[Intel-gfx] ✓ Fi.CI.BAT: success for Add support for Gen 11 pipe color features (rev5)

2019-01-07 Thread Patchwork
== Series Details == Series: Add support for Gen 11 pipe color features (rev5) URL : https://patchwork.freedesktop.org/series/51408/ State : success == Summary == CI Bug Log - changes from CI_DRM_5372 -> Patchwork_11205 Summary ---

Re: [Intel-gfx] [PATCH] drm/i915/cnl: Fix CNL macros for Voltage Swing programming

2019-01-07 Thread Jani Nikula
On Mon, 07 Jan 2019, Aditya Swarup wrote: > On Mon, Dec 31, 2018 at 11:03:22AM +0200, Jani Nikula wrote: >> On Fri, 14 Dec 2018, Aditya Swarup wrote: >> > CNL macros for register groups CNL_PORT_TX_DW2_* / CNL_PORT_TX_DW5_* are >> > configured incorrectly wrt definition of _CNL_PORT_TX_DW_GRP.

Re: [Intel-gfx] [v2 14/14] drivers/video: Constantify function argument for HDMI infoframe log

2019-01-07 Thread Shankar, Uma
>-Original Message- >From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf Of >Sharma, Shashank >Sent: Friday, December 21, 2018 2:28 PM >To: Shankar, Uma ; intel-gfx@lists.freedesktop.org; >dri-de...@lists.freedesktop.org >Cc: Syrjala, Ville ; Lankhorst, Maarten >

Re: [Intel-gfx] [PATCH] drm/i915/cnl: Fix CNL macros for Voltage Swing programming

2019-01-07 Thread Aditya Swarup
On Mon, Dec 31, 2018 at 11:03:22AM +0200, Jani Nikula wrote: > On Fri, 14 Dec 2018, Aditya Swarup wrote: > > CNL macros for register groups CNL_PORT_TX_DW2_* / CNL_PORT_TX_DW5_* are > > configured incorrectly wrt definition of _CNL_PORT_TX_DW_GRP. > > What a mess. > > Please fix this by making

[Intel-gfx] [v5 6/6] drm/i915/icl: Add degamma and gamma lut size to gen11 caps

2019-01-07 Thread Uma Shankar
Add the degamma and gamma lut sizes to gen11 capability structure. Note: Currently this doesn't account for the extended range gamma entries and this will be addressed with new segmented gamma ABI in a future patch. v2: Reorder the patch as per Maarten's suggestion. v3: Rebase v4: Updated

[Intel-gfx] [v5 5/6] drm/i915/icl: Enable ICL Pipe CSC block

2019-01-07 Thread Uma Shankar
Enable ICL pipe csc hardware. CSC block is enabled in CSC_MODE register instead of PLANE_COLOR_CTL. ToDO: Extend the ABI to accept 32 bit coefficient values instead of 16bit for future platforms. v2: Addressed Maarten's review comments. v3: Addressed Matt's review comments. Removed rmw patterns

[Intel-gfx] [v5 3/6] drm/i915: Remove gamma_mode state variable

2019-01-07 Thread Uma Shankar
Removed crtc state variable for gamma mode as it's redundant since currently we have fixed modes on respective hardware platforms. This was making this state variable irrelevant. v2: Updated logic to check for split gamma mode. This is moved to a separate patch and handled as part of

[Intel-gfx] [v5 0/6] Add support for Gen 11 pipe color features

2019-01-07 Thread Uma Shankar
This patch series adds support for Gen11 pipe degamma, CSC and gamma hardware blocks. CRC checks are not working for 10bit gamma but works for 8bit pallete modes which seems to be due to some rounding errors in pipe. ToDo: Support for Multi Segmented Gamma will be added later. v2: Addressed

[Intel-gfx] [v5 4/6] drm/i915/icl: Add icl pipe degamma and gamma support

2019-01-07 Thread Uma Shankar
Add support for icl pipe degamma and gamma. v2: Removed a POSTING_READ and corrected the Bit Definition as per Maarten's comments. v3: Addressed Matt's review comments. Removed rmw patterns as suggested by Matt. v4: Fixed Matt's review comments. v5: Corrected macro alignment as per Jani

[Intel-gfx] [v5 1/6] drm/i915: Check for Null for color lut callbacks

2019-01-07 Thread Uma Shankar
Check if de-gamma/gamma lut callback is assigned before calling the same. Signed-off-by: Uma Shankar --- drivers/gpu/drm/i915/intel_color.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_color.c b/drivers/gpu/drm/i915/intel_color.c index

[Intel-gfx] [v5 2/6] drm/i915: Sanitize crtc gamma mode

2019-01-07 Thread Uma Shankar
Sanitize crtc gamma mode and update the mode in driver in case BIOS has setup a different gamma mode as to what is expected by driver. There is restriction on HSW platform not to read/write color LUT's if ips is enabled. Handled the same accordingly. Credits-to: Matt Roper Signed-off-by: Uma

Re: [Intel-gfx] [v2 04/14] drm: Parse Colorimetry data block from EDID

2019-01-07 Thread Shankar, Uma
>-Original Message- >From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf Of >Sharma, Shashank >Sent: Tuesday, January 8, 2019 12:27 PM >To: Shankar, Uma ; intel-gfx@lists.freedesktop.org; >dri-de...@lists.freedesktop.org >Cc: Syrjala, Ville ; Lankhorst, Maarten >

Re: [Intel-gfx] [v2 11/14] drm/i915: Add HLG EOTF

2019-01-07 Thread Shankar, Uma
>-Original Message- >From: Sharma, Shashank >Sent: Friday, December 21, 2018 2:17 PM >To: Shankar, Uma ; intel-gfx@lists.freedesktop.org; >dri-de...@lists.freedesktop.org >Cc: Lankhorst, Maarten ; Syrjala, Ville >; brian.star...@arm.com; Ville Syrjälä > >Subject: Re: [v2 11/14] drm/i915:

Re: [Intel-gfx] [v2 04/14] drm: Parse Colorimetry data block from EDID

2019-01-07 Thread Sharma, Shashank
On 1/8/2019 12:10 PM, Shankar, Uma wrote: -Original Message- From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf Of Sharma, Shashank Sent: Thursday, December 20, 2018 11:54 PM To: Shankar, Uma ; intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org

Re: [Intel-gfx] [v2 09/14] drm/i915: Write HDR infoframe and send to panel

2019-01-07 Thread Shankar, Uma
>-Original Message- >From: Sharma, Shashank >Sent: Friday, December 21, 2018 2:14 PM >To: Shankar, Uma ; intel-gfx@lists.freedesktop.org; >dri-de...@lists.freedesktop.org >Cc: Lankhorst, Maarten ; Syrjala, Ville >; brian.star...@arm.com >Subject: Re: [v2 09/14] drm/i915: Write HDR

Re: [Intel-gfx] [v2 08/14] drm: Enable HDR infoframe support

2019-01-07 Thread Shankar, Uma
>-Original Message- >From: Sharma, Shashank >Sent: Friday, December 21, 2018 2:11 PM >To: Shankar, Uma ; intel-gfx@lists.freedesktop.org; >dri-de...@lists.freedesktop.org >Cc: Lankhorst, Maarten ; Syrjala, Ville >; brian.star...@arm.com >Subject: Re: [v2 08/14] drm: Enable HDR infoframe

Re: [Intel-gfx] [v2 07/14] drm: Implement HDR source metadata set and get property handling

2019-01-07 Thread Shankar, Uma
>-Original Message- >From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf Of >Sharma, Shashank >Sent: Friday, December 21, 2018 12:04 AM >To: Shankar, Uma ; intel-gfx@lists.freedesktop.org; >dri-de...@lists.freedesktop.org >Cc: Syrjala, Ville ; Lankhorst, Maarten >

Re: [Intel-gfx] [v2 05/14] drm/i915: Attach HDR metadata property to connector

2019-01-07 Thread Shankar, Uma
>-Original Message- >From: Sharma, Shashank >Sent: Thursday, December 20, 2018 11:56 PM >To: Shankar, Uma ; intel-gfx@lists.freedesktop.org; >dri-de...@lists.freedesktop.org >Cc: Lankhorst, Maarten ; Syrjala, Ville >; brian.star...@arm.com >Subject: Re: [v2 05/14] drm/i915: Attach HDR

Re: [Intel-gfx] [v2 04/14] drm: Parse Colorimetry data block from EDID

2019-01-07 Thread Shankar, Uma
>-Original Message- >From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf Of >Sharma, Shashank >Sent: Thursday, December 20, 2018 11:54 PM >To: Shankar, Uma ; intel-gfx@lists.freedesktop.org; >dri-de...@lists.freedesktop.org >Cc: Syrjala, Ville ; Lankhorst, Maarten

Re: [Intel-gfx] [v2 03/14] drm: Parse HDR metadata info from EDID

2019-01-07 Thread Shankar, Uma
>-Original Message- >From: Sharma, Shashank >Sent: Tuesday, January 8, 2019 11:26 AM >To: Shankar, Uma ; intel-gfx@lists.freedesktop.org; >dri-de...@lists.freedesktop.org >Cc: Syrjala, Ville ; Lankhorst, Maarten > >Subject: Re: [v2 03/14] drm: Parse HDR metadata info from EDID > >Regards

Re: [Intel-gfx] [v2 03/14] drm: Parse HDR metadata info from EDID

2019-01-07 Thread Sharma, Shashank
Regards Shashank On 1/8/2019 11:10 AM, Shankar, Uma wrote: -Original Message- From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf Of Sharma, Shashank Sent: Thursday, December 20, 2018 11:47 PM To: Shankar, Uma ; intel-gfx@lists.freedesktop.org;

Re: [Intel-gfx] [v2 03/14] drm: Parse HDR metadata info from EDID

2019-01-07 Thread Shankar, Uma
>-Original Message- >From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf Of >Sharma, Shashank >Sent: Thursday, December 20, 2018 11:47 PM >To: Shankar, Uma ; intel-gfx@lists.freedesktop.org; >dri-de...@lists.freedesktop.org >Cc: Syrjala, Ville ; Lankhorst, Maarten

Re: [Intel-gfx] [v2 02/14] drm: Add CEA extended tag blocks and HDR bitfield macros

2019-01-07 Thread Shankar, Uma
>-Original Message- >From: Sharma, Shashank >Sent: Thursday, December 20, 2018 11:38 PM >To: Shankar, Uma ; intel-gfx@lists.freedesktop.org; >dri-de...@lists.freedesktop.org >Cc: Lankhorst, Maarten ; Syrjala, Ville >; brian.star...@arm.com >Subject: Re: [v2 02/14] drm: Add CEA extended

Re: [Intel-gfx] [v2 01/14] drm: Add HDR source metadata property

2019-01-07 Thread Shankar, Uma
>-Original Message- >From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf Of >Sharma, Shashank >Sent: Thursday, December 20, 2018 11:21 PM >To: Shankar, Uma ; intel-gfx@lists.freedesktop.org; >dri-de...@lists.freedesktop.org >Cc: Syrjala, Ville ; Lankhorst, Maarten

[Intel-gfx] linux-next: build failure after merge of the drm-misc tree

2019-01-07 Thread Stephen Rothwell
Use private obj helpers for dm_atomic_state") from Linus' tree (merged during the merge window). Its not obvious how to fix this up, so I have used the drm-misc tree from next-20190107 for today. -- Cheers, Stephen Rothwell ___ Intel-gfx mailing list Intel-gf

[Intel-gfx] linux-next: build warning after merge of the drm-misc tree

2019-01-07 Thread Stephen Rothwell
Hi all, After merging the drm-misc tree, today's linux-next build (arm multi_v7_defconfig) produced this warning: drivers/gpu/drm/msm/msm_gem.c: In function 'describe_fence': drivers/gpu/drm/msm/msm_gem.c:761:36: warning: format '%u' expects argument of type 'unsigned int', but argument 6 has

[Intel-gfx] linux-next: build warnings after merge of the drm-intel tree

2019-01-07 Thread Stephen Rothwell
Hi all, After merging the drm-intel tree, today's linux-next build (x86_64 allmodconfig) produced these warnings: In file included from include/linux/printk.h:7, from include/linux/kernel.h:14, from include/asm-generic/bug.h:18, from

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/selftests: Mark the whole mock device as DMA capable (rev2)

2019-01-07 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Mark the whole mock device as DMA capable (rev2) URL : https://patchwork.freedesktop.org/series/54825/ State : success == Summary == CI Bug Log - changes from CI_DRM_5369_full -> Patchwork_11204_full

Re: [Intel-gfx] [PATCH 21/39] drm/i915/guc: Disable global reset

2019-01-07 Thread Daniele Ceraolo Spurio
On 01/07/2019 01:35 PM, Chris Wilson wrote: Quoting Daniele Ceraolo Spurio (2019-01-07 21:28:48) On 01/07/2019 10:50 AM, Chris Wilson wrote: Quoting Daniele Ceraolo Spurio (2019-01-07 18:31:52) Were you already planning/working on something along the lines of the possible solution

Re: [Intel-gfx] [PATCH 21/39] drm/i915/guc: Disable global reset

2019-01-07 Thread Chris Wilson
Quoting Daniele Ceraolo Spurio (2019-01-07 21:28:48) > > On 01/07/2019 10:50 AM, Chris Wilson wrote: > > Quoting Daniele Ceraolo Spurio (2019-01-07 18:31:52) > >> > >> Were you already > >> planning/working on something along the lines of the possible solution > >> mentioned in the commit

Re: [Intel-gfx] [PATCH 21/39] drm/i915/guc: Disable global reset

2019-01-07 Thread Daniele Ceraolo Spurio
On 01/07/2019 10:50 AM, Chris Wilson wrote: Quoting Daniele Ceraolo Spurio (2019-01-07 18:31:52) On 01/02/2019 01:41 AM, Chris Wilson wrote: The guc (and huc) currently inexcruitably depend on struct_mutex for device reinitialisation from inside the reset, and indeed taking any mutex here

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Reduce i915_request_alloc retirement to local context

2019-01-07 Thread Patchwork
== Series Details == Series: drm/i915: Reduce i915_request_alloc retirement to local context URL : https://patchwork.freedesktop.org/series/54820/ State : success == Summary == CI Bug Log - changes from CI_DRM_5369_full -> Patchwork_11202_full

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/debugfs: store rotation string buffer on stack

2019-01-07 Thread Patchwork
== Series Details == Series: drm/i915/debugfs: store rotation string buffer on stack URL : https://patchwork.freedesktop.org/series/54816/ State : success == Summary == CI Bug Log - changes from CI_DRM_5369_full -> Patchwork_11201_full

Re: [Intel-gfx] [PATCH] drm/i915/icl: Apply WaEnablePreemptionGranularityControlByUMD

2019-01-07 Thread Matt Roper
On Mon, Jan 07, 2019 at 01:23:50PM +0100, Michał Winiarski wrote: > On Mon, Jan 07, 2019 at 01:01:16PM +0200, Joonas Lahtinen wrote: > > Quoting José Roberto de Souza (2019-01-04 19:37:00) > > > According to Workaround database ICL also needs > > > WaEnablePreemptionGranularityControlByUMD, to

Re: [Intel-gfx] [PATCH 21/39] drm/i915/guc: Disable global reset

2019-01-07 Thread Chris Wilson
Quoting Daniele Ceraolo Spurio (2019-01-07 18:31:52) > > > On 01/02/2019 01:41 AM, Chris Wilson wrote: > > The guc (and huc) currently inexcruitably depend on struct_mutex for > > device reinitialisation from inside the reset, and indeed taking any > > mutex here is verboten (as we must be able

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Mark the whole mock device as DMA capable (rev2)

2019-01-07 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Mark the whole mock device as DMA capable (rev2) URL : https://patchwork.freedesktop.org/series/54825/ State : success == Summary == CI Bug Log - changes from CI_DRM_5369 -> Patchwork_11204

Re: [Intel-gfx] [PATCH 21/39] drm/i915/guc: Disable global reset

2019-01-07 Thread Daniele Ceraolo Spurio
On 01/02/2019 01:41 AM, Chris Wilson wrote: The guc (and huc) currently inexcruitably depend on struct_mutex for device reinitialisation from inside the reset, and indeed taking any mutex here is verboten (as we must be able to reset from underneath any of our mutexes). That makes recovering

Re: [Intel-gfx] drm/i915: Watchdog timeout: IRQ handler for gen8+

2019-01-07 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-01-07 16:58:24) > And finally there is one programming restriction which says: > > * SW must not preempt the workload which has watchdog enabled. Either > it must: > > a) disable preemption for that workload completely, or > b) disable the watchdog via mmio write

[Intel-gfx] [PATCH i-g-t v3] tests/gem_shrink: Exercise OOM and other routes to shrinking in reasonable time

2019-01-07 Thread Tvrtko Ursulin
From: Tvrtko Ursulin A set of subtests which exercises different paths to our shrinker code (including the OOM killer) in predictable and reasonable time budget. v2: * Fix blacklist regexp. (Petri Latvala) v3: * Skip userptr test if not userptr support. Signed-off-by: Tvrtko Ursulin ---

[Intel-gfx] [PATCH] drm/i915/selftests: Mark the whole mock device as DMA capable

2019-01-07 Thread Chris Wilson
Being a mock device, we suffer no DMA restrictions, so set the coherent mask to 64b. v2: Fix up mock_huge_selftests Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld --- drivers/gpu/drm/i915/selftests/huge_pages.c | 4 drivers/gpu/drm/i915/selftests/mock_gem_device.c | 2 +- 2

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Mark the whole mock device as DMA capable

2019-01-07 Thread Chris Wilson
Quoting Matthew Auld (2019-01-07 18:01:18) > On Mon, 7 Jan 2019 at 16:28, Chris Wilson wrote: > > > > Being a mock device, we suffer no DMA restrictions, so set the coherent > > mask to 64b. > > > > Signed-off-by: Chris Wilson > > Care to get rid of the call in

Re: [Intel-gfx] [PULL] topic/drmp-cleanup for drm-misc-next and drm-intel-next-queued

2019-01-07 Thread Maxime Ripard
Hi Jani, On Wed, Jan 02, 2019 at 12:00:49PM +0200, Jani Nikula wrote: > I embarked on removing drmP.h includes from i915, but that requires a > bunch of drm header cleanup to add relevant includes and forward > declarations. Due to the timing, propagating the patches back to i915 > would take

[Intel-gfx] [PULL] drm-misc-next

2019-01-07 Thread Maxime Ripard
Hi Dave, Daniel, Here is the first PR for 5.1 for drm-misc-next. This is my first PR ever for drm-misc, so please let me know if I screwed up somehow :) Thanks! Maxime drm-misc-next-2019-01-07-1: drm-misc-next for 5.1: UAPI Changes: Cross-subsystem Changes: - Turn dma-buf fence sequence

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Mark the whole mock device as DMA capable

2019-01-07 Thread Matthew Auld
On Mon, 7 Jan 2019 at 16:28, Chris Wilson wrote: > > Being a mock device, we suffer no DMA restrictions, so set the coherent > mask to 64b. > > Signed-off-by: Chris Wilson Care to get rid of the call in i915_gem_huge_page_mock_selftests? Reviewed-by: Matthew Auld

[Intel-gfx] [PATCH i-g-t v2] tests/gem_shrink: Exercise OOM and other routes to shrinking in reasonable time

2019-01-07 Thread Tvrtko Ursulin
From: Tvrtko Ursulin A set of subtests which exercises different paths to our shrinker code (including the OOM killer) in predictable and reasonable time budget. v2: * Fix blacklist regexp. (Petri Latvala) Signed-off-by: Tvrtko Ursulin --- lib/igt_core.c| 19 ++

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] tests/gem_shrink: Exercise OOM and other routes to shrinking in reasonable time

2019-01-07 Thread Tvrtko Ursulin
On 07/01/2019 11:28, Petri Latvala wrote: On Mon, Jan 07, 2019 at 11:12:30AM +, Tvrtko Ursulin wrote: On 07/01/2019 11:01, Petri Latvala wrote: On Fri, Jan 04, 2019 at 03:37:09PM +, Tvrtko Ursulin wrote: diff --git a/tests/intel-ci/blacklist.txt b/tests/intel-ci/blacklist.txt index

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Mark the whole mock device as DMA capable

2019-01-07 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Mark the whole mock device as DMA capable URL : https://patchwork.freedesktop.org/series/54825/ State : success == Summary == CI Bug Log - changes from CI_DRM_5369 -> Patchwork_11203 Summary

Re: [Intel-gfx] drm/i915: Watchdog timeout: DRM kernel interface to set the timeout

2019-01-07 Thread Tvrtko Ursulin
On 07/01/2019 17:00, Tvrtko Ursulin wrote: On 07/01/2019 12:38, Tvrtko Ursulin wrote: [snip] +#define GEN8_TIMESTAMP_CNTS_PER_USEC 12 +#define GEN9_LP_TIMESTAMP_CNTS_PER_USEC 19 +static inline u32 cs_timestamp_in_us(struct drm_i915_private *dev_priv) +{ +    u32 cs_timestamp_base =

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [01/46] drm/i915: Return immediately if trylock fails for direct-reclaim

2019-01-07 Thread Chris Wilson
Quoting Patchwork (2019-01-07 17:10:25) > Possible regressions > > * igt@i915_missed_irq: > - shard-snb: PASS -> FAIL > - shard-kbl: PASS -> FAIL > - shard-hsw: PASS -> FAIL > - shard-skl: PASS -> FAIL > - shard-glk:

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [01/46] drm/i915: Return immediately if trylock fails for direct-reclaim

2019-01-07 Thread Patchwork
== Series Details == Series: series starting with [01/46] drm/i915: Return immediately if trylock fails for direct-reclaim URL : https://patchwork.freedesktop.org/series/54803/ State : failure == Summary == CI Bug Log - changes from CI_DRM_5368_full -> Patchwork_11200_full

Re: [Intel-gfx] drm/i915: Watchdog timeout: DRM kernel interface to set the timeout

2019-01-07 Thread Tvrtko Ursulin
On 07/01/2019 12:38, Tvrtko Ursulin wrote: [snip] +#define GEN8_TIMESTAMP_CNTS_PER_USEC 12 +#define GEN9_LP_TIMESTAMP_CNTS_PER_USEC 19 +static inline u32 cs_timestamp_in_us(struct drm_i915_private *dev_priv) +{ +    u32 cs_timestamp_base = dev_priv->cs_timestamp_base; + +    if

Re: [Intel-gfx] drm/i915: Watchdog timeout: IRQ handler for gen8+

2019-01-07 Thread Tvrtko Ursulin
On 07/01/2019 13:57, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-01-07 13:43:29) On 07/01/2019 11:58, Tvrtko Ursulin wrote: [snip] Note about future interaction with preemption: Preemption could happen in a command sequence prior to watchdog counter getting disabled, resulting in

[Intel-gfx] [PATCH i-g-t] intel-ci/blacklist: Exclude gem_exec_parse lri

2019-01-07 Thread Chris Wilson
These exercise a certain HW misfeature, no longer protected by the kernel cmdparser due to obsolete userspace requirements. Signed-off-by: Chris Wilson Cc: Joonas Lahtinen --- tests/intel-ci/blacklist.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/intel-ci/blacklist.txt

[Intel-gfx] [PATCH] drm/i915/selftests: Mark the whole mock device as DMA capable

2019-01-07 Thread Chris Wilson
Being a mock device, we suffer no DMA restrictions, so set the coherent mask to 64b. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/selftests/mock_gem_device.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/selftests/mock_gem_device.c

[Intel-gfx] ✓ Fi.CI.IGT: success for ACPI/i915: Add support for PMIC MIPI sequence elements (rev2)

2019-01-07 Thread Patchwork
== Series Details == Series: ACPI/i915: Add support for PMIC MIPI sequence elements (rev2) URL : https://patchwork.freedesktop.org/series/54050/ State : success == Summary == CI Bug Log - changes from CI_DRM_5368_full -> Patchwork_11199_full

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Reduce i915_request_alloc retirement to local context

2019-01-07 Thread Patchwork
== Series Details == Series: drm/i915: Reduce i915_request_alloc retirement to local context URL : https://patchwork.freedesktop.org/series/54820/ State : success == Summary == CI Bug Log - changes from CI_DRM_5369 -> Patchwork_11202

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/debugfs: store rotation string buffer on stack

2019-01-07 Thread Patchwork
== Series Details == Series: drm/i915/debugfs: store rotation string buffer on stack URL : https://patchwork.freedesktop.org/series/54816/ State : success == Summary == CI Bug Log - changes from CI_DRM_5369 -> Patchwork_11201 Summary

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Reduce i915_request_alloc retirement to local context

2019-01-07 Thread Patchwork
== Series Details == Series: drm/i915: Reduce i915_request_alloc retirement to local context URL : https://patchwork.freedesktop.org/series/54820/ State : warning == Summary == $ dim checkpatch origin/drm-tip ceb365430726 drm/i915: Reduce i915_request_alloc retirement to local context -:11:

Re: [Intel-gfx] [PATCH v6 3/4] ACPI / PMIC: Add generic intel_soc_pmic_exec_mipi_pmic_seq_element handling

2019-01-07 Thread Andy Shevchenko
On Mon, Jan 07, 2019 at 12:15:55PM +0100, Hans de Goede wrote: > Most PMIC-s use only a single i2c-address, so after verifying the > i2c-address matches, we can simply pass the call to regmap_update_bits. > > This commit adds support for this and hooks this up for the xpower AXP288 > PMIC by

Re: [Intel-gfx] [PATCH v6 2/4] ACPI / PMIC: Implement exec_mipi_pmic_seq_element for CHT Whiskey Cove PMIC

2019-01-07 Thread Andy Shevchenko
On Mon, Jan 07, 2019 at 12:15:54PM +0100, Hans de Goede wrote: > Implement the exec_mipi_pmic_seq_element callback for the CHT Whiskey Cove > PMIC. > > On some CHT devices this fixes the LCD panel not lighting up when it was > not initialized by the GOP, because an external monitor was plugged in

Re: [Intel-gfx] [PATCH v6 1/4] ACPI / PMIC: Add support for executing PMIC MIPI sequence elements

2019-01-07 Thread Andy Shevchenko
On Mon, Jan 07, 2019 at 12:15:53PM +0100, Hans de Goede wrote: > DSI LCD panels describe an initialization sequence in the Video BIOS > Tables using so called MIPI sequences. One possible element in these > sequences is a PMIC specific element of 15 bytes. > > Although this is not really an ACPI

Re: [Intel-gfx] [PATCH v6 3/4] ACPI / PMIC: Add generic intel_soc_pmic_exec_mipi_pmic_seq_element handling

2019-01-07 Thread Ville Syrjälä
On Mon, Jan 07, 2019 at 12:15:55PM +0100, Hans de Goede wrote: > Most PMIC-s use only a single i2c-address, so after verifying the > i2c-address matches, we can simply pass the call to regmap_update_bits. > > This commit adds support for this and hooks this up for the xpower AXP288 > PMIC by

Re: [Intel-gfx] [PATCH v6 4/4] drm/i915/intel_dsi_vbt: Add support for PMIC MIPI sequences

2019-01-07 Thread Ville Syrjälä
On Mon, Jan 07, 2019 at 12:15:56PM +0100, Hans de Goede wrote: > Add support for PMIC MIPI sequences using the new > intel_soc_pmic_exec_mipi_pmic_seq_element function. > > This fixes the DSI LCD panel not lighting up when not initialized by the > GOP (because an external monitor was connected)

[Intel-gfx] [PATCH] drm/i915: Reduce i915_request_alloc retirement to local context

2019-01-07 Thread Chris Wilson
In the continual quest to reduce the amount of global work required when submitting requests, replace i915_retire_requests() after allocation failure to retiring just our ring. References: 11abf0c5a021 ("drm/i915: Limit the backpressure for i915_request allocation") Signed-off-by: Chris Wilson

Re: [Intel-gfx] [PATCH] drm/i915/debugfs: store rotation string buffer on stack

2019-01-07 Thread Chris Wilson
Quoting Jani Nikula (2019-01-07 14:51:49) > Minimal change to nuke the static buf. > > Signed-off-by: Jani Nikula I'm sure there's a grander plan, Reviewed-by: Chris Wilson -Chris ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org

[Intel-gfx] [PATCH] drm/i915/debugfs: store rotation string buffer on stack

2019-01-07 Thread Jani Nikula
Minimal change to nuke the static buf. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/i915_debugfs.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c index c77326a7d058..95813e21ae02

Re: [Intel-gfx] [PATCH v5 2/3] drm/i915: Move on the new pm runtime interface

2019-01-07 Thread Rafael J. Wysocki
On Mon, Jan 7, 2019 at 3:04 PM Vincent Guittot wrote: > > Hi Tvrtko, > > On Mon, 31 Dec 2018 at 13:32, Tvrtko Ursulin > wrote: > > > > > > On 21/12/2018 13:26, Vincent Guittot wrote: > > > On Fri, 21 Dec 2018 at 12:33, Tvrtko Ursulin > > [snip] > > > >> > > >> If it is always monotonic, then

Re: [Intel-gfx] [PATCH 01/46] drm/i915: Return immediately if trylock fails for direct-reclaim

2019-01-07 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-01-07 14:00:25) > > On 07/01/2019 11:54, Chris Wilson wrote: > > Ignore trying to shrink from i915 if we fail to acquire the struct_mutex > > in the shrinker while performing direct-reclaim. The trade-off being > > (much) lower latency for non-i915 clients at an

Re: [Intel-gfx] [PATCH v5 2/3] drm/i915: Move on the new pm runtime interface

2019-01-07 Thread Vincent Guittot
Hi Tvrtko, On Mon, 31 Dec 2018 at 13:32, Tvrtko Ursulin wrote: > > > On 21/12/2018 13:26, Vincent Guittot wrote: > > On Fri, 21 Dec 2018 at 12:33, Tvrtko Ursulin [snip] > >> > >> If it is always monotonic, then worst case we report one wrong sample, > >> which I guess is still not ideal since

Re: [Intel-gfx] [PATCH 01/46] drm/i915: Return immediately if trylock fails for direct-reclaim

2019-01-07 Thread Tvrtko Ursulin
On 07/01/2019 11:54, Chris Wilson wrote: Ignore trying to shrink from i915 if we fail to acquire the struct_mutex in the shrinker while performing direct-reclaim. The trade-off being (much) lower latency for non-i915 clients at an increased risk of being unable to obtain a page from

Re: [Intel-gfx] drm/i915: Watchdog timeout: IRQ handler for gen8+

2019-01-07 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-01-07 13:43:29) > > On 07/01/2019 11:58, Tvrtko Ursulin wrote: > > [snip] > > >> Note about future interaction with preemption: Preemption could happen > >> in a command sequence prior to watchdog counter getting disabled, > >> resulting in watchdog being triggered

Re: [Intel-gfx] drm/i915: Watchdog timeout: DRM kernel interface to set the timeout

2019-01-07 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-01-07 13:39:24) > > On 07/01/2019 12:50, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2019-01-07 12:38:47) > >> On 05/01/2019 02:39, Carlos Santa wrote: > >>> +/* Return the timer count threshold in microseconds. */ > >>> +int i915_gem_context_get_watchdog(struct

Re: [Intel-gfx] drm/i915: Watchdog timeout: IRQ handler for gen8+

2019-01-07 Thread Tvrtko Ursulin
On 07/01/2019 11:58, Tvrtko Ursulin wrote: [snip] Note about future interaction with preemption: Preemption could happen in a command sequence prior to watchdog counter getting disabled, resulting in watchdog being triggered following preemption (e.g. when watchdog had been enabled in the low

Re: [Intel-gfx] drm/i915: Watchdog timeout: DRM kernel interface to set the timeout

2019-01-07 Thread Tvrtko Ursulin
On 07/01/2019 12:50, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-01-07 12:38:47) On 05/01/2019 02:39, Carlos Santa wrote: +/* Return the timer count threshold in microseconds. */ +int i915_gem_context_get_watchdog(struct i915_gem_context *ctx, + struct

Re: [Intel-gfx] "flip_done timed out" messages causing huge increase in boot time

2019-01-07 Thread Ville Syrjälä
On Sat, Jan 05, 2019 at 12:47:12AM +0100, Daniel Kamil Kozar wrote: > Hello. > After upgrading the kernel to 4.20, I noticed that the boot time > increased from about 5 seconds to 25 seconds. My machine is an Asus > K53SV with an Intel i7-2630QM, i.e. Sandy Bridge. I have an external > display

Re: [Intel-gfx] [PATCH 03/46] drm/i915: Track all held rpm wakerefs

2019-01-07 Thread Chris Wilson
Quoting Mika Kuoppala (2019-01-07 13:14:00) > Chris Wilson writes: > > @@ -2011,6 +2011,8 @@ static int i915_drm_suspend_late(struct drm_device > > *dev, bool hibernation) > > > > out: > > enable_rpm_wakeref_asserts(dev_priv); > > + if (!dev_priv->uncore.user_forcewake.count) > > +

Re: [Intel-gfx] [PATCH 03/46] drm/i915: Track all held rpm wakerefs

2019-01-07 Thread Mika Kuoppala
Chris Wilson writes: > Everytime we take a wakeref, record the stack trace of where it was > taken; clearing the set if we ever drop back to no owners. For debugging > a rpm leak, we can look at all the current wakerefs and check if they > have a matching rpm_put. > > Signed-off-by: Chris Wilson

Re: [Intel-gfx] drm/i915: Watchdog timeout: IRQ handler for gen8+

2019-01-07 Thread Tvrtko Ursulin
On 07/01/2019 13:02, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-01-07 12:58:39) On 07/01/2019 12:16, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-01-07 11:58:13) On 05/01/2019 02:39, Carlos Santa wrote: +static void gen8_watchdog_irq_handler(unsigned long data) +{ + struct

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [01/46] drm/i915: Return immediately if trylock fails for direct-reclaim

2019-01-07 Thread Patchwork
== Series Details == Series: series starting with [01/46] drm/i915: Return immediately if trylock fails for direct-reclaim URL : https://patchwork.freedesktop.org/series/54803/ State : success == Summary == CI Bug Log - changes from CI_DRM_5368 -> Patchwork_11200

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [01/46] drm/i915: Return immediately if trylock fails for direct-reclaim

2019-01-07 Thread Patchwork
== Series Details == Series: series starting with [01/46] drm/i915: Return immediately if trylock fails for direct-reclaim URL : https://patchwork.freedesktop.org/series/54803/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Return

Re: [Intel-gfx] drm/i915: Watchdog timeout: IRQ handler for gen8+

2019-01-07 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-01-07 12:58:39) > > On 07/01/2019 12:16, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2019-01-07 11:58:13) > >> On 05/01/2019 02:39, Carlos Santa wrote: > >>> +static void gen8_watchdog_irq_handler(unsigned long data) > >>> +{ > >>> + struct intel_engine_cs

Re: [Intel-gfx] drm/i915/watchdog: move emit_stop_watchdog until the very end of the ring commands

2019-01-07 Thread Tvrtko Ursulin
On 07/01/2019 12:54, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-01-07 12:50:24) On 05/01/2019 02:40, Carlos Santa wrote: +static void gen8_emit_breadcrumb_vcs(struct i915_request *request, u32 *cs) +{ + /* w/a: bit 5 needs to be zero for MI_FLUSH_DW address. */ +

Re: [Intel-gfx] drm/i915: Watchdog timeout: IRQ handler for gen8+

2019-01-07 Thread Tvrtko Ursulin
On 07/01/2019 12:16, Chris Wilson wrote: Quoting Tvrtko Ursulin (2019-01-07 11:58:13) Hi, This series has not been recognized by Patchwork as such, nor are the patches numbered. Have you used git format-patch - --cover-letter and git send-email to send it out? Rest inline. On 05/01/2019

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] tests/gem_shrink: Exercise OOM and other routes to shrinking in reasonable time

2019-01-07 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-01-07 12:52:28) > > On 07/01/2019 12:31, Chris Wilson wrote: > > Quoting Michał Winiarski (2019-01-07 12:27:07) > >> On Fri, Jan 04, 2019 at 03:37:09PM +, Tvrtko Ursulin wrote: > >>> From: Tvrtko Ursulin > >>> > >>> A set of subtests which exercises different

Re: [Intel-gfx] drm/i915/watchdog: move emit_stop_watchdog until the very end of the ring commands

2019-01-07 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-01-07 12:50:24) > > On 05/01/2019 02:40, Carlos Santa wrote: > > +static void gen8_emit_breadcrumb_vcs(struct i915_request *request, u32 *cs) > > +{ > > + /* w/a: bit 5 needs to be zero for MI_FLUSH_DW address. */ > > + BUILD_BUG_ON(I915_GEM_HWS_INDEX_ADDR &

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] tests/gem_shrink: Exercise OOM and other routes to shrinking in reasonable time

2019-01-07 Thread Tvrtko Ursulin
On 07/01/2019 12:31, Chris Wilson wrote: Quoting Michał Winiarski (2019-01-07 12:27:07) On Fri, Jan 04, 2019 at 03:37:09PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin A set of subtests which exercises different paths to our shrinker code (including the OOM killer) in predictable and

Re: [Intel-gfx] drm/i915/watchdog: move emit_stop_watchdog until the very end of the ring commands

2019-01-07 Thread Tvrtko Ursulin
On 05/01/2019 02:40, Carlos Santa wrote: From: Michel Thierry On command streams that could potentially hang the GPU after a last flush command, it's best not to cancel the watchdog until after all commands have executed. Patch shared by Michel Thierry through IIRC after reproduction on

Re: [Intel-gfx] drm/i915: Watchdog timeout: DRM kernel interface to set the timeout

2019-01-07 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-01-07 12:38:47) > On 05/01/2019 02:39, Carlos Santa wrote: > > +/* Return the timer count threshold in microseconds. */ > > +int i915_gem_context_get_watchdog(struct i915_gem_context *ctx, > > + struct drm_i915_gem_context_param *args) > >

[Intel-gfx] ✓ Fi.CI.BAT: success for ACPI/i915: Add support for PMIC MIPI sequence elements (rev2)

2019-01-07 Thread Patchwork
== Series Details == Series: ACPI/i915: Add support for PMIC MIPI sequence elements (rev2) URL : https://patchwork.freedesktop.org/series/54050/ State : success == Summary == CI Bug Log - changes from CI_DRM_5368 -> Patchwork_11199 Summary

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/46] drm/i915: Return immediately if trylock fails for direct-reclaim

2019-01-07 Thread Patchwork
== Series Details == Series: series starting with [01/46] drm/i915: Return immediately if trylock fails for direct-reclaim URL : https://patchwork.freedesktop.org/series/54803/ State : warning == Summary == $ dim checkpatch origin/drm-tip 7b61c9e7b9d7 drm/i915: Return immediately if trylock

[Intel-gfx] [PATCH i-g-t] i915/gem_ctx_isolation: Ignore the low bits of BB_OFFSET

2019-01-07 Thread Chris Wilson
On Skylake, BB_OFFSET seems to be unstable. Since this is an offset into the batch at the time of CS execution, it should be actively written to as we read from the register so allow it a qword of discrepancy (since the CS should be reading in qwords). This still allows us to detect dirt across

Re: [Intel-gfx] drm/i915: Only process VCS2 only when supported

2019-01-07 Thread Tvrtko Ursulin
On 05/01/2019 02:39, Carlos Santa wrote: Not checking for BSD2 causes a segfault on GPU revs with no h/w support for the extra media engines. Segfault on ULX GT2 (0x591e) follows: Patch shared by Michel Thierry on IIRC. [ 468.625970] BUG: unable to handle kernel NULL pointer dereference at

Re: [Intel-gfx] drm/i915: Watchdog timeout: DRM kernel interface to set the timeout

2019-01-07 Thread Tvrtko Ursulin
On 05/01/2019 02:39, Carlos Santa wrote: From: Michel Thierry Final enablement patch for GPU hang detection using watchdog timeout. Using the gem_context_setparam ioctl, users can specify the desired timeout value in microseconds, and the driver will do the conversion to 'timestamps'. The

Re: [Intel-gfx] [PATCH 02/46] drm/i915: Report the number of closed vma held by each context in debugfs

2019-01-07 Thread Mika Kuoppala
Chris Wilson writes: > Include the total size of closed vma when reporting the per_ctx_stats of > debugfs/i915_gem_objects. > > Whilst adjusting the context tracking, note that we can simply use our > list of contexts in i915->contexts rather than circumlocute via > dev->filelist and the

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] tests/gem_shrink: Exercise OOM and other routes to shrinking in reasonable time

2019-01-07 Thread Chris Wilson
Quoting Michał Winiarski (2019-01-07 12:27:07) > On Fri, Jan 04, 2019 at 03:37:09PM +, Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > > > A set of subtests which exercises different paths to our shrinker code > > (including the OOM killer) in predictable and reasonable time budget. > >

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] tests/gem_shrink: Exercise OOM and other routes to shrinking in reasonable time

2019-01-07 Thread Michał Winiarski
On Fri, Jan 04, 2019 at 03:37:09PM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > A set of subtests which exercises different paths to our shrinker code > (including the OOM killer) in predictable and reasonable time budget. > > Signed-off-by: Tvrtko Ursulin > --- > lib/igt_core.c

Re: [Intel-gfx] [PATCH] drm/i915/icl: Apply WaEnablePreemptionGranularityControlByUMD

2019-01-07 Thread Michał Winiarski
On Mon, Jan 07, 2019 at 01:01:16PM +0200, Joonas Lahtinen wrote: > Quoting José Roberto de Souza (2019-01-04 19:37:00) > > According to Workaround database ICL also needs > > WaEnablePreemptionGranularityControlByUMD, to allow userspace to do > > fine-granularity preemptions per-context. > > I

Re: [Intel-gfx] drm/i915: Watchdog timeout: Ringbuffer command emission for gen8+

2019-01-07 Thread Tvrtko Ursulin
On 05/01/2019 02:39, Carlos Santa wrote: From: Michel Thierry Emit the required commands into the ring buffer for starting and stopping the watchdog timer before/after batch buffer start during batch buffer submission. v2: Support watchdog threshold per context engine, merge lri commands,

Re: [Intel-gfx] drm/i915: Watchdog timeout: IRQ handler for gen8+

2019-01-07 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-01-07 11:58:13) > > Hi, > > This series has not been recognized by Patchwork as such, nor are the > patches numbered. Have you used git format-patch - --cover-letter and > git send-email to send it out? > > Rest inline. > > On 05/01/2019 02:39, Carlos Santa

[Intel-gfx] [PATCH 24/46] drm/i915: Serialise concurrent calls to i915_gem_set_wedged()

2019-01-07 Thread Chris Wilson
Make i915_gem_set_wedged() and i915_gem_unset_wedged() behaviour more consistently if called concurrently. Signed-off-by: Chris Wilson Cc: Mika Kuoppala --- drivers/gpu/drm/i915/i915_gem.c | 32 ++- drivers/gpu/drm/i915/i915_gpu_error.h | 4 ++-

  1   2   >