Re: [Intel-gfx] [PATCH] drm/i915: DP link training optimization

2015-02-26 Thread Jani Nikula
On Fri, 27 Feb 2015, Todd Previte tprev...@gmail.com wrote: Hi Mika, On 2/26/2015 2:26 AM, Mika Kahola wrote: In a case when DP link has been once trained we can reuse the existing link training parameters i.e. voltage swing and pre-emphasis levels from cache when there is a need to restart

Re: [Intel-gfx] [PATCH 0/4] drm/i915/skl: Support for edp1.4 intermediate frequencies

2015-02-26 Thread Jindal, Sonika
Hi, Did anybody get a chance to look into these patches? The first patch in the series is merged in -nightly Thanks, Sonika -Original Message- From: Jindal, Sonika Sent: Saturday, February 21, 2015 11:12 AM To: intel-gfx@lists.freedesktop.org Cc: ville.syrj...@linux.intel.com; Jindal,

Re: [Intel-gfx] [PATCH] drm/i915: Fix a use after free, and unbalanced refcounting

2015-02-26 Thread Jani Nikula
On Tue, 24 Feb 2015, Jani Nikula jani.nik...@linux.intel.com wrote: On Mon, 23 Feb 2015, Daniel, Thomas thomas.dan...@intel.com wrote: -Original Message- From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of Nick Hoath Sent: Thursday, February 19, 2015 4:31

Re: [Intel-gfx] [PATCH] drm/i915: DP link training optimization

2015-02-26 Thread Ville Syrjälä
On Thu, Feb 26, 2015 at 06:29:45PM -0700, Todd Previte wrote: Hi Mika, On 2/26/2015 2:26 AM, Mika Kahola wrote: In a case when DP link has been once trained we can reuse the existing link training parameters i.e. voltage swing and pre-emphasis levels from cache when there is a need to

Re: [Intel-gfx] [PATCH] drm/i915: Check for driver readyness before handling an underrun interrupt

2015-02-26 Thread Jani Nikula
On Thu, 26 Feb 2015, Chris Wilson ch...@chris-wilson.co.uk wrote: When we takeover from the BIOS and install our interrupt handler, the BIOS may have left us a few surprises in the form of spontaneous interrupts. (This is especially likely on hardware like 965gm where display fifo underruns

Re: [Intel-gfx] [PATCH 3/5] drm/i915/chv: Set min freq to efficient frequency on chv

2015-02-26 Thread Chris Wilson
On Thu, Feb 26, 2015 at 08:46:56PM +0530, deepa...@linux.intel.com wrote: From: Deepak S deepa...@linux.intel.com After feedback from the hardware team, now we set the GPU min freq to RPe. If we drop the freq to RPn, we found that the punit was not setting the voltage to Vnn, So

Re: [Intel-gfx] [PATCH 4/5] drm/i915: Modifying RC6 Promotion timer for Media workloads.

2015-02-26 Thread Chris Wilson
On Thu, Feb 26, 2015 at 08:46:57PM +0530, deepa...@linux.intel.com wrote: From: Deepak S deepa...@linux.intel.com In normal cases, RC6 promotion timer is 1700us/500us. This will result in more time spent in C1 state. For more residency in C6 in case of media workloads, this is changed to

Re: [Intel-gfx] [RFC] drm/i915: Framebuffers need not be limited to 256MB on gen8+.

2015-02-26 Thread Damien Lespiau
On Thu, Feb 26, 2015 at 04:01:32PM +, Chris Wilson wrote: On Thu, Feb 26, 2015 at 09:01:52PM +0530, deepa...@linux.intel.com wrote: From: Deepak S deepa...@linux.intel.com The restriction of pinningFramebuffer to first 256MB is removed from gen8+. Removing the restriction so that FB

[Intel-gfx] [PATCH] drm/i915: Check DVO reads for errors

2015-02-26 Thread Chris Wilson
Not all of the DVO functions were checking the return value from their i2c routines when reading registers. This could lead to us feeding garbage values back into the hardware, possible causing further failures. In some cases the uninitialised stack values were being written into the kernel log.

Re: [Intel-gfx] [PATCH 1/2] drm: Complete moving rotation property to core

2015-02-26 Thread Daniel Vetter
On Thu, Feb 26, 2015 at 07:24:24AM -0800, Matt Roper wrote: For both patches: Reviewed-by: Matt Roper matthew.d.ro...@intel.com Both merged to drm-misc, thanks. -Daniel On Thu, Feb 26, 2015 at 01:49:17PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin tvrtko.ursu...@intel.com

Re: [Intel-gfx] [PATCH 6/8] drm/i915/skl: Updated watermark programming

2015-02-26 Thread Damien Lespiau
On Wed, Feb 25, 2015 at 04:47:22PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin tvrtko.ursu...@intel.com Recent BSpect updates have changed the watermark calculation to avoid display flickering in some cases. Signed-off-by: Tvrtko Ursulin tvrtko.ursu...@intel.com --- There are

Re: [Intel-gfx] [PATCH] drm/i915: Add media rc6 residency file to sysfs

2015-02-26 Thread Daniel Vetter
On Thu, Feb 26, 2015 at 09:10:27PM +0530, deepa...@linux.intel.com wrote: From: Ville Syrjälä ville.syrj...@linux.intel.com On VLV/CHV the media well rc6 residency gets reported separately from the render well, so add another file to sysfs so that we can report the residency to the user.

[Intel-gfx] [patch -next] drm/i915: fix a printk format

2015-02-26 Thread Dan Carpenter
This printk leads to the following Smatch warning: drivers/gpu/drm/i915/i915_gem_gtt.c:336 alloc_pt_range() error: '%pa' expects argument of type 'phys_addr_t*', argument 5 has type 'struct i915_page_table_entry*' It looks like a simple typo to me where %p

Re: [Intel-gfx] [PATCH 7/8] drm/i915/skl: Update watermarks for Y tiling

2015-02-26 Thread Damien Lespiau
On Wed, Feb 25, 2015 at 04:47:23PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin tvrtko.ursu...@intel.com Display watermarks need different programming for different tiling modes. Set the relevant flag so this happens during the plane commit and add relevant data into a structure made

Re: [Intel-gfx] [PATCH 8/8] drm/i915/skl: Allow Y (and Yf) frame buffer creation

2015-02-26 Thread Daniel Vetter
On Wed, Feb 25, 2015 at 04:47:24PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin tvrtko.ursu...@intel.com By this patch all underlying bits have been implemented and this patch actually enables the feature. v2: Validate passed in fb modifiers to reject garbage. (Daniel Vetter)

Re: [Intel-gfx] eDP display control registers in Linux kernel

2015-02-26 Thread Michael Leuchtenburg
Note to anyone else who might try this (I sent someone this way from IRC who was also wondering the same thing about the XPS 13), these patches don't apply to 4.0-rc1 since they're missing DP_EDP_DPCD_REV (and maybe some other things, haven't dug in thoroughly yet). Also that patch doesn't quite

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Use the CRC gpio_chip for panel enable/disable

2015-02-26 Thread Alexandre Courbot
On Wed, Feb 18, 2015 at 9:18 PM, Shobhit Kumar shobhit.ku...@intel.com wrote: The CRC (Crystal Cove) PMIC, controls the panel enable and disable signals for BYT for dsi panels. This is indicated in the VBT fields. Use that to initialize and use GPIO based control for these signals. Cc: Linus

Re: [Intel-gfx] eDP display control registers in Linux kernel

2015-02-26 Thread Michael Leuchtenburg
Okay, here's the results: : 12 0a 02 41 00 00 00 00 00 00 00 00 00 0b 00 0070: 01 00 0080: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 0100: 0a 02 00 09 09 00 00 00 01 00 00 0200: 01 00 77 00 01 01 55 00 0600: 01 0700: 02 0701: 88 40 00 00 0720: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00

Re: [Intel-gfx] [PATCH 1/2] drm: Complete moving rotation property to core

2015-02-26 Thread Matt Roper
For both patches: Reviewed-by: Matt Roper matthew.d.ro...@intel.com On Thu, Feb 26, 2015 at 01:49:17PM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin tvrtko.ursu...@intel.com Commit 1da30627fc511a57c9bd23a02c97f0576379f761 drm: Add rotation value to plane state moved the rotation

[Intel-gfx] [PATCH 4/5] drm/i915: Modifying RC6 Promotion timer for Media workloads.

2015-02-26 Thread deepak . s
From: Deepak S deepa...@linux.intel.com In normal cases, RC6 promotion timer is 1700us/500us. This will result in more time spent in C1 state. For more residency in C6 in case of media workloads, this is changed to 250us. Not doing this for 3D workloads as too many C6-C0 transition delays can

[Intel-gfx] [PATCH 1/5] drm/i915/chv: Remove Wait for a previous gfx force-off

2015-02-26 Thread deepak . s
From: Deepak S deepa...@linux.intel.com On CHV, PUNIT team confirmed that 'VLV_GFX_CLK_STATUS_BIT' is not a sticky bit and it will always be set. So ignore Check for previous Gfx force off during suspend and allow the force clk as part S0ix Sequence Signed-off-by: Deepak S

[Intel-gfx] [PATCH 3/5] drm/i915/chv: Set min freq to efficient frequency on chv

2015-02-26 Thread deepak . s
From: Deepak S deepa...@linux.intel.com After feedback from the hardware team, now we set the GPU min freq to RPe. If we drop the freq to RPn, we found that the punit was not setting the voltage to Vnn, So recommendation is to set min freq to RPe. Signed-off-by: Deepak S deepa...@linux.intel.com

[Intel-gfx] [PATCH 2/5] drm/i915: Re-adjusting rc6 promotional timer for chv

2015-02-26 Thread deepak . s
From: Deepak S deepa...@linux.intel.com After feedback from the hardware team we are changing the RC6 promotional timer to increase the power saving without changing performance. Signed-off-by: Deepak S deepa...@linux.intel.com --- drivers/gpu/drm/i915/intel_pm.c | 4 ++-- 1 file changed, 2

[Intel-gfx] [PATCH 5/5] drm/i915: Setup static bias for GPU

2015-02-26 Thread deepak . s
From: Deepak S deepa...@linux.intel.com Based on the spec, Setting up static BIAS for GPU to improve the rps performace. Signed-off-by: Deepak S deepa...@linux.intel.com --- drivers/gpu/drm/i915/i915_reg.h | 5 + drivers/gpu/drm/i915/intel_pm.c | 12 2 files changed, 17

Re: [Intel-gfx] [PATCH v6 05/32] drm/i915: Track GEN6 page table usage

2015-02-26 Thread Mika Kuoppala
Michel Thierry michel.thie...@intel.com writes: From: Ben Widawsky benjamin.widaw...@intel.com Instead of implementing the full tracking + dynamic allocation, this patch does a bit less than half of the work, by tracking and warning on unexpected conditions. The tracking itself follows which

[Intel-gfx] [PATCH i-g-t] tests/drv_suspend: Unrename tests

2015-02-26 Thread Daniel Vetter
Renaming tests massively confuses QA's test result tracking and blacklisting. So except when really good reasons are around we shouldn't do it. Here I think just adding the -hibernat suffix and leaving test names unchanged is enough. Cc: David Weinehall david.weineh...@intel.com Cc: Imre Deak

Re: [Intel-gfx] [PATCH 1/5] drm/i915/chv: Remove Wait for a previous gfx force-off

2015-02-26 Thread Ville Syrjälä
On Thu, Feb 26, 2015 at 08:46:54PM +0530, deepa...@linux.intel.com wrote: From: Deepak S deepa...@linux.intel.com On CHV, PUNIT team confirmed that 'VLV_GFX_CLK_STATUS_BIT' is not a sticky bit and it will always be set. So ignore Check for previous Gfx force off during suspend and allow the

[Intel-gfx] [PATCH] drm/i915: Add media rc6 residency file to sysfs

2015-02-26 Thread deepak . s
From: Ville Syrjälä ville.syrj...@linux.intel.com On VLV/CHV the media well rc6 residency gets reported separately from the render well, so add another file to sysfs so that we can report the residency to the user. Testcase: igt/pm_rc6_residency --run-subtest media-rc6-accuracy Reviewed-by:

[Intel-gfx] [PATCH 2/2] tests/pm_rc6_residency: Add media_rc6_residency_counter subtest

2015-02-26 Thread deepak . s
From: Deepak S deepa...@linux.intel.com Added new media_rc6_residency_subtest for chv vlv. Signed-off-by: Deepak S deepa...@linux.intel.com --- tests/pm_rc6_residency.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/tests/pm_rc6_residency.c

[Intel-gfx] [PATCH 1/2] tests/pm_rc6_residency: Fix proper residency calculation

2015-02-26 Thread deepak . s
From: Deepak S deepa...@linux.intel.com With current code we are not considering the RC6 residency during sysfs read. This is causing test to fail due to incorrect residency_accuracy check This patch consider code time spent for accuracy check Signed-off-by: Deepak S deepa...@linux.intel.com ---

Re: [Intel-gfx] [PATCH 1/5] drm/i915/chv: Remove Wait for a previous gfx force-off

2015-02-26 Thread Deepak S
On Thursday 26 February 2015 09:13 PM, Ville Syrjälä wrote: On Thu, Feb 26, 2015 at 08:46:54PM +0530, deepa...@linux.intel.com wrote: From: Deepak S deepa...@linux.intel.com On CHV, PUNIT team confirmed that 'VLV_GFX_CLK_STATUS_BIT' is not a sticky bit and it will always be set. So ignore

Re: [Intel-gfx] [RFC] drm/i915: Framebuffers need not be limited to 256MB on gen8+.

2015-02-26 Thread Chris Wilson
On Thu, Feb 26, 2015 at 09:01:52PM +0530, deepa...@linux.intel.com wrote: From: Deepak S deepa...@linux.intel.com The restriction of pinningFramebuffer to first 256MB is removed from gen8+. Removing the restriction so that FB can be pinned in any space within GTT/PPGTT. Also, for gen8+ no

Re: [Intel-gfx] [PATCH 8/8] drm/i915/skl: Allow Y (and Yf) frame buffer creation

2015-02-26 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 5826 -Summary- Platform Delta drm-intel-nightly Series Applied PNV -2 281/281

[Intel-gfx] [PATCH 0/5] CHV PM fix Improvements

2015-02-26 Thread deepak . s
From: Deepak S deepa...@linux.intel.com Adding few of PM fixes and Improvements for CHV/VLV. Deepak S (5): drm/i915/chv: Remove Wait for a previous gfx force-off drm/i915: Re-adjusting rc6 promotional timer for chv drm/i915/chv: Set min freq to efficient frequency on chv drm/i915:

[Intel-gfx] [RFC] drm/i915: Framebuffers need not be limited to 256MB on gen8+.

2015-02-26 Thread deepak . s
From: Deepak S deepa...@linux.intel.com The restriction of pinningFramebuffer to first 256MB is removed from gen8+. Removing the restriction so that FB can be pinned in any space within GTT/PPGTT. Also, for gen8+ no need to use pin_mappable for Framebuffer also we do not take fence as

Re: [Intel-gfx] [PATCH 5/8] drm/i915/skl: Adjust get_plane_config() to support Yb/Yf tiling

2015-02-26 Thread Damien Lespiau
On Wed, Feb 25, 2015 at 04:47:21PM +, Tvrtko Ursulin wrote: From: Damien Lespiau damien.lesp...@intel.com v2: Rebased for addfb2 interface and consolidated a bit. (Tvrtko Ursulin) v3: Rebased for fb modifier changes. (Tvrtko Ursulin) v4: Use intel_fb_stride_alignment instead of open

[Intel-gfx] [PATCH] drm/i915: Check for driver readyness before handling an underrun interrupt

2015-02-26 Thread Chris Wilson
When we takeover from the BIOS and install our interrupt handler, the BIOS may have left us a few surprises in the form of spontaneous interrupts. (This is especially likely on hardware like 965gm where display fifo underruns are continuous and the GMCH cannot filter that interrupt souce.) As we

Re: [Intel-gfx] [PATCH 1/8] drm/i915/skl: Added new macros

2015-02-26 Thread Chris Wilson
On Thu, Feb 26, 2015 at 06:19:37PM +0530, akash.g...@intel.com wrote: +#define GT_INTERVAL_FROM_US(us) (IS_GEN9(dev_priv-dev) ? \ + INTERVAL_1_33_US(us) : \ + INTERVAL_1_28_US(us)) Just use IS_GEN9(dev_priv) -Chris -- Chris Wilson,

Re: [Intel-gfx] [PATCH 3/4] drm/dp: add DPCD definitions from eDP 1.2

2015-02-26 Thread Daniel Vetter
On Thu, Feb 26, 2015 at 03:21:13PM +0530, sonika wrote: On Wednesday 25 February 2015 06:16 PM, Jani Nikula wrote: Mostly display control related DPCD addresses. Signed-off-by: Jani Nikula jani.nik...@intel.com --- include/drm/drm_dp_helper.h | 32 1

Re: [Intel-gfx] [PATCH] drm/i915: Add missing description to parameter in alloc_pt_range

2015-02-26 Thread Daniel Vetter
On Thu, Feb 26, 2015 at 11:28:13AM +, Michel Thierry wrote: The patch drm/i915: Plumb drm_device through page tables operations added an extra parameter, but it didn't update the function description. Also remove unnecessary blank line added by the same patch. Found by kbuild test robot.

Re: [Intel-gfx] [PATCH 4/4] drm/dp: add DPCD definitions from eDP 1.4

2015-02-26 Thread Jani Nikula
On Thu, 26 Feb 2015, sonika sonika.jin...@intel.com wrote: On Wednesday 25 February 2015 06:16 PM, Jani Nikula wrote: Signed-off-by: Jani Nikula jani.nik...@intel.com --- include/drm/drm_dp_helper.h | 37 + 1 file changed, 37 insertions(+) diff --git

[Intel-gfx] [PATCH 2/8] drm/i915/skl: Updated intel_gpu_freq() and intel_freq_opcode()

2015-02-26 Thread akash . goel
From: Akash Goel akash.g...@intel.com On SKL, frequency is specified in units of 16.66 MHZ. Updated the intel_gpu_freq() and intel_freq_opecode() functions to do the conversion appropriately. Signed-off-by: Akash Goel akash.g...@intel.com --- drivers/gpu/drm/i915/intel_pm.c | 8 ++-- 1 file

[Intel-gfx] [PATCH 8/8] drm/i915/skl: Updated the i915_frequency_info debugfs function

2015-02-26 Thread akash . goel
From: Akash Goel akash.g...@intel.com Added support for SKL in the i915_frequency_info debugfs function v2: - corrected the handling of reqf (Damien) - Reorderd the platform check for cagf (Ville) Signed-off-by: Akash Goel akash.g...@intel.com --- drivers/gpu/drm/i915/i915_debugfs.c | 25

[Intel-gfx] [PATCH 5/8] drm/i915/skl: Restructured the gen6_set_rps_thresholds function

2015-02-26 Thread akash . goel
From: Akash Goel akash.g...@intel.com Prior to SKL, the time period programmed in Up/Down EI Up/Down threshold registers was in units of 1.28 micro seconds. But for SKL, the units have changed (1.333 micro seconds). Have generalized the implementation of gen6_set_rps_thresholds function, by

[Intel-gfx] [PATCH 1/8] drm/i915/skl: Added new macros

2015-02-26 Thread akash . goel
From: Akash Goel akash.g...@intel.com For SKL, register definition for RPNSWREQ (A008), RPSTAT1(A01C) have changed slightly. Also on SKL, frequency is specified in units of 16.66 MHZ, compared to 50 MHZ for most of the earlier platforms and the time values are expressed in units of 1.33 us,

[Intel-gfx] [PATCH 3/8] drm/i915/skl: Updated the gen6_init_rps_frequencies function

2015-02-26 Thread akash . goel
From: Akash Goel akash.g...@intel.com On SKL the frequency is specified in units of 16.66 MHZ, barring the RP_STATE_CAP(0x5998) register, which still reports frequency in units of 50 MHZ. So an extra conversion is required in gen6_init_rps_frequencies function for SKL, to store the frequency

[Intel-gfx] [PATCH v3 00/10] Added missing changes for Turbo feature on SKL

2015-02-26 Thread akash . goel
From: Akash Goel akash.g...@intel.com This patch series adds the missing changes, required for proper functioning of the Turbo feature on SKL. Most of the changes are mainly due to the fact that on SKL, the frequency has to be programmed in units of 16.66 MHZ and the time period value programmed

[Intel-gfx] [PATCH 6/8] drm/i915/skl: Updated the gen6_rps_limits function

2015-02-26 Thread akash . goel
From: Akash Goel akash.g...@intel.com RP Interrupt Up/Down Frequency Limits register (A014) definition has changed for SKL. Updated the gen6_rps_limits function as per that v2: Renamed the function to intel_rps_limits (Chris) Signed-off-by: Akash Goel akash.g...@intel.com ---

Re: [Intel-gfx] [PATCH 5/8] drm/i915/skl: Restructured the gen6_set_rps_thresholds function

2015-02-26 Thread Chris Wilson
On Thu, Feb 26, 2015 at 06:19:41PM +0530, akash.g...@intel.com wrote: From: Akash Goel akash.g...@intel.com Prior to SKL, the time period programmed in Up/Down EI Up/Down threshold registers was in units of 1.28 micro seconds. But for SKL, the units have changed (1.333 micro seconds). Have

[Intel-gfx] [PATCH] drm/atomic-helper: Fix kerneldoc for prepare_planes

2015-02-26 Thread Daniel Vetter
Copypaste-fail from cleanup_planes. Reported by Tvrtko. Cc: Tvrtko Ursulin tvrtko.ursu...@linux.intel.com Reviewed-by: Tvrtko Ursulin tvrtko.ursu...@linux.intel.com Signed-off-by: Daniel Vetter daniel.vet...@intel.com --- drivers/gpu/drm/drm_atomic_helper.c | 4 ++-- 1 file changed, 2

[Intel-gfx] [PATCH 2/2] drm/i915: Rotation property is now handled in DRM core

2015-02-26 Thread Tvrtko Ursulin
From: Tvrtko Ursulin tvrtko.ursu...@intel.com So no need to have code which never gets called in the driver. Signed-off-by: Tvrtko Ursulin tvrtko.ursu...@intel.com Cc: Matt Roper matthew.d.ro...@intel.com Reviewed-by: Daniel Vetter daniel.vet...@ffwll.ch Cc: dri-de...@lists.freedesktop.org ---

[Intel-gfx] [PATCH 1/2] drm: Complete moving rotation property to core

2015-02-26 Thread Tvrtko Ursulin
From: Tvrtko Ursulin tvrtko.ursu...@intel.com Commit 1da30627fc511a57c9bd23a02c97f0576379f761 drm: Add rotation value to plane state moved the rotation property to DRM core but only did the set property part. This does the get property part as well. Signed-off-by: Tvrtko Ursulin

Re: [Intel-gfx] [PATCH] drm/i915: DP link training optimization

2015-02-26 Thread Chris Wilson
On Thu, Feb 26, 2015 at 02:19:51PM +, Kahola, Mika wrote: -Original Message- From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] Sent: Thursday, February 26, 2015 12:51 PM To: Kahola, Mika Cc: intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH] drm/i915: DP

Re: [Intel-gfx] [PATCH] drm/i915: Look at staged config when fixing pipe_src_w for LVDS

2015-02-26 Thread Daniel Vetter
On Thu, Feb 26, 2015 at 09:44:45AM +0200, Ander Conselvan de Oliveira wrote: The code in function intel_crtc_compute_config() that evens pipe_src_w if necessary would look at the current config instead of the staged one when deciding if there is an LVDS encoder in use. This could potentially

[Intel-gfx] [PATCH 09/10] drm/i915/skl: Updated the act_freq_mhz_show sysfs function

2015-02-26 Thread akash . goel
From: Akash Goel akash.g...@intel.com Added support for SKL in the act_freq_mhz_show sysfs function Signed-off-by: Akash Goel akash.g...@intel.com --- drivers/gpu/drm/i915/i915_sysfs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_sysfs.c

[Intel-gfx] [PATCH 10/10] drm/i915/skl: Enabling processing of Turbo interrupts

2015-02-26 Thread akash . goel
From: Akash Goel akash.g...@intel.com Earlier Turbo interrupts were not being processed for SKL, as something was amiss in turbo programming for SKL. Now missing changes have been added, so enabling the Turbo interrupt processing for SKL. Signed-off-by: Akash Goel akash.g...@intel.com ---

[Intel-gfx] [PATCH 7/8] drm/i915/skl: Updated the gen9_enable_rps function

2015-02-26 Thread akash . goel
From: Akash Goel akash.g...@intel.com On SKL, GT frequency is programmed in units of 16.66 MHZ units compared to 50 MHZ for older platforms. Also the time value specified for Up/Down EI Up/Down thresholds are expressed in units of 1.33 us, compared to 1.28 us for older platforms. So updated the

[Intel-gfx] [PATCH 4/8] drm/i915/skl: Updated the gen6_set_rps function

2015-02-26 Thread akash . goel
From: Akash Goel akash.g...@intel.com On SKL, the frequency is programmed differently in RPNSWREQ (A008) register (from bits 23 to 31, compared to bits 24 to 31). So updated the gen6_set_rps function, as per this change. Signed-off-by: Akash Goel akash.g...@intel.com ---

Re: [Intel-gfx] [PATCH 1/8] drm/i915/skl: Added new macros

2015-02-26 Thread Chris Wilson
On Thu, Feb 26, 2015 at 12:50:16PM +, Chris Wilson wrote: On Thu, Feb 26, 2015 at 06:19:37PM +0530, akash.g...@intel.com wrote: +#define GT_INTERVAL_FROM_US(us) (IS_GEN9(dev_priv-dev) ? \ + INTERVAL_1_33_US(us) : \ +

Re: [Intel-gfx] [PATCH v2] drm/i915: Removed the read of RP_STATE_CAP from sysfs/debugfs functions

2015-02-26 Thread Daniel Vetter
On Thu, Feb 26, 2015 at 10:38:28AM +, Chris Wilson wrote: On Thu, Feb 26, 2015 at 04:09:47PM +0530, akash.g...@intel.com wrote: From: Akash Goel akash.g...@intel.com The frequency values(Rp0, Rp1, Rpn) reported by RP_STATE_CAP register are stored, initially by the Driver, inside the

Re: [Intel-gfx] [PATCH 5/6] drm/i915: Simplify batch pool cache search

2015-02-26 Thread Chris Wilson
On Thu, Feb 26, 2015 at 10:05:17AM +, Chris Wilson wrote: Combining list_del() with the list_for_each() is actually safe. Sigh. It's not, the iterator disappears and so iter = iter-next is unsafe (I was just thinking that the value of iter-next is left untouched by list_del()). Time to go

Re: [Intel-gfx] [PATCH] drm/i915: DP link training optimization

2015-02-26 Thread Kahola, Mika
-Original Message- From: Chris Wilson [mailto:ch...@chris-wilson.co.uk] Sent: Thursday, February 26, 2015 12:51 PM To: Kahola, Mika Cc: intel-gfx@lists.freedesktop.org Subject: Re: [Intel-gfx] [PATCH] drm/i915: DP link training optimization On Thu, Feb 26, 2015 at 11:26:10AM

[Intel-gfx] [PATCH] drm/i915: Support for higher DSI clk

2015-02-26 Thread Gaurav K Singh
For MIPI panels requiring higher DSI clk, values needs to be added in lfsr_converts table for getting the correct values of pll ctrl and dividor values which gets programmed in cck regs, otherwise DSI PLL does not get locked leading to no display on the MIPI panel. Signed-off-by: Gaurav K Singh

Re: [Intel-gfx] [PATCH] drm: Remove redundant code in the getencoder ioctl

2015-02-26 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 5827 -Summary- Platform Delta drm-intel-nightly Series Applied PNV -1 281/281

[Intel-gfx] [PATCH 1/2] drm/i915/skl: Fix stepping check for a couple of W/As

2015-02-26 Thread Damien Lespiau
Both WaDisableSDEUnitClockGating and WaSetGAPSunitClckGateDisable are needed on B0 as well. Signed-off-by: Damien Lespiau damien.lesp...@intel.com --- drivers/gpu/drm/i915/intel_pm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_pm.c

[Intel-gfx] [PATCH 2/2] drm/i915/skl: Implement WaDisableVFUnitClockGating

2015-02-26 Thread Damien Lespiau
Signed-off-by: Damien Lespiau damien.lesp...@intel.com --- drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/intel_pm.c | 4 2 files changed, 5 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index 55143cb..6849b74 100644 ---

[Intel-gfx] [PATCH 0/2] A couple of follow up W/A patches

2015-02-26 Thread Damien Lespiau
While reviewing the initial 18 patches series Nick noticed one stepping check didn't look correct, so here a couple of patches to fix that. -- Damien Damien Lespiau (2): drm/i915/skl: Fix stepping check for a couple of W/As drm/i915/skl: Implement WaDisableVFUnitClockGating

[Intel-gfx] [PATCH 5/9 V4] drm/i915: Update the EDID automated compliance test function

2015-02-26 Thread Todd Previte
Updates the EDID compliance test function to perform the EDID read as required by the tests. This read needs to take place in the kernel for reasons of speed and efficiency. The results of the EDID read operations are handed off to userspace so that the userspace app can set the display mode

Re: [Intel-gfx] [PATCH] drm/i915: fix failure to power off after hibernate

2015-02-26 Thread Imre Deak
On to, 2015-02-26 at 10:34 +0100, Bjørn Mork wrote: Imre Deak imre.d...@intel.com writes: That patch fixes the problem, with only pci_set_power_state commented out. Do you still want me to try with pci_disable_device() commented out as well? No, but it would help if you could still

[Intel-gfx] [PATCH 1/2] drm/i915: Disable DDR DVFS on CHV

2015-02-26 Thread ville . syrjala
From: Ville Syrjälä ville.syrj...@linux.intel.com DDR DVFS introduces massive memory latencies which can't be handled by the PND deadline stuff. Instead the watermarks will need to be programmed to compensate for the latency and the deadlines will need to be programmed to tight fixed values. That

Re: [Intel-gfx] [PATCH] drm/i915: fix failure to power off after hibernate

2015-02-26 Thread Ville Syrjälä
On Thu, Feb 26, 2015 at 08:50:48PM +0200, Imre Deak wrote: On to, 2015-02-26 at 10:34 +0100, Bjørn Mork wrote: Imre Deak imre.d...@intel.com writes: That patch fixes the problem, with only pci_set_power_state commented out. Do you still want me to try with pci_disable_device()

Re: [Intel-gfx] [PATCH 2/2] drm/i915/gen8: Apply Per-context workarounds using W/A batch buffers

2015-02-26 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 5828 -Summary- Platform Delta drm-intel-nightly Series Applied PNV -1 281/281

Re: [Intel-gfx] [PATCH] drm/i915: fix failure to power off after hibernate

2015-02-26 Thread Daniel Vetter
On Thu, Feb 26, 2015 at 08:50:48PM +0200, Imre Deak wrote: On to, 2015-02-26 at 10:34 +0100, Bjørn Mork wrote: Imre Deak imre.d...@intel.com writes: That patch fixes the problem, with only pci_set_power_state commented out. Do you still want me to try with pci_disable_device()

Re: [Intel-gfx] [PATCH] drm/i915: fix failure to power off after hibernate

2015-02-26 Thread Bjørn Mork
Ville Syrjälä ville.syrj...@linux.intel.com writes: @@ -651,7 +651,14 @@ static int i915_drm_suspend_late(struct drm_device *drm_dev) } pci_disable_device(drm_dev-pdev); -pci_set_power_state(drm_dev-pdev, PCI_D3hot); +/* + * During hibernation on some GM45

Re: [Intel-gfx] [PATCH] drm/i915: fix failure to power off after hibernate

2015-02-26 Thread Bjørn Mork
Imre Deak imre.d...@intel.com writes: Attached is the proposed fix for this issue. --Imre From 5c23657bc168db12a1ba100ab65fabd305c89c8a Mon Sep 17 00:00:00 2001 From: Imre Deak imre.d...@intel.com Date: Thu, 26 Feb 2015 18:38:53 +0200 Subject: [PATCH] drm/i915: gm45: work around hang

[Intel-gfx] [PATCH v2 12/12] drm/i915: Enable the maxfifo PM5 mode when appropriate on CHV

2015-02-26 Thread ville . syrjala
From: Ville Syrjälä ville.syrj...@linux.intel.com CHV has a new knob in Punit to select between some memory power savings modes PM2 and PM5. We can allow the deeper PM5 when maxfifo mode is enabled, so let's do so in the hopes for moar power savings. v2: Put the thing into a separate function to

Re: [Intel-gfx] [patch -next] drm/i915: fix a printk format

2015-02-26 Thread Daniel Vetter
On Thu, Feb 26, 2015 at 07:53:54PM +0300, Dan Carpenter wrote: This printk leads to the following Smatch warning: drivers/gpu/drm/i915/i915_gem_gtt.c:336 alloc_pt_range() error: '%pa' expects argument of type 'phys_addr_t*', argument 5 has type 'struct

[Intel-gfx] [PATCH] drm/i915: Reudce CHV DPLL min vco frequency to 4.8 GHz

2015-02-26 Thread ville . syrjala
From: Ville Syrjälä ville.syrj...@linux.intel.com The current minimum vco frequency leaves us with a gap in our supported frequencies at 233-243 MHz. Your typical 2560x1440@60 display wants a pixel clock of 241.5 MHz, which is just withing that gap. Reduce the allowed vco min frequency to 4.8GHz

[Intel-gfx] [PATCH 2/2] drm/i915: Reduce chv drain latency even further for 4k displays

2015-02-26 Thread ville . syrjala
From: Ville Syrjälä ville.syrj...@linux.intel.com To get 4k resolutions to work reliably with the current watermark setup we need to further reduce the drain latency. Signed-off-by: Ville Syrjälä ville.syrj...@linux.intel.com --- drivers/gpu/drm/i915/intel_pm.c | 2 +- 1 file changed, 1

Re: [Intel-gfx] [PATCH] drm/i915: Removed the read of RP_STATE_CAP from sysfs/debugfs functions

2015-02-26 Thread Akash Goel
On Thu, 2015-02-26 at 08:04 +, Chris Wilson wrote: On Thu, Feb 26, 2015 at 01:29:09PM +0530, akash.g...@intel.com wrote: From: Akash Goel akash.g...@intel.com The frequency values(Rp0, Rp1, Rpn) reported by RP_STATE_CAP register are stored, initially by the Driver, inside the

[Intel-gfx] [PULL] drm-intel-fixes

2015-02-26 Thread Jani Nikula
Hi Dave - First batch of fixes for v4.0-rc, plenty of cc: stable material. BR, Jani. The following changes since commit c517d838eb7d07bbe9507871fab3931deccff539: Linux 4.0-rc1 (2015-02-22 18:21:14 -0800) are available in the git repository at: git://anongit.freedesktop.org/drm-intel

Re: [Intel-gfx] [RFC v2] drm/i915: Android native sync support

2015-02-26 Thread Chris Wilson
On Wed, Feb 25, 2015 at 12:46:31PM -0800, Jesse Barnes wrote: On 01/28/2015 02:07 AM, Chris Wilson wrote: On Wed, Jan 28, 2015 at 10:50:18AM +0100, Daniel Vetter wrote: On Wed, Jan 28, 2015 at 09:23:46AM +, Chris Wilson wrote: On Wed, Jan 28, 2015 at 10:22:15AM +0100, Daniel Vetter

Re: [Intel-gfx] [PATCH] drm/i915: Fix frontbuffer false positve.

2015-02-26 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 5820 -Summary- Platform Delta drm-intel-nightly Series Applied PNV -1 281/281

[Intel-gfx] [PATCH] drm/i915: DP link training optimization

2015-02-26 Thread Mika Kahola
In a case when DP link has been once trained we can reuse the existing link training parameters i.e. voltage swing and pre-emphasis levels from cache when there is a need to restart link training. In a case of eDP we initially try to train the link by using the parameter set that we can find from

Re: [Intel-gfx] [PATCH 3/4] drm/dp: add DPCD definitions from eDP 1.2

2015-02-26 Thread sonika
On Wednesday 25 February 2015 06:16 PM, Jani Nikula wrote: Mostly display control related DPCD addresses. Signed-off-by: Jani Nikula jani.nik...@intel.com --- include/drm/drm_dp_helper.h | 32 1 file changed, 32 insertions(+) diff --git

Re: [Intel-gfx] [PATCH v2] drm/i915: Removed the read of RP_STATE_CAP from sysfs/debugfs functions

2015-02-26 Thread Chris Wilson
On Thu, Feb 26, 2015 at 04:09:47PM +0530, akash.g...@intel.com wrote: From: Akash Goel akash.g...@intel.com The frequency values(Rp0, Rp1, Rpn) reported by RP_STATE_CAP register are stored, initially by the Driver, inside the dev_priv-rps structure. Since these values are expected to remain

Re: [Intel-gfx] [PATCH] drm/i915: fix failure to power off after hibernate

2015-02-26 Thread Bjørn Mork
Imre Deak imre.d...@intel.com writes: That patch fixes the problem, with only pci_set_power_state commented out. Do you still want me to try with pci_disable_device() commented out as well? No, but it would help if you could still try the two attached patch separately, without any of the

Re: [Intel-gfx] [PATCH 1/4] drm/dp: indentation and ordering cleanups

2015-02-26 Thread sonika
On Wednesday 25 February 2015 06:16 PM, Jani Nikula wrote: Keep the DPCD macros ordered by address, and make indentation conform to the rest of the file. commit e045d20bef41707dbba676e58624b54f9f39e172 Author: Sonika Jindal sonika.jin...@intel.com Date: Thu Feb 19 13:16:44 2015 +0530

Re: [Intel-gfx] [PATCH 2/4] drm/dp: add DPCD definitions from DP 1.2a

2015-02-26 Thread sonika
On Wednesday 25 February 2015 06:16 PM, Jani Nikula wrote: Signed-off-by: Jani Nikula jani.nik...@intel.com --- include/drm/drm_dp_helper.h | 95 ++--- 1 file changed, 90 insertions(+), 5 deletions(-) diff --git a/include/drm/drm_dp_helper.h

[Intel-gfx] [PATCH 6/6] drm/i915: Include active flag when describing objects in debugfs

2015-02-26 Thread Chris Wilson
Since we use obj-active as a hint in many places throughout the code, knowing its state in debugfs is extremely useful. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/i915/i915_debugfs.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git

[Intel-gfx] [PATCH 3/6] drm/i915: Free batch pool when idle

2015-02-26 Thread Chris Wilson
At runtime, this helps ensure that the batch pools are kept trim and fast. Then at suspend, this releases memory that we do not need to restore. It also ties into the oom-notifier to ensure that we recover as much kernel memory as possible during OOM. Signed-off-by: Chris Wilson

[Intel-gfx] [PATCH 5/6] drm/i915: Simplify batch pool cache search

2015-02-26 Thread Chris Wilson
Combining list_del() with the list_for_each() is actually safe. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/i915/i915_gem_batch_pool.c | 41 +- 1 file changed, 18 insertions(+), 23 deletions(-) diff --git

[Intel-gfx] [PATCH 4/6] drm/i915: Split batch pool into size buckets

2015-02-26 Thread Chris Wilson
Now with the trimmed memcpy before the command parser, we try to allocate many different sizes of batches, predominantly one or two pages. We can therefore speed up searching for a good sized batch by keeping the objects of buckets of roughly the same size. Signed-off-by: Chris Wilson

[Intel-gfx] [PATCH 1/6] drm/i915: Split i915_gem_batch_pool into its own header

2015-02-26 Thread Chris Wilson
In the next patch, I want to use the structure elsewhere and so require it defined earlier. Rather than move the definition to an earlier location where it feels very odd, place it in its own header file. Signed-off-by: Chris Wilson ch...@chris-wilson.co.uk --- drivers/gpu/drm/i915/i915_drv.h

[Intel-gfx] [PATCH 2/6] drm/i915: Split the batch pool by engine

2015-02-26 Thread Chris Wilson
I woke up one morning and found 50k objects sitting in the batch pool and every search seemed to iterate the entire list... Painting the screen in oils would provide a more fluid display. One issue with the current design is that we only check for retirements on the current ring when preparing to

[Intel-gfx] [PATCH v2] drm/i915: Removed the read of RP_STATE_CAP from sysfs/debugfs functions

2015-02-26 Thread akash . goel
From: Akash Goel akash.g...@intel.com The frequency values(Rp0, Rp1, Rpn) reported by RP_STATE_CAP register are stored, initially by the Driver, inside the dev_priv-rps structure. Since these values are expected to remain same throughout, there is no real need to read this register, on dynamic

Re: [Intel-gfx] [PATCH] drm/i915: DP link training optimization

2015-02-26 Thread Chris Wilson
On Thu, Feb 26, 2015 at 11:26:10AM +0200, Mika Kahola wrote: In a case when DP link has been once trained we can reuse the existing link training parameters i.e. voltage swing and pre-emphasis levels from cache when there is a need to restart link training. In a case of eDP we initially try

[Intel-gfx] [PATCH 2/2] drm/i915: Rotation property is now handled in DRM core

2015-02-26 Thread Tvrtko Ursulin
From: Tvrtko Ursulin tvrtko.ursu...@intel.com So no need to have code which never gets called in the driver. Signed-off-by: Tvrtko Ursulin tvrtko.ursu...@intel.com Cc: Matt Roper matthew.d.ro...@intel.com --- drivers/gpu/drm/i915/intel_atomic_plane.c | 24 1 file

[Intel-gfx] [PATCH 1/2] drm: Complete moving rotation property to core

2015-02-26 Thread Tvrtko Ursulin
From: Tvrtko Ursulin tvrtko.ursu...@intel.com Commit 1da30627fc511a57c9bd23a02c97f0576379f761 drm: Add rotation value to plane state moved the rotation property to DRM core but only did the set property part. This does the get property part as well. Signed-off-by: Tvrtko Ursulin

[Intel-gfx] [PATCH] drm/i915: Add missing description to parameter in alloc_pt_range

2015-02-26 Thread Michel Thierry
The patch drm/i915: Plumb drm_device through page tables operations added an extra parameter, but it didn't update the function description. Also remove unnecessary blank line added by the same patch. Found by kbuild test robot. Signed-off-by: Michel Thierry michel.thie...@intel.com ---

  1   2   >