Re: [Intel-gfx] [PATCH RESEND FOR CI] drm/i915: Fix races on fbdev

Hi Lukas, I'm sorry I haven't reacted sooner. I've enabled the option to only consider git send-email patches on intel-gfx as we were having a lot of false positives (ie patchwork considering emails were people were making suggestions with diffs as patches to test). I'm not sure how you send

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Use a crtc mask instead of a refcount for dpll functions.

On Mon, 2016-02-29 at 13:52 +0100, Maarten Lankhorst wrote: > This makes it easier to verify correct dpll setup with only a single crtc. > It it also useful to detect double dpll enable/disable. I have a goal of being able to get a reference for a shared pll for an encoder without a crtc, so that

Re: [Intel-gfx] [alsa-devel] [PATCH 1/2] ALSA: hda - hdmi add wmb barrier for audio component

On Fri, 04 Mar 2016 07:33:06 +0100, libin.y...@linux.intel.com wrote: > > From: Libin Yang > > To make sure audio_ptr is set before intel_audio_codec_enable() > or intel_audio_codec_disable() calling pin_eld_notify(), > this patch adds wmb barrier to prevent

Re: [Intel-gfx] Problems in intel_panel_fitter.1

On Mon, 29 Feb 2016, e...@thyrsus.com wrote: > This is automatically generated email about markup problems in a man > page for which you appear to be responsible. If you are not the right > person or list, please tell me so I can correct my database. > > See

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Perform dpll commit first.

On Mon, 2016-02-29 at 13:52 +0100, Maarten Lankhorst wrote: > Warn for the wrong mask in enable only. Disable will have the wrong mask now > because the new state is committed before disabling the old state. Why do we want to perform dpll commit first? That should be in the commit message. With

[Intel-gfx] [PATCH] drm/i915: add sanity check for partial view creation

When binding pages for a partial view we should check that the offset + size is valid relative to the size of the gem object. v2: Don't use pages->nents to determine the page count (Tvrtko Ursulin) v3: Handle potential overflow (Chris Wilson) Cc: Joonas Lahtinen

Re: [Intel-gfx] [PATCH] drm/i915: Don't WARN() when sprite watermark > 0 for disabled LP2/LP3 levels

On Thu, Mar 03, 2016 at 02:18:09PM -0800, Matt Roper wrote: > As of commit d81f04c5ef ("drm/i915: Allow preservation of watermarks, v2.") > it's now possible to have non-zero values for watermark levels that are > disabled (e.g., in the higher LP levels that can only be used when the sprite > is

Re: [Intel-gfx] [PATCH] drm/i915: Only write watermark registers if a pipe is active

On Thu, Mar 03, 2016 at 02:27:21PM -0800, Matt Roper wrote: > If all pipes are off, then we may have entered runtime suspend and > writing these registers will have no effect anyway. When a pipe is > re-enabled, it's crtc_enable will take care of programming appropriate > watermark values. > >

[Intel-gfx] [PATCH i-g-t] kms_frontbuffer_tracking: Remove hardcoded PIPE_A

Use the pipe which is given from the possible_crcs for that connected port instead. On BSW there are constrains for the crtc<-->connector, this fix make this test passing on BSW. Signed-off-by: Gabriel Feceoru --- tests/kms_frontbuffer_tracking.c | 3 ++- 1 file

Re: [Intel-gfx] [PATCH RESEND FOR CI] drm/i915: Fix races on fbdev

On Thu, 03 Mar 2016, Lukas Wunner wrote: > Hi Damien, Hi Daniel, > > I've submitted the patch below for the third time now in an attempt > to get CI to test it, again to no avail. This time I didn't set the > In-Reply-To header and only submitted it as a single patch instead > of

Re: [Intel-gfx] [PATCH] drm/i915: add sanity check for partial view creation

On Fri, Mar 04, 2016 at 10:11:24AM +, Matthew Auld wrote: > When binding pages for a partial view we should check that the offset + > size is valid relative to the size of the gem object. > > v2: Don't use pages->nents to determine the page count (Tvrtko Ursulin) > v3: Handle potential

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Move pll power state to crtc power domains.

On Tue, 2016-03-01 at 17:03 +, R, Durgadoss wrote: > > -Original Message- > > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf > > Of Maarten Lankhorst > > Sent: Monday, February 29, 2016 6:22 PM > > To: intel-gfx@lists.freedesktop.org > > Subject: [Intel-gfx]

Re: [Intel-gfx] [PATCH i-g-t v2 2/7] lib/ioctl_wrappers: Separate ring BSD1 from BSD2 checks

I need to control exactly which ring each batchbuffer is submitted to if there is more than 1 BSD ring as I need to fill the queues in a known manner. My understanding is that if I submit to BSD when there is BSD1 and BSD2 the kernel will choose which ring it gets submitted to. If this logic

Re: [Intel-gfx] [PATCH v3 7/7] drm/atomic: Clean up update_connector_routing.

On Thu, Mar 03, 2016 at 10:17:42AM +0100, Maarten Lankhorst wrote: > connector_state->crtc can no longer be unset by accident, > so that check can be removed. The other code open-codes > drm_atomic_get_existing_crtc_state, so use that. > > Signed-off-by: Maarten Lankhorst

[Intel-gfx] [PATCH i-g-t] gem_ppgtt: Fix flink-and-exit-vma-leak for engine->last_context

From: Tvrtko Ursulin Now that engines keep references on the last executed contexts, to fix this test we need to execute an unrelated context last to ensure the one we are interested in is free to be cleaned up when we expect it to be. Signed-off-by: Tvrtko Ursulin

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Move pll power state to crtc power domains.

On Mon, 2016-02-29 at 13:52 +0100, Maarten Lankhorst wrote: > Signed-off-by: Maarten Lankhorst > --- > drivers/gpu/drm/i915/intel_display.c | 10 +++--- > 1 file changed, 3 insertions(+), 7 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_display.c

Re: [Intel-gfx] [PATCH i-g-t v2 4/7] tests/gem_scheduler: Add gem_scheduler test

I don't really understand your statement, can you elaborate please. What do you mean by timeline? Are you saying the driver needs changing? By deprecate HAS_BSD2 did you mean some change that would remove the need for gem_has_bsd2()? Doesn't I915_EXEC_BSD | 1<<13 and I915_EXEC_BSD | 2<<13

Re: [Intel-gfx] [PATCH] drm/i915: Adaptive backoff delay on link training

On Thu, Mar 03, 2016 at 11:27:06AM +0200, Ander Conselvan De Oliveira wrote: > (Cc'ing Sivakumar, as he might have some ideas on this) > > On Fri, 2016-02-26 at 12:54 +0200, Mika Kuoppala wrote: > > If the panel don't give us the information how long to wait > > before starting a new link

Re: [Intel-gfx] [PATCH v3 5/7] drm/atomic: Handle encoder assignment conflicts in a separate check, v3.

On Thu, Mar 03, 2016 at 10:17:40AM +0100, Maarten Lankhorst wrote: > The current check doesn't handle the case where we don't steal an > encoder, but keep it on the current connector. If we repurpose > disable_conflicting_encoders to do the checking, we just have > to reject the ones that

Re: [Intel-gfx] [PATCH v3 6/7] drm/atomic: Clean up steal_encoder, v2.

On Thu, Mar 03, 2016 at 10:17:41AM +0100, Maarten Lankhorst wrote: > Now that only encoders can be stolen that are part of the state > steal_encoder no longer needs to inspect all connectors, > just those that are part of the atomic state. > > Changes since v1: > - Change return value to void,

Re: [Intel-gfx] [PATCH] drm/i915: Adaptive backoff delay on link training

On Fri, 2016-03-04 at 14:59 +0200, Ville Syrjälä wrote: > On Thu, Mar 03, 2016 at 11:27:06AM +0200, Ander Conselvan De Oliveira wrote: > > (Cc'ing Sivakumar, as he might have some ideas on this) > > > > On Fri, 2016-02-26 at 12:54 +0200, Mika Kuoppala wrote: > > > If the panel don't give us the

Re: [Intel-gfx] Ask for comments of getting guest framebuffer in igvt-g

Hi, On to, 2016-03-03 at 17:50 +0800, Zhiyuan Lv wrote: > Dear i915 developers, > > Here I have one topic hoping to get your comments and suggestions. > Basically it is about graphics virtualization(igvt-g), for the purpose > of host system to get virtual machine's framebuffer. We would like to

Re: [Intel-gfx] [PATCH v2 drm/i915: rawclk/cdclk stuff (v2)

On Wed, Mar 02, 2016 at 05:22:12PM +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Here are the remainder of my cdclk/rawclk cleanup patches. Previous time I > posted these was [1]. Bunch of them got already r-b'd by Jani. I also did > the PWM

Re: [Intel-gfx] Ask for comments of getting guest framebuffer in igvt-g

Hi Joonas, On Fri, Mar 04, 2016 at 04:00:27PM +0200, Joonas Lahtinen wrote: > Hi, > > On to, 2016-03-03 at 17:50 +0800, Zhiyuan Lv wrote: > > Dear i915 developers, > > > > Here I have one topic hoping to get your comments and suggestions. > > Basically it is about graphics

Re: [Intel-gfx] [PATCH v2.1 3/6] drm/atomic: Always call steal_encoder, v2.

On Tue, Mar 01, 2016 at 02:52:05PM +0100, Maarten Lankhorst wrote: > There's no need to have a separate function to get the crtc > which is stolen, this can already be found when actually > stealing the encoder. > > drm_for_each_connector already checks for connection_mutex, so > use that macro

Re: [Intel-gfx] [PATCH v2 4/6] drm/atomic: Handle encoder stealing from set_config better.

On Wed, Feb 24, 2016 at 09:37:31AM +0100, Maarten Lankhorst wrote: > Instead of failing with -EINVAL when conflicting encoders are found, > the legacy set_config will disable other connectors when encoders > conflict. > > With the cleanup to update_output_state this is a lot easier to >

Re: [Intel-gfx] [PATCH v5 00/12] Enable GPU switching on pre-retina MacBook Pro

Lukas Wunner wunner.de> writes: > > Enable GPU switching on the pre-retina MacBook Pro (2008 - 2013), v5. Hey Lukas, I've tested your patchset on a MacBookPro8,1, with an integrated Intel and discrete AMD/ATI GPUs. I've used the COPR repository here to cut down on my compilation time:

Re: [Intel-gfx] [PATCH v2 2/6] drm/atomic: Pass connector and state to update_connector_routing.

On Tue, Mar 01, 2016 at 05:19:53PM +0200, Ville Syrjälä wrote: > On Wed, Feb 24, 2016 at 09:37:29AM +0100, Maarten Lankhorst wrote: > > Minor cleanup, connector and connector_state are always non-NULL here. > > > > Signed-off-by: Maarten Lankhorst > >

[Intel-gfx] [PATCH 2/3] drm/i915: Set GPU freq to idle_freq initially

From: Ville Syrjälä Currently we set the initial GPU frequency to min_freq_softlimit on gen9, and to efficient_freq on VLV/CHV. On all the other platforms we set it to idle_freq. Let's use idle_freq across the board to make sure we don't waste power. This is

[Intel-gfx] [PATCH v2] drm/i915/gen9: Fix DMC firmware initialization

In commit 1e657ad7 we moved the last step of firmware initialization to skl_display_core_init(), where it will be run only during system resume, but not during driver loading. Since this init step needs to be done whenever we program the firmware fix this by moving the initialization to the end of

Re: [Intel-gfx] [PATCH] drm/i915: Don't WARN() when sprite watermark > 0 for disabled LP2/LP3 levels

On Fri, Mar 04, 2016 at 07:47:09PM +0200, Ville Syrjälä wrote: > On Fri, Mar 04, 2016 at 09:37:40AM -0800, Matt Roper wrote: > > On Fri, Mar 04, 2016 at 12:45:38PM +0200, Ville Syrjälä wrote: > > > On Thu, Mar 03, 2016 at 02:18:09PM -0800, Matt Roper wrote: > > > > As of commit d81f04c5ef

[Intel-gfx] [PATCH 0/3] drm/i915: Some GT freq stuff

From: Ville Syrjälä A small pile of gt freq related stuff I had lying around. Ville Syrjälä (3): drm/i915: Use GPLL ref clock to calculate GPU freqs on VLV/CHV drm/i915: Set GPU freq to idle_freq initially drm/i915: Drop locking/rpm resume/flush_delayed_work

[Intel-gfx] [PATCH 1/3] drm/i915: Use GPLL ref clock to calculate GPU freqs on VLV/CHV

From: Ville Syrjälä Extract the GPLL reference frequency from CCK and use it in the GPU freq<->opcode conversions on VLV/CHV. This eliminates all the assumptions we have about which divider is used for which czclk frequency. Note that unlike most clocks from CCK,

[Intel-gfx] [PATCH 3/3] drm/i915: Drop locking/rpm resume/flush_delayed_work for cur/min/max freq sysfs read

From: Ville Syrjälä cur_freq, min/max_freq_softlimit, efficient_freq are just single values stored under dev_priv.rps, so there's no real point in locking, resuming the devices and flushing the delayed resume work just to print them out. Signed-off-by: Ville

Re: [Intel-gfx] [PATCH i-g-t] kms_frontbuffer_tracking: Remove hardcoded PIPE_A

Em Sex, 2016-03-04 às 12:02 +0200, Gabriel Feceoru escreveu: > Use the pipe which is given from the possible_crcs for that connected > port > instead. > > On BSW there are constrains for the crtc<-->connector, this fix make > this test > passing on BSW. > > Signed-off-by: Gabriel Feceoru

Re: [Intel-gfx] [PATCH] drm/i915: Only write watermark registers if a pipe is active

On Fri, Mar 04, 2016 at 12:52:41PM +0200, Ville Syrjälä wrote: > On Thu, Mar 03, 2016 at 02:27:21PM -0800, Matt Roper wrote: > > If all pipes are off, then we may have entered runtime suspend and > > writing these registers will have no effect anyway. When a pipe is > > re-enabled, it's

[Intel-gfx] [PATCH] drm/i915: Wait until after wm optimization to drop runtime PM reference

At the end of an atomic commit, we currently wait for vblanks to complete, call put() on the various runtime PM references, and then try to optimize our watermarks (on platforms that need two-step watermark programming). This can lead to watermark registers being programmed while the power well

[Intel-gfx] [PATCH] drm/i915/gen9: fix DMC firmware initialization

In commit 1e657ad7 we moved the last step of firmware initialization to skl_display_core_init(), where it will be run only during system resume, but not during driver loading. Since this init step needs to be done whenever we program the firmware fix this by moving the initialization to the end of

Re: [Intel-gfx] [PATCH] drm/i915: Don't WARN() when sprite watermark > 0 for disabled LP2/LP3 levels

On Fri, Mar 04, 2016 at 12:45:38PM +0200, Ville Syrjälä wrote: > On Thu, Mar 03, 2016 at 02:18:09PM -0800, Matt Roper wrote: > > As of commit d81f04c5ef ("drm/i915: Allow preservation of watermarks, v2.") > > it's now possible to have non-zero values for watermark levels that are > > disabled

Re: [Intel-gfx] [PATCH] drm/i915: Wait until after wm optimization to drop runtime PM reference

Hi Matt, On Fri, 2016-03-04 at 15:59 -0800, Matt Roper wrote: > At the end of an atomic commit, we currently wait for vblanks to > complete, call put() on the various runtime PM references, and then > try > to optimize our watermarks (on platforms that need two-step watermark > programming).  

[Intel-gfx] [RFC 07/15] drm/i915: Add API code for non-HDAudio HDMI interface

Add API code for interface available on Baytrail and CherryTrail Initial code was downloaded from https://github.com/01org/baytrailaudio/ ...and had the changes to .config stripped and the revert on sound/init.c done by David Henningson Clean-up, port to 4.4 and intel-drm by Pierre Bossart

[Intel-gfx] [RFC 09/15] ALSA: Intel: Atom: add Atom non-HDAudio HDMI interface

Add support interface available on Baytrail and CherryTrail Initial code was downloaded from https://github.com/01org/baytrailaudio/ ...and had the changes to .config stripped and the revert on sound/init.c and printk->pr_debug done by David Henningson Clean-up, port to 4.4 and intel-drm by

[Intel-gfx] [RFC 13/15] hdmi_audio: Fix mishandling of AUD_HDMI_STATUS_v2 register.

From: Toyo Abe According to the datasheet, write one to clear these UNDERRUN flag bits. This fixes the following warning in dmesg. [15357.574902] had: Unable to clear UNDERRUN bits Signed-off-by: Toyo Abe Signed-off-by: Pierre-Louis Bossart

[Intel-gfx] [RFC 06/15] drm/i915: power-related changes non-HDAudio HDMI interface

PM and RPM changes for interface available on Baytrail and CherryTrail This driver was downloaded from https://github.com/01org/baytrailaudio/ ...and had the changes to .config stripped and the revert on sound/init.c Clean-up, port to 4.4 and intel-drm by Pierre Bossart Signed-off-by: David

[Intel-gfx] [RFC 00/15] HDMI Audio support on Atom w/o HDAUdio

When HDaudio is not enabled or fused-out, an alternate hardware interface can be used to provide audio data to the display/HDMI controller on Atom platforms. The code to control this interface was never submitted upstream but has been used extensively in Android programs on Medfield, Clovertrail,

[Intel-gfx] [RFC 01/15] drm: i915: fix inversion of definitions for LPE_PIPE_A/B

Definitions for I915_LPE_PIPE_A_INTERRUPT and I915_LPE_PIPE_B_INTERRUPT are inverted. Signed-off-by: Pierre-Louis Bossart --- drivers/gpu/drm/i915/i915_reg.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[Intel-gfx] [RFC 14/15] i915: Enable LPE_PIPEA_Interrupt.

From: Toyo Abe To enable interrupt, IER, IIR, and IMR must be configured appropriately. IER setting for hdmi_audio was missing. This fixes the following warning in dmesg. [ 302.369965] had: Driver detected 2 missed buffer done interrupt(s) Signed-off-by: Toyo Abe

[Intel-gfx] [RFC 02/15] drm: i915: remove intel_hdmi variable declaration

'intel_hdmi' variable is redeclared, use same variable declared in function scope. Signed-off-by: Pierre-Louis Bossart --- drivers/gpu/drm/i915/intel_hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Intel-gfx] [RFC 05/15] drm/i915: changes for non-HDAudio HDMI interface

Changes to existing code for interface available on Baytrail and CherryTrail This driver was downloaded from https://github.com/01org/baytrailaudio/ ...and had the changes to .config stripped and the revert on sound/init.c Cleanup, port to 4.4 and intel-drm by Pierre Bossart Signed-off-by:

[Intel-gfx] [RFC 11/15] hdmi_audio: Improve position reporting

From: David Henningsson Using a hw register to calculate sub-period position reports. This makes PulseAudio happier. Signed-off-by: David Henningsson Signed-off-by: Pierre-Louis Bossart

[Intel-gfx] [RFC 04/15] drm/i915: Add headers for non-HDAudio HDMI interface

Add header files for interface available on Baytrail and CherryTrail Initial code was downloaded from https://github.com/01org/baytrailaudio/ ...and had the changes to .config stripped and the revert on sound/init.c done by David Henningson Clean-up, port to 4.4 and intel-drm by Pierre Bossart

[Intel-gfx] [RFC 08/15] drm/i915: enable non-HDAudio HDMI interface Makefile

Makefile for all previous patches This driver was downloaded from https://github.com/01org/baytrailaudio/ ...and had the changes to .config stripped and the revert on sound/init.c clean-up, port to 4.4 and intel-drm by Pierre Bossart Signed-off-by: David Henningsson

[Intel-gfx] [RFC 03/15] Doc: sound: add description of Atom HDMI audio interface

Used when HDaudio is not enabled Signed-off-by: Pierre-Louis Bossart --- Documentation/sound/alsa/Atom-hdmi-audio.txt | 241 +++ 1 file changed, 241 insertions(+) create mode 100644 Documentation/sound/alsa/Atom-hdmi-audio.txt diff

[Intel-gfx] [RFC 10/15] add dependency on PM_RUNTIME

Signed-off-by: Pierre-Louis Bossart --- sound/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/Kconfig b/sound/Kconfig index 75c679e..b8b4fce 100644 --- a/sound/Kconfig +++ b/sound/Kconfig @@ -138,6 +138,7 @@ config AC97_BUS config

[Intel-gfx] [RFC 12/15] hdmi_audio: Fixup some monitor

From: David Henningsson I think this change was given to us, and they claimed it fixed an issue on some monitor brand. I'm not sure what this patch actually does. Signed-off-by: David Henningsson Signed-off-by: Pierre-Louis

[Intel-gfx] [RFC 15/15] i915: Fix typo in comment.

From: Toyo Abe Signed-off-by: Toyo Abe Signed-off-by: Pierre-Louis Bossart --- drivers/gpu/drm/i915/i915_irq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_irq.c

Re: [Intel-gfx] [PATCH] drm/i915: Don't WARN() when sprite watermark > 0 for disabled LP2/LP3 levels

On Fri, Mar 04, 2016 at 09:37:40AM -0800, Matt Roper wrote: > On Fri, Mar 04, 2016 at 12:45:38PM +0200, Ville Syrjälä wrote: > > On Thu, Mar 03, 2016 at 02:18:09PM -0800, Matt Roper wrote: > > > As of commit d81f04c5ef ("drm/i915: Allow preservation of watermarks, > > > v2.") > > > it's now

Re: [Intel-gfx] [PATCH v1.1 1/2] drm/i915: Allow preservation of watermarks, v2.

On Wed, Mar 02, 2016 at 12:38:06PM +0100, Maarten Lankhorst wrote: > As Paulo has noted we can help bisectability by separating computing > watermarks on a noop in 2 separate commits. > > This patch no longer clears the crtc watermark state, but recalculates > it completely. Regardless whether a

[Intel-gfx] [PULL] drm-intel-next

Hi Dave, Final feature pull for 4.6, with this it's Jani's turn again. drm-intel-next-2016-02-29: - fbc by default on hsw, thanks to great work by Paulo! - psr by default hsw,bdw,vlv, thanks to great work by Rodrigo! - fixes to hw state readout vs. rpm issues (Imre) - dc3 fixes (Mika), this and