[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix integer overflow tests

== Series Details == Series: drm/i915: Fix integer overflow tests URL : https://patchwork.freedesktop.org/series/28898/ State : success == Summary == Series 28898v1 drm/i915: Fix integer overflow tests https://patchwork.freedesktop.org/api/1.0/series/28898/revisions/1/mbox/ Test

[Intel-gfx] [PATCH] drm/i915: Do not do link training fallback or prune modes for eDP

In case of eDP because the panel has a fixed mode we cannot link train fallback and prune modes since this results in no modes available for eDP connector. Also since its a panel, link training should not fail dynamically based on cable conditions like in case of DP. Cc: Jani Nikula

Re: [Intel-gfx] [PATCH v2] drm/i915: Beef up the IPS vs. CRC workaround

FYI, when I rebased to drm-tip to test this there is now also a call to the old: "hsw_trans_edp_pipe_A_crc_wa" from "intel_crtc_set_crc_source". I replaced that in the same manner as you did in " pipe_crc_set_source". With that this was tested OK. Tested-by: Marta Lofsted

Re: [Intel-gfx] [maintainer-tools PATCH 2/2] dim: Accept patchwork URLs as apply-branch optional argument.

On Wed, 16 Aug 2017, Rodrigo Vivi wrote: > Instead of having to manually download mbox from patchwork > let's make dim to do it directly. > > Cc: Daniel Vetter > Cc: Jani Nikula > Signed-off-by: Rodrigo Vivi

Re: [Intel-gfx] [maintainer-tools PATCH 2/2] dim: Accept patchwork URLs as apply-branch optional argument.

On Wed, 16 Aug 2017, Rodrigo Vivi wrote: > On Wed, Aug 16, 2017 at 11:13 AM, Rodrigo Vivi wrote: >> Instead of having to manually download mbox from patchwork >> let's make dim to do it directly. >> >> Cc: Daniel Vetter >>

Re: [Intel-gfx] [PATCH i-g-t] intel-ci: Add fast-feedback-simulation.testlist

On Wed, Aug 16, 2017 at 05:30:08PM -0700, Kelvin Gardiner wrote: > > > On 16/08/17 07:04, Daniel Vetter wrote: > > On Wed, Aug 16, 2017 at 11:33 AM, Petri Latvala > > wrote: > > > On Tue, Jun 27, 2017 at 02:04:51PM -0700, Kelvin Gardiner wrote: > > > > Added an initial

Re: [Intel-gfx] [maintainer-tools PATCH 1/2] dim: Accept .mbox and .patch files as apply-branch optional argument.

On Thu, Aug 17, 2017 at 10:30:02AM +0300, Jani Nikula wrote: > On Wed, 16 Aug 2017, Rodrigo Vivi wrote: > > Instead of forcing users to cat .patch or .mbox let's accept them > > as optional argument for dim apply-branches. > > Well, that's a useless use of cat anyway. You

Re: [Intel-gfx] [PATCH] drm/i915: Do not do link training fallback or prune modes for eDP

On Wed, Aug 16, 2017 at 11:51 PM Manasi Navare wrote: > In case of eDP because the panel has a fixed mode we cannot > link train fallback and prune modes since this results in > no modes available for eDP connector. What about downclock modes?! > > Also since its a

Re: [Intel-gfx] [maintainer-tools PATCH 1/2] dim: Accept .mbox and .patch files as apply-branch optional argument.

On Wed, 16 Aug 2017, Rodrigo Vivi wrote: > Instead of forcing users to cat .patch or .mbox let's accept them > as optional argument for dim apply-branches. Well, that's a useless use of cat anyway. You could do $ dim apply-branch branch < patch.mbox > Cc: Daniel Vetter

[Intel-gfx] [PATCH] drm/i915: Fix integer overflow tests

There are some potential integer overflows here on 64 bit systems. The condition "if (nfences > SIZE_MAX / sizeof(*fences))" can only be true on 32 bit systems, it's a no-op on 64 bit, so let's ignore the check for now and look a couple lines after: if (!access_ok(VERIFY_READ, user,

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Do not do link training fallback or prune modes for eDP

== Series Details == Series: drm/i915: Do not do link training fallback or prune modes for eDP URL : https://patchwork.freedesktop.org/series/28900/ State : success == Summary == Series 28900v1 drm/i915: Do not do link training fallback or prune modes for eDP

Re: [Intel-gfx] [PATCH v2] drm/i915: Beef up the IPS vs. CRC workaround

Op 16-08-17 om 16:39 schreef ville.syrj...@linux.intel.com: > From: Ville Syrjälä > > Oneshot disabling of IPS when CRC capturing is started is insufficient. > IPS may get re-enabled by any plane update, and hence tests that keep > CRC capturing on across plane

Re: [Intel-gfx] [maintainer-tools PATCH 1/2] dim: Accept .mbox and .patch files as apply-branch optional argument.

On Thu, 17 Aug 2017, Daniel Vetter wrote: > One thing we maybe could be doing is a more fancy aliasing feature, along > the lines of git aliases, where you can do whatever you want. Then you > could do a dim apply-curl alias which resolves to curl $arg | dim apply. > Not sure how

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix integer overflow tests (rev2)

== Series Details == Series: drm/i915: Fix integer overflow tests (rev2) URL : https://patchwork.freedesktop.org/series/28898/ State : success == Summary == Series 28898v2 drm/i915: Fix integer overflow tests https://patchwork.freedesktop.org/api/1.0/series/28898/revisions/2/mbox/ Test

[Intel-gfx] [PATCH v2] drm/i915: Prevent overflow of execbuf.buffer_count and num_cliprects

We check whether the multiplies will overflow prior to calling kmalloc_array so that we can respond with -EINVAL for the invalid user arguments rather than treating it as an -ENOMEM that would otherwise occur. However, as Dan Carpenter pointed out, we did an addition on the unsigned int prior to

Re: [Intel-gfx] [PATCH i-g-t] tools/intel_vbt_decode: Fix decoding of child device structure

On Wed, 16 Aug 2017, Clint Taylor wrote: > This patch fixes the alignment. I spotted another issue with teh > structure and will fix it once this one is merged. I'm sure there are plenty of issues; patches welcome! BR, Jani. > > Reviewed-by: Clint Taylor

Re: [Intel-gfx] [PATCH] drm/i915: Do not do link training fallback or prune modes for eDP

On Wed, 16 Aug 2017, Manasi Navare wrote: > In case of eDP because the panel has a fixed mode we cannot > link train fallback and prune modes since this results in > no modes available for eDP connector. > Also since its a panel, link training should not fail

Re: [Intel-gfx] [PATCH] drm/i915: Fix integer overflow tests

On Thu, Aug 17, 2017 at 12:37:00PM +0300, Imre Deak wrote: > On Thu, Aug 17, 2017 at 09:23:10AM +0300, Dan Carpenter wrote: > > There are some potential integer overflows here on 64 bit systems. > > > > The condition "if (nfences > SIZE_MAX / sizeof(*fences))" can only be > > true on 32 bit

Re: [Intel-gfx] [patch net-next 0/3] net/sched: Improve getting objects by indexes

Am 16.08.2017 um 04:12 schrieb Chris Mi: Using current TC code, it is very slow to insert a lot of rules. In order to improve the rules update rate in TC, we introduced the following two changes: 1) changed cls_flower to use IDR to manage the filters. 2) changed all act_xxx

Re: [Intel-gfx] [patch net-next 0/3] net/sched: Improve getting objects by indexes

Quoting Christian König (2017-08-16 08:49:07) > Am 16.08.2017 um 04:12 schrieb Chris Mi: > > Using current TC code, it is very slow to insert a lot of rules. > > > > In order to improve the rules update rate in TC, > > we introduced the following two changes: > > 1) changed cls_flower to

Re: [Intel-gfx] [PATCH] drm/i915: Fix integer overflow tests

On Thu, Aug 17, 2017 at 09:23:10AM +0300, Dan Carpenter wrote: > There are some potential integer overflows here on 64 bit systems. > > The condition "if (nfences > SIZE_MAX / sizeof(*fences))" can only be > true on 32 bit systems, it's a no-op on 64 bit, so let's ignore the > check for now and

Re: [Intel-gfx] [maintainer-tools PATCH 1/2] dim: Accept .mbox and .patch files as apply-branch optional argument.

On Thu, Aug 17, 2017 at 10:12 AM, Jani Nikula wrote: > On Thu, 17 Aug 2017, Daniel Vetter wrote: >> One thing we maybe could be doing is a more fancy aliasing feature, along >> the lines of git aliases, where you can do whatever you want. Then you >> could

Re: [Intel-gfx] [PATCH] drm/i915: Fix integer overflow tests

On Thu, Aug 17, 2017 at 12:50:37PM +0300, Dan Carpenter wrote: > On Thu, Aug 17, 2017 at 12:37:00PM +0300, Imre Deak wrote: > > On Thu, Aug 17, 2017 at 09:23:10AM +0300, Dan Carpenter wrote: > > > There are some potential integer overflows here on 64 bit systems. > > > > > > The condition "if

[Intel-gfx] [PATCH] drm/i915: Prevent overflow of execbuf.buffer_count and num_cliprects

We check whether the multiplies will overflow prior to calling kmalloc_array so that we can respond with -EINVAL for the invalid user arguments rather than treating it as an -ENOMEM that would otherwise occur. However, as Dan Carpenter pointed out, we did an addition on the unsigned int prior to

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/opregion: let user specify override VBT via firmware load (rev2)

== Series Details == Series: drm/i915/opregion: let user specify override VBT via firmware load (rev2) URL : https://patchwork.freedesktop.org/series/25105/ State : success == Summary == Series 25105v2 drm/i915/opregion: let user specify override VBT via firmware load

Re: [Intel-gfx] [PATCH v2] drm/i915: Beef up the IPS vs. CRC workaround

On Thu, Aug 17, 2017 at 10:00:52AM +0200, Maarten Lankhorst wrote: > Op 16-08-17 om 16:39 schreef ville.syrj...@linux.intel.com: > > From: Ville Syrjälä > > > > Oneshot disabling of IPS when CRC capturing is started is insufficient. > > IPS may get re-enabled by any

Re: [Intel-gfx] [PATCH v3 4/4] drm/i915: Acquire PUNIT->PMIC bus for intel_uncore_forcewake_reset()

On Mon, Aug 14, 2017 at 09:58:32PM +0200, Hans de Goede wrote: > intel_uncore_forcewake_reset() does forcewake puts and gets as such > we need to make sure that no-one tries to access the PUNIT->PMIC bus > (on systems where this bus is shared) while it runs, otherwise bad > things happen. > >

Re: [Intel-gfx] [PATCH v2] drm/i915: Beef up the IPS vs. CRC workaround

On Thu, Aug 17, 2017 at 03:16:46PM +0300, Ville Syrjälä wrote: > On Thu, Aug 17, 2017 at 10:00:52AM +0200, Maarten Lankhorst wrote: > > Op 16-08-17 om 16:39 schreef ville.syrj...@linux.intel.com: > > > From: Ville Syrjälä > > > > > > Oneshot disabling of IPS when

[Intel-gfx] [PATCH v2] drm/i915/bxt: use NULL for GPIO connection ID

The commit 213e08ad60ba ("drm/i915/bxt: add bxt dsi gpio element support") enables GPIO support for Broxton based platforms. While using that API we might get into troubles in the future, because we can't rely on label name in the driver since vendor firmware might provide any GPIO pin

Re: [Intel-gfx] [PATCH v2] drm/i915/bxt: use NULL for GPIO connection ID

Tested with GLK + MIPI/DSI panel (AU Optronics B101UAN01) Tested-by: Mika Kahola On Thu, 2017-08-17 at 13:55 +0300, Andy Shevchenko wrote: > The commit 213e08ad60ba > ("drm/i915/bxt: add bxt dsi gpio element support") > enables GPIO support for Broxton based

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/bxt: use NULL for GPIO connection ID (rev2)

== Series Details == Series: drm/i915/bxt: use NULL for GPIO connection ID (rev2) URL : https://patchwork.freedesktop.org/series/20011/ State : success == Summary == Series 20011v2 drm/i915/bxt: use NULL for GPIO connection ID

[Intel-gfx] [PATCH v3 RESEND] drm/i915/opregion: let user specify override VBT via firmware load

Sometimes it would be most enlightening to debug systems by replacing the VBT to be used. For example, in the referenced bug the BIOS provides different VBT depending on the boot mode (UEFI vs. legacy). It would be interesting to try the failing boot mode with the VBT from the working boot, and

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix integer overflow tests (rev3)

== Series Details == Series: drm/i915: Fix integer overflow tests (rev3) URL : https://patchwork.freedesktop.org/series/28898/ State : success == Summary == Series 28898v3 drm/i915: Fix integer overflow tests https://patchwork.freedesktop.org/api/1.0/series/28898/revisions/3/mbox/ Test

[Intel-gfx] [PATCH] drm/i915: Boost GPU clocks if we miss the pageflip's vblank

If we miss the current vblank because the gpu was busy, that may cause a jitter as the frame rate temporarily drops. We try to limit the impact of this by then boosting the GPU clock to deliver the frame as quickly as possible. Originally done in commit 6ad790c0f5ac ("drm/i915: Boost GPU frequency

Re: [Intel-gfx] [PATCH 3/3] drm/i915/cnl: Avoid old DDI translation functions on Cannonlake.

On Thu, 2017-07-06 at 13:54 -0700, Rodrigo Vivi wrote: > Cannonlake uses a different swing voltage initalization > sequence scheme that doesn't require these old functions. > > All other DDI, voltage swing and PLLs initialialization > and configuration are already in place for Cannonlake. > This

Re: [Intel-gfx] [PATCH] drm/i915: Split pin mapping into per platform functions

>-Original Message- >From: Zanoni, Paulo R >Sent: Thursday, August 17, 2017 1:24 PM >To: Srivatsa, Anusha ; intel- >g...@lists.freedesktop.org >Cc: Ville Syrjala ; Vivi, Rodrigo >; Taylor, Clinton A

Re: [Intel-gfx] [PATCH] drm/i915: Do not do link training fallback or prune modes for eDP

On Thu, Aug 17, 2017 at 1:11 PM, Pandiyan, Dhinakaran wrote: > On Thu, 2017-08-17 at 12:46 -0700, Manasi Navare wrote: >> On Thu, Aug 17, 2017 at 07:01:05AM +, Rodrigo Vivi wrote: >> >On Wed, Aug 16, 2017 at 11:51 PM Manasi Navare >> >

Re: [Intel-gfx] [PATCH] drm/i915: Split pin mapping into per platform functions

Em Qua, 2017-08-16 às 16:45 -0700, Anusha Srivatsa escreveu: > Cleanup the code. Map the pins in accordance to > individual platforms rather than according to ports. > Create separate functions for platforms. > > v2: >  - Add missing condition for CoffeeLake. Make platform >  specific functions

Re: [Intel-gfx] [PATCH] drm/i915: Do not do link training fallback or prune modes for eDP

On Thu, Aug 17, 2017 at 02:01:05PM -0700, Manasi Navare wrote: > On Thu, Aug 17, 2017 at 01:11:00PM -0700, Pandiyan, Dhinakaran wrote: > > On Thu, 2017-08-17 at 12:46 -0700, Manasi Navare wrote: > > > On Thu, Aug 17, 2017 at 07:01:05AM +, Rodrigo Vivi wrote: > > > >On Wed, Aug 16, 2017 at

Re: [Intel-gfx] [PATCH] drm/i915: Do not do link training fallback or prune modes for eDP

On Thu, Aug 17, 2017 at 01:44:14PM -0700, Rodrigo Vivi wrote: > On Thu, Aug 17, 2017 at 1:11 PM, Pandiyan, Dhinakaran > wrote: > > On Thu, 2017-08-17 at 12:46 -0700, Manasi Navare wrote: > >> On Thu, Aug 17, 2017 at 07:01:05AM +, Rodrigo Vivi wrote: > >> >On

Re: [Intel-gfx] [PATCH] drm/i915: Do not do link training fallback or prune modes for eDP

On Thu, Aug 17, 2017 at 01:11:00PM -0700, Pandiyan, Dhinakaran wrote: > On Thu, 2017-08-17 at 12:46 -0700, Manasi Navare wrote: > > On Thu, Aug 17, 2017 at 07:01:05AM +, Rodrigo Vivi wrote: > > >On Wed, Aug 16, 2017 at 11:51 PM Manasi Navare > > ><[1]manasi.d.nav...@intel.com> wrote: >

Re: [Intel-gfx] [PATCH 2/8] drm/i915: Check has_infoframes when enabling infoframes

On Fri, May 19, 2017 at 04:17:19PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > has_infoframe is what tells us whether infoframes should be enabled, so > let's pass that instead of has_hdmi_sink to .set_infoframes(). makes sense

Re: [Intel-gfx] [PATCH v2 8/8] drm/i915: Constify states passed to enable/disable/etc. encoder hooks

On Fri, May 19, 2017 at 04:17:25PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > The enable/disable/etc. encoder hooks aren't supposed to alter the > state(s), so pass them as const. Unfortunately C lacks any kind of deep > const thingy, so

[Intel-gfx] [PATCH] drm/i915/dp: Fix the channel equalization failure condition during Link Training

In the channel EQ retry loop, we break from the loop in case of failure to get link status or failure in clock recovery or failure to update link training. In these cases channel_eq_status is still false even though the retry loop has not reached max retries. So we need to consider this as a

[Intel-gfx] [RFC v1 1/2] drm/i915/pmu: reorder function to suite next patch

This patch is doing nover except reordering functions to highlight changes in the next patch. Change-Id: I0cd298780503ae8f6f8035b86c59fc8b5191356b Signed-off-by: Dmitry Rogozhkin Cc: Tvrtko Ursulin Cc: Peter Zijlstra

[Intel-gfx] [RFC v1 0/2] Support perf stat with i915 PMU

These patches depend on the RFC patches enabling i915 PMU from Tvrtko: https://patchwork.freedesktop.org/series/27488/ Thus, CI failure to build them is expected. I think that my patches should be squeashed in Tvrtko's one actually. The first patch simply reorders functions and does nothing now

Re: [Intel-gfx] [PATCH 6/8] drm/i915: Plumb crtc_state to PSR enable/disable

On Fri, May 19, 2017 at 04:17:23PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > The PSR enable/disable need to know things about the crtc state, so > plumb it through. This will become even more important when we start > to reuse the

Re: [Intel-gfx] [PATCH 7/8] drm/i915: Remove mostly duplicated video DIP handling from PSR code

On Fri, May 19, 2017 at 04:17:24PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Now that the infoframe hooks are part of the intel_dig_port, we can use > the normal .write_infoframe() hook to update the VSC SDP. We do need to > deal with

Re: [Intel-gfx] [PATCH v2 1/8] drm/dp: Add defines for DP SDP types

On Fri, May 19, 2017 at 04:17:18PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Add defines for the secondary data packet (SDP) types from the spec. > These are the DP specific ones, and in addition HDMI infoframe types > (see enum

Re: [Intel-gfx] [RFC 2/2] drm/i915/pmu: serve global events and support perf stat

On Tue, 2017-08-15 at 10:56 -0700, Dmitry Rogozhkin wrote: > This patch should probably be squashed with Tvrtko's PMU enabling > patch... > > i915 events don't have a CPU context to work with, so i915 > PMU should work in global mode, i.e. expose perf_invalid_context. > This will make the

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dp: Fix the channel equalization failure condition during Link Training

== Series Details == Series: drm/i915/dp: Fix the channel equalization failure condition during Link Training URL : https://patchwork.freedesktop.org/series/28960/ State : success == Summary == Series 28960v1 drm/i915/dp: Fix the channel equalization failure condition during Link Training

Re: [Intel-gfx] [PATCH] drm/i915: Do not do link training fallback or prune modes for eDP

On Thursday, August 17, 2017 1:44:14 PM PDT Rodrigo Vivi wrote: > On Thu, Aug 17, 2017 at 1:11 PM, Pandiyan, Dhinakaran > > wrote: > > On Thu, 2017-08-17 at 12:46 -0700, Manasi Navare wrote: > >> On Thu, Aug 17, 2017 at 07:01:05AM +, Rodrigo Vivi wrote: > >> >

[Intel-gfx] [RFC v1 2/2] drm/i915/pmu: serve global events and support perf stat

This patch should probably be squashed with Tvrtko's PMU enabling patch... i915 events don't have a CPU context to work with, so i915 PMU should work in global mode, i.e. expose perf_invalid_context. This will make the following call to perf: perf stat -e i915/rcs0-busy/ workload.sh to error

[Intel-gfx] ✗ Fi.CI.BAT: warning for Fixed16.16 wrapper cleanup & wm optimization (rev7)

== Series Details == Series: Fixed16.16 wrapper cleanup & wm optimization (rev7) URL : https://patchwork.freedesktop.org/series/25692/ State : warning == Summary == Series 25692v7 Fixed16.16 wrapper cleanup & wm optimization

[Intel-gfx] [PATCH v3] drm/i915: Beef up the IPS vs. CRC workaround

From: Ville Syrjälä Oneshot disabling of IPS when CRC capturing is started is insufficient. IPS may get re-enabled by any plane update, and hence tests that keep CRC capturing on across plane updates will start to see inconsistent results as soon as IPS kicks back

Re: [Intel-gfx] [PATCH 0/8] Fixed16.16 wrapper cleanup & wm optimization

Hi, My bad, I forgot to modify cover-letter before sending series to intel-gfx. yes this is for upstream consideration. -Mahesh On Thursday 17 August 2017 08:10 PM, Jani Nikula wrote: On Thu, 17 Aug 2017, Mahesh Kumar wrote: This is a Trybot Version of series.

Re: [Intel-gfx] [PATCH 6/7] drm/i915: Trivial grammar fix s/opt of/opt out of/ in comment

On Wed, 2017-08-16 at 09:52 +0100, Chris Wilson wrote: > The word out was dropped from the sentence across the line break, put it > back. > > Signed-off-by: Chris Wilson Reviewed-by: Joonas Lahtinen Regards, Joonas -- Joonas Lahtinen

Re: [Intel-gfx] [PATCH 7/7] drm/i915: Mark the GT as busy before idling the previous request

On Wed, 2017-08-16 at 09:52 +0100, Chris Wilson wrote: > In a synchronous setup, we may retire the last request before we > complete allocating the next request. As the last request is retired, we > queue a timer to mark the device as idle, and promptly have to execute > ad cancel that timer once

[Intel-gfx] [PATCH 5/8] drm/i915/cnl: Extend WM workaround with IPC for CNL

From: "Kumar, Mahesh" CNL:A & CNL:B have same workaround as KBL to increase wm level latency by 4us if IPC is enabled. Signed-off-by: Mahesh Kumar Reviewed-by: Maarten Lankhorst ---

[Intel-gfx] [PATCH 6/8] drm/i915/gen9+: Add has_ipc flag in device info structure

From: "Kumar, Mahesh" New Isochronous Priority Control (IPC) capability is introduced in newer GEN platforms. This patch adds a device info flag to indicate if platform supports IPC. Patch also sets this flag in supported platforms. Signed-off-by: Mahesh Kumar

[Intel-gfx] [PATCH 2/8] drm/i915/skl+: Optimize WM calculation

From: "Kumar, Mahesh" Plane configuration parameters doesn't change for each WM-level calculation. Currently we compute same parameters 8 times for each wm-level. This patch optimizes it by calculating these parameters in beginning & reuse during each level-wm

[Intel-gfx] [PATCH 4/8] drm/i915/glk: IPC linetime watermark workaround for GLK

From: "Kumar, Mahesh" IF IPC is enabled LINETIME_WM value should be half of calculated value line time = ROUNDDOWN(1/2 * Calculated Line Time) Earlier code was rounding-up the value, But updated Bspec says we should take the ROUNDDOWN. This patch corrects that as well.

Re: [Intel-gfx] [PATCH] drm/i915: Fix integer overflow tests

On Thu, Aug 17, 2017 at 07:16:03AM -0700, Jason Ekstrand wrote: > On Thu, Aug 17, 2017 at 2:56 AM, Imre Deak wrote: > > > On Thu, Aug 17, 2017 at 12:50:37PM +0300, Dan Carpenter wrote: > > > On Thu, Aug 17, 2017 at 12:37:00PM +0300, Imre Deak wrote: > > > > On Thu, Aug 17,

[Intel-gfx] [PATCH v2] drm/i915: Mark the GT as busy before idling the previous request

In a synchronous setup, we may retire the last request before we complete allocating the next request. As the last request is retired, we queue a timer to mark the device as idle, and promptly have to execute ad cancel that timer once we complete allocating the request and need to keep the device

[Intel-gfx] [PATCH 1/8] drm/i915: Fixed point fixed16 wrapper cleanup

From: "Kumar, Mahesh" As per suggestion from Jani, cleanup the code. Cleanup includes - Instead of left shifting & check, compare with U32/16_MAX - Use typecast instead of clamp_t Signed-off-by: Mahesh Kumar Cc: Jani Nikula

[Intel-gfx] [PATCH 0/8] Fixed16.16 wrapper cleanup & wm optimization

This is a Trybot Version of series. This series Include patches for: clean fixed16.16 wrappers optimize wm calculation code enable/Implement trans wm calculation create a DebugFS entry for IPC status Kumar, Mahesh (8): drm/i915: Fixed point fixed16 wrapper

[Intel-gfx] [PATCH 7/8] drm/i915/bxt+: Enable IPC support

From: "Kumar, Mahesh" This patch adds IPC support. This patch also enables IPC in all supported platforms based on has_ipc flag. IPC (Isochronous Priority Control) is the hardware feature, which dynamically controls the memory read priority of Display. When IPC is

[Intel-gfx] [PATCH 8/8] drm/i915/skl+: debugfs entry to control IPC

From: "Kumar, Mahesh" This patch creates an entry in debugfs to check the status of IPC. This can also be used to enable/disable IPC in supported platforms. Changes since V1: - fix use of HAS_IPC - use kstrtobool_from_user (Maarten) - drm_info log, while enabling IPC

[Intel-gfx] [PATCH 3/8] drm/i915/gen10: Calculate and enable transition WM

From: "Kumar, Mahesh" GEN > 9 require transition WM to be programmed if IPC is enabled. This patch calculates & enable transition WM for supported platforms. If transition WM is enabled, Plane read requests are sent at high priority until filling above the transition

Re: [Intel-gfx] [PATCH] drm/i915: Add has_psr-flag to gen9lp

On Tue, Aug 08, 2017 at 12:50:51PM -0700, Rodrigo Vivi wrote: > a long time ago I had agreed with Daniel that we would only add new > platforms after it was enabled by default on previous platforms. > a big reason for that is that we was willing to reduce the platforms > to validate and do better

Re: [Intel-gfx] [PATCH] drm/i915: Fix integer overflow tests

On Thu, Aug 17, 2017 at 2:56 AM, Imre Deak wrote: > On Thu, Aug 17, 2017 at 12:50:37PM +0300, Dan Carpenter wrote: > > On Thu, Aug 17, 2017 at 12:37:00PM +0300, Imre Deak wrote: > > > On Thu, Aug 17, 2017 at 09:23:10AM +0300, Dan Carpenter wrote: > > > > There are some

Re: [Intel-gfx] [PATCH 0/8] Fixed16.16 wrapper cleanup & wm optimization

On Thu, 17 Aug 2017, Mahesh Kumar wrote: > This is a Trybot Version of series. What do you mean? Is this for upstream consideration or not? BR, Jani. -- Jani Nikula, Intel Open Source Technology Center ___ Intel-gfx mailing

Re: [Intel-gfx] [RFC i-g-t] igt/gem_ringfill: Adds full ringbuffer preemption test

On 15/08/17 15:35, Chris Wilson wrote: Quoting Antonio Argenziano (2017-08-15 22:44:21) Sending as RFC to get feedback on what would be the correct behaviour of the driver and, therefore, if the test is valid. It's not a preemption specific bug. It is fair to say that any client blocking

Re: [Intel-gfx] [RFC i-g-t] igt/gem_ringfill: Adds full ringbuffer preemption test

Quoting Antonio Argenziano (2017-08-17 16:14:04) > > > On 15/08/17 15:35, Chris Wilson wrote: > > Quoting Antonio Argenziano (2017-08-15 22:44:21) > >> Sending as RFC to get feedback on what would be the correct behaviour of > >> the driver and, therefore, if the test is valid. > > > > It's not

Re: [Intel-gfx] [PATCH igt 2/3] igt/gem_exec_schedule: Basic tests for preemption

Quoting Michał Winiarski (2017-08-17 15:39:12) > On Thu, Aug 03, 2017 at 01:30:28PM +0100, Chris Wilson wrote: > > We queue N low priority hanging batches across the engines > > and check that out high priority write over takes them. > > s/out/our > > > > > Signed-off-by: Chris Wilson

[Intel-gfx] [PATCH i-g-t 3/3] tests: Introduce audio tests, starting with HDMI signal integrity

This introduces a new test for audio going through display connectors. It currently contains a single subtest for HDMI signal integrity, but other test cases will be added later on. The test setup consists in using an HDMI-VGA bridge that separates the audio out (via a 3.5 mm jack) and feeding

[Intel-gfx] [PATCH i-g-t 2/3] lib: Add ALSA library with dedicated helpers

This introduces an ALSA library, with dedicated helpers for handling playback and capture. It handles ALSA device identification and configuration as well as a run loop with callback mechanisms for feeding output data and handling input data. This library paves the way for testing audio going

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] lib: Add audio library with dedicated helpers

== Series Details == Series: series starting with [1/3] lib: Add audio library with dedicated helpers URL : https://patchwork.freedesktop.org/series/28929/ State : success == Summary == IGT patchset tested on top of latest successful build 5a17ee2c8f9013f5db852d27564b837f9f2c5a9f

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/7] drm/i915: Don't use MI_STORE_DWORD_IMM on Sandybridge/vcs (rev2)

== Series Details == Series: series starting with [1/7] drm/i915: Don't use MI_STORE_DWORD_IMM on Sandybridge/vcs (rev2) URL : https://patchwork.freedesktop.org/series/28859/ State : success == Summary == Series 28859v2 Series without cover letter

Re: [Intel-gfx] [maintainer-tools PATCH 2/2] dim: Accept patchwork URLs as apply-branch optional argument.

On Thu, Aug 17, 2017 at 12:37 AM, Jani Nikula wrote: > On Wed, 16 Aug 2017, Rodrigo Vivi wrote: >> Instead of having to manually download mbox from patchwork >> let's make dim to do it directly. >> >> Cc: Daniel Vetter >>

Re: [Intel-gfx] [maintainer-tools PATCH 2/2] dim: Accept patchwork URLs as apply-branch optional argument.

On Thu, Aug 17, 2017 at 12:45 AM, Jani Nikula wrote: > On Wed, 16 Aug 2017, Rodrigo Vivi wrote: >> On Wed, Aug 16, 2017 at 11:13 AM, Rodrigo Vivi >> wrote: >>> Instead of having to manually download mbox from patchwork >>>

Re: [Intel-gfx] [PATCH 2/7] drm/i915: Check context status before looking up our obj/vma

Quoting Mika Kuoppala (2017-08-17 15:10:02) > Chris Wilson writes: > > > Since we keep the context around across the slow lookup where we may > > drop the struct_mutex, we should double check that the context is still > > valid upon reacquisition. > > > > Signed-off-by:

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: Beef up the IPS vs. CRC workaround (rev3)

== Series Details == Series: drm/i915: Beef up the IPS vs. CRC workaround (rev3) URL : https://patchwork.freedesktop.org/series/17084/ State : warning == Summary == Series 17084v3 drm/i915: Beef up the IPS vs. CRC workaround

[Intel-gfx] [PATCH i-g-t 1/3] lib: Add audio library with dedicated helpers

This introduces an audio library, with dedicated helpers for both generating signals and detecting peak frequencies in a signal. This library paves the way for testing audio going through display connectors, such as HDMI. Signed-off-by: Paul Kocialkowski ---

Re: [Intel-gfx] [maintainer-tools PATCH 1/2] dim: Accept .mbox and .patch files as apply-branch optional argument.

On Thu, Aug 17, 2017 at 12:57 AM, Daniel Vetter wrote: > On Thu, Aug 17, 2017 at 10:30:02AM +0300, Jani Nikula wrote: >> On Wed, 16 Aug 2017, Rodrigo Vivi wrote: >> > Instead of forcing users to cat .patch or .mbox let's accept them >> > as optional

Re: [Intel-gfx] [maintainer-tools PATCH 2/2] dim: Accept patchwork URLs as apply-branch optional argument.

On Thu, Aug 17, 2017 at 9:18 AM, Rodrigo Vivi wrote: > On Thu, Aug 17, 2017 at 12:45 AM, Jani Nikula wrote: >> On Wed, 16 Aug 2017, Rodrigo Vivi wrote: >>> On Wed, Aug 16, 2017 at 11:13 AM, Rodrigo Vivi

Re: [Intel-gfx] [PATCH] drm/i915: decouple runtime PM enablement from DMC presence

On Mon, Jun 19, 2017 at 11:45 AM, Jani Nikula wrote: > > On Thu, 15 Jun 2017, Imre Deak wrote: > > On Thu, Jun 15, 2017 at 10:20:57AM -0700, Rodrigo Vivi wrote: > >> I believe it is worth allowing RPM to work without requiring DMC, no?! > > > >

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Boost GPU clocks if we miss the pageflip's vblank

== Series Details == Series: drm/i915: Boost GPU clocks if we miss the pageflip's vblank URL : https://patchwork.freedesktop.org/series/28921/ State : failure == Summary == Series 28921v1 drm/i915: Boost GPU clocks if we miss the pageflip's vblank

Re: [Intel-gfx] [PATCH 2/7] drm/i915: Check context status before looking up our obj/vma

Chris Wilson writes: > Since we keep the context around across the slow lookup where we may > drop the struct_mutex, we should double check that the context is still > valid upon reacquisition. > > Signed-off-by: Chris Wilson > Cc: Tvrtko

Re: [Intel-gfx] [PATCH igt 2/3] igt/gem_exec_schedule: Basic tests for preemption

On Thu, Aug 03, 2017 at 01:30:28PM +0100, Chris Wilson wrote: > We queue N low priority hanging batches across the engines > and check that out high priority write over takes them. s/out/our > > Signed-off-by: Chris Wilson I'm getting stuck on throttle when spawning

Re: [Intel-gfx] [PATCH i-g-t] intel-ci: Add fast-feedback-simulation.testlist

On 17/08/17 00:50, Daniel Vetter wrote: On Wed, Aug 16, 2017 at 05:30:08PM -0700, Kelvin Gardiner wrote: On 16/08/17 07:04, Daniel Vetter wrote: On Wed, Aug 16, 2017 at 11:33 AM, Petri Latvala wrote: On Tue, Jun 27, 2017 at 02:04:51PM -0700, Kelvin Gardiner

Re: [Intel-gfx] [PATCH v3 RESEND] drm/i915/opregion: let user specify override VBT via firmware load

On Thu, 17 Aug 2017, Jani Nikula wrote: > Sometimes it would be most enlightening to debug systems by replacing > the VBT to be used. For example, in the referenced bug the BIOS provides > different VBT depending on the boot mode (UEFI vs. legacy). It would be > interesting

Re: [Intel-gfx] [PATCH] drm/i915/cnl: Enable Audio Pin Buffer.

On Thu, 2017-08-17 at 18:55 +, Vivi, Rodrigo wrote: > On Thu, 2017-08-17 at 09:26 +0530, Sanyog Kale wrote: > > On Wed, Aug 16, 2017 at 06:46:26PM -0500, Pandiyan, Dhinakaran wrote: > > > On Thu, 2017-07-06 at 14:03 -0700, Rodrigo Vivi wrote: > > > > Starting on CNL, we need to enable Audio

Re: [Intel-gfx] [PATCH v5] drm/i915/edp: Be less aggressive about changing link config on eDP

On Thu, Aug 17, 2017 at 10:50:04AM -0700, Jim Bride wrote: > On Wed, Aug 16, 2017 at 03:13:06PM -0700, Manasi Navare wrote: > > On Wed, Aug 09, 2017 at 02:21:07PM -0700, Jim Bride wrote: > > > This set of changes has some history to them. There were several attempts > > > to add what was called

Re: [Intel-gfx] [PATCH] drm/i915: Do not do link training fallback or prune modes for eDP

On Thu, Aug 17, 2017 at 12:51:27PM +0300, Jani Nikula wrote: > On Wed, 16 Aug 2017, Manasi Navare wrote: > > In case of eDP because the panel has a fixed mode we cannot > > link train fallback and prune modes since this results in > > no modes available for eDP

[Intel-gfx] [PATCH] drm/i915: Stop touching forcewake following a gen6+ engine reset

Forcewake is not affected by the engine reset on gen6+. Indeed the reason why we added intel_uncore_forcewake_reset() to gen6_reset_engines() was to keep the bookkeeping intact because the reset did not touch the forcewake bit (yet we cancelled the forcewake consumers)! This was done in commit

Re: [Intel-gfx] [PATCH 3/3] drm/i915/cnl: Avoid old DDI translation functions on Cannonlake.

On Thu, 2017-08-17 at 15:59 +0300, Mika Kahola wrote: > On Thu, 2017-07-06 at 13:54 -0700, Rodrigo Vivi wrote: > > Cannonlake uses a different swing voltage initalization > > sequence scheme that doesn't require these old functions. > > > > All other DDI, voltage swing and PLLs initialialization

Re: [Intel-gfx] [PATCH] drm/i915/cnl: Enable Audio Pin Buffer.

On Thu, 2017-08-17 at 09:26 +0530, Sanyog Kale wrote: > On Wed, Aug 16, 2017 at 06:46:26PM -0500, Pandiyan, Dhinakaran wrote: > > On Thu, 2017-07-06 at 14:03 -0700, Rodrigo Vivi wrote: > > > Starting on CNL, we need to enable Audio Pin Buffer. > > > > > > By the spec it seems that this is part of

Re: [Intel-gfx] [maintainer-tools PATCH] dim.rst: Document aliases extension on dimrc.

On Thu, 17 Aug 2017, Rodrigo Vivi wrote: > On my own workflow I was missing a way to download mboxes > directly from patchwork with the patchwork id. So my first > reflex was to modify dim to fulfil my needs. However that > was increasing dim in complexity and dependencies

Re: [Intel-gfx] [maintainer-tools PATCH] dim.rst: Document aliases extension on dimrc.

On Thu, Aug 17, 2017 at 10:33 AM, Jani Nikula wrote: > On Thu, 17 Aug 2017, Rodrigo Vivi wrote: >> On my own workflow I was missing a way to download mboxes >> directly from patchwork with the patchwork id. So my first >> reflex was to modify dim to

  1   2   >