[Intel-gfx] [PATCH v20 12/18] drm/i915: Set scaler mode for NV12

2018-04-06 Thread Vidya Srinivas
From: Chandra Konduru This patch sets appropriate scaler mode for NV12 format. In this mode, skylake scaler does either chroma-upsampling or chroma-upsampling and resolution scaling v2: Review comments from Ville addressed NV12 case to be checked first for setting the

[Intel-gfx] [PATCH v20 09/18] drm/i915/skl: split skl_compute_ddb function

2018-04-06 Thread Vidya Srinivas
From: Mahesh Kumar This patch splits skl_compute_wm/ddb functions into two parts. One adds all affected pipes after the commit to atomic_state structure and second part does compute the DDB. v2: Added reviewed by tag from Shashank Sharma v3: Added reviewed by from

[Intel-gfx] [PATCH v20 00/18] Add NV12 support

2018-04-06 Thread Vidya Srinivas
This patch series is adding NV12 support for Broxton display after rebasing on latest drm-tip. Initial series of the patches can be found here: https://lists.freedesktop.org/archives/intel-gfx/2015-May/066786.html Previous revision history: The first version of patches were reviewed when floated

[Intel-gfx] [PATCH v20 04/18] drm/i915/skl+: support verification of DDB HW state for NV12

2018-04-06 Thread Vidya Srinivas
From: Mahesh Kumar For YUV 420 Planar formats like NV12, buffer allocation is done for Y and UV surfaces separately. For NV12 plane formats, the UV buffer allocation must be programmed in the Plane Buffer Config register and the Y buffer allocation must be programmed in

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/execlists: Log fence context & seqno throughout GEM_TRACE (rev2)

2018-04-06 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Log fence context & seqno throughout GEM_TRACE (rev2) URL : https://patchwork.freedesktop.org/series/41263/ State : success == Summary == Series 41263v2 drm/i915/execlists: Log fence context & seqno throughout GEM_TRACE

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Enclose for_each_engine_masked macro arguments in parentheses (rev2)

2018-04-06 Thread Patchwork
== Series Details == Series: drm/i915: Enclose for_each_engine_masked macro arguments in parentheses (rev2) URL : https://patchwork.freedesktop.org/series/41261/ State : success == Summary == Series 41261v2 drm/i915: Enclose for_each_engine_masked macro arguments in parentheses

Re: [Intel-gfx] [PATCH v2] drm/i915: Enclose for_each_engine_masked macro arguments in parentheses

2018-04-06 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-04-06 12:44:07) > From: Tvrtko Ursulin > > Enclose for_each_engine_masked macro arguments in parentheses. > > v2: > * Fixup whitespace to satisfy checkpatch. > * Likewise reformat to 80 chars. > > Signed-off-by: Tvrtko Ursulin

[Intel-gfx] [PATCH v20 18/18] drm/i915: Do not do fb src adjustments for NV12

2018-04-06 Thread Vidya Srinivas
We skip src trunction/adjustments for NV12 case and handle the sizes directly. Without this, pipe fifo underruns are seen on APL/KBL. Credits-to: Maarten Lankhorst Signed-off-by: Vidya Srinivas --- drivers/gpu/drm/i915/intel_sprite.c

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/4] drm/i915: Only call finish_reset after a prepare_reset (rev2)

2018-04-06 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Only call finish_reset after a prepare_reset (rev2) URL : https://patchwork.freedesktop.org/series/41204/ State : failure == Summary == Applying: drm/i915: Only call finish_reset after a prepare_reset Using index info to

[Intel-gfx] [PATCH v3] drm/i915/execlists: Log fence context & seqno throughout GEM_TRACE

2018-04-06 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Include fence context and seqno in low level tracing so it is easier to follow flows of individual requests when things go bad. Also added tracing on the reset side of things. v2: Chris Wilson: * Standardize global_seqno and seqno as global. *

[Intel-gfx] [PATCH v20 18/18] drm/i915: Do not do fb src adjustments for NV12

2018-04-06 Thread Vidya Srinivas
We skip src trunction/adjustments for NV12 case and handle the sizes directly. Without this, pipe fifo underruns are seen on APL/KBL. Credits-to: Maarten Lankhorst Signed-off-by: Vidya Srinivas --- drivers/gpu/drm/i915/intel_sprite.c

Re: [Intel-gfx] [PATCH v2] drm/i915: set minimum CD clock to twice the BCLK.

2018-04-06 Thread kbuild test robot
/linux/commits/Abhay-Kumar/drm-i915-set-minimum-CD-clock-to-twice-the-BCLK/20180406-143913 base: git://anongit.freedesktop.org/drm-intel for-linux-next config: x86_64-randconfig-x001-201813 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config

[Intel-gfx] [PATCH igt] igt/gem_eio: Require context support before creation

2018-04-06 Thread Chris Wilson
gem_context_create() nowadays assumes you have already checked for context support and asserts for any error. So check first. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105924 Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin ---

Re: [Intel-gfx] [PATCH igt] igt/gem_eio: Require context support before creation

2018-04-06 Thread Tvrtko Ursulin
On 06/04/2018 10:11, Chris Wilson wrote: gem_context_create() nowadays assumes you have already checked for context support and asserts for any error. So check first. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=105924 Signed-off-by: Chris Wilson Cc: Tvrtko

Re: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Enclose for_each_engine_masked macro arguments in parentheses

2018-04-06 Thread Chris Wilson
Quoting Patchwork (2018-04-06 10:29:45) > == Series Details == > > Series: drm/i915: Enclose for_each_engine_masked macro arguments in > parentheses > URL : https://patchwork.freedesktop.org/series/41261/ > State : warning > > == Summary == > > $ dim checkpatch origin/drm-tip > e31cc0477730

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Enclose for_each_engine_masked macro arguments in parentheses

2018-04-06 Thread Patchwork
== Series Details == Series: drm/i915: Enclose for_each_engine_masked macro arguments in parentheses URL : https://patchwork.freedesktop.org/series/41261/ State : failure == Summary == Series 41261v1 drm/i915: Enclose for_each_engine_masked macro arguments in parentheses

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Avoid repeatedly harming the same innocent context

2018-04-06 Thread Tvrtko Ursulin
On 06/04/2018 10:40, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-04-06 10:11:57) On 30/03/2018 14:18, Chris Wilson wrote: if (!wait_for_hang(, prev)) { This was confusing me a period since I was assuming the seqno check is against the breadcrumb, but it is

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Log fence context & seqno throughout GEM_TRACE

2018-04-06 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-04-06 10:54:57) > From: Tvrtko Ursulin > > Include fence context and seqno in low level tracing so it is easier to > follow flows of individual requests when things go bad. > > Also added tracing on the reset side of things. > >

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for Documentation patch for batchbuffer submission (rev5)

2018-04-06 Thread Joonas Lahtinen
Merged these (documentation only changes). Thanks for the patches! Regards, Joonas Quoting Patchwork (2018-04-06 11:29:26) > == Series Details == > > Series: Documentation patch for batchbuffer submission (rev5) > URL : https://patchwork.freedesktop.org/series/38433/ > State : failure > > ==

Re: [Intel-gfx] [PATCH] drm/i915: throw __must_check at GEM_WARN_ON

2018-04-06 Thread Joonas Lahtinen
Quoting Matthew Auld (2018-04-04 14:19:04) > GEM_WARN_ON is intended to be used as: > > if (GEM_WARN_ON(expr)) > ... > > However this isn't clear since we just wrap WARN_ON, therefore throw a > warning if the result is ignored. For !DRM_I915_DEBUG_GEM builds this > should already be the

Re: [Intel-gfx] [PATCH] drm/i915: throw __must_check at GEM_WARN_ON

2018-04-06 Thread Chris Wilson
Quoting Joonas Lahtinen (2018-04-06 12:29:01) > Quoting Matthew Auld (2018-04-04 14:19:04) > > GEM_WARN_ON is intended to be used as: > > > > if (GEM_WARN_ON(expr)) > > ... > > > > However this isn't clear since we just wrap WARN_ON, therefore throw a > > warning if the result is

[Intel-gfx] [PATCH v2] drm/i915: Enclose for_each_engine_masked macro arguments in parentheses

2018-04-06 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Enclose for_each_engine_masked macro arguments in parentheses. v2: * Fixup whitespace to satisfy checkpatch. * Likewise reformat to 80 chars. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_drv.h | 6

[Intel-gfx] [PATCH] drm/i915/selftests: Rename wait_for_hang() to wait_until_running()

2018-04-06 Thread Chris Wilson
Tvrtko mentioned that wait_for_hang() was confusing as it does not actually wait for the aforementioned hang, just until the request is running and we are *ready* to inject a hang. A quick s/wait_for_hang/wait_until_running/ removes that confusion without having to rethink the naming scheme,

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/5] drm/i915/icl: Add reset control register changes (rev3)

2018-04-06 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915/icl: Add reset control register changes (rev3) URL : https://patchwork.freedesktop.org/series/41214/ State : success == Summary == Series 41214v3 series starting with [1/5] drm/i915/icl: Add reset control register changes

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Rename wait_for_hang() to wait_until_running()

2018-04-06 Thread Tvrtko Ursulin
On 06/04/2018 11:09, Chris Wilson wrote: Tvrtko mentioned that wait_for_hang() was confusing as it does not actually wait for the aforementioned hang, just until the request is running and we are *ready* to inject a hang. A quick s/wait_for_hang/wait_until_running/ removes that confusion

Re: [Intel-gfx] [PATCH v2] drm/i915/execlists: Log fence context & seqno throughout GEM_TRACE

2018-04-06 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-04-06 12:36:51) > From: Tvrtko Ursulin > > Include fence context and seqno in low level tracing so it is easier to > follow flows of individual requests when things go bad. > > Also added tracing on the reset side of things. > > v2: >

[Intel-gfx] ✗ Fi.CI.BAT: failure for Documentation patch for batchbuffer submission (rev5)

2018-04-06 Thread Patchwork
== Series Details == Series: Documentation patch for batchbuffer submission (rev5) URL : https://patchwork.freedesktop.org/series/38433/ State : failure == Summary == Series 38433v5 Documentation patch for batchbuffer submission

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Enclose for_each_engine_masked macro arguments in parentheses

2018-04-06 Thread Patchwork
== Series Details == Series: drm/i915: Enclose for_each_engine_masked macro arguments in parentheses URL : https://patchwork.freedesktop.org/series/41261/ State : warning == Summary == $ dim checkpatch origin/drm-tip e31cc0477730 drm/i915: Enclose for_each_engine_masked macro arguments in

Re: [Intel-gfx] [PATCH] drm/i915: Enclose for_each_engine_masked macro arguments in parentheses

2018-04-06 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-04-06 10:24:17) > From: Tvrtko Ursulin > > Enclose for_each_engine_masked macro arguments in parentheses. > > Signed-off-by: Tvrtko Ursulin > --- > drivers/gpu/drm/i915/i915_drv.h | 4 ++-- > 1 file changed, 2

Re: [Intel-gfx] [PATCH] drm/i915: Enclose for_each_engine_masked macro arguments in parentheses

2018-04-06 Thread Chris Wilson
Quoting Chris Wilson (2018-04-06 10:29:36) > Quoting Tvrtko Ursulin (2018-04-06 10:24:17) > > From: Tvrtko Ursulin > > > > Enclose for_each_engine_masked macro arguments in parentheses. > > > > Signed-off-by: Tvrtko Ursulin > > --- > >

[Intel-gfx] [PATCH] drm/i915/execlists: Log fence context & seqno throughout GEM_TRACE

2018-04-06 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Include fence context and seqno in low level tracing so it is easier to follow flows of individual requests when things go bad. Also added tracing on the reset side of things. Signed-off-by: Tvrtko Ursulin ---

Re: [Intel-gfx] [Freedreno] [PATCH 01/10] include: Move ascii85 functions from i915 to linux/ascii85.h

2018-04-06 Thread Chris Wilson
Quoting Jordan Crouse (2018-04-05 23:06:53) > On Thu, Apr 05, 2018 at 04:00:47PM -0600, Jordan Crouse wrote: > > The i915 DRM driver very cleverly used ascii85 encoding for their > > GPU state file. Move the encode functions to a general header file to > > support other drivers that might be

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/5] drm/i915/icl: Add reset control register changes (rev3)

2018-04-06 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915/icl: Add reset control register changes (rev3) URL : https://patchwork.freedesktop.org/series/41214/ State : warning == Summary == $ dim checkpatch origin/drm-tip 27c0b6b10865 drm/i915/icl: Add reset control register changes

[Intel-gfx] [PATCH v2] drm/i915/execlists: Log fence context & seqno throughout GEM_TRACE

2018-04-06 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Include fence context and seqno in low level tracing so it is easier to follow flows of individual requests when things go bad. Also added tracing on the reset side of things. v2: Chris Wilson: * Standardize global_seqno and seqno as global. *

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915/execlists: Log fence context & seqno throughout GEM_TRACE

2018-04-06 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Log fence context & seqno throughout GEM_TRACE URL : https://patchwork.freedesktop.org/series/41263/ State : warning == Summary == Series 41263v1 drm/i915/execlists: Log fence context & seqno throughout GEM_TRACE

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix memory leak in intel_hdcp auth

2018-04-06 Thread Jani Nikula
On Thu, 05 Apr 2018, "Srivatsa, Anusha" wrote: > Earlier, I responded to the wrong version of the patch :( > Apologies. > >>-Original Message- >>From: Sripada, Radhakrishna >>Sent: Wednesday, April 4, 2018 4:00 PM >>To: intel-gfx@lists.freedesktop.org >>Cc:

[Intel-gfx] [PATCH v5 2/3] i915.rst: add link to documentation in i915_gem_execbuffer.c

2018-04-06 Thread kevin . rogovin
From: Kevin Rogovin Add the documentation of "DOC: User command execution" of i915_gem_execbuffer.c into a new section in i915.rst. Signed-off-by: Kevin Rogovin Reviewed-by: Joonas Lahtinen ---

[Intel-gfx] [PATCH v5 1/3] i915.rst: Narration overview on GEM + minor reorder to improve narration

2018-04-06 Thread kevin . rogovin
From: Kevin Rogovin Add a narration to i915.rst about Intel GEN GPU's: engines, driver context and relocation. v5: More type fixes. Flow bullet list so lines are not too long. Signed-off-by: Kevin Rogovin Reviewed-by: Joonas Lahtinen

[Intel-gfx] [PATCH v5 3/3] i915: add a text about what happens at bottom of stack in processing a batchbuffer

2018-04-06 Thread kevin . rogovin
From: Kevin Rogovin Now that "DOC: User command execution" of i915_gem_execbuffer.c is included in the i915.rst, it is benecifial (for new developers) to read what happens at the bottom of the driver stack (in terms of bytes written to be read by the GPU) when processing

[Intel-gfx] [PATCH v5 0/3] Documentation patch for batchbuffer submission

2018-04-06 Thread kevin . rogovin
From: Kevin Rogovin v5: In interest of getting reviewed patches in sonner, last two patches dropped for a later series. Permute patch order of 2 and 3 (this is what the v4 series should have had). v4: Drop some details from narration to provide better

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Avoid repeatedly harming the same innocent context

2018-04-06 Thread Tvrtko Ursulin
On 30/03/2018 14:18, Chris Wilson wrote: We don't handle resetting the kernel context very well, or presumably any context executing its breadcrumb commands in the ring as opposed to the batchbuffer and flush. If we trigger a device reset twice in quick succession while the kernel context is

Re: [Intel-gfx] [PATCH igt 1/2] lib: Acquire master for pollable spinbatch on gen4/5

2018-04-06 Thread Tvrtko Ursulin
On 05/04/2018 19:47, Chris Wilson wrote: gen4/5 require a DRM_MASTER to use MI_STORE_DW, make it so. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- lib/igt_dummyload.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff

Re: [Intel-gfx] [PATCH igt 2/2] igt/gem_eio: Drop DRM_MASTER so we can reacquire it in the subtests

2018-04-06 Thread Tvrtko Ursulin
On 05/04/2018 19:47, Chris Wilson wrote: As we reopen the fd for each subtest, and we need a DRM_MASTER, we need to drop master on the original before we are allowed to claim DRM_MASTER on the second. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin

Re: [Intel-gfx] [PATCH] drm/i915: Fix audio issue on BXT

2018-04-06 Thread Jani Nikula
On Thu, 05 Apr 2018, "Pandiyan, Dhinakaran" wrote: > On Thu, 2018-04-05 at 22:12 +0530, Gaurav K Singh wrote: >> On Apollolake, with stress test warm reboot, audio card >> was not getting enumerated after reboot. This was a >> spurious issue happening on

Re: [Intel-gfx] ✗ Fi.CI.IGT: warning for drm: i915: Fix audio issue on BXT (rev3)

2018-04-06 Thread Jani Nikula
On Thu, 05 Apr 2018, Patchwork wrote: > == Series Details == > > Series: drm: i915: Fix audio issue on BXT (rev3) > URL : https://patchwork.freedesktop.org/series/35955/ > State : warning > > == Summary == > > Possible new issues: > > Test kms_flip: >

Re: [Intel-gfx] [PATCH igt 2/2] igt/gem_eio: Drop DRM_MASTER so we can reacquire it in the subtests

2018-04-06 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-04-06 09:35:41) > > On 05/04/2018 19:47, Chris Wilson wrote: > > As we reopen the fd for each subtest, and we need a DRM_MASTER, we need > > to drop master on the original before we are allowed to claim DRM_MASTER > > on the second. > > > > Signed-off-by: Chris

Re: [Intel-gfx] [PATCH 3/7] drm/vmwgfx: Stop using plane->fb in vmw_kms_helper_dirty()

2018-04-06 Thread kbuild test robot
/0day-ci/linux/commits/Ville-Syrjala/drm-arc-Stop-consulting-plane-fb/20180406-155056 base: git://people.freedesktop.org/~airlied/linux.git drm-next config: x86_64-randconfig-x010-201813 (attached as .config) compiler: gcc-7 (Debian 7.3.0-1) 7.3.0 reproduce: # save the attached .config

[Intel-gfx] ✗ Fi.CI.BAT: failure for Documentation patch for batchbuffer submission (rev5)

2018-04-06 Thread Patchwork
== Series Details == Series: Documentation patch for batchbuffer submission (rev5) URL : https://patchwork.freedesktop.org/series/38433/ State : failure == Summary == Series 38433v5 Documentation patch for batchbuffer submission

Re: [Intel-gfx] [PATCH igt 2/2] igt/gem_eio: Drop DRM_MASTER so we can reacquire it in the subtests

2018-04-06 Thread Tvrtko Ursulin
On 06/04/2018 09:51, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-04-06 09:35:41) On 05/04/2018 19:47, Chris Wilson wrote: As we reopen the fd for each subtest, and we need a DRM_MASTER, we need to drop master on the original before we are allowed to claim DRM_MASTER on the second.

[Intel-gfx] [PATCH] drm/i915: Enclose for_each_engine_masked macro arguments in parentheses

2018-04-06 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Enclose for_each_engine_masked macro arguments in parentheses. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_drv.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Avoid repeatedly harming the same innocent context

2018-04-06 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-04-06 10:11:57) > > On 30/03/2018 14:18, Chris Wilson wrote: > > if (!wait_for_hang(, prev)) { > > This was confusing me a period since I was assuming the seqno check is > against the breadcrumb, but it is actually about the same number written

Re: [Intel-gfx] [PATCH 1/7] drm/arc: Stop consulting plane->fb

2018-04-06 Thread Alexey Brodkin
Hi Ville, On Thu, 2018-04-05 at 22:50 +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > We want to stop using plane->fb with atomic driver, so stop looking at > it. > > I have no idea what this code is trying to achieve. There is no > corresponding check in

[Intel-gfx] [PATCH 4/5] drm/i915/icl: Deal with GT INT DW correctly

2018-04-06 Thread Mika Kuoppala
From: Oscar Mateo BSpec says: "Second level interrupt events are stored in the GT INT DW. GT INT DW is a double buffered structure. A snapshot of events is taken when SW reads GT INT DW. From the time of read to the time of SW completely clearing GT INT DW (to indicate

[Intel-gfx] [PATCH 2/5] drm/i915/icl: Use hw engine class, instance to find irq handler

2018-04-06 Thread Mika Kuoppala
Interrupt identity register we already read from hardware contains engine class and instance fields. Leverage these fields to find correct engine to handle the interrupt. v3: rebase on top of rps intr use correct class / instance limits (Michel) v4: split engine/other handling v5: empty iir

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Enclose for_each_engine_masked macro arguments in parentheses (rev2)

2018-04-06 Thread Patchwork
== Series Details == Series: drm/i915: Enclose for_each_engine_masked macro arguments in parentheses (rev2) URL : https://patchwork.freedesktop.org/series/41261/ State : failure == Summary == Possible new issues: Test kms_atomic: Subgroup plane_invalid_params_fence:

Re: [Intel-gfx] [PATCH] drm/i915: Split out parking from the idle worker for reuse

2018-04-06 Thread Michal Wajdeczko
On Fri, 06 Apr 2018 16:33:39 +0200, Chris Wilson wrote: We will want to park GEM before disengaging the drive^W^W^W unwedging. Since we already do the work for idling, expose the guts as a new function that we can then reuse. v2: Just skip if already parked; makes

Re: [Intel-gfx] [PATCH] drm/i915: Split out parking from the idle worker for reuse

2018-04-06 Thread Chris Wilson
Quoting Michal Wajdeczko (2018-04-06 16:18:53) > On Fri, 06 Apr 2018 16:33:39 +0200, Chris Wilson > wrote: > > > We will want to park GEM before disengaging the drive^W^W^W unwedging. > > Since we already do the work for idling, expose the guts as a new > > function

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/selftests: Rename wait_for_hang() to wait_until_running()

2018-04-06 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Rename wait_for_hang() to wait_until_running() URL : https://patchwork.freedesktop.org/series/41264/ State : failure == Summary == Possible new issues: Test gem_pipe_control_store_loop: Subgroup reused-buffer: pass

[Intel-gfx] ✗ Fi.CI.IGT: warning for igt/gem_eio: Require context support before creation

2018-04-06 Thread Patchwork
== Series Details == Series: igt/gem_eio: Require context support before creation URL : https://patchwork.freedesktop.org/series/41260/ State : warning == Summary == Possible new issues: Test kms_frontbuffer_tracking: Subgroup fbc-2p-scndscrn-cur-indfb-move: pass

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Split out parking from the idle worker for reuse

2018-04-06 Thread Patchwork
== Series Details == Series: drm/i915: Split out parking from the idle worker for reuse URL : https://patchwork.freedesktop.org/series/41278/ State : success == Summary == Series 41278v1 drm/i915: Split out parking from the idle worker for reuse

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/selftests: Rename wait_for_hang() to wait_until_running()

2018-04-06 Thread Chris Wilson
Quoting Patchwork (2018-04-06 16:04:14) > == Series Details == > > Series: drm/i915/selftests: Rename wait_for_hang() to wait_until_running() > URL : https://patchwork.freedesktop.org/series/41264/ > State : failure > > == Summary == > > Possible new issues: > > Test

Re: [Intel-gfx] [PATCH] drm/i915: Split out parking from the idle worker for reuse

2018-04-06 Thread Chris Wilson
Quoting Chris Wilson (2018-04-06 16:21:04) > Quoting Michal Wajdeczko (2018-04-06 16:18:53) > > On Fri, 06 Apr 2018 16:33:39 +0200, Chris Wilson > > wrote: > > > > > We will want to park GEM before disengaging the drive^W^W^W unwedging. > > > Since we already do the

Re: [Intel-gfx] [PATCH v2] drm/i915: set minimum CD clock to twice the BCLK.

2018-04-06 Thread Jani Nikula
On Thu, 05 Apr 2018, Abhay Kumar wrote: > In glk when device boots with 1366x768 panel, HDA codec doesn't comeup. > This result in no audio forever as cdclk is < 96Mhz. > This chagne will ensure CD clock to be twice of BCLK. In short, we can't poke around CDCLK like this.

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/5] drm/i915/icl: Add reset control register changes (rev3)

2018-04-06 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915/icl: Add reset control register changes (rev3) URL : https://patchwork.freedesktop.org/series/41214/ State : success == Summary == Possible new issues: Test kms_atomic: Subgroup plane_invalid_params_fence:

[Intel-gfx] ✓ Fi.CI.BAT: success for igt/gem_eio: Require context support before creation

2018-04-06 Thread Patchwork
== Series Details == Series: igt/gem_eio: Require context support before creation URL : https://patchwork.freedesktop.org/series/41260/ State : success == Summary == IGT patchset tested on top of latest successful build 8a7353abf41eb3dbbde240ac5f7ac26f92ed693a tests/kms_psr_sink_crc: Save

[Intel-gfx] [PATCH] drm/i915: Split out parking from the idle worker for reuse

2018-04-06 Thread Chris Wilson
We will want to park GEM before disengaging the drive^W^W^W unwedging. Since we already do the work for idling, expose the guts as a new function that we can then reuse. v2: Just skip if already parked; makes it more forgiving to use by future callers. Signed-off-by: Chris Wilson

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Park before resetting the submission backend

2018-04-06 Thread Michal Wajdeczko
On Fri, 06 Apr 2018 14:25:48 +0200, Chris Wilson wrote: Quoting Sagar Arun Kamble (2018-04-05 12:54:38) On 4/5/2018 4:32 PM, Chris Wilson wrote: > As different backends may have different park/unpark callbacks, we > should only ever switch backends

[Intel-gfx] ✗ Fi.CI.BAT: warning for Add NV12 support (rev10)

2018-04-06 Thread Patchwork
== Series Details == Series: Add NV12 support (rev10) URL : https://patchwork.freedesktop.org/series/39670/ State : warning == Summary == Series 39670v10 Add NV12 support https://patchwork.freedesktop.org/api/1.0/series/39670/revisions/10/mbox/ Possible new issues: Test

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Park before resetting the submission backend

2018-04-06 Thread Chris Wilson
Quoting Michal Wajdeczko (2018-04-06 14:39:28) > On Fri, 06 Apr 2018 14:25:48 +0200, Chris Wilson > wrote: > > > Quoting Sagar Arun Kamble (2018-04-05 12:54:38) > >> > >> > >> On 4/5/2018 4:32 PM, Chris Wilson wrote: > >> > As different backends may have different

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/execlists: Log fence context & seqno throughout GEM_TRACE (rev2)

2018-04-06 Thread Patchwork
== Series Details == Series: drm/i915/execlists: Log fence context & seqno throughout GEM_TRACE (rev2) URL : https://patchwork.freedesktop.org/series/41263/ State : failure == Summary == Possible new issues: Test kms_atomic: Subgroup plane_invalid_params_fence:

Re: [Intel-gfx] [PATCH v3] drm/i915: Split out parking from the idle worker for reuse

2018-04-06 Thread Michal Wajdeczko
On Fri, 06 Apr 2018 17:51:44 +0200, Chris Wilson wrote: We will want to park GEM before disengaging the drive^W^W^W unwedging. Since we already do the work for idling, expose the guts as a new function that we can then reuse. v2: Just skip if already parked; makes

Re: [Intel-gfx] [PATCH] drm/i915/execlists: Set queue priority from secondary port

2018-04-06 Thread Chris Wilson
Quoting Chris Wilson (2018-03-29 10:39:00) > We can refine our current execlists->queue_priority if we inspect > ELSP[1] rather than the head of the unsubmitted queue. Currently, we use > the unsubmitted queue and say that if a subsequent request is more than > important than the current queue, we

[Intel-gfx] [PATCH v10 01/11] drm/modes: Introduce drm_mode_match()

2018-04-06 Thread Nautiyal, Ankit K
From: Ville Syrjälä Make mode matching less confusing by allowing the caller to specify which parts of the modes should match via some flags. Signed-off-by: Ville Syrjälä Reviewed-by: Shashank Sharma ---

[Intel-gfx] [PATCH v10 00/11] Aspect ratio support in DRM layer

2018-04-06 Thread Nautiyal, Ankit K
From: Ankit Nautiyal This patch series is a re-attempt to enable aspect ratio support in DRM layer. Currently the aspect ratio information gets lost in translation during a user->kernel mode or vice versa. The old patch series

[Intel-gfx] [PATCH v10 02/11] drm/edid: Use drm_mode_match_no_clocks_no_stereo() for consistentcy

2018-04-06 Thread Nautiyal, Ankit K
From: Ville Syrjälä Use drm_mode_equal_no_clocks_no_stereo() in drm_match_hdmi_mode_clock_tolerance() for consistency as we also use it in drm_match_hdmi_mode() and the cea mode matching functions. This doesn't actually change anything since the input mode comes

[Intel-gfx] [PATCH v10 07/11] drm: Add helper functions to handle aspect-ratio flag bits

2018-04-06 Thread Nautiyal, Ankit K
From: Ankit Nautiyal This patch adds helper functions for determining if aspect-ratio is expected in user-mode and for allowing/disallowing the aspect-ratio, if its not expected. Signed-off-by: Ankit Nautiyal ---

[Intel-gfx] [PATCH v10 03/11] drm/edid: Fix cea mode aspect ratio handling

2018-04-06 Thread Nautiyal, Ankit K
From: Ville Syrjälä commit 6dffd431e229 ("drm: Add aspect ratio parsing in DRM layer") cause us to not send out any VICs in the AVI infoframes. That commit was since reverted, but if and when we add aspect ratio handing back we need to be more careful. Let's

[Intel-gfx] [PATCH v10 06/11] drm: Add DRM client cap for aspect-ratio

2018-04-06 Thread Nautiyal, Ankit K
From: Ankit Nautiyal To enable aspect-ratio support in DRM, blindly exposing the aspect ratio information along with mode, can break things in existing user-spaces which have no intention or support to use this aspect ratio information. To avoid this, a new drm

[Intel-gfx] [PATCH v10 04/11] drm/edid: Don't send bogus aspect ratios in AVI infoframes

2018-04-06 Thread Nautiyal, Ankit K
From: Ville Syrjälä If the user mode would specify an aspect ratio other than 4:3 or 16:9 we now silently ignore it. Maybe a better apporoach is to return an error? Let's try that. Also we must be careful that we don't try to send illegal picture aspect in the

[Intel-gfx] [PATCH v10 08/11] drm: Handle aspect ratio info in legacy and atomic modeset paths

2018-04-06 Thread Nautiyal, Ankit K
From: Ankit Nautiyal If the user-space does not support aspect-ratio, and requests for a modeset with mode having aspect ratio bits set, then the given user-mode must be rejected. Secondly, while preparing a user-mode from kernel mode, the aspect-ratio info must not

[Intel-gfx] [PATCH v10 05/11] video/hdmi: Reject illegal picture aspect ratios

2018-04-06 Thread Nautiyal, Ankit K
From: Ville Syrjälä AVI infoframe can only carry none, 4:3, or 16:9 picture aspect ratios. Return an error if the user asked for something different. Cc: Shashank Sharma Cc: "Lin, Jia" Cc: Akashdeep Sharma

[Intel-gfx] [PATCH v10 09/11] drm: Expose modes with aspect ratio, only if requested

2018-04-06 Thread Nautiyal, Ankit K
From: Ankit Nautiyal We parse the EDID and add all the modes in the connector's modelist. This adds CEA modes with aspect ratio information too, regadless of whether user space requested this information or not. This patch prunes the modes with aspect-ratio

[Intel-gfx] [PATCH v10 11/11] drm: Add and handle new aspect ratios in DRM layer

2018-04-06 Thread Nautiyal, Ankit K
From: "Sharma, Shashank" HDMI 2.0/CEA-861-F introduces two new aspect ratios: - 64:27 - 256:135 This patch: - Adds new DRM flags for to represent these new aspect ratios. - Adds new cases to handle these aspect ratios while converting from user->kernel mode or vise

[Intel-gfx] [PATCH v10 10/11] drm: Add aspect ratio parsing in DRM layer

2018-04-06 Thread Nautiyal, Ankit K
From: "Sharma, Shashank" Current DRM layer functions don't parse aspect ratio information while converting a user mode->kernel mode or vice versa. This causes modeset to pick mode with wrong aspect ratio, eventually causing failures in HDMI compliance test cases, due

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Split out parking from the idle worker for reuse (rev2)

2018-04-06 Thread Patchwork
== Series Details == Series: drm/i915: Split out parking from the idle worker for reuse (rev2) URL : https://patchwork.freedesktop.org/series/41278/ State : success == Summary == Series 41278v2 drm/i915: Split out parking from the idle worker for reuse

Re: [Intel-gfx] [PATCH v2 3/4] drm/i915: Check hdcp key loadability

2018-04-06 Thread Ville Syrjälä
On Mon, Apr 02, 2018 at 02:35:42PM +0530, Ramalingam C wrote: > > > On Thursday 29 March 2018 07:54 PM, Ville Syrjälä wrote: > > On Thu, Mar 29, 2018 at 07:39:07PM +0530, Ramalingam C wrote: > >> HDCP1.4 key can be loaded, only when Power well #1 is enabled and cdclk > >> is enabled. Using the

Re: [Intel-gfx] [PATCH] drm/i915: Do NOT skip the first 4k of stolen memory for pre-allocated buffers

2018-04-06 Thread Ville Syrjälä
On Thu, Apr 05, 2018 at 01:37:31PM +0200, Hans de Goede wrote: > Hi, > > On 04-04-18 22:49, Ville Syrjälä wrote: > > On Wed, Apr 04, 2018 at 10:06:29PM +0200, Hans de Goede wrote: > >> Hi, > >> > >> On 04-04-18 17:50, Ville Syrjälä wrote: > >>> On Fri, Mar 30, 2018 at 04:26:53PM +0200, Hans de

[Intel-gfx] [PATCH v3] drm/i915: Split out parking from the idle worker for reuse

2018-04-06 Thread Chris Wilson
We will want to park GEM before disengaging the drive^W^W^W unwedging. Since we already do the work for idling, expose the guts as a new function that we can then reuse. v2: Just skip if already parked; makes it more forgiving to use by future callers. v3: Extract mark_busy, rename it to

Re: [Intel-gfx] [PATCH i-g-t v3] tests/kms_rotation_crc: Move platform checks to one place for non exhaust fence cases

2018-04-06 Thread Ville Syrjälä
On Thu, Mar 29, 2018 at 06:19:40AM +, Sripada, Radhakrishna wrote: > > > > -Original Message- > > From: Ville Syrjälä [mailto:ville.syrj...@linux.intel.com] > > Sent: Wednesday, March 28, 2018 3:36 AM > > To: Maarten Lankhorst > > Cc: Sripada,

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Split out parking from the idle worker for reuse (rev2)

2018-04-06 Thread Patchwork
== Series Details == Series: drm/i915: Split out parking from the idle worker for reuse (rev2) URL : https://patchwork.freedesktop.org/series/41278/ State : failure == Summary == Series 41278v2 drm/i915: Split out parking from the idle worker for reuse

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Aspect ratio support in DRM layer (rev2)

2018-04-06 Thread Patchwork
== Series Details == Series: Aspect ratio support in DRM layer (rev2) URL : https://patchwork.freedesktop.org/series/39960/ State : warning == Summary == $ dim checkpatch origin/drm-tip e9fb8279cbaa drm/modes: Introduce drm_mode_match() -:39: CHECK:PARENTHESIS_ALIGNMENT: Alignment should

Re: [Intel-gfx] [PATCH v10 10/11] drm: Add aspect ratio parsing in DRM layer

2018-04-06 Thread Nautiyal, Ankit K
This patch is causing failure of IGT test kms_3d. The kms_3d test expects the no. of 3d modes to be 13. (The test has hard-coded value for expected no. of 3d modes as 13) But due to the addition of "matching aspect_ratio" in drm_mode_equal in this patch, the total no. of modes in the

[Intel-gfx] [PATCH] drm/i915/psr: vbt change for psr

2018-04-06 Thread vathsala nagaraju
From: Vathsala Nagaraju For psr block #9, the vbt description has moved to options [0-3] for TP1,TP2,TP3 Wakeup time from decimal value without any change to vbt structure. Since spec does not mention from which VBT version this change was added to vbt.bsf file, we

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Split out parking from the idle worker for reuse

2018-04-06 Thread Patchwork
== Series Details == Series: drm/i915: Split out parking from the idle worker for reuse URL : https://patchwork.freedesktop.org/series/41278/ State : success == Summary == Known issues: Test kms_flip: Subgroup 2x-dpms-vs-vblank-race-interruptible: pass ->

Re: [Intel-gfx] [PATCH] drm/i915/psr: vbt change for psr

2018-04-06 Thread Rodrigo Vivi
On Fri, Apr 06, 2018 at 10:58:51PM +0530, vathsala nagaraju wrote: > From: Vathsala Nagaraju > > For psr block #9, the vbt description has moved to options [0-3] for > TP1,TP2,TP3 Wakeup time from decimal value without any change to vbt > structure. Since spec does

[Intel-gfx] ✓ Fi.CI.BAT: success for Aspect ratio support in DRM layer (rev2)

2018-04-06 Thread Patchwork
== Series Details == Series: Aspect ratio support in DRM layer (rev2) URL : https://patchwork.freedesktop.org/series/39960/ State : success == Summary == Series 39960v2 Aspect ratio support in DRM layer https://patchwork.freedesktop.org/api/1.0/series/39960/revisions/2/mbox/ Possible

Re: [Intel-gfx] [PATCH v10 10/11] drm: Add aspect ratio parsing in DRM layer

2018-04-06 Thread Ville Syrjälä
On Fri, Apr 06, 2018 at 10:55:14PM +0530, Nautiyal, Ankit K wrote: > This patch is causing failure of IGT test kms_3d. The kms_3d test > expects the no. of 3d modes to be 13. > > (The test has hard-coded value for expected no. of 3d modes as 13) > > But due to the addition of "matching

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/psr: vbt change for psr

2018-04-06 Thread Patchwork
== Series Details == Series: drm/i915/psr: vbt change for psr URL : https://patchwork.freedesktop.org/series/41289/ State : success == Summary == Series 41289v1 drm/i915/psr: vbt change for psr https://patchwork.freedesktop.org/api/1.0/series/41289/revisions/1/mbox/ Possible new issues:

<    1   2