✓ Fi.CI.BAT: success for drm/i915: Implemnt vblank sycnhronized mbus joining changes (rev2)

2024-03-28 Thread Patchwork
== Series Details == Series: drm/i915: Implemnt vblank sycnhronized mbus joining changes (rev2) URL : https://patchwork.freedesktop.org/series/131700/ State : success == Summary == CI Bug Log - changes from CI_DRM_14506 -> Patchwork_131700v2

✗ Fi.CI.SPARSE: warning for drm/i915: Implemnt vblank sycnhronized mbus joining changes (rev2)

2024-03-28 Thread Patchwork
== Series Details == Series: drm/i915: Implemnt vblank sycnhronized mbus joining changes (rev2) URL : https://patchwork.freedesktop.org/series/131700/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✓ Fi.CI.BAT: success for ASoC: SOF: Core: Add remove_late() to sof_init_environment failure path (rev2)

2024-03-28 Thread Patchwork
== Series Details == Series: ASoC: SOF: Core: Add remove_late() to sof_init_environment failure path (rev2) URL : https://patchwork.freedesktop.org/series/131767/ State : success == Summary == CI Bug Log - changes from CI_DRM_14506 -> Patchwork_131767v2

✗ Fi.CI.SPARSE: warning for ASoC: SOF: Core: Add remove_late() to sof_init_environment failure path (rev2)

2024-03-28 Thread Patchwork
== Series Details == Series: ASoC: SOF: Core: Add remove_late() to sof_init_environment failure path (rev2) URL : https://patchwork.freedesktop.org/series/131767/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2

Re: [PATCH] drm/i915/hwmon: Remove i915_hwmon_unregister() during driver unbind

2024-03-28 Thread Dixit, Ashutosh
On Wed, 27 Mar 2024 13:37:19 -0700, Dixit, Ashutosh wrote: > > On Wed, 27 Mar 2024 02:15:27 -0700, Krzysztofik, Janusz wrote: > > > > Hi Janusz, > > > For me, that still doesn't explain why you think that i915->hwmon reset to > > NULL on i915 driver unregister can be the root cause of the reported

✓ Fi.CI.BAT: success for Disable automatic load CCS load balancing (rev14)

2024-03-28 Thread Patchwork
== Series Details == Series: Disable automatic load CCS load balancing (rev14) URL : https://patchwork.freedesktop.org/series/129951/ State : success == Summary == CI Bug Log - changes from CI_DRM_14506 -> Patchwork_129951v14 Summary

✗ Fi.CI.SPARSE: warning for Disable automatic load CCS load balancing (rev14)

2024-03-28 Thread Patchwork
== Series Details == Series: Disable automatic load CCS load balancing (rev14) URL : https://patchwork.freedesktop.org/series/129951/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for Disable automatic load CCS load balancing (rev14)

2024-03-28 Thread Patchwork
== Series Details == Series: Disable automatic load CCS load balancing (rev14) URL : https://patchwork.freedesktop.org/series/129951/ State : warning == Summary == Error: dim checkpatch failed 9e5c201ff6d6 drm/i915/gt: Disable HW load balancing for CCS 165039e14345 drm/i915/gt: Do not

✓ Fi.CI.BAT: success for drm/i915/display_debugfs: Remove check for crtc in force bigjoiner

2024-03-28 Thread Patchwork
== Series Details == Series: drm/i915/display_debugfs: Remove check for crtc in force bigjoiner URL : https://patchwork.freedesktop.org/series/131770/ State : success == Summary == CI Bug Log - changes from CI_DRM_14506 -> Patchwork_131770v1

✓ Fi.CI.BAT: success for ALPM AUX-Less (rev8)

2024-03-28 Thread Patchwork
== Series Details == Series: ALPM AUX-Less (rev8) URL : https://patchwork.freedesktop.org/series/129938/ State : success == Summary == CI Bug Log - changes from CI_DRM_14505 -> Patchwork_129938v8 Summary --- **SUCCESS** No

✗ Fi.CI.SPARSE: warning for ALPM AUX-Less (rev8)

2024-03-28 Thread Patchwork
== Series Details == Series: ALPM AUX-Less (rev8) URL : https://patchwork.freedesktop.org/series/129938/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. +./arch/x86/include/asm/bitops.h:116:1: warning:

✗ Fi.CI.CHECKPATCH: warning for ALPM AUX-Less (rev8)

2024-03-28 Thread Patchwork
== Series Details == Series: ALPM AUX-Less (rev8) URL : https://patchwork.freedesktop.org/series/129938/ State : warning == Summary == Error: dim checkpatch failed b95867a71e6f drm/i915/psr: Add missing ALPM AUX-Less register definitions -:33: WARNING:LONG_LINE: line length of 169 exceeds 100

Re: [PATCH] drm/i915/guc: Remove bogus null check

2024-03-28 Thread Rodrigo Vivi
On Thu, Mar 28, 2024 at 10:41:55PM +0100, Andi Shyti wrote: > Hi Rodrigo, > > On Thu, Mar 28, 2024 at 05:31:07PM -0400, Rodrigo Vivi wrote: > > This null check is bogus because we are already using 'ce' stuff > > in many places before this function is called. > > > > Having this here is useless

[PULL] drm-intel-fixes

2024-03-28 Thread Rodrigo Vivi
Hi Dave and Sima, Here goes our first PR of this round. Our CI is not working as I would expect: https://intel-gfx-ci.01.org/tree/drm-intel-fixes/index.html? Well, at least it caught some build failures on runds 832 and 833. But after I fixed those, the 834 (with v6.9-rc1) and the 835 (with all

✗ Fi.CI.IGT: failure for drm/i915/gt: Limit the reserved VM space to only the platforms that need it

2024-03-28 Thread Patchwork
== Series Details == Series: drm/i915/gt: Limit the reserved VM space to only the platforms that need it URL : https://patchwork.freedesktop.org/series/131707/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14495_full -> Patchwork_131707v1_full

[PATCH] drm/i915: Fix i915_display_info output when connectors are not active

2024-03-28 Thread Ville Syrjala
From: Ville Syrjälä Currently intel_connector_info(), which prints the per-connector output for i915_display_info, just bails out early if the connector doesn't have a current encoder. That leads to very confusing output where some of your connected (and properly detected) outputs appear to have

✗ Fi.CI.BUILD: failure for spi: add driver for Intel discrete graphics

2024-03-28 Thread Patchwork
== Series Details == Series: spi: add driver for Intel discrete graphics URL : https://patchwork.freedesktop.org/series/131763/ State : failure == Summary == Error: patch https://patchwork.freedesktop.org/api/1.0/series/131763/revisions/1/mbox/ not applied Applying: spi: add auxiliary

[PATCH 22/22] drm/i915: Use debugfs_create_bool() for "i915_bigjoiner_force_enable"

2024-03-28 Thread Ville Syrjala
From: Ville Syrjälä There is no reason to make this debugfs file for a simple boolean so complicated. Just use debugfs_create_bool(). Signed-off-by: Ville Syrjälä --- .../drm/i915/display/intel_display_debugfs.c | 44 +-- 1 file changed, 2 insertions(+), 42 deletions(-) diff

[PATCH 21/22] drm/i915: Allow bigjoiner for MST

2024-03-28 Thread Ville Syrjala
From: Vidya Srinivas We need bigjoiner support with MST functionality for MST monitor resolutions > 5K to work. Adding support for the same. v2: Addressed review comments from Jani. Revert rejection of MST bigjoiner modes and add functionality v3: Fixed pipe_mismatch WARN for

[PATCH 20/22] drm/i915/mst: Add bigjoiner handling to MST modeset sequence

2024-03-28 Thread Ville Syrjala
From: Ville Syrjälä Loop over all joined pipes at relevant points in the MST modeset sequence. Carved out from Vidya's earlier big patch, with naming/etc. changed to match the earlier hsw_crtc_enable() stuff. Co-developed-by: Vidya Srinivas Signed-off-by: Vidya Srinivas Signed-off-by: Ville

[PATCH 18/22] drm/i915: Handle joined pipes inside hsw_crtc_disable()

2024-03-28 Thread Ville Syrjala
From: Ville Syrjälä Reorganize the crtc disable path to only deal with the master pipes/transcoders in intel_old_crtc_state_disables() and offload the handling of joined pipes to hsw_crtc_disable(). This makes the whole thing much more sensible since we can actually control the order in which we

[PATCH 19/22] drm/i915: Handle joined pipes inside hsw_crtc_enable()

2024-03-28 Thread Ville Syrjala
From: Stanislav Lisovskiy Handle only bigjoiner masters in skl_commit_modeset_enables/disables, slave crtcs should be handled by master hooks. Same for encoders. That way we can also remove a bunch of checks like intel_crtc_is_bigjoiner_slave. v2: - Moved skl_pfit_enable, intel_dsc_enable,

[PATCH 17/22] drm/i915: Utilize intel_crtc_joined_pipe_mask() more

2024-03-28 Thread Ville Syrjala
From: Ville Syrjälä Unify the master vs. slave handling in intel_ddi_post_disable_hdmi_or_sst() by looping over all the pipes in one go. This also lets us move the intel_crtc_vblank_off() calls to happen in a consistent place vs. the transcoder disable. Previously we did the master vs. slaves

[PATCH 16/22] drm/i915: Extract intel_ddi_post_disable_hdmi_or_sst()

2024-03-28 Thread Ville Syrjala
From: Ville Syrjälä Extract the "not-MST" stuff from intel_ddi_post_disable() so that the whole thing isn't so cluttered. The bigjoiner slave handling was outside of the !MST check, but it really should have been inside it as its the counterpart to the master handling inside the check. So we

[PATCH 15/22] drm/i915: Introduce intel_crtc_joined_pipe_mask()

2024-03-28 Thread Ville Syrjala
From: Ville Syrjälä Add a small helper to compute the set of pipes that the current crtc is using. And we have at least one trivial place in intel_ddi_update_active_dpll() where we can use it immediately, so let's do that. v2: Use the name 'pipe_crtc' for the per-pipe crtc pointer

[PATCH 14/22] drm/i915/mst: Reject FEC+MST on ICL

2024-03-28 Thread Ville Syrjala
From: Ville Syrjälä ICL supposedly doesn't support FEC on MST. Reject it. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_dp.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_dp.c

[PATCH 13/22] drm/i915/mst: Limit MST+DSC to TGL+

2024-03-28 Thread Ville Syrjala
From: Ville Syrjälä The MST code currently assumes that glk+ alerady supports MST+DSC, which is incorrect. We need to check for TGL+ actually. ICL does support SST+DSC, but supposedly it can't do MST+FEC which will also rule MST+DSC. Note that a straight TGL+ check doesn't work here because DSC

[PATCH 12/22] drm/i915: Pass connector to intel_dp_need_bigjoiner()

2024-03-28 Thread Ville Syrjala
From: Ville Syrjälä Pass the connector explicitly to intel_dp_need_bigjoiner() so that it'll actually check the correct place for the bigjoiner force flag. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_dp.c | 10 ++ drivers/gpu/drm/i915/display/intel_dp.h

[PATCH 10/22] drm/i915: Extract intel_dp_joiner_needs_dsc()

2024-03-28 Thread Ville Syrjala
From: Ville Syrjälä Pull the "does joiner need DSC?" check into a helper. MST will want to use this too at some point. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_dp.c | 26 ++--- drivers/gpu/drm/i915/display/intel_dp.h | 1 +

[PATCH 11/22] drm/i915/mst: Check intel_dp_joiner_needs_dsc()

2024-03-28 Thread Ville Syrjala
From: Ville Syrjälä intel_dp_mst_compute_config() is missing the "does the joiner need DSC?" check despite claiming to have a lot of other joiner/dsc stuff in there (albeit disabled). Replicate the logic from the SST side. TODO: refactor all this duplicated code! Signed-off-by: Ville Syrjälä

[PATCH 09/22] drm/i915: s/intel_dp_can_bigjoiner()/intel_dp_can_bigjoiner()/

2024-03-28 Thread Ville Syrjala
From: Ville Syrjälä Rename intel_dp_can_bigjoiner() to intel_dp_has_bigjoiner() to better reflect its function. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_dp.c | 4 ++-- drivers/gpu/drm/i915/display/intel_dp.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-)

[PATCH 08/22] drm/i915: Extract glk_need_scaler_clock_gating_wa()

2024-03-28 Thread Ville Syrjala
From: Ville Syrjälä Simplify our life by extracting the "do we need the glk scaler clock gating w/a?" check into a small helper. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 16 ++-- 1 file changed, 10 insertions(+), 6 deletions(-) diff --git

[PATCH 07/22] drm/i915: Clean up glk_pipe_scaler_clock_gating_wa()

2024-03-28 Thread Ville Syrjala
From: Ville Syrjälä glk_pipe_scaler_clock_gating_wa() is messy. Clean it up via intel_de_rmw(), and also just pass in the whole crtc so the caller doesn't dance around so much. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 19 +++ 1 file

[PATCH 06/22] drm/i915: Shuffle DP .mode_valid() checks

2024-03-28 Thread Ville Syrjala
From: Ville Syrjälä Move some of the more trivial checks in the DP .mode_valid() hooks upwards to lessen the noise amongst the more complex checks. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_dp.c | 6 +++--- drivers/gpu/drm/i915/display/intel_dp_mst.c | 21

[PATCH 05/22] drm/i915: Remove DRM_MODE_FLAG_DBLSCAN checks from .mode_valid() hooks

2024-03-28 Thread Ville Syrjala
From: Ville Syrjälä We never set connector->doublescan_allowed, so the probe helper already filters out all doublescan modes for us. Sadly we still need to keep the explicit doublescan checks in .compute_config as outlined in commit e4dd27aadd20 ("drm/i915: Allow DBLSCAN user modes with

[PATCH 04/22] drm/i915/vrr: Disable VRR when using bigjoiner

2024-03-28 Thread Ville Syrjala
From: Ville Syrjälä All joined pipes share the same transcoder/timing generator. Currently we just do the commits per-pipe, which doesn't really work if we need to change switch between non-VRR and VRR timings generators on the fly, or even when sending the push to the transcoder. For now just

[PATCH 03/22] drm/i915: Disable live M/N updates when using bigjoiner

2024-03-28 Thread Ville Syrjala
From: Ville Syrjälä All joined pipes share the same transcoder/timing generator. Currently we just do the commits per-pipe, which doesn't really work if we need to change the timings at the same time. For now just disable live M/N updates when bigjoiner is needed. Signed-off-by: Ville Syrjälä

[PATCH 02/22] drm/i915: Fix intel_modeset_pipe_config_late() for bigjoiner

2024-03-28 Thread Ville Syrjala
From: Ville Syrjälä Currently intel_modeset_pipe_config_late() is called after the bigjoiner state copy, and it will actually not do anything for bigjoiner slaves. This can lead to a mismatched state between the master and slave. The two things that we do in the encoder .compute_config_late()

[PATCH 00/22] drm/i915: Bigjoiner modeset sequence redesign and MST support

2024-03-28 Thread Ville Syrjala
From: Ville Syrjälä I started to look at the MST+bignoier stuff floating around and then decided that there's just too much noise in the way, and so did a quick pass over the whole thing to clean and fix things up ahead of time. I then applied the stuff from Stan and Vidya on top of what I had

[PATCH 01/22] drm/i915: Disable port sync when bigjoiner is used

2024-03-28 Thread Ville Syrjala
From: Ville Syrjälä The current modeset sequence can't handle port sync and bigjoiner at the same time. Refuse port sync when bigjoiner is needed, at least until we fix the modeset sequence. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_ddi.c | 1 + 1 file changed, 1

✓ Fi.CI.BAT: success for drm/i915: use fine grained -Woverride-init disable

2024-03-28 Thread Patchwork
== Series Details == Series: drm/i915: use fine grained -Woverride-init disable URL : https://patchwork.freedesktop.org/series/131753/ State : success == Summary == CI Bug Log - changes from CI_DRM_14504 -> Patchwork_131753v1 Summary

✗ Fi.CI.IGT: failure for drm/i915: A few bigjoiner fixes

2024-03-28 Thread Patchwork
== Series Details == Series: drm/i915: A few bigjoiner fixes URL : https://patchwork.freedesktop.org/series/131711/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14495_full -> Patchwork_131711v1_full Summary ---

✗ Fi.CI.SPARSE: warning for drm/i915: use fine grained -Woverride-init disable

2024-03-28 Thread Patchwork
== Series Details == Series: drm/i915: use fine grained -Woverride-init disable URL : https://patchwork.freedesktop.org/series/131753/ State : warning == Summary == Error: dim sparse failed Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately.

✗ Fi.CI.CHECKPATCH: warning for drm/i915: use fine grained -Woverride-init disable

2024-03-28 Thread Patchwork
== Series Details == Series: drm/i915: use fine grained -Woverride-init disable URL : https://patchwork.freedesktop.org/series/131753/ State : warning == Summary == Error: dim checkpatch failed bee34a0221ee drm/i915: use fine grained -Woverride-init disable -:14: ERROR:GIT_COMMIT_ID: Please

✗ Fi.CI.IGT: failure for drm/i915/gem: Replace dev_priv with i915

2024-03-28 Thread Patchwork
== Series Details == Series: drm/i915/gem: Replace dev_priv with i915 URL : https://patchwork.freedesktop.org/series/131736/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14495_full -> Patchwork_131736v1_full Summary

✗ Fi.CI.IGT: failure for drm/xe/display: check for error on drmm_mutex_init (rev3)

2024-03-28 Thread Patchwork
== Series Details == Series: drm/xe/display: check for error on drmm_mutex_init (rev3) URL : https://patchwork.freedesktop.org/series/131301/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14496_full -> Patchwork_131301v3_full

Re: [PATCH] drm/i915/guc: Remove bogus null check

2024-03-28 Thread Andi Shyti
Hi Rodrigo, On Thu, Mar 28, 2024 at 05:31:07PM -0400, Rodrigo Vivi wrote: > This null check is bogus because we are already using 'ce' stuff > in many places before this function is called. > > Having this here is useless and confuses static analyzer tools > that can see: > > struct

[PATCH] drm/i915/guc: Remove bogus null check

2024-03-28 Thread Rodrigo Vivi
This null check is bogus because we are already using 'ce' stuff in many places before this function is called. Having this here is useless and confuses static analyzer tools that can see: struct intel_engine_cs *engine = ce->engine; before this check, in the same function. Fixes: cec82816d0d0

✗ Fi.CI.IGT: failure for drm/i915: Implemnt vblank sycnhronized mbus joining changes

2024-03-28 Thread Patchwork
== Series Details == Series: drm/i915: Implemnt vblank sycnhronized mbus joining changes URL : https://patchwork.freedesktop.org/series/131700/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14495_full -> Patchwork_131700v1_full

✓ Fi.CI.IGT: success for drm/i915: Implemnt vblank sycnhronized mbus joining changes

2024-03-28 Thread Patchwork
== Series Details == Series: drm/i915: Implemnt vblank sycnhronized mbus joining changes URL : https://patchwork.freedesktop.org/series/131700/ State : success == Summary == CI Bug Log - changes from CI_DRM_14495_full -> Patchwork_131700v1_full

✓ Fi.CI.IGT: success for drm/i915/gt: Limit the reserved VM space to only the platforms that need it

2024-03-28 Thread Patchwork
== Series Details == Series: drm/i915/gt: Limit the reserved VM space to only the platforms that need it URL : https://patchwork.freedesktop.org/series/131707/ State : success == Summary == CI Bug Log - changes from CI_DRM_14495_full -> Patchwork_131707v1_full

✓ Fi.CI.IGT: success for drm/i915: A few bigjoiner fixes

2024-03-28 Thread Patchwork
== Series Details == Series: drm/i915: A few bigjoiner fixes URL : https://patchwork.freedesktop.org/series/131711/ State : success == Summary == CI Bug Log - changes from CI_DRM_14495_full -> Patchwork_131711v1_full Summary ---

✓ Fi.CI.IGT: success for drm/i915/panelreplay: Panel replay workaround with VRR (rev4)

2024-03-28 Thread Patchwork
== Series Details == Series: drm/i915/panelreplay: Panel replay workaround with VRR (rev4) URL : https://patchwork.freedesktop.org/series/129632/ State : success == Summary == CI Bug Log - changes from CI_DRM_14495_full -> Patchwork_129632v4_full

✓ Fi.CI.IGT: success for drm/i915/gem: Replace dev_priv with i915

2024-03-28 Thread Patchwork
== Series Details == Series: drm/i915/gem: Replace dev_priv with i915 URL : https://patchwork.freedesktop.org/series/131736/ State : success == Summary == CI Bug Log - changes from CI_DRM_14495_full -> Patchwork_131736v1_full Summary

✓ Fi.CI.IGT: success for Disable automatic load CCS load balancing (rev13)

2024-03-28 Thread Patchwork
== Series Details == Series: Disable automatic load CCS load balancing (rev13) URL : https://patchwork.freedesktop.org/series/129951/ State : success == Summary == CI Bug Log - changes from CI_DRM_14496_full -> Patchwork_129951v13_full

Re: [topic/core-for-CI] ASoC: SOF: Core: Add remove_late() to sof_init_environment failure path

2024-03-28 Thread Lucas De Marchi
On Thu, Mar 28, 2024 at 09:52:33AM -0400, Rodrigo Vivi wrote: From: Chaitanya Kumar Borah In cases where the sof driver is unable to find the firmware and/or topology file [1], it exits without releasing the i915 runtime pm wakeref [2]. This results in dmesg warnings[3] during suspend/resume

✓ Fi.CI.IGT: success for drm/xe/display: check for error on drmm_mutex_init (rev3)

2024-03-28 Thread Patchwork
== Series Details == Series: drm/xe/display: check for error on drmm_mutex_init (rev3) URL : https://patchwork.freedesktop.org/series/131301/ State : success == Summary == CI Bug Log - changes from CI_DRM_14496_full -> Patchwork_131301v3_full

Re: [PATCH] drm/i915/display_debugfs: Remove check for crtc in force bigjoiner

2024-03-28 Thread Ville Syrjälä
On Thu, Mar 28, 2024 at 07:44:21PM +0530, Ankit Nautiyal wrote: > At the moment, we allow force joiner debugs to work only for connector > with status connected and a crtc attached to it. > This creates a problem when we force bigjoiner and then pipe gets reset > before the force bigjoiner is

[PATCH] ASoC: SOF: Core: Add remove_late() to sof_init_environment failure path

2024-03-28 Thread Rodrigo Vivi
From: Chaitanya Kumar Borah In cases where the sof driver is unable to find the firmware and/or topology file [1], it exits without releasing the i915 runtime pm wakeref [2]. This results in dmesg warnings[3] during suspend/resume or driver unbind. Add remove_late() to the failure path of

RE: [PATCH 00/13] drm/i915: Implemnt vblank sycnhronized mbus joining changes

2024-03-28 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Wednesday, March 27, 2024 11:16 PM > To: intel-gfx@lists.freedesktop.org > Subject: [PATCH 00/13] drm/i915: Implemnt vblank sycnhronized mbus joining > changes Nit: Typo in implement and synchronized > From:

✓ Fi.CI.IGT: success for drm/i915: Implemnt vblank sycnhronized mbus joining changes

2024-03-28 Thread Patchwork
== Series Details == Series: drm/i915: Implemnt vblank sycnhronized mbus joining changes URL : https://patchwork.freedesktop.org/series/131700/ State : success == Summary == CI Bug Log - changes from CI_DRM_14495_full -> Patchwork_131700v1_full

RE: [PATCH 13/13] drm/i915: Optimize out redundant dbuf slice updates

2024-03-28 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Wednesday, March 27, 2024 11:16 PM > To: intel-gfx@lists.freedesktop.org > Subject: [PATCH 13/13] drm/i915: Optimize out redundant dbuf slice updates > > From: Ville Syrjälä > > if the new dbuf slices are a

RE: [PATCH 12/13] drm/i915: Use a plain old int for the cdclk/mdclk ratio

2024-03-28 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Wednesday, March 27, 2024 11:16 PM > To: intel-gfx@lists.freedesktop.org > Subject: [PATCH 12/13] drm/i915: Use a plain old int for the cdclk/mdclk ratio > > From: Ville Syrjälä > > No point in throwing

RE: [PATCH 11/13] drm/i915: Implement vblank synchronized MBUS join changes

2024-03-28 Thread Shankar, Uma
> -Original Message- > From: Intel-gfx On Behalf Of Ville > Syrjala > Sent: Wednesday, March 27, 2024 11:16 PM > To: intel-gfx@lists.freedesktop.org > Cc: Ville Syrjälä > Subject: [PATCH 11/13] drm/i915: Implement vblank synchronized MBUS join > changes > > From: Stanislav Lisovskiy

✓ Fi.CI.BAT: success for drm/i915: Implemnt vblank sycnhronized mbus joining changes

2024-03-28 Thread Patchwork
== Series Details == Series: drm/i915: Implemnt vblank sycnhronized mbus joining changes URL : https://patchwork.freedesktop.org/series/131700/ State : success == Summary == CI Bug Log - changes from CI_DRM_14495 -> Patchwork_131700v1

✓ Fi.CI.BAT: success for drm/i915/gt: Limit the reserved VM space to only the platforms that need it

2024-03-28 Thread Patchwork
== Series Details == Series: drm/i915/gt: Limit the reserved VM space to only the platforms that need it URL : https://patchwork.freedesktop.org/series/131707/ State : success == Summary == CI Bug Log - changes from CI_DRM_14495 -> Patchwork_131707v1

✓ Fi.CI.BAT: success for drm/i915: A few bigjoiner fixes

2024-03-28 Thread Patchwork
== Series Details == Series: drm/i915: A few bigjoiner fixes URL : https://patchwork.freedesktop.org/series/131711/ State : success == Summary == CI Bug Log - changes from CI_DRM_14495 -> Patchwork_131711v1 Summary --- **SUCCESS**

✗ Fi.CI.BAT: failure for drm/i915/panelreplay: Panel replay workaround with VRR (rev4)

2024-03-28 Thread Patchwork
== Series Details == Series: drm/i915/panelreplay: Panel replay workaround with VRR (rev4) URL : https://patchwork.freedesktop.org/series/129632/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14495 -> Patchwork_129632v4

✓ Fi.CI.BAT: success for drm/i915/gem: Replace dev_priv with i915

2024-03-28 Thread Patchwork
== Series Details == Series: drm/i915/gem: Replace dev_priv with i915 URL : https://patchwork.freedesktop.org/series/131736/ State : success == Summary == CI Bug Log - changes from CI_DRM_14495 -> Patchwork_131736v1 Summary ---

✗ Fi.CI.BAT: failure for Disable automatic load CCS load balancing (rev13)

2024-03-28 Thread Patchwork
== Series Details == Series: Disable automatic load CCS load balancing (rev13) URL : https://patchwork.freedesktop.org/series/129951/ State : failure == Summary == CI Bug Log - changes from CI_DRM_14496 -> Patchwork_129951v13 Summary

✓ Fi.CI.BAT: success for drm/xe/display: check for error on drmm_mutex_init (rev3)

2024-03-28 Thread Patchwork
== Series Details == Series: drm/xe/display: check for error on drmm_mutex_init (rev3) URL : https://patchwork.freedesktop.org/series/131301/ State : success == Summary == CI Bug Log - changes from CI_DRM_14496 -> Patchwork_131301v3

✓ Fi.CI.BAT: success for drm/i915: Implemnt vblank sycnhronized mbus joining changes

2024-03-28 Thread Patchwork
== Series Details == Series: drm/i915: Implemnt vblank sycnhronized mbus joining changes URL : https://patchwork.freedesktop.org/series/131700/ State : success == Summary == CI Bug Log - changes from CI_DRM_14495 -> Patchwork_131700v1

RE: [PATCH] drm/i915/display_debugfs: Remove check for crtc in force bigjoiner

2024-03-28 Thread Joshi, Kunal1
Tested-by: Kunal Joshi

[PATCH] drm/i915/display_debugfs: Remove check for crtc in force bigjoiner

2024-03-28 Thread Ankit Nautiyal
At the moment, we allow force joiner debugs to work only for connector with status connected and a crtc attached to it. This creates a problem when we force bigjoiner and then pipe gets reset before the force bigjoiner is disabled. Relax the condition to check for crtc while exposing the debugfs.

[PATCH v6 5/5] drm/i915/psr: Do not write ALPM configuration for PSR1 or DP2.0 Panel Replay

2024-03-28 Thread Jouni Högander
No need to write ALPM configuration for DP2.0 Panel Replay or PSR1. Signed-off-by: Jouni Högander Reviewed-by: Animesh Manna --- drivers/gpu/drm/i915/display/intel_psr.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/display/intel_psr.c

[PATCH v6 4/5] drm/i915/psr: Enable ALPM on source side for eDP Panel replay

2024-03-28 Thread Jouni Högander
Enable ALPM AUX-Less on source side for Panel Replay eDP. Also write all calculated AUX-Less configuration values accordingly. Enabling it on sink side is in upcoming patch. Bspec: 71477 v5: - mention enable is only on source side in commit message v4: - add comment explaining why AUX less

[PATCH v6 3/5] drm/i915/psr: Silence period and lfps half cycle

2024-03-28 Thread Jouni Högander
Add get function for silence period and lfps half cycle. Values are taken from the tables in bspec. Bspec: 71632 v3: - use PORT_ALPM_CTL_SILENCE_PERIOD_MASK instead of value 255 - use PORT_ALPM_LFPS_CTL_LAST_LFPS_HALF_CYCLE_DURATION_MASK instead of value 31 v2: - fix some checks -

[PATCH v6 2/5] drm/i915/psr: Calculate aux less wake time

2024-03-28 Thread Jouni Högander
Calculate aux less wake time and store it into alpm_params struct Bspec: 71477 v4: - re-use fast_wake_lines to store aux_less_wake_lines v3: - use ALPM_CTL_AUX_LESS_WAKE_TIME_MASK instead of value 63 v2: - use variables instead of values directly - fix max value - move converting port

[PATCH v6 1/5] drm/i915/psr: Add missing ALPM AUX-Less register definitions

2024-03-28 Thread Jouni Högander
Couple of ALPM AUX-Less related fields are missing from ALPM register definitions. Add these and remove some duplicate definitions. Bspec: 70294 V2: add Bspec reference Signed-off-by: Jouni Högander Reviewed-by: Arun R Murthy Reviewed-by: Animesh Manna ---

[PATCH v6 0/5] ALPM AUX-Less

2024-03-28 Thread Jouni Högander
This patch set is implementing calculation of ALPM AUX-Less parameters for Intel HW and writing them in case of AUX-Less is enabled. It is also enabling ALPM AUX-Less for eDP Panel Replay. Current code is not allowing Panel Replay on eDP. Patches for this are coming later. This implementation is

[topic/core-for-CI] ASoC: SOF: Core: Add remove_late() to sof_init_environment failure path

2024-03-28 Thread Rodrigo Vivi
From: Chaitanya Kumar Borah In cases where the sof driver is unable to find the firmware and/or topology file [1], it exits without releasing the i915 runtime pm wakeref [2]. This results in dmesg warnings[3] during suspend/resume or driver unbind. Add remove_late() to the failure path of

[PULL] drm-misc-fixes

2024-03-28 Thread Thomas Zimmermann
Hi Dave, Sima, this is the weekly PR for drm-misc-fixes. Best regards Thomas drm-misc-fixes-2024-03-28: Short summary of fixes pull: bridge: - select DRM_KMS_HELPER dma-buf: - fix NULL-pointer deref dp: - fix div-by-zero in DP MST unplug code fbdev: - select FB_IOMEM_FOPS for SBus nouveau:

Re: [PATCH 01/11] drm/i915/dp: Fix DSC line buffer depth programming

2024-03-28 Thread Imre Deak
On Wed, Mar 20, 2024 at 10:11:41PM +0200, Imre Deak wrote: > Fix the calculation of the DSC line buffer depth. This is limited both > by the source's and sink's maximum line buffer depth, but the former one > was not taken into account. On all Intel platform's the source's maximum > buffer depth

Re: [PATCH 5/5] drm/i915/display: Implement Wa_16021440873

2024-03-28 Thread Hogander, Jouni
On Thu, 2024-03-28 at 12:57 +, Kahola, Mika wrote: > > -Original Message- > > From: Hogander, Jouni > > Sent: Tuesday, March 19, 2024 2:33 PM > > To: intel-gfx@lists.freedesktop.org > > Cc: Kahola, Mika ; Hogander, Jouni > > > > Subject: [PATCH 5/5] drm/i915/display: Implement

Re: [PATCH] drm/i915: use fine grained -Woverride-init disable

2024-03-28 Thread Lucas De Marchi
On Thu, Mar 28, 2024 at 12:24:55PM +0200, Jani Nikula wrote: Use localized __diag_push(), __diag_ignore_all() with rationale, and __diag_pop() for specific initializations instead of blanket disabling of -Woverride-init across several files. Note that we've tried this before with commit

Re: [PATCH i-g-t] lib/kunit: Read results from debugfs

2024-03-28 Thread Lucas De Marchi
On Wed, Mar 27, 2024 at 10:54:53PM +0100, Janusz Krzysztofik wrote: >+static DIR *kunit_debugfs_open(void) >+{ >+ const char *debugfs_path = igt_debugfs_mount(); >+ int debugfs_fd, kunit_fd; >+ DIR *kunit_dir; >+ >+ if (igt_debug_on(!debugfs_path)) >+ return NULL; >+ >+

RE: [PATCH 5/5] drm/i915/display: Implement Wa_16021440873

2024-03-28 Thread Kahola, Mika
> -Original Message- > From: Hogander, Jouni > Sent: Tuesday, March 19, 2024 2:33 PM > To: intel-gfx@lists.freedesktop.org > Cc: Kahola, Mika ; Hogander, Jouni > > Subject: [PATCH 5/5] drm/i915/display: Implement Wa_16021440873 > > This patch is implementing Wa_16021440873. > > Bspec:

Re: [PATCH i-g-t] lib/kunit: Read results from debugfs

2024-03-28 Thread Janusz Krzysztofik
On Wednesday, 27 March 2024 22:54:53 CET Janusz Krzysztofik wrote: > On Wednesday, 27 March 2024 17:03:01 CET Lucas De Marchi wrote: > > On Wed, Mar 27, 2024 at 12:22:54PM +0100, Janusz Krzysztofik wrote: > > >KUnit can provide KTAP reports from test modules via debugfs files, one > > >per test

Re: [PATCH 01/13] drm/i915/cdclk: Fix CDCLK programming order when pipes are active

2024-03-28 Thread Ville Syrjälä
On Thu, Mar 28, 2024 at 09:16:06AM +, Murthy, Arun R wrote: > > > -Original Message- > > From: Intel-gfx On Behalf Of Ville > > Syrjala > > Sent: Wednesday, March 27, 2024 11:16 PM > > To: intel-gfx@lists.freedesktop.org > > Subject: [PATCH 01/13] drm/i915/cdclk: Fix CDCLK

[PATCH 13/13] drm/xe/spi: add support for access mode

2024-03-28 Thread Alexander Usyskin
Check SPI access mode from GSC FW status registers and overwrite access status read from SPI descriptor, if needed. Signed-off-by: Alexander Usyskin --- drivers/gpu/drm/xe/regs/xe_gsc_regs.h | 5 + drivers/gpu/drm/xe/xe_heci_gsc.c | 5 + drivers/gpu/drm/xe/xe_spi.c | 31

[PATCH 12/13] drm/xe/spi: add on-die spi device

2024-03-28 Thread Alexander Usyskin
Signed-off-by: Alexander Usyskin --- drivers/gpu/drm/xe/Makefile | 1 + drivers/gpu/drm/xe/xe_device.c | 3 ++ drivers/gpu/drm/xe/xe_device_types.h | 5 ++ drivers/gpu/drm/xe/xe_spi.c | 78 drivers/gpu/drm/xe/xe_spi.h | 15 ++

[PATCH 11/13] spi: intel-dg: wake card on operations

2024-03-28 Thread Alexander Usyskin
Enable runtime PM in spi driver to notify graphics driver that whole card should be kept awake while spi operations are performed through this driver. CC: Lucas De Marchi Signed-off-by: Alexander Usyskin --- drivers/spi/spi-intel-dg.c | 44 ++ 1 file

[PATCH 09/13] spi: intel-dg: implement mtd access handlers

2024-03-28 Thread Alexander Usyskin
Implement mtd read, erase, and write handlers. For erase operation address and size should be 4K aligned. For write operation address and size has to be 4bytes aligned. CC: Rodrigo Vivi CC: Lucas De Marchi Signed-off-by: Tomas Winkler Signed-off-by: Vitaly Lubart Signed-off-by: Alexander

[PATCH 10/13] spi: intel-dg: align 64bit read and write

2024-03-28 Thread Alexander Usyskin
GSC SPI HW errors on quad access overlapping 1K border. Align 64bit read and write to avoid readq/writeq over 1K border. Signed-off-by: Alexander Usyskin --- drivers/spi/spi-intel-dg.c | 35 +++ 1 file changed, 35 insertions(+) diff --git

[PATCH 08/13] spi: intel-dg: spi register with mtd

2024-03-28 Thread Alexander Usyskin
Register the on-die spi device with the mtd subsystem. Refcount spi object on _get and _put mtd callbacks. CC: Rodrigo Vivi CC: Lucas De Marchi Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin --- drivers/spi/spi-intel-dg.c | 111 + 1 file

[PATCH 07/13] spi: intel-dg: implement spi access functions

2024-03-28 Thread Alexander Usyskin
Implement spi_read(), spi_erase() and spi_write() functions. CC: Lucas De Marchi CC: Rodrigo Vivi Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin Signed-off-by: Vitaly Lubart --- drivers/spi/spi-intel-dg.c | 199 + 1 file changed, 199

[PATCH 05/13] spi: add driver for intel graphics on-die spi device

2024-03-28 Thread Alexander Usyskin
Add auxiliary driver for intel discrete graphics on-die spi device. CC: Rodrigo Vivi Signed-off-by: Tomas Winkler Signed-off-by: Lucas De Marchi Signed-off-by: Alexander Usyskin --- drivers/spi/Kconfig| 11 +++ drivers/spi/Makefile | 1 + drivers/spi/spi-intel-dg.c | 146

[PATCH 06/13] spi: intel-dg: implement region enumeration

2024-03-28 Thread Alexander Usyskin
In intel-dg spi, there is no access to the spi controller, the information is extracted from the descriptor region. CC: Rodrigo Vivi CC: Lucas De Marchi Signed-off-by: Tomas Winkler Signed-off-by: Alexander Usyskin --- drivers/spi/spi-intel-dg.c | 190 + 1

[PATCH 03/13] drm/i915/spi: add intel_spi_region map

2024-03-28 Thread Alexander Usyskin
Add the dGFX spi region map and convey it via auxiliary device to the spi child device. CC: Rodrigo Vivi CC: Lucas De Marchi Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler --- drivers/gpu/drm/i915/spi/intel_spi.c | 8 1 file changed, 8 insertions(+) diff --git

[PATCH 04/13] drm/i915/spi: add support for access mode

2024-03-28 Thread Alexander Usyskin
Check SPI access mode from GSC FW status registers and overwrite access status read from SPI descriptor, if needed. Signed-off-by: Alexander Usyskin --- drivers/gpu/drm/i915/spi/intel_spi.c | 25 + 1 file changed, 25 insertions(+) diff --git

  1   2   >