Re: [Intel-gfx] [PATCH 3/4] drm/i915/edp: Be less aggressive about changing link config on eDP

2017-05-08 Thread Mika Kahola
.  The revert above was identified > via a > bisect as the cause of some of Skylake's PSR woes.  This patch, > largely > based on > > commit 4e96c97742f4201edf1b0f8e1b1b6b2ac6ff33e7 > Author: Mika Kahola <mika.kah...@intel.com> > Date:   Wed Apr 29 09:17:39 2015 +030

[Intel-gfx] [PATCH i-g-t v3] tests/kms_atomic_allow_modeset: Add DRM_MODE_ATOMIC_ALLOW_MODESET test

2017-05-03 Thread Mika Kahola
. - Do full modeset/change active property - Enable DRM_MODE_ATOMIC_ALLOW_MODESET and try to do atmic commit. Kernel should now allow atomic modeset. For: VIZ-6955 v2: create own testcase (Maarten) v3: add test for active property change (Maarten) Signed-off-by: Mika Kahola <mika.

[Intel-gfx] [PATCH i-g-t] tests/kms_atomic_abi: Test event ABI corner cases

2017-04-27 Thread Mika Kahola
Atomic has a few special cases around async commits and event generation that we need to test. This patch addresses these two tests - kernel rejects events on a disabled pipe - events on a pipe that is getting enabled/disabled For: VIZ-6954 Signed-off-by: Mika Kahola <mika.kah...@intel.

[Intel-gfx] [PATCH i-g-t v3] tests/kms_concurrent: Concurrent and interruptible subtests for atomic

2017-04-11 Thread Mika Kahola
resolution from higher to lower one and back. For: VIZ-7022 v2: use igt_fork instead of pthreads to create concurrent test runs (Maarten) v3: use igt_display calls instead of raw drm calls for display updates (Maarten) Various cleanups on accessing drm connector (Maarten) Signed-off-by: Mika

Re: [Intel-gfx] [PATCH i-g-t v2] tests/kms_concurrent: Concurrent and interruptible subtests for atomic

2017-04-10 Thread Mika Kahola
On Wed, 2017-03-29 at 11:53 +0200, Maarten Lankhorst wrote: > Op 15-03-17 om 09:43 schreef Mika Kahola: > > > > This test case introduces concurrently running test cases for > > atomic > > modesetting. > > > > The first test or threa

Re: [Intel-gfx] [PATCH 60/67] drm/i915/cnl: Enable fifo underrun for Cannonlake.

2017-04-07 Thread Mika Kahola
Looks ok to me. On Thu, 2017-04-06 at 12:15 -0700, Rodrigo Vivi wrote: > Also in a way that reuse bdw+ for all next platforms. > > Signed-off-by: Rodrigo Vivi <rodrigo.v...@intel.com> Reviewed-by: Mika Kahola <mika.kah...@intel.com> > --- >  drivers/gpu/drm/i91

Re: [Intel-gfx] [PATCH i-g-t v2] tests/kms_atomic_allow_modeset: Add DRM_MODE_ATOMIC_ALLOW_MODESET test

2017-04-05 Thread Mika Kahola
On Tue, 2017-04-04 at 14:28 +0200, Maarten Lankhorst wrote: > Hey, > > Op 04-04-17 om 13:59 schreef Mika Kahola: > > > > When doing a full atomic modeset, kernel should fail if the flag > > DRM_MODE_ATOMIC_ALLOW_MODESET is not set. Let's add this test as > > part

[Intel-gfx] [PATCH i-g-t v2] tests/kms_atomic_allow_modeset: Add DRM_MODE_ATOMIC_ALLOW_MODESET test

2017-04-04 Thread Mika Kahola
. - Do full modeset - Enable DRM_MODE_ATOMIC_ALLOW_MODESET and try to do atmic commit. Kernel should now allow atomic modeset. For: VIZ-6955 Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- tests/Makefile.sources | 1 + tests/kms_atomic_allow_modeset.c

[Intel-gfx] [PATCH i-g-t v4 2/7] tests/kms_plane_multiple: Add TEST_ONLY flag

2017-03-23 Thread Mika Kahola
Add TEST_ONLY flag to test atomic modesetting commits without actual real-life commit. v2: Use flag to indicate to test with TEST_ONLY flag with atomic commit v3: Moved force_test_atomic flag set to 'test_plane_position()' v4: Fix typo in subject field Signed-off-by: Mika Kahola <mika.

[Intel-gfx] [PATCH i-g-t v4 3/7] tests/kms_atomic_transition: Add TEST_ONLY flag

2017-03-23 Thread Mika Kahola
Add TEST_ONLY flag to test atomic transition display commits without actual real-life commit. v2: use flag to force atomic commit with TEST_ONLY flag v3: Rebase Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- tests/kms_atomic_transition.

[Intel-gfx] [PATCH i-g-t v4 7/7] tests/kms_cursor_legacy: Add TEST_ONLY flag

2017-03-23 Thread Mika Kahola
Add TEST_ONLY flag to test atomic modesetting commits without actual real-life commit. Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- tests/kms_cursor_legacy.c | 230 -- 1 file changed, 204 insertions(+), 26 deletions(-) diff --git a

[Intel-gfx] [PATCH i-g-t v4 4/7] tests/kms_plane_scaling: Add TEST_ONLY flag

2017-03-23 Thread Mika Kahola
Add TEST_ONLY flag to test atomic scaling without actually committing the changes. v2: Create subtests with TEST_ONLY flag and one without v3: Rename subtest 'force-atomic-test' as 'with-atomic-test' Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- tests/kms_plane_scaling.

[Intel-gfx] [PATCH i-g-t v4 1/7] lib/igt_kms: Add forcing TEST_ONLY for atomic commits

2017-03-23 Thread Mika Kahola
Add an option to force atomic commits to do commits with TEST_ONLY flag first before doing the actual commit. v2: Clear force_test_atomic flag if atomic commit with TEST_ONLY flag fails (Maarten) Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- lib/igt_kms.

[Intel-gfx] [PATCH i-g-t v4 2/7] tests/kms_plane_multiple: Add TEST_ONLY flag Cc: maarten.lankho...@linux.intel.com

2017-03-23 Thread Mika Kahola
Add TEST_ONLY flag to test atomic modesetting commits without actual real-life commit. v2: Use flag to indicate to test with TEST_ONLY flag with atomic commit v3: Moved force_test_atomic flag set to 'test_plane_position()' Signed-off-by: Mika Kahola <mika.kah...@intel.com> ---

[Intel-gfx] [PATCH i-g-t v4 2/3] tests/kms_plane_multiple: Add TEST_ONLY flag Cc: maarten.lankho...@linux.intel.com

2017-03-23 Thread Mika Kahola
Add TEST_ONLY flag to test atomic modesetting commits without actual real-life commit. v2: Use flag to indicate to test with TEST_ONLY flag with atomic commit v3: Moved force_test_atomic flag set to 'test_plane_position()' Signed-off-by: Mika Kahola <mika.kah...@intel.com> ---

[Intel-gfx] [PATCH i-g-t v4 5/7] tests/kms_rotation_crc: Add TEST_ONLY flag

2017-03-23 Thread Mika Kahola
Add TEST_ONLY flag to test atomic modesetting commits without actual real-life commit. Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- tests/kms_rotation_crc.c | 139 +++ 1 file changed, 139 insertions(+) diff --git a/tests/kms_rotation_c

[Intel-gfx] [PATCH i-g-t v4 6/7] tests/kms_plane_lowres: Add TEST_ONLY flag

2017-03-23 Thread Mika Kahola
Add TEST_ONLY flag to test atomic modesetting commits without actual real-life commit. Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- tests/kms_plane_lowres.c | 40 1 file changed, 36 insertions(+), 4 deletions(-) diff --git a

[Intel-gfx] [PATCH i-g-t v4 0/7] Validate TEST_ONLY correctness against full atomic commit

2017-03-23 Thread Mika Kahola
selection in igt core separate test cases for TEST_ONLY atomic commits (Maarten) v4: Clear force_test_atomic flag if atomic commit fails (Maarten) For: VIZ-6956 Mika Kahola (7): lib/igt_kms: Add forcing TEST_ONLY for atomic commits tests/kms_plane_multiple: Add TEST_ONLY flag Cc

Re: [Intel-gfx] [PATCH i-g-t v3 1/7] lib/igt_kms: Add forcing TEST_ONLY for atomic commits

2017-03-23 Thread Mika Kahola
On Wed, 2017-03-08 at 15:59 +0100, Maarten Lankhorst wrote: > Op 01-02-17 om 14:18 schreef Mika Kahola: > > > > Add an option to force atomic commits to do commits with TEST_ONLY > > flag > > first before doing the actual commit. > > > > Signed-off

[Intel-gfx] [PATCH i-g-t v2] tests/kms_concurrent: Concurrent and interruptible subtests for atomic

2017-03-15 Thread Mika Kahola
resolution from higher to lower one and back. The delay between resolution changes is randomly selected between 20 and 50 milliseconds. The test runs by default 32 iterations to increase the coverage. v2: use igt_fork instead of pthreads to create concurrent test runs (Maarten) Signed-off-by: Mika

Re: [Intel-gfx] [PATCH 2/5] drm/i915: s/__raw_i915_read32/I915_READ_FW/ in the SKL+ scanline read w/a

2017-03-13 Thread Mika Kahola
ut everyone else uses I915_READ_FW() so let's follow suit. > > Signed-off-by: Ville Syrjälä <ville.syrj...@linux.intel.com> Reviewed-by: Mika Kahola <mika.kah...@intel.com> > --- >  drivers/gpu/drm/i915/i915_irq.c | 3 +-- >  1 file changed, 1 insertion(+), 2 deletions(-) &

Re: [Intel-gfx] [PATCH i-g-t 4/4] assembler/gen8_disasm.c: Remove unused m_mask_ctrl

2017-03-09 Thread Mika Kahola
On Wed, 2017-03-08 at 16:44 +0200, Petri Latvala wrote: > Signed-off-by: Petri Latvala <petri.latv...@intel.com> Reviewed-by: Mika Kahola <mika.kah...@intel.com> > --- >  assembler/gen8_disasm.c | 5 - >  1 file changed, 5 deletions(-) > > diff --git a/assem

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_concurrent: Concurrent and interruptible subtests for atomic

2017-03-09 Thread Mika Kahola
On Wed, 2017-03-08 at 15:00 +0100, Maarten Lankhorst wrote: > Op 23-02-17 om 14:26 schreef Mika Kahola: > > > > This test case introduces concurrently running test cases for > > atomic > > modesetting. > > > > The first test or threa

[Intel-gfx] [PATCH i-g-t v2] tests/kms_atomic: test that TEST_ONLY does not clobber state

2017-03-09 Thread Mika Kahola
none of that is clobbered v2: use ATOMIC_RELAX_NONE instead of CRTC_RELAX_MODE when checking crtc or plane state (Maarten) rename subtest and function that executes this test (Maarten) Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- tests/kms_atomic.

Re: [Intel-gfx] [PATCH i-g-t 3/4] tests/testdisplay: Remove unused SPRITE_COLOR_KEY

2017-03-09 Thread Mika Kahola
On Wed, 2017-03-08 at 16:44 +0200, Petri Latvala wrote: > Unused since 99bdf4f0ff3e ("tests/testdisplay: Use cairo helpers to > draw to plane") > > Signed-off-by: Petri Latvala <petri.latv...@intel.com> Reviewed-by: Mika Kahola <mika.kah...@intel.com> >

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_atomic: test that TEST_ONLY does not clobber state

2017-03-08 Thread Mika Kahola
On Wed, 2017-03-08 at 15:08 +0100, Maarten Lankhorst wrote: > Op 17-02-17 om 14:39 schreef Mika Kahola: > > > > We need to make sure that TEST_ONLY really only touches the free- > > standing > > state objects and nothing else. Test approach here is the > > foll

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_plane_lowres: Add DRM_MODE_ATOMIC_ALLOW_MODESET test

2017-03-08 Thread Mika Kahola
On Wed, 2017-03-08 at 13:38 +0100, Maarten Lankhorst wrote: > Hey, > > Op 07-02-17 om 14:33 schreef Mika Kahola: > > > > When doing a full atomic modeset, kernel should fail if the flag > > DRM_MODE_ATOMIC_ALLOW_MODESET is not set. Let's add this test as > &

[Intel-gfx] [PATCH i-g-t] benchmarks/gem_latency: Fix compiler warning

2017-02-24 Thread Mika Kahola
from ../lib/drmtest.h:39, from ../lib/igt.h:27, from gem_latency.c:31: Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- benchmarks/gem_latency.c | 1 - 1 file changed, 1 deletion(-) diff --git a/benchmarks/gem_latency.c b/benchmarks/gem_l

[Intel-gfx] [PATCH i-g-t] tests/kms_concurrent: Concurrent and interruptible subtests for atomic

2017-02-23 Thread Mika Kahola
resolution from higher to lower one and back. The delay between resolution changes is randomly selected between 20 and 50 milliseconds. The test runs by default 32 iterations to increase the coverage. Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- tests/Makefile.sources | 1 +

[Intel-gfx] [PATCH i-g-t] tests/kms_atomic: test that TEST_ONLY does not clobber state

2017-02-17 Thread Mika Kahola
none of that is clobbered Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- tests/kms_atomic.c | 79 ++ 1 file changed, 79 insertions(+) diff --git a/tests/kms_atomic.c b/tests/kms_atomic.c index d6273f4..3531fa4 100644 --- a

[Intel-gfx] [PATCH] lib/igt_kms: Fix regression on kms_plane_lowres test

2017-02-16 Thread Mika Kahola
count") Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- lib/igt_kms.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/lib/igt_kms.c b/lib/igt_kms.c index dae8bf9..5388a83 100644 --- a/lib/igt_kms.c +++ b/lib/igt_kms.c @@ -1331,6 +1331,7 @@ void

[Intel-gfx] [PATCH i-g-t] tests/kms_plane_lowres: Add DRM_MODE_ATOMIC_ALLOW_MODESET test

2017-02-07 Thread Mika Kahola
When doing a full atomic modeset, kernel should fail if the flag DRM_MODE_ATOMIC_ALLOW_MODESET is not set. Let's add this test as part of 'kms_plane_lowres' testset. The testcases are 'pipe-x-allow-modeset' where x stands for pipe in question. For: VIZ-6955 Signed-off-by: Mika Kahola <mika.

[Intel-gfx] [PATCH i-g-t v2] tests/kms_plane_multiple: Test only with maximum number of planes

2017-02-02 Thread Mika Kahola
t Foss <robert.f...@collabora.com> Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- tests/kms_plane_multiple.c | 141 + 1 file changed, 65 insertions(+), 76 deletions(-) diff --git a/tests/kms_plane_multiple.c b/tests/kms_plane_multiple.c inde

[Intel-gfx] [PATCH] tests/kms_plane_multiple: Test only with maximum number of planes

2017-02-01 Thread Mika Kahola
To be more suitable for BAT testing, let's modify the test such a way that it only uses the maximum number of available planes. This reduces the total number of subtests. Cc: Robert Foss <robert.f...@collabora.com> Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- tests/kms_plan

[Intel-gfx] [PATCH i-g-t v3 6/7] tests/kms_plane_lowres: Add TEST_ONLY flag

2017-02-01 Thread Mika Kahola
Add TEST_ONLY flag to test atomic modesetting commits without actual real-life commit. Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- tests/kms_plane_lowres.c | 40 1 file changed, 36 insertions(+), 4 deletions(-) diff --git a

[Intel-gfx] [PATCH i-g-t v3 3/7] tests/kms_atomic_transition: Add TEST_ONLY flag

2017-02-01 Thread Mika Kahola
Add TEST_ONLY flag to test atomic transition display commits without actual real-life commit. v2: use flag to force atomic commit with TEST_ONLY flag Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- tests/kms_atomic_transition.c | 66 ---

[Intel-gfx] [PATCH i-g-t v3 5/7] tests/kms_rotation_crc: Add TEST_ONLY flag

2017-02-01 Thread Mika Kahola
Add TEST_ONLY flag to test atomic modesetting commits without actual real-life commit. Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- tests/kms_rotation_crc.c | 139 +++ 1 file changed, 139 insertions(+) diff --git a/tests/kms_rotation_c

[Intel-gfx] [PATCH i-g-t v3 4/7] tests/kms_plane_scaling: Add TEST_ONLY flag

2017-02-01 Thread Mika Kahola
Add TEST_ONLY flag to test atomic scaling without actually committing the changes. v2: Create subtests with TEST_ONLY flag and one without Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- tests/kms_plane_scaling.c | 29 + 1 file changed, 21 insertions

[Intel-gfx] [PATCH i-g-t v3 0/7] Validate TEST_ONLY correctness against full atomic commit

2017-02-01 Thread Mika Kahola
selection in igt core separate test cases for TEST_ONLY atomic commits (Maarten) For: VIZ-6956 Mika Kahola (7): lib/igt_kms: Add forcing TEST_ONLY for atomic commits tests/kms_plane_multiple: Add TEST_ONLY flag tests/kms_atomic_transition: Add TEST_ONLY flag tests/kms_plane_scaling: Add

[Intel-gfx] [PATCH i-g-t v3 2/7] tests/kms_plane_multiple: Add TEST_ONLY flag

2017-02-01 Thread Mika Kahola
Add TEST_ONLY flag to test atomic modesetting commits without actual real-life commit. v2: Use flag to indicate to test with TEST_ONLY flag with atomic commit Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- tests/kms_plane_multiple.c | 35 +++

[Intel-gfx] [PATCH i-g-t v3 7/7] tests/kms_cursor_legacy: Add TEST_ONLY flag

2017-02-01 Thread Mika Kahola
Add TEST_ONLY flag to test atomic modesetting commits without actual real-life commit. Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- tests/kms_cursor_legacy.c | 230 -- 1 file changed, 204 insertions(+), 26 deletions(-) diff --git a

[Intel-gfx] [PATCH i-g-t v3 1/7] lib/igt_kms: Add forcing TEST_ONLY for atomic commits

2017-02-01 Thread Mika Kahola
Add an option to force atomic commits to do commits with TEST_ONLY flag first before doing the actual commit. Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- lib/igt_kms.c | 18 +- lib/igt_kms.h | 1 + 2 files changed, 18 insertions(+), 1 deletion(-) diff --git

Re: [Intel-gfx] [PATCH] drm/i915: Add MIPI_IO WA and program DSI regulators

2017-01-31 Thread Mika Kahola
Looks ok. Acked-by: Mika Kahola <mika.kah...@intel.com> On Wed, 2017-01-25 at 19:43 +0530, Vidya Srinivas wrote: > From: Uma Shankar <uma.shan...@intel.com> > > Enable MIPI IO WA for BXT DSI as per bspec and > program the DSI regulators. > > v2: Moved IO enab

Re: [Intel-gfx] [PATCH i-g-t v2] tests: Validate TEST_ONLY correctness against full atomic commit

2017-01-30 Thread Mika Kahola
On Mon, 2017-01-30 at 13:43 +0100, Maarten Lankhorst wrote: > Op 30-01-17 om 12:37 schreef Mika Kahola: > > > > Validate atomic commit correctness before actual commit. > > > > For: VIZ-6956 > > > > v2: Add flag to toggle TEST_ONLY for atomic commit. >

[Intel-gfx] [PATCH i-g-t v2] tests: Validate TEST_ONLY correctness against full atomic commit

2017-01-30 Thread Mika Kahola
com> Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- lib/igt_kms.c | 32 lib/igt_kms.h | 3 ++- tests/kms_atomic_transition.c | 23 ++- tests/kms_busy.c | 21 +---

Re: [Intel-gfx] [PATCH i-g-t v2 33/33] lib/igt_kms: Remove code obsoleted by dyn n_planes implementation

2017-01-26 Thread Mika Kahola
Reviewed-by: Mika Kahola <mika.kah...@intel.com> On Tue, 2017-01-24 at 18:34 -0500, Robert Foss wrote: > Due to the dyn n_planes implementation some attributes and functions > were made obsolete and cand be removed. > > However to keep all of the tests building the obsolete

Re: [Intel-gfx] [PATCH i-g-t v2 32/33] tests/kms_plane_lowres: Add support for dynamic number of planes

2017-01-26 Thread Mika Kahola
Reviewed-by: Mika Kahola <mika.kah...@intel.com> On Tue, 2017-01-24 at 18:33 -0500, Robert Foss wrote: > Add changes reflecting the new support for dynamic number of planes > per pipe. > > Signed-off-by: Robert Foss <robert.f...@collabora.com> > --- >

Re: [Intel-gfx] [PATCH i-g-t v2 31/33] tests/kms_ccs: Add support for dynamic number of planes

2017-01-26 Thread Mika Kahola
Reviewed-by: Mika Kahola <mika.kah...@intel.com> On Tue, 2017-01-24 at 18:33 -0500, Robert Foss wrote: > Add changes reflecting the new support for dynamic number of planes > per pipe. > > Signed-off-by: Robert Foss <robert.f...@collabora.com> > --- >  tests/kms_cc

Re: [Intel-gfx] [PATCH i-g-t v2 30/33] tests/prime_mmap_kms: Add support for dynamic number of planes

2017-01-26 Thread Mika Kahola
Reviewed-by: Mika Kahola <mika.kah...@intel.com> On Tue, 2017-01-24 at 18:33 -0500, Robert Foss wrote: > Add changes reflecting the new support for dynamic number of planes > per pipe. > > Signed-off-by: Robert Foss <robert.f...@collabora.com> > --- >  tests/pri

Re: [Intel-gfx] [PATCH i-g-t v2 29/33] tests/kms_vblank: Add support for dynamic number of planes

2017-01-26 Thread Mika Kahola
Reviewed-by: Mika Kahola <mika.kah...@intel.com> On Tue, 2017-01-24 at 18:33 -0500, Robert Foss wrote: > Add changes reflecting the new support for dynamic number of planes > per pipe. > > Signed-off-by: Robert Foss <robert.f...@collabora.com> > --- >  tests/k

Re: [Intel-gfx] [PATCH i-g-t v2 28/33] tests/kms_universal_plane: Add support for dynamic number of planes

2017-01-26 Thread Mika Kahola
Reviewed-by: Mika Kahola <mika.kah...@intel.com> On Tue, 2017-01-24 at 18:33 -0500, Robert Foss wrote: > Add changes reflecting the new support for dynamic number of planes > per pipe. > > Signed-off-by: Robert Foss <robert.f...@collabora.com> > --- >  te

Re: [Intel-gfx] [PATCH i-g-t v2 26/33] tests/kms_rotation_crc: Add support for dynamic number of planes

2017-01-26 Thread Mika Kahola
Reviewed-by: Mika Kahola <mika.kah...@intel.com> On Tue, 2017-01-24 at 18:33 -0500, Robert Foss wrote: > Add changes reflecting the new support for dynamic number of planes > per pipe. > > Signed-off-by: Robert Foss <robert.f...@collabora.com> > --- >

Re: [Intel-gfx] [PATCH i-g-t v2 27/33] tests/kms_sink_crc_basic: Add support for dynamic number of planes

2017-01-26 Thread Mika Kahola
Reviewed-by: Mika Kahola <mika.kah...@intel.com> On Tue, 2017-01-24 at 18:33 -0500, Robert Foss wrote: > Add changes reflecting the new support for dynamic number of planes > per pipe. > > Signed-off-by: Robert Foss <robert.f...@collabora.com> > --- >  tests/kms_sin

Re: [Intel-gfx] [PATCH i-g-t v2 25/33] tests/kms_rmfb: Add support for dynamic number of planes

2017-01-26 Thread Mika Kahola
Reviewed-by: Mika Kahola <mika.kah...@intel.com> On Tue, 2017-01-24 at 18:33 -0500, Robert Foss wrote: > Add changes reflecting the new support for dynamic number of planes > per pipe. > > Signed-off-by: Robert Foss <robert.f...@collabora.com> > --- >  tests/kms_r

Re: [Intel-gfx] [PATCH i-g-t v2 24/33] tests/kms_pwrite_crc: Add support for dynamic number of planes

2017-01-26 Thread Mika Kahola
Reviewed-by: Mika Kahola <mika.kah...@intel.com> On Tue, 2017-01-24 at 18:33 -0500, Robert Foss wrote: > Add changes reflecting the new support for dynamic number of planes > per pipe. > > Signed-off-by: Robert Foss <robert.f...@collabora.com> > --- >  tests/kms

Re: [Intel-gfx] [PATCH i-g-t v2 23/33] tests/kms_psr_sink_crc: Add support for dynamic number of planes

2017-01-26 Thread Mika Kahola
Reviewed-by: Mika Kahola <mika.kah...@intel.com> On Tue, 2017-01-24 at 18:33 -0500, Robert Foss wrote: > Add changes reflecting the new support for dynamic number of planes > per pipe. > > Signed-off-by: Robert Foss <robert.f...@collabora.com> > --- >

Re: [Intel-gfx] [PATCH i-g-t v2 22/33] tests/kms_properties: Add support for dynamic number of planes

2017-01-26 Thread Mika Kahola
Reviewed-by: Mika Kahola <mika.kah...@intel.com> On Tue, 2017-01-24 at 18:33 -0500, Robert Foss wrote: > Add changes reflecting the new support for dynamic number of planes > per pipe. > > Signed-off-by: Robert Foss <robert.f...@collabora.com> > --- >  tests/kms_pro

Re: [Intel-gfx] [PATCH i-g-t v2 21/33] tests/kms_plane_scaling: Add support for dynamic number of planes

2017-01-26 Thread Mika Kahola
Reviewed-by: Mika Kahola <mika.kah...@intel.com> On Tue, 2017-01-24 at 18:33 -0500, Robert Foss wrote: > Add changes reflecting the new support for dynamic number of planes > per pipe. > > Signed-off-by: Robert Foss <robert.f...@collabora.com> > --- >  

Re: [Intel-gfx] [PATCH i-g-t v2 20/33] tests/kms_plane_multiple: Add support for dynamic number of planes

2017-01-26 Thread Mika Kahola
; + int n_planes = data->display.pipes[pipe].n_planes; > + for (int planes = 0; planes < n_planes; planes++) > + test_plane_position(data, pipe, true, > planes, > + LOCAL_I915_FORMAT_MOD_Y_TILED); > + } > + > + igt_subtest_f("legacy-pipe-%s-tiling-yf-planes", > +   kmstest_pipe_name(pipe)) { > + int n_planes = data->display.pipes[pipe].n_planes; > + for (int planes = 0; planes < n_planes; planes++) > + test_plane_position(data, pipe, false, > planes, > + LOCAL_I915_FORMAT_MOD_Yf_TILED); > + } > + > + igt_subtest_f("atomic-pipe-%s-tiling-yf-planes", > +   kmstest_pipe_name(pipe)) { > + int n_planes = data->display.pipes[pipe].n_planes; > + for (int planes = 0; planes < n_planes; planes++) > + test_plane_position(data, pipe, true, > planes, > + LOCAL_I915_FORMAT_MOD_Yf_TILED); > + } >  } >   >  static data_t data; > @@ -461,15 +516,13 @@ int main(int argc, char *argv[]) >   >   igt_fixture { >   data.drm_fd = drm_open_driver_master(DRIVER_INTEL); > - >   kmstest_set_vt_graphics_mode(); > - >   igt_require_pipe_crc(); >   igt_display_init(, data.drm_fd); >   } >   >   for (int pipe = 0; pipe < I915_MAX_PIPES; pipe++) > - run_tests_for_pipe(, pipe); > + run_tests_for_pipe_plane(, pipe); >   >   igt_fixture { >   igt_display_fini(); -- Mika Kahola - Intel OTC ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH i-g-t v2 19/33] tests/kms_plane: Add support for dynamic number of planes

2017-01-25 Thread Mika Kahola
g_with_output(data_t *data, >  } >   >  static void > -test_plane_panning(data_t *data, enum pipe pipe, enum igt_plane > plane, > +test_plane_panning(data_t *data, enum pipe pipe, int plane, >  unsigned int flags) misaligned parameter. With that fixed, this i

Re: [Intel-gfx] [PATCH i-g-t v2 18/33] tests/kms_pipe_color: Add support for dynamic number of planes

2017-01-25 Thread Mika Kahola
Reviewed-by: Mika Kahola <mika.kah...@intel.com> On Tue, 2017-01-24 at 18:33 -0500, Robert Foss wrote: > Add changes reflecting the new support for dynamic number of planes > per pipe. > > Signed-off-by: Robert Foss <robert.f...@collabora.com> > --- >  tests/kms_p

Re: [Intel-gfx] [PATCH i-g-t v2 17/33] tests/kms_panel_fitting: Add support for dynamic number of planes

2017-01-25 Thread Mika Kahola
Reviewed-by: Mika Kahola <mika.kah...@intel.com> On Tue, 2017-01-24 at 18:33 -0500, Robert Foss wrote: > Add changes reflecting the new support for dynamic number of planes > per pipe. > > Signed-off-by: Robert Foss <robert.f...@collabora.com> > --- >  

Re: [Intel-gfx] [PATCH i-g-t v2 16/33] tests/kms_mmio_vs_cs_flip: Add support for dynamic number of planes

2017-01-25 Thread Mika Kahola
Reviewed-by: Mika Kahola <mika.kah...@intel.com> On Tue, 2017-01-24 at 18:33 -0500, Robert Foss wrote: > Add changes reflecting the new support for dynamic number of planes > per pipe. > > Signed-off-by: Robert Foss <robert.f...@collabora.com> > --- >  tests/kms_mmi

Re: [Intel-gfx] [PATCH i-g-t v2 15/33] tests/kms_mmap_write_crc: Add support for dynamic number of planes

2017-01-25 Thread Mika Kahola
Reviewed-by: Mika Kahola <mika.kah...@intel.com> On Tue, 2017-01-24 at 18:33 -0500, Robert Foss wrote: > Add changes reflecting the new support for dynamic number of planes > per pipe. > > Signed-off-by: Robert Foss <robert.f...@collabora.com> > --- >  tests/kms_mma

Re: [Intel-gfx] [PATCH i-g-t v2 14/33] tests/kms_legacy_colorkey: Add support for dynamic number of planes

2017-01-25 Thread Mika Kahola
Reviewed-by: Mika Kahola <mika.kah...@intel.com> On Tue, 2017-01-24 at 18:33 -0500, Robert Foss wrote: > Add changes reflecting the new support for dynamic number of planes > per pipe. > > Signed-off-by: Robert Foss <robert.f...@collabora.com> > --- >  tests/kms_l

Re: [Intel-gfx] [PATCH i-g-t v2 12/33] tests/kms_fence_pin_leak: Add support for dynamic number of planes

2017-01-25 Thread Mika Kahola
Reviewed-by: Mika Kahola <mika.kah...@intel.com> On Tue, 2017-01-24 at 18:33 -0500, Robert Foss wrote: > Add changes reflecting the new support for dynamic number of planes > per pipe. > > Signed-off-by: Robert Foss <robert.f...@collabora.com> > --- >  tests/kms_fen

Re: [Intel-gfx] [PATCH i-g-t v2 13/33] tests/kms_flip_event_leak: Add support for dynamic number of planes

2017-01-25 Thread Mika Kahola
Reviewed-by: Mika Kahola <mika.kah...@intel.com> On Tue, 2017-01-24 at 18:33 -0500, Robert Foss wrote: > Add changes reflecting the new support for dynamic number of planes > per pipe. > > Signed-off-by: Robert Foss <robert.f...@collabora.com> > --- >  tests/kms

Re: [Intel-gfx] [PATCH i-g-t v2 11/33] tests/kms_fbc_crc: Add support for dynamic number of planes

2017-01-25 Thread Mika Kahola
ch defined this as pipe_id. For consistency, should we rename this as pipe_id too? I'll leave this up to you. Either way, this is  Reviewed-by: Mika Kahola <mika.kah...@intel.com> >   > - for_each_pipe(display, pipe) { > - igt_plane_t *plane = > >pipes[pipe].planes

Re: [Intel-gfx] [PATCH i-g-t v2 07/33] tests/kms_chv_cursor_fail: Add support for dynamic number of planes

2017-01-25 Thread Mika Kahola
Reviewed-by: Mika Kahola <mika.kah...@intel.com>   On Tue, 2017-01-24 at 18:33 -0500, Robert Foss wrote: > Add changes reflecting the new support for dynamic number of planes > per pipe. > > Signed-off-by: Robert Foss <robert.f...@collabora.com> > --- >  t

Re: [Intel-gfx] [PATCH i-g-t v2 08/33] tests/kms_crtc_background_color: Add support for dynamic number of planes

2017-01-25 Thread Mika Kahola
Reviewed-by: Mika Kahola <mika.kah...@intel.com> On Tue, 2017-01-24 at 18:33 -0500, Robert Foss wrote: > Add changes reflecting the new support for dynamic number of planes > per pipe. > > Signed-off-by: Robert Foss <robert.f...@collabora.com> > --- >  tests/k

Re: [Intel-gfx] [PATCH i-g-t v2 09/33] tests/kms_cursor_crc: Add support for dynamic number of planes

2017-01-25 Thread Mika Kahola
Reviewed-by: Mika Kahola <mika.kah...@intel.com> On Tue, 2017-01-24 at 18:33 -0500, Robert Foss wrote: > Add changes reflecting the new support for dynamic number of planes > per pipe. > > Signed-off-by: Robert Foss <robert.f...@collabora.com> > --- >

Re: [Intel-gfx] [PATCH i-g-t v2 05/33] tests/kms_atomic_transition: Add support for dynamic number of planes

2017-01-25 Thread Mika Kahola
Reviewed-by: Mika Kahola <mika.kah...@intel.com> On Tue, 2017-01-24 at 18:33 -0500, Robert Foss wrote: > Add changes reflecting the new support for dynamic number of planes > per pipe. > > Signed-off-by: Robert Foss <robert.f...@collabora.com> > --- >  test

Re: [Intel-gfx] [PATCH i-g-t v2 06/33] tests/kms_busy: Add support for dynamic number of planes

2017-01-25 Thread Mika Kahola
Reviewed-by: Mika Kahola <mika.kah...@intel.com> On Tue, 2017-01-24 at 18:33 -0500, Robert Foss wrote: > Add changes reflecting the new support for dynamic number of planes > per pipe. > > Signed-off-by: Robert Foss <robert.f...@collabora.com> > --- >  tests/kms_b

Re: [Intel-gfx] [PATCH i-g-t v2 04/33] lib/igt_kms: Implement dynamic plane count support

2017-01-25 Thread Mika Kahola
valid planes */ > + for (j = 0; j < plane_resources->count_planes; j++) > { > + drmModePlane *drm_plane; > + > + drm_plane = drmModeGetPlane(display->drm_fd, > + plane_r

Re: [Intel-gfx] [PATCH i-g-t v2 03/33] lib/igt_kms: Rename kmstest properties nplanes and plane

2017-01-25 Thread Mika Kahola
Reviewed-by: Mika Kahola <mika.kah...@intel.com> On Tue, 2017-01-24 at 18:33 -0500, Robert Foss wrote: > Rename these properties to have them use the same naming convention > as the igt_*_t structs. > > Signed-off-by: Robert Foss <robert.f...@collabora.com> > --- >

Re: [Intel-gfx] [PATCH i-g-t v2 02/33] lib/igt_kms: Avoid depencency on static plane count

2017-01-25 Thread Mika Kahola
Reviewed-by: Mika Kahola <mika.kah...@intel.com> On Tue, 2017-01-24 at 18:33 -0500, Robert Foss wrote: > Rework kmstest_crtc and kmstest_plane structs and their usage > to not depend on a static plane count. > > Signed-off-by: Robert Foss <robert.f...@collabora.com> >

Re: [Intel-gfx] [PATCH i-g-t v2 01/33] lib/igt_kms: Add index property to kmstest_plane struct

2017-01-25 Thread Mika Kahola
Reviewed-by: Mika Kahola <mika.kah...@intel.com> On Tue, 2017-01-24 at 18:33 -0500, Robert Foss wrote: > Add an index property which helps accessing the corresponding > igt_plane_t structure through the igt_*_get_plane() functions. > > Signed-off-by: Robert Foss <robe

Re: [Intel-gfx] [PATCH i-g-t 5/5] tests/kms_test_only: Validate TEST_ONLY correctness against full atomic commit

2017-01-23 Thread Mika Kahola
On Thu, 2017-01-12 at 12:37 +0100, Maarten Lankhorst wrote: > Hey, > > Op 12-01-17 om 11:28 schreef Mika Kahola: > > > > On Thu, 2017-01-12 at 11:11 +0100, Maarten Lankhorst wrote: > > > > > > Op 30-12-16 om 13:00 schreef Mika Kahola: > > &g

Re: [Intel-gfx] [PATCH i-g-t v1 04/32] lib/igt_kms: Implement dynamic plane count support

2017-01-23 Thread Mika Kahola
> - IGT_PLANE_3, > - IGT_PLANE_4, > - IGT_PLANE_5, > - IGT_PLANE_6, > - IGT_PLANE_7, > - IGT_PLANE_8, > - IGT_PLANE_9, > - IGT_PLANE_CURSOR, /* IGT_PLANE_CURSOR is always the last > plane. */ > - IGT_MAX_PLANES, > -}; > - &g

Re: [Intel-gfx] [PATCH i-g-t v1 03/32] lib/igt_kms: Rename kmstest properties nplanes and plane

2017-01-23 Thread Mika Kahola
Reviewed-by: Mika Kahola <mika.kah...@intel.com> On Fri, 2017-01-20 at 12:45 -0500, Robert Foss wrote: > Rename these properties to have them use the same naming convention > as the igt_*_t structs. > > Signed-off-by: Robert Foss <robert.f...@collabora.com> > --- >

Re: [Intel-gfx] [PATCH i-g-t v1 02/32] lib/igt_kms: Avoid depencency on static plane count

2017-01-23 Thread Mika Kahola
Reviewed-by: Mika Kahola <mika.kah...@intel.com> On Fri, 2017-01-20 at 12:45 -0500, Robert Foss wrote: > Rework kmstest_crtc and kmstest_plane structs and their usage > to not depend on a static plane count. > > Signed-off-by: Robert Foss <robert.f...@collabora.com> >

Re: [Intel-gfx] [PATCH i-g-t v1 01/32] lib/igt_kms: Add index property to kmstest_plane struct

2017-01-23 Thread Mika Kahola
Reviewed-by: Mika Kahola <mika.kah...@intel.com> On Fri, 2017-01-20 at 12:45 -0500, Robert Foss wrote: > Add an index property which helps accessing the corresponding > igt_plane_t structure through the igt_*_get_plane() functions. > > Signed-off-by: Robert Foss <robe

Re: [Intel-gfx] [PATCH] drm/i915: Add MIPI_IO WA and program DSI regulators

2017-01-19 Thread Mika Kahola
er, >   >   intel_dsi_clear_device_ready(encoder); >   > + val = I915_READ(BXT_P_CR_GT_DISP_PWRON); > + I915_WRITE(BXT_P_CR_GT_DISP_PWRON, > + val & ~MIPIO_RST_CTRL); > + >   intel_disable_dsi_pll(encoder); >   > + /* Power down

[Intel-gfx] [PATCH i-g-t v2 2/2] tests/kms_plane_multiple: Cleanup in favor of library functions

2017-01-17 Thread Mika Kahola
Cleaunup by replacing get_vblank() function with library function kmstest_get_vblank(). Cc: Maarten Lankhorst <maarten.lankho...@linux.intel.com> Reviewed-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com> Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- tests/km

[Intel-gfx] [PATCH i-g-t v2 0/2] tests/kms_plane_multiple: Fix CI issues

2017-01-17 Thread Mika Kahola
Fixes for issues seen on CI tests. The patches provide relaxed timing requirement for atomic commit as well as general cleanup to favor library functions. v2: fix MAX_CRCS definition Mika Kahola (2): tests/kms_plane_multiple: Relax atomic commit time requirement tests/kms_plane_multiple

[Intel-gfx] [PATCH i-g-t v2 1/2] tests/kms_plane_multiple: Relax atomic commit time requirement

2017-01-17 Thread Mika Kahola
Relax required time to atomic commits from 1 vblank to 2 vblanks. v2: Increase MAX_CRCS to 2 (Maarten) Reference: Issues seen on BYT CI tests Cc: Maarten Lankhorst <maarten.lankho...@linux.intel.com> Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- tests/kms_plane_mul

Re: [Intel-gfx] [PATCH i-g-t 1/2] tests/kms_plane_multiple: Relax atomic commit time requirement

2017-01-16 Thread Mika Kahola
On Mon, 2017-01-16 at 14:26 +0100, Maarten Lankhorst wrote: > Op 16-01-17 om 14:09 schreef Mika Kahola: > > > > Relax required time to atomic commits from 1 vblank to 2 vblanks. > > > > Reference: Issues seen on BYT CI tests > > > > Cc: Maarten Lankh

[Intel-gfx] [PATCH i-g-t 2/2] tests/kms_plane_multiple: Cleanup in favor of library functions

2017-01-16 Thread Mika Kahola
Cleaunup by replacing get_vblank() function with library function kmstest_get_vblank(). Cc: Maarten Lankhorst <maarten.lankho...@linux.intel.com> Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- tests/kms_plane_multiple.c | 27 +++ 1 file changed,

[Intel-gfx] [PATCH i-g-t 1/2] tests/kms_plane_multiple: Relax atomic commit time requirement

2017-01-16 Thread Mika Kahola
Relax required time to atomic commits from 1 vblank to 2 vblanks. Reference: Issues seen on BYT CI tests Cc: Maarten Lankhorst <maarten.lankho...@linux.intel.com> Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- tests/kms_plane_multiple.c | 9 + 1 file changed, 5 inse

[Intel-gfx] [PATCH i-g-t 0/2] tests/kms_plane_multiple: Fix CI issues

2017-01-16 Thread Mika Kahola
Fixes for issues seen on CI tests. The patches provide relaxed timing requirement for atomic commit as well as general cleanup to favor library functions. Mika Kahola (2): tests/kms_plane_multiple: Relax atomic commit time requirement tests/kms_plane_multiple: Cleanup in favor of library

Re: [Intel-gfx] [PATCH 10/14] drm/i915: Add MIPI_IO WA

2017-01-12 Thread Mika Kahola
This is definitely needed to pass igt test on bxt 'gem_exec_suspend --run-subtest basic-S3' Tested-by: Mika Kahola <mika.kah...@intel.com> On Mon, 2017-01-09 at 14:46 +0530, Vidya Srinivas wrote: > From: Uma Shankar <uma.shan...@intel.com> > > Enable MIPI IO WA for

[Intel-gfx] [PATCH i-g-t] tests/kms_plane_multiple: Change number of iterations

2017-01-12 Thread Mika Kahola
In CI system, the default 64 iterations of this test may cause CRC overflow warnings in dmesg when debugfs is enabled in kernel config. To keep dmesg warning noise in minimum, let's run this test only once by default. Signed-off-by: Mika Kahola <mika.kah...@intel.com> ---

Re: [Intel-gfx] [PATCH i-g-t v4] tests/kms_plane_lowres: Plane visibility after atomic modesets

2017-01-12 Thread Mika Kahola
On Thu, 2017-01-12 at 11:00 +0100, Maarten Lankhorst wrote: > Op 30-12-16 om 13:47 schreef Mika Kahola: > > > > Testcase for plane visibility after atomic modesets. The idea of > > the test > > is the following: > > > >  - draw a blue screen with high

[Intel-gfx] [PATCH] drm/i915: Header cleanup for intel_display

2017-01-04 Thread Mika Kahola
Remove reference to drm/drm_edid.h and drm/drmP.h as these are no longer required. Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- drivers/gpu/drm/i915/intel_display.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/dr

[Intel-gfx] [PATCH i-g-t v4] tests/kms_plane_lowres: Plane visibility after atomic modesets

2016-12-30 Thread Mika Kahola
option for multiple test iterations (Daniel Vetter) v4: switch 'for_each_connected_output()' to 'for_each_valid_output_on_pipe()' (Maarten) Cc: Daniel Stone <dan...@fooishbar.org> Cc: Maarten Lankhorst <maarten.lankho...@linux.intel.com> Signed-off-by: Mika Kahola <mika.k

[Intel-gfx] [PATCH i-g-t 2/5] tests/kms_atomic_transition: Add TEST_ONLY flag

2016-12-30 Thread Mika Kahola
Add TEST_ONLY flag to test atomic transition display commits without actual real-life commit. Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- tests/kms_atomic_transition.c | 227 -- 1 file changed, 152 insertions(+), 75 deletions(-) diff

[Intel-gfx] [PATCH i-g-t 3/5] tests/kms_plane_scaling: Add TEST_ONLY flag

2016-12-30 Thread Mika Kahola
Add TEST_ONLY flag to test atomic scaling without actually committing the changes. Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- tests/kms_plane_scaling.c | 152 -- 1 file changed, 135 insertions(+), 17 deletions(-) diff --git a

[Intel-gfx] [PATCH i-g-t 0/5] Validate TEST_ONLY correctness against full atomic commit

2016-12-30 Thread Mika Kahola
with TEST_ONLY flag the real deal atomic commit is executed and the outcome is verified. For: VIZ-6956 Mika Kahola (5): tests/kms_plane_multiple: Add TEST_ONLY flag tests/kms_atomic_transition: Add TEST_ONLY flag tests/kms_plane_scaling: Add TEST_ONLY flag tests/kms_rotation_crc: Add TEST_ONLY flag

[Intel-gfx] [PATCH i-g-t 4/5] tests/kms_rotation_crc: Add TEST_ONLY flag

2016-12-30 Thread Mika Kahola
Add TEST_ONLY flag to test atomic transition display commits without actual real-life commit. Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- tests/kms_rotation_crc.c | 282 +-- 1 file changed, 222 insertions(+), 60 deletions(-) diff

[Intel-gfx] [PATCH i-g-t 5/5] tests/kms_test_only: Validate TEST_ONLY correctness against full atomic commit

2016-12-30 Thread Mika Kahola
with TEST_ONLY flag the real deal atomic commit is executed and the outcome is verified. The test runs by default for 64 iterations. Signed-off-by: Mika Kahola <mika.kah...@intel.com> --- tests/Makefile.sources | 1 + tests/kms_test_only.c | 455 + 2

<    1   2   3   4   5   6   7   8   9   10   >