smus <james.aus...@intel.com>
Reviewed-by: Petri Latvala <petri.latv...@intel.com>
> ---
> lib/igt_debugfs.c | 1 +
> lib/igt_sysfs.c | 1 +
> tools/aubdump.c | 1 +
> 3 files changed, 3 insertions(+)
>
> diff --git a/lib/igt_debugfs.c b/lib/igt_debugfs.c
>
On Wed, Sep 27, 2017 at 11:37:33AM -0700, Eric Anholt wrote:
> Signed-off-by: Eric Anholt <e...@anholt.net>
For the series:
Reviewed-by: Petri Latvala <petri.latv...@intel.com>
> ---
> benchmarks/prime_lookup.c | 2 +-
> tests/gem_exec_reuse.c| 3 ++-
> 2
xesting pipe.
^unexisting
--
Petri Latvala
>
> Signed-off-by: Gabriel Krisman Bertazi <kris...@collabora.co.uk>
> Reviewed-by: Maarten Lankhorst <maarten.lankho...@linux.intel.com>
> ---
> lib/igt_kms.c | 2 +-
> 1 file changed, 1 i
tools/registers/kabylake was not included in the REGISTER_FILES list,
so didn't get included in tarballs or installed.
Signed-off-by: Petri Latvala <petri.latv...@intel.com>
---
Some files still remain that are not tarballed or installed:
Should these be included in all platform
Adding LIBDRM_INTEL_BENCHMARKS into benchmarks_PROGRAMS had a tab
before the assignment, making the line be inserted into the Makefile
as is instead of being evaluated by automake.
Signed-off-by: Petri Latvala <petri.latv...@intel.com>
---
benchmarks/Makefile.am | 2 +-
1 file chan
4
--- a/tests/meson.build
+++ b/tests/meson.build
@@ -243,6 +243,7 @@ if libdrm_vc4.found()
'vc4_create_bo',
'vc4_dmabuf_poll',
'vc4_lookup_fail',
+ 'vc4_purgeable_bo',
'vc4_wait_bo',
'vc4_wait_seqno',
]
kip so I presume this means all existing tests
check the number of planes available.
> Signed-off-by: Ville Syrjälä <ville.syrj...@linux.intel.com>
Reviewed-by: Petri Latvala <petri.latv...@intel.com>
> ---
> lib/igt_kms.c | 6 +++---
> 1 file changed, 3 insertions(+)
lle.syrj...@linux.intel.com>
Reviewed-by: Petri Latvala <petri.latv...@intel.com>
> ---
> tests/kms_draw_crc.c | 23 ---
> 1 file changed, 20 insertions(+), 3 deletions(-)
>
> diff --git a/tests/kms_draw_crc.c b/tests/kms_draw_crc.c
> index 260950c7
mode->hdisplay = 1024;
> + mode->vdisplay = 768;
> + prepare_crtc(d, output, pipe, d->plane1, mode,
> COMMIT_LEGACY);
> + }
else
igt_info("Not gonna do sprite scaling\n");
maybe? With a better string.
--
Petri Latvala
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Tue, Sep 26, 2017 at 02:01:46PM +0200, Daniel Vetter wrote:
> On Mon, Sep 25, 2017 at 02:48:41PM +0300, Jani Nikula wrote:
> > On Mon, 25 Sep 2017, Petri Latvala <petri.latv...@intel.com> wrote:
> > > [[ a != b ]] is a bashism. As it's just comparing $1 to an em
> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
After a discussion on IRC regarding kernel backwards compatibility of
DROP_ACTIVE, this LGTM.
Reviewed-by: Petri Latvala <petri.latv...@intel.com>
> ---
> lib/drmtest.c | 28 +---
&g
[[ a != b ]] is a bashism. As it's just comparing $1 to an empty
string, use -n with a normal [ ].
/bin/sh is dash in CI.
Fixes: f0243a761f1b ("tests/igt_command_line.sh: Allow testing individual
tests")
CC: Daniel Vetter <daniel.vet...@ffwll.ch>
Signed-off-by: Petri Lat
context_get_sseu_masks(context1, engine, _mask, NULL);
> + igt_assert_eq(device_subslice_mask, subslice_mask);
> + context_get_sseu_masks(context2, engine, _mask, NULL);
> + igt_assert_eq(mask_minus(mask_minus(device_subslice_mask)),
> sub
On Mon, Sep 25, 2017 at 11:33:51AM +0300, Abdiel Janulgue wrote:
>
>
> On 09/21/2017 03:52 PM, Petri Latvala wrote:
> > Instead of redirecting output to pipes and forking, redirect after
> > forking to avoid having to carefully unredirect before logging
> > anythi
On Fri, Sep 22, 2017 at 03:05:44PM +0300, Ville Syrjälä wrote:
> On Fri, Sep 22, 2017 at 12:52:59PM +0300, Petri Latvala wrote:
> > On Thu, Sep 21, 2017 at 05:39:30PM +0300, Ville Syrjala wrote:
> > > From: Ville Syrjälä <ville.syrj...@linux.intel.com>
where we run it from.
>
> Signed-off-by: Ville Syrjälä <ville.syrj...@linux.intel.com>
Reviewed-by: Petri Latvala <petri.latv...@intel.com>
> ---
> tests/kms_panel_fitting.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/tests/k
gzilla: https://bugs.freedesktop.org/show_bug.cgi?id=92248
(Not sure if this patch fixes it yet or if CI switch to make install
-deployment is also needed)
kms_plane_fitting doesn't seem to have a separate bug report.
Reviewed-by: Petri Latvala <petri.latv...@intel.com>
> ---
> lib/igt
set
the subjectprefix for you automatically.
--
Petri Latvala
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
On Fri, Sep 22, 2017 at 12:03:39PM +0300, Arkadiusz Hiler wrote:
> On Fri, Aug 25, 2017 at 01:13:50PM +0300, Petri Latvala wrote:
> > This series makes a 'make install'ed IGT runnable with piglit. One
> > issue is that piglit expects test-list.txt and test-list-full.txt to
>
was to check that the tool prints
only one line, not that it prints "at least" a line. Modify the last
check to verify that an "is disabled" text is _not_ printed.
v2: Add a TODO comment
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101650
Signed-off-by: Petri
prepended by [cmd] because output was redirected,
causing outputs to appear multiple times. This patch fixes that.
CC: Abdiel Janulgue <abdiel.janul...@linux.intel.com>
Signed-off-by: Petri Latvala <petri.latv...@intel.com>
---
lib/igt_
x.intel.com>
Signed-off-by: Petri Latvala <petri.latv...@intel.com>
---
tests/tools_test.c | 83 ++
1 file changed, 46 insertions(+), 37 deletions(-)
diff --git a/tests/tools_test.c b/tests/tools_test.c
index 132bb88b..ed32bb29 100644
---
On Mon, Sep 18, 2017 at 12:51:07PM -0700, Rodrigo Vivi wrote:
> > Reviewed-by: Rodrigo Vivi <rodrigo.v...@intel.com>
>
> merged to master. thanks for the patch,.
Obligatory scolding: You forgot to add your R-b to the commit message.
o know they get to
keep both pieces when things break. And installing the .so is anyway
something to be done sooner or later.
Acked-by: Petri Latvala <petri.latv...@intel.com>
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.fr
LOAD}} \
> +LD_PRELOAD=${libdir}/libintel_aubdump.so${LD_PPRELOAD:+:${LD_PRELOAD}} \
> exec -- "$@" 3<https://patchwork.freedesktop.org/series/30155/
--
Petri Latvala
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
> bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101650
> Cc: Petri Latvala <petri.latv...@intel.com>
> Signed-off-by: Abdiel Janulgue <abdiel.janul...@linux.intel.com>
> ---
> tests/tools_test.c | 64
> ++
&
to have their number selection
documented to avoid cases like the number hunting Marta had to do for
the fbc bug, but meh. Either way,
Reviewed-by: Petri Latvala <petri.latv...@intel.com>
> ---
> lib/igt_kms.c| 3 +-
> lib/igt_kms.h
t; Changed junk struct and stuff array names.
> Made some minor coding style changes.
>
> Cc: Vinay Belgaumkar <vinay.belgaum...@intel.com>
> Cc: Petri Latvala <petri.latv...@intel.com>
> Cc: Arkadiusz Hiler <arkadiusz.hi...@intel.com>
> Cc: Daniel Vetter <
batches */
> +
> + igt_assert_eq(__gem_wait(fd, obj.handle, -1), 0);
> + igt_assert_eq(sync_fence_status(fence), -EIO);
> + close(fence);
>
> igt_require(i915_reset_control(true));
> trigger_reset(fd);
> + close(timeline);
> }
>
> igt_main
> @@ -241,
On Thu, Sep 07, 2017 at 09:49:42AM +0300, Abdiel Janulgue wrote:
> Check support before executing test.
> v2: Skip test only if intel_l3_parity tool tells us to skip. (Petri)
>
> bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=101650
> Cc: Petri Latvala <petri.latv...@i
ng into a bigger series
> already. And of course we need to keep autohell working for probably a
> fairly long time, at least for the tools that distro install.
>
> Comments and testing very much welcom.
>
Series is
Acked-by: Petri Latvala <petri.latv...@intel.com>
__
On 09/05/2017 07:16 PM, Daniel Vetter wrote:
On Tue, Sep 05, 2017 at 03:39:49PM +0300, Petri Latvala wrote:
When no action is specified on the command line, print the usage help
text and exit with failure instead of SIGABRT. Fix some typos on the
usage text.
Keep the abort() call in places
message printed.
CC: Ben Widawsky <benjamin.widaw...@intel.com>
Signed-off-by: Petri Latvala <petri.latv...@intel.com>
---
tools/intel_l3_parity.c | 12 +---
1 file changed, 9 insertions(+), 3 deletions(-)
diff --git a/tools/intel_l3_parity.c b/tools/intel_l3_parity.c
index eb00
t;../tools/intel_l3_parity") !=
> + IGT_EXIT_SUCCESS,
> + "intel_l3_parity not supported\n");
That's not how the tool works. If you give it no parameters, it will
call abort() on all platforms because it wants an action on the
command line.
Skipp
On Tue, Sep 05, 2017 at 08:39:00AM +0200, Daniel Vetter wrote:
> This reverts commit effb78b382895c19d0946c217cee3602dcd94c50.
>
> cibuglog is for filtering unstable results, we can't simply opt to not
> test PSR.
>
> Signed-off-by: Daniel Vetter <daniel.vet...@intel.
On Sat, Aug 26, 2017 at 02:17:40PM +, Patchwork wrote:
> CC gem_exec_nop.o
> Makefile:3922: recipe for target 'gem_exec_nop.o' failed
> Makefile:4407: recipe for target 'all-recursive' failed
> Makefile:530: recipe for target 'all-recursive' failed
> Makefile:462: recipe for target
gt; to the caller, all other values were a success, so convert those to 0.
>
> This should actually be no functional change, as all errors were
> reported as 1, and everything else as 0.
>
> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
Re
:
pass -> SKIP (shard-hsw)
Also happens on snb, kbl, so looks very real. Please investigate
before pushing.
Is very real, but happens with or without this series.
https://intel-gfx-ci.01.org/tree/drm-tip/shards.html
--
Petri Latv
_unload() == 0
> Last errno: 2, No such file or directory
>
> Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
Reviewed-by: Petri Latvala <petri.latv...@intel.com>
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
domain changes, it is to check that FBC was (re-)enabled.
Can this explanation be added to the code as a comment too?
--
Petri Latvala
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Signed-off-by: Petri Latvala <petri.latv...@intel.com>
Cc: Tomi Sarvela <tomi.p.sarv...@intel.com>
Cc: Arkadiusz Hiler <arkadiusz.hi...@intel.com>
---
tests/intel-ci/Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/intel-ci/Makefile.a
Piglit expects test-list*.txt files to be in the same directory as the
test binaries. Installing non-executable files to libexecdir requires
going around some of autotools' sanity checks.
This change should make 'make install':ed IGT runnable with piglit.
Signed-off-by: Petri Latvala <petri.l
This series makes a 'make install'ed IGT runnable with piglit. One
issue is that piglit expects test-list.txt and test-list-full.txt to
be in the same directory as the test binaries. Another is that the
testlist files were not installed.
Petri Latvala (2):
tests/Makefile.am: Install test-list
n
comparing e.g. these results from the Fi.CI.IGT results:
https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_2995/shard-kbl3/igt@pm_...@debugfs-read.html
vs
https://intel-gfx-ci.01.org/tree/drm-tip/IGTPW_86/shard-kbl1/igt@pm_...@debugfs-read.html
Reviewed-by: Petri Latvala <petri
The list has been unmaintained and unused. The set of tests is a
subset of what CI runs in sharded runs so we are running all of them
already.
Signed-off-by: Petri Latvala <petri.latv...@intel.com>
---
tests/intel-ci/Makefile.am | 1 -
tests/intel-ci/README | 6 --
tests
Note: Alsa libraries are not installed in CI atm so this series wasn't
quite tested.
--
Petri Latvala
On Thu, Aug 17, 2017 at 04:24:21PM +, Patchwork wrote:
> == Series Details ==
>
> Series: series starting with [1/3] lib: Add audio library with dedicated
> helpers
>
On Tue, Jun 27, 2017 at 02:04:51PM -0700, Kelvin Gardiner wrote:
> Added an initial list of fast feedback tests for simulation
> environments.
Merged, thanks.
--
Petri Latvala
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
On Mon, Aug 14, 2017 at 12:48:54PM +0300, Petri Latvala wrote:
> The series LGTM.
>
> Can you resend the whole series and slap a revert of
> 1385b31d9371fae02af2fd8adb0d9ea86a5bb0f2 at the end? With a pass of
> CI on such a bunch this series is
>
> Reviewed-by: Petr
A simple and naive format: Double newline denotes paragraph change,
otherwise insert subtest documentation into the generated docs as-is.
Signed-off-by: Petri Latvala <petri.latv...@intel.com>
---
docs/reference/intel-gpu-tools/Makefile.am | 6 ++
1 file changed, 6 insertions(+)
diff
Signed-off-by: Petri Latvala <petri.latv...@intel.com>
---
README | 5 +
1 file changed, 5 insertions(+)
diff --git a/README b/README
index d1ea952..5b6cb00 100644
--- a/README
+++ b/README
@@ -32,6 +32,11 @@ tests/
be run. Some tests have futher options and these are de
t subtest name will then require doing
pattern matching in the documentation generator, for subtests where
the name is generated at runtime using igt_subtest_f.
v2: Rebase, change function name in commit message to match code
v3: Fix current documentation string tracking, add missing va_end (Vi
Changes:
1/5 Fix a brainfart that I thought I tested for. Thanks, CI!
Petri Latvala (5):
Add support for subtest-specific documentation
README: Describe the subtest documentation command line flags
docs: Include subtest documentation
testdisplay: Handle subtest documentation flags
Signed-off-by: Petri Latvala <petri.latv...@intel.com>
---
tests/igt_command_line.sh | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/tests/igt_command_line.sh b/tests/igt_command_line.sh
index 7f80fc8..b3a794c 100755
--- a/tests/igt_command_line.sh
+++ b
testdisplay has no subtests so hook them to existing subtest handling.
Signed-off-by: Petri Latvala <petri.latv...@intel.com>
---
tests/testdisplay.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/testdisplay.c b/tests/testdisplay.c
index f2a41fa..85b118f 100644
--- a
testdisplay has no subtests so hook them to existing subtest handling.
Signed-off-by: Petri Latvala <petri.latv...@intel.com>
---
TODO: Make testdisplay use igt_simple_init_parse_opts...
tests/testdisplay.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/testdisplay.c b
Signed-off-by: Petri Latvala <petri.latv...@intel.com>
---
tests/igt_command_line.sh | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git a/tests/igt_command_line.sh b/tests/igt_command_line.sh
index 7f80fc8..b3a794c 100755
--- a/tests/igt_command_line.sh
+++ b
A simple and naive format: Double newline denotes paragraph change,
otherwise insert subtest documentation into the generated docs as-is.
Signed-off-by: Petri Latvala <petri.latv...@intel.com>
---
Still not sure whether inside is
kosher.
docs/reference/intel-gpu-tools/Makefile.
t subtest name will then require doing
pattern matching in the documentation generator, for subtests where
the name is generated at runtime using igt_subtest_f.
v2: Rebase, change function name in commit message to match code
v3: Fix current documentation string tracking, add missing va_end (Vi
Signed-off-by: Petri Latvala <petri.latv...@intel.com>
---
README | 5 +
1 file changed, 5 insertions(+)
diff --git a/README b/README
index d1ea952..5b6cb00 100644
--- a/README
+++ b/README
@@ -32,6 +32,11 @@ tests/
be run. Some tests have futher options and these are de
New ever-growing series with some fixes and additions.
Petri Latvala (5):
Add support for subtest-specific documentation
README: Describe the subtest documentation command line flags
docs: Include subtest documentation
testdisplay: Handle subtest documentation flags
igt_command_line.sh
> > void igt_skip_on_simulation(void)
> > {
> > - if (igt_only_list_subtests())
> > + if (igt_only_collect_data())
> > return;
> > if (!in_fixture && !in_subtest) {
> > @@ -2087,7 +2174,7 @@ void igt_vlog(const char *domain, enum igt_log_level
> > level, const char *format,
> > program_name = command_str;
> > #endif
> > - if (list_subtests && level <= IGT_LOG_WARN)
> > + if (igt_only_collect_data() && level <= IGT_LOG_WARN)
> > return;
> > if (vasprintf(, format, args) == -1)
> > diff --git a/lib/igt_core.h b/lib/igt_core.h
> > index 1619a9d..275e467 100644
> > --- a/lib/igt_core.h
> > +++ b/lib/igt_core.h
> > @@ -197,8 +197,12 @@ bool __igt_run_subtest(const char *subtest_name);
> > #define igt_subtest_f(f...) \
> > __igt_subtest_f(igt_tokencat(__tmpchar, __LINE__), f)
> > +void igt_document_subtest(const char *documentation);
> > +__attribute__((format(printf, 1, 2)))
> > +void igt_document_subtest_f(const char *documentation, ...);
> > +
> > const char *igt_subtest_name(void);
> > -bool igt_only_list_subtests(void);
> > +bool igt_only_collect_data(void);
> > void __igt_subtest_group_save(int *);
> > void __igt_subtest_group_restore(int);
>
> I have also sent you a separate email with the gtkdoc generated after using
> the new method.
>
The documentation string tracking was indeed done wrong, fixed in the
new series.
--
Petri Latvala
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
A simple and naive format: Double newline denotes paragraph change,
otherwise insert subtest documentation into the generated docs as-is.
Signed-off-by: Petri Latvala <petri.latv...@intel.com>
---
This works for me, but I don't know if the generated docs are actually
valid docbook xml.
t subtest name will then require doing
pattern matching in the documentation generator, for subtests where
the name is generated at runtime using igt_subtest_f.
v2: Rebase, change function name in commit message to match code
Signed-off-by: Petri Latvala <petri.latv...@intel.com>
=
> See lib/tests/test-suite.log
Changes are underway to have this dumped into the output for pw failures.
--
Petri Latvala
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
BIT(0)
> +#define INCLUDE_SET BIT(1)
> +#define EXCLUDE_SET BIT(2)
> +
> +} igt_ftrace = { -1 };
> +
Why are those #defines inside the struct definition?
--
Petri Latvala
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
h
On 08/08/2017 12:55 PM, Arkadiusz Hiler wrote:
On Mon, Aug 07, 2017 at 03:23:29PM +0300, Petri Latvala wrote:
Signed-off-by: Petri Latvala <petri.latv...@intel.com>
Reviewed-by: Arkadiusz Hiler <arkadiusz.hi...@intel.com>
Thanks, pushed.
--
P
Signed-off-by: Petri Latvala <petri.latv...@intel.com>
---
tools/intel_gpu_top.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tools/intel_gpu_top.c b/tools/intel_gpu_top.c
index 7848876..3fe77f7 100644
--- a/tools/intel_gpu_top.c
+++ b/tools/intel_gpu_top.c
@@ -513,7
e value of local_I915_OA_FORMAT_A12, etc. You need to use the
number.
--
Petri Latvala
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Please fix asap.
--
Petri Latvala
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
Commit 37b06eb9b526df6c23ec75f7a9ecd9547fa76695 limited the used
engines to only the default engine, dropping the engine name from
subtest names, but left over the format parameter.
Fixes: 37b06eb9b526 ("tests/kms_busy: Only test against one engine")
Signed-off-by: Petri Latvala &
Fixes: 848fc49e22c6 ("tests: delete extended.testlist")
Signed-off-by: Petri Latvala <petri.latv...@intel.com>
---
tests/intel-ci/Makefile.am | 1 -
1 file changed, 1 deletion(-)
diff --git a/tests/intel-ci/Makefile.am b/tests/intel-ci/Makefile.am
index 9fb9744..d74e7ec 100644
-
a/tests/intel-ci/extended.testlist
> > b/tests/intel-ci/extended.testlist
> > deleted file mode 100644
> > index 17eed013f810..
> > --- a/tests/intel-ci/extended.testlist
> > +++ /dev/null
>
> Acked-by: Tomi Sarvela <tomi.p.sarv...@intel.com>
And pus
Debian and Ubuntu have XMLRPC packages without pkg-config files. Let's
do automatically what the user would anyway do manually.
Signed-off-by: Petri Latvala <petri.latv...@intel.com>
CC: Daniel Vetter <daniel.vet...@intel.com>
CC: Paul Kocialkowski <paul.kocialkow...@linux.intel
kefile.sources
> @@ -12,6 +12,7 @@ tools_prog_lists = \
> intel_bios_dumper \
> intel_display_crc \
> intel_display_poller\
> + intel_engine_stats \
> intel_forcewaked\
> intel_gpu_frequency \
> intel
Uses new uapi tokens, please add those as LOCAL_* definitions.
--
Petri Latvala
On Wed, Aug 02, 2017 at 01:33:11PM +0100, Tvrtko Ursulin wrote:
> From: Tvrtko Ursulin <tvrtko.ursu...@intel.com>
>
> So it works with the i915 PMU RFC kernel patches.
>
> Signed-o
. The problem is,
those lib functions take igt_crc_t** so that they can give you the
correct pointer, kms_plane* wrongly expect them to modify the passed
object.
Mika, can you fix this while you're at it?
--
Petri Latvala
___
Intel-gfx mailing list
Intel
rs for --document-all-subtests
and --document-subtest , but using them blindly without
parallelizing will cause the docs build time to rise too much.
Signed-off-by: Petri Latvala <petri.latv...@intel.com>
---
lib/igt_aux.c | 8 ++--
lib/igt_core.c | 147 +
The series is
Reviewed-by: Petri Latvala <petri.latv...@intel.com>
On Tue, Jun 20, 2017 at 01:11:27AM -0300, Gabriel Krisman Bertazi wrote:
> Signed-off-by: Gabriel Krisman Bertazi <kris...@collabora.co.uk>
> ---
> tests/kms_pipe_crc_basic.c | 3 ++-
> 1 file cha
current: Concurrent and interruptible subtests for atomic
Mika Kuoppala (1):
tests/gem_spin_batch: Add multiengine test
Oscar Mateo (1):
tests/pm_sseu: Re-enable the test
Petri Latvala (18):
Update MAINTAINERS file
igt_command_line.sh: Handle the special cases of drv_sel
Document the test ordering choices in fast-feedback.testlist.
For comments in testlists, piglit commit
commit 0c535186d624071098c10003fdafe8f475ed9ae7
Author: Petri Latvala <petri.latv...@intel.com>
Date: Wed Feb 1 12:57:45 2017 +0200
framework/programs/run.py: Allow comments i
Signed-off-by: Petri Latvala <petri.latv...@intel.com>
---
tests/intel-ci/README | 3 +++
1 file changed, 3 insertions(+)
diff --git a/tests/intel-ci/README b/tests/intel-ci/README
index ae92460..d17922e 100644
--- a/tests/intel-ci/README
+++ b/tests/intel-ci/README
@@ -24,6 +24,9 @
When generating the .gitignore file, use /.gitignore instead of
.gitignore to not have it apply to subdirectories.
Signed-off-by: Petri Latvala <petri.latv...@intel.com>
---
tests/Makefile.am | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/Makefile.am b
Signed-off-by: Petri Latvala <petri.latv...@intel.com>
---
configure.ac | 1 +
tests/Makefile.am | 2 ++
tests/intel-ci/Makefile.am | 7 +++
3 files changed, 10 insertions(+)
create mode 100644 tests/intel-ci/Makefile.am
diff --git a/configure.ac b/configure.ac
The separation of testcases with and without subtests in the build
system was used in the past, but now both are handled the same
way. Merge them together and finally forget about the difference
between TESTS_progs and TESTS_progs_M.
Signed-off-by: Petri Latvala <petri.latv...@intel.
The tests listed in XFAIL_TESTS have moved to lib/tests quite a while
ago.
Signed-off-by: Petri Latvala <petri.latv...@intel.com>
---
tests/Makefile.sources | 8
1 file changed, 8 deletions(-)
diff --git a/tests/Makefile.sources b/tests/Makefile.sources
index b3a680e..14ea5b6
ig
> @@ -0,0 +1,9 @@
Add a header that links to the website like in Mesa's .editorconfig:
# To use this config on you editor, follow the instructions at:
# http://editorconfig.org
Also add
root = true
With those,
Reviewed-by: Petri Latvala <petri.latv...@intel.com>
n error
message. Although autogen.sh is only in git, not in the dist tarball,
so that shouldn't be an issue.
Can you also document that autogen.sh does the config for you in
CONTRIBUTING?
Anyway,
Acked-by: Petri Latvala <petri.latv...@intel.com>
> if test -z "$NOCONFIGURE"; then
>
are on that?
> https://01.org/linuxgraphics/gfx-docs/maintainer-tools/drm-intel.html is
> quite vague on IGT patches.
>
Thanks, pushed this.
Getting commits to IGT is described in igt/CONTRIBUTING. That page
could use a short description of IGT patch flow indeed.
--
Petri Latvala
__
E_BATCH();
> +struct drm_i915_gem_exec_object2 obj;
> +struct drm_i915_gem_execbuffer2 execbuf;
> +
> +uint32_t batch[16];
> +int i = 0;
> +
> +memset(, 0, sizeof(obj));
> +memset(, 0, sizeof(execbuf));
> +
> +execbuf.buffers_ptr = to_user_pointer();
> +execbuf.buffer_count = 1;
> +execbuf.flags = engine;
> +execbuf.flags |= I915_EXEC_SECURE;
>
> - intel_batchbuffer_flush(batch);
> +obj.handle = gem_create(fd, 4096);
> +
> +batch[i++] = MI_STORE_DWORD_IMM | MI_MEM_VIRTUAL;
> +batch[i++] = 0x0; //Low part of the GTT address = 4GByte
> +batch[i++] = 0x1; //High part of the GTT address > GTT size
> +batch[i++] = 0xdeadbeef;
> +
> +batch[i++] = MI_BATCH_BUFFER_END;
> +batch[i++] = 0x0;
> +
> +gem_write(fd, obj.handle, 0, batch, sizeof(batch));
> +gem_execbuf(fd, );
> +
> +gem_close(fd, obj.handle);
> }
Use tabs for indentation here.
--
Petri Latvala
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
; - int err = 0;
> > - if (igt_ioctl(fd, LOCAL_IOCTL_I915_GEM_EXECBUFFER2_WR, execbuf))
> > - err = -errno;
> > - errno = 0;
> > - return err;
> > -}
> > -
> > -static void gem_execbuf_wr(int fd, stru
lex is,
AC_PROG_LEX sets $LEX to 'lex', but assembler/Makefile.am hardcodes
'flex -i' anyway if the assembler is enabled. That still happens
whether AM_ or AC_ is used so this patch is still an improvement.
I would also like to note that the ratio of
characters-in-commit-message to characters-
Patches 1-4 and 6-13 are
Reviewed-by: Petri Latvala <petri.latv...@intel.com>
Nitpicks on the commit message on patch 6 (replied to it).
--
Petri Latvala
On Tue, May 16, 2017 at 03:24:49PM +0200, Arkadiusz Hiler wrote:
> IGTs are broken for Android since the introduction of d
On Tue, May 16, 2017 at 03:24:55PM +0200, Arkadiusz Hiler wrote:
> Those tools does not build on Android due to "Linux-only" dependencies.
s/does/do/
"to" missing in title.
--
Petri Latvala
>
> Let's blacklist them for now.
>
> Signed-off-by: Arkadiu
rogram has terminated. Which never happens.
--
Petri Latvala
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
t; - sysfs_l3_parity
> - test_rte_check (same as check_drm_clients)
> - tools_test
> - ZZ_check_dmesg
>
> Cc: Daniel Vetter <daniel.vet...@ffwll.ch>
> Cc: Petri Latvala <petri.latv...@intel.com>
> Signed-off-by: Abdiel Janulgue <abdiel.janul...@linux.intel.c
* The path to the debugfs directory corresponding to device
> + */
> +const char *igt_debugfs_path(int device)
> +{
> + char *path = 0;
> +
> + if (!path) {
??
--
Petri Latvala
> + char *linkname;
> + int debugfs;
On Thu, Apr 20, 2017 at 11:13:45AM +0300, Abdiel Janulgue wrote:
> Support executing external processes with the goal of capturing its
> standard streams to the igt logging infrastructure in addition to its
> exit status.
>
> Cc: Daniel Vetter <daniel.vet...@ffwll.ch>
he asserts on fd are useless (Petri)
> - Deinit in inverse order.
>
> Cc: Petri Latvala <petri.latv...@intel.com>
> Signed-off-by: Oscar Mateo <oscar.ma...@intel.com>
Thanks, pushed with R-b.
Btw, can you do
git config format.subjectprefix "PAT
_status,
> but I'm not going to work on that soon. And there's always the problem
> with having to sync Kernel and IGT.
>
> Anyway, the current patch plugs the current hole, so I think further
> improvements to this area can come on top of it:
>
> Reviewed-by: Paulo Zanoni <
563,10 @@ igt_main
> igt_subtest("context-sequential")
> sequential(device, handle, FORKED | CONTEXT, 150);
>
> +#if (!defined(ANDROID)) || (defined(ANDROID) && ANDROID_HAS_CAIRO)
Likewise.
--
Petri Latvala
> ig
301 - 400 of 508 matches
Mail list logo
