Re: [Intel-gfx] [RFC, drm-misc-next v4 0/9] PCI/VGA: Allowing the user to select the primary video adapter at boot time

2023-09-06 Thread Alex Williamson
On Wed, 6 Sep 2023 11:51:59 +0800 Sui Jingfeng wrote: > Hi, > > > On 2023/9/5 22:52, Alex Williamson wrote: > > On Tue, 5 Sep 2023 03:57:15 +0800 > > Sui Jingfeng wrote: > > > >> From: Sui Jingfeng > >> > >> On a machine with multi

Re: [Intel-gfx] [RFC, drm-misc-next v4 0/9] PCI/VGA: Allowing the user to select the primary video adapter at boot time

2023-09-05 Thread Alex Williamson
On Wed, 6 Sep 2023 00:21:09 +0800 suijingfeng wrote: > Hi, > > On 2023/9/5 22:52, Alex Williamson wrote: > > On Tue, 5 Sep 2023 03:57:15 +0800 > > Sui Jingfeng wrote: > > > >> From: Sui Jingfeng > >> > >> On a machine with multiple

Re: [Intel-gfx] [RFC, drm-misc-next v4 0/9] PCI/VGA: Allowing the user to select the primary video adapter at boot time

2023-09-05 Thread Alex Williamson
On Tue, 5 Sep 2023 03:57:15 +0800 Sui Jingfeng wrote: > From: Sui Jingfeng > > On a machine with multiple GPUs, a Linux user has no control over which > one is primary at boot time. This series tries to solve above mentioned > problem by introduced the ->be_primary() function stub. The

Re: [Intel-gfx] [PATCH v15 00/26] Add vfio_device cdev for iommufd support

2023-07-25 Thread Alex Williamson
On Mon, 24 Jul 2023 13:09:22 -0600 Alex Williamson wrote: > On Tue, 18 Jul 2023 13:57:46 -0300 > Jason Gunthorpe wrote: > > > On Tue, Jul 18, 2023 at 06:55:25AM -0700, Yi Liu wrote: > > > Existing VFIO provides group-centric user APIs for userspace. Userspace &

Re: [Intel-gfx] [PATCH v15 00/26] Add vfio_device cdev for iommufd support

2023-07-24 Thread Alex Williamson
On Tue, 18 Jul 2023 13:57:46 -0300 Jason Gunthorpe wrote: > On Tue, Jul 18, 2023 at 06:55:25AM -0700, Yi Liu wrote: > > Existing VFIO provides group-centric user APIs for userspace. Userspace > > opens the /dev/vfio/$group_id first before getting device fd and hence > > getting access to device.

Re: [Intel-gfx] [PATCH 0/2] eventfd: simplify signal helpers

2023-07-17 Thread Alex Williamson
On Mon, 17 Jul 2023 19:12:16 -0300 Jason Gunthorpe wrote: > On Mon, Jul 17, 2023 at 01:08:31PM -0600, Alex Williamson wrote: > > > What would that mechanism be? We've been iterating on getting the > > serialization and buffering correct, but I don't know of another means

Re: [Intel-gfx] [PATCH 0/2] eventfd: simplify signal helpers

2023-07-17 Thread Alex Williamson
On Mon, 17 Jul 2023 10:29:34 +0200 Grzegorz Jaszczyk wrote: > pt., 14 lip 2023 o 09:05 Christian Brauner napisaƂ(a): > > > > On Thu, Jul 13, 2023 at 11:10:54AM -0600, Alex Williamson wrote: > > > On Thu, 13 Jul 2023 12:05:36 +0200 > > > Christian Brauner wr

Re: [Intel-gfx] [PATCH v13 21/22] vfio: Compile vfio_group infrastructure optionally

2023-07-17 Thread Alex Williamson
On Mon, 17 Jul 2023 08:08:59 + "Liu, Yi L" wrote: > > From: Liu, Yi L > > Sent: Monday, July 17, 2023 2:36 PM > > > > > From: Liu, Yi L > > > Sent: Friday, June 16, 2023 5:40 PM > > > > > > vfio_group is not needed for vfio device cdev, so with vfio device cdev > > > introduced, the

Re: [Intel-gfx] [PATCH 0/2] eventfd: simplify signal helpers

2023-07-13 Thread Alex Williamson
On Thu, 13 Jul 2023 12:05:36 +0200 Christian Brauner wrote: > Hey everyone, > > This simplifies the eventfd_signal() and eventfd_signal_mask() helpers > by removing the count argument which is effectively unused. We have a patch under review which does in fact make use of the signaling value:

Re: [Intel-gfx] [PATCH v13 22/22] docs: vfio: Add vfio device cdev description

2023-06-28 Thread Alex Williamson
On Tue, 27 Jun 2023 13:12:14 -0300 Jason Gunthorpe wrote: > On Tue, Jun 27, 2023 at 08:54:33AM +, Liu, Yi L wrote: > > > From: Alex Williamson > > > Sent: Thursday, June 22, 2023 5:54 AM > > > > > > On Fri, 16 Jun 2023 02:39:46 -0700 > > > Y

Re: [Intel-gfx] [PATCH v13 22/22] docs: vfio: Add vfio device cdev description

2023-06-21 Thread Alex Williamson
On Fri, 16 Jun 2023 02:39:46 -0700 Yi Liu wrote: > This gives notes for userspace applications on device cdev usage. > > Reviewed-by: Kevin Tian > Signed-off-by: Yi Liu > --- > Documentation/driver-api/vfio.rst | 139 ++ > 1 file changed, 139 insertions(+) > >

Re: [Intel-gfx] [PATCH v12 21/24] vfio: Determine noiommu device in __vfio_register_dev()

2023-06-20 Thread Alex Williamson
On Tue, 13 Jun 2023 15:01:35 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Tuesday, June 13, 2023 10:48 PM > > > > On Tue, 13 Jun 2023 14:33:01 + > > "Liu, Yi L" wrote: > > > > > >

Re: [Intel-gfx] [PATCH v12 21/24] vfio: Determine noiommu device in __vfio_register_dev()

2023-06-20 Thread Alex Williamson
[Sorry for breaking threading, replying to my own message id with reply content from Yi since the Cc list got broken] On Tue, 13 Jun 2023 15:28:06 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Tuesday, June 13, 2023 11:13 PM > > > > On Tue, 1

Re: [Intel-gfx] [PATCH v12 21/24] vfio: Determine noiommu device in __vfio_register_dev()

2023-06-13 Thread Alex Williamson
On Tue, 13 Jun 2023 14:35:09 -0300 Jason Gunthorpe wrote: > On Tue, Jun 13, 2023 at 11:15:11AM -0600, Alex Williamson wrote: > > [Sorry for breaking threading, replying to my own message id with reply > > content from Yi since the Cc list got broken] > > Yikes it is rea

Re: [Intel-gfx] [PATCH v12 07/24] vfio: Block device access via device fd until device is opened

2023-06-13 Thread Alex Williamson
On Tue, 13 Jun 2023 14:19:17 -0300 Jason Gunthorpe wrote: > On Tue, Jun 13, 2023 at 08:16:47AM -0600, Alex Williamson wrote: > > > > Not quite get why bit field is going to be incompatible with smp > > > lockless operations. Could you elaborate a

Re: [Intel-gfx] [PATCH v12 24/24] docs: vfio: Add vfio device cdev description

2023-06-13 Thread Alex Williamson
On Tue, 13 Jun 2023 15:11:06 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Tuesday, June 13, 2023 11:04 PM > > > > > > > > > > > > > > > > > > > Unless I missed it, we've not described that

Re: [Intel-gfx] [PATCH v12 24/24] docs: vfio: Add vfio device cdev description

2023-06-13 Thread Alex Williamson
On Tue, 13 Jun 2023 14:48:02 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Tuesday, June 13, 2023 10:24 PM > > > > On Tue, 13 Jun 2023 12:01:51 + > > "Liu, Yi L" wrote: > > > > > > From: Alex Williamson

Re: [Intel-gfx] [PATCH v12 18/24] vfio: Add VFIO_DEVICE_BIND_IOMMUFD

2023-06-13 Thread Alex Williamson
On Tue, 13 Jun 2023 14:42:46 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Tuesday, June 13, 2023 10:40 PM > > > > On Tue, 13 Jun 2023 14:28:43 + > > "Liu, Yi L" wrote: > > > > > >

Re: [Intel-gfx] [PATCH v12 21/24] vfio: Determine noiommu device in __vfio_register_dev()

2023-06-13 Thread Alex Williamson
On Tue, 13 Jun 2023 14:33:01 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Tuesday, June 13, 2023 10:19 PM > > > > On Tue, 13 Jun 2023 05:53:42 + > > "Liu, Yi L" wrote: > > > > > > From: Alex Williamson

Re: [Intel-gfx] [PATCH v12 07/24] vfio: Block device access via device fd until device is opened

2023-06-13 Thread Alex Williamson
On Tue, 13 Jun 2023 14:36:14 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Tuesday, June 13, 2023 10:17 PM > > > > On Tue, 13 Jun 2023 05:46:32 + > > "Liu, Yi L" wrote: > > > > > > From: Alex Williamson

Re: [Intel-gfx] [PATCH v12 18/24] vfio: Add VFIO_DEVICE_BIND_IOMMUFD

2023-06-13 Thread Alex Williamson
On Tue, 13 Jun 2023 14:28:43 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Tuesday, June 13, 2023 10:18 PM > > > > > > diff --git a/include/linux/vfio.h b/include/linux/vfio.h > > > > > index 83cc5dc28b7a..e

Re: [Intel-gfx] [PATCH v7 8/9] vfio/pci: Extend VFIO_DEVICE_GET_PCI_HOT_RESET_INFO for vfio device cdev

2023-06-13 Thread Alex Williamson
On Tue, 13 Jun 2023 12:50:43 + "Liu, Yi L" wrote: > > From: Jason Gunthorpe > > Sent: Tuesday, June 13, 2023 7:47 PM > > > > On Fri, Jun 02, 2023 at 05:15:14AM -0700, Yi Liu wrote: > > > +/* > > > + * Return devid for a device which is affected by hot-reset. > > > + * - valid devid > 0

Re: [Intel-gfx] [PATCH v12 24/24] docs: vfio: Add vfio device cdev description

2023-06-13 Thread Alex Williamson
On Tue, 13 Jun 2023 12:01:51 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Tuesday, June 13, 2023 7:06 AM > > > > On Fri, 2 Jun 2023 05:16:53 -0700 > > Yi Liu wrote: > > > > > This gives notes for userspace applicatio

Re: [Intel-gfx] [PATCH v12 21/24] vfio: Determine noiommu device in __vfio_register_dev()

2023-06-13 Thread Alex Williamson
On Tue, 13 Jun 2023 05:53:42 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Tuesday, June 13, 2023 6:42 AM > > > > On Fri, 2 Jun 2023 05:16:50 -0700 > > Yi Liu wrote: > > > > > This moves

Re: [Intel-gfx] [PATCH v12 18/24] vfio: Add VFIO_DEVICE_BIND_IOMMUFD

2023-06-13 Thread Alex Williamson
On Tue, 13 Jun 2023 05:48:46 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Tuesday, June 13, 2023 6:27 AM > > > > On Fri, 2 Jun 2023 05:16:47 -0700 > > Yi Liu wrote: > > > > > This add

Re: [Intel-gfx] [PATCH v12 07/24] vfio: Block device access via device fd until device is opened

2023-06-13 Thread Alex Williamson
On Tue, 13 Jun 2023 05:46:32 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Tuesday, June 13, 2023 5:52 AM > > > > On Fri, 2 Jun 2023 05:16:36 -0700 > > Yi Liu wrote: > > > > > Allow the vfio_device file to be in a s

Re: [Intel-gfx] [PATCH v12 24/24] docs: vfio: Add vfio device cdev description

2023-06-12 Thread Alex Williamson
On Fri, 2 Jun 2023 05:16:53 -0700 Yi Liu wrote: > This gives notes for userspace applications on device cdev usage. > > Reviewed-by: Kevin Tian > Signed-off-by: Yi Liu > --- > Documentation/driver-api/vfio.rst | 132 ++ > 1 file changed, 132 insertions(+) > >

Re: [Intel-gfx] [PATCH v12 22/24] vfio: Remove vfio_device_is_noiommu()

2023-06-12 Thread Alex Williamson
On Fri, 2 Jun 2023 05:16:51 -0700 Yi Liu wrote: > This converts noiommu test to use vfio_device->noiommu flag. Per this > change, vfio_device_is_noiommu() is removed. > > Signed-off-by: Yi Liu > --- > drivers/vfio/group.c | 2 +- > drivers/vfio/iommufd.c | 4 ++-- > drivers/vfio/vfio.h

Re: [Intel-gfx] [PATCH v12 21/24] vfio: Determine noiommu device in __vfio_register_dev()

2023-06-12 Thread Alex Williamson
make sense? The motivation for the change is really not clear without cdev support for noiommu. Thanks, Alex > Suggested-by: Alex Williamson > Signed-off-by: Yi Liu > --- > drivers/vfio/group.c | 15 --- > drivers/vfio/vfio_main.c | 31 ++- >

Re: [Intel-gfx] [PATCH v12 20/24] vfio: Only check group->type for noiommu test

2023-06-12 Thread Alex Williamson
On Fri, 2 Jun 2023 05:16:49 -0700 Yi Liu wrote: > group->type can be VFIO_NO_IOMMU only when vfio_noiommu option is true. > And vfio_noiommu option can only be true if CONFIG_VFIO_NOIOMMU is enabled. > So checking group->type is enough when testing noiommu. > > Signed-off-by: Yi Liu > --- >

Re: [Intel-gfx] [PATCH v12 18/24] vfio: Add VFIO_DEVICE_BIND_IOMMUFD

2023-06-12 Thread Alex Williamson
On Fri, 2 Jun 2023 05:16:47 -0700 Yi Liu wrote: > This adds ioctl for userspace to bind device cdev fd to iommufd. > > VFIO_DEVICE_BIND_IOMMUFD: bind device to an iommufd, hence gain DMA > control provided by the iommufd. open_device >

Re: [Intel-gfx] [PATCH v12 07/24] vfio: Block device access via device fd until device is opened

2023-06-12 Thread Alex Williamson
On Fri, 2 Jun 2023 05:16:36 -0700 Yi Liu wrote: > Allow the vfio_device file to be in a state where the device FD is > opened but the device cannot be used by userspace (i.e. its .open_device() > hasn't been called). This inbetween state is not used when the device > FD is spawned from the

Re: [Intel-gfx] [PATCH v12 06/24] vfio: Pass struct vfio_device_file * to vfio_device_open/close()

2023-06-12 Thread Alex Williamson
On Fri, 2 Jun 2023 05:16:35 -0700 Yi Liu wrote: > This avoids passing too much parameters in multiple functions. Per the > input parameter change, rename the function to be vfio_df_open/close(). > > Reviewed-by: Kevin Tian > Reviewed-by: Jason Gunthorpe > Reviewed-by: Eric Auger >

Re: [Intel-gfx] [PATCH v7 9/9] vfio/pci: Allow passing zero-length fd array in VFIO_DEVICE_PCI_HOT_RESET

2023-06-08 Thread Alex Williamson
On Fri, 2 Jun 2023 05:15:15 -0700 Yi Liu wrote: > This is the way user to invoke hot-reset for the devices opened by cdev > interface. User should check the flag VFIO_PCI_HOT_RESET_FLAG_DEV_ID_OWNED > in the output of VFIO_DEVICE_GET_PCI_HOT_RESET_INFO ioctl before doing > hot-reset for cdev

Re: [Intel-gfx] [PATCH v7 8/9] vfio/pci: Extend VFIO_DEVICE_GET_PCI_HOT_RESET_INFO for vfio device cdev

2023-06-08 Thread Alex Williamson
reported > in this mode if all of the devices affected by the hot-reset are owned by > either virtue of being directly bound to the same iommufd context as the > calling device, or implicitly owned via a shared IOMMU group. > > Suggested-by: Jason Gunthorpe > Suggested-by

Re: [Intel-gfx] [PATCH v7 4/9] iommufd: Add iommufd_ctx_has_group()

2023-06-08 Thread Alex Williamson
On Fri, 2 Jun 2023 05:15:10 -0700 Yi Liu wrote: > This adds the helper to check if any device within the given iommu_group > has been bound with the iommufd_ctx. This is helpful for the checking on > device ownership for the devices which have not been bound but cannot be > bound to any other

Re: [Intel-gfx] [PATCH v6 09/10] vfio/pci: Extend VFIO_DEVICE_GET_PCI_HOT_RESET_INFO for vfio device cdev

2023-06-01 Thread Alex Williamson
On Thu, 1 Jun 2023 06:06:17 + "Liu, Yi L" wrote: > > From: Jason Gunthorpe > > Sent: Thursday, June 1, 2023 3:00 AM > > > > On Fri, May 26, 2023 at 10:04:27AM +0800, Baolu Lu wrote: > > > On 5/25/23 9:02 PM, Liu, Yi L wrote: > > > > > It's possible that requirement > > > > > might be

Re: [Intel-gfx] [PATCH v6 10/10] vfio/pci: Allow passing zero-length fd array in VFIO_DEVICE_PCI_HOT_RESET

2023-05-31 Thread Alex Williamson
On Tue, 30 May 2023 04:23:12 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Thursday, May 25, 2023 4:20 AM > > > > On Mon, 22 May 2023 04:57:51 -0700 > > Yi Liu wrote: > > > > > This is the way user to invoke hot-res

Re: [Intel-gfx] [PATCH v11 20/23] vfio: Add VFIO_DEVICE_[AT|DE]TACH_IOMMUFD_PT

2023-05-25 Thread Alex Williamson
On Thu, 25 May 2023 03:03:54 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Wednesday, May 24, 2023 11:32 PM > > > > On Wed, 24 May 2023 02:12:14 + > > "Liu, Yi L" wrote: > > > > > >

Re: [Intel-gfx] [PATCH v6 10/10] vfio/pci: Allow passing zero-length fd array in VFIO_DEVICE_PCI_HOT_RESET

2023-05-24 Thread Alex Williamson
On Mon, 22 May 2023 04:57:51 -0700 Yi Liu wrote: > This is the way user to invoke hot-reset for the devices opened by cdev > interface. User should check the flag VFIO_PCI_HOT_RESET_FLAG_DEV_ID_OWNED > in the output of VFIO_DEVICE_GET_PCI_HOT_RESET_INFO ioctl before doing > hot-reset for cdev

Re: [Intel-gfx] [PATCH v6 09/10] vfio/pci: Extend VFIO_DEVICE_GET_PCI_HOT_RESET_INFO for vfio device cdev

2023-05-24 Thread Alex Williamson
reported > in this mode if all of the devices affected by the hot-reset are owned by > either virtue of being directly bound to the same iommufd context as the > calling device, or implicitly owned via a shared IOMMU group. > > Suggested-by: Jason Gunthorpe > Suggested-by

Re: [Intel-gfx] [PATCH v11 20/23] vfio: Add VFIO_DEVICE_[AT|DE]TACH_IOMMUFD_PT

2023-05-24 Thread Alex Williamson
On Wed, 24 May 2023 02:12:14 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Tuesday, May 23, 2023 11:50 PM > > > > On Tue, 23 May 2023 01:20:17 + > > "Liu, Yi L" wrote: > > > > > > From: Alex Williamson

Re: [Intel-gfx] [PATCH v11 19/23] vfio: Add VFIO_DEVICE_BIND_IOMMUFD

2023-05-23 Thread Alex Williamson
On Tue, 23 May 2023 01:41:36 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Tuesday, May 23, 2023 6:01 AM > > > > On Sat, 13 May 2023 06:28:23 -0700 > > Yi Liu wrote: > > > > > This add

Re: [Intel-gfx] [PATCH v11 20/23] vfio: Add VFIO_DEVICE_[AT|DE]TACH_IOMMUFD_PT

2023-05-23 Thread Alex Williamson
On Tue, 23 May 2023 01:20:17 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Tuesday, May 23, 2023 6:16 AM > > > > On Sat, 13 May 2023 06:28:24 -0700 > > Yi Liu wrote: > > > > > This adds ioctl for userspace to attach de

Re: [Intel-gfx] [PATCH v11 21/23] vfio: Determine noiommu device in __vfio_register_dev()

2023-05-22 Thread Alex Williamson
On Sat, 13 May 2023 06:28:25 -0700 Yi Liu wrote: > This is to make the cdev path and group path consistent for the noiommu > devices registration. If vfio_noiommu is disabled, such registration > should fail. However, this check is vfio_device_set_group() which is part > of the vfio_group code.

Re: [Intel-gfx] [PATCH v11 20/23] vfio: Add VFIO_DEVICE_[AT|DE]TACH_IOMMUFD_PT

2023-05-22 Thread Alex Williamson
On Sat, 13 May 2023 06:28:24 -0700 Yi Liu wrote: > This adds ioctl for userspace to attach device cdev fd to and detach > from IOAS/hw_pagetable managed by iommufd. > > VFIO_DEVICE_ATTACH_IOMMUFD_PT: attach vfio device to IOAS, hw_pagetable > managed by

Re: [Intel-gfx] [PATCH v11 19/23] vfio: Add VFIO_DEVICE_BIND_IOMMUFD

2023-05-22 Thread Alex Williamson
On Sat, 13 May 2023 06:28:23 -0700 Yi Liu wrote: > This adds ioctl for userspace to bind device cdev fd to iommufd. > > VFIO_DEVICE_BIND_IOMMUFD: bind device to an iommufd, hence gain DMA > control provided by the iommufd. open_device >

Re: [Intel-gfx] [PATCH v11 13/23] vfio-iommufd: Add detach_ioas support for physical VFIO devices

2023-05-22 Thread Alex Williamson
On Mon, 22 May 2023 14:46:17 -0600 Alex Williamson wrote: > On Sat, 13 May 2023 06:28:17 -0700 > Yi Liu wrote: > > > this prepares for adding DETACH ioctl for physical VFIO devices. > > > > Reviewed-by: Kevin Tian > > Tested-by: Terrence Xu > &

Re: [Intel-gfx] [PATCH v11 13/23] vfio-iommufd: Add detach_ioas support for physical VFIO devices

2023-05-22 Thread Alex Williamson
On Sat, 13 May 2023 06:28:17 -0700 Yi Liu wrote: > this prepares for adding DETACH ioctl for physical VFIO devices. > > Reviewed-by: Kevin Tian > Tested-by: Terrence Xu > Tested-by: Nicolin Chen > Tested-by: Matthew Rosato > Tested-by: Yanting Jiang > Tested-by: Shameer Kolothum >

Re: [Intel-gfx] [PATCH v11 10/23] vfio-iommufd: Move noiommu compat probe out of vfio_iommufd_bind()

2023-05-22 Thread Alex Williamson
On Sat, 13 May 2023 06:28:14 -0700 Yi Liu wrote: > into vfio_device_group_open(). This is more consistent with what will > be done in vfio device cdev path. Same comment regarding flowing commit subject into body on this series. > > Reviewed-by: Kevin Tian > Tested-by: Terrence Xu >

Re: [Intel-gfx] [PATCH v11 03/23] vfio: Accept vfio device file in the KVM facing kAPI

2023-05-22 Thread Alex Williamson
On Sat, 13 May 2023 06:28:07 -0700 Yi Liu wrote: > This makes the vfio file kAPIs to accept vfio device files, also a > preparation for vfio device cdev support. > > For the kvm set with vfio device file, kvm pointer is stored in struct > vfio_device_file, and use kvm_ref_lock to protect kvm

Re: [Intel-gfx] [PATCH v5 09/10] vfio/pci: Extend VFIO_DEVICE_GET_PCI_HOT_RESET_INFO for vfio device cdev

2023-05-18 Thread Alex Williamson
On Thu, 18 May 2023 13:21:57 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Thursday, May 18, 2023 6:02 AM > > > > On Sat, 13 May 2023 06:21:35 -0700 > > Yi Liu wrote: > > > > > This makes VFIO_DEVICE_GET_PCI_HOT_RESE

Re: [Intel-gfx] [PATCH v5 09/10] vfio/pci: Extend VFIO_DEVICE_GET_PCI_HOT_RESET_INFO for vfio device cdev

2023-05-18 Thread Alex Williamson
On Thu, 18 May 2023 13:31:47 + "Liu, Yi L" wrote: > > From: Liu, Yi L > > Sent: Thursday, May 18, 2023 9:22 PM > > > > > From: Alex Williamson > > > Sent: Thursday, May 18, 2023 6:02 AM > > > > > > On Sat, 13 May 2023

Re: [Intel-gfx] [PATCH v5 06/10] vfio-iommufd: Add helper to retrieve iommufd_ctx and devid for vfio_device

2023-05-18 Thread Alex Williamson
On Thu, 18 May 2023 13:25:59 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Thursday, May 18, 2023 2:15 AM > > > > On Sat, 13 May 2023 06:21:32 -0700 > > Yi Liu wrote: > > > > > This is needed by the vfio-pci d

Re: [Intel-gfx] [PATCH v5 07/10] vfio: Add helper to search vfio_device in a dev_set

2023-05-18 Thread Alex Williamson
On Thu, 18 May 2023 12:31:07 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Thursday, May 18, 2023 3:13 AM > > > > On Sat, 13 May 2023 06:21:33 -0700 > > Yi Liu wrote: > > > > > There are drivers that need to search vfio

Re: [Intel-gfx] [PATCH v5 01/10] vfio-iommufd: Create iommufd_access for noiommu devices

2023-05-18 Thread Alex Williamson
On Thu, 18 May 2023 12:23:29 + "Liu, Yi L" wrote: > > From: Jason Gunthorpe > > Sent: Thursday, May 18, 2023 2:21 AM > > > > On Wed, May 17, 2023 at 11:26:09AM -0600, Alex Williamson wrote: > > > > > It's not clear to me why we

Re: [Intel-gfx] [PATCH v5 09/10] vfio/pci: Extend VFIO_DEVICE_GET_PCI_HOT_RESET_INFO for vfio device cdev

2023-05-17 Thread Alex Williamson
ontext as the calling device, or implicitly owned via a shared IOMMU group. > and adds flag VFIO_PCI_HOT_RESET_FLAG_DEV_ID_OWNED to tell user if all > the affected devices are owned, so user can know it without looping all > the returned devids. > > Suggested-by: Jason Gunthorpe

Re: [Intel-gfx] [PATCH v5 08/10] iommufd: Add iommufd_ctx_has_group()

2023-05-17 Thread Alex Williamson
On Sat, 13 May 2023 06:21:34 -0700 Yi Liu wrote: > to check if any device within the given iommu_group has been bound with Nit, I find these commit logs where the subject line is intended to flow into the commit log to form a complete sentence difficult to read. I expect complete thoughts

Re: [Intel-gfx] [PATCH v5 07/10] vfio: Add helper to search vfio_device in a dev_set

2023-05-17 Thread Alex Williamson
On Sat, 13 May 2023 06:21:33 -0700 Yi Liu wrote: > There are drivers that need to search vfio_device within a given dev_set. > e.g. vfio-pci. So add a helper. > > Signed-off-by: Yi Liu > --- > drivers/vfio/pci/vfio_pci_core.c | 8 +++- > drivers/vfio/vfio_main.c | 15

Re: [Intel-gfx] [PATCH v5 06/10] vfio-iommufd: Add helper to retrieve iommufd_ctx and devid for vfio_device

2023-05-17 Thread Alex Williamson
On Wed, 17 May 2023 15:22:27 -0300 Jason Gunthorpe wrote: > On Wed, May 17, 2023 at 12:15:17PM -0600, Alex Williamson wrote: > > > > +int vfio_iommufd_physical_devid(struct vfio_device *vdev) > > > +{ > > > + if (vdev->iommufd_device) > > &g

Re: [Intel-gfx] [PATCH v5 06/10] vfio-iommufd: Add helper to retrieve iommufd_ctx and devid for vfio_device

2023-05-17 Thread Alex Williamson
On Sat, 13 May 2023 06:21:32 -0700 Yi Liu wrote: > This is needed by the vfio-pci driver to report affected devices in the > hot reset for a given device. > > Signed-off-by: Yi Liu > --- > drivers/iommu/iommufd/device.c | 24 > drivers/vfio/iommufd.c | 20

Re: [Intel-gfx] [PATCH v5 01/10] vfio-iommufd: Create iommufd_access for noiommu devices

2023-05-17 Thread Alex Williamson
On Sat, 13 May 2023 06:21:27 -0700 Yi Liu wrote: > This binds noiommu device to iommufd and creates iommufd_access for this > bond. This is useful for adding an iommufd-based device ownership check > for VFIO_DEVICE_PCI_HOT_RESET since this model requires all the other > affected devices bound

Re: [Intel-gfx] [PATCH v4 8/9] vfio/pci: Extend VFIO_DEVICE_GET_PCI_HOT_RESET_INFO for vfio device cdev

2023-05-08 Thread Alex Williamson
On Mon, 8 May 2023 15:32:44 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Friday, April 28, 2023 4:16 AM > > > > > > + * > > > > * Return: 0 on success, -errno on failure: > > > > *

Re: [Intel-gfx] [PATCH v4 2/9] vfio-iommufd: Create iommufd_access for noiommu devices

2023-05-03 Thread Alex Williamson
On Wed, 3 May 2023 16:41:52 -0300 Jason Gunthorpe wrote: > > > My general idea to complete the no-iommu feature is to add a new IOCTL > > > to VFIO that is 'pin iova and return dma addr' that no-iommu userspace > > > would call instead of trying to abuse mlock and /proc/ to do it. That > > >

Re: [Intel-gfx] [PATCH v4 9/9] vfio/pci: Allow passing zero-length fd array in VFIO_DEVICE_PCI_HOT_RESET

2023-04-27 Thread Alex Williamson
On Wed, 26 Apr 2023 07:54:19 -0700 Yi Liu wrote: > This is the way user to invoke hot-reset for the devices opened by cdev > interface. User should check the flag VFIO_PCI_HOT_RESET_FLAG_RESETTABLE > in the output of VFIO_DEVICE_GET_PCI_HOT_RESET_INFO ioctl before doing > hot-reset for cdev

Re: [Intel-gfx] [PATCH v4 8/9] vfio/pci: Extend VFIO_DEVICE_GET_PCI_HOT_RESET_INFO for vfio device cdev

2023-04-27 Thread Alex Williamson
On Thu, 27 Apr 2023 14:04:05 -0600 Alex Williamson wrote: > On Wed, 26 Apr 2023 07:54:18 -0700 > Yi Liu wrote: > > > This makes VFIO_DEVICE_GET_PCI_HOT_RESET_INFO ioctl to use the bound > > iommufd of the cdev device to check the ownership of the other affected >

Re: [Intel-gfx] [PATCH v4 8/9] vfio/pci: Extend VFIO_DEVICE_GET_PCI_HOT_RESET_INFO for vfio device cdev

2023-04-27 Thread Alex Williamson
-1 will block hot-reset. > > This adds flag VFIO_PCI_HOT_RESET_FLAG_IOMMUFD_DEV_ID to tell the user > dev_id is returned and adds flag VFIO_PCI_HOT_RESET_FLAG_RESETTABLE to > tell user if the cdev device is resettable or not. > > Suggested-by: Jason Gunthorpe > Suggested-by: Alex Williamson > S

Re: [Intel-gfx] [PATCH v4 5/9] vfio: Mark cdev usage in vfio_device

2023-04-27 Thread Alex Williamson
On Wed, 26 Apr 2023 07:54:15 -0700 Yi Liu wrote: > Use it to differentiate whether to report group_id or dev_id in revised > VFIO_DEVICE_GET_PCI_HOT_RESET_INFO ioctl. Though it is not set at this > moment introducing it now allows us to get hot reset ready for cdev. > > Signed-off-by: Yi Liu >

Re: [Intel-gfx] [PATCH v4 1/9] vfio: Determine noiommu in vfio_device registration

2023-04-27 Thread Alex Williamson
On Thu, 27 Apr 2023 07:05:37 + "Liu, Yi L" wrote: > > From: Tian, Kevin > > Sent: Thursday, April 27, 2023 2:36 PM > > > > > From: Liu, Yi L > > > Sent: Wednesday, April 26, 2023 10:54 PM > > > > > > -static inline bool vfio_device_is_noiommu(struct vfio_device *vdev) > > > +static

Re: [Intel-gfx] [PATCH v4 2/9] vfio-iommufd: Create iommufd_access for noiommu devices

2023-04-27 Thread Alex Williamson
On Thu, 27 Apr 2023 06:59:17 + "Liu, Yi L" wrote: > > From: Tian, Kevin > > Sent: Thursday, April 27, 2023 2:39 PM > > > > > From: Liu, Yi L > > > Sent: Wednesday, April 26, 2023 10:54 PM > > > @@ -121,7 +128,8 @@ static void vfio_emulated_unmap(void *data, > > > unsigned long iova, > >

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-26 Thread Alex Williamson
On Wed, 26 Apr 2023 07:22:17 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Thursday, April 20, 2023 10:09 PM > [...] > > > > Whereas dev-id < 0 > > > > (== -1) is an affected device which prevents hot-reset, ex. an un-owned

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-21 Thread Alex Williamson
[Appears the list got dropped, replying to my previous message to re-add] On Tue, 11 Apr 2023 13:32:16 -0300 Jason Gunthorpe wrote: > On Tue, Apr 11, 2023 at 09:54:17AM -0600, Alex Williamson wrote: > > On Tue, 11 Apr 2023 10:24:58 -0300 > > Jason Gunthorpe wrote: > >

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-21 Thread Alex Williamson
On Tue, 11 Apr 2023 10:24:58 -0300 Jason Gunthorpe wrote: > On Thu, Apr 06, 2023 at 11:53:47AM -0600, Alex Williamson wrote: > > > Where whether a device is opened is subject to change outside of the > > user's control. This essentially allows the user to perform hot-res

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-20 Thread Alex Williamson
On Thu, 20 Apr 2023 12:10:20 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Wednesday, April 19, 2023 2:39 AM > > > > On Tue, 18 Apr 2023 09:57:32 -0300 > > Jason Gunthorpe wrote: > > > > > On Mon, Apr 17, 2023 at 02:06:

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-18 Thread Alex Williamson
On Tue, 18 Apr 2023 09:57:32 -0300 Jason Gunthorpe wrote: > On Mon, Apr 17, 2023 at 02:06:42PM -0600, Alex Williamson wrote: > > On Mon, 17 Apr 2023 16:31:56 -0300 > > Jason Gunthorpe wrote: > > > > > On Mon, Apr 17, 2023 at 01:01:40PM -0600, Alex William

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-18 Thread Alex Williamson
On Tue, 18 Apr 2023 10:34:45 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Tuesday, April 18, 2023 12:11 PM > > > [...] > > > > We haven't discussed how it fails when called on a group-opened device > > in a mixed envi

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-18 Thread Alex Williamson
On Tue, 18 Apr 2023 05:02:44 + "Tian, Kevin" wrote: > > From: Alex Williamson > > Sent: Tuesday, April 18, 2023 12:11 PM > > > > On Tue, 18 Apr 2023 03:24:46 + > > "Tian, Kevin" wrote: > > > > > >

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-17 Thread Alex Williamson
On Tue, 18 Apr 2023 03:24:46 + "Tian, Kevin" wrote: > > From: Alex Williamson > > Sent: Tuesday, April 18, 2023 4:07 AM > > > > On Mon, 17 Apr 2023 16:31:56 -0300 > > Jason Gunthorpe wrote: > > > > > On Mon, Apr 17, 2023 at 01:01

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-17 Thread Alex Williamson
On Mon, 17 Apr 2023 16:31:56 -0300 Jason Gunthorpe wrote: > On Mon, Apr 17, 2023 at 01:01:40PM -0600, Alex Williamson wrote: > > Yes, it's not trivial, but Jason is now proposing that we consider > > mixing groups, cdevs, and multiple iommufd_ctxs as invalid. I think

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-17 Thread Alex Williamson
On Mon, 17 Apr 2023 04:20:27 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Saturday, April 15, 2023 1:11 AM > > > > On Fri, 14 Apr 2023 11:38:24 + > > "Liu, Yi L" wrote: > > > > > > From: Tian, Kevin &

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-14 Thread Alex Williamson
On Fri, 14 Apr 2023 11:38:24 + "Liu, Yi L" wrote: > > From: Tian, Kevin > > Sent: Friday, April 14, 2023 5:12 PM > > > > > From: Alex Williamson > > > Sent: Friday, April 14, 2023 2:07 AM > > > > > > We had already iterat

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-14 Thread Alex Williamson
On Fri, 14 Apr 2023 09:11:30 + "Tian, Kevin" wrote: > > From: Alex Williamson > > Sent: Friday, April 14, 2023 2:07 AM > > > > We had already iterated a proposal where the group-id is replaced with > > a dev-id in the existing ioctl and a flag indi

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-13 Thread Alex Williamson
On Thu, 13 Apr 2023 08:50:45 -0300 Jason Gunthorpe wrote: > On Thu, Apr 13, 2023 at 08:25:52AM +, Tian, Kevin wrote: > > > From: Jason Gunthorpe > > > Sent: Thursday, April 13, 2023 4:07 AM > > > > > > > > > > in which case we need c) a way to > > > > report the overall set of affected

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-12 Thread Alex Williamson
On Wed, 12 Apr 2023 12:05:50 -0300 Jason Gunthorpe wrote: > On Wed, Apr 12, 2023 at 07:27:43AM +, Tian, Kevin wrote: > > > From: Jason Gunthorpe > > > Sent: Wednesday, April 12, 2023 8:01 AM > > > > > > I see this problem as a few basic requirements from a qemu-like > > > application: > > >

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-12 Thread Alex Williamson
On Wed, 12 Apr 2023 10:09:32 + "Liu, Yi L" wrote: > > From: Jason Gunthorpe > > Sent: Wednesday, April 12, 2023 8:01 AM > > > > On Tue, Apr 11, 2023 at 03:58:27PM -0600, Alex Williamson wrote: > > > > > > Management tools already need

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-12 Thread Alex Williamson
On Tue, 11 Apr 2023 21:01:06 -0300 Jason Gunthorpe wrote: > On Tue, Apr 11, 2023 at 03:58:27PM -0600, Alex Williamson wrote: > > > > Management tools already need to understand dev_set if they want to > > > offer reliable reset support to the VMs. Same as today. >

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-11 Thread Alex Williamson
On Tue, 11 Apr 2023 15:40:07 -0300 Jason Gunthorpe wrote: > On Tue, Apr 11, 2023 at 11:11:17AM -0600, Alex Williamson wrote: > > [Appears the list got dropped, replying to my previous message to re-add] > > Wowo this got mesed up alot, mutt drops the cc when replying for s

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-10 Thread Alex Williamson
On Mon, 10 Apr 2023 15:18:27 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Monday, April 10, 2023 10:41 PM > > > > On Mon, 10 Apr 2023 08:48:54 + > > "Liu, Yi L" wrote: > > > > > >

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-10 Thread Alex Williamson
On Mon, 10 Apr 2023 08:48:54 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Sunday, April 9, 2023 9:30 PM > [...] > > > yeah, needs to move the iommu group creation back to vfio_main.c. This > > > would be a prerequisite for [1] > &g

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-09 Thread Alex Williamson
On Sun, 9 Apr 2023 19:58:47 +0800 Yi Liu wrote: > On 2023/4/8 22:20, Alex Williamson wrote: > > On Sat, 8 Apr 2023 05:07:16 + > > "Liu, Yi L" wrote: > > > >>> From: Alex Williamson > >>> Sent: Saturday, April 8, 2023 5:07 AM > &g

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-08 Thread Alex Williamson
On Sat, 8 Apr 2023 05:07:16 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Saturday, April 8, 2023 5:07 AM > > > > On Fri, 7 Apr 2023 15:47:10 + > > "Liu, Yi L" wrote: > > > > > > From: Alex Williamson

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-07 Thread Alex Williamson
On Fri, 7 Apr 2023 15:47:10 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Friday, April 7, 2023 11:14 PM > > > > On Fri, 7 Apr 2023 14:04:02 + > > "Liu, Yi L" wrote: > > > > > > From: Alex Williamson &

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-07 Thread Alex Williamson
On Fri, 7 Apr 2023 14:04:02 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Friday, April 7, 2023 9:52 PM > > > > On Fri, 7 Apr 2023 13:24:25 + > > "Liu, Yi L" wrote: > > > > > >

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-07 Thread Alex Williamson
On Fri, 7 Apr 2023 13:24:25 + "Liu, Yi L" wrote: > > From: Alex Williamson > > Sent: Friday, April 7, 2023 8:04 PM > > > > > > > > @@ -791,7 +813,21 @@ static int vfio_pci_fill_devs(struct pci_dev > > > > > >

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-07 Thread Alex Williamson
On Fri, 7 Apr 2023 10:09:58 + "Liu, Yi L" wrote: > Hi Alex, > > > From: Alex Williamson > > Sent: Monday, April 3, 2023 11:02 PM > > > > On Mon, 3 Apr 2023 09:25:06 + > > "Liu, Yi L" wrote: > > > >

Re: [Intel-gfx] [PATCH v9 06/25] kvm/vfio: Accept vfio device file from userspace

2023-04-06 Thread Alex Williamson
On Thu, 6 Apr 2023 10:49:45 + "Liu, Yi L" wrote: > Hi Eric, > > > From: Eric Auger > > Sent: Thursday, April 6, 2023 5:47 PM > > > > Hi Yi, > > > > On 4/1/23 17:18, Yi Liu wrote: > > > This defines KVM_DEV_VFIO_FILE* and make alias with KVM_DEV_VFIO_GROUP*. > > > Old userspace uses

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-06 Thread Alex Williamson
On Thu, 6 Apr 2023 10:02:10 + "Liu, Yi L" wrote: > > From: Jason Gunthorpe > > Sent: Thursday, April 6, 2023 7:23 AM > > > > On Wed, Apr 05, 2023 at 01:49:45PM -0600, Alex Williamson wrote: > > > > > > > QEMU can m

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-06 Thread Alex Williamson
On Thu, 6 Apr 2023 06:34:08 + "Liu, Yi L" wrote: > Hi Alex, > > > From: Alex Williamson > > Sent: Thursday, April 6, 2023 3:50 AM > > > > On Wed, 5 Apr 2023 16:21:09 -0300 > > Jason Gunthorpe wrote: > > > > > On

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-05 Thread Alex Williamson
On Wed, 5 Apr 2023 16:21:09 -0300 Jason Gunthorpe wrote: > On Wed, Apr 05, 2023 at 12:56:21PM -0600, Alex Williamson wrote: > > Usability needs to be a consideration as well. An interface where the > > result is effectively arbitrary from a user perspective because the >

Re: [Intel-gfx] [PATCH v3 12/12] vfio/pci: Report dev_id in VFIO_DEVICE_GET_PCI_HOT_RESET_INFO

2023-04-05 Thread Alex Williamson
On Wed, 5 Apr 2023 12:56:21 -0600 Alex Williamson wrote: > On Wed, 5 Apr 2023 14:23:43 -0300 > Jason Gunthorpe wrote: > > > On Wed, Apr 05, 2023 at 10:52:15AM -0600, Alex Williamson wrote: > > > On Wed, 5 Apr 2023 13:37:05 -0300 > > > Jason Gunthorpe wrote:

  1   2   3   4   >