[Intel-gfx] [PATCH i-g-t v2 3/6] kms_panel_fitting: Remove un-used variable.

2016-04-25 Thread robert . foss
From: Robert Foss ref_crc is never assigned or read, and can be safely removed. Signed-off-by: Robert Foss --- tests/kms_panel_fitting.c | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/kms_panel_fitting.c

[Intel-gfx] [PATCH i-g-t v2 5/6] kms_panel_fitting: Enabled test on non-Intel hardware.

2016-04-25 Thread robert . foss
From: Robert Foss Switched from DRIVER_INTEL to DRIVER_ANY to enable test on all hardware. Signed-off-by: Robert Foss --- tests/kms_panel_fitting.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[Intel-gfx] [PATCH i-g-t v2 4/6] kms_panel_fitting: Switched DRM format to a hardware agnostic alternative.

2016-04-25 Thread robert . foss
From: Robert Foss Changed the DRM format to LOCAL_DRM_FORMAT_MOD_NONE since it is hardware agnostic. Also fixed formatting/tabs. Signed-off-by: Robert Foss --- tests/kms_panel_fitting.c | 10 +- 1 file changed, 5 insertions(+), 5

[Intel-gfx] [PATCH i-g-t v2 0/6] Improve kms_panel_fitting.

2016-04-25 Thread robert . foss
From: Robert Foss Changes since v1: - Squash patches - Based patch on https://lists.freedesktop.org/archives/intel-gfx/2016-March/090617.html Robert Foss (6): kms_panel_fitting: Remove un-read variable. kms_panel_fitting: Remove un-read variable pipe_crc.

[Intel-gfx] [PATCH i-g-t v2 6/6] kms_panel_fitting: Add support for LVDS and DSI connectors.

2016-04-25 Thread robert . foss
From: Robert Foss Add support for DRM_MODE_CONNECTOR_LVDS and DRM_MODE_CONNECTOR_DSI connectors. Signed-off-by: Robert Foss --- tests/kms_panel_fitting.c | 13 ++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git

[Intel-gfx] [PATCH i-g-t v2 1/6] kms_panel_fitting: Remove un-read variable.

2016-04-25 Thread robert . foss
From: Robert Foss Remove devid from data_t since it is never read. Also remove one assignment to devid. Signed-off-by: Robert Foss --- tests/kms_panel_fitting.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tests/kms_panel_fitting.c

[Intel-gfx] [PATCH i-g-t v2 2/6] kms_panel_fitting: Remove un-read variable pipe_crc.

2016-04-25 Thread robert . foss
From: Robert Foss pipe_crc in data_t is assigned an allocated memory space and then later free'd. But it is never used for any comparisons. It should therefore be safe to remove pipe_crc and the crc requirement. Signed-off-by: Robert Foss

Re: [Intel-gfx] [PATCH v3 13/21] drm/i915: Replace the pinned context address with its unique ID

2016-04-25 Thread Dave Gordon
On 24/04/16 19:10, Chris Wilson wrote: Rather than reuse the current location of the context in the global GTT for its hardware identifier, use the context's unique ID assigned to it for its whole lifetime. Signed-off-by: Chris Wilson Reviewed-by: Tvrtko Ursulin

Re: [Intel-gfx] [PATCH 11/12] drm/i915: Extend GET_APERTURE ioctl to report available map space

2016-04-25 Thread Tvrtko Ursulin
On 25/04/16 11:35, Ankitprasad Sharma wrote: On Thu, 2016-04-21 at 15:59 +0100, Tvrtko Ursulin wrote: On 21/04/16 15:46, Chris Wilson wrote: On Thu, Apr 21, 2016 at 03:04:52PM +0100, Tvrtko Ursulin wrote: Hi, On 20/04/16 12:17, ankitprasad.r.sha...@intel.com wrote: +

[Intel-gfx] [PATCH i-g-t v3 2/4] lib/igt_kms: Fix plane counting in igt_display_init.

2016-04-25 Thread robert . foss
From: Robert Foss Fix issue where the plane counting fails due to the number and configuration of planes being unlike the intel configuration. Signed-off-by: Robert Foss --- lib/igt_kms.c | 6 -- 1 file changed, 4 insertions(+), 2

Re: [Intel-gfx] [PATCH i-g-t v2 6/6] kms_panel_fitting: Add support for LVDS and DSI connectors.

2016-04-25 Thread Ville Syrjälä
On Mon, Apr 25, 2016 at 10:35:51AM -0400, robert.f...@collabora.com wrote: > From: Robert Foss > > Add support for DRM_MODE_CONNECTOR_LVDS and DRM_MODE_CONNECTOR_DSI > connectors. > > Signed-off-by: Robert Foss > --- >

[Intel-gfx] [PATCH 3/4] CI_ONLY: pass request (not client) to i915_guc_wq_check_space()

2016-04-25 Thread Dave Gordon
The knowledge of how to derive the relevant client from the request should be localised within i915_guc_submission.c; the LRC code shouldn't have to know about the internal details of the GuC submission process. Signed-off-by: Dave Gordon ---

[Intel-gfx] [PATCH 4/4] CI_ONLY: DO NOT MERGE: WARN on GuC WQ full

2016-04-25 Thread Dave Gordon
Let's try not waiting for the GuC WQ to be not-full, but instead * count how many times this happens * print a WARNING, at least sometimes * return -EAGAIN and see whether the GuC is ever a bottleneck for submission. .Dave. Signed-off-by: Dave Gordon ---

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/4] CI_ONLY: add enable_guc_loading parameter

2016-04-25 Thread Patchwork
== Series Details == Series: series starting with [1/4] CI_ONLY: add enable_guc_loading parameter URL : https://patchwork.freedesktop.org/series/6268/ State : failure == Summary == Series 6268v1 Series without cover letter http://patchwork.freedesktop.org/api/1.0/series/6268/revisions/1/mbox/

[Intel-gfx] [PATCH] prime_mmap_kms: show case dma-buf new API and processes restrictions

2016-04-25 Thread Tiago Vignatti
dma-buf new API consists of: - mmap(dma_buf_fd): the ability to map a dma-buf file-descriptor to the user-space, and most importantly, to actually write on the mapped pointer. Worth to note that the Direct Rendering Manager (DRM) and the hardware driver implementation are fundamentally important

Re: [Intel-gfx] [PATCH 2/3] drm/i915: bail in alloc_pdp when !FULL_48BIT_PPGTT

2016-04-25 Thread Joonas Lahtinen
On pe, 2016-04-22 at 12:05 +0100, Matthew Auld wrote: > If we are not in FULL_48BIT_PPGTT mode then we really shouldn't > continue on with our allocations, given that the call to free_pdp would > bail early without freeing everything, thus leaking memory. > > v2: > (Joonas Lahtinen) >   - tidy up

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/4] drm/i915/bdw: Add missing delay during L3 SQC credit programming

2016-04-25 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915/bdw: Add missing delay during L3 SQC credit programming URL : https://patchwork.freedesktop.org/series/6252/ State : failure == Summary == Series 6252v1 Series without cover letter

[Intel-gfx] [PATCH 2/4] CI_ONLY: change default to using GuC submission if possible

2016-04-25 Thread Dave Gordon
This patch simply changes the default value of "enable_guc_submission" from 0 (never) to -1 (auto). This means that GuC submission will be used if the platform has a GuC, the GuC supports the request submission protocol, and any required GuC firmwware was successfully loaded. If any of these

[Intel-gfx] [PATCH 1/4] CI_ONLY: add enable_guc_loading parameter

2016-04-25 Thread Dave Gordon
Split the function of "enable_guc_submission" into two separate options. The new one ("enable_guc_loading") controls only the *fetching and loading* of the GuC firmware image. The existing one is redefined to control only the *use* of the GuC for batch submission once the firmware is loaded. In

Re: [Intel-gfx] [PATCH v3 13/21] drm/i915: Replace the pinned context address with its unique ID

2016-04-25 Thread Chris Wilson
On Mon, Apr 25, 2016 at 04:21:58PM +0100, Dave Gordon wrote: > On 24/04/16 19:10, Chris Wilson wrote: > >Rather than reuse the current location of the context in the global GTT > >for its hardware identifier, use the context's unique ID assigned to it > >for its whole lifetime. > > >

[Intel-gfx] [PATCH i-g-t v3 4/4] kms_vblank: Switch from using crtc0 statically to explicitly setting mode.

2016-04-25 Thread robert . foss
From: Robert Foss Previously crtc0 was statically used for VBLANK tests, but that assumption is not valid for the VC4 platform. Instead we're now explicitly setting the mode. Also add support for testing all connected connectors during the same test. Signed-off-by:

[Intel-gfx] [PATCH i-g-t v3 1/4] lib/igt_kms: Add support for up to 10 planes.

2016-04-25 Thread robert . foss
From: Robert Foss Increase the number of planes supported to 10. kmstest_plane_name only previously supported 4 planes, this patch adds support for up to 10 planes. Signed-off-by: Robert Foss --- lib/igt_kms.c | 6 ++ lib/igt_kms.h |

[Intel-gfx] [PATCH i-g-t v3 3/4] lib/igt_kms: Switch to verbose assert.

2016-04-25 Thread robert . foss
From: Robert Foss Switch igt_assert to igt_assert_lte to provide more diagnostic information. Signed-off-by: Robert Foss --- lib/igt_kms.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/igt_kms.c b/lib/igt_kms.c

[Intel-gfx] [PATCH i-g-t v3 0/4] kms_flip_event_leak and kms_vblank fixes for VC4.

2016-04-25 Thread robert . foss
From: Robert Foss Changes since v2: - Rebased onto trunk which already contains kms_flip_event_leak changes. Changes since v1: - kms_vblank: Removed un-used members of data_t struct. - Rename plane_counter to n_planes. - Removed un-needed handling CURSOR plane

Re: [Intel-gfx] [PATCH i-g-t v2 6/6] kms_panel_fitting: Add support for LVDS and DSI connectors.

2016-04-25 Thread Robert Foss
On 04/25/2016 11:10 AM, Ville Syrjälä wrote: On Mon, Apr 25, 2016 at 10:35:51AM -0400, robert.f...@collabora.com wrote: From: Robert Foss Add support for DRM_MODE_CONNECTOR_LVDS and DRM_MODE_CONNECTOR_DSI connectors. Signed-off-by: Robert Foss

Re: [Intel-gfx] [PATCH i-g-t v2 0/2] core_getversion: Only verify major version for i915.

2016-04-25 Thread Tomeu Vizoso
On 21 April 2016 at 11:20, Daniel Vetter wrote: > On Wed, Apr 20, 2016 at 12:25:50PM -0400, robert.f...@collabora.com wrote: >> From: Robert Foss >> >> This series enables tests/core_getversion to test vc4. >> It's been tested on rpi2 hardware and

Re: [Intel-gfx] [PATCH 07/12] drm/i915: Add and initialize lspcon connector

2016-04-25 Thread Zanoni, Paulo R
Em Seg, 2016-04-04 às 17:31 +0530, Shashank Sharma escreveu: > lspcon is a device which acts as DP in some cases > and as HDMI in some. Here is how: > - lspcon needs DP(aux) for all the i2c_ove_aux read/write >   transitions so it needs to have some DP level initializations > - lspcon is detected

[Intel-gfx] [PATCH i-g-t] tools: Add missing Kabylake codename strings.

2016-04-25 Thread Rodrigo Vivi
No functional change and no change in the current format. Just introducing the missing Kabylake name strings. v2: Duh! forgot the ")"... Signed-off-by: Rodrigo Vivi --- tools/intel_audio_dump.c | 3 ++- tools/intel_reg.c| 2 ++ 2 files changed, 4 insertions(+),

[Intel-gfx] [PATCH i-g-t] tools: Add missing Kabylake codename strings.

2016-04-25 Thread Rodrigo Vivi
No functional change and no change in the current format. Just introducing the missing Kabylake name strings. Signed-off-by: Rodrigo Vivi --- tools/intel_audio_dump.c | 1 + tools/intel_reg.c| 2 ++ 2 files changed, 3 insertions(+) diff --git

Re: [Intel-gfx] [PATCH v3 14/16] drm/i915/gen9: Calculate watermarks during atomic 'check'

2016-04-25 Thread Jani Nikula
On Fri, 22 Apr 2016, Matt Roper wrote: > Moving watermark calculation into the check phase will allow us to to > reject display configurations for which there are no valid watermark > values before we start trying to program the hardware (although those > tests will

Re: [Intel-gfx] [PATCH v3 21/21] drm/i915: Unify GPU resets upon shutdown

2016-04-25 Thread Ville Syrjälä
On Sun, Apr 24, 2016 at 07:10:19PM +0100, Chris Wilson wrote: > Both execlists and legacy need to reset the context (and mode) of the > GPU before we lose control of the system. By resetting the GPU, we > revert back to default settings. This simplifies the life of any > subsequent driver (in

Re: [Intel-gfx] [PATCH v2 2/2] drm/i915: Add a way to test the modeset done during gpu reset, v2.

2016-04-25 Thread Ville Syrjälä
On Mon, Apr 11, 2016 at 08:23:34AM +0200, Maarten Lankhorst wrote: > Add force_reset_modeset_test as a parameter to force the modeset path during > gpu reset. > This allows a IGT test to set the knob and trigger a hang to force the gpu > reset, > even on platforms that wouldn't otherwise require

Re: [Intel-gfx] [PATCH 16/19] drm/i915: Make unpin async.

2016-04-25 Thread Lionel Landwerlin
On 19/04/16 08:52, Maarten Lankhorst wrote: All of intel_post_plane_update is handled there now, so move it over. This is run after the hw state checker because it can't handle checking crtc's separately yet. Signed-off-by: Maarten Lankhorst ---

Re: [Intel-gfx] [PATCH 16/19] drm/i915: Make unpin async.

2016-04-25 Thread Lionel Landwerlin
On 19/04/16 08:52, Maarten Lankhorst wrote: All of intel_post_plane_update is handled there now, so move it over. This is run after the hw state checker because it can't handle checking crtc's separately yet. Signed-off-by: Maarten Lankhorst ---

Re: [Intel-gfx] [PATCH i-g-t v2 6/6] kms_panel_fitting: Add support for LVDS and DSI connectors.

2016-04-25 Thread Ville Syrjälä
On Mon, Apr 25, 2016 at 11:38:06AM -0400, Robert Foss wrote: > > > On 04/25/2016 11:10 AM, Ville Syrjälä wrote: > > On Mon, Apr 25, 2016 at 10:35:51AM -0400, robert.f...@collabora.com wrote: > >> From: Robert Foss > >> > >> Add support for DRM_MODE_CONNECTOR_LVDS and

Re: [Intel-gfx] [PATCH v3 21/21] drm/i915: Unify GPU resets upon shutdown

2016-04-25 Thread Chris Wilson
On Mon, Apr 25, 2016 at 08:25:14PM +0300, Ville Syrjälä wrote: > On Sun, Apr 24, 2016 at 07:10:19PM +0100, Chris Wilson wrote: > > Both execlists and legacy need to reset the context (and mode) of the > > GPU before we lose control of the system. By resetting the GPU, we > > revert back to default

Re: [Intel-gfx] [PATCH v2 1/2] drm/i915: Fix modeset handling during gpu reset.

2016-04-25 Thread Ville Syrjälä
On Mon, Apr 11, 2016 at 08:23:33AM +0200, Maarten Lankhorst wrote: > This function would call drm_modeset_lock_all, while the suspend/resume > functions already have their own locking. Fix this by factoring out > __intel_display_resume, and calling the atomic helpers for duplicating > atomic state

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gen9: Clean up MOCS table definitions

2016-04-25 Thread Imre Deak
On ma, 2016-04-25 at 13:30 +0100, Chris Wilson wrote: > On Mon, Apr 25, 2016 at 03:23:20PM +0300, Imre Deak wrote: > > Use named struct initializers for clarity. Also fix the target cache > > definition to reflect its role in GEN9 onwards. On GEN8 a TC value of 0 > > meant ELLC but on GEN9+ it

Re: [Intel-gfx] [PATCH v3 21/21] drm/i915: Unify GPU resets upon shutdown

2016-04-25 Thread Ville Syrjälä
On Mon, Apr 25, 2016 at 06:45:29PM +0100, Chris Wilson wrote: > On Mon, Apr 25, 2016 at 08:25:14PM +0300, Ville Syrjälä wrote: > > On Sun, Apr 24, 2016 at 07:10:19PM +0100, Chris Wilson wrote: > > > Both execlists and legacy need to reset the context (and mode) of the > > > GPU before we lose

Re: [Intel-gfx] [PATCH 03/19] drm/i915: Remove intel_prepare_page_flip, v2.

2016-04-25 Thread Patrik Jakobsson
On Tue, Apr 19, 2016 at 09:52:23AM +0200, Maarten Lankhorst wrote: > Instead of calling prepare_flip right before calling finish_page_flip > do everything from prepare_page_flip in finish_page_flip. > > Putting prepare and finish page_flip in a single step removes the need > for

[Intel-gfx] [PATCH] drm/i915/guc: Use major_minor version for filename

2016-04-25 Thread tom . orourke
From: Tom O'Rourke Load guc firmware from file with major_minor number in filename instead of using symolic link with only major number. Issue: VIZ-7713 Signed-off-by: Tom O'Rourke --- drivers/gpu/drm/i915/intel_guc_loader.c | 2 +- 1 file

Re: [Intel-gfx] [PATCH i-g-t 1/2] kms_pipe_crc_basic: Only test one pipe in the basic set

2016-04-25 Thread Zanoni, Paulo R
Em Seg, 2016-04-25 às 10:45 +0100, Tvrtko Ursulin escreveu: > On 25/04/16 09:51, Daniel Vetter wrote: > > > > On Fri, Apr 22, 2016 at 04:11:11PM +0100, Chris Wilson wrote: > > > > > > On Fri, Apr 22, 2016 at 03:41:55PM +0100, Tvrtko Ursulin wrote: > > > > > > > > From: Tvrtko Ursulin

Re: [Intel-gfx] [PATCH 2/2] drm/i915/guc: default to using GuC submission where possible

2016-04-25 Thread Dave Gordon
On 22/04/16 19:51, Chris Wilson wrote: On Fri, Apr 22, 2016 at 07:45:15PM +0100, Chris Wilson wrote: On Fri, Apr 22, 2016 at 07:22:55PM +0100, Dave Gordon wrote: This patch simply changes the default value of "enable_guc_submission" from 0 (never) to -1 (auto). This means that GuC submission

Re: [Intel-gfx] [PATCH 01/19] drm/core: Add drm_accurate_vblank_count, v5.

2016-04-25 Thread Mario Kleiner
On 04/25/2016 08:32 AM, Maarten Lankhorst wrote: This function is useful for gen2 intel devices which have no frame counter, but need a way to determine the current vblank count without racing with the vblank interrupt handler. intel_pipe_update_start checks if no vblank interrupt will occur

[Intel-gfx] [BUG] Blinking display with 4.6-rc*

2016-04-25 Thread Steinar H. Gunderson
Hi, I have a Lenovo X240, which has Haswell integrated graphics. On upgrade from 4.5.0 to 4.6-rc1, I noticed an extremely irritating issue; about every minute, the display shows black for a brief moment (perhaps one or two frames), then reverts back to the correct display. There are no other ill

Re: [Intel-gfx] [PATCH v4 1/2] shmem: Support for registration of driver/file owner specific ops

2016-04-25 Thread Kirill A. Shutemov
On Mon, Apr 04, 2016 at 02:18:10PM +0100, Chris Wilson wrote: > From: Akash Goel > > This provides support for the drivers or shmem file owners to register > a set of callbacks, which can be invoked from the address space > operations methods implemented by shmem. This

[Intel-gfx] Updated drm-intel-testing

2016-04-25 Thread Daniel Vetter
Hi all, New -testing cycle with cool stuff: - more userptr cornercase fixes from Chris - clean up and tune forcewake handling (Tvrtko) - more underrun fixes from Ville, mostly for ilk to appeas CI - fix unclaimed register warnings on vlv/chv and enable the debug code to catch them by default

Re: [Intel-gfx] [PATCH 2/4] drm/i915/fbc: sanitize i915.enable_fbc during FBC init

2016-04-25 Thread Daniel Vetter
On Wed, Apr 13, 2016 at 04:01:09PM -0300, Paulo Zanoni wrote: > The DDX driver changes its behavior depending on the value it reads > from i915.enable_fbc, so sanitize the value in order to allow it to > know what's going on. It uses this in order to choose the defaults for > the TearFree option.

[Intel-gfx] [PATCH] drm/i915/bxt: Adding bxt scaler ratio limit properties

2016-04-25 Thread Nabendu Maiti
Plane source,destination size limit, as well as scaler ratio limits are published by drm plane properties. Scaling requirement is calculated as required scaling = (src*0x1)/dst. Required ratio always should be less than scaling_max_down_ratio or nv12_scaling_max_down_ratio property values.

Re: [Intel-gfx] [PATCH i-g-t 1/2] kms_pipe_crc_basic: Only test one pipe in the basic set

2016-04-25 Thread Jani Nikula
On Fri, 22 Apr 2016, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > I would argue it is enough to test one pipe in the BAT set. FWIW BYT/CHV DSI may be fixed to port C which is fixed to pipe B, skipping the test for pipe A. BR, Jani.

Re: [Intel-gfx] [PATCH 3/4] drm/i915: use ORIGIN_CPU for frontbuffer invalidation on WC mmaps

2016-04-25 Thread Daniel Vetter
On Mon, Apr 04, 2016 at 06:17:17PM -0300, Paulo Zanoni wrote: > From: Chris Wilson > > ... instead of the previous ORIGIN_GTT. This should actually > invalidate FBC once something is written on the frontbuffer using WC > mmaps. The problem with ORIGIN_GTT is that the

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: rename i915_gem_alloc_object() to i915_gem_object_create()

2016-04-25 Thread Dave Gordon
On 24/04/16 10:23, Patchwork wrote: == Series Details == Series: drm/i915: rename i915_gem_alloc_object() to i915_gem_object_create() URL : https://patchwork.freedesktop.org/series/6183/ State : warning == Summary == Series 6183v1 drm/i915: rename i915_gem_alloc_object() to

Re: [Intel-gfx] [PATCH] mfd: intel_soc_pmic_core: Terminate panel control GPIO lookup table correctly

2016-04-25 Thread Jani Nikula
On Fri, 22 Apr 2016, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > GPIO lookup tables are supposed to be zero terminated. Let's do that > and avoid accidentally walking off the end. > > Cc: Shobhit Kumar > Cc: Samuel Ortiz

[Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [v3,01/21] drm/i915/fbdev: Call intel_unpin_fb_obj() on release

2016-04-25 Thread Patchwork
== Series Details == Series: series starting with [v3,01/21] drm/i915/fbdev: Call intel_unpin_fb_obj() on release URL : https://patchwork.freedesktop.org/series/6226/ State : warning == Summary == Series 6226v1 Series without cover letter

Re: [Intel-gfx] [PATCH 3/4] drm/i915: use ORIGIN_CPU for frontbuffer invalidation on WC mmaps

2016-04-25 Thread Chris Wilson
On Mon, Apr 25, 2016 at 10:15:11AM +0200, Daniel Vetter wrote: > On Mon, Apr 04, 2016 at 06:17:17PM -0300, Paulo Zanoni wrote: > > From: Chris Wilson > > > > ... instead of the previous ORIGIN_GTT. This should actually > > invalidate FBC once something is written on the

Re: [Intel-gfx] [BUG] Blinking display with 4.6-rc*

2016-04-25 Thread Jani Nikula
On Sat, 23 Apr 2016, "Steinar H. Gunderson" wrote: > I have a Lenovo X240, which has Haswell integrated graphics. On upgrade from > 4.5.0 to 4.6-rc1, I noticed an extremely irritating issue; about every > minute, the display shows black for a brief moment (perhaps one or

Re: [Intel-gfx] [PATCH 2/2] drm/i915/guc: default to using GuC submission where possible

2016-04-25 Thread Chris Wilson
On Mon, Apr 25, 2016 at 08:31:07AM +0100, Dave Gordon wrote: > On 22/04/16 19:51, Chris Wilson wrote: > >On Fri, Apr 22, 2016 at 07:45:15PM +0100, Chris Wilson wrote: > >>On Fri, Apr 22, 2016 at 07:22:55PM +0100, Dave Gordon wrote: > >>>This patch simply changes the default value of

Re: [Intel-gfx] [PATCH i-g-t] tests: atomic: add test to verify page flip event emissions

2016-04-25 Thread Maarten Lankhorst
Op 21-04-16 om 19:43 schreef Lionel Landwerlin: > It seems we don't have a test verifying events with atomic commits > yet. Here is a first step. > > Cc: Maarten Lankhorst > Signed-off-by: Lionel Landwerlin > --- >

Re: [Intel-gfx] [PATCH xf86-video-intel] Fix fd (and mem) leak when intel_scrn_create fails

2016-04-25 Thread Timo Aaltonen
22.04.2016, 21:04, Hans de Goede kirjoitti: > The probe functions in intel_module.c call intel_open_device() before > calling intel_scrn_create(), but if the later fails because of e.g. > an unsupported (new) pci-id they were not cleaning up the resources > claimed by intel_open_device(), esp.

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [1/2] drm/i915: Canonicalize stolen memory calculations (rev2)

2016-04-25 Thread Joonas Lahtinen
On su, 2016-04-24 at 07:53 +, Patchwork wrote: > == Series Details == > > Series: series starting with [1/2] drm/i915: Canonicalize stolen memory > calculations (rev2) > URL   : https://patchwork.freedesktop.org/series/6153/ > State : warning > > == Summary == > > Series 6153v2 Series

Re: [Intel-gfx] [PATCH i-g-t 2/2] kms_flip: Run basic tests only on one pipe

2016-04-25 Thread Daniel Vetter
On Fri, Apr 22, 2016 at 04:16:16PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > It brings enough value for the basic test set to check > one connector with one pipe only, rather every connector > with all possible pipes. > > Signed-off-by: Tvrtko Ursulin

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/bxt: Adding bxt scaler ratio limit properties

2016-04-25 Thread Patchwork
== Series Details == Series: drm/i915/bxt: Adding bxt scaler ratio limit properties URL : https://patchwork.freedesktop.org/series/6235/ State : failure == Summary == Series 6235v1 drm/i915/bxt: Adding bxt scaler ratio limit properties

Re: [Intel-gfx] [PATCH] drm/atomic: Always allow async support for the atomic ioctl.

2016-04-25 Thread Daniel Vetter
On Mon, Apr 25, 2016 at 11:37 AM, Maarten Lankhorst wrote: > Op 25-04-16 om 11:35 schreef Daniel Vetter: >> On Mon, Apr 25, 2016 at 11:21 AM, Maarten Lankhorst >> wrote: >>> async_page_flip is a unrelated flag and should not

Re: [Intel-gfx] [PATCH v3 21/21] drm/i915: Unify GPU resets upon shutdown

2016-04-25 Thread Mika Kuoppala
Chris Wilson writes: > [ text/plain ] > Both execlists and legacy need to reset the context (and mode) of the > GPU before we lose control of the system. By resetting the GPU, we > revert back to default settings. This simplifies the life of any > subsequent driver (in

Re: [Intel-gfx] [PATCH i-g-t 1/2] kms_pipe_crc_basic: Only test one pipe in the basic set

2016-04-25 Thread Tvrtko Ursulin
On 25/04/16 09:51, Daniel Vetter wrote: On Fri, Apr 22, 2016 at 04:11:11PM +0100, Chris Wilson wrote: On Fri, Apr 22, 2016 at 03:41:55PM +0100, Tvrtko Ursulin wrote: From: Tvrtko Ursulin I would argue it is enough to test one pipe in the BAT set. Signed-off-by:

[Intel-gfx] [PATCH 3/5] drm/i915: Cleanup panel IRQ handling

2016-04-25 Thread Shubhangi Shrivastava
IRQ bits are set by panel in DPCD 0x201 to perform various requests. Current code clears all bits in one go and then handles them, but this is not proper since some scenarios require full detection and if we clear such bits the test request may not be detected in the later part. It is always good

Re: [Intel-gfx] [BUG] Blinking display with 4.6-rc*

2016-04-25 Thread Steinar H. Gunderson
On Mon, Apr 25, 2016 at 11:23:30AM +0300, Jani Nikula wrote: > Please file a bug at [1]. Please add drm.debug=14 module parameter and > attach dmesg to the bug, all the way from boot to exhibiting the > problem. Done, thanks. https://bugs.freedesktop.org/show_bug.cgi?id=95124 /* Steinar */ --

Re: [Intel-gfx] [PATCH] mfd: intel_soc_pmic_core: Terminate panel control GPIO lookup table correctly

2016-04-25 Thread Thierry Reding
On Fri, Apr 22, 2016 at 10:38:55PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > GPIO lookup tables are supposed to be zero terminated. Let's do that > and avoid accidentally walking off the end. > > Cc: Shobhit Kumar

Re: [Intel-gfx] [PATCH 3/4] drm/i915: use ORIGIN_CPU for frontbuffer invalidation on WC mmaps

2016-04-25 Thread Daniel Vetter
On Mon, Apr 25, 2016 at 09:20:05AM +0100, Chris Wilson wrote: > On Mon, Apr 25, 2016 at 10:15:11AM +0200, Daniel Vetter wrote: > > On Mon, Apr 04, 2016 at 06:17:17PM -0300, Paulo Zanoni wrote: > > > From: Chris Wilson > > > > > > ... instead of the previous ORIGIN_GTT.

Re: [Intel-gfx] [PATCH i-g-t 1/2] kms_flip: Shorten basic tests a bit

2016-04-25 Thread Daniel Vetter
On Fri, Apr 22, 2016 at 04:16:15PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Seems like an overkill for a basic test to keep flipping for > a full minute. Dial it down a bit. > > Signed-off-by: Tvrtko Ursulin Ack. -Daniel >

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [1/2] drm/i915: Canonicalize stolen memory calculations (rev2)

2016-04-25 Thread Tvrtko Ursulin
On 25/04/16 09:54, Joonas Lahtinen wrote: On su, 2016-04-24 at 07:53 +, Patchwork wrote: == Series Details == Series: series starting with [1/2] drm/i915: Canonicalize stolen memory calculations (rev2) URL : https://patchwork.freedesktop.org/series/6153/ State : warning == Summary ==

Re: [Intel-gfx] [PATCH] drm/atomic: Always allow async support for the atomic ioctl.

2016-04-25 Thread Maarten Lankhorst
Op 25-04-16 om 11:35 schreef Daniel Vetter: > On Mon, Apr 25, 2016 at 11:21 AM, Maarten Lankhorst > wrote: >> async_page_flip is a unrelated flag and should not be used for >> testing support. It's up to the drivers to fail if they don't >> support async commit.

Re: [Intel-gfx] [PATCH v6 00/34] GPU scheduler for i915 driver

2016-04-25 Thread Chris Wilson
On Wed, Apr 20, 2016 at 06:13:18PM +0100, john.c.harri...@intel.com wrote: > From: John Harrison > > Implemented a batch buffer submission scheduler for the i915 DRM driver. > > The general theory of operation is that when batch buffers are > submitted to the driver,

[Intel-gfx] [PATCH 2/5] drm/i915: Read test values for lane_count and link_rate

2016-04-25 Thread Shubhangi Shrivastava
During automated test request for link training we are supposed to read the TEST_LANE_COUNT and TEST_LINK_RATE dpcd registers and use respective values in the next link training. This patch adds reading and updating of these values. Signed-off-by: Sivakumar Thulasimani

[Intel-gfx] [PATCH 5/5] drm/i915: Delay acknowledging of link training for ATR

2016-04-25 Thread Shubhangi Shrivastava
Automated test request will wait for ack or nak before proceeding. Acknowledging them ahead of time is not always good especially for link training related requests. Scenarios where we need to do full detection it is likely that the new detect might not read the automated request since we have

[Intel-gfx] [PATCH 4/5] drm/i915: Extract test reply to separate function

2016-04-25 Thread Shubhangi Shrivastava
Replying for automated test request must be done only when we are ready for the request. This patch extracts this reply to separate function as it is needed in other places in the upcoming patches. Signed-off-by: Sivakumar Thulasimani Signed-off-by: Shubhangi

[Intel-gfx] [PATCH 1/5] drm/i915: Handle automated test requests for short pulse hpd

2016-04-25 Thread Shubhangi Shrivastava
This patch adds support for automated test requests during short pulse handling in gen platforms. Signed-off-by: Sivakumar Thulasimani Signed-off-by: Shubhangi Shrivastava --- drivers/gpu/drm/i915/intel_dp.c | 12 +--- 1

Re: [Intel-gfx] [PATCH 4/4] drm/i915/fbc: enable FBC on gen 9+ too

2016-04-25 Thread Daniel Vetter
On Wed, Apr 13, 2016 at 04:01:37PM -0300, Paulo Zanoni wrote: > Now that we're more protected against user space doing frontbuffer > mmap rendering, the last - how many times did I say this before? - > SKL problem seems to be solved. So let's give it a try. > > And since the other newer platforms

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [1/4] drm/i915: Remove i915_gem_obj_size

2016-04-25 Thread Dave Gordon
On 23/04/16 16:58, Patchwork wrote: == Series Details == Series: series starting with [1/4] drm/i915: Remove i915_gem_obj_size URL : https://patchwork.freedesktop.org/series/6060/ State : warning == Summary == Series 6060v1 Series without cover letter

Re: [Intel-gfx] [PATCH i-g-t 1/2] kms_pipe_crc_basic: Only test one pipe in the basic set

2016-04-25 Thread Daniel Vetter
On Fri, Apr 22, 2016 at 04:11:11PM +0100, Chris Wilson wrote: > On Fri, Apr 22, 2016 at 03:41:55PM +0100, Tvrtko Ursulin wrote: > > From: Tvrtko Ursulin > > > > I would argue it is enough to test one pipe in the BAT set. > > > > Signed-off-by: Tvrtko Ursulin

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915:bxt: implement WaProgramL3SqcReg1DefaultForPerf (rev4)

2016-04-25 Thread Tvrtko Ursulin
On 24/04/16 07:23, Patchwork wrote: == Series Details == Series: drm/i915:bxt: implement WaProgramL3SqcReg1DefaultForPerf (rev4) URL : https://patchwork.freedesktop.org/series/5990/ State : success == Summary == Series 5990v4 drm/i915:bxt: implement WaProgramL3SqcReg1DefaultForPerf

[Intel-gfx] [PATCH] drm/atomic: Always allow async support for the atomic ioctl.

2016-04-25 Thread Maarten Lankhorst
async_page_flip is a unrelated flag and should not be used for testing support. It's up to the drivers to fail if they don't support async commit. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/drm_atomic.c | 4 1 file changed, 4 deletions(-) diff

Re: [Intel-gfx] [PATCH] drm/atomic: Always allow async support for the atomic ioctl.

2016-04-25 Thread Daniel Vetter
On Mon, Apr 25, 2016 at 11:21 AM, Maarten Lankhorst wrote: > async_page_flip is a unrelated flag and should not be used for > testing support. It's up to the drivers to fail if they don't > support async commit. > > Signed-off-by: Maarten Lankhorst

Re: [Intel-gfx] [PATCH 2/2] drm/i915/guc: default to using GuC submission where possible

2016-04-25 Thread Dave Gordon
On 22/04/16 19:45, Chris Wilson wrote: On Fri, Apr 22, 2016 at 07:22:55PM +0100, Dave Gordon wrote: This patch simply changes the default value of "enable_guc_submission" from 0 (never) to -1 (auto). This means that GuC submission will be used if the platform has a GuC, the GuC supports the

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/5] drm/i915: Handle automated test requests for short pulse hpd

2016-04-25 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915: Handle automated test requests for short pulse hpd URL : https://patchwork.freedesktop.org/series/6240/ State : success == Summary == Series 6240v1 Series without cover letter

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [1/2] drm/i915: Canonicalize stolen memory calculations (rev2)

2016-04-25 Thread Joonas Lahtinen
On ma, 2016-04-25 at 10:23 +0100, Tvrtko Ursulin wrote: > Acked-by: Tvrtko Ursulin Merged, thanks for the R-b and A-b! Regards, Joonas -- Joonas Lahtinen Open Source Technology Center Intel Corporation ___ Intel-gfx mailing

Re: [Intel-gfx] [PATCH 2/2] drm/i915/guc: default to using GuC submission where possible

2016-04-25 Thread Chris Wilson
On Mon, Apr 25, 2016 at 11:07:13AM +0100, Dave Gordon wrote: > On 22/04/16 19:45, Chris Wilson wrote: > >On Fri, Apr 22, 2016 at 07:22:55PM +0100, Dave Gordon wrote: > >>This patch simply changes the default value of "enable_guc_submission" > >>from 0 (never) to -1 (auto). This means that GuC

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [1/2] drm/i915: Canonicalize stolen memory calculations (rev2)

2016-04-25 Thread Mika Kuoppala
Joonas Lahtinen writes: > [ text/plain ] > On ma, 2016-04-25 at 10:23 +0100, Tvrtko Ursulin wrote: >> Acked-by: Tvrtko Ursulin > > Merged, thanks for the R-b and A-b! > Too late in this party, but read it through and it clears things

Re: [Intel-gfx] [PATCH] drm/i915: rename i915_gem_alloc_object() to i915_gem_object_create()

2016-04-25 Thread Tvrtko Ursulin
On 22/04/16 19:14, Dave Gordon wrote: Because having both i915_gem_object_alloc() and i915_gem_alloc_object() (with different return conventions) is just too confusing! (i915_gem_object_alloc() is the low-level memory allocator, and remains unchanged, whereas i915_gem_alloc_object() is a

Re: [Intel-gfx] [PATCH i-g-t 1/2] kms_flip: Shorten basic tests a bit

2016-04-25 Thread Marius Vlad
Thanks. Pushed. On Fri, Apr 22, 2016 at 04:16:15PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Seems like an overkill for a basic test to keep flipping for > a full minute. Dial it down a bit. > > Signed-off-by: Tvrtko Ursulin >

Re: [Intel-gfx] [PATCH] drm/i915: rename i915_gem_alloc_object() to i915_gem_object_create()

2016-04-25 Thread Joonas Lahtinen
On pe, 2016-04-22 at 19:14 +0100, Dave Gordon wrote: > Because having both i915_gem_object_alloc() and i915_gem_alloc_object() > (with different return conventions) is just too confusing! > > (i915_gem_object_alloc() is the low-level memory allocator, and remains > unchanged, whereas

Re: [Intel-gfx] [PATCH] lib: Always NUL terminate ucs2_as_utf8

2016-04-25 Thread Laszlo Ersek
On 04/22/16 20:52, Matt Fleming wrote: > On Thu, 21 Apr, at 06:21:11PM, Laszlo Ersek wrote: >> >> ... How about this instead? > > Your patch looks fine to me. I've gone ahead and stuck it in the > urgent EFI queue. I intended to probe for opinions first, and then (if appropriate) submit the

Re: [Intel-gfx] [PATCH 11/12] drm/i915: Extend GET_APERTURE ioctl to report available map space

2016-04-25 Thread Ankitprasad Sharma
On Thu, 2016-04-21 at 15:59 +0100, Tvrtko Ursulin wrote: > On 21/04/16 15:46, Chris Wilson wrote: > > On Thu, Apr 21, 2016 at 03:04:52PM +0100, Tvrtko Ursulin wrote: > >> > >> Hi, > >> > >> On 20/04/16 12:17, ankitprasad.r.sha...@intel.com wrote: > >>> + mutex_unlock(>struct_mutex); > >>> + > >>>

[Intel-gfx] ✗ Fi.CI.BAT: failure for x86/e820: Add E820_RESERVED_GFX for graphics memory

2016-04-25 Thread Patchwork
== Series Details == Series: x86/e820: Add E820_RESERVED_GFX for graphics memory URL : https://patchwork.freedesktop.org/series/6161/ State : failure == Summary == Series 6161v1 x86/e820: Add E820_RESERVED_GFX for graphics memory

Re: [Intel-gfx] [i-g-t PATCH v1 0/7] Make more tests generic

2016-04-25 Thread Tomeu Vizoso
On 20 April 2016 at 16:12, Daniel Vetter wrote: > On Wed, Apr 20, 2016 at 03:57:53PM +0200, Tomeu Vizoso wrote: >> On 20 April 2016 at 15:10, Daniel Vetter wrote: >> > On Mon, Apr 18, 2016 at 01:42:48PM +0200, Tomeu Vizoso wrote: >> >> Hi, >> >> >> >> these

Re: [Intel-gfx] [PATCH 3/4] drm/i915/chv: Tune L3 SQC credits based on actual latencies

2016-04-25 Thread Ville Syrjälä
On Mon, Apr 25, 2016 at 03:38:07PM +0300, Imre Deak wrote: > While browsing BSpec I bumped into a note saying we need to tune these > values based on actual measurements done after initial enabling. I've > checked that it indeed improves things on BXT. I haven't checked this on > CHV, but here it

Re: [Intel-gfx] [i-g-t PATCH v1 0/7] Make more tests generic

2016-04-25 Thread Tomeu Vizoso
On 25 April 2016 at 15:13, Tomeu Vizoso wrote: > On 20 April 2016 at 16:12, Daniel Vetter wrote: >> On Wed, Apr 20, 2016 at 03:57:53PM +0200, Tomeu Vizoso wrote: >>> On 20 April 2016 at 15:10, Daniel Vetter wrote: >>> > On Mon, Apr

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Propagate error from drm_gem_object_init() (rev2)

2016-04-25 Thread Patchwork
== Series Details == Series: drm/i915: Propagate error from drm_gem_object_init() (rev2) URL : https://patchwork.freedesktop.org/series/6149/ State : failure == Summary == Series 6149v2 drm/i915: Propagate error from drm_gem_object_init()

Re: [Intel-gfx] [RFC] x86/e820: Add E820_RESERVED_GFX for graphics memory

2016-04-25 Thread Joonas Lahtinen
(Correcting the bad CC's.) What do others think? This failed in the CI due to i915 driver not being able to claim RESERVED_GFX memory as it's handled like RESERVED_KERN in all places. So that'll need some tweaking, still. Regards, Joonas On pe, 2016-04-22 at 16:29 +0300, Joonas Lahtinen wrote:

Re: [Intel-gfx] [PATCH 2/5] drm/i915: Read test values for lane_count and link_rate

2016-04-25 Thread Navare, Manasi D
The automated test request for link training needs to start the link training with the requested link rate and lane count. So after reading the TEST LANE COUNT and TEST LINK RATE values, it needs to call intel_dp_start_link_train() also. How is the automated link train being tested currently?

  1   2   >