Re: [Intel-gfx] [PATCH 11/41] drm/i915: Introduce an internal allocator for disposable private objects

2016-10-17 Thread Chris Wilson
On Mon, Oct 17, 2016 at 10:47:09AM +0100, Tvrtko Ursulin wrote: > > On 14/10/2016 15:42, Chris Wilson wrote: > >On Fri, Oct 14, 2016 at 03:35:59PM +0100, Tvrtko Ursulin wrote: > >>On 14/10/2016 14:53, Chris Wilson wrote: > >We do pass NORETRY | NOWARN for the higher order allocations, so it >

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Use fence_write() from rpm resume

2016-10-17 Thread Daniel Vetter
On Thu, Oct 13, 2016 at 04:41:01PM +0100, Chris Wilson wrote: > On Thu, Oct 13, 2016 at 05:28:13PM +0200, Daniel Vetter wrote: > > On Thu, Oct 13, 2016 at 04:25:18PM +0100, Chris Wilson wrote: > > > On Thu, Oct 13, 2016 at 05:10:21PM +0200, Daniel Vetter wrote: > > > > On Wed, Oct 12, 2016 at

Re: [Intel-gfx] [PATCH 0/8] dim: move -nigthly into drm-nighly.git

2016-10-17 Thread Daniel Vetter
On Sun, Oct 16, 2016 at 08:48:02PM +0200, Daniel Vetter wrote: > Hi all, > > This is the first step to split out the drm-misc trees into their own git > repo. > This just moves the integration trees into drm-nightly.git. Those are separate > since I really like the idea of sharing one

Re: [Intel-gfx] [PATCH] drm/i915/dp: Increase cdclk when DP audio is enabled with 4 lanes and HBR2

2016-10-17 Thread Daniel Vetter
On Fri, Oct 14, 2016 at 07:27:39PM +, Pandiyan, Dhinakaran wrote: > On Thu, 2016-10-13 at 11:30 -0700, Jim Bride wrote: > > On Thu, Oct 13, 2016 at 11:04:19AM -0700, Dhinakaran Pandiyan wrote: > > > According to BSpec, cdclk has to be not less than 432 MHz with DP audio > > > enabled, port

Re: [Intel-gfx] [PULL] GVT-g device model core

2016-10-17 Thread Daniel Vetter
On Fri, Oct 14, 2016 at 06:30:30PM +0800, Zhenyu Wang wrote: > > Hi, > > This is first pull request to merge GVT-g device model in i915 > which contains core GVT-g device model work to virtualize GPU > resources. This tries to add feature of Intel GVT-g technology > for full GPU virtualization.

Re: [Intel-gfx] Uevent for retraining in case of link training failure in atomic commit phase

2016-10-17 Thread Daniel Vetter
On Sun, Oct 16, 2016 at 10:51:30PM -0700, Manasi Navare wrote: > Hi, > > I am working on adding a link rate fallback in case of link training failure. > If the link training fails at a specific link rate/lane count in atomic > commit phase, I validate the modes again based on the link rate lower

Re: [Intel-gfx] [PATCH v2 3/5] drm/i915: Remove superfluous locking around userfault_list

2016-10-17 Thread Joonas Lahtinen
On pe, 2016-10-14 at 12:05 +0100, Chris Wilson wrote: > Now that we have reduced the access to the list to either (a) under the > struct_mutex whilst holding the RPM wakeref (so that concurrent writers to > the list are serialised by struct_mutex) and (b) under the atomic > runtime suspend (which

Re: [Intel-gfx] [PATCH v2 4/4] drm: Add and handle new aspect ratios in DRM layer

2016-10-17 Thread Sharma, Shashank
> r-b with that bikeshed addressed or not? Hello Daniel, I have already acknowledged this comment, and I am publishing next set today with rebase, addressing this comment. So you can consider this one done. Regards Shashank -Original Message- From: Daniel Vetter

Re: [Intel-gfx] [PATCH 11/41] drm/i915: Introduce an internal allocator for disposable private objects

2016-10-17 Thread Tvrtko Ursulin
On 14/10/2016 15:42, Chris Wilson wrote: On Fri, Oct 14, 2016 at 03:35:59PM +0100, Tvrtko Ursulin wrote: On 14/10/2016 14:53, Chris Wilson wrote: We do pass NORETRY | NOWARN for the higher order allocations, so it shouldn't be as bad it seems? I don't know for sure without looking into the

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915: Bump object bookkeeping to u64 from size_t

2016-10-17 Thread Joonas Lahtinen
On ma, 2016-10-17 at 09:00 +0100, Chris Wilson wrote: > Internally we allow for using more objects than a single process can > allocate, i.e. we allow for a 64bit GPU address space even on a 32bit > system. Using size_t may oveerflow. > > Signed-off-by: Chris Wilson

Re: [Intel-gfx] [PATCH v2 1/3] drm/i915: Bump object bookkeeping to u64 from size_t

2016-10-17 Thread Chris Wilson
On Mon, Oct 17, 2016 at 12:48:17PM +0300, Joonas Lahtinen wrote: > On ma, 2016-10-17 at 09:00 +0100, Chris Wilson wrote: > > Internally we allow for using more objects than a single process can > > allocate, i.e. we allow for a 64bit GPU address space even on a 32bit > > system. Using size_t may

Re: [Intel-gfx] [PATCH] drm/i915: Fix cxsr_latency_table reorg

2016-10-17 Thread Joonas Lahtinen
On pe, 2016-10-14 at 14:55 +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > I have re-ordered some struct members in patch: > >   commit 44a655cae3043453f9dd8076538712d52e2e0ce4 > >   Author: Tvrtko Ursulin >   Date:   Thu Oct 13

Re: [Intel-gfx] [PULL] GVT-g device model core

2016-10-17 Thread Daniel Vetter
On Mon, Oct 17, 2016 at 09:30:45AM +0200, Daniel Vetter wrote: > On Fri, Oct 14, 2016 at 06:30:30PM +0800, Zhenyu Wang wrote: > > > > Hi, > > > > This is first pull request to merge GVT-g device model in i915 > > which contains core GVT-g device model work to virtualize GPU > > resources. This

Re: [Intel-gfx] [PULL] GVT-g device model core

2016-10-17 Thread Zhenyu Wang
On 2016.10.17 09:33:19 +0200, Daniel Vetter wrote: > On Mon, Oct 17, 2016 at 09:30:45AM +0200, Daniel Vetter wrote: > > On Fri, Oct 14, 2016 at 06:30:30PM +0800, Zhenyu Wang wrote: > > > > > > Hi, > > > > > > This is first pull request to merge GVT-g device model in i915 > > > which contains

Re: [Intel-gfx] [PATCH v2 05/10] drm/i915/gen9: Get rid of redundant watermark values

2016-10-17 Thread Maarten Lankhorst
Op 17-10-16 om 08:05 schreef Daniel Vetter: > On Thu, Oct 13, 2016 at 05:04:03PM -0300, Paulo Zanoni wrote: >> Em Qui, 2016-10-13 às 15:39 +0200, Maarten Lankhorst escreveu: >>> Op 08-10-16 om 02:11 schreef Lyude: Now that we've make skl_wm_levels make a little more sense, we can remove

Re: [Intel-gfx] [PATCH] drm/i915/dp: Increase cdclk when DP audio is enabled with 4 lanes and HBR2

2016-10-17 Thread Ville Syrjälä
On Fri, Oct 14, 2016 at 08:33:37PM +, Pandiyan, Dhinakaran wrote: > On Thu, 2016-10-13 at 21:44 +0300, Ville Syrjälä wrote: > > On Thu, Oct 13, 2016 at 11:04:19AM -0700, Dhinakaran Pandiyan wrote: > > > According to BSpec, cdclk has to be not less than 432 MHz with DP audio > > > enabled, port

Re: [Intel-gfx] [PATCH 14/41] drm/i915: Use a radixtree for random access to the object's backing storage

2016-10-17 Thread Tvrtko Ursulin
On 14/10/2016 15:07, Chris Wilson wrote: On Fri, Oct 14, 2016 at 02:32:03PM +0100, Tvrtko Ursulin wrote: On 14/10/2016 13:18, Chris Wilson wrote: A while ago we switched from a contiguous array of pages into an sglist, for that was both more convenient for mapping to hardware and avoided the

Re: [Intel-gfx] [PATCH 8/8] drm/i915/get_params: Add HuC status to getparams

2016-10-17 Thread Daniel Vetter
On Thu, Oct 13, 2016 at 02:47:32PM -0700, Jeff McGee wrote: > On Mon, Oct 03, 2016 at 11:43:02AM -0700, Anusha Srivatsa wrote: > > From: Peter Antoine > > > > This patch will allow for getparams to return the status of the HuC. > > As the HuC has to be validated by the

Re: [Intel-gfx] [PATCH 7/8] drm/i915/get_params: Add GuC status to getparams

2016-10-17 Thread Daniel Vetter
On Thu, Oct 13, 2016 at 02:42:46PM -0700, Jeff McGee wrote: > On Fri, Oct 07, 2016 at 09:11:03AM +0200, Daniel Vetter wrote: > > On Wed, Oct 05, 2016 at 01:51:14PM -0700, Rodrigo Vivi wrote: > > > > > > > > > Reviewed-by: Rodrigo Vivi > > > > This is new uabi. Where's

Re: [Intel-gfx] 4.9-r1: gpu hangs after hibernation

2016-10-17 Thread Jani Nikula
On Sun, 16 Oct 2016, zieg...@uni-freiburg.de wrote: > If I hibernate from the console, thaw, and switch between the console > and X, the gpu hangs itself. The machine becomes unresponsive except > for the power button. Please file a bug at [1], and attach the error state there. Thanks, Jani.

[Intel-gfx] [PATCH v2 1/3] drm/i915: Bump object bookkeeping to u64 from size_t

2016-10-17 Thread Chris Wilson
Internally we allow for using more objects than a single process can allocate, i.e. we allow for a 64bit GPU address space even on a 32bit system. Using size_t may oveerflow. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_debugfs.c | 2 +-

[Intel-gfx] [PATCH v2 2/3] drm/i915: Document our internal limit on object size

2016-10-17 Thread Chris Wilson
In many places, we try to count pages using a 32 bit integer. That implies if we are asked to create an object larger than 43bits, we will subtly crash much later. Catch this on the boundary, and add a warning to remind ourselves later on our exabyte systems. Signed-off-by: Chris Wilson

[Intel-gfx] [PATCH v2 3/3] drm/i915: Limit the scattergather coalescing to 32bits

2016-10-17 Thread Chris Wilson
The scattergather list uses a 32bit size counter, we should avoid exceeding it. v2: Also we should use unsigned int to match sg->length. Fixes: 871dfbd67d4e ("drm/i915: Allow compaction upto SWIOTLB max segment size") Signed-off-by: Chris Wilson Reviewed-by: Tvrtko

Re: [Intel-gfx] [PATCH] drm/i915/dp: Increase cdclk when DP audio is enabled with 4 lanes and HBR2

2016-10-17 Thread Ville Syrjälä
On Mon, Oct 17, 2016 at 08:55:51AM +0200, Daniel Vetter wrote: > On Fri, Oct 14, 2016 at 07:27:39PM +, Pandiyan, Dhinakaran wrote: > > On Thu, 2016-10-13 at 11:30 -0700, Jim Bride wrote: > > > On Thu, Oct 13, 2016 at 11:04:19AM -0700, Dhinakaran Pandiyan wrote: > > > > According to BSpec,

[Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [v2,1/3] drm/i915: Bump object bookkeeping to u64 from size_t

2016-10-17 Thread Patchwork
== Series Details == Series: series starting with [v2,1/3] drm/i915: Bump object bookkeeping to u64 from size_t URL : https://patchwork.freedesktop.org/series/13853/ State : warning == Summary == Series 13853v1 Series without cover letter

[Intel-gfx] [PATCH i-g-t] intel-ci: Reorder tests to have vgem-basic@unload tested first

2016-10-17 Thread Petri Latvala
Signed-off-by: Petri Latvala CC: Chris Wilson --- (Possible duplicate, I didn't see this arrive on the mailing list myself) To match Chris's intention. The test itself will receive fixes later, and another module loading test will be added at

[Intel-gfx] linux-next: build failure after merge of the drm-intel tree

2016-10-17 Thread Stephen Rothwell
tructure only for the enabled engines") interacting with some other commits that were merged without fixes being applied (probably) in commit 06a75ace46e2 ("Merge tag 'gvt-next-2016-10-14' of https://github.com/01org/gvt-linux into drm-intel-next-queued") I have used the versi

Re: [Intel-gfx] [PATCH] drm/i915: KBL - Recommended buffer translation programming for DisplayPort

2016-10-17 Thread Manasi Navare
On Thu, Oct 06, 2016 at 10:54:01AM -0700, Rodrigo Vivi wrote: > According to spec: "KBL re-uses SKL values, except where > specific KBL values are listed." > > And recently spec has changed adding different table for Display Port only. > But for all SKUs (H,S,U,Y) we have slightly different

Re: [Intel-gfx] [PATCH 1/2] drm/i915/gen9: fix watermarks when using the pipe scaler

2016-10-17 Thread Matt Roper
On Fri, Oct 07, 2016 at 05:28:57PM -0300, Paulo Zanoni wrote: > Luckily, the necessary adjustments for when we're using the scaler are > exactly the same as the ones needed on ILK+, so just reuse the > function we already have. > > v2: Invert the patch order so stable backports get easier. > >

[Intel-gfx] [drm-intel:for-linux-next 0/3] drivers/gpu/drm/i915/gvt/handlers.c:137: error: request for member 'mmio_base' in something not a structure or union

2016-10-17 Thread kbuild test robot
tree: git://anongit.freedesktop.org/drm-intel for-linux-next head: bfd02b3c557caa083be0d55a3164ede706a446e1 commit: 06a75ace46e2fdd1d93b06228df0e2dfe526cc27 [0/3] Merge tag 'gvt-next-2016-10-14' of https://github.com/01org/gvt-linux into drm-intel-next-queued config:

[Intel-gfx] [PATCH] drm/i915/gvt: Fix build failure after intel_engine_cs change

2016-10-17 Thread Zhenyu Wang
Change GVT-g code reference for intel_engine_cs from static array to allocated pointer after commit 3b3f1650b1ca ("drm/i915: Allocate intel_engine_cs structure only for the enabled engines"). Signed-off-by: Zhenyu Wang --- drivers/gpu/drm/i915/gvt/execlist.c | 2 +-

Re: [Intel-gfx] [PULL] GVT-g device model core

2016-10-17 Thread Zhenyu Wang
On 2016.10.17 16:07:50 +0200, Daniel Vetter wrote: > Yeah might be best to have a new branch with upstreaming stuff (now you > need to at least split out bugfixes for the already merged stuff) and > treat that like a mostly stable branch. And the still unmerged features > (vfio and all that) would

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gvt: Fix build failure after intel_engine_cs change

2016-10-17 Thread Patchwork
== Series Details == Series: drm/i915/gvt: Fix build failure after intel_engine_cs change URL : https://patchwork.freedesktop.org/series/13910/ State : failure == Summary == Series 13910v1 drm/i915/gvt: Fix build failure after intel_engine_cs change

[Intel-gfx] [i-g-t PATCH] igt/tools: Update intel_watermark with SKL support

2016-10-17 Thread Dhinakaran Pandiyan
Added support to print SKL watermark and DDB registers. Signed-off-by: Dhinakaran Pandiyan --- tools/intel_watermark.c | 104 +++- 1 file changed, 103 insertions(+), 1 deletion(-) diff --git a/tools/intel_watermark.c

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gvt: Fix build failure after intel_engine_cs change

2016-10-17 Thread Saarinen, Jani
> == Series Details == > > Series: drm/i915/gvt: Fix build failure after intel_engine_cs change > URL : https://patchwork.freedesktop.org/series/13910/ > State : failure > > == Summary == > > Series 13910v1 drm/i915/gvt: Fix build failure after intel_engine_cs change >

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gvt: Fix build failure after intel_engine_cs change

2016-10-17 Thread Zhenyu Wang
On 2016.10.18 05:39:11 +, Saarinen, Jani wrote: > > == Series Details == > > > > Series: drm/i915/gvt: Fix build failure after intel_engine_cs change > > URL : https://patchwork.freedesktop.org/series/13910/ > > State : failure > > > > == Summary == > > > > Series 13910v1 drm/i915/gvt:

[Intel-gfx] [PATCH v3 3/4] drm/i915: Clean up DDI DDC/AUX CH sanitation

2016-10-17 Thread ville . syrjala
From: Ville Syrjälä Now that we use the AUX and GMBUS assignment from VBT for all ports, let's clean up the sanitization of the port information a bit. Previosuly we only did this for port E, and only complained about a non-standard assignment for the other ports.

Re: [Intel-gfx] [PATCH 3/4] drm/i915: Clean up DDI DDC/AUX CH sanitation

2016-10-17 Thread Ville Syrjälä
On Tue, Oct 11, 2016 at 08:52:47PM +0300, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Now that we use the AUX and GMBUS assignment from VBT for all ports, > let's clean up the sanitization of the port information a bit. > Previosuly we only did

[Intel-gfx] [PATCH xf86-video-intel] sna: Reprobe if kernel updates the connector mode list

2016-10-17 Thread Manasi Navare
Output_check_status() should return a false if it detects that the connector mode list has changed so that sna_mode_discover can reprobe. Fixes: eb01cc549d4d (sna: Refresh mode list if the kernel updates) Signed-off-by: Manasi Navare Cc: Chris Wilson

Re: [Intel-gfx] [PATCH 12/15] drm: RIP mode_config->rotation_property

2016-10-17 Thread Laurent Pinchart
Hi Ville, On Friday 22 Jul 2016 16:43:13 ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Now that all drivers have been converted over to the per-plane rotation > property, we can just nuke the global rotation property. > > Signed-off-by: Ville

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for Start of skl watermark cleanup (rev3)

2016-10-17 Thread Saarinen, Jani
> == Series Details == > > Series: Start of skl watermark cleanup (rev3) > URL : https://patchwork.freedesktop.org/series/1/ > State : warning > > == Summary == > > Series 1v3 Start of skl watermark cleanup > https://patchwork.freedesktop.org/api/1.0/series/1/revisions/3/mbox/ >

Re: [Intel-gfx] [PATCH v2 4/4] drm: Add and handle new aspect ratios in DRM layer

2016-10-17 Thread Daniel Vetter
On Thu, Oct 13, 2016 at 10:28:14AM -0700, Jim Bride wrote: > On Tue, Aug 09, 2016 at 08:25:50PM +0530, Shashank Sharma wrote: > > HDMI 2.0/CEA-861-F introduces two new aspect ratios: > > - 64:27 > > - 256:135 > > > > This patch: > > - Adds new DRM flags for to represent these new aspect ratios.

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [1/1] drm/i915/guc: Sanitory checks for platform that dont have GuC

2016-10-17 Thread Saarinen, Jani
> == Series Details == > > Series: series starting with [1/1] drm/i915/guc: Sanitory checks for platform > that dont have GuC > URL : https://patchwork.freedesktop.org/series/13815/ > State : warning > > == Summary == > > Series 13815v1 Series without cover letter >

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [1/2] drm/i915/dmc: Make no_stepping_info an array

2016-10-17 Thread Saarinen, Jani
> == Series Details == > > Series: series starting with [1/2] drm/i915/dmc: Make no_stepping_info an > array > URL : https://patchwork.freedesktop.org/series/13818/ > State : warning > > == Summary == > > Series 13818v1 Series without cover letter >

Re: [Intel-gfx] [PATCH v2 05/10] drm/i915/gen9: Get rid of redundant watermark values

2016-10-17 Thread Daniel Vetter
On Thu, Oct 13, 2016 at 05:04:03PM -0300, Paulo Zanoni wrote: > Em Qui, 2016-10-13 às 15:39 +0200, Maarten Lankhorst escreveu: > > Op 08-10-16 om 02:11 schreef Lyude: > > > > > > Now that we've make skl_wm_levels make a little more sense, we can > > > remove all of the redundant wm information.

Re: [Intel-gfx] [PATCH] drm/edid: Only print the bad edid when aborting

2016-10-17 Thread Daniel Vetter
On Thu, Oct 13, 2016 at 08:43:55PM +0100, Chris Wilson wrote: > Currently, if drm.debug is enabled, we get a DRM_ERROR message on the > intermediate edid reads. This causes transient failures in CI which > flags up the sporadic EDID read failures, which are recovered by > rereading the EDID

Re: [Intel-gfx] [PATCH 26/41] drm: Add reference counting to drm_atomic_state

2016-10-17 Thread Daniel Vetter
On Fri, Oct 14, 2016 at 01:18:18PM +0100, Chris Wilson wrote: > drm_atomic_state has a complicated single owner model that tracks the > single reference from allocation through to destruction on another > thread - or perhaps on a local error path. We can simplify this tracking > by using reference

Re: [Intel-gfx] [PATCH v2 3/4] video: Add new aspect ratios for HDMI 2.0

2016-10-17 Thread Tomi Valkeinen
On 09/08/16 17:55, Shashank Sharma wrote: > HDMI 2.0/CEA-861-F introduces two new aspect ratios: > - 64:27 > - 256:135 > > This patch adds enumeration for the new aspect ratios > in the existing aspect ratio list. > > V2: rebase > > Signed-off-by: Shashank Sharma >

Re: [Intel-gfx] [RFC PATCH v2 1/8] drm/i915: setup bridge for HDMI LPE audio driver

2016-10-17 Thread Daniel Vetter
On Sat, Oct 01, 2016 at 05:52:35AM +0530, Jerome Anand wrote: > Enable support for HDMI LPE audio mode on Baytrail and > Cherrytrail when HDaudio controller is not detected > > Setup minimum required resources during i915_driver_load: > 1. Create a platform device to share MMIO/IRQ resources > 2.

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Respect alternate_ddc_pin for all DDI ports

2016-10-17 Thread Daniel Vetter
On Thu, Oct 13, 2016 at 09:29:30PM +0300, Ville Syrjälä wrote: > On Thu, Oct 13, 2016 at 11:06:55AM -0700, Jim Bride wrote: > > On Tue, Oct 11, 2016 at 08:52:46PM +0300, ville.syrj...@linux.intel.com > > wrote: > > > From: Ville Syrjälä > > > > > > The VBT

[Intel-gfx] [PATCH v3 2/4] drm: Add aspect ratio parsing in DRM layer

2016-10-17 Thread Shashank Sharma
Current DRM layer functions don't parse aspect ratio information while converting a user mode->kernel mode or vice versa. This causes modeset to pick mode with wrong aspect ratio, eventually causing failures in HDMI compliance test cases, due to wrong VIC. This patch adds aspect ratio information

[Intel-gfx] [PATCH v3 3/4] video: Add new aspect ratios for HDMI 2.0

2016-10-17 Thread Shashank Sharma
HDMI 2.0/CEA-861-F introduces two new aspect ratios: - 64:27 - 256:135 This patch adds enumeration for the new aspect ratios in the existing aspect ratio list. Signed-off-by: Shashank Sharma Reviewed-by: Sean Paul Cc: Daniel Vetter

[Intel-gfx] [PATCH v3 4/4] drm: Add and handle new aspect ratios in DRM layer

2016-10-17 Thread Shashank Sharma
HDMI 2.0/CEA-861-F introduces two new aspect ratios: - 64:27 - 256:135 This patch: - Adds new DRM flags for to represent these new aspect ratios. - Adds new cases to handle these aspect ratios while converting from user->kernel mode or vise versa. Signed-off-by: Shashank Sharma

[Intel-gfx] [PATCH v3 1/4] drm/i915: Add lspcon resume function

2016-10-17 Thread Shashank Sharma
As per the software design, we are driving lspcon in PCON mode. But while resuming from suspend, lspcon can go in LS mode (which is its default operating mode on power on) This patch adds a resume function for lspcon, which makes sure its operating in PCON mode, post resume. V2: Address review

[Intel-gfx] [PATCH v3 0/4] Picture aspect ratio support in DRM layer

2016-10-17 Thread Shashank Sharma
This patch series adds 4 patches. - The first two patches add aspect ratio support in DRM layes - Next two patches add new aspect ratios defined in CEA-861-F supported for HDMI 2.0 4k modes. Adding aspect ratio support in DRM layer: - The CEA videmodes contain aspect ratio information, which we

Re: [Intel-gfx] [PATCH v3 0/4]: Picture aspect ratio support in DRM layer

2016-10-17 Thread Sharma, Shashank
Regards Shashank On 10/17/2016 5:01 PM, Jose Abreu wrote: Hi Shashank, On 17-10-2016 12:32, Shashank Sharma wrote: This patch series adds 4 patches. - The first two patches add aspect ratio support in DRM layes - Next two patches add new aspect ratios defined in CEA-861-F supported for

Re: [Intel-gfx] [PATCH 38/41] drm/i915: Defer setting of global seqno on request to submission

2016-10-17 Thread Joonas Lahtinen
On pe, 2016-10-14 at 13:18 +0100, Chris Wilson wrote: > Defer the assignment of the global seqno on a request to its submission. > In the next patch, we will only allocate the global seqno at that time, > here we are just enabling the wait-for-submission before wait-for-seqno > paths. > >

Re: [Intel-gfx] [PATCH] RFC drm/i915: Add a sunset clause to GPU hang logging

2016-10-17 Thread Joonas Lahtinen
On pe, 2016-10-14 at 14:44 +0100, Chris Wilson wrote: > If the kernel is old, more than a few releases old, chances are that the > user is using an old kernel for a good reason, despite there being GPU > hangs. After 180days since driver release stop suggesting that they > should send those

Re: [Intel-gfx] [PATCH i-g-t] intel-ci: Reorder tests to have vgem-basic@unload tested first

2016-10-17 Thread Chris Wilson
On Mon, Oct 17, 2016 at 12:53:10PM +0300, Petri Latvala wrote: > Signed-off-by: Petri Latvala > CC: Chris Wilson > --- > > (Possible duplicate, I didn't see this arrive on the mailing list myself) > > To match Chris's intention. > > The test

[Intel-gfx] [PATCH v3 0/4]: Picture aspect ratio support in DRM layer

2016-10-17 Thread Shashank Sharma
This patch series adds 4 patches. - The first two patches add aspect ratio support in DRM layes - Next two patches add new aspect ratios defined in CEA-861-F supported for HDMI 2.0 4k modes. Adding aspect ratio support in DRM layer: - The CEA videmodes contain aspect ratio information, which we

[Intel-gfx] [PATCH v3 2/4] drm: Add aspect ratio parsing in DRM layer

2016-10-17 Thread Shashank Sharma
Current DRM layer functions don't parse aspect ratio information while converting a user mode->kernel mode or vice versa. This causes modeset to pick mode with wrong aspect ratio, eventually causing failures in HDMI compliance test cases, due to wrong VIC. This patch adds aspect ratio information

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: Suppress underrun reporting around DP link retraining

2016-10-17 Thread Ville Syrjälä
On Fri, Oct 14, 2016 at 06:51:37PM -, Patchwork wrote: > == Series Details == > > Series: drm/i915: Suppress underrun reporting around DP link retraining > URL : https://patchwork.freedesktop.org/series/13805/ > State : warning OK, but... > > == Summary == > > Series 13805v1 drm/i915:

Re: [Intel-gfx] [PATCH v6 5/5] drm/i915: Add lspcon resume function

2016-10-17 Thread Imre Deak
On pe, 2016-10-14 at 19:56 +0530, Shashank Sharma wrote: > As per the software design, we are driving lspcon in > PCON mode. But while resuming from suspend, lspcon can go > in LS mode (which is its default operating mode on power on) > > This patch adds a resume function for lspcon, which makes

Re: [Intel-gfx] [PATCH 14/41] drm/i915: Use a radixtree for random access to the object's backing storage

2016-10-17 Thread Chris Wilson
On Mon, Oct 17, 2016 at 10:56:27AM +0100, Tvrtko Ursulin wrote: > > On 14/10/2016 15:07, Chris Wilson wrote: > >On Fri, Oct 14, 2016 at 02:32:03PM +0100, Tvrtko Ursulin wrote: > >>On 14/10/2016 13:18, Chris Wilson wrote: > >>>A while ago we switched from a contiguous array of pages into an

Re: [Intel-gfx] [PATCH 17/42] drm/i915: Pass around sg_table to get_pages/put_pages backend

2016-10-17 Thread Chris Wilson
On Mon, Oct 17, 2016 at 11:52:27AM +0100, Tvrtko Ursulin wrote: > > On 14/10/2016 10:43, Chris Wilson wrote: > >On Fri, Oct 14, 2016 at 10:28:42AM +0100, Tvrtko Ursulin wrote: > >> diff --git a/drivers/gpu/drm/i915/i915_drv.h > >> b/drivers/gpu/drm/i915/i915_drv.h > >> index

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: Suppress underrun reporting around DP link retraining

2016-10-17 Thread Tomi Sarvela
On Monday, 17 October 2016 14:33:28 EEST Ville Syrjälä wrote: > On Fri, Oct 14, 2016 at 06:51:37PM -, Patchwork wrote: > > == Series Details == > > > > Series: drm/i915: Suppress underrun reporting around DP link retraining > > URL : https://patchwork.freedesktop.org/series/13805/ > > State

Re: [Intel-gfx] [PATCH 32/41] drm/i915: Rename ->emit_request to ->emit_breadcrumb

2016-10-17 Thread Joonas Lahtinen
On pe, 2016-10-14 at 13:18 +0100, Chris Wilson wrote: > Now that the emission of the request tail and its submission to hardware > are two separate steps, engine->emit_request() is confusing. > engine->emit_request() is called to emit the breadcrumb commands for the > request into the ring, name

[Intel-gfx] ✗ Fi.CI.BAT: warning for mm/vmalloc: Replace opencoded 4-level page walkers

2016-10-17 Thread Patchwork
== Series Details == Series: mm/vmalloc: Replace opencoded 4-level page walkers URL : https://patchwork.freedesktop.org/series/13822/ State : warning == Summary == Series 13822v1 mm/vmalloc: Replace opencoded 4-level page walkers

[Intel-gfx] [PATCH 10/19] drm/rcar-du: Use new atomic iterator macros.

2016-10-17 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/rcar-du/rcar_du_kms.c | 2 +- drivers/gpu/drm/rcar-du/rcar_du_plane.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c

[Intel-gfx] [PATCH 01/19] drm/atomic: Add new iterators over all state

2016-10-17 Thread Maarten Lankhorst
Add for_each_(old)(new)_(plane,connector,crtc)_in_state iterators to replace the old for_each_xxx_in_state ones. This is useful for >1 flip depth and getting rid of all xxx->state dereferences. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/drm_atomic.c

[Intel-gfx] [PATCH 04/19] drm/blend: Use new atomic iterator macros.

2016-10-17 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/drm_blend.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/drm_blend.c b/drivers/gpu/drm/drm_blend.c index 85172a977bf3..70c03eb032fc 100644 ---

[Intel-gfx] [PATCH 08/19] drm/vc4: Use new atomic iterator macros.

2016-10-17 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/vc4/vc4_kms.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_kms.c b/drivers/gpu/drm/vc4/vc4_kms.c index f31f72af8551..76cc9b374215 100644 ---

[Intel-gfx] [PATCH 07/19] drm/atomic: Fix atomic helpers to use the new iterator macros.

2016-10-17 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/drm_atomic_helper.c | 302 +++- 1 file changed, 157 insertions(+), 145 deletions(-) diff --git a/drivers/gpu/drm/drm_atomic_helper.c b/drivers/gpu/drm/drm_atomic_helper.c

[Intel-gfx] [PATCH 02/19] drm/atmel-hlcdc: Use new atomic iterator macros.

2016-10-17 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c index

[Intel-gfx] [PATCH 19/19] drm/atomic: Rename atomic oldnew iterator

2016-10-17 Thread Maarten Lankhorst
With the old users of for_each_obj_in_state gone, we can rename for_each_oldnew_obj_in_state back to that name. It's slightly less ugly. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/drm_atomic_helper.c | 34 ++---

[Intel-gfx] [PATCH 09/19] drm/rockchip: Use new atomic iterator macros.

2016-10-17 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/rockchip/rockchip_drm_vop.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop.c index

[Intel-gfx] [PATCH 15/19] drm/i915: Use new atomic iterator macros in ddi

2016-10-17 Thread Maarten Lankhorst
Also make the function static, it's only used inside intel_ddi.c Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_ddi.c | 4 ++-- drivers/gpu/drm/i915/intel_drv.h | 2 -- 2 files changed, 2 insertions(+), 4 deletions(-) diff --git

[Intel-gfx] [PATCH 18/19] drm/i915: Use new atomic iterator macros in display code

2016-10-17 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_display.c | 156 ++- 1 file changed, 80 insertions(+), 76 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c

[Intel-gfx] [PATCH 12/19] drm/msm: Use new atomic iterator macros

2016-10-17 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/msm/mdp/mdp4/mdp4_kms.c | 4 ++-- drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.c | 6 +++--- drivers/gpu/drm/msm/mdp/mdp5/mdp5_kms.h | 3 ++- drivers/gpu/drm/msm/mdp/mdp5/mdp5_plane.c | 4 ++--

[Intel-gfx] [PATCH 13/19] drm/imx: Use new atomic iterator macros

2016-10-17 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/imx/imx-drm-core.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c index 98df09c2b388..d484af773460

[Intel-gfx] [PATCH 05/19] drm/atomic: Make add_affected_connectors look at crtc_state.

2016-10-17 Thread Maarten Lankhorst
This kills another dereference of connector->state. connector_mask holds all unchanged connectors at least and any changed connectors are already in state anyway. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/drm_atomic.c | 11 --- 1 file

Re: [Intel-gfx] Uevent for retraining in case of link training failure in atomic commit phase

2016-10-17 Thread Ville Syrjälä
On Sun, Oct 16, 2016 at 10:51:30PM -0700, Manasi Navare wrote: > Hi, > > I am working on adding a link rate fallback in case of link training failure. > If the link training fails at a specific link rate/lane count in atomic > commit phase, I validate the modes again based on the link rate lower

Re: [Intel-gfx] [PATCH 17/41] drm/i915: Pass around sg_table to get_pages/put_pages backend

2016-10-17 Thread Tvrtko Ursulin
On 14/10/2016 13:18, Chris Wilson wrote: The plan is to move obj->pages out from under the struct_mutex into its own per-object lock. We need to prune any assumption of the struct_mutex from the get_pages/put_pages backends, and to make it easier we pass around the sg_table to operate on rather

Re: [Intel-gfx] [PATCH v3 0/4] Picture aspect ratio support in DRM layer

2016-10-17 Thread Sharma, Shashank
Please ignore this series, I mixed up one patch from LSPCON in here. Will send the right series in few minutes. Regards Shashank -Original Message- From: Sharma, Shashank Sent: Monday, October 17, 2016 4:52 PM To: dri-de...@lists.freedesktop.org; jim.br...@linux.intel.com Cc:

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_plane_multiple: CRC based atomic correctness test

2016-10-17 Thread Mika Kahola
On Wed, 2016-10-12 at 14:54 +0200, Maarten Lankhorst wrote: > Op 07-10-16 om 13:45 schreef Mika Kahola: > > > > This is a testcase with multiple planes. The idea here is the > > following > > > >  - draw a uniform frame with blue color > >  - grab crc for reference > >  - put planes randomly on

[Intel-gfx] [PATCH i-g-t] tests/kms_plane_multiple: CRC based atomic correctness test

2016-10-17 Thread Mika Kahola
This is a testcase with multiple planes. The idea here is the following - draw a uniform frame with blue color - grab crc for reference - put planes randomly on top with the same blue color - punch holes with black color into the primary framebuffer - ideally the planes should cover these

Re: [Intel-gfx] [PATCH 17/41] drm/i915: Pass around sg_table to get_pages/put_pages backend

2016-10-17 Thread Chris Wilson
On Mon, Oct 17, 2016 at 11:55:54AM +0100, Tvrtko Ursulin wrote: > On 14/10/2016 13:18, Chris Wilson wrote: > > static void > >-i915_gem_object_put_pages_gtt(struct drm_i915_gem_object *obj) > >+i915_gem_object_put_pages_gtt(struct drm_i915_gem_object *obj, > >+ struct

Re: [Intel-gfx] [PATCH v3 0/4]: Picture aspect ratio support in DRM layer

2016-10-17 Thread Jose Abreu
Hi Shashank, On 17-10-2016 12:32, Shashank Sharma wrote: > This patch series adds 4 patches. > - The first two patches add aspect ratio support in DRM layes > - Next two patches add new aspect ratios defined in CEA-861-F > supported for HDMI 2.0 4k modes. > > Adding aspect ratio support in DRM

Re: [Intel-gfx] [PATCH 08/41] drm/i915: Rearrange i915_wait_request() accounting with callers

2016-10-17 Thread Joonas Lahtinen
On pe, 2016-10-14 at 13:18 +0100, Chris Wilson wrote: > Our low-level wait routine has evolved from our generic wait interface > that handled unlocked, RPS boosting, waits with time tracking. If we > push our GEM fence tracking to use reservation_objects (required for > handling multiple

Re: [Intel-gfx] [PATCH v4 0/4] Picture aspect ratio support in DRM layer

2016-10-17 Thread Daniel Vetter
On Mon, Oct 17, 2016 at 05:34:36PM +0530, Shashank Sharma wrote: > This patch series adds 4 patches. > - The first two patches add aspect ratio support in DRM layes > - Next two patches add new aspect ratios defined in CEA-861-F > supported for HDMI 2.0 4k modes. > > Adding aspect ratio support

Re: [Intel-gfx] [PATCH v6 3/5] drm/i915: Parse VBT data for lspcon

2016-10-17 Thread Jani Nikula
On Fri, 14 Oct 2016, "Sharma, Shashank" wrote: > Regards > > Shashank > > > On 10/14/2016 8:02 PM, Jani Nikula wrote: >> On Fri, 14 Oct 2016, Shashank Sharma wrote: >>> Many GEN9 boards come with on-board lspcon cards. >>> Fot these boards,

[Intel-gfx] [PATCH v3 3/4] video: Add new aspect ratios for HDMI 2.0

2016-10-17 Thread Shashank Sharma
HDMI 2.0/CEA-861-F introduces two new aspect ratios: - 64:27 - 256:135 This patch adds enumeration for the new aspect ratios in the existing aspect ratio list. Signed-off-by: Shashank Sharma Reviewed-by: Sean Paul Cc: Daniel Vetter

[Intel-gfx] [PATCH v3 1/4] drm: add picture aspect ratio flags

2016-10-17 Thread Shashank Sharma
This patch adds drm flag bits for aspect ratio information Currently drm flag bits don't have field for mode's picture aspect ratio. This field will help the driver to pick mode with right aspect ratio, and help in setting right VIC field in avi infoframes. Signed-off-by: Shashank Sharma

[Intel-gfx] [PATCH v3 4/4] drm: Add and handle new aspect ratios in DRM layer

2016-10-17 Thread Shashank Sharma
HDMI 2.0/CEA-861-F introduces two new aspect ratios: - 64:27 - 256:135 This patch: - Adds new DRM flags for to represent these new aspect ratios. - Adds new cases to handle these aspect ratios while converting from user->kernel mode or vise versa. Signed-off-by: Shashank Sharma

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: Suppress underrun reporting around DP link retraining

2016-10-17 Thread Ville Syrjälä
On Mon, Oct 17, 2016 at 02:38:01PM +0300, Tomi Sarvela wrote: > On Monday, 17 October 2016 14:33:28 EEST Ville Syrjälä wrote: > > On Fri, Oct 14, 2016 at 06:51:37PM -, Patchwork wrote: > > > == Series Details == > > > > > > Series: drm/i915: Suppress underrun reporting around DP link

Re: [Intel-gfx] ✗ Fi.CI.BAT: warning for : Picture aspect ratio support in DRM layer (rev2)

2016-10-17 Thread Saarinen, Jani
> == Series Details == > > Series: : Picture aspect ratio support in DRM layer (rev2) > URL : https://patchwork.freedesktop.org/series/10587/ > State : warning > > == Summary == > > Series 10587v2 : Picture aspect ratio support in DRM layer >

Re: [Intel-gfx] [PATCH 06/41] drm/i915: Support asynchronous waits on struct fence from i915_gem_request

2016-10-17 Thread Joonas Lahtinen
On pe, 2016-10-14 at 13:17 +0100, Chris Wilson wrote: > We will need to wait on DMA completion (as signaled via struct fence) > before executing our i915_gem_request. Therefore we want to expose a > method for adding the await on the fence itself to the request. > > v2: Add a comment detailing a

Re: [Intel-gfx] [PATCH v4 2/4] drm: Add aspect ratio parsing in DRM layer

2016-10-17 Thread Ville Syrjälä
On Mon, Oct 17, 2016 at 05:34:38PM +0530, Shashank Sharma wrote: > Current DRM layer functions don't parse aspect ratio information > while converting a user mode->kernel mode or vice versa. This > causes modeset to pick mode with wrong aspect ratio, eventually > causing failures in HDMI

[Intel-gfx] [PATCH 14/19] drm/mediatek: Use new atomic iterator macros

2016-10-17 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/mediatek/mtk_drm_drv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/mediatek/mtk_drm_drv.c b/drivers/gpu/drm/mediatek/mtk_drm_drv.c index db61aa5f32ef..414e848d8cbf

[Intel-gfx] [PATCH 03/19] drm/exynos: Use new atomic iterator macros.

2016-10-17 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/exynos/exynos_drm_drv.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.c b/drivers/gpu/drm/exynos/exynos_drm_drv.c index 4a21a745c373..fc54f3f0a42c

  1   2   >