Re: [Intel-gfx] [PATCH 39/40] drm/i915/execlists: Refactor out can_merge_rq()

2018-10-01 Thread Tvrtko Ursulin
On 28/09/2018 21:11, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-09-27 12:32:54) On 19/09/2018 20:55, Chris Wilson wrote: In the next patch, we add another user that wants to check whether requests can be merge into a single HW execution, and in the future we want to add more conditions

Re: [Intel-gfx] [PATCH v4 19/25] drm/i915/dsc: Add a power domain for VDSC on eDP/MIPI DSI

2018-10-01 Thread Imre Deak
On Tue, Sep 18, 2018 at 12:04:35PM -0700, Manasi Navare wrote: > > > [...] > > > diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c > > > b/drivers/gpu/drm/i915/intel_runtime_pm.c > > > index 480dadb1047b..146e2d6cf954 100644 > > > --- a/drivers/gpu/drm/i915/intel_runtime_pm.c > > > +++

Re: [Intel-gfx] [PATCH 11/18] drm/i915: Return the mask of enabled infoframes from ->inforame_enabled()

2018-10-01 Thread Daniel Vetter
On Mon, Sep 24, 2018 at 07:36:08PM +0300, Ville Syrjälä wrote: > On Mon, Sep 24, 2018 at 05:51:16PM +0200, Daniel Vetter wrote: > > On Thu, Sep 20, 2018 at 09:51:38PM +0300, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > We want to start tracking which infoframes are enabled, so

Re: [Intel-gfx] [PATCH 39/40] drm/i915/execlists: Refactor out can_merge_rq()

2018-10-01 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-10-01 09:14:52) > > On 28/09/2018 21:11, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2018-09-27 12:32:54) > >> > >> On 19/09/2018 20:55, Chris Wilson wrote: > >>> In the next patch, we add another user that wants to check whether > >>> requests can be merge into a

Re: [Intel-gfx] [PATCH i-g-t 7/7] tests/plane_damage: Integrate kernel selftest test-drm_damage_helper

2018-10-01 Thread Petri Latvala
On Thu, Sep 27, 2018 at 05:43:50PM -0700, Deepak Rawat wrote: > Call kernel selftest module test-drm_damage_helper from igt. > > Signed-off-by: Deepak Rawat > --- > tests/Makefile.sources | 1 + > tests/drm_plane_damage.c | 10 ++ > 2 files changed, 11 insertions(+) > create mode

Re: [Intel-gfx] [PATCH 16/18] drm/i915/sdvo: Read out HDMI infoframes

2018-10-01 Thread Daniel Vetter
On Mon, Sep 24, 2018 at 08:13:08PM +0300, Ville Syrjälä wrote: > On Mon, Sep 24, 2018 at 06:10:14PM +0200, Daniel Vetter wrote: > > On Thu, Sep 20, 2018 at 09:51:43PM +0300, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > Read the HDMI infoframes from the hbuf and unpack them into > >

Re: [Intel-gfx] [PATCH 6/6] drm/i915/icl: Support co-existence between per-context SSEU and OA

2018-10-01 Thread Tvrtko Ursulin
Hi, One final unreviewed patch on this series. Hopefully uncontroversial enough for a quick review? Thanks, Tvrtko On 17/09/2018 12:30, Tvrtko Ursulin wrote: From: Tvrtko Ursulin When OA is active we want to lock the powergating configuration, but on Icelake, users like the media stack

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 2/5] igt/prime_vgem: Skip flip if no display

2018-10-01 Thread Daniel Vetter
On Fri, Sep 14, 2018 at 09:13:07PM +0100, Chris Wilson wrote: > We try flipping a vgem surface onto a i915 scanout. However, if there > is no display we want to disable the kms interface, including the addfb > ioctl. On such systems the call to kms_addfb will naturally fail and the > test cannot

Re: [Intel-gfx] [PATCH v4 19/25] drm/i915/dsc: Add a power domain for VDSC on eDP/MIPI DSI

2018-10-01 Thread Imre Deak
On Fri, Sep 21, 2018 at 04:46:47PM +0300, Ville Syrjälä wrote: > On Fri, Sep 21, 2018 at 01:34:00AM -0700, Manasi Navare wrote: > > On Wed, Sep 19, 2018 at 01:57:00PM +0300, Ville Syrjälä wrote: > > > On Tue, Sep 18, 2018 at 02:10:17PM -0700, Manasi Navare wrote: > > > > On Tue, Sep 18, 2018 at

Re: [Intel-gfx] [PATCH 6/6] drm/i915/icl: Support co-existence between per-context SSEU and OA

2018-10-01 Thread Lionel Landwerlin
On 17/09/2018 13:30, Tvrtko Ursulin wrote: From: Tvrtko Ursulin When OA is active we want to lock the powergating configuration, but on Icelake, users like the media stack will have issues if we lock to the full device configuration. Instead lock to a subset of (sub)slices which are currently

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 2/5] igt/prime_vgem: Skip flip if no display

2018-10-01 Thread Chris Wilson
Quoting Daniel Vetter (2018-10-01 09:49:07) > On Fri, Sep 14, 2018 at 09:13:07PM +0100, Chris Wilson wrote: > > We try flipping a vgem surface onto a i915 scanout. However, if there > > is no display we want to disable the kms interface, including the addfb > > ioctl. On such systems the call to

Re: [Intel-gfx] [PATCH v10 1/2] drm: Add connector property to limit max bpc

2018-10-01 Thread Daniel Vetter
On Mon, Sep 24, 2018 at 02:08:14PM -0700, Radhakrishna Sripada wrote: > At times 12bpc HDMI cannot be driven due to faulty cables, dongles > level shifters etc. To workaround them we may need to drive the output > at a lower bpc. Currently the user space does not have a way to limit > the bpc. The

Re: [Intel-gfx] [PATCH] input/psmouse: Don't hold the mutex while calling ->disconnect

2018-10-01 Thread Daniel Vetter
On Wed, May 2, 2018 at 11:06 AM Daniel Vetter wrote: > > On Mon, Apr 30, 2018 at 11:17 PM, Dmitry Torokhov > wrote: > > Hi Daniel, > > > > On Mon, Apr 30, 2018 at 09:56:49PM +0200, Daniel Vetter wrote: > >> At least trackpoint_disconnect wants to remove some sysfs files, and > >> we can't remove

Re: [Intel-gfx] [PATCH 37/40] drm/i915: Allow a context to define its set of engines

2018-10-01 Thread Tvrtko Ursulin
On 28/09/2018 21:22, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-09-27 12:28:47) On 19/09/2018 20:55, Chris Wilson wrote: Over the last few years, we have debated how to extend the user API to support an increase in the number of engines, that may be sparse and even be heterogeneous

Re: [Intel-gfx] [PATCH i-g-t 3/5] lib: Report if kms is enabled on the display

2018-10-01 Thread Daniel Vetter
On Fri, Sep 14, 2018 at 09:13:08PM +0100, Chris Wilson wrote: > Some drivers may have disabled KMS or there may simply nothing attached > to the device. In either case KMS is unusable and we may prefer to skip. > > Signed-off-by: Chris Wilson > --- > lib/igt_kms.c | 14 -- >

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 4/5] lib/kms: Skip no-op display updates

2018-10-01 Thread Daniel Vetter
On Fri, Sep 14, 2018 at 09:13:09PM +0100, Chris Wilson wrote: > If the display is disabled (e.g. the driver has disabled the KMS > interface) there is nothing to do so avoid failing. > > Signed-off-by: Chris Wilson Silently doing nothing feels funny, I think putting the igt_require into

Re: [Intel-gfx] [RFC 1/3] drm/i915/icl: Restructure ICL DPLL enable functionality

2018-10-01 Thread Kulkarni, Vandita
> -Original Message- > From: Ville Syrjälä > Sent: Wednesday, September 26, 2018 7:57 PM > To: Kulkarni, Vandita > Cc: intel-gfx@lists.freedesktop.org; Nikula, Jani ; > Zanoni, Paulo R > Subject: Re: [Intel-gfx] [RFC 1/3] drm/i915/icl: Restructure ICL DPLL enable > functionality > >

Re: [Intel-gfx] [PATCH 6/6] drm/i915/icl: Support co-existence between per-context SSEU and OA

2018-10-01 Thread Tvrtko Ursulin
On 01/10/2018 15:18, Lionel Landwerlin wrote: On 01/10/2018 13:42, Tvrtko Ursulin wrote: On 01/10/2018 12:06, Lionel Landwerlin wrote: On 01/10/2018 12:20, Tvrtko Ursulin wrote: On 01/10/2018 10:50, Lionel Landwerlin wrote: On 17/09/2018 13:30, Tvrtko Ursulin wrote: From: Tvrtko Ursulin

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915: Restore vblank interrupts earlier

2018-10-01 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Restore vblank interrupts earlier URL : https://patchwork.freedesktop.org/series/50393/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4907 -> Patchwork_10307 = == Summary - SUCCESS == No regressions

Re: [Intel-gfx] [PATCH v3 3/8] drm/i915: Add a new "remapped" gtt_view

2018-10-01 Thread Tvrtko Ursulin
On 01/10/2018 16:37, Chris Wilson wrote: Quoting Ville Syrjälä (2018-10-01 16:27:43) On Mon, Oct 01, 2018 at 04:12:09PM +0100, Chris Wilson wrote: Quoting Ville Syrjälä (2018-10-01 16:03:30) On Wed, Sep 26, 2018 at 08:50:25AM +0100, Tvrtko Ursulin wrote: On 25/09/2018 20:37, Ville Syrjala

Re: [Intel-gfx] [PATCH] drm/i915: Engine discovery query

2018-10-01 Thread Tvrtko Ursulin
Hi, Media experts please scroll down... On 01/10/2018 17:15, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Engine discovery query allows userspace to enumerate engines, probe their configuration features, all without needing to maintain the internal PCI ID based database. A new query for the

Re: [Intel-gfx] [PATCH] drm/i915: Engine discovery query

2018-10-01 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-10-01 17:15:24) > From: Tvrtko Ursulin > > Engine discovery query allows userspace to enumerate engines, probe their > configuration features, all without needing to maintain the internal PCI > ID based database. > > A new query for the generic i915 query ioctl is

Re: [Intel-gfx] [PATCH v3 3/8] drm/i915: Add a new "remapped" gtt_view

2018-10-01 Thread Chris Wilson
Quoting Ville Syrjälä (2018-10-01 16:03:30) > On Wed, Sep 26, 2018 at 08:50:25AM +0100, Tvrtko Ursulin wrote: > > > > On 25/09/2018 20:37, Ville Syrjala wrote: > > One more thing, do you really need random access for this > > transformation? Or you could walk the sg list as it is? Just if you

Re: [Intel-gfx] [PATCH v3 3/8] drm/i915: Add a new "remapped" gtt_view

2018-10-01 Thread Ville Syrjälä
On Mon, Oct 01, 2018 at 04:12:09PM +0100, Chris Wilson wrote: > Quoting Ville Syrjälä (2018-10-01 16:03:30) > > On Wed, Sep 26, 2018 at 08:50:25AM +0100, Tvrtko Ursulin wrote: > > > > > > On 25/09/2018 20:37, Ville Syrjala wrote: > > > One more thing, do you really need random access for this >

Re: [Intel-gfx] [PATCH v3 3/8] drm/i915: Add a new "remapped" gtt_view

2018-10-01 Thread Tvrtko Ursulin
On 01/10/2018 16:12, Chris Wilson wrote: Quoting Ville Syrjälä (2018-10-01 16:03:30) On Wed, Sep 26, 2018 at 08:50:25AM +0100, Tvrtko Ursulin wrote: On 25/09/2018 20:37, Ville Syrjala wrote: One more thing, do you really need random access for this transformation? Or you could walk the sg

Re: [Intel-gfx] [PATCH v3 3/8] drm/i915: Add a new "remapped" gtt_view

2018-10-01 Thread Chris Wilson
Quoting Ville Syrjälä (2018-10-01 16:27:43) > On Mon, Oct 01, 2018 at 04:12:09PM +0100, Chris Wilson wrote: > > Quoting Ville Syrjälä (2018-10-01 16:03:30) > > > On Wed, Sep 26, 2018 at 08:50:25AM +0100, Tvrtko Ursulin wrote: > > > > > > > > On 25/09/2018 20:37, Ville Syrjala wrote: > > > > One

Re: [Intel-gfx] [PATCH v3 3/8] drm/i915: Add a new "remapped" gtt_view

2018-10-01 Thread Tvrtko Ursulin
On 01/10/2018 16:27, Ville Syrjälä wrote: On Mon, Oct 01, 2018 at 04:12:09PM +0100, Chris Wilson wrote: Quoting Ville Syrjälä (2018-10-01 16:03:30) On Wed, Sep 26, 2018 at 08:50:25AM +0100, Tvrtko Ursulin wrote: On 25/09/2018 20:37, Ville Syrjala wrote: One more thing, do you really need

Re: [Intel-gfx] [PATCH] drm/i915: Engine discovery query

2018-10-01 Thread Tvrtko Ursulin
Hi, Media experts please scroll down... On 01/10/2018 17:15, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Engine discovery query allows userspace to enumerate engines, probe their configuration features, all without needing to maintain the internal PCI ID based database. A new query for the

Re: [Intel-gfx] [PATCH v2 3/4] drm/i915/dp: Validate the downclock mode for eDP if it exists

2018-10-01 Thread Ville Syrjälä
On Wed, Sep 12, 2018 at 03:57:18PM -0700, Manasi Navare wrote: > With downclock mode and DRRS now operating independently user can > request a modeset on downclock mode. In that case intel_dp_mode_valid() > should validate the downclock mode as well if that is requested. > > Cc: Jani Nikula >

Re: [Intel-gfx] [PATCH v2 1/4] drm/i915/dp: Link train Fallback on eDP only if fallback link BW can fit panel's native mode

2018-10-01 Thread Ville Syrjälä
On Wed, Sep 12, 2018 at 03:57:16PM -0700, Manasi Navare wrote: > This patch fixes the original commit c0cfb10d9e1de49 ("drm/i915/edp: > Do not do link training fallback or prune modes on EDP") that causes > a blank screen in case of certain eDP panels (Eg: seen on Dell XPS13 9350) > where first

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/3] drm/i915: Priority boost for new clients

2018-10-01 Thread Patchwork
== Series Details == Series: series starting with [CI,1/3] drm/i915: Priority boost for new clients URL : https://patchwork.freedesktop.org/series/50395/ State : warning == Summary == $ dim checkpatch origin/drm-tip 2b9a64542c15 drm/i915: Priority boost for new clients 3ef9b826a9a3 drm/i915:

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [CI,1/3] drm/i915: Priority boost for new clients

2018-10-01 Thread Patchwork
== Series Details == Series: series starting with [CI,1/3] drm/i915: Priority boost for new clients URL : https://patchwork.freedesktop.org/series/50395/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm/i915: Priority boost for new clients Okay! Commit: drm/i915: Pull

[Intel-gfx] [PATCH] drm/i915: Engine discovery query

2018-10-01 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Engine discovery query allows userspace to enumerate engines, probe their configuration features, all without needing to maintain the internal PCI ID based database. A new query for the generic i915 query ioctl is added named DRM_I915_QUERY_ENGINE_INFO, together with

[Intel-gfx] ✗ Fi.CI.BAT: failure for Per context dynamic (sub)slice power-gating (rev6)

2018-10-01 Thread Patchwork
== Series Details == Series: Per context dynamic (sub)slice power-gating (rev6) URL : https://patchwork.freedesktop.org/series/48194/ State : failure == Summary == Applying: drm/i915/execlists: Move RPCS setup to context pin Applying: drm/i915: Record the sseu configuration per-context &

Re: [Intel-gfx] [PATCH v3 3/8] drm/i915: Add a new "remapped" gtt_view

2018-10-01 Thread Ville Syrjälä
On Wed, Sep 26, 2018 at 08:50:25AM +0100, Tvrtko Ursulin wrote: > > On 25/09/2018 20:37, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > To overcome display engine stride limits we'll want to remap the > > pages in the GTT. To that end we need a new gtt_view type which > > is just like the

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915: Restore vblank interrupts earlier

2018-10-01 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Restore vblank interrupts earlier URL : https://patchwork.freedesktop.org/series/50393/ State : warning == Summary == $ dim checkpatch origin/drm-tip 3d421aa28f28 drm/i915: Restore vblank interrupts earlier ab4d85399a55

[Intel-gfx] [PATCH v3] drm/i915/icl: Support co-existence between per-context SSEU and OA

2018-10-01 Thread Tvrtko Ursulin
From: Tvrtko Ursulin When OA is active we want to lock the powergating configuration, but on Icelake, users like the media stack will have issues if we lock to the full device configuration. Instead lock to a subset of (sub)slices which are currently a known working configuration for all users.

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/3] drm/i915: Priority boost for new clients

2018-10-01 Thread Patchwork
== Series Details == Series: series starting with [CI,1/3] drm/i915: Priority boost for new clients URL : https://patchwork.freedesktop.org/series/50395/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4908 -> Patchwork_10308 = == Summary - SUCCESS == No regressions

[Intel-gfx] [PATCH v3 6/6] drm/i915/psr: Remove alpm from i915_psr

2018-10-01 Thread José Roberto de Souza
ALPM is a requirement and we don't need to keep it's cached, what were done in commit 97c9de66ca80 ("drm/i915/psr: Fix ALPM cap check for PSR2") but the alpm was not removed from i915_psr. Reviewed-by: Dhinakaran Pandiyan Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/i915_drv.h

[Intel-gfx] [PATCH v3 4/6] drm/i915/psr: Use WA to force HW tracking to exit PSR2

2018-10-01 Thread José Roberto de Souza
This WA also works fine for PSR2, triggering a selective update when possible. Acked-by: Dhinakaran Pandiyan Reviewed-by: Rodrigo Vivi Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/intel_psr.c | 24 ++-- 1 file changed, 10 insertions(+), 14 deletions(-)

[Intel-gfx] [PATCH v3 3/6] drm/i915/psr: Remove PSR2 TODO error handling

2018-10-01 Thread José Roberto de Souza
We are already handling all PSR2 errors, so we can drop this TODO. Reviewed-by: Dhinakaran Pandiyan Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/intel_psr.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_psr.c b/drivers/gpu/drm/i915/intel_psr.c

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v3,1/6] drm/i915/psr: Share PSR and PSR2 exit mask

2018-10-01 Thread Patchwork
== Series Details == Series: series starting with [v3,1/6] drm/i915/psr: Share PSR and PSR2 exit mask URL : https://patchwork.freedesktop.org/series/50417/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4911 -> Patchwork_10316 = == Summary - SUCCESS == No regressions

Re: [Intel-gfx] [PATCH v2 2/6] drm/i915/dp: Restrict link retrain workaround to external monitors

2018-10-01 Thread Dhinakaran Pandiyan
On Mon, 2018-10-01 at 12:49 -0700, Rodrigo Vivi wrote: > On Mon, Sep 24, 2018 at 03:45:24PM -0700, Dhinakaran Pandiyan wrote: > > Commit '3cf71bc9904d ("drm/i915: Re-apply "Perform link quality > > check, > > unconditionally during long pulse"")' applies a work around for > > sinks > > Fixes: ? >

Re: [Intel-gfx] [PATCH v2] drm/i915/psr: Enable PSR1 on gen-9+ HW

2018-10-01 Thread Rodrigo Vivi
On Thu, Sep 27, 2018 at 11:11:17PM -0700, Dhinakaran Pandiyan wrote: > We have new tests and fixes in place since the feature was last > disabled. Try again for gen-9+ hardware and enable only PSR1 by default as > a first step. > v2: Remove typo fix and comment improvements (Rodrigo) > > Cc: Jani

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/guc: init GuC descriptors after GuC load

2018-10-01 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/guc: init GuC descriptors after GuC load URL : https://patchwork.freedesktop.org/series/50410/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4911 -> Patchwork_10314 = == Summary - SUCCESS == No

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: extract common ce->pin_count check

2018-10-01 Thread Patchwork
== Series Details == Series: drm/i915: extract common ce->pin_count check URL : https://patchwork.freedesktop.org/series/50414/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4911 -> Patchwork_10315 = == Summary - SUCCESS == No regressions found. External URL:

[Intel-gfx] [PATCH v3 1/6] drm/i915/psr: Share PSR and PSR2 exit mask

2018-10-01 Thread José Roberto de Souza
Now both PSR and PSR2 have the same exit mask, so let's share then instead of have the same code 2 times. Reviewed-by: Dhinakaran Pandiyan Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/intel_psr.c | 34 1 file changed, 13 insertions(+), 21

[Intel-gfx] [PATCH v3 2/6] drm/i915/psr: Make MASK_DISP_REG_WRITE reserved in PSR_MASK for ICL

2018-10-01 Thread José Roberto de Souza
ICL spec states that this bit is now reserved. Bspec: 7722 v2(Dhinakaran and Jani): - instead of remove bit in gen11 now only setting if if gen < 11 - changed commit title Cc: Jani Nikula Reviewed-by: Dhinakaran Pandiyan Signed-off-by: José Roberto de Souza ---

[Intel-gfx] [PATCH v3 5/6] drm/i915/psr: Don't tell sink that main link will be active while is active PSR2

2018-10-01 Thread José Roberto de Souza
For PSR2 there is no register to tell HW to keep main link enabled while PSR2 is active, so don't configure sink DPCD with a wrong value. v3: Also update the value printed in debugfs Cc: Dhinakaran Pandiyan Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/i915_debugfs.c | 3 ++-

Re: [Intel-gfx] [PATCH v3 4/6] drm/i915/dp: Do not grab crtc modeset lock in intel_dp_detect()

2018-10-01 Thread Rodrigo Vivi
On Mon, Oct 01, 2018 at 03:01:18PM -0700, Dhinakaran Pandiyan wrote: > On Mon, 2018-10-01 at 23:10 +0300, Ville Syrjälä wrote: > > On Mon, Oct 01, 2018 at 12:48:28PM -0700, Rodrigo Vivi wrote: > > > On Tue, Sep 25, 2018 at 07:54:22PM -0700, Dhinakaran Pandiyan > > > wrote: > > > > A crtc modeset

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [v3,1/6] drm/i915/psr: Share PSR and PSR2 exit mask

2018-10-01 Thread Patchwork
== Series Details == Series: series starting with [v3,1/6] drm/i915/psr: Share PSR and PSR2 exit mask URL : https://patchwork.freedesktop.org/series/50417/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm/i915/psr: Share PSR and PSR2 exit mask Okay! Commit: drm/i915/psr:

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v3,1/6] drm/i915/psr: Share PSR and PSR2 exit mask

2018-10-01 Thread Patchwork
== Series Details == Series: series starting with [v3,1/6] drm/i915/psr: Share PSR and PSR2 exit mask URL : https://patchwork.freedesktop.org/series/50417/ State : warning == Summary == $ dim checkpatch origin/drm-tip f82ea23a1cf4 drm/i915/psr: Share PSR and PSR2 exit mask 86c86b719ae1

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/4] drm/i915: Replace some open-coded i915_map_coherent_type()

2018-10-01 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Replace some open-coded i915_map_coherent_type() URL : https://patchwork.freedesktop.org/series/50408/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4911 -> Patchwork_10313 = == Summary - FAILURE ==

Re: [Intel-gfx] [PATCH v3 4/6] drm/i915/dp: Do not grab crtc modeset lock in intel_dp_detect()

2018-10-01 Thread Dhinakaran Pandiyan
On Mon, 2018-10-01 at 23:10 +0300, Ville Syrjälä wrote: > On Mon, Oct 01, 2018 at 12:48:28PM -0700, Rodrigo Vivi wrote: > > On Tue, Sep 25, 2018 at 07:54:22PM -0700, Dhinakaran Pandiyan > > wrote: > > > A crtc modeset lock was added for link retraining but > > > intel_dp_retrain_link() knows to

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/psr: Enable PSR1 on gen-9+ HW (rev2)

2018-10-01 Thread Patchwork
== Series Details == Series: drm/i915/psr: Enable PSR1 on gen-9+ HW (rev2) URL : https://patchwork.freedesktop.org/series/49312/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4909_full -> Patchwork_10312_full = == Summary - SUCCESS == No regressions found. == Known

Re: [Intel-gfx] [PATCH v2 1/6] drm/i915/dp: Fix link retraining comment in intel_dp_long_pulse()

2018-10-01 Thread Lyude Paul
Reviewed-by: Lyude Paul On Mon, 2018-09-24 at 15:45 -0700, Dhinakaran Pandiyan wrote: > Comment claims link needs to be retrained because the connected sink raised > a long pulse to indicate link loss. If the sink did so, > intel_dp_hotplug() would have handled link retraining. Looking at the >

Re: [Intel-gfx] [PATCH v2 2/6] drm/i915/dp: Restrict link retrain workaround to external monitors

2018-10-01 Thread Lyude Paul
Reviewed-by: Lyude Paul On Mon, 2018-09-24 at 15:45 -0700, Dhinakaran Pandiyan wrote: > Commit '3cf71bc9904d ("drm/i915: Re-apply "Perform link quality check, > unconditionally during long pulse"")' applies a work around for sinks > that don't signal link loss. The work around does not need to

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/guc: init GuC descriptors after GuC load

2018-10-01 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/guc: init GuC descriptors after GuC load URL : https://patchwork.freedesktop.org/series/50410/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4911_full -> Patchwork_10314_full = == Summary - WARNING ==

Re: [Intel-gfx] [PATCH 38/40] drm/i915/execlists: Flush the CS events before unpinning

2018-10-01 Thread Tvrtko Ursulin
On 19/09/2018 20:55, Chris Wilson wrote: Inside the execlists submission tasklet, we often make the mistake of assuming that everything beneath the request is available for use. However, the submission and the request live on two separate timelines, and the request contents may be freed from an

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915/selftests: Split preemption smoke test into threads (rev2)

2018-10-01 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915/selftests: Split preemption smoke test into threads (rev2) URL : https://patchwork.freedesktop.org/series/50329/ State : warning == Summary == $ dim checkpatch origin/drm-tip 949446d4ae2f drm/i915/selftests: Split preemption

Re: [Intel-gfx] [RFC 3/3] drm/i915/icl: Calculate DPLL params for DSI

2018-10-01 Thread Kulkarni, Vandita
> -Original Message- > From: Ville Syrjälä > Sent: Wednesday, September 26, 2018 7:52 PM > To: Kulkarni, Vandita > Cc: intel-gfx@lists.freedesktop.org; Nikula, Jani ; > Zanoni, Paulo R > Subject: Re: [Intel-gfx] [RFC 3/3] drm/i915/icl: Calculate DPLL params for DSI > > On Thu, Sep

Re: [Intel-gfx] [PATCH 6/6] drm/i915/icl: Support co-existence between per-context SSEU and OA

2018-10-01 Thread Tvrtko Ursulin
On 01/10/2018 12:06, Lionel Landwerlin wrote: On 01/10/2018 12:20, Tvrtko Ursulin wrote: On 01/10/2018 10:50, Lionel Landwerlin wrote: On 17/09/2018 13:30, Tvrtko Ursulin wrote: From: Tvrtko Ursulin When OA is active we want to lock the powergating configuration, but on Icelake, users

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/7] drm/i915/icl: Add WaEnable32PlaneMode

2018-10-01 Thread Patchwork
== Series Details == Series: series starting with [1/7] drm/i915/icl: Add WaEnable32PlaneMode URL : https://patchwork.freedesktop.org/series/50340/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4906 -> Patchwork_10303 = == Summary - SUCCESS == No regressions found.

Re: [Intel-gfx] [RFC 3/3] drm/i915/icl: Calculate DPLL params for DSI

2018-10-01 Thread Chauhan, Madhav
> -Original Message- > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of > Kulkarni, Vandita > Sent: Monday, October 1, 2018 5:00 PM > To: Ville Syrjälä > Cc: Nikula, Jani ; intel-gfx@lists.freedesktop.org; > Zanoni, Paulo R > Subject: Re: [Intel-gfx] [RFC

Re: [Intel-gfx] [PATCH 6/6] drm/i915/icl: Support co-existence between per-context SSEU and OA

2018-10-01 Thread Tvrtko Ursulin
On 01/10/2018 10:50, Lionel Landwerlin wrote: On 17/09/2018 13:30, Tvrtko Ursulin wrote: From: Tvrtko Ursulin When OA is active we want to lock the powergating configuration, but on Icelake, users like the media stack will have issues if we lock to the full device configuration. Instead

Re: [Intel-gfx] [PATCH 4/7] drm/i915/icl: WaSendPushConstantsFromMMIO

2018-10-01 Thread Joonas Lahtinen
Why is this mixed with display workarounds? These were already once on the list and were decided not to be included as there are no known users. Regards, Joonas Quoting Radhakrishna Sripada (2018-09-28 19:47:35) > From: Oscar Mateo > > Allows UMDs to set 'Disable Gather at Set Shader Common

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/5] drm/dp/mst: Configure no_stop_bit correctly for remote i2c xfers

2018-10-01 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/dp/mst: Configure no_stop_bit correctly for remote i2c xfers URL : https://patchwork.freedesktop.org/series/50341/ State : warning == Summary == $ dim checkpatch origin/drm-tip 3c513d17e3fc drm/dp/mst: Configure no_stop_bit

[Intel-gfx] ✗ Fi.CI.BAT: failure for Add Wa_1606682166 (rev2)

2018-10-01 Thread Patchwork
== Series Details == Series: Add Wa_1606682166 (rev2) URL : https://patchwork.freedesktop.org/series/50349/ State : failure == Summary == Applying: drm/i915/icl:Add Wa_1606682166 error: sha1 information is lacking or useless (drivers/gpu/drm/i915/i915_reg.h). error: could not build fake

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/5] drm/dp/mst: Configure no_stop_bit correctly for remote i2c xfers

2018-10-01 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/dp/mst: Configure no_stop_bit correctly for remote i2c xfers URL : https://patchwork.freedesktop.org/series/50341/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4906 -> Patchwork_10304 = == Summary - SUCCESS ==

[Intel-gfx] [PATCH 1/4] drm/i915/selftests: Split preemption smoke test into threads

2018-10-01 Thread Chris Wilson
When submitting chains to each engine, we can do so (mostly) in parallel, so delegate submission to threads on a per-engine basis. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/selftests/intel_lrc.c | 73 ++ 1 file changed, 61 insertions(+), 12 deletions(-) diff

[Intel-gfx] [PATCH 3/4] drm/i915: Reserve some priority bits for internal use

2018-10-01 Thread Chris Wilson
In the next few patches, we will want to give a small priority boost to some requests/queues but not so much that we perturb the user controlled order. As such we will shift the user priority bits higher leaving ourselves a few low priority bits for our internal bumping. Signed-off-by: Chris

[Intel-gfx] [PATCH 4/4] drm/i915: Combine multiple internal plists into the same i915_priolist bucket

2018-10-01 Thread Chris Wilson
As we are about to allow ourselves to slightly bump the user priority into a few different sublevels, packthose internal priority lists into the same i915_priolist to keep the rbtree compact and avoid having to allocate the default user priority even after the internal bumping. The downside to

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Fix ILK-IVB sprite enable delays

2018-10-01 Thread Patchwork
== Series Details == Series: drm/i915: Fix ILK-IVB sprite enable delays URL : https://patchwork.freedesktop.org/series/50328/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4906_full -> Patchwork_10301_full = == Summary - FAILURE == Serious unknown changes coming with

Re: [Intel-gfx] [PATCH 7/7] drm/i915/icl: Add Wa_1406609255

2018-10-01 Thread Mika Kuoppala
Radhakrishna Sripada writes: > Shader feature to prefetch binding tables does not support 16:6 18:8 BTP > formats. Enabling fault handling could result in hangs with faults. > Disabling demand prefetch would disable binding table prefetch. > > Signed-off-by: Radhakrishna Sripada > --- >

Re: [Intel-gfx] [PATCH 1/4] drm/i915/selftests: Split preemption smoke test into threads

2018-10-01 Thread Tvrtko Ursulin
On 28/09/2018 14:58, Chris Wilson wrote: When submitting chains to each engine, we can do so (mostly) in parallel, so delegate submission to threads on a per-engine basis. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/selftests/intel_lrc.c | 73 ++ 1 file

Re: [Intel-gfx] [PATCH 40/40] drm/i915: Load balancing across a virtual engine

2018-10-01 Thread Tvrtko Ursulin
On 19/09/2018 20:55, Chris Wilson wrote: Having allowed the user to define a set of engines that they will want to only use, we go one step further and allow them to bind those engines into a single virtual instance. Submitting a batch to the virtual engine will then forward it to any one of

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/4] drm/i915/selftests: Split preemption smoke test into threads (rev2)

2018-10-01 Thread Chris Wilson
Quoting Patchwork (2018-10-01 12:25:25) > == Series Details == > > Series: series starting with [1/4] drm/i915/selftests: Split preemption smoke > test into threads (rev2) > URL : https://patchwork.freedesktop.org/series/50329/ > State : failure > > == Summary == > > = CI Bug Log - changes

[Intel-gfx] [PATCH 2/4] drm/i915/selftests: Include arbitration points in preemption smoketest

2018-10-01 Thread Chris Wilson
Include a batch full of a page of arbitration points in order to provide a window for inject_preempt_context() in the preemption smoketests. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/selftests/intel_lrc.c | 134 - 1 file changed, 101 insertions(+), 33 deletions(-)

Re: [Intel-gfx] [PATCH 39/40] drm/i915/execlists: Refactor out can_merge_rq()

2018-10-01 Thread Tvrtko Ursulin
On 01/10/2018 09:18, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-10-01 09:14:52) On 28/09/2018 21:11, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-09-27 12:32:54) On 19/09/2018 20:55, Chris Wilson wrote: In the next patch, we add another user that wants to check whether requests

Re: [Intel-gfx] [PATCH 4/7] drm/i915/icl: WaSendPushConstantsFromMMIO

2018-10-01 Thread Mika Kuoppala
Chris Wilson writes: > Quoting Radhakrishna Sripada (2018-09-28 17:47:35) >> From: Oscar Mateo >> >> Allows UMDs to set 'Disable Gather at Set Shader Common Slice'. > > Question for reviewers is what other bits are exposed here? And we would also need to have a mesa/umd side commit/ack to

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix ILK-IVB sprite enable delays

2018-10-01 Thread Patchwork
== Series Details == Series: drm/i915: Fix ILK-IVB sprite enable delays URL : https://patchwork.freedesktop.org/series/50328/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4906 -> Patchwork_10301 = == Summary - SUCCESS == No regressions found. External URL:

Re: [Intel-gfx] [PATCH 1/4] drm/i915/selftests: Split preemption smoke test into threads

2018-10-01 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-10-01 11:38:37) > > On 28/09/2018 14:58, Chris Wilson wrote: > > When submitting chains to each engine, we can do so (mostly) in > > parallel, so delegate submission to threads on a per-engine basis. > > > > Signed-off-by: Chris Wilson > > --- > >

Re: [Intel-gfx] [PATCH 7/7] drm/i915/icl: Add Wa_1406609255

2018-10-01 Thread Mika Kuoppala
Radhakrishna Sripada writes: > Shader feature to prefetch binding tables does not support 16:6 18:8 BTP > formats. s/formats./,causing lower performance if used. And with fault handling enabled can cause gpu hangs. > Disabling demand prefetch would disable binding table prefetch. > Also

Re: [Intel-gfx] [PATCH 6/6] drm/i915/icl: Support co-existence between per-context SSEU and OA

2018-10-01 Thread Lionel Landwerlin
On 01/10/2018 12:20, Tvrtko Ursulin wrote: On 01/10/2018 10:50, Lionel Landwerlin wrote: On 17/09/2018 13:30, Tvrtko Ursulin wrote: From: Tvrtko Ursulin When OA is active we want to lock the powergating configuration, but on Icelake, users like the media stack will have issues if we lock to

Re: [Intel-gfx] [PATCH 38/40] drm/i915/execlists: Flush the CS events before unpinning

2018-10-01 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-10-01 11:51:23) > > On 19/09/2018 20:55, Chris Wilson wrote: > > Inside the execlists submission tasklet, we often make the mistake of > > assuming that everything beneath the request is available for use. > > However, the submission and the request live on two

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/4] drm/i915/selftests: Split preemption smoke test into threads (rev2)

2018-10-01 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915/selftests: Split preemption smoke test into threads (rev2) URL : https://patchwork.freedesktop.org/series/50329/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4906 -> Patchwork_10302 = == Summary - FAILURE

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/4] drm/i915/selftests: Split preemption smoke test into threads

2018-10-01 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915/selftests: Split preemption smoke test into threads URL : https://patchwork.freedesktop.org/series/50389/ State : warning == Summary == $ dim checkpatch origin/drm-tip 7cbb475e40b4 drm/i915/selftests: Split preemption smoke

[Intel-gfx] [PATCH] drm/i915: fix wrong error number report

2018-10-01 Thread Andi Shyti
During driver load it's considered that the i915_driver_create() function fails only in case of insufficient memory. Indeed, in case of failure of i915_driver_create(), the load function returns indiscriminately -ENOMEM ignoring the real cause of failure. In i915_driver_create() get the

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Engine discovery query (rev3)

2018-10-01 Thread Patchwork
== Series Details == Series: drm/i915: Engine discovery query (rev3) URL : https://patchwork.freedesktop.org/series/39958/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4908 -> Patchwork_10310 = == Summary - SUCCESS == No regressions found. External URL:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: fix wrong error number report

2018-10-01 Thread Patchwork
== Series Details == Series: drm/i915: fix wrong error number report URL : https://patchwork.freedesktop.org/series/50406/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4908 -> Patchwork_10311 = == Summary - SUCCESS == No regressions found. External URL:

Re: [Intel-gfx] [PATCH] drm/i915: Engine discovery query

2018-10-01 Thread Tvrtko Ursulin
On 01/10/2018 17:24, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-10-01 17:15:24) From: Tvrtko Ursulin Engine discovery query allows userspace to enumerate engines, probe their configuration features, all without needing to maintain the internal PCI ID based database. A new query for

Re: [Intel-gfx] linux-firmware pull request(ICL:DMC)

2018-10-01 Thread Srivatsa, Anusha
>-Original Message- >From: Josh Boyer [mailto:jwbo...@kernel.org] >Sent: Monday, October 1, 2018 6:55 AM >To: Srivatsa, Anusha >Cc: Intel Graphics Development ; Kyle McMartin >; Ben Hutchings >Subject: Re: linux-firmware pull request(ICL:DMC) > >On Wed, Sep 26, 2018 at 3:11 PM

Re: [Intel-gfx] [PATCH 16/18] drm/i915/sdvo: Read out HDMI infoframes

2018-10-01 Thread Daniel Vetter
On Mon, Oct 01, 2018 at 04:35:50PM +0300, Ville Syrjälä wrote: > On Mon, Oct 01, 2018 at 08:59:41AM +0200, Daniel Vetter wrote: > > On Mon, Sep 24, 2018 at 08:13:08PM +0300, Ville Syrjälä wrote: > > > On Mon, Sep 24, 2018 at 06:10:14PM +0200, Daniel Vetter wrote: > > > > On Thu, Sep 20, 2018 at

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Engine discovery query (rev3)

2018-10-01 Thread Patchwork
== Series Details == Series: drm/i915: Engine discovery query (rev3) URL : https://patchwork.freedesktop.org/series/39958/ State : warning == Summary == $ dim checkpatch origin/drm-tip 9c2c6952bb56 drm/i915: Engine discovery query -:179: WARNING:TYPO_SPELLING: 'an user' may be misspelled -

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/3] drm/i915: Restore vblank interrupts earlier

2018-10-01 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Restore vblank interrupts earlier URL : https://patchwork.freedesktop.org/series/50393/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4907_full -> Patchwork_10307_full = == Summary - SUCCESS == No

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 1/5] igt/kms_getfb: Check the iface exists before use

2018-10-01 Thread Antonio Argenziano
On 01/10/18 12:43, Chris Wilson wrote: Quoting Antonio Argenziano (2018-10-01 19:36:24) On 28/09/18 03:19, Chris Wilson wrote: If the driver doesn't support the getfb iface (e.g. because KMS has been disabled), the ioctls will fail with ENOTSUP. This is expected, so skip the test as

Re: [Intel-gfx] [PATCH v3 4/6] drm/i915/dp: Do not grab crtc modeset lock in intel_dp_detect()

2018-10-01 Thread Ville Syrjälä
On Mon, Oct 01, 2018 at 12:48:28PM -0700, Rodrigo Vivi wrote: > On Tue, Sep 25, 2018 at 07:54:22PM -0700, Dhinakaran Pandiyan wrote: > > A crtc modeset lock was added for link retraining but > > intel_dp_retrain_link() knows to take the necessary locks since > > commit c85d200e8321 ("drm/i915:

[Intel-gfx] [PATCH] [intel-gfx] drm/i915/csr Added DC5 and DC6 counter register for ICL in debugfs entry.

2018-10-01 Thread Jyoti Yadav
DC5 and DC6 counter register tells about residency of DC5 and DC6. These registers are same for SKL and ICL. v2 : Remove csr_version check. Added generic check regarding DC counters for Gen9 onwards. (Rodrigo) Signed-off-by: Jyoti Yadav --- drivers/gpu/drm/i915/i915_debugfs.c | 7 ---

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: extract common ce->pin_count check

2018-10-01 Thread Patchwork
== Series Details == Series: drm/i915: extract common ce->pin_count check URL : https://patchwork.freedesktop.org/series/50414/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4911_full -> Patchwork_10315_full = == Summary - WARNING == Minor unknown changes coming with

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v3,1/6] drm/i915/psr: Share PSR and PSR2 exit mask

2018-10-01 Thread Patchwork
== Series Details == Series: series starting with [v3,1/6] drm/i915/psr: Share PSR and PSR2 exit mask URL : https://patchwork.freedesktop.org/series/50417/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4911_full -> Patchwork_10316_full = == Summary - WARNING == Minor

  1   2   >