[Intel-gfx] [PATCH] drm/i915: Ensure proper HDA suspend/resume ordering with a device link

2018-10-18 Thread Imre Deak
In order to ensure that our system suspend and resume callbacks are called in the correct order wrt. those of the HDA driver add a device link to the HDA driver during audio component binding time. With i915 as the supplier and HDA as the consumer the PM framework will guarantee the HDA->i915

Re: [Intel-gfx] [PATCH v2 5/8] drm/i915/gen11: Program the scalers correctly for planar formats, v3.

2018-10-18 Thread Ville Syrjälä
On Thu, Oct 18, 2018 at 01:51:31PM +0200, Maarten Lankhorst wrote: > The first 3 planes (primary, sprite 0 and 1) have a dedicated chroma > upsampler to upscale YUV420 to YUV444 and the scaler should only be > used for upscaling. Because of this we shouldn't program the scalers > in planar mode if

Re: [Intel-gfx] [PATCH v2 0/8] drm/i915/gen11: Add support for the NV12 format.

2018-10-18 Thread Ville Syrjälä
On Thu, Oct 18, 2018 at 01:51:26PM +0200, Maarten Lankhorst wrote: > New version, with a lot of reworking to incorporate all the feedback. > > We currently don't set the plane input CSC correctly, so colors are a > bit off. As a result I can't verify for 100% we program the chroma > upsampler

Re: [Intel-gfx] [PATCH v2 4/8] drm/i915/gen11: Handle watermarks correctly for separate Y/UV planes, v2.

2018-10-18 Thread Ville Syrjälä
On Thu, Oct 18, 2018 at 01:51:30PM +0200, Maarten Lankhorst wrote: > Skylake style watermarks program the UV parameters into wm->uv_wm, > and have a separate DDB allocation for UV blocks into the same plane. > > Gen11 watermarks have a separate plane for Y and UV, with separate > mechanisms. The

Re: [Intel-gfx] [PATCH v5 24/28] drm/i915/dp: Configure Display stream splitter registers during DSC enable

2018-10-18 Thread Ville Syrjälä
On Fri, Oct 05, 2018 at 04:23:02PM -0700, Manasi Navare wrote: > Display Stream Splitter registers need to be programmed to enable > the joiner if two DSC engines are used and also to enable > the left and the right DSC engines. This happens as part of > the DSC enabling routine in the source in

Re: [Intel-gfx] [PATCH] drm/i915: Use i915_gem_object_get_dma_address() to populate rotated vmas

2018-10-18 Thread Ville Syrjälä
On Thu, Oct 18, 2018 at 03:52:27PM +0100, Tvrtko Ursulin wrote: > > On 16/10/2018 16:04, Ville Syrjala wrote: > > From: Ville Syrjälä > > > > Replace the kvmalloc_array() with i915_gem_object_get_dma_address() when > > populating rotated vmas. One random access mechanism ought to be enough > >

Re: [Intel-gfx] [PATCH 10/11] drm/i915: add pipe_htotal to struct skl_wm_params

2018-10-18 Thread Ville Syrjälä
On Tue, Oct 16, 2018 at 03:01:32PM -0700, Paulo Zanoni wrote: > With this one here we can finally drop the intel state structures from > the functions that compute watermark values: they all rely on struct > skl_wm_params now. This should help the watermarks code be a little > more clear on its

Re: [Intel-gfx] [PATCH 11/11] drm/i915: pass dev_priv instead of cstate to skl_compute_transition_wm()

2018-10-18 Thread Ville Syrjälä
On Tue, Oct 16, 2018 at 03:01:33PM -0700, Paulo Zanoni wrote: > Stop passing modeset state structures to functions that should work > only with the skl_wm_params. The only use for cstate there was to > reach dev_priv, so pass it directly. > > Signed-off-by: Paulo Zanoni Reviewed-by: Ville

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for More watermarks improvements

2018-10-18 Thread Saarinen, Jani
HI, > -Original Message- > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of > Paulo Zanoni > Sent: keskiviikko 17. lokakuuta 2018 1.53 > To: intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for More watermarks improvements > >

Re: [Intel-gfx] [PATCH v2 1/8] drm/i915: Fix unsigned overflow when calculating total data rate

2018-10-18 Thread Ville Syrjälä
On Thu, Oct 18, 2018 at 01:51:27PM +0200, Maarten Lankhorst wrote: > On gen11, we can definitely smash the 32-bits barrier with just a > when we enable all planes in the next patch. > > Signed-off-by: Maarten Lankhorst > --- > drivers/gpu/drm/i915/intel_pm.c | 47

Re: [Intel-gfx] [PATCH v2 8/8] drm/i915/gen11: Expose planar format support on gen11.

2018-10-18 Thread Ville Syrjälä
On Thu, Oct 18, 2018 at 01:51:34PM +0200, Maarten Lankhorst wrote: > Signed-off-by: Maarten Lankhorst I guess the skl_has_planar() thing should be in this patch.. > --- > drivers/gpu/drm/i915/intel_display.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [Intel-gfx] [PATCH 08/11] drm/i915: reorganize the error message for invalid watermarks

2018-10-18 Thread Ville Syrjälä
On Thu, Oct 18, 2018 at 04:55:52PM +0300, Ville Syrjälä wrote: > On Tue, Oct 16, 2018 at 03:01:30PM -0700, Paulo Zanoni wrote: > > Print a more generic "failed to compute watermark levels" whenever any > > of skl_compute_wm_levels() fail, and print only the specific error > > message for the

Re: [Intel-gfx] [PATCH v2 0/8] drm/i915/gen11: Add support for the NV12 format.

2018-10-18 Thread Maarten Lankhorst
Op 18-10-18 om 17:16 schreef Ville Syrjälä: > On Thu, Oct 18, 2018 at 01:51:26PM +0200, Maarten Lankhorst wrote: >> New version, with a lot of reworking to incorporate all the feedback. >> >> We currently don't set the plane input CSC correctly, so colors are a >> bit off. As a result I can't

[Intel-gfx] [PULL] drm-misc-fixes

2018-10-18 Thread Maarten Lankhorst
drm-misc-fixes-2018-10-18: drm-misc-fixes for v4.19: - Fix use of freed memory in drm_mode_setcrtc. - Reject pixel format changing requests in fb helper. - Add 6 bpc quirk for HP Pavilion 15-n233sl - Fix VSDB yCBCr420 Deep Color mode bit definitions The following changes since commit

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Ensure proper HDA suspend/resume ordering with a device link

2018-10-18 Thread Patchwork
== Series Details == Series: drm/i915: Ensure proper HDA suspend/resume ordering with a device link URL : https://patchwork.freedesktop.org/series/51189/ State : success == Summary == = CI Bug Log - changes from CI_DRM_5008 -> Patchwork_10504 = == Summary - SUCCESS == No regressions

[Intel-gfx] [PULL] drm-intel-next-fixes

2018-10-18 Thread Joonas Lahtinen
Hi Dave, Here comes the final set of fixes under -next-fixes umbrella. Next one will be then from -fixes, assuming a release next Sun. Fixes for bunch of display related issues reported by users, then the MST fixes that were dropped from Rodrigos PR + further Icelake fixes and proactive

Re: [Intel-gfx] [RFC] GuC firmware versioning change

2018-10-18 Thread Jeff McGee
On Thu, Oct 18, 2018 at 11:57:06AM +0200, Daniel Vetter wrote: > On Fri, Oct 12, 2018 at 11:45 PM Jeff McGee wrote: > > > > On Fri, Oct 12, 2018 at 02:33:26PM -0700, Jeff McGee wrote: > > > On Fri, Oct 12, 2018 at 01:51:46PM -0700, Rodrigo Vivi wrote: > > > > On Fri, Oct 12, 2018 at 01:24:30PM

Re: [Intel-gfx] [PATCH v2 7/8] drm/i915/gen11: Program the Y and UV plane for planar mode correctly, v3.

2018-10-18 Thread Ville Syrjälä
On Thu, Oct 18, 2018 at 01:51:33PM +0200, Maarten Lankhorst wrote: > The UV plane is the master plane that does all color correction etc. > It needs to be programmed with the dimensions for color plane 1 (UV). > > The Y plane just feeds the Y pixels to it. Program the scaler from the > master

[Intel-gfx] [PATCH i-g-t 00/17] Media scalability tooling

2018-10-18 Thread Tvrtko Ursulin
From: Tvrtko Ursulin A bunch of patches to trace.pl and gem_wsim which enable simulation and load balancing analysis of the Virtual Engine work done separately by Chris Wilson. Culmination is being able to simulate a so called frame split media workloads. Example workload for this looks like

Re: [Intel-gfx] [PATCH 08/11] drm/i915: reorganize the error message for invalid watermarks

2018-10-18 Thread Ville Syrjälä
On Tue, Oct 16, 2018 at 03:01:30PM -0700, Paulo Zanoni wrote: > Print a more generic "failed to compute watermark levels" whenever any > of skl_compute_wm_levels() fail, and print only the specific error > message for the specific cases. This allows us to stop passing pstate > everywhere, making

Re: [Intel-gfx] [PATCH v2 6/8] drm/i915/gen11: Program the chroma upsampler for HDR planes.

2018-10-18 Thread Ville Syrjälä
On Thu, Oct 18, 2018 at 01:51:32PM +0200, Maarten Lankhorst wrote: > We configure the chroma upsampler with the same chroma siting as > used by the scaler for consistency, the chroma upsampler is used > instead of the scaler for YUV 4:2:0 on ICL's HDR planes. > > Signed-off-by: Maarten Lankhorst

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Drop rpm wakeref on error in debugfs/i915_drop_caches_set

2018-10-18 Thread Joonas Lahtinen
Pushed, because I need to get this cherry picked and included in PR. Thanks for the review. Regards, Joonas Quoting Patchwork (2018-10-18 13:12:43) > == Series Details == > > Series: drm/i915: Drop rpm wakeref on error in debugfs/i915_drop_caches_set > URL :

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] igt/gem_tiled_fence_blits: Remove libdrm_intel dependence

2018-10-18 Thread Tvrtko Ursulin
On 23/07/2018 13:14, Chris Wilson wrote: Modernise the test to use igt's ioctl library as opposed to the antiquated libdrm_intel. Signed-off-by: Chris Wilson --- tests/gem_tiled_fence_blits.c | 188 -- 1 file changed, 110 insertions(+), 78 deletions(-) diff

Re: [Intel-gfx] [PATCH] drm/i915: Ensure proper HDA suspend/resume ordering with a device link

2018-10-18 Thread Takashi Iwai
On Thu, 18 Oct 2018 16:25:58 +0200, Imre Deak wrote: > > In order to ensure that our system suspend and resume callbacks are > called in the correct order wrt. those of the HDA driver add a device > link to the HDA driver during audio component binding time. With i915 as > the supplier and HDA as

Re: [Intel-gfx] [PATCH v2 3/8] drm/i915/gen11: Link nv12 Y and UV planes in the atomic state, v4.

2018-10-18 Thread Ville Syrjälä
On Thu, Oct 18, 2018 at 01:51:29PM +0200, Maarten Lankhorst wrote: > To make NV12 working on icl, we need to update 2 planes simultaneously. > I've chosen to do this in the CRTC step after plane validation is done, > so we know what planes are (in)visible. The linked Y plane will get > updated in

Re: [Intel-gfx] [PATCH 09/11] drm/i915: make skl_needs_memory_bw_wa() take dev_priv instead of state

2018-10-18 Thread Ville Syrjälä
On Tue, Oct 16, 2018 at 03:01:31PM -0700, Paulo Zanoni wrote: > The function only really needs dev_priv to make its decision. If we > ever need more, we can change it again. But then, in this case we > should make needs_memory_bw_wa be a variable inside struct > skl_wm_params so we won't need to

[Intel-gfx] [PATCH i-g-t 01/17] lib: Update uapi headers

2018-10-18 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Sync with latest DRM uapi changes. --- include/drm-uapi/amdgpu_drm.h | 52 +++- include/drm-uapi/drm.h | 16 ++ include/drm-uapi/drm_fourcc.h | 224 +++ include/drm-uapi/drm_mode.h| 26 +- include/drm-uapi/etnaviv_drm.h | 6 +

[Intel-gfx] [PATCH i-g-t 13/17] gem_wsim: Compact int command parsing with a macro

2018-10-18 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Parsing an integer workload descriptor field is a common pattern which we can extract to a helper macro and by doing so further improve the readability of the main parsing loop. Signed-off-by: Tvrtko Ursulin --- benchmarks/gem_wsim.c | 80

[Intel-gfx] [PATCH i-g-t 11/17] gem_wsim: Engine map support

2018-10-18 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Support new i915 uAPI for configuring contexts with engine maps. Please refer to the README file for more detailed explanation. Signed-off-by: Tvrtko Ursulin --- benchmarks/gem_wsim.c | 212 ++--- benchmarks/wsim/README | 17 +++- 2

[Intel-gfx] [PATCH i-g-t 05/17] gem_wsim: Use IGT uapi headers

2018-10-18 Thread Tvrtko Ursulin
From: Tvrtko Ursulin We are moving towards bumping the uAPI headers more often instead of using too much local struct/ioctl/param definitions since the latter are more challenging for rebase and maintenance. Signed-off-by: Tvrtko Ursulin --- benchmarks/gem_wsim.c | 68

[Intel-gfx] [PATCH i-g-t 03/17] trace.pl: Virtual engine preemption support

2018-10-18 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Use the 'completed?' tracepoint field to detect more robustly when a request has been preempted and remove it from the engine database if so. Otherwise the script can hit a scenario where the same global seqno will be mentioned multiple times (on an engine seqno) which

[Intel-gfx] [PATCH i-g-t 02/17] trace.pl: Virtual engine support

2018-10-18 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Add virtual/queue timelines to both stdout and HTML output. A new timeline is created for each queue/virtual engine to display associated requests in queued and runnable states. Once requests are submitted to a real engine for executing they show up on the physical engine

[Intel-gfx] [PATCH i-g-t 12/17] gem_wsim: Save some lines by changing to implicit NULL checking

2018-10-18 Thread Tvrtko Ursulin
From: Tvrtko Ursulin We can improve the parsing loop readability a bit more by avoiding some line breaks caused by explicit NULL checks. Signed-off-by: Tvrtko Ursulin --- benchmarks/gem_wsim.c | 39 +++ 1 file changed, 15 insertions(+), 24 deletions(-)

[Intel-gfx] [PATCH i-g-t 08/17] gem_wsim: More wsim_err

2018-10-18 Thread Tvrtko Ursulin
From: Tvrtko Ursulin A few more opportunities to compact the code by using the error logging helper. Signed-off-by: Tvrtko Ursulin --- benchmarks/gem_wsim.c | 54 --- 1 file changed, 15 insertions(+), 39 deletions(-) diff --git a/benchmarks/gem_wsim.c

[Intel-gfx] [PATCH i-g-t 04/17] wsim/media-bench: i915 balancing

2018-10-18 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Support i915 virtual engine from gem_wsim (-b i915) and media-bench.pl Signed-off-by: Tvrtko Ursulin --- benchmarks/gem_wsim.c | 289 ++--- scripts/media-bench.pl | 9 +- 2 files changed, 251 insertions(+), 47 deletions(-) diff

[Intel-gfx] [PATCH i-g-t 07/17] gem_wsim: Factor out common error handling

2018-10-18 Thread Tvrtko Ursulin
From: Tvrtko Ursulin There is a repeated pattern with error handling which can be moved to a macro to for better readability in the command parsing loop. Signed-off-by: Tvrtko Ursulin --- benchmarks/gem_wsim.c | 244 +++--- 1 file changed, 88 insertions(+),

[Intel-gfx] [PATCH i-g-t 09/17] gem_wsim: Submit fence support

2018-10-18 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Add support for submit fences in a way similar to how normal input fences are handled. Eg: 1.RCS.500-1000.0.0 1.VCS1.3000.s-1.0 1.VCS2.3000.s-2.0 Submit fences are signalled when the originating request enters the submission backend. Signed-off-by: Tvrtko Ursulin

[Intel-gfx] [PATCH i-g-t 16/17] gem_wsim: Some more example workloads

2018-10-18 Thread Tvrtko Ursulin
From: Tvrtko Ursulin A few additional workloads useful for experimenting with scheduling. Signed-off-by: Tvrtko Ursulin --- benchmarks/wsim/frame-split-60fps.wsim | 16 benchmarks/wsim/high-composited-game.wsim | 11 +++ benchmarks/wsim/media-1080p-player.wsim

[Intel-gfx] [PATCH i-g-t 10/17] gem_wsim: Extract str to engine lookup

2018-10-18 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Signed-off-by: Tvrtko Ursulin --- benchmarks/gem_wsim.c | 34 +- 1 file changed, 21 insertions(+), 13 deletions(-) diff --git a/benchmarks/gem_wsim.c b/benchmarks/gem_wsim.c index a77a322ee309..17325d2ceaf6 100644 ---

[Intel-gfx] [PATCH i-g-t 17/17] gem_wsim: Infinite batch support

2018-10-18 Thread Tvrtko Ursulin
From: Tvrtko Ursulin For simulating frame split workloads it is useful to express a batch which ends at the same time as the parallel submission on the respective bonded engine. For this we add support for infinite batch durations and the batch terminate command ('T'). Syntax looks like this:

[Intel-gfx] [PATCH i-g-t 14/17] gem_wsim: Engine map load balance command

2018-10-18 Thread Tvrtko Ursulin
From: Tvrtko Ursulin A new workload command for enabling a load balanced context map (aka Virtual Engine). Example usage: 1.B This turns on load balancing for context one, assuming it has already been configured with an engine map. Only DEFAULT engine specifier can be used with load balanced

[Intel-gfx] [PATCH i-g-t 06/17] gem_wsim: Fix shadowed local

2018-10-18 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Signed-off-by: Tvrtko Ursulin --- benchmarks/gem_wsim.c | 1 - 1 file changed, 1 deletion(-) diff --git a/benchmarks/gem_wsim.c b/benchmarks/gem_wsim.c index adfc2b1bc819..2561817622f6 100644 --- a/benchmarks/gem_wsim.c +++ b/benchmarks/gem_wsim.c @@ -1170,7 +1170,6 @@

[Intel-gfx] [PATCH i-g-t 15/17] gem_wsim: Engine bond command

2018-10-18 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Engine bonds are an i915 uAPI applicable to load balanced contexts with engine map. They allow expression rules of engine selection between two contexts when submissions are also tied with submit fences. Please refer to the README for a more detailed description.

Re: [Intel-gfx] [PATCH] drm/i915/guc: Propagate the fw xfer timeout

2018-10-18 Thread Daniele Ceraolo Spurio
On 18/10/18 02:13, Chris Wilson wrote: Quoting Michal Wajdeczko (2018-10-18 00:22:43) On Thu, 18 Oct 2018 01:09:19 +0200, Daniele Ceraolo Spurio wrote: On 17/10/18 13:29, Chris Wilson wrote: Propagate the timeout on transferring the fw back to the caller where it may act upon it,

Re: [Intel-gfx] [PATCH] drm/i915/icl: Store available engine masks in INTEL_INFO

2018-10-18 Thread Daniele Ceraolo Spurio
On 18/10/18 03:41, Tvrtko Ursulin wrote: From: Tvrtko Ursulin Upcoming GuC code will need to read the fused off engine masks as well, and will also want to have them as enabled instead of disabled masks. To consolidate the read-out place we can store them in this fashion inside INTEL_INFO

Re: [Intel-gfx] [PATCH] drm/i915: Add ppgtt to GVT GEM context

2018-10-18 Thread Zhenyu Wang
On 2018.10.18 13:40:31 +0800, Xiong Zhang wrote: > Currently the guest couldn't boot up under GVT-g environment as the > following call trace exists: > [ 272.504762] BUG: unable to handle kernel NULL pointer dereference at > 0100 > [ 272.504834] Call Trace: > [ 272.504852]

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 15/17] gem_wsim: Engine bond command

2018-10-18 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-10-18 16:28:13) > @@ -1196,6 +1256,7 @@ prepare_workload(unsigned int id, struct workload *wrk, > unsigned int flags) > { .base.name = > I915_CONTEXT_ENGINES_EXT_LOAD_BALANCE, > .engines_mask = -1, >

[Intel-gfx] [PATCH 2/2] drm/i915/ICL: Add pre_pll_enable hook for ICL and set DFLEXDPMLE in this hook

2018-10-18 Thread Manasi Navare
In case of Legacy DP connector on TypeC port, the flex IO DPMLE register is set to number of lanes configured by the display driver which will be programmed into DDI_BUF_CTL PORT_WIDTH_SELECTION. This needs to be programmed before enabling the shared PLLs hence add a pre_pll_enable hook for ICL

[Intel-gfx] [PATCH v3] drm/i915/guc: doorbell checking cleanup

2018-10-18 Thread Daniele Ceraolo Spurio
A collection of very small cleanups/improvements around doorbell checking that do not deserve their own patch: - Move doorbell-related HW defs to intel_guc_reg.h - use GUC_NUM_DOORBELLS instead of GUC_DOORBELL_INVALID where appropriate - do not stop on error in guc_verify_doorbells - do not

Re: [Intel-gfx] [RFC] GuC firmware versioning change

2018-10-18 Thread Rodrigo Vivi
On Thu, Oct 18, 2018 at 10:32:37AM -0700, Jeff McGee wrote: > On Thu, Oct 18, 2018 at 11:57:06AM +0200, Daniel Vetter wrote: > > On Fri, Oct 12, 2018 at 11:45 PM Jeff McGee wrote: > > > > > > On Fri, Oct 12, 2018 at 02:33:26PM -0700, Jeff McGee wrote: > > > > On Fri, Oct 12, 2018 at 01:51:46PM

[Intel-gfx] [PATCH v3] drm/i915/guc: Propagate the fw xfer timeout

2018-10-18 Thread Chris Wilson
Propagate the timeout on transferring the fw back to the caller where it may act upon it, usually by restarting the xfer before failing. v2: Simplify the wait to only wait upon the guc signaling completion, with an assertion that the fw xfer must have completed for it to be ready! Testcase:

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/icl: Fix the macros for DFLEXDPMLE register bits

2018-10-18 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/icl: Fix the macros for DFLEXDPMLE register bits URL : https://patchwork.freedesktop.org/series/51223/ State : success == Summary == = CI Bug Log - changes from CI_DRM_5011 -> Patchwork_10509 = == Summary - SUCCESS == No

Re: [Intel-gfx] [v2 3/6] i915/dp/fec: Check for FEC Support

2018-10-18 Thread Manasi Navare
On Mon, Oct 15, 2018 at 02:50:34PM -0700, Anusha Srivatsa wrote: > For DP 1.4 and above, Display Stream compression can be > enabled only if Forward Error Correctin can be performed. > > Check if the sink supports FEC using the helper. > > v2: Mention External DP where ever FEC is mentioned > in

Re: [Intel-gfx] [RFC] GuC firmware versioning change

2018-10-18 Thread Jeff McGee
On Thu, Oct 18, 2018 at 11:12:21AM -0700, Rodrigo Vivi wrote: > On Thu, Oct 18, 2018 at 10:32:37AM -0700, Jeff McGee wrote: > > On Thu, Oct 18, 2018 at 11:57:06AM +0200, Daniel Vetter wrote: > > > On Fri, Oct 12, 2018 at 11:45 PM Jeff McGee wrote: > > > > > > > > On Fri, Oct 12, 2018 at

Re: [Intel-gfx] [v2 4/6] drm/i915/fec: Set FEC_READY in FEC_CONFIGURATION

2018-10-18 Thread Manasi Navare
On Mon, Oct 15, 2018 at 02:50:35PM -0700, Anusha Srivatsa wrote: > If the panel supports FEC, the driver has to > set the FEC_READY bit in the dpcd register: > FEC_CONFIGURATION. > > This has to happen before link training. > > v2: s/intel_dp_set_fec_ready/intel_dp_sink_set_fec_ready >-

[Intel-gfx] [RFC 8/8] drm/i915: Simplify intel_has_sagv function.

2018-10-18 Thread Rodrigo Vivi
Let's just handle SKL as special case instead of listing platform by platform. Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/intel_pm.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c index

[Intel-gfx] [RFC 3/8] drm/i915/gen10: Prefer gen number than platform codename.

2018-10-18 Thread Rodrigo Vivi
Whenever possible let's move towards preferring gen number and or features instead of hard coding platform codename everywhere. Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/i915_drv.h | 2 +- drivers/gpu/drm/i915/intel_cdclk.c | 6 +++--- drivers/gpu/drm/i915/intel_ddi.c

[Intel-gfx] [RFC 2/8] drm/i915: Use the ddi_ports info to kill ugly CNL_WITH_PORT_F.

2018-10-18 Thread Rodrigo Vivi
Now that we have the number of ddi ports information available let's use it instead of that ugly platform macro. Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/i915_drv.c | 10 ++ drivers/gpu/drm/i915/i915_drv.h | 2 -- drivers/gpu/drm/i915/i915_irq.c | 5

[Intel-gfx] [RFC 1/8] drm/i915: Make number of ddi ports explicit.

2018-10-18 Thread Rodrigo Vivi
Instead of a simple bool that shows if we have ddi ports or not, let's highlight the number of ddi ports. So we can use this information to determine the code path instead of using platforms codenames. Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/i915_drv.h | 2 +-

[Intel-gfx] [RFC 7/8] drm/i915: Sort platform if cases from newer-to-older.

2018-10-18 Thread Rodrigo Vivi
Let's use this whenever it makes sense and code gets easier to read. Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/intel_ddi.c| 18 +- drivers/gpu/drm/i915/intel_dp.c | 24 +--- drivers/gpu/drm/i915/intel_pm.c | 6 +++---

[Intel-gfx] [RFC 6/8] drm/i915: Consolidate cdclk hooks.

2018-10-18 Thread Rodrigo Vivi
We don't need 2 different blocks. Specially with on in ordered older-to-newer and the other one newer-to-older. Let's start always using newer-to-older order when it makes sense. Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/intel_cdclk.c | 91 ++ 1 file

[Intel-gfx] [RFC 5/8] drm/i915/gen11+: Prefer gen over platform codename.

2018-10-18 Thread Rodrigo Vivi
Also let's always consider next platform follows the most recent one. Like we have done for transitioning gen9 to gen10 and gent10 to gen11. Let's use same approach for gen11+ and only introduce changes later as needed. Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/intel_cdclk.c |

[Intel-gfx] [RFC 4/8] drm/i915: Group gen 10 display.

2018-10-18 Thread Rodrigo Vivi
Continuing with the goal of use less platform codenames: let's group platforms who has gen10 display. Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/i915_drv.h | 2 ++ drivers/gpu/drm/i915/intel_cdclk.c | 2 +- drivers/gpu/drm/i915/intel_color.c | 2 +-

[Intel-gfx] [RFC 0/8] re-organize a bit gen10 and gen11

2018-10-18 Thread Rodrigo Vivi
The goal off this series is to start the trend of prefering gen number and feature checks instead of hardcoding individual platform names everywhere. I tried to use coccinelle but I failed badly because there are places where it makes sense to have platform codenames still. On sort part it was

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for re-organize a bit gen10 and gen11

2018-10-18 Thread Patchwork
== Series Details == Series: re-organize a bit gen10 and gen11 URL : https://patchwork.freedesktop.org/series/51230/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915: Make number of ddi ports explicit. Okay! Commit: drm/i915: Use the ddi_ports

[Intel-gfx] [PATCH 1/2] drm/i915/icl: Fix the macros for DFLEXDPMLE register bits

2018-10-18 Thread Manasi Navare
This patch fixes the macros used for defining the DFLEXDPMLE register bit fields. This accounts for changes in the spec. Fixes: a2bc69a1a9d6 ("drm/i915/icl: Add register definition for DFLEXDPMLE") Cc: Animesh Manna Cc: Paulo Zanoni Cc: Jose Roberto de Souza Signed-off-by: Manasi Navare ---

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/guc: Propagate the fw xfer timeout (rev3)

2018-10-18 Thread Patchwork
== Series Details == Series: drm/i915/guc: Propagate the fw xfer timeout (rev3) URL : https://patchwork.freedesktop.org/series/51140/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_5010_full -> Patchwork_10507_full = == Summary - FAILURE == Serious unknown changes coming

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v2,1/6] drm/i915/guc: drop negative doorbell alloc selftest (rev2)

2018-10-18 Thread Patchwork
== Series Details == Series: series starting with [v2,1/6] drm/i915/guc: drop negative doorbell alloc selftest (rev2) URL : https://patchwork.freedesktop.org/series/51153/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_5011 -> Patchwork_10510 = == Summary - FAILURE ==

[Intel-gfx] ✗ Fi.CI.BAT: failure for re-organize a bit gen10 and gen11

2018-10-18 Thread Patchwork
== Series Details == Series: re-organize a bit gen10 and gen11 URL : https://patchwork.freedesktop.org/series/51230/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_5011 -> Patchwork_10511 = == Summary - FAILURE == Serious unknown changes coming with Patchwork_10511

Re: [Intel-gfx] [v2 5/6] i915/dp/fec: Configure the Forward Error Correction bits.

2018-10-18 Thread Manasi Navare
On Mon, Oct 15, 2018 at 02:50:36PM -0700, Anusha Srivatsa wrote: > If FEC is supported, the corresponding > DP_TP_CTL register bits have to be configured. > > The driver has to program the FEC_ENABLE in DP_TP_CTL[30] register > and wait till FEC_STATUS in DP_TP_CTL[28] is 1. > Also add the warn

Re: [Intel-gfx] [v2 6/6] drm/i915/fec: Disable FEC state.

2018-10-18 Thread Manasi Navare
Hi Anusha, Find my comments below: On Mon, Oct 15, 2018 at 02:50:37PM -0700, Anusha Srivatsa wrote: > Set the suitable bits in DP_TP_CTL to stop > bit correction when DSC is disabled. > > - rebased. > - Add additional check for compression state. (Gaurav) > > v3: rebased. > > Cc: Gaurav K

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/6] drm/i915/guc: drop negative doorbell alloc selftest (rev2)

2018-10-18 Thread Patchwork
== Series Details == Series: series starting with [v2,1/6] drm/i915/guc: drop negative doorbell alloc selftest (rev2) URL : https://patchwork.freedesktop.org/series/51153/ State : warning == Summary == $ dim checkpatch origin/drm-tip fbae90ba884e drm/i915/guc: rename

Re: [Intel-gfx] [PATCH] drm/i915/cnp+: update to the new RAWCLK_FREQ recommendations

2018-10-18 Thread Rodrigo Vivi
On Thu, Oct 18, 2018 at 03:52:21PM +0300, Ville Syrjälä wrote: > On Tue, Oct 16, 2018 at 04:09:19PM -0700, Rodrigo Vivi wrote: > > On Tue, Oct 16, 2018 at 04:00:26PM -0700, Paulo Zanoni wrote: > > > Em Sex, 2018-10-12 às 15:42 +0300, Ville Syrjälä escreveu: > > > > On Thu, Oct 11, 2018 at

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for re-organize a bit gen10 and gen11

2018-10-18 Thread Patchwork
== Series Details == Series: re-organize a bit gen10 and gen11 URL : https://patchwork.freedesktop.org/series/51230/ State : warning == Summary == $ dim checkpatch origin/drm-tip 8c7a79b33eb4 drm/i915: Make number of ddi ports explicit. e86a18876ae8 drm/i915: Use the ddi_ports info to kill

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/i915: Relocate SKL+ NV12 src width w/a

2018-10-18 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Relocate SKL+ NV12 src width w/a URL : https://patchwork.freedesktop.org/series/51215/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_5010_full -> Patchwork_10508_full = == Summary - FAILURE == Serious

[Intel-gfx] [PATCH v3 1/2] drm/i915/guc: Limit number of scratch registers used for H2G

2018-10-18 Thread Michal Wajdeczko
We wrongly assumed that GuC is only using last scratch register for G2H messages, but in fact it is also using register [14] to report sleep state status. Remove that register from our H2G send registers pool. v2: No message from host to GuC uses more than 8 registers and the GuC FW itself uses

[Intel-gfx] [PATCH v3 2/2] HAX: Enable GuC for CI

2018-10-18 Thread Michal Wajdeczko
GuC is disabled by default. Enable it. Signed-off-by: Michal Wajdeczko --- drivers/gpu/drm/i915/i915_params.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h index 7e56c51..c681537 100644 ---

[Intel-gfx] [PATCH v2] drm/i915/guc: Propagate the fw xfer timeout

2018-10-18 Thread Chris Wilson
Propagate the timeout on transferring the fw back to the caller where it may act upon it, usually by restarting the xfer before failing. v2: Simplify the wait to only wait upon the guc signaling completion, with an assertion that the fw xfer must have completed for it to be ready! Testcase:

Re: [Intel-gfx] [PATCH v3] drm/i915/guc: Propagate the fw xfer timeout

2018-10-18 Thread Daniele Ceraolo Spurio
On 18/10/18 12:55, Chris Wilson wrote: Propagate the timeout on transferring the fw back to the caller where it may act upon it, usually by restarting the xfer before failing. v2: Simplify the wait to only wait upon the guc signaling completion, with an assertion that the fw xfer must have

[Intel-gfx] [PATCH 1/2] drm/i915: Relocate SKL+ NV12 src width w/a

2018-10-18 Thread Ville Syrjala
From: Ville Syrjälä The SKL+ NV12 src width alignment w/a is still living in an odd place. Everything else was already relocated closer to the main plane check function. Move this workaround as well. As a bonus we avoid the funky rotated vs. not mess with the src coordinates as this now gets

[Intel-gfx] [PATCH 2/2] drm/i915: Move the SKL+ zero constant alpha handling

2018-10-18 Thread Ville Syrjala
From: Ville Syrjälä Let's run through the entire plane check even when the plane is invisible due to zero constant alpha. This makes for more consistent behaviour since we check the src/dst coordinates, stride etc. against the hardware limits. Signed-off-by: Ville Syrjälä ---

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [v3,1/2] drm/i915/guc: Limit number of scratch registers used for H2G

2018-10-18 Thread Patchwork
== Series Details == Series: series starting with [v3,1/2] drm/i915/guc: Limit number of scratch registers used for H2G URL : https://patchwork.freedesktop.org/series/51206/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_5010 -> Patchwork_10505 = == Summary - FAILURE ==

Re: [Intel-gfx] [PULL] drm-intel-next-fixes

2018-10-18 Thread Daniel Vetter
On Thu, Oct 18, 2018 at 6:57 PM Joonas Lahtinen wrote: > > Hi Dave, > > Here comes the final set of fixes under -next-fixes umbrella. > Next one will be then from -fixes, assuming a release next Sun. > > Fixes for bunch of display related issues reported by users, then the > MST fixes that were

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: Propagate the fw xfer timeout (rev3)

2018-10-18 Thread Patchwork
== Series Details == Series: drm/i915/guc: Propagate the fw xfer timeout (rev3) URL : https://patchwork.freedesktop.org/series/51140/ State : success == Summary == = CI Bug Log - changes from CI_DRM_5010 -> Patchwork_10507 = == Summary - SUCCESS == No regressions found. External URL:

Re: [Intel-gfx] [RFC] drm/i915/guc: New GuC stage descriptors

2018-10-18 Thread Daniele Ceraolo Spurio
On 17/10/18 11:42, Lis, Tomasz wrote: On 2018-10-12 20:25, Daniele Ceraolo Spurio wrote: With the new interface, GuC now requires every lrc to be registered in one of the stage descriptors, which have been re-designed so that each descriptor can store up to 64 lrc per class (i.e. equal to

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/guc: Propagate the fw xfer timeout (rev2)

2018-10-18 Thread Patchwork
== Series Details == Series: drm/i915/guc: Propagate the fw xfer timeout (rev2) URL : https://patchwork.freedesktop.org/series/51140/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_5010 -> Patchwork_10506 = == Summary - FAILURE == Serious unknown changes coming with

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Relocate SKL+ NV12 src width w/a

2018-10-18 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Relocate SKL+ NV12 src width w/a URL : https://patchwork.freedesktop.org/series/51215/ State : success == Summary == = CI Bug Log - changes from CI_DRM_5010 -> Patchwork_10508 = == Summary - WARNING == Minor unknown changes

Re: [Intel-gfx] [PATCH] drm/i915/guc: Propagate the fw xfer timeout

2018-10-18 Thread Michal Wajdeczko
On Thu, 18 Oct 2018 20:18:53 +0200, Daniele Ceraolo Spurio wrote: On 18/10/18 02:13, Chris Wilson wrote: Quoting Michal Wajdeczko (2018-10-18 00:22:43) On Thu, 18 Oct 2018 01:09:19 +0200, Daniele Ceraolo Spurio wrote: On 17/10/18 13:29, Chris Wilson wrote: Propagate the timeout on

Re: [Intel-gfx] [PATCH v3 1/2] drm/i915/guc: Limit number of scratch registers used for H2G

2018-10-18 Thread Daniele Ceraolo Spurio
On 18/10/18 11:30, Michal Wajdeczko wrote: We wrongly assumed that GuC is only using last scratch register for G2H messages, but in fact it is also using register [14] to report sleep state status. Remove that register from our H2G send registers pool. v2: No message from host to GuC uses

Re: [Intel-gfx] [PATCH] drm/i915/guc: Propagate the fw xfer timeout

2018-10-18 Thread Chris Wilson
Quoting Michal Wajdeczko (2018-10-18 19:27:20) > On Thu, 18 Oct 2018 20:18:53 +0200, Daniele Ceraolo Spurio > wrote: > > > > > > > On 18/10/18 02:13, Chris Wilson wrote: > >> Quoting Michal Wajdeczko (2018-10-18 00:22:43) > >>> On Thu, 18 Oct 2018 01:09:19 +0200, Daniele Ceraolo Spurio > >>>

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Ensure proper HDA suspend/resume ordering with a device link

2018-10-18 Thread Patchwork
== Series Details == Series: drm/i915: Ensure proper HDA suspend/resume ordering with a device link URL : https://patchwork.freedesktop.org/series/51189/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_5008_full -> Patchwork_10504_full = == Summary - FAILURE == Serious

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Mark pinned shmemfs pages as unevictable

2018-10-18 Thread Chris Wilson
Quoting Chris Wilson (2018-10-16 19:31:06) > Fwiw, the shmem_unlock_mapping() call feels quite expensive, almost > nullifying the advantage gained from not walking the lists in reclaim. > I'll have better numbers in a couple of days. Using a test ("igt/benchmarks/gem_syslatency -t 120 -b -m" on

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add ppgtt to GVT GEM context

2018-10-18 Thread Patchwork
== Series Details == Series: drm/i915: Add ppgtt to GVT GEM context URL : https://patchwork.freedesktop.org/series/51156/ State : success == Summary == = CI Bug Log - changes from CI_DRM_5000 -> Patchwork_10500 = == Summary - SUCCESS == No regressions found. External URL:

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Mark pinned shmemfs pages as unevictable

2018-10-18 Thread Michal Hocko
On Thu 18-10-18 07:56:45, Chris Wilson wrote: > Quoting Chris Wilson (2018-10-16 19:31:06) > > Fwiw, the shmem_unlock_mapping() call feels quite expensive, almost > > nullifying the advantage gained from not walking the lists in reclaim. > > I'll have better numbers in a couple of days. > > Using

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: GEM_WARN_ON considered harmful (rev2)

2018-10-18 Thread Tvrtko Ursulin
On 12/10/2018 08:16, Patchwork wrote: == Series Details == Series: drm/i915: GEM_WARN_ON considered harmful (rev2) URL : https://patchwork.freedesktop.org/series/49340/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4976 -> Patchwork_10434 = == Summary - SUCCESS ==

[Intel-gfx] [PATCH] drm/i915: Drop rpm wakeref on error in debugfs/i915_drop_caches_set

2018-10-18 Thread Joonas Lahtinen
Use single exit point to drop rpm wakeref in case of an error. Fixes: 9d3eb2c33f03 ("drm/i915: Hold rpm wakeref for debugfs/i915_drop_caches_set") Signed-off-by: Joonas Lahtinen Cc: Chris Wilson Cc: Ville Syrjälä --- drivers/gpu/drm/i915/i915_debugfs.c | 3 ++- 1 file changed, 2

Re: [Intel-gfx] [PATCH v2] drm/i915/huc: Normalize HuC status returned by I915_PARAM_HAS_HUC

2018-10-18 Thread Chris Wilson
Quoting Michal Wajdeczko (2018-10-17 20:52:45) > In response for I915_PARAM_HAS_HUC we are returning value that > indicates if HuC firmware was loaded and verified. However, our > previously used positive value was based on specific register bit > which is about to change on future platform. Let's

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Add ppgtt to GVT GEM context

2018-10-18 Thread Patchwork
== Series Details == Series: drm/i915: Add ppgtt to GVT GEM context URL : https://patchwork.freedesktop.org/series/51156/ State : success == Summary == = CI Bug Log - changes from CI_DRM_5000_full -> Patchwork_10500_full = == Summary - SUCCESS == No regressions found. == Known issues

Re: [Intel-gfx] [PATCH] kthread: finer-grained lockdep/cross-release completion

2018-10-18 Thread Daniel Vetter
On Fri, Mar 16, 2018 at 12:26 AM Byungchul Park wrote: > > On 3/15/2018 9:41 PM, Peter Zijlstra wrote: > > On Thu, Mar 15, 2018 at 11:31:57AM +0100, Daniel Vetter wrote: > >> Is there any progress on getting cross-release enabled again? > > > > Not yet, I'm still fighting the meltdown/spectre

Re: [Intel-gfx] [PATCH] drm/i915/guc: Propagate the fw xfer timeout

2018-10-18 Thread Chris Wilson
Quoting Michal Wajdeczko (2018-10-18 00:22:43) > On Thu, 18 Oct 2018 01:09:19 +0200, Daniele Ceraolo Spurio > wrote: > > > > > > > On 17/10/18 13:29, Chris Wilson wrote: > >> Propagate the timeout on transferring the fw back to the caller where it > >> may act upon it, usually by restarting

  1   2   >