Raptor Lake S(RPL-S) is a version 12
Display, Media and Render. For all i915
purposes it is the same as Alder Lake S (ADL-S).
The series introduces it as a subplatform
of ADL-S. The one difference is the GuC
submission which is default on RPL-S but
was not the case with ADL-S.
Anusha Srivatsa
Raptor Lake S(RPL-S) is a version 12
Display, Media and Render. For all i915
purposes it is the same as Alder Lake S (ADL-S).
Introduce RPL-S as a subplatform
of ADL-S. This patch adds PCI ids for RPL-S.
v2: Update PCI IDs.
- Add more description to commit message (Jani)
v3:
Add the PCH ID for RPL-S.
v2: Self contained commit message (Jani)
Cc: Jani Nikula
Cc: Swathi Dhanavanthri
Signed-off-by: Anusha Srivatsa
---
drivers/gpu/drm/i915/intel_pch.c | 1 +
drivers/gpu/drm/i915/intel_pch.h | 1 +
2 files changed, 2 insertions(+)
diff --git
Though, RPL-S is defined as subplatform of ADL-S, unlike
ADL-S, it has GuC submission by default.
v2: Remove extra parenthesis (Jani)
v3: s/IS_RAPTORLAKE/IS_ADLS_RPLS (Jani)
Cc: Jani Nikula
Cc: Swathi Dhanavanthri
Signed-off-by: Anusha Srivatsa
---
drivers/gpu/drm/i915/gt/uc/intel_uc.c | 2
> -Original Message-
> From: Intel-gfx On Behalf Of Ville
> Syrjala
> Sent: Wednesday, November 24, 2021 1:37 PM
> To: intel-gfx@lists.freedesktop.org
> Subject: [Intel-gfx] [PATCH 15/20] drm/i915/fbc: Disable FBC fully on FIFO
> underrun
>
> From: Ville Syrjälä
>
> Currently a FIFO
From: Siva Mullati
Only hw that supports mappable aperture would hit this path
vm_fault_gtt/vm_fault_tmm, So we never hit this function
remap_io_mapping() in discrete, So skip this code for non-x86
architectures.
v2: use IS_ENABLED () instead of #if defined
v3: move function prototypes from
On Tue, 30 Nov 2021, Lucas De Marchi wrote:
> On Mon, Nov 22, 2021 at 06:01:42PM +0530, Mullati Siva wrote:
>>From: Siva Mullati
>>
>>Only hw that supports mappable aperture would hit this path
>>vm_fault_gtt/vm_fault_tmm, So we never hit this function
>>remap_io_mapping() in discrete, So skip
On Tue, 30 Nov 2021, Anusha Srivatsa wrote:
> Though, RPL-S is defined as subplatform of ADL-S, unlike
> ADL-S, it has GuC submission by default.
>
> v2: Remove extra parenthesis (Jani)
> v3: s/IS_RAPTORLAKE/IS_ADLS_RPLS (Jani)
>
> Cc: Jani Nikula
> Cc: Swathi Dhanavanthri
> Signed-off-by:
> -Original Message-
> From: Intel-gfx On Behalf Of Ville
> Syrjala
> Sent: Wednesday, November 24, 2021 1:37 PM
> To: intel-gfx@lists.freedesktop.org
> Subject: [Intel-gfx] [PATCH 08/20] drm/i915/fbc: Track FBC usage per-plane
>
> From: Ville Syrjälä
>
> In the future we may have
On 01/12/2021 02:20, Rogozhkin, Dmitry V wrote:
On Fri, 2021-11-19 at 12:59 +, Tvrtko Ursulin wrote:
From: Tvrtko Ursulin
Adding a cross-check with ABI config name space and not just relying
on
sysfs names.
Signed-off-by: Tvrtko Ursulin
Cc: Dmitry Rogozhkin
---
> -Original Message-
> From: Intel-gfx On Behalf Of Ville
> Syrjala
> Sent: Wednesday, November 24, 2021 1:37 PM
> To: intel-gfx@lists.freedesktop.org
> Subject: [Intel-gfx] [PATCH 10/20] drm/i915/fbc: Pass i915 instead of FBC
> instance to FBC underrun stuff
>
> From: Ville Syrjälä
>
> -Original Message-
> From: Intel-gfx On Behalf Of Ville
> Syrjala
> Sent: Wednesday, November 24, 2021 1:37 PM
> To: intel-gfx@lists.freedesktop.org
> Subject: [Intel-gfx] [PATCH 12/20] drm/i915/fbc: Introduce
> intel_fbc_add_plane()
>
> From: Ville Syrjälä
>
> In order to better
On 12/1/21 11:32, Christian König wrote:
Am 01.12.21 um 11:15 schrieb Thomas Hellström (Intel):
[SNIP]
What we could do is to avoid all this by not calling the callback
with the lock held in the first place.
If that's possible that might be a good idea, pls also see below.
The problem
> -Original Message-
> From: Intel-gfx On Behalf Of Ville
> Syrjala
> Sent: Wednesday, November 24, 2021 1:37 PM
> To: intel-gfx@lists.freedesktop.org
> Subject: [Intel-gfx] [PATCH 19/20] drm/i915/fbc: No FBC+double wide pipe
>
> From: Ville Syrjälä
>
> FBC and double wide pipe are
On 12/1/21 08:05, Christian König wrote:
Am 30.11.21 um 20:27 schrieb Thomas Hellström:
On 11/30/21 19:12, Thomas Hellström wrote:
On Tue, 2021-11-30 at 16:02 +0100, Christian König wrote:
Am 30.11.21 um 15:35 schrieb Thomas Hellström:
On Tue, 2021-11-30 at 14:26 +0100, Christian König
> -Original Message-
> From: Intel-gfx On Behalf Of Ville
> Syrjala
> Sent: Wednesday, November 24, 2021 1:37 PM
> To: intel-gfx@lists.freedesktop.org
> Subject: [Intel-gfx] [PATCH 05/20] drm/i915/fbc: Nuke more FBC state
>
> From: Ville Syrjälä
>
> There isn't a good reason why we'd
On 01.12.2021 01:38, Lucas De Marchi wrote:
> On Wed, Dec 01, 2021 at 12:41:08AM +0200, Andi Shyti wrote:
>> Hi Lucas,
>>
>> fist of all thanks for taking a look at this, I was eagerly
>> waiting for reviewers.
>>
>> On Tue, Nov 30, 2021 at 01:07:30PM -0800, Lucas De Marchi wrote:
>>> On Sun,
> -Original Message-
> From: Intel-gfx On Behalf Of Ville
> Syrjala
> Sent: Wednesday, November 24, 2021 1:37 PM
> To: intel-gfx@lists.freedesktop.org
> Subject: [Intel-gfx] [PATCH 06/20] drm/i915/fbc: Reuse the same struct for the
> cache and params
>
> From: Ville Syrjälä
>
> The FBC
On 12/1/21 09:36, Christian König wrote:
Am 01.12.21 um 09:23 schrieb Thomas Hellström (Intel):
[SNIP]
Jason and I came up with a deep dive iterator for his use case,
but I
think we don't want to use that any more after my dma_resv rework.
In other words when you need to create a new
> -Original Message-
> From: Intel-gfx On Behalf Of Ville
> Syrjala
> Sent: Wednesday, November 24, 2021 1:37 PM
> To: intel-gfx@lists.freedesktop.org
> Subject: [Intel-gfx] [PATCH 13/20] drm/i915/fbc: Allocate intel_fbc
> dynamically
>
> From: Ville Syrjälä
>
> In the future we may
> -Original Message-
> From: Intel-gfx On Behalf Of Ville
> Syrjala
> Sent: Wednesday, November 24, 2021 1:37 PM
> To: intel-gfx@lists.freedesktop.org
> Subject: [Intel-gfx] [PATCH 14/20] drm/i915/fbc: Move stuff from
> intel_fbc_can_enable() into intel_fbc_check_plane()
>
> From: Ville
On 30-11-2021 19:38, Tvrtko Ursulin wrote:
>
> On 30/11/2021 11:17, Maarten Lankhorst wrote:
>> On 30-11-2021 09:54, Tvrtko Ursulin wrote:
>>>
>>> Hi,
>>>
>>> On 29/11/2021 13:47, Maarten Lankhorst wrote:
New version of the series, with feedback from previous series added.
>>>
>>> If there
On Tue, 30 Nov 2021, Lyude Paul wrote:
> While working on supporting the Intel HDR backlight interface, I noticed
> that there's a couple of laptops that will very rarely manage to boot up
> without detecting Intel HDR backlight support - even though it's supported
> on the system. One example of
> -Original Message-
> From: Jani Nikula
> Sent: Wednesday, December 1, 2021 2:46 PM
> To: Srivatsa, Anusha ; intel-
> g...@lists.freedesktop.org
> Cc: Srivatsa, Anusha ; Dhanavanthri, Swathi
>
> Subject: Re: [v3 3/3] drm/i915/rpl-s: Enable guc submission by default
>
> On Tue, 30 Nov
> -Original Message-
> From: Intel-gfx On Behalf Of Ville
> Syrjala
> Sent: Wednesday, November 24, 2021 1:37 PM
> To: intel-gfx@lists.freedesktop.org
> Subject: [Intel-gfx] [PATCH 07/20] drm/i915/fbc: Pass around FBC instance
> instead of crtc
>
> From: Ville Syrjälä
>
> Pass the FBC
> -Original Message-
> From: Intel-gfx On Behalf Of Ville
> Syrjala
> Sent: Wednesday, November 24, 2021 1:37 PM
> To: intel-gfx@lists.freedesktop.org
> Subject: [Intel-gfx] [PATCH 09/20] drm/i915/fbc: Flatten
> __intel_fbc_pre_update()
>
> From: Ville Syrjälä
>
> Use an early return
> -Original Message-
> From: Intel-gfx On Behalf Of Ville
> Syrjala
> Sent: Wednesday, November 24, 2021 1:37 PM
> To: intel-gfx@lists.freedesktop.org
> Subject: [Intel-gfx] [PATCH 16/20] drm/i915/fbc: Nuke state_cache
>
> From: Ville Syrjälä
>
> fbc->state_cache has now become
> -Original Message-
> From: Intel-gfx On Behalf Of Ville
> Syrjala
> Sent: Wednesday, November 24, 2021 1:37 PM
> To: intel-gfx@lists.freedesktop.org
> Subject: [Intel-gfx] [PATCH 17/20] drm/i915/fbc: Move plane pointer into
> intel_fbc_state
>
> From: Ville Syrjälä
>
> Currently we
> -Original Message-
> From: Intel-gfx On Behalf Of Ville
> Syrjala
> Sent: Wednesday, November 24, 2021 1:37 PM
> To: intel-gfx@lists.freedesktop.org
> Subject: [Intel-gfx] [PATCH 18/20] drm/i915/fbc: s/parms/fbc_state/
>
> From: Ville Syrjälä
>
> Rename the 'params' to just fbc
On Wed, 2021-12-01 at 17:25 +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Rename the YUV byte order bits to be a bit more consistent.
Why rename bits not used? Would be better already nuke it.
Anyways up to you.
Reviewed-by: José Roberto de Souza
>
> Signed-off-by: Ville Syrjälä
>
On Wed, 2021-12-01 at 17:25 +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Polish the skl+ universal plane register defines by
> using REG_BIT() & co.
>
> The defines are also currently spread around in some
> semi-random fashion. Collect them up into one place.
>
> Signed-off-by: Ville
== Series Details ==
Series: drm/i915: Plane register cleanup
URL : https://patchwork.freedesktop.org/series/97467/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10950 -> Patchwork_21718
Summary
---
**SUCCESS**
== Series Details ==
Series: drm/i915: Skip remap_io_mapping() for non-x86 platforms (rev4)
URL : https://patchwork.freedesktop.org/series/96855/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10949_full -> Patchwork_21713_full
On Fri, Nov 19, 2021 at 06:09:31AM -0800, José Roberto de Souza wrote:
> Those two workarounds needs to be implemented in UMD, KMD only needs
> to whitelist the registers, so here only adding the workaround number
> to facilitate future workaroud table checks.
>
> Signed-off-by: José Roberto de
On Wed, 2021-12-01 at 17:25 +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Let's just stick to 32bit mmio accesses so we can get rid
> of the bare "uncore" reg access in display code. The register
> are defined as 32bit in the spec anyway.
>
> We could define a 64bit "de" variant I
On Wed, 2021-12-01 at 17:25 +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Add a few small helpers to calculate the color key register
> values. Cleans up skl_program_plane_arm() a bit.
Reviewed-by: José Roberto de Souza
>
> Signed-off-by: Ville Syrjälä
> ---
>
On Wed, 2021-12-01 at 17:25 +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> There is no real point in having this two stage
> skl_program_plane*() vs. skl_plane_update*() wrapper stuff.
> All we need to do is determine the correct color plane and
> we're done.
Reviewed-by: José Roberto de
== Series Details ==
Series: drm/i915: Re-use i915 macros for checking PTEs (rev7)
URL : https://patchwork.freedesktop.org/series/97090/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
68b441f63a8e drm/i915: Re-use i915 macros for checking PTEs
-:6: WARNING:COMMIT_LOG_LONG_LINE:
On Wed, Dec 01, 2021 at 09:17:27AM +0530, Vidya Srinivas wrote:
> PLANE_CUS_CTL has a restriction of 4096 width even though
> PLANE_SIZE and scaler size registers supports max 5120.
> Take care of this restriction in max_width.
>
> Without this patch, when 5k content is sent on HDR plane
> with
On Wed, 2021-12-01 at 17:25 +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Replace the "sizes are 0 based" stuff with just straight
> up -1 where needed. Less confusing all around.
>
> Signed-off-by: Ville Syrjälä
> ---
> drivers/gpu/drm/i915/display/intel_sprite.c | 26
On Wed, 2021-12-01 at 17:25 +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Extract the PLANE_AUX_DIST stuff into a small helper to
> dclutter skl_program_plane_arm() a bit.
Reviewed-by: José Roberto de Souza
>
> Signed-off-by: Ville Syrjälä
> ---
>
== Series Details ==
Series: drm/i915: Plane register cleanup
URL : https://patchwork.freedesktop.org/series/97467/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
2a489c8cf0ae drm/i915: Get rid of the 64bit PLANE_CC_VAL mmio
-:69: WARNING:LONG_LINE: line length of 102 exceeds
== Series Details ==
Series: drm/i915: Re-use i915 macros for checking PTEs (rev7)
URL : https://patchwork.freedesktop.org/series/97090/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10950 -> Patchwork_21717
Summary
On Tue, Nov 30, 2021 at 11:14 AM Marco Elver wrote:
>
> The non-interrupt portion of interrupt stack traces before interrupt
> entry is usually arbitrary. Therefore, saving stack traces of interrupts
> (that include entries before interrupt entry) to stack depot leads to
> unbounded stackdepot
From: Ville Syrjälä
Let's just stick to 32bit mmio accesses so we can get rid
of the bare "uncore" reg access in display code. The register
are defined as 32bit in the spec anyway.
We could define a 64bit "de" variant I suppose, but doesn't
really make much sense just for this one case, and
From: Ville Syrjälä
Bunch of cleanup around plane registers, and a bit of
reshuffling in the skl+ universal plane code.
Ville Syrjälä (14):
drm/i915: Get rid of the 64bit PLANE_CC_VAL mmio
drm/i915: Rename plane YUV order bits
drm/i915: Get rid of the "sizes are 0 based" stuff
drm/i915:
On Wed, Dec 01, 2021 at 03:57:12PM +0200, Jani Nikula wrote:
> Break the dependency on i915_drv.h.
>
> Signed-off-by: Jani Nikula
Looks reasonable.
Reviewed-by: Ville Syrjälä
> ---
> drivers/gpu/drm/i915/display/intel_display_types.h| 9 -
>
From: Ville Syrjälä
Use REG_BIT() & co. to polish the vlv/chv sprite plane registers.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/intel_sprite.c | 9 +-
drivers/gpu/drm/i915/i915_reg.h | 103
2 files changed, 70 insertions(+), 42
On Wed, 2021-12-01 at 17:25 +0200, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Rename the PLANE_CUS_CTL Y plane selection bits to actually
> say "Y plane".
>
Reviewed-by: José Roberto de Souza
> Signed-off-by: Ville Syrjälä
> ---
> drivers/gpu/drm/i915/display/intel_display.c | 8
== Series Details ==
Series: drm/i915/adl_p: Add adl-p ddc pin mapping (rev2)
URL : https://patchwork.freedesktop.org/series/97009/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10949_full -> Patchwork_21714_full
Summary
== Series Details ==
Series: series starting with [1/2] Revert "drm/i915: Implement Wa_1508744258"
(rev2)
URL : https://patchwork.freedesktop.org/series/97105/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10949_full -> Patchwork_21715_full
== Series Details ==
Series: drm/i915: Plane register cleanup
URL : https://patchwork.freedesktop.org/series/97467/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915: break intel_display_types.h dependency on i915_drv.h (rev2)
URL : https://patchwork.freedesktop.org/series/97173/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10949_full -> Patchwork_21716_full
== Series Details ==
Series: series starting with [1/2] Revert "drm/i915: Implement Wa_1508744258"
(rev2)
URL : https://patchwork.freedesktop.org/series/97105/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10949 -> Patchwork_21715
On Wed, Dec 01, 2021 at 03:57:09PM +0200, Jani Nikula wrote:
> This is far from ideal, but it reduces the i915_drv.h dependency from
> intel_display_types.h. Maybe in the future we'll need a better split.
Yeah, looks pretty temporary until we move the wm code into some
actually sensible place.
On Wed, Dec 01, 2021 at 03:57:07PM +0200, Jani Nikula wrote:
> Move a number of crtc/pipe related functions to intel_crtc.[ch], and
> un-inline to avoid looking into struct drm_i915_private guts in header
> files.
>
> Signed-off-by: Jani Nikula
Reviewed-by: Ville Syrjälä
> ---
>
On Wed, Dec 01, 2021 at 03:57:08PM +0200, Jani Nikula wrote:
> Move fb functions where they belong, and un-inline to avoid looking into
> struct drm_i915_private guts in header files.
>
> Signed-off-by: Jani Nikula
Reviewed-by: Ville Syrjälä
> ---
>
== Series Details ==
Series: Introduce Raptor Lake S (rev4)
URL : https://patchwork.freedesktop.org/series/96869/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
91c35932ece3 drm/i915/rpl-s: Add PCI IDS for Raptor Lake S
-:112: ERROR:COMPLEX_MACRO: Macros with complex values
== Series Details ==
Series: drm/i915: Skip remap_io_mapping() for non-x86 platforms (rev4)
URL : https://patchwork.freedesktop.org/series/96855/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
e1ed6afae3fa drm/i915: Skip remap_io_mapping() for non-x86 platforms
-:63:
== Series Details ==
Series: drm/i915/adl_p: Add adl-p ddc pin mapping (rev2)
URL : https://patchwork.freedesktop.org/series/97009/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10949 -> Patchwork_21714
Summary
---
== Series Details ==
Series: drm/i915: break intel_display_types.h dependency on i915_drv.h (rev2)
URL : https://patchwork.freedesktop.org/series/97173/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked
On Wed, Dec 01, 2021 at 03:57:06PM +0200, Jani Nikula wrote:
> There are only three call sites remaining for
> intel_wait_for_vblank(). Remove the function, and open code it to avoid
> new users from showing up.
>
> v2:
> - Use intel_crtc_wait_for_next_vblank() (Ville)
>
> Signed-off-by: Jani
== Series Details ==
Series: Introduce Raptor Lake S (rev4)
URL : https://patchwork.freedesktop.org/series/96869/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10949 -> Patchwork_21712
Summary
---
**SUCCESS**
No
Hi Michal,
> >> fist of all thanks for taking a look at this, I was eagerly
> >> waiting for reviewers.
> >>
> >> On Tue, Nov 30, 2021 at 01:07:30PM -0800, Lucas De Marchi wrote:
> >>> On Sun, Nov 28, 2021 at 01:09:26PM +0200, Andi Shyti wrote:
> >>> > Starting from a patch from Matt to_root_gt()
== Series Details ==
Series: drm/i915: Skip remap_io_mapping() for non-x86 platforms (rev4)
URL : https://patchwork.freedesktop.org/series/96855/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10949 -> Patchwork_21713
== Series Details ==
Series: drm/i915: break intel_display_types.h dependency on i915_drv.h (rev2)
URL : https://patchwork.freedesktop.org/series/97173/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10949 -> Patchwork_21716
On Wed, Dec 01, 2021 at 03:57:04PM +0200, Jani Nikula wrote:
> The "get" in the name implies reference counting, remove it. This also
> makes the function conform to naming style.
>
> Suggested-by: Ville Syrjälä
> Signed-off-by: Jani Nikula
Reviewed-by: Ville Syrjälä
> ---
>
On Wed, Dec 01, 2021 at 03:57:03PM +0200, Jani Nikula wrote:
> intel_wait_for_vblank() goes through a pipe to crtc lookup, while in
> most cases we already have the crtc available. Avoid the extra lookups
> by adding an intel_crtc based helper.
>
> v2:
> - Add intel_crtc_wait_for_next_vblank()
On Wed, Dec 01, 2021 at 03:57:05PM +0200, Jani Nikula wrote:
> The "get" in the name implies reference counting, remove it. This also
> makes the function conform to naming style.
>
> Suggested-by: Ville Syrjälä
> Signed-off-by: Jani Nikula
Reviewed-by: Ville Syrjälä
> ---
>
On 01/12/2021 11:15, Maarten Lankhorst wrote:
On 30-11-2021 19:38, Tvrtko Ursulin wrote:
On 30/11/2021 11:17, Maarten Lankhorst wrote:
On 30-11-2021 09:54, Tvrtko Ursulin wrote:
Hi,
On 29/11/2021 13:47, Maarten Lankhorst wrote:
New version of the series, with feedback from previous
== Series Details ==
Series: drm/i915: break intel_display_types.h dependency on i915_drv.h (rev2)
URL : https://patchwork.freedesktop.org/series/97173/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
e378d10ac676 drm/i915/display: add intel_crtc_wait_for_next_vblank() and use
== Series Details ==
Series: Introduce Raptor Lake S (rev4)
URL : https://patchwork.freedesktop.org/series/96869/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10949_full -> Patchwork_21712_full
Summary
---
From: raviteja goud talla
>From VBT, ddc pin info suggests the following mapping:
VBTDRIVER
DDI TC1->ddc_pin=3 should translate to PORT_TC1->0x9
DDI TC2->ddc_pin=4 should translate to PORT_TC2->0xa
DDI TC3->ddc_pin=5 should translate to
On 12/1/21 12:25, Christian König wrote:
Am 01.12.21 um 12:04 schrieb Thomas Hellström (Intel):
On 12/1/21 11:32, Christian König wrote:
Am 01.12.21 um 11:15 schrieb Thomas Hellström (Intel):
[SNIP]
What we could do is to avoid all this by not calling the callback
with the lock held in
== Series Details ==
Series: Introduce Raptor Lake S (rev4)
URL : https://patchwork.freedesktop.org/series/96869/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
== Series Details ==
Series: drm/i915: Skip remap_io_mapping() for non-x86 platforms (rev4)
URL : https://patchwork.freedesktop.org/series/96855/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
The "get" in the name implies reference counting, remove it. This also
makes the function conform to naming style.
Suggested-by: Ville Syrjälä
Signed-off-by: Jani Nikula
---
.../gpu/drm/i915/display/intel_atomic_plane.c| 2 +-
drivers/gpu/drm/i915/display/intel_cdclk.c | 2 +-
v2 of https://patchwork.freedesktop.org/series/97173/
BR,
Jani.
Jani Nikula (10):
drm/i915/display: add intel_crtc_wait_for_next_vblank() and use it
drm/i915/crtc: rename intel_get_crtc_for_pipe() to
intel_crtc_for_pipe()
drm/i915/crtc: rename intel_get_crtc_for_plane() to
intel_wait_for_vblank() goes through a pipe to crtc lookup, while in
most cases we already have the crtc available. Avoid the extra lookups
by adding an intel_crtc based helper.
v2:
- Add intel_crtc_wait_for_next_vblank() helper (Ville)
Signed-off-by: Jani Nikula
---
The "get" in the name implies reference counting, remove it. This also
makes the function conform to naming style.
Suggested-by: Ville Syrjälä
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display_types.h | 2 +-
drivers/gpu/drm/i915/intel_pm.c| 4 ++--
There are only three call sites remaining for
intel_wait_for_vblank(). Remove the function, and open code it to avoid
new users from showing up.
v2:
- Use intel_crtc_wait_for_next_vblank() (Ville)
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_cdclk.c | 2 +-
This is far from ideal, but it reduces the i915_drv.h dependency from
intel_display_types.h. Maybe in the future we'll need a better split.
Signed-off-by: Jani Nikula
---
.../drm/i915/display/intel_display_types.h| 1 +
drivers/gpu/drm/i915/i915_drv.h | 64 +---
It's not the ideal location, but a better alternative than
i915_drv.h. The goal is to break the intel_display_types.h to i915_drv.h
dependency.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display.h | 24
drivers/gpu/drm/i915/i915_drv.h |
Move a number of crtc/pipe related functions to intel_crtc.[ch], and
un-inline to avoid looking into struct drm_i915_private guts in header
files.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_crtc.c | 42 ++
drivers/gpu/drm/i915/display/intel_crtc.h
Move fb functions where they belong, and un-inline to avoid looking into
struct drm_i915_private guts in header files.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display_types.h | 10 --
drivers/gpu/drm/i915/display/intel_fb.c| 10 ++
On Tue, 30 Nov 2021 at 09:21, Maarten Lankhorst
wrote:
>
> We will need the lock to unbind the vma, and wait for bind to complete.
> Remove the special casing for the !ww path, and force ww locking for all.
>
> Changes since v1:
> - Pass err to for_i915_gem_ww handling for -EDEADLK handling.
>
>
On Wed, Dec 01, 2021 at 03:57:11PM +0200, Jani Nikula wrote:
> Avoid looking into the guts of struct drm_i915_private in
> headers. Again, converting an inline function to a macro is less than
> ideal, but avoids having to pull in i915_drv.h just for the to_i915()
> part.
Ugly, but gets the job
On Wed, 01 Dec 2021, Anusha Srivatsa wrote:
> Raptor Lake S(RPL-S) is a version 12
> Display, Media and Render. For all i915
> purposes it is the same as Alder Lake S (ADL-S).
>
> The series introduces it as a subplatform
> of ADL-S. The one difference is the GuC
> submission which is default on
Break the dependency on i915_drv.h.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display_types.h| 9 -
drivers/gpu/drm/i915/display/intel_dp_aux_backlight.c | 1 +
drivers/gpu/drm/i915/display/intel_dp_link_training.c | 2 +-
Avoid looking into the guts of struct drm_i915_private in
headers. Again, converting an inline function to a macro is less than
ideal, but avoids having to pull in i915_drv.h just for the to_i915()
part.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/display/intel_display_types.h | 6
On Wed, Dec 01, 2021 at 03:57:10PM +0200, Jani Nikula wrote:
> It's not the ideal location, but a better alternative than
> i915_drv.h. The goal is to break the intel_display_types.h to i915_drv.h
> dependency.
>
> Signed-off-by: Jani Nikula
Reviewed-by: Ville Syrjälä
> ---
>
From: Ville Syrjälä
Polish the skl+ universal plane register defines by
using REG_BIT() & co.
The defines are also currently spread around in some
semi-random fashion. Collect them up into one place.
Signed-off-by: Ville Syrjälä
---
.../drm/i915/display/skl_universal_plane.c| 36 ++--
From: Ville Syrjälä
Use REG_BIT() & co. for the pre-skl primary plane registers.
Also give everything a consistent namespace.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/i9xx_plane.c| 99 +
drivers/gpu/drm/i915/display/intel_display.c | 13 +--
From: Ville Syrjälä
There's no need to have separate masks for the stride bitfield
in PLANE_STRIDE for different platforms. All the extra bits
are hardcoded to zero anyway.
Also the masks we're using now don't even match the actual hardware
since the bitfield was only 10 bits on
From: Ville Syrjälä
Replace the "sizes are 0 based" stuff with just straight
up -1 where needed. Less confusing all around.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/intel_sprite.c | 26 ---
.../drm/i915/display/skl_universal_plane.c| 6 +
2
From: Ville Syrjälä
Use REG_BIT() & co. to polish the ivb+ sprite plane registers.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/intel_sprite.c | 20 +++--
drivers/gpu/drm/i915/i915_reg.h | 81 +
2 files changed, 62 insertions(+), 39
From: Ville Syrjälä
Use REG_BIT() & co. to polish the g4x+ sprite plane registers.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/intel_sprite.c | 12 ++--
drivers/gpu/drm/i915/i915_reg.h | 73 +
2 files changed, 53 insertions(+), 32 deletions(-)
From: Ville Syrjälä
Use REG_BIT() & co. to polish the cursor plane registers.
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/intel_cursor.c | 25 ---
drivers/gpu/drm/i915/display/intel_display.c | 4 +-
drivers/gpu/drm/i915/i915_reg.h | 71
From: Ville Syrjälä
Add a few small helpers to calculate the color key register
values. Cleans up skl_program_plane_arm() a bit.
Signed-off-by: Ville Syrjälä
---
.../drm/i915/display/skl_universal_plane.c| 45 +--
1 file changed, 32 insertions(+), 13 deletions(-)
diff
From: Ville Syrjälä
There is no real point in having this two stage
skl_program_plane*() vs. skl_plane_update*() wrapper stuff.
All we need to do is determine the correct color plane and
we're done.
Signed-off-by: Ville Syrjälä
---
.../drm/i915/display/skl_universal_plane.c| 53
1 - 100 of 130 matches
Mail list logo
