atch page.
LGTM.
Reviewed-by: David Weinehall
>
> Reported-by: Mike Lothian
> Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=96584
> Fixes: f7770bfd9fd2 ("drm/i915: Skip clearing the GGTT on full-ppgtt systems")
> Signed-off-by: Chris Wilson
> Cc: Davi
re was mention of a case where
incorrect EDID-information might end up being read after resume on some
Chromebooks, I'll just try to open a discussion instead.
Kind regards, David Weinehall
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
sec (+ whatever delays gets added by
> the sandybridge_pcode_read() itself). Let's change the limit to 3ms.
>
> I decided to keep 10 usec delay per iteration for now, even though
> the spec doesn't really tell us to do that.
>
> Cc: David Weinehall
> Signed-off-by: Vill
_0 and tx_blnclegsctl_4."
>
> Currently we only program tx_blnclegsctl_0. Let's do the other one as
> well.
Nice find.
Reviewed-by: David Weinehall
> Cc: David Weinehall
> Signed-off-by: Ville Syrjälä
> ---
> drivers/gpu/drm/i915/i915_
On Tue, Jul 12, 2016 at 03:59:30PM +0300, ville.syrj...@linux.intel.com wrote:
> From: Ville Syrjälä
>
> Currently we fail to program the iboost stuff for HDMI/DVI. Let's remedy
> that.
>
> Cc: David Weinehall
> Signed-off-by: Ville Syrjälä
Reviewed-by: David Weineh
On Tue, Jul 12, 2016 at 03:59:29PM +0300, ville.syrj...@linux.intel.com wrote:
> From: Ville Syrjälä
>
> Give a proper name for the SKL DDI_BUF_TRANS iboost bit.
>
> Cc: David Weinehall
> Signed-off-by: Ville Syrjälä
Reviewed-by: David Weinehall
> ---
> drivers
On Wed, Jul 13, 2016 at 01:17:40PM +0100, Chris Wilson wrote:
> On Wed, Jul 13, 2016 at 01:09:28PM +0100, Chris Wilson wrote:
> > On Wed, Jul 13, 2016 at 01:59:52PM +0200, Daniel Vetter wrote:
> > > I think the proper solution should be to make all the probing and fbdev
> > > restoring async. As so
When reading the SSEU statistics, we need to call
intel_runtime_pm_get() first, otherwise we might end up
triggering "Device suspended during HW access".
Signed-off-by: David Weinehall
---
drivers/gpu/drm/i915/i915_debugfs.c | 9 -
1 file changed, 8 insertions(+), 1 deletio
Use consistent naming for drm_minor, and always use kdev_to_drm_minor()
to convert kdev to drm_minor.
Signed-off-by: David Weinehall
---
drivers/gpu/drm/i915/i915_sysfs.c | 52 +++
1 file changed, 26 insertions(+), 26 deletions(-)
diff --git a/drivers/gpu
To improve consistency in the driver, and to pave the way for
further cleanup patches, do various bits of tidying.
David Weinehall (4):
drm/i915: Cosmetic fixes in i915_drv.h
drm/i915: Consistent struct device naming
drm/i915: Consistent drm_minor use
drm/i915: pdev cleanup
drivers/gpu
We currently have a mix of struct device *device, struct device *kdev,
and struct device *dev (the latter forcing us to refer to
struct drm_device as something else than the normal dev).
To simplify things, always use kdev when referring to struct device.
Signed-off-by: David Weinehall
Fix minor whitespace issues plus a typo.
Signed-off-by: David Weinehall
---
drivers/gpu/drm/i915/i915_drv.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 65ada5d2f88c..88c3acda7194 100644
--- a
where dev_priv would be the more obvious
choice.
Signed-off-by: David Weinehall
---
drivers/gpu/drm/i915/i915_drv.c | 58 +++--
drivers/gpu/drm/i915/i915_gem_gtt.c | 34 +++
drivers/gpu/drm/i915/i915_gem_stolen.c | 17 +-
drivers/gpu
On Tue, Aug 02, 2016 at 03:21:57PM +0300, ville.syrj...@linux.intel.com wrote:
> From: Ville Syrjälä
>
> The spec was recently fixed to have the correct iboost setting for the
> SKL Y/U DP DDI buffer translation table entry 2. Update our tables
> to match.
>
> Cc: David We
Change all IS_GEN9() by gen >= 9 (Damien)
For future reference, please use IS_GEN(dev_priv) >= 9 for expressions
such as this. My bad for not spotting this until the patch got merged.
Fret not, however, I've got a few patches that'll clean this up :)
Regards, David Weinehall
__
e
> > 1.23.
>
> From what I can remember it causes GPU Hangs depending on what you are
> running on the GPU.
Sounds like we should submit a fix to stable that makes the minimum
required version 1.26 if that's indeed the case. I wonder if this
the cause of all the hangs I've
0 [i915]
> [ 2138.372761] idr_for_each+0xa7/0x160
> [ 2138.372773] ? idr_get_next_ul+0x110/0x110
> [ 2138.372782] ? do_raw_spin_lock+0x10a/0x1d0
> [ 2138.372923] print_context_stats+0x264/0x510 [i915]
>
> Signed-off-by: Chris Wilson
Tested-by: David Weinehall
> ---
>
On Mon, Dec 18, 2017 at 08:15:30PM +0100, Maarten Lankhorst wrote:
> Op 14-11-17 om 16:17 schreef Shashank Sharma:
> > Different LSPCON vendors specify their custom methods to pass
> > AVI infoframes to the LSPCON chip, so does Parade tech.
> >
> > This patch adds functions to arrange and write AVI
On Wed, Dec 20, 2017 at 10:08:53AM +0530, Sharma, Shashank wrote:
> Thanks for the review, David.
>
> My comments, inline.
>
>
> Regards
>
> Shashank
>
>
> On 12/19/2017 3:43 PM, David Weinehall wrote:
> > On Mon, Dec 18, 2017 at 08:15:30PM +0100, Maa
m bootup. We already do relegate some configuration to
> asynchronous tasks (such as setting up the fbdev), now do the entire
> probe.
>
> References: https://bugs.freedesktop.org/show_bug.cgi?id=105622
> Signed-off-by: Chris Wilson
LGTM, and still seems to apply cleanly.
Reviewed
On Tue, Apr 24, 2018 at 03:20:16PM +0300, Jani Nikula wrote:
> Use i915.dmc_firmware_path to override default firmware for the platform
> and bypassing version checks.
>
> v2: add missing param struct member declaration (David)
>
> Tested-by: David Weinehall
> Reviewed-by:
n (David)
> >
> > Tested-by: David Weinehall
> > Reviewed-by: David Weinehall
> > Cc: Anusha Srivatsa
> > Cc: David Weinehall
> > Signed-off-by: Jani Nikula
>
> So *I* don't need this patch. Please someone tell me this is useful to
> you, and I
On Fri, Aug 05, 2016 at 11:24:12AM +0300, Jani Nikula wrote:
> On Thu, 04 Aug 2016, David Weinehall wrote:
> > On Tue, Aug 02, 2016 at 04:09:49PM +0200, Daniel Vetter wrote:
> >> On Mon, Aug 01, 2016 at 11:18:15PM +0530, Kamble, Sagar A wrote:
> >> >
fier might avoid some of these other
> > > failure modes as well, but I'm pretty sure it can't hurt at least.
> > >
> >
> > While testing this change on SKL if 2 crtc's are enabled resume from
> > suspend is 500ms longer than a single crtc resume. Ar
where dev_priv would be the more obvious
choice.
Signed-off-by: David Weinehall
---
drivers/gpu/drm/i915/i915_debugfs.c | 5 +--
drivers/gpu/drm/i915/i915_drv.c | 59 +++--
drivers/gpu/drm/i915/i915_gem_gtt.c | 4 ++-
drivers/gpu/drm/i915
inline function and
for consistency rename it kdev_to_drm_minor().
Signed-off-by: David Weinehall
---
drivers/gpu/drm/i915/i915_drv.c | 96 -
drivers/gpu/drm/i915/i915_drv.h | 4 +-
drivers/gpu/drm/i915/i915_gem_gtt.c | 6 +--
drivers/gpu/drm
ant access to to_i915(node->minor->dev) in a lot of places,
so add the node_to_i915() helper to accomodate for this.
Finally, we have quite a few cases where we get a void * pointer,
and need to cast it to drm_device *, only to run to_i915() on it.
Add cast_to_i915() to do this.
Signed-off-
than 30kB.
That's still a bit down the road though, but I've got a full
patch series to accomplish this in a fairly straightforward
manner.
This submission supersedes the previous one (from the 1st of August);
it drops one patch, and adds two others.
David Weinehall (5):
drm/i915: Co
,
and rename it kdev_to_i915_dm() (to differentiate it from
kdev_to_i915(), which goes about this in a different, non-compatible,
way).
All calls to INTEL_INFO()->gen have been replaced with
INTEL_GEN().
Signed-off-by: David Weinehall
---
drivers/gpu/drm/i915/i915_drv.c | 4 +-
drivers/gpu/
Fix minor whitespace issues plus a typo in i915_drv.h.
Signed-off-by: David Weinehall
---
drivers/gpu/drm/i915/i915_drv.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index c36d17659ebe..e71f334a46bc
On Mon, Aug 08, 2016 at 04:23:53PM +0100, Chris Wilson wrote:
> On Mon, Aug 08, 2016 at 04:19:59PM +0300, David Weinehall wrote:
> > -static inline struct drm_minor *kdev_to_drm_minor(struct device *kdev)
> > +static inline struct drm_i915_private *kdev_to_i915_dm(struct device *kde
On Mon, Aug 08, 2016 at 04:28:56PM +0100, Chris Wilson wrote:
> On Mon, Aug 08, 2016 at 04:20:01PM +0300, David Weinehall wrote:
> > @@ -136,13 +140,14 @@ static void
> > describe_obj(struct seq_file *m, struct drm_i915_gem_object *obj)
> > {
> > struct drm_i915_
,
and rename it kdev_to_i915_dm() (to differentiate it from
kdev_to_i915(), which goes about this in a different, non-compatible,
way).
All calls to INTEL_INFO()->gen have been replaced with
INTEL_GEN().
v2: Rename kdev_to_i915_dm() to kdev_minor_to_i915() (Chris)
Signed-off-by: David Weineh
27;t introduce extra dev (Chris)
Signed-off-by: David Weinehall
---
drivers/gpu/drm/i915/i915_debugfs.c | 704
drivers/gpu/drm/i915/i915_drv.c | 2 +-
drivers/gpu/drm/i915/i915_drv.h | 7 +-
3 files changed, 320 insertions(+), 393 deletions(-)
diff -
where dev_priv would be the more obvious
choice.
v2: Rebase
Signed-off-by: David Weinehall
---
drivers/gpu/drm/i915/i915_debugfs.c | 5 +--
drivers/gpu/drm/i915/i915_drv.c | 59 +++--
drivers/gpu/drm/i915/i915_gem_gtt.c | 4 ++-
drivers/gpu/drm/i915
rsion.
Signed-off-by: David Weinehall
---
drivers/gpu/drm/i915/i915_debugfs.c | 749
drivers/gpu/drm/i915/i915_drv.c | 2 +-
drivers/gpu/drm/i915/i915_drv.h | 8 +-
3 files changed, 342 insertions(+), 417 deletions(-)
diff --git a/driver
On Fri, Aug 12, 2016 at 01:03:24PM +0100, Chris Wilson wrote:
> On Fri, Aug 12, 2016 at 02:20:12PM +0300, David Weinehall wrote:
> > diff --git a/drivers/gpu/drm/i915/i915_drv.h
> > b/drivers/gpu/drm/i915/i915_drv.h
> > index d8cc52c7ddf8..3efc5af97231 100644
> >
On Fri, Aug 12, 2016 at 01:43:52PM +0100, Dave Gordon wrote:
> On 12/08/16 12:20, David Weinehall wrote:
> > drm/i915: debugfs spring cleaning
> >
> > Just like with sysfs, we do some major overhaul.
> >
> > Pass dev_priv instead of dev to all feature macros (I
good to me (well, it doesn't, I hate having things on the same
line as the case statement, but that's a personal opinion), compiles
and works as it should.
Reviewed-by: David Weinehall
> ---
> drivers/gpu/drm/i915/i915_debugfs.c | 43
> +++-
s version.
v4: Fixed a nasty bug in the earlier version (that could trigger
an oops).
Changed the code a bit so that dev_priv is passed directly
to various functions, thus removing the need for the
cast_to_i915() helper. Also did some additional cleanup.
Signed-off-by: David Weinehall
On Fri, Aug 12, 2016 at 01:43:52PM +0100, Dave Gordon wrote:
> Alternatively (noting that almost the only use we make of this drm_info_node
> is to indirect multiple times to get dev_priv), we could change what is
> stored in (struct seq_file).private to make it more convenient and/or
> efficient.
etely disable
live status check.
David Weinehall (2):
drm/i915: Skip live status if not supported
drm/i915: add module param for live_status
drivers/gpu/drm/i915/i915_params.c | 8
drivers/gpu/drm/i915/i915_params.h | 1 +
drivers/gpu/drm/i915/intel_hdmi.c
hings for newer platforms, but for older
platforms we save ~80ms / HDMI-port with no display connected
whenever intel_hdmi_detect() is called.
Signed-off-by: David Weinehall
---
drivers/gpu/drm/i915/intel_hdmi.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/
out in the cold completely, add a module parameter, defaulting
to -1 (live status detection on supported platforms, but without
the extra delays), that allows for re-enabling this hack.
Signed-off-by: David Weinehall
---
drivers/gpu/drm/i915/i915_params.c | 8
drivers/gpu/drm/i915
On Wed, Aug 17, 2016 at 09:08:58AM +0100, Chris Wilson wrote:
> On Wed, Aug 17, 2016 at 11:02:32AM +0300, David Weinehall wrote:
> > Since the workaround for buggy displays that do not reply to
> > live status detect immediately affects a rather limited set of
> > displays
"Bspec says so".
Signed-off-by: David Weinehall
---
drivers/gpu/drm/i915/intel_dp.c | 2 +-
drivers/gpu/drm/i915/intel_drv.h | 2 --
drivers/gpu/drm/i915/intel_hdmi.c | 43 +--
3 files changed, 11 insertions(+), 36 deletions(-)
diff --git a/drive
On Wed, Aug 17, 2016 at 04:43:36PM +0300, Jani Nikula wrote:
> On Wed, 17 Aug 2016, Chris Wilson wrote:
> > On Wed, Aug 17, 2016 at 03:47:48PM +0300, David Weinehall wrote:
> >> This reverts commit 237ed86c693d8a8e4db476976aeb30df4deac74b.
> >>
> >> Our c
On Thu, Aug 18, 2016 at 10:29:43AM +0300, David Weinehall wrote:
> On Wed, Aug 17, 2016 at 04:43:36PM +0300, Jani Nikula wrote:
> > On Wed, 17 Aug 2016, Chris Wilson wrote:
> > > On Wed, Aug 17, 2016 at 03:47:48PM +0300, David Weinehall wrote:
> >
rivers/gpu/drm/i915/intel_drv.h
> b/drivers/gpu/drm/i915/intel_drv.h
> index 8b3d062..374cbbd 100644
> --- a/drivers/gpu/drm/i915/intel_drv.h
> +++ b/drivers/gpu/drm/i915/intel_drv.h
> @@ -1158,9 +1158,11 @@ void intel_ddi_clock_get(struct intel_encoder *encoder,
>
e SLPC_POWER_PLAN_SOURCE(plan, source) ((plan) | ((source) << 6))
> +#define SLPC_POWER_PLAN(plan_source) ((plan_source) & 0x3F)
> +#define SLPC_POWER_SOURCE(plan_source) ((plan_source) >> 6)
> +
> +struct slpc_platform_info {
> + u8 platform_sku;
>
ev) (HAS_GUC(dev))
> +#define HAS_SLPC(dev)(INTEL_INFO(dev)->has_slpc)
>
> #define HAS_RESOURCE_STREAMER(dev) (IS_HASWELL(dev) || \
> INTEL_INFO(dev)->gen >= 8)
Reviewed-by: David Weinehall
--
/) David Weinehall /) Nor
nd/or C on vlv/chv */
s/dev/dev_priv/ in feature macros. To keep the diff down to a minimum
you can ignore the rest of them, but I certainly wouldn't mind if
you cleanup them all (and change INTEL_INFO()->gen to INTEL_GEN()).
Regards: David Weinehall
--
/) David Weinehall /) Northe
f GuC loading is disabled sanitizing SLPC option */
> if (!i915.enable_guc_loading)
> - return;
> + goto out;
> if (fw_path == NULL)
> - return;
> + goto out;
> if (*fw_path == '\0')
> - re
,
> + SLPC_EVENT_DISPLAY_MODE_CHANGE = 3,
> + SLPC_EVENT_FLIP_COMPLETE = 4,
> + SLPC_EVENT_QUERY_TASK_STATE = 5,
> + SLPC_EVENT_PARAMETER_SET = 6,
> + SLPC_EVENT_PARAMETER_UNSET = 7,
> +};
> +
> +#define SLPC_EVENT(id, argc) ((u32) (id) << 8 | (argc
+ * copy of this software and associated documentation files (the "Software"),
> + * to deal in the Software without restriction, including without limitation
> + * the rights to use, copy, modify, merge, publish, distribute, sublicense,
> + * and/or sell copies of the Software, and
; - return;
> + host2guc_slpc_shutdown(dev_priv);
> + dev_priv->guc.slpc.enabled = false;
> }
>
> void intel_slpc_enable(struct drm_i915_private *dev_priv)
> @@ -167,5 +182,6 @@ void intel_slpc_enable(struct drm_i915_private *dev_priv)
>
> void intel_slpc_res
drm_i915_private *dev_priv);
> int i915_guc_submission_enable(struct drm_i915_private *dev_priv);
> int i915_guc_wq_check_space(struct drm_i915_gem_request *rq);
> +struct i915_vma *guc_allocate_vma(struct intel_guc *guc, u32 size);
>
static unsigned long intel_pxfreq(u32 vidfreq)
> @@ -6588,7 +6606,6 @@ void intel_disable_gt_powersave(struct drm_i915_private
> *dev_priv)
> ironlake_disable_drps(dev_priv);
> }
>
> - dev_priv->rps.enabled = false;
> mutex_unlock(&dev_priv-&g
) {
> + intel_runtime_pm_get(dev_priv);
> + mutex_lock(&dev_priv->rps.hw_lock);
> + dev_priv->rps.cur_freq = gen9_read_requested_freq(dev_priv);
> + mutex_unlock(&dev_priv->rps.hw_lock);
> + intel_runtime_pm_put(dev_
sprite, pipe_name(pipe));
Mind fixing that INTEL_INFO(dev)->gen to INTEL_GEN(dev_priv)
while at it? Obviously it's not introduced by your code, but
it's something that should eventually be fixed anyway, so
while it's in near patch context and
than 30kB.
That's still a bit down the road though, but I've got a full
patch series to accomplish this in a fairly straightforward
manner.
David Weinehall (5):
drm/i915: cosmetic fixes to i915_drv.h
drm/i915: consistent struct device naming
drm/i915: i915_sysfs.c cleanup
with the inline function
kdev_to_drm_minor().
Signed-off-by: David Weinehall
---
drivers/gpu/drm/i915/i915_drv.c | 96 -
drivers/gpu/drm/i915/i915_drv.h | 4 +-
drivers/gpu/drm/i915/i915_gem_gtt.c | 6 +--
drivers/gpu/drm/i915
cannot be used here.
Unlike the version in i915_drv.h, this helper
reaches i915 through drm_minor.
v2: Rename kdev_to_i915_dm() to kdev_minor_to_i915() (Chris)
Signed-off-by: David Weinehall
---
drivers/gpu/drm/i915/i915_drv.c | 4 +-
drivers/gpu/drm/i915/i915_drv.h | 4 +-
drivers/gpu/drm
Just like with sysfs, we do some major overhaul.
Pass dev_priv instead of dev to all feature macros (IS_, HAS_,
INTEL_, etc.). This has the side effect that a bunch of functions
now get dev_priv passed instead of dev.
All calls to INTEL_INFO()->gen have been replaced with
INTEL_GEN().
We want ac
cannot be used here.
Unlike the version in i915_drv.h, this helper
reaches i915 through drm_minor.
v2: Rename kdev_to_i915_dm() to kdev_minor_to_i915() (Chris)
Signed-off-by: David Weinehall
---
drivers/gpu/drm/i915/i915_drv.c | 4 +-
drivers/gpu/drm/i915/i915_drv.h | 4 +-
drivers/gpu/drm
Fix minor whitespace issues plus a typo.
Signed-off-by: David Weinehall
---
drivers/gpu/drm/i915/i915_drv.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index e6069057eb98..2cb40026b476 100644
--- a
where dev_priv would be the more obvious
choice.
v2: Fixed one more place missing in the previous patch set
Signed-off-by: David Weinehall
---
drivers/gpu/drm/i915/i915_debugfs.c | 5 +--
drivers/gpu/drm/i915/i915_drv.c | 59 +++--
drivers/gpu/drm/i915
than 30kB.
That's still a bit down the road though, but I've got a full
patch series to accomplish this in a fairly straightforward
manner.
Resend: mailing list issues
David Weinehall (5):
drm/i915: cosmetic fixes to i915_drv.h
drm/i915: consistent struct device naming
drm/i91
with the inline function
kdev_to_drm_minor().
Signed-off-by: David Weinehall
---
drivers/gpu/drm/i915/i915_drv.c | 96 -
drivers/gpu/drm/i915/i915_drv.h | 4 +-
drivers/gpu/drm/i915/i915_gem_gtt.c | 6 +--
drivers/gpu/drm/i915
Just like with sysfs, we do some major overhaul.
Pass dev_priv instead of dev to all feature macros (IS_, HAS_,
INTEL_, etc.). This has the side effect that a bunch of functions
now get dev_priv passed instead of dev.
All calls to INTEL_INFO()->gen have been replaced with
INTEL_GEN().
We want ac
Just like with sysfs, we do some major overhaul.
Pass dev_priv instead of dev to all feature macros (IS_, HAS_,
INTEL_, etc.). This has the side effect that a bunch of functions
now get dev_priv passed instead of dev.
All calls to INTEL_INFO()->gen have been replaced with
INTEL_GEN().
We want ac
On Fri, Aug 19, 2016 at 05:45:02PM +0100, Chris Wilson wrote:
> As we do many register reads within a very short period of time, hold
> the GMBUS powerwell from start to finish.
>
> Signed-off-by: Chris Wilson
> Cc: David Weinehall
Looks good, works well.
Reviewed-by:
o.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dvo.c
> b/drivers/gpu/drm/i915/intel_dvo.c
> index 47bdf9dad0d3..b9e5a63a7c9e 100644
> --- a/drivers/gpu/drm/i915/intel_dvo.c
> +++ b/drivers/gpu/drm/i915/intel_dvo.c
> @@ -554,7 +554,6 @@
gt; GUC_CTL_VCS2_ENABLED;
>
> + if (intel_slpc_enabled())
> + params[GUC_CTL_FEATURE] |= GUC_CTL_ENABLE_SLPC;
> +
> if (i915.guc_log_level >= 0) {
> params[GUC_CTL_LOG_PARAMS] = guc->log_flags;
> params[GUC_CTL_DEBUG]
ce_info
> intel_skylake_info = {
> BDW_FEATURES,
> .is_skylake = 1,
> .gen = 9,
> + .has_slpc = 1,
> };
>
> static const struct intel_device_info intel_skylake_gt3_info = {
> BDW_FEATURES,
> .is_skylake = 1,
> .gen = 9,
> +
_training_channel_equalization(struct
> intel_dp *intel_dp)
>
> if (drm_dp_channel_eq_ok(link_status,
>intel_dp->lane_count)) {
> - channel_eq = true;
> + intel_dp->channel_eq_status
t; i915.enable_slpc = 0;
> +
> + if (IS_SKYLAKE(dev_priv) && (guc_fw->guc_fw_major_found != 6))
> + i915.enable_slpc = 0;
> }
>
> static u32 get_gttype(struct drm_i915_private *dev_priv)
Reviewed-by: David Weinehall
--
/) David Wein
Fix minor whitespace issues plus a typo.
Signed-off-by: David Weinehall
---
drivers/gpu/drm/i915/i915_drv.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index e6069057eb98..2cb40026b476 100644
--- a
where dev_priv would be the more obvious
choice.
v2: Fixed one more place missing in the previous patch set
Signed-off-by: David Weinehall
---
drivers/gpu/drm/i915/i915_debugfs.c | 5 +--
drivers/gpu/drm/i915/i915_drv.c | 59 +++--
drivers/gpu/drm/i915
-A-1 when there *is*
a display connected -- incredibly slow.
So, ironically I'd say NAK to the NAK-patch.
Kind regards, David Weinehall
> Signed-off-by: Chris Wilson
> Cc: David Weinehall
> ---
> drivers/gpu/drm/i915/intel_i2c.c | 23 +++
> 1 file changed,
The eDP backlight and panel enable/disable delays are quite
useful to know when measuring time consumed by suspend/resume,
and while the information is printed to the kernel log as debug
messages, having this information in debugfs makes things easier.
Signed-off-by: David Weinehall
---
drivers
tu all versions except 16.04.
>
> It's almost like the auto detection software in the newest version of
> X is off just enough to make my display flaky. Kind of like the old
> analog CRT TVs that were sensitive to small tweaks to the horizontal
> and vertical adjustments.
&
On Wed, Aug 24, 2016 at 08:20:31AM +0100, Chris Wilson wrote:
> When determining the initial plane config we set the same information in
> both the framebuffer (fb.modifier[0]) and in plane_config.tiling.
> Ultimately, we only need the information in the framebuffer so remove
> the redundant copy f
On Wed, Aug 24, 2016 at 09:56:29AM +0100, Chris Wilson wrote:
> On Wed, Aug 24, 2016 at 10:47:22AM +0200, David Weinehall wrote:
> > On Wed, Aug 24, 2016 at 08:20:31AM +0100, Chris Wilson wrote:
> > > When determining the initial plane config we set the same information
> to the fundament: check that the cursor ioctl following the nonblocking
>
> fundametal
While that sounds heavy enough, is it crazy to suggest fundamental
instead?
> > flip/modeset occurs within the same vblank. However, CI + debug builds
> s/However/Hopefully/
> > are fast
On Thu, Aug 25, 2016 at 11:07:01AM +0200, Maarten Lankhorst wrote:
> The mentioned commit changes intel_display_crc_init to take a dev_priv,
> but forgets to change the stub.
Doh!
>
> Cc: David Weinehall
> Fixes: 36cdd0138b7f ("drm/i915: debugfs spring cleaning")
On Thu, Aug 25, 2016 at 04:32:41PM +0100, Chris Wilson wrote:
[snip]
> diff --git a/drivers/gpu/drm/i915/i915_gem_context.c
> b/drivers/gpu/drm/i915/i915_gem_context.c
> index 3c97f0e7a003..c618bb86aeb9 100644
> --- a/drivers/gpu/drm/i915/i915_gem_context.c
> +++ b/drivers/gpu/drm/i915/i915_gem_co
On Fri, Aug 26, 2016 at 01:38:26PM +0100, Chris Wilson wrote:
> On Fri, Aug 26, 2016 at 02:29:41PM +0200, David Weinehall wrote:
> > On Thu, Aug 25, 2016 at 04:32:41PM +0100, Chris Wilson wrote:
> > [snip]
> > > diff --git a/drivers/gpu/drm/i915/i915_gem_context.c
>
Pass dev_priv to all instances of HAS_RESOURCE_STREAMER() and
HAS_CORE_RING_FREQ(), and make the macros use INTEL_GEN().
Signed-off-by: David Weinehall
---
drivers/gpu/drm/i915/i915_drv.c| 2 +-
drivers/gpu/drm/i915/i915_drv.h| 11 ++-
drivers/gpu/drm/i915
Convert all instances of INTEL_INFO(dev)->gen in intel_pm.c
to INTEL_GEN(dev_priv).
Signed-off-by: David Weinehall
---
drivers/gpu/drm/i915/intel_pm.c | 67 -
1 file changed, 40 insertions(+), 27 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_p
Convert all instances of INTEL_INFO(dev)->gen in intel_display.c
to INTEL_GEN(dev_priv).
Signed-off-by: David Weinehall
---
drivers/gpu/drm/i915/intel_display.c | 176 ++-
1 file changed, 89 insertions(+), 87 deletions(-)
diff --git a/drivers/gpu/drm/i
, non-fixed, uses.
Signed-off-by: David Weinehall
---
drivers/gpu/drm/i915/i915_drv.h | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 77a5478043e7..b544f43fc533 100644
--- a/drivers/gpu/drm/i915/i915_drv.h
+++ b/drivers
Pass dev_priv to all instances of HAS_GMCH_DISPLAY(), and make the
macro use INTEL_GEN().
Signed-off-by: David Weinehall
---
drivers/gpu/drm/i915/i915_drv.h| 5 +++--
drivers/gpu/drm/i915/intel_color.c | 11 +--
drivers/gpu/drm/i915/intel_display.c | 12
Pass dev_priv to all instances of INTEL_GEN(), and make the macro
use the new non-polymorph version of INTEL_INFO().
Signed-off-by: David Weinehall
---
drivers/gpu/drm/i915/i915_drv.h | 2 +-
drivers/gpu/drm/i915/i915_gem_render_state.c | 3 +--
drivers/gpu/drm/i915/intel_display.c
Pass dev_priv to all instances of IS_MOBILE(), convert the
only user of INTEL_INFO()->is_mobile to use IS_MOBILE(),
and make the macro use the new non-polymorph version of INTEL_INFO().
Signed-off-by: David Weinehall
---
drivers/gpu/drm/i915/i915_drv.h | 4 ++--
drivers/gpu/drm/i
Final batch of INTEL_INFO()->gen to INTEL_GEN().
Signed-off-by: David Weinehall
---
drivers/gpu/drm/i915/i915_drv.c | 2 +-
drivers/gpu/drm/i915/i915_drv.h | 21 +++--
drivers/gpu/drm/i915/i915_gpu_error.c | 4 ++--
drivers/gpu/drm/i915/intel_dp.c |
Pass dev_priv to all instances of HAS_POOLED_EU(), as well as
to INTEL_INFO()->min_eu_in_pool, and make the macro
use the new non-polymorph version of INTEL_INFO().
Signed-off-by: David Weinehall
---
drivers/gpu/drm/i915/i915_drv.c | 4 ++--
drivers/gpu/drm/i915/i915_dr
lid majority
against it in terms of established use.
David Weinehall (12):
drm/i915: Transitional, non-polymorph, macros
drm/i915: IS_MOBILE() fixes
drm/i915: HAS_POOLED_EU() fixes
drm/i915: INTEL_GEN() fixes, part 1
drm/i915: INTEL_GEN() fixes, part 2
drm/i915: INTEL_GEN() fixes
Convert all instances of INTEL_INFO(dev_priv)->gen to INTEL_GEN(dev_priv).
Signed-off-by: David Weinehall
---
drivers/gpu/drm/i915/i915_drv.c| 2 +-
drivers/gpu/drm/i915/i915_gem.c| 10 +-
drivers/gpu/drm/i915/i915_gem_execbuffer.c | 6 +++---
drivers/gpu/
Modify i915_vgacntrl_reg() to take dev_priv instead of dev,
and replace its call to INTEL_INFO(dev)->gen with INTEL_GEN(dev_priv).
Signed-off-by: David Weinehall
---
drivers/gpu/drm/i915/i915_drv.h | 6 +++---
drivers/gpu/drm/i915/intel_display.c | 4 ++--
2 files changed, 5 inserti
1 - 100 of 405 matches
Mail list logo
