Travis Swicegood wrote:
On Jun 19, 2008, at 9:03 AM, Steph Fox wrote:
There's nothing wrong with that approach. I'm trying to find
something that addresses the problem (i.e., "how can I not run tests
that are going to take a long time to run?"), while providing enough
flexibility to ans
Steph Fox wrote:
So 'skipif' suits my needs better, but not yours. I'll add both.
Thanks Steph.
Chris
--
Christopher Jones, Oracle
Email: [EMAIL PROTECTED]Tel: +1 650 506 8630
Blog: http://blogs.oracle.com/opal/ Free PHP Book: http://tinyurl.com/f8jad
--
PHP Internals - PHP Runtime
On Jun 19, 2008, at 9:03 AM, Steph Fox wrote:
There's nothing wrong with that approach. I'm trying to find
something that addresses the problem (i.e., "how can I not run
tests that are going to take a long time to run?"), while
providing enough flexibility to answer other problems (i.
Hi Chris,
If we make the timeout value adjustable, you can set it to a low value
so your slow tests are quickly aborted, and I can set it to a high
value so my tests are run.
It's easily enough done, it's just a separate issue.
I can easily put a workaround in the Windows version of select.c
Steph Fox wrote:
> So what was wrong with the simple skipif and env var approach again?
The problem is it only skips the test!
I'd like my slow tests to run (this generally occurs when I use a very
remote DB). I end up manually increasing the timeout in stream_select()
in run-tests.sh. This
There's nothing wrong with that approach. I'm trying to find something
that addresses the problem (i.e., "how can I not run tests that are going
to take a long time to run?"), while providing enough flexibility to
answer other problems (i.e., "how can I skip X tests that I don't care
abo
On Jun 19, 2008, at 8:26 AM, Steph Fox wrote:
I can add this to PHPT - it uses a timeout based on reading the
open proc.
That's what the current run-tests does too. The problem is it isn't
reliable cross-platform - we don't have any control over the select
() function used by stream_select(
uhm, file a bug report then. It was supposed to work..
There are some open on this already.
Also - Windows is the only environment where we actually have control over
whether it works or not. Everything else relies on a system call.
- Steph
--
PHP Internals - PHP Runtime Development Ma
I can add this to PHPT - it uses a timeout based on reading the open
proc.
That's what the current run-tests does too. The problem is it isn't reliable
cross-platform - we don't have any control over the select() function used
by stream_select() except under Windows, where it doesn't work (I
Yes, it is. Check the system_with_timeout() function in the run-tests.php
script.
There you've the timeout hardcoded ('$leak_check ? 300 : 60'). You would
just need to make it configurable by some environment var.
I already tried hard-coding both tv_sec and tv_usec to 0 and it makes no
differe
On Jun 19, 2008, at 7:07 AM, Steph Fox wrote:
Yes, it is. Check the system_with_timeout() function in the run-
tests.php script.
There you've the timeout hardcoded ('$leak_check ? 300 : 60'). You
would just need to make it configurable by some environment var.
I already tried hard-coding b
Yes, it is. Check the system_with_timeout() function in the run-tests.php
script.
There you've the timeout hardcoded ('$leak_check ? 300 : 60'). You would
just need to make it configurable by some environment var.
I already tried hard-coding both tv_sec and tv_usec to 0 and it makes no
diffe
I'd prefer a run-tests.php option that sets the timeout limit in seconds.
Nice idea, but I'm not sure it's achievable under CLI.
Yes, it is. Check the system_with_timeout() function in the run-tests.php
script.
There you've the timeout hardcoded ('$leak_check ? 300 : 60'). You would
just nee
Hey Stas,
+$environment['EXEMPT_SLOW_TESTS'] = 1;
Maybe "SKIP_SLOW_TESTS"? If it's checked in skip section... :)
Otherwise - good idea!
You can tell I'm reading my mail backwards today...
I used 'EXEMPT' because the option is 'x' and I wanted it to be easy to
remember.
Hi Travis,
All it does is adds another option, -x, to run-tests.php. This sets an
environmental variable which can then be checked for in the SKIPIF
section of very slow-running tests.
How do you specify that "test A is slow"? Is there a certain skipif
message you include, or...?
Yep.
I'd prefer a run-tests.php option that sets the timeout limit in seconds.
Nice idea, but I'm not sure it's achievable under CLI.
- Steph
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit: http://www.php.net/unsub.php
Steph Fox wrote:
Hi again,
I'm using this locally because two of our tests take over 10 minutes
each to run on my laptop, and I run the relevant bits of test suite
every time I make a change.
All it does is adds another option, -x, to run-tests.php. This sets an
environmental variable whi
Hey Steph;
On Jun 18, 2008, at 3:37 PM, Steph Fox wrote:
I'm using this locally because two of our tests take over 10
minutes each to run on my laptop, and I run the relevant bits of
test suite every time I make a change.
All it does is adds another option, -x, to run-tests.php. This sets
Hi!
+$environment['EXEMPT_SLOW_TESTS'] = 1;
Maybe "SKIP_SLOW_TESTS"? If it's checked in skip section... :)
Otherwise - good idea!
--
Stanislav Malyshev, Zend Software Architect
[EMAIL PROTECTED] http://www.zend.com/
(408)253-8829 MSN: [EMAIL PROTECTED]
--
PHP Internals
Hi again,
I'm using this locally because two of our tests take over 10 minutes each to
run on my laptop, and I run the relevant bits of test suite every time I
make a change.
All it does is adds another option, -x, to run-tests.php. This sets an
environmental variable which can then be check
20 matches
Mail list logo
