Re: [PHP-DEV] BC break in 5.3.2 - 5.3.3 with parent:: and __call/__callStatic

2010-11-03 Thread jvlad
Until version 5.3.2 this worked fine, starting from version 5.3.3 parent::getFoo() calls __callStatic() instead of __call(). This is a really bad BC change which i thought you decided to accept only in minor versions change and not patch-level versions change. Anyway, I would even be

Re: [PHP-DEV] BC break in 5.3.2 - 5.3.3 with parent:: and __call/__callStatic

2010-11-02 Thread Felipe Pena
2010/10/24 Giovanni Giacobbi giova...@giacobbi.net Greetings, in reference to bug #52713 i'd like to inquire you about this decision which actually broke my codebase in different parts. The situation is this one: class ActiveRecord { public function __call($method, $args) { if

Re: [PHP-DEV] BC break in 5.3.2 - 5.3.3 with parent:: and __call/__callStatic

2010-10-26 Thread Daniel Convissor
On Mon, Oct 25, 2010 at 12:56:28AM +0200, Etienne Kneuss wrote: Exactly, if Bar::getFoo is not called statically, parent::getFoo() will not be a static call, it should not get through __callStatic. That logic sounds good. Unfortunately, things aren't behaving that way: ?php // Rework of

Re: [PHP-DEV] BC break in 5.3.2 - 5.3.3 with parent:: and __call/__callStatic

2010-10-26 Thread Richard Quadling
On 26 October 2010 15:48, Daniel Convissor dani...@analysisandsolutions.com wrote: On Mon, Oct 25, 2010 at 12:56:28AM +0200, Etienne Kneuss wrote: Exactly, if Bar::getFoo is not called statically, parent::getFoo() will not be a static call, it should not get through __callStatic. That logic

[PHP-DEV] BC break in 5.3.2 - 5.3.3 with parent:: and __call/__callStatic

2010-10-24 Thread Giovanni Giacobbi
Greetings, in reference to bug #52713 i'd like to inquire you about this decision which actually broke my codebase in different parts. The situation is this one: class ActiveRecord { public function __call($method, $args) { if ($method == getFoo) { // implement some default

Re: [PHP-DEV] BC break in 5.3.2 - 5.3.3 with parent:: and __call/__callStatic

2010-10-24 Thread Stas Malyshev
Hi! class Bar { // override getFoo() to add some specific behaviour public function getFoo() { // do the specific stuff parent::getFoo(); } } I think you meant Bar to extend ActiveRecord? But anyway, I think that this particular call should be done through __call, not

Re: [PHP-DEV] BC break in 5.3.2 - 5.3.3 with parent:: and __call/__callStatic

2010-10-24 Thread Etienne Kneuss
On Oct 24 15:41:44, Stas Malyshev wrote: Hi! class Bar { // override getFoo() to add some specific behaviour public function getFoo() { // do the specific stuff parent::getFoo(); } } I think you meant Bar to extend ActiveRecord? But anyway, I think that this

Re: [PHP-DEV] BC break in 5.3.2 - 5.3.3 with parent:: and __call/__callStatic

2010-10-24 Thread Etienne Kneuss
On Oct 25 0:56:28, Etienne Kneuss wrote: On Oct 24 15:41:44, Stas Malyshev wrote: Hi! class Bar { // override getFoo() to add some specific behaviour public function getFoo() { // do the specific stuff parent::getFoo(); } } I think you meant Bar to

Re: [PHP-DEV] BC break in 5.3.2 - 5.3.3 with parent:: and __call/__callStatic

2010-10-24 Thread Giovanni Giacobbi
On Mon, Oct 25, 2010 at 01:04:00AM +0200, Etienne Kneuss wrote: On Oct 25 0:56:28, Etienne Kneuss wrote: I think you meant Bar to extend ActiveRecord? But anyway, I think that this particular call should be done through __call, not __callStatic, since it's basically non-static call.