On 2023/02/22 22:09, Peter Kokot wrote:
> Most likely, some of those three unset lines could be removed today,
> yes, but I can't be sure. If removal would fix some bug, then probably
> it is time to remove them and see where things break afterwards.
https://github.com/php/php-src/pull/10678
--
On 2023/02/22 22:09, Peter Kokot wrote:
> If removal would fix some bug, then probably it is time to remove
> them and see where things break afterwards.
Observe the output of PHP's "./configure --help":
"Some influential environment variables:
[...]
LDFLAGS linker flags, e.g. -L if yo
On 2023/02/23 05:53, Stanislav Malyshev wrote:
> It could be these changes do not make sense. It also could be they are
> necessary for the build to work on one of dozens of systems, distros and
> tools combinations PHP is being built on. Unless you have tested on all of
> them, I'd advise caution
Hi!
There seems to be another unset done to this change here:
https://github.com/php/php-src/commit/c4d84aa33390045cd4ff542719a0f79cff52fb7c
which fixed some bugs related to linker errors and duplicate symbols.
Smells like people doing random things until some bug disappears...
and no commit m
On 2023/02/22 22:09, Peter Kokot wrote:
> >From my quick check, the unset is initially done to move the currently
> set flags to extra flags variable and clean the variable for further
> additions so there are no duplicate ones or something like that.
> https://github.com/php/php-src/commit/941757
On Wed, 22 Feb 2023 at 14:14, Max Kellermann wrote:
>
> On 2023/02/22 13:45, Max Kellermann wrote:
> > 13 years ago, there was commit
> > https://github.com/php/php-src/commit/477649cd3f09 which attempted to
> > fix this, but was reverted on the same day by commit
> > https://github.com/php/php-s
On 2023/02/22 13:45, Max Kellermann wrote:
> 13 years ago, there was commit
> https://github.com/php/php-src/commit/477649cd3f09 which attempted to
> fix this, but was reverted on the same day by commit
> https://github.com/php/php-src/commit/16450418b188 with just commit
> message "Revert bad pat
Hi,
while working on https://github.com/php/php-src/pull/10663 I saw CI
failures because after that PR, the sanitizer flags were missing in
the linker call; they were only present in CFLAGS and LDFLAGS but not
in CXXFLAGS.
That is because ".cirrus.yml" sets LDFLAGS, but that value never gets
used
