Re: [PHP-DEV] Preparing for PHP 8.0.0 GA

2020-11-24 Thread Dmitry Stogov
On Tue, Nov 24, 2020 at 6:14 PM Sara Golemon wrote: > On Tue, Nov 24, 2020 at 8:55 AM Sara Golemon wrote: > >> Given that the JIT is enabled by default, I'm tempted to add another RC >> and delay the release. >> >> > As Niki just helpfully pointed out; My understanding of the JIT's setting > on

Re: [PHP-DEV] Preparing for PHP 8.0.0 GA

2020-11-24 Thread Sara Golemon
On Tue, Nov 24, 2020 at 10:27 AM Dmitry Stogov wrote: > I think, new RC is not necessary. > These commits only affect JIT. They fix the recently found problems and don't show any degradation. > Good enough for me. I'll pull 'em up and cut in the next couple hours. -Sara

Re: [PHP-DEV] Preparing for PHP 8.0.0 GA

2020-11-24 Thread Dmitry Stogov
Hi Sara, On Tue, Nov 24, 2020 at 5:56 PM Sara Golemon wrote: > On Tue, Nov 24, 2020 at 12:35 AM Dmitry Stogov > wrote: > >> I finally fixed all the known JIT related issues and made the PHP-8.0 >> build "green". >> >> >>

Re: [PHP-DEV] Preparing for PHP 8.0.0 GA

2020-11-24 Thread Sara Golemon
On Tue, Nov 24, 2020 at 8:55 AM Sara Golemon wrote: > Given that the JIT is enabled by default, I'm tempted to add another RC > and delay the release. > > As Niki just helpfully pointed out; My understanding of the JIT's setting on 8.0 is wrong. It's "on", but with a 0-sized buffer, so it's

Re: [PHP-DEV] Preparing for PHP 8.0.0 GA

2020-11-24 Thread Sara Golemon
On Tue, Nov 24, 2020 at 12:35 AM Dmitry Stogov wrote: > I finally fixed all the known JIT related issues and made the PHP-8.0 > build "green". > > > https://dev.azure.com/phpazuredevops/PHP/_build/results?buildId=13088=results > > Please, cherry-pick the following 5 commits into PHP-8.0.0. > >

Re: [PHP-DEV] Preparing for PHP 8.0.0 GA

2020-11-24 Thread Christoph M. Becker
On 24.11.2020 at 03:40, Christopher Jones wrote: > On 20/11/20 1:50 am, Sara Golemon wrote: > >> I've just cut the release branch for PHP-8.0.0 final which will be >> released >> in one week on 26 Nov.  Minor bug fixes can continue to be merged via the >> PHP-8.0 branch for inclusion in 8.0.1,

Re: [PHP-DEV] Preparing for PHP 8.0.0 GA

2020-11-23 Thread Dmitry Stogov
Hi, I finally fixed all the known JIT related issues and made the PHP-8.0 build "green". https://dev.azure.com/phpazuredevops/PHP/_build/results?buildId=13088=results Please, cherry-pick the following 5 commits into PHP-8.0.0. c8df28d276c25c6f5ad0f1ab2727804b32be8cfe

Re: [PHP-DEV] Preparing for PHP 8.0.0 GA

2020-11-23 Thread Christopher Jones
On 20/11/20 1:50 am, Sara Golemon wrote: I've just cut the release branch for PHP-8.0.0 final which will be released in one week on 26 Nov. Minor bug fixes can continue to be merged via the PHP-8.0 branch for inclusion in 8.0.1, but 8.0.0 will be precisely what 8.0.0RC5 contained unless

Re: [PHP-DEV] Preparing for PHP 8.0.0 GA

2020-11-19 Thread Christoph M. Becker
On 19.11.2020 at 17:52, Côme Chilliet wrote: > Le Thu, 19 Nov 2020 08:50:04 -0600, > Sara Golemon a écrit : > >> Lastly, there are likely still gaps in the documentation of new features, >> so please take a moment away from code to make the manual better. > > With the huge changes on parameter

Re: [PHP-DEV] Preparing for PHP 8.0.0 GA

2020-11-19 Thread Côme Chilliet
Le Thu, 19 Nov 2020 08:50:04 -0600, Sara Golemon a écrit : > Lastly, there are likely still gaps in the documentation of new features, > so please take a moment away from code to make the manual better. With the huge changes on parameter names in PHP-8, is there any easy automated process to

[PHP-DEV] Preparing for PHP 8.0.0 GA

2020-11-19 Thread Sara Golemon
I've just cut the release branch for PHP-8.0.0 final which will be released in one week on 26 Nov. Minor bug fixes can continue to be merged via the PHP-8.0 branch for inclusion in 8.0.1, but 8.0.0 will be precisely what 8.0.0RC5 contained unless serious issues are encountered. If you feel you