Re: [PHP-DEV] Re: Fixing insane session_start() behaviors

Hi Stas, On Wed, Oct 19, 2016 at 8:57 PM, Yasuo Ohgaki wrote: > Only valid use case is > > ob_start(); > session_start(); > session_set_cache_limiter('public'); // <== Call this between > session_start() and session_regenerate_id() > session_regenerate_id(); > ?> > > Other

Re: [PHP-DEV] Re: Fixing insane session_start() behaviors

Hi Davey, On Wed, Oct 19, 2016 at 6:06 PM, Davey Shafik wrote: > Yasuo, assuming "partial fix" doesn't mean "broken fix" but instead "it > doesn't do everything I planned" then I do not want this in 7.1. As others > have pointed out, it's not a small change and sessions are a

Re: [PHP-DEV] Re: Fixing insane session_start() behaviors

Hi Stas, On Wed, Oct 19, 2016 at 3:08 PM, Stanislav Malyshev wrote: >> I pushed patch fixes number of nonsense/inconsistent session function >> behaviors. The additional patch is pushed so that it's easy to cherry >> pick minimum fixes. The last push is the additional fixes.

Re: [PHP-DEV] Re: Fixing insane session_start() behaviors

On Tue, Oct 18, 2016 at 11:08 PM, Stanislav Malyshev wrote: > Hi! > > > I pushed patch fixes number of nonsense/inconsistent session function > > behaviors. The additional patch is pushed so that it's easy to cherry > > pick minimum fixes. The last push is the additional

Re: [PHP-DEV] Re: Fixing insane session_start() behaviors

Hi! > I pushed patch fixes number of nonsense/inconsistent session function > behaviors. The additional patch is pushed so that it's easy to cherry > pick minimum fixes. The last push is the additional fixes. These changes look like a reasonable cleanup. I'm not a big fan of

Re: [PHP-DEV] Re: Fixing insane session_start() behaviors

Hi Yasuo, On Mon, Oct 17, 2016 at 4:47 PM, Yasuo Ohgaki wrote: > Hi Davey, > > On Sun, Oct 16, 2016 at 6:08 PM, Yasuo Ohgaki wrote: >> >> I was planning to fix session_start() behaviors by PHP 7.1, but I >> forgot to do this completely. Partial fix is

[PHP-DEV] Re: Fixing insane session_start() behaviors

Hi Davey, On Sun, Oct 16, 2016 at 6:08 PM, Yasuo Ohgaki wrote: > > I was planning to fix session_start() behaviors by PHP 7.1, but I > forgot to do this completely. Partial fix is merged currently. > > Following PR makes session_start() return FALSE when it cannot start >

[PHP-DEV] Re: Fixing insane session_start() behaviors

Hi Davey, On Sun, Oct 16, 2016 at 6:08 PM, Yasuo Ohgaki wrote: > > I was planning to fix session_start() behaviors by PHP 7.1, but I > forgot to do this completely. Partial fix is merged currently. > > Following PR makes session_start() return FALSE when it cannot start >