Re: [PHP-DEV] Return value of convert_to_*()

2007-01-03 Thread Andrei Zmievski
Only in cases where people blindly pass objects where strings are expected. It won't break anything for those objects that know how to convert themselves. -Andrei On Dec 27, 2006, at 1:23 PM, Antony Dovgal wrote: On 12/28/2006 12:12 AM, Andrei Zmievski wrote: It's perfectly legal to do it

Re: [PHP-DEV] Return value of convert_to_*()

2007-01-03 Thread Antony Dovgal
On 01/03/2007 09:51 PM, Andrei Zmievski wrote: Only in cases where people blindly pass objects where strings are expected. It won't break anything for those objects that know how to convert themselves. It still see no reasons for this particular change in behavior. It was allowed in the past

Re: [PHP-DEV] Return value of convert_to_*()

2007-01-03 Thread Andrei Zmievski
So you're okay with substr($obj, 0, 3) giving you Obj ?? To me, that seems broken, regardless of whether we had it working in the past. -Andrei On Jan 3, 2007, at 10:58 AM, Antony Dovgal wrote: On 01/03/2007 09:51 PM, Andrei Zmievski wrote: Only in cases where people blindly pass objects

Re: [PHP-DEV] Return value of convert_to_*()

2007-01-03 Thread Marcus Boerger
Hello Andrei, we had a long decision about this issue already and decided that the only reason for Object... in 5.0 and 5.1 was the lack of ability to fix __toString() prior to 5.2. The current 5.2/6.0 behavior is what we wanted in the first place and hence correct, or do we need to restart the

Re: [PHP-DEV] Return value of convert_to_*()

2007-01-03 Thread Antony Dovgal
On 01/03/2007 10:17 PM, Andrei Zmievski wrote: So you're okay with substr($obj, 0, 3) giving you Obj ?? To me, that seems broken, regardless of whether we had it working in the past. I can name you quite a number of things which seem broken to me (or aesthetically wrong), but I don't think

Re: [PHP-DEV] Return value of convert_to_*()

2007-01-03 Thread Andrei Zmievski
On Jan 3, 2007, at 12:00 PM, Marcus Boerger wrote: Hello Andrei, we had a long decision about this issue already and decided that the only reason for Object... in 5.0 and 5.1 was the lack of ability to fix __toString() prior to 5.2. The current 5.2/6.0 behavior is what we wanted in the

[PHP-DEV] Return value of convert_to_*()

2006-12-27 Thread Andrei Zmievski
Antony and I just had a spirited discussion on IRC about his latest patches to convert_to_unicode() and convert_to_string(). The specific troublesome point was conversion of IS_OBJECT type. His point was that since all we care about is the end result, then the function should return SUCCESS

Re: [PHP-DEV] Return value of convert_to_*()

2006-12-27 Thread Antony Dovgal
On 12/27/2006 11:02 PM, Andrei Zmievski wrote: Antony and I just had a spirited discussion on IRC about his latest patches to convert_to_unicode() and convert_to_string(). The specific troublesome point was conversion of IS_OBJECT type. His point was that since all we care about is the end

Re: [PHP-DEV] Return value of convert_to_*()

2006-12-27 Thread Andrei Zmievski
Why do you want that? Bad conversion is failed conversion, that's the case when you get E_RECOVERABLE_ERROR and it bails out. Yes, I want that function to return FAILURE when we issue E_RECOVERABLE_ERROR. Exactly what I was talking about. One such place is zend_parse_parameters(). If

Re: [PHP-DEV] Return value of convert_to_*()

2006-12-27 Thread Antony Dovgal
On 12/28/2006 12:12 AM, Andrei Zmievski wrote: It's perfectly legal to do it in 5.2 and I don't see why PHP6 is different. IMO it's same as changing the E_RECOVERABLE to E_ERROR - users won't have any way to workaround it, even though this was the original intention of E_RECOVERABLE. It