Steph Fox wrote:
OK, so there are some things that should maybe 'just happen' here, and
also when 'S' is used:
PHP_NAMED_FUNCTION(php_if_crc32)
{
char *p;
int len, nr;
php_uint32 crcinit = 0;
register php_uint32 crc;
if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, S, p, nr) ==
FAILURE)
Hi Andrei,
I see where you're coming from over the (binary)|(string) issue, just trying
to find some way that would preserve a little more back compatibility.
UG(ascii_conv) is for the format string, not the arguments. The warning is
thrown by this code:
Hi,
On Sat, 2008-05-24 at 13:55 +0100, Steph Fox wrote:
Warning: crc32() expects parameter 1 to be strictly a binary string, Unicode
string given in ...
Surely if a function's *expecting* a binary string it should do a silent
conversion, and only throw a warning if the conversion fails? I
On 21.05.2008 17:51, Antony Dovgal wrote:
On 21.05.2008 17:50, Steph Fox wrote:
Not fix the streams issue?
Felipe has taken care of that issue, so now we have only one uber-major
issue left.
Your patch? Or the changed error message?
Yes, I mean that problem with storing string/Unicode
This patch fixes it:
http://dev.daylessday.org/diff/shell_exec_unicode.diff
Coolth :)
Still, I see no point to fix something until we remove the switch.
Let's give Scott a chance to get home from php|tek and present his patch to
do just that.
- Steph (loin-girder extraordinaire)
--
UG(ascii_conv) is for the format string, not the arguments. The warning
is thrown by this code:
convert_to_string_ex(argv[currentarg]);
It should check the arg type and return with a warning if it's Unicode.
-Andrei
Steph Fox wrote:
It does - 'UG(ascii_conv)' - but sometimes there's a
Hey Andrei,
UG(unicode) checks are still secondary I think - they don't prevent us
from doing tests and moving forward, although cleaning them up would be
nice.
Cleaning them up would make it possible to find and fix the bugs we already
know are there ;) There don't seem to be too many, but
Steph Fox wrote:
What concerns me at this point is that we could and should be telling
PHP users how to future-proof their code during the move from PHP 4 to
PHP 5. If we can get a fix on that now and get word out, we'll have made
their future migration path *much* smoother.
As far as I can
On 21.05.2008 00:21, Steph Fox wrote:
I think the test script and ZE problems should be resolved first...
And to do that we need to drop the Unicode Switch =)
plus I just discovered that my php.ini isn't being found when I run commandline
tests (e.g. php -r var_dump(strcasecmp()); doesn't
Hey Tony,
First off, thanks for caring :)
And to do that we need to drop the Unicode Switch =)
Not fix the streams issue?
I committed a fix for this one a minute ago.
Thanks!
The patch is as easy as this:
http://dev.daylessday.org/diff/fix_unicode_function_names.diff
This is the
On 21.05.2008 15:12, Steph Fox wrote:
Hey Tony,
First off, thanks for caring :)
And to do that we need to drop the Unicode Switch =)
Not fix the streams issue?
That, too =)
--
Wbr,
Antony Dovgal
--
PHP Internals - PHP Runtime Development Mailing List
To unsubscribe, visit:
On 21.05.2008 15:12, Steph Fox wrote:
Hey Tony,
First off, thanks for caring :)
And to do that we need to drop the Unicode Switch =)
Not fix the streams issue?
Felipe has taken care of that issue, so now we have only one uber-major issue
left.
--
Wbr,
Antony Dovgal
--
PHP Internals -
Not fix the streams issue?
Felipe has taken care of that issue, so now we have only one uber-major
issue left.
Your patch? Or the changed error message?
FWIW the --EXPECT-- sections on those tests are different in 5_3 and would
pass, so maybe they should just match those?
- Steph
--
On 21.05.2008 17:50, Steph Fox wrote:
Not fix the streams issue?
Felipe has taken care of that issue, so now we have only one uber-major
issue left.
Your patch? Or the changed error message?
Yes, I mean that problem with storing string/Unicode function names.
That patch seems to be no
Yes, I mean that problem with storing string/Unicode function names.
That patch seems to be no good, run-tests.php doesn't work after I apply
it (some functions are not found).
shrug / it'll be a lot easier to see what's going on if/when the
UG(unicode) if'n'butting goes. There's obviously a
On 21.05.2008 17:58, Steph Fox wrote:
Yes, I mean that problem with storing string/Unicode function names.
That patch seems to be no good, run-tests.php doesn't work after I apply
it (some functions are not found).
shrug / it'll be a lot easier to see what's going on if/when the
UG(unicode)
Nothing premature about it. It was time.
UG(unicode) checks are still secondary I think - they don't prevent us
from doing tests and moving forward, although cleaning them up would be
nice.
pack() should take binary strings only, methinks.
-Andrei
Steph Fox wrote:
I would've hoped that PHP
to expect.
Andi
-Original Message-
From: Andrei Zmievski [mailto:[EMAIL PROTECTED]
Sent: Monday, May 19, 2008 2:54 PM
To: Lukas Kahwe Smith
Cc: Cristian Rodríguez; Steph Fox; internals
Subject: Re: [PHP-DEV] Unicode progress [Was: unicode.semantics ad infinitum]
Yes, but we should run some sort
Hi Andi, et. al,
Am Montag, den 19.05.2008, 23:03 -0700 schrieb Andi Gutmans:
The idea here was to find volunteers who'd try and run their apps and
some standard apps on this so we can figure out what the migration
path looks like. That'd also give us the necessary data point to make
a
On 20.05.2008 01:54, Andrei Zmievski wrote:
Yes, but we should run some sort of test suite and see what exactly breaks
with unicode strings as the default ones.
Right, but in order to do this we need to add filtered streams support to
stream_select().
At the moment all tests in HEAD fail
At the moment all tests in HEAD fail because of this:
Warning: stream_select(): cannot cast a filtered stream on this system in
/local/qa/head/run-tests.php on line 938
Warning: stream_select(): No stream arrays were passed in
/local/qa/head/run-tests.php on line 938
Why not just use the 5_3
On 20.05.2008 17:49, Steph Fox wrote:
At the moment all tests in HEAD fail because of this:
Warning: stream_select(): cannot cast a filtered stream on this system in
/local/qa/head/run-tests.php on line 938
Warning: stream_select(): No stream arrays were passed in
/local/qa/head/run-tests.php
run-tests.php in 5_3 uses stream_select(), too.
And stream_select() in HEAD doesn't work because Unicode is now enabled by
default.
Bizarre. I ran 400-odd tests with run-tests from 5_3 and never saw that
error...
- Steph
--
Wbr, Antony Dovgal
--
PHP Internals - PHP Runtime
run-tests.php in 5_3 uses stream_select(), too.
And stream_select() in HEAD doesn't work because Unicode is now enabled
by default.
Bizarre. I ran 400-odd tests with run-tests from 5_3 and never saw that
error...
Ah, I have it. My TEST_PHP_EXECUTABLE isn't the same as the one running the
Andi Gutmans wrote:
The idea here was to find volunteers who'd try and run their apps and
some standard apps on this so we can figure out what the migration
path looks like. That'd also give us the necessary data point to make
a decision on default for strings. I think none of us right now
Edward Z. Yang wrote:
Also, as stands it appears most non-trivial applications are fairly
broken. Those issues need to be resolved first, before we toss Unicode
onto the pile.
I retract this statement; I didn't realize we had already turned on
Unicode semantics.
--
Edward Z. Yang
Hi Edward,
As I a PHP developer on Windows, I pay very close attention to
development work on PHP and regularly test my code against PHP 5.3,
hand-built from the CVS. Nearly all of the PECL extensions are broken on
Windows for PHP 6. The http extension has a very nasty problem: its
fatal error
Done. See latest commit: switch is removed and mode is defaulted to On.
-Andrei
On Wed, May 14, 2008 at 5:59 AM, Steph Fox [EMAIL PROTECTED] wrote:
Hi all,
Is there any chance of getting the unicode.semantics issue sorted soon?
http://www.php.net/unsub.php
Andrei Zmievski escribió:
Done. See latest commit: switch is removed and mode is defaulted to On.
Thank you , VERY MUCH Andrei, now we can **really** move forward..
--
Progress is possible only if we train ourselves to think about programs
without thinking of them as pieces of executable
On 19.05.2008, at 23:34, Cristian Rodríguez wrote:
Andrei Zmievski escribió:
Done. See latest commit: switch is removed and mode is defaulted to
On.
Thank you , VERY MUCH Andrei, now we can **really** move forward..
well the next question is binary or unicode as the default for
strings
Yes, but we should run some sort of test suite and see what exactly breaks
with unicode strings as the default ones.
On Mon, May 19, 2008 at 2:42 PM, Lukas Kahwe Smith [EMAIL PROTECTED]
wrote:
On 19.05.2008, at 23:34, Cristian Rodríguez wrote:
Andrei Zmievski escribió:
Done. See latest
31 matches
Mail list logo
