Re: [PHP-DEV] I want to work against Bug 44522 - Upload limit 2G

2013-08-08 Thread Michael Wallner
On 6 August 2013 23:00, Michael Wallner m...@php.net wrote: Alright, I rebased the 2Gupload branch against stdint: https://github.com/m6w6/php-src/compare/2Guploads https://github.com/m6w6/php-src/compare/stdint So, is everyone fine with it so far? -- Regards, Mike -- PHP Internals - PHP

Re: [PHP-DEV] I want to work against Bug 44522 - Upload limit 2G

2013-08-08 Thread Ralf Lang
On 08.08.2013 14:42, Michael Wallner wrote: On 6 August 2013 23:00, Michael Wallner m...@php.net wrote: Alright, I rebased the 2Gupload branch against stdint: https://github.com/m6w6/php-src/compare/2Guploads https://github.com/m6w6/php-src/compare/stdint So, is everyone fine with it so

Re: [PHP-DEV] I want to work against Bug 44522 - Upload limit 2G

2013-08-08 Thread Kalle Sommer Nielsen
Hi Michael 2013/8/8 Michael Wallner m...@php.net: On 6 August 2013 23:00, Michael Wallner m...@php.net wrote: Alright, I rebased the 2Gupload branch against stdint: https://github.com/m6w6/php-src/compare/2Guploads https://github.com/m6w6/php-src/compare/stdint So, is everyone fine with it

Re: [PHP-DEV] I want to work against Bug 44522 - Upload limit 2G

2013-08-08 Thread Michael Wallner
On 8 August 2013 14:44, Kalle Sommer Nielsen ka...@php.net wrote: Hi Michael 2013/8/8 Michael Wallner m...@php.net: On 6 August 2013 23:00, Michael Wallner m...@php.net wrote: Alright, I rebased the 2Gupload branch against stdint: https://github.com/m6w6/php-src/compare/2Guploads

Re: [PHP-DEV] I want to work against Bug 44522 - Upload limit 2G

2013-08-06 Thread Michael Wallner
On 5 August 2013 20:34, Michael Wallner m...@php.net wrote: On 5 August 2013 16:19, Pierre Joye pierre@gmail.com wrote: Hi Mike, On Aug 5, 2013 3:58 PM, Michael Wallner m...@php.net wrote: Johannes reminded me, that we don't have C99 stdint portable typedefs in a central PHP header file

Re: [PHP-DEV] I want to work against Bug 44522 - Upload limit 2G

2013-08-05 Thread Michael Wallner
I have added a simple test case for Linux to verify it's basic functionality via the CLI server, and think it's ready to be merged to master to be able to test it within a wider audience. Objections, anyone? https://github.com/m6w6/php-src/compare/2Guploads Thank you Ralf! -- Regards, Mike --

Re: [PHP-DEV] I want to work against Bug 44522 - Upload limit 2G

2013-08-05 Thread Michael Wallner
On 5 August 2013 14:05, Michael Wallner m...@php.net wrote: I have added a simple test case for Linux to verify it's basic functionality via the CLI server, and think it's ready to be merged to master to be able to test it within a wider audience. Objections, anyone?

Re: [PHP-DEV] I want to work against Bug 44522 - Upload limit 2G

2013-08-05 Thread Pierre Joye
Hi Mike, On Aug 5, 2013 3:58 PM, Michael Wallner m...@php.net wrote: On 5 August 2013 14:05, Michael Wallner m...@php.net wrote: I have added a simple test case for Linux to verify it's basic functionality via the CLI server, and think it's ready to be merged to master to be able to test

Re: [PHP-DEV] I want to work against Bug 44522 - Upload limit 2G

2013-08-05 Thread Michael Wallner
On 5 August 2013 16:19, Pierre Joye pierre@gmail.com wrote: Hi Mike, On Aug 5, 2013 3:58 PM, Michael Wallner m...@php.net wrote: On 5 August 2013 14:05, Michael Wallner m...@php.net wrote: I have added a simple test case for Linux to verify it's basic functionality via the CLI server,

Re: [PHP-DEV] I want to work against Bug 44522 - Upload limit 2G

2013-08-02 Thread Michael Wallner
On 3 July 2013 19:38, Ralf Lang l...@b1-systems.de wrote: Any additional action required from my side or is it just waiting for a review timeslot? I'll soon be able to merge/align it with a solution that's been running in production for years, just give me a few days. Thank you for your

Re: [PHP-DEV] I want to work against Bug 44522 - Upload limit 2G

2013-07-03 Thread Ralf Lang
On 28.06.2013 08:45, Ralf Lang wrote: On 27.06.2013 18:52, Christopher Jones wrote: On 06/27/2013 09:33 AM, Ralf Lang wrote: Anyway, I have built a version of the patch (using unsigned long instead of signed long as the original did) against old php 5.3.8 and currently a test is running

Re: [PHP-DEV] I want to work against Bug 44522 - Upload limit 2G

2013-06-28 Thread Ralf Lang
On 28.06.2013 07:12, Laruence wrote: Hey: Instead of change the uint to long or size_t, Maybe make the max_file_upload_size 0 means unlimited? like Apached did, ulimited or = 2Gb https://httpd.apache.org/docs/2.2/mod/core.html#limitrequestbody This doesn't change the behaviour that

Re: [PHP-DEV] I want to work against Bug 44522 - Upload limit 2G

2013-06-28 Thread Ralf Lang
On 27.06.2013 18:52, Christopher Jones wrote: On 06/27/2013 09:33 AM, Ralf Lang wrote: Anyway, I have built a version of the patch (using unsigned long instead of signed long as the original did) against old php 5.3.8 and currently a test is running with a 4.7 GiB DVD Image. If it works

Re: [PHP-DEV] I want to work against Bug 44522 - Upload limit 2G

2013-06-27 Thread Johannes Schlüter
Hi, On Thu, 2013-06-27 at 10:21 +0200, Ralf Lang wrote: Hi, I want to deal with Bug 44522 which disallows uploads 2G https://bugs.php.net/bug.php?id=44522edit=1 Great! Today with PHP cloud solutions, we are running into more situations where this really hurts. Yay cloud :-D (i don't

Re: [PHP-DEV] I want to work against Bug 44522 - Upload limit 2G

2013-06-27 Thread Ralf Lang
Yay cloud :-D (i don't see why cloud matters, here though it's more about modern bandwidth and storage space) Just did not want to name the product which prompted me to finally go at it. ;) Before I begin providing a github patch (as I have no php svn access and I don't think it's needed)

Re: [PHP-DEV] I want to work against Bug 44522 - Upload limit 2G

2013-06-27 Thread Christopher Jones
On 06/27/2013 09:33 AM, Ralf Lang wrote: Anyway, I have built a version of the patch (using unsigned long instead of signed long as the original did) against old php 5.3.8 and currently a test is running with a 4.7 GiB DVD Image. If it works well, I will submit the patch and attach it to the

Re: [PHP-DEV] I want to work against Bug 44522 - Upload limit 2G

2013-06-27 Thread Johannes Schlüter
On Thu, 2013-06-27 at 09:52 -0700, Christopher Jones wrote: Did you review all the previous mail list discussion about the patch? IIRC there were a bunch of reasons it never got merged. what we never merged for reasons is large file support. So 32bit machines can use files 2G. The patches

Re: [PHP-DEV] I want to work against Bug 44522 - Upload limit 2G

2013-06-27 Thread Yasuo Ohgaki
Hi Just a comment for the patch. 2013/6/27 Ralf Lang l...@b1-systems.de Does anybody know of intricate reasons why the existing patch https://bugs.php.net/patch-display.php?bug_id=44522patch=uploads_larger_than_2g_HEAD_v2revision=latest could not be included into php 5.5? It uses long

Re: [PHP-DEV] I want to work against Bug 44522 - Upload limit 2G

2013-06-27 Thread Anthony Ferrara
To be fair, the overall limit is going to be 32 bit anyway (due to the use of int for string lengths)... I'm working on a patch to replace all references of string sizes with size_t, but as you can imagine, it's going to take some time... Just throwing it out there that a better fix may be

Re: [PHP-DEV] I want to work against Bug 44522 - Upload limit 2G

2013-06-27 Thread Rasmus Lerdorf
On 06/27/2013 06:13 PM, Anthony Ferrara wrote: To be fair, the overall limit is going to be 32 bit anyway (due to the use of int for string lengths)... For file uploads? Why? We never hold the entire file in a string. -Rasmus -- PHP Internals - PHP Runtime Development Mailing List To

Re: [PHP-DEV] I want to work against Bug 44522 - Upload limit 2G

2013-06-27 Thread Laruence
Hey: Instead of change the uint to long or size_t, Maybe make the max_file_upload_size 0 means unlimited? like Apached did, ulimited or = 2Gb https://httpd.apache.org/docs/2.2/mod/core.html#limitrequestbody thanks On Thu, Jun 27, 2013 at 4:21 PM, Ralf Lang l...@b1-systems.de wrote: Hi,

Re: [PHP-DEV] I want to work against Bug 44522 - Upload limit 2G

2013-06-27 Thread Laruence
On Fri, Jun 28, 2013 at 1:12 PM, Laruence larue...@php.net wrote: Hey: Instead of change the uint to long or size_t, Maybe make the max_file_upload_size 0 means unlimited? like Apached did, ulimited or = 2Gb s ,Gb,GB, https://httpd.apache.org/docs/2.2/mod/core.html#limitrequestbody