Re: [PHP-DEV] Implement formal process for run-tests.php refactor

On Mon, May 29, 2017 at 8:20 PM, Stanislav Malyshev wrote: >> Is that worth a shot, do you think? > > Definitely. There's no reason also why it shouldn't work so failing > tests in such scenario probably should be treated as bugs. > > A lot of tests also inherently

Re: [PHP-DEV] Implement formal process for run-tests.php refactor

Hi! > Is that worth a shot, do you think? Definitely. There's no reason also why it shouldn't work so failing tests in such scenario probably should be treated as bugs. A lot of tests also inherently parallel-safe - probably majority of them, though wouldn't claim I am 100% sure - so maybe

RE: [PHP-DEV] Implement formal process for run-tests.php refactor

> -Original Message- > From: Rasmus Lerdorf [mailto:ras...@lerdorf.com] > Sent: Thursday, May 25, 2017 3:08 PM > To: Nikita Popov <nikita@gmail.com> > Cc: Andrea Faulds <a...@ajf.me>; PHP internals <internals@lists.php.net> > Subject: Re: [PHP-D

RE: [PHP-DEV] Implement formal process for run-tests.php refactor

Hi Sammy, > -Original Message- > From: sam...@sammykmedia.com [mailto:sam...@sammykmedia.com] On > > I agree that parallelism should be the first and primary goal of the > refactor. I just > mentioned maintainability and unit tests first since I foresee those things > happing as we

Re: [PHP-DEV] Implement formal process for run-tests.php refactor

On Thu, May 25, 2017 at 3:52 PM, Nikita Popov wrote: > > > During normal development I usually only run either Zend/ tests, or the > tests in the extension I'm modifying (the rest is what CI is for). > Parallelizing by directory will speed up our CI builds (which is

Re: [PHP-DEV] Implement formal process for run-tests.php refactor

On Thu, May 25, 2017 at 2:34 PM, Rasmus Lerdorf wrote: > On Thu, May 25, 2017 at 3:09 AM, Andrea Faulds wrote: > > > > It occurred to me a little while ago that if we ran the test suite in > > parallel, but only run one test from a given directory (or extension)

Re: [PHP-DEV] Implement formal process for run-tests.php refactor

On Thu, May 25, 2017 at 3:09 AM, Andrea Faulds wrote: > > It occurred to me a little while ago that if we ran the test suite in > parallel, but only run one test from a given directory (or extension) at a > time, it should probably avoid any such problems, and it would not be >

Re: [PHP-DEV] Implement formal process for run-tests.php refactor

Hi all, Johannes Schlüter wrote: phpUnit might be battle tested with parallelization, the PHP test suite isn't. There are tons of tests using the same resource (i.e. different mysqli and pdo_mysql tests might use the same tables some other tests use same port for some socket stuff etc.) Would

Re: [PHP-DEV] Implement formal process for run-tests.php refactor

On Thu, May 18, 2017 at 5:59 AM, Anatol Belski wrote: > > Hi Sammy, > > > -Original Message- > > From: sam...@sammykmedia.com [mailto:sam...@sammykmedia.com] On > > Behalf Of Sammy Kaye Powers > > Sent: Wednesday, May 17, 2017 4:29 PM > > To: PHP Internals

Re: [PHP-DEV] Implement formal process for run-tests.php refactor

Am 18.05.2017 um 12:08 schrieb Marco Pivetta: On Thu, May 18, 2017 at 2:35 AM, Johannes Schlüter wrote: On Mi, 2017-05-17 at 23:30 +0200, Marco Pivetta wrote: Is Sebastian copied in here? Why can't we just use the super-battle- tested PHPUnit? It supports phpt and a

Re: [PHP-DEV] Implement formal process for run-tests.php refactor

On 05/17/2017 11:30 PM, Marco Pivetta wrote: Is Sebastian copied in here? Why can't we just use the super-battle-tested PHPUnit? It supports phpt and a ton of plugins, plus everyone uses it and is familiar with it. IMO, PHPUnit is not the right tool to test PHP itself. Yes, it supports a

RE: [PHP-DEV] Implement formal process for run-tests.php refactor

Hi Sammy, > -Original Message- > From: sam...@sammykmedia.com [mailto:sam...@sammykmedia.com] On > Behalf Of Sammy Kaye Powers > Sent: Wednesday, May 17, 2017 4:29 PM > To: PHP Internals > Subject: [PHP-DEV] Implement formal process for run-tests.php refactor >

Re: [PHP-DEV] Implement formal process for run-tests.php refactor

On Do, 2017-05-18 at 12:08 +0200, Marco Pivetta wrote: > On Thu, May 18, 2017 at 2:35 AM, Johannes Schlüter rs.de> wrote: > > On Mi, 2017-05-17 at 23:30 +0200, Marco Pivetta wrote: > > > Is Sebastian copied in here? Why can't we just use the super- > > battle- > > > tested > >

Re: [PHP-DEV] Implement formal process for run-tests.php refactor

On Thu, May 18, 2017 at 2:35 AM, Johannes Schlüter wrote: > On Mi, 2017-05-17 at 23:30 +0200, Marco Pivetta wrote: > > Is Sebastian copied in here? Why can't we just use the super-battle- > > tested > > PHPUnit? It supports phpt and a ton of plugins, plus everyone uses it

Re: [PHP-DEV] Implement formal process for run-tests.php refactor

On Mi, 2017-05-17 at 23:30 +0200, Marco Pivetta wrote: > Is Sebastian copied in here? Why can't we just use the super-battle- > tested > PHPUnit? It supports phpt and a ton of plugins, plus everyone uses it > and > is familiar with it. PHPUnit is huge. run-tests is a small script in a single file

Re: [PHP-DEV] Implement formal process for run-tests.php refactor

Is Sebastian copied in here? Why can't we just use the super-battle-tested PHPUnit? It supports phpt and a ton of plugins, plus everyone uses it and is familiar with it. Am I missing something? On 17 May 2017 7:18 p.m., "Fleshgrinder" wrote: > I like the idea and the

Re: [PHP-DEV] Implement formal process for run-tests.php refactor

I like the idea and the proposed approach. I would also offer my help with anything here. What I would definitely avoid is moving this out of the PHP repository itself. Ideally we get to a point where people enter a single command and it does take care of everything (given that the required

Re: [PHP-DEV] Implement formal process for run-tests.php refactor

Am 17.05.2017 um 17:00 schrieb Andreas Heigl: seriously a signature on top breaks reply and quotes for any sane MUA which strips signatures and so quotes only stuff on top of the "-- " line > Just a stupid question for a non-regular: Why not a > separate repo? In the end

Re: [PHP-DEV] Implement formal process for run-tests.php refactor

-- Andreas Heigl andr...@heigl.org > Am 17.05.2017 um 16:28 schrieb Sammy Kaye Powers : > > Hello internals folks! > > As you may already know, run-tests.php is an old legacy app that is in > serious need of a refactor. Some things that are badly needed amongst other >