Re: [PHP-DEV] Re: [VOTE] Random Extension Improvement

2022-07-13 Thread Go Kudo
2022年7月13日(水) 1:10 Tim Düsterhus : > Hi > > On 7/12/22 18:04, Tim Düsterhus wrote: > > I also think that both '$string' and '$binary' are appropriate parameter > > names in this case, so particular preference from my side. > > Sorry for the follow-up, there's two mistakes in that sentence. It >

Re: [PHP-DEV] Re: [VOTE] Random Extension Improvement

2022-07-12 Thread Tim Düsterhus
Hi On 7/12/22 18:04, Tim Düsterhus wrote: I also think that both '$string' and '$binary' are appropriate parameter names in this case, so particular preference from my side. Sorry for the follow-up, there's two mistakes in that sentence. It should read: I also think that both '$string' and

Re: [PHP-DEV] Re: [VOTE] Random Extension Improvement

2022-07-12 Thread Tim Düsterhus
Hi On 7/12/22 14:26, Go Kudo wrote: Currently, the renaming of Randomizer::shuffleString() to Randomizer::shuffleBytes() seems acceptable. I forgot to note the change regarding arguments when I submitted this RFC. With this change, the argument was supposed to be changed from `string $string`

Re: [PHP-DEV] Re: [VOTE] Random Extension Improvement

2022-07-12 Thread Guilliam Xavier
> > https://wiki.php.net/rfc/random_extension_improvement > > Hi Internals. > > Currently, the renaming of Randomizer::shuffleString() to > Randomizer::shuffleBytes() seems acceptable. > > I forgot to note the change regarding arguments when I submitted this RFC. > With this change, the argument