Re: [PHP-DEV] [RFC Discussion] Catching multiple exception types

2016-03-09 Thread Björn Larsson
Hi, Thanks for clarifying. Think the RFC would benefit from having some of these examples in it. I also had in mind that it's handy for catching many exceptions when logging stuff and re-throwing like: } catch (FirstException | SecondException ex) { logger.error(ex); throw ex; }

Re: [PHP-DEV] [RFC Proposal] Null Coalesce Equal Operator

2016-03-09 Thread Midori Kocak
Hi, I fixed that, corrected some typos and closed voting. Thank you for feedbacks, Midori > On 09 Mar 2016, at 19:55, Jakub Kubíček wrote: > > Hi Midori, > > what about targetting this to the next PHP 7.x? > > -- > Kubis > On 10-Mar-2016 12:11 am, "Ryan Pallas"

Re: [PHP-DEV] segfault in ini_lex() in 7.0.3

2016-03-09 Thread Adam Baratz
> > Can you provide the INI (minus secure info) and script that generates > this? Unfortunately, I haven't been able to isolate what's causing this. It seems to occur on "complex enough" pages. Which could mean one of the (many) extensions involved isn't playing nice with PHP7, which I'll look

Re: [PHP-DEV] [RFC][VOTE] Precise session management

2016-03-09 Thread Yasuo Ohgaki
Hi Derick, On Thu, Mar 10, 2016 at 6:08 AM, Yasuo Ohgaki wrote: > Session module returns FALSE for invalid status, therefore it would be > better to return FALSE. IMO. However, this patch is for 7.1, so it can > be changed. If we are going to change this, it would be nicer to

Re: [PHP-DEV] [RFC][VOTE] Precise session management

2016-03-09 Thread Yasuo Ohgaki
Hi Derick, On Wed, Mar 9, 2016 at 8:48 PM, Derick Rethans wrote: >> Hi all, >> >> This mail is for RFC vote notice. >> >> The RFC is >> https://wiki.php.net/rfc/precise_session_management >> The PR is >> https://github.com/php/php-src/pull/1734 >> >> I suppose almost all

Re: [PHP-DEV] [RFC Proposal] var keyword deprecation/removal

2016-03-09 Thread Glenn Eggleton
Hi list, I think that removing it in any 7.x would be too soon. We should mark it as future deprecation then remove it at a later date. While I don't come across the use of var too much, it does still exist in code bases that are quite old. On Wed, Mar 9, 2016 at 1:56 PM, Fleshgrinder

Re: [PHP-DEV] segfault in ini_lex() in 7.0.3

2016-03-09 Thread Will Fitch
On Wed, Mar 9, 2016, at 01:28 PM, Adam Baratz wrote: > I got a core dump with this output: Can you provide the INI (minus secure info) and script that generates this? > > Cannot access memory at address 0x9 > Cannot access memory at address 0x1 > > #0 0x00654a6d in ini_lex

[PHP-DEV] segfault in ini_lex() in 7.0.3

2016-03-09 Thread Adam Baratz
I got a core dump with this output: Cannot access memory at address 0x9 Cannot access memory at address 0x1 #0 0x00654a6d in ini_lex (ini_lval=0xd314c15417d73c46) at Zend/zend_ini_scanner.c:3724 #1 0x0067da19 in init_executor () at

Re: [PHP-DEV] [RFC Proposal] var keyword deprecation/removal

2016-03-09 Thread Fleshgrinder
@Tony Marston: I cannot reply anymore to you because you are discrediting yourself with every mail you send and I do not want to contribute to this any further; I might reply again if you write something that is actually contributing to this discussion. In the meantime: read what Rowan Collins

Re: [PHP-DEV] [RFC Proposal] Null Coalesce Equal Operator

2016-03-09 Thread Jakub Kubíček
Hi Midori, what about targetting this to the next PHP 7.x? -- Kubis On 10-Mar-2016 12:11 am, "Ryan Pallas" wrote: > On Wed, Mar 9, 2016 at 11:14 AM, Midori Kocak wrote: > > > Hi all, > > > > Remember my question about ??= operator? > > > > Forgive my

Re: [PHP-DEV] [RFC Proposal] Null Coalesce Equal Operator

2016-03-09 Thread Ryan Pallas
On Wed, Mar 9, 2016 at 11:14 AM, Midori Kocak wrote: > Hi all, > > Remember my question about ??= operator? > > Forgive my rookieness and let me introduce my first RFC here: > https://wiki.php.net/rfc/null_coalesce_equal_operator < >

Re: [PHP-DEV] [RFC Proposal] Null Coalesce Equal Operator

2016-03-09 Thread Sara Golemon
On Wed, Mar 9, 2016 at 10:14 AM, Midori Kocak wrote: > Remember my question about ??= operator? > https://wiki.php.net/rfc/null_coalesce_equal_operator > As I said before, I support this. The whole thing feels like a no-brainer in terms of implementing it. Davey mentioned on

[PHP-DEV] [RFC Proposal] Null Coalesce Equal Operator

2016-03-09 Thread Midori Kocak
Hi all, Remember my question about ??= operator? Forgive my rookieness and let me introduce my first RFC here: https://wiki.php.net/rfc/null_coalesce_equal_operator Let me also include here the introduction I wrote: Combined

Re: [PHP-DEV] Can you please give me karma? Understanding Karma as a Buddhist

2016-03-09 Thread Ferenc Kovacs
On Wed, Mar 9, 2016 at 1:07 AM, Midori Kocak wrote: > Hello, > > You remember my question? > > A question about null coalescing operator.. > > $this->request->data['comments']['user_id'] = > $this->request->data['comments']['user_id'] ?? ‘value’; > > … > > And you remember my

Re: [PHP-DEV] Can you please give me karma? Understanding Karma as a Buddhist

2016-03-09 Thread Midori Kocak
Thank you very very much. I appreciate that. Now it’s the level 3. Best wishes, Midori > On 09 Mar 2016, at 17:46, Ferenc Kovacs wrote: > > > > On Wed, Mar 9, 2016 at 1:07 AM, Midori Kocak > wrote: > Hello, > > You remember

[PHP-DEV] GOOD Benchmark Results for PHP Master 2016-03-09

2016-03-09 Thread lp_benchmark_robot
Results for project PHP master, build date 2016-03-09 16:02:28+02:00 commit: f2d2e8c previous commit:58c82ff revision date: 2016-03-09 18:05:28+08:00 environment:Haswell-EP cpu:Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz 2x18 cores, stepping 2, LLC 45 MB

Re: [PHP-DEV] [RFC Discussion] Catching multiple exception types

2016-03-09 Thread Pierrick Charron
On 9 March 2016 at 08:30, Marco Pivetta wrote: > On 9 March 2016 at 14:24, Pierrick Charron wrote: >> >> The thing I don't like about this approach is that I have to read the >> code and double check to make sure that the catch statement call the same >>

Re: [PHP-DEV] [RFC Discussion] Catching multiple exception types

2016-03-09 Thread Marco Pivetta
On 9 March 2016 at 14:24, Pierrick Charron wrote: > > The thing I don't like about this approach is that I have to read the code > and double check to make sure that the catch statement call the same method. > For the amount of work that needs to be done in the Engine (see the

Re: [PHP-DEV] [RFC Discussion] Catching multiple exception types

2016-03-09 Thread Arvids Godjuks
I'm definetly lately started to use instanceof to check the type of exception I've got and throw further those that I don't need. This is especially valuable for CLI applications (I have a few daemons in PHP). So a big +1 on the proposal idea, as for the tech part - maybe unions is a good idea.

Re: [PHP-DEV] [RFC Discussion] Catching multiple exception types

2016-03-09 Thread Pierrick Charron
On 9 March 2016 at 08:08, Marco Pivetta wrote: > On 9 March 2016 at 14:03, Pierrick Charron wrote: > >> Hi Derick >> >> I agree that most of the time the best solution is to implement a clean >> exception hierarchy but as stated in the RFC : >> >> "A

Re: [PHP-DEV] [RFC Discussion] Catching multiple exception types

2016-03-09 Thread Marco Pivetta
On 9 March 2016 at 14:03, Pierrick Charron wrote: > Hi Derick > > I agree that most of the time the best solution is to implement a clean > exception hierarchy but as stated in the RFC : > > "A solution to fix this problem on the user level would be to implement a > common

Re: [PHP-DEV] [RFC Discussion] Catching multiple exception types

2016-03-09 Thread Pierrick Charron
Hi Derick I agree that most of the time the best solution is to implement a clean exception hierarchy but as stated in the RFC : "A solution to fix this problem on the user level would be to implement a common interface for ExceptionType1 and ExceptionType2 and catch it. However, this is only

Re: [PHP-DEV] [RFC Discussion] Catching multiple exception types

2016-03-09 Thread Niklas Keller
2016-03-09 12:52 GMT+01:00 Derick Rethans : > Hi! > > On Tue, 8 Mar 2016, Pierrick Charron wrote: > > > Bronisław Białek and I would like to start a discussion about allowing > > multiple exception types to be caught in a single catch statement. > > > >

Re: [PHP-DEV] [RFC Discussion] Catching multiple exception types

2016-03-09 Thread Derick Rethans
Hi! On Tue, 8 Mar 2016, Pierrick Charron wrote: > Bronisław Białek and I would like to start a discussion about allowing > multiple exception types to be caught in a single catch statement. > > https://wiki.php.net/rfc/multiple-catch Would it not be better, to have your Exceptions extend a

Re: [PHP-DEV] [RFC][VOTE] Precise session management

2016-03-09 Thread Derick Rethans
On Wed, 9 Mar 2016, Yasuo Ohgaki wrote: > Hi all, > > This mail is for RFC vote notice. > > The RFC is > https://wiki.php.net/rfc/precise_session_management > The PR is > https://github.com/php/php-src/pull/1734 > > I suppose almost all questions and discussion is finished, but > if you have

[PHP-DEV] Re: [RFC][VOTE] Precise session management

2016-03-09 Thread Yasuo Ohgaki
Hi all, On Wed, Mar 9, 2016 at 6:14 PM, Yasuo Ohgaki wrote: > The RFC is > https://wiki.php.net/rfc/precise_session_management - Change session_destroy() Accept bool parameter for session data removal. bool session_gc(void) - The function should be

Re: [PHP-DEV] [RFC Proposal] var keyword deprecation/removal

2016-03-09 Thread James Titcumb
Yes, you're quite right - my mistake!

Re: [PHP-DEV] [RFC Proposal] var keyword deprecation/removal

2016-03-09 Thread Rowan Collins
James Titcumb wrote on 09/03/2016 11:13: By the way Yasuo, you didn't include the internals mailing list in your last reply. I think possibly you didn't include the list in a previous reply then, assuming Yasuo was replying to something you wrote? -- PHP Internals - PHP Runtime Development

Re: [PHP-DEV] [RFC Proposal] var keyword deprecation/removal

2016-03-09 Thread James Titcumb
On 9 March 2016 at 11:09, Yasuo Ohgaki wrote: > > > Since there is conversion script, how about just write RFC and start > voting? I seems discussion never ends. I agree completely :) By the way Yasuo, you didn't include the internals mailing list in your last reply.

Re: [PHP-DEV] [RFC Proposal] var keyword deprecation/removal

2016-03-09 Thread Rowan Collins
Yasuo Ohgaki wrote on 09/03/2016 10:35: Hi all, Keeping aliases do not harm much. It may stay forever. How about stop discussion, but write code? The only chance this kind of proposal to pass is existence of "conversion program" that replaces aliases in older codes. If there is anyone who

Re: [PHP-DEV] [RFC Proposal] var keyword deprecation/removal

2016-03-09 Thread Rowan Collins
Tony Marston wrote on 09/03/2016 10:31: As a developer who went through several COBOL upgrades I can attest to the fact that BC breaks were extremely rare and only for a good reason. My code was never affected simply because I never used any of the dodgy features (such as ALTER ... GO TO ...)

Re: [PHP-DEV] [RFC Proposal] var keyword deprecation/removal

2016-03-09 Thread Rowan Collins
Tony Marston wrote on 09/03/2016 10:09: What we as userland developers do with our own code only affects us. What you as core developers do with the language affects every one of the millions of userland developers all over the world. I touched on this in another message, but I think you may

Re: [PHP-DEV] [RFC Proposal] var keyword deprecation/removal

2016-03-09 Thread Yasuo Ohgaki
Hi all, Keeping aliases do not harm much. It may stay forever. How about stop discussion, but write code? The only chance this kind of proposal to pass is existence of "conversion program" that replaces aliases in older codes. If there is anyone who would like to volunteer for this, please

Re: [PHP-DEV] [RFC Proposal] var keyword deprecation/removal

2016-03-09 Thread Tony Marston
wrote in message news:56df3dfb.10...@fleshgrinder.com... @Tony Marston: I feel directly attacked and offended and others have the feeling too, that is the definition of an insult. That being said, I am staying constructive the whole time and do not avoid communication with you or anyone else

Re: [PHP-DEV] [RFC Proposal] var keyword deprecation/removal

2016-03-09 Thread Rowan Collins
Tony Marston wrote on 09/03/2016 09:51: Those who advocate the removal of long-standing features of the language FOR NO GOOD REASON [...] What you have to understand is that this is YOUR OPINION. Even if, in your opinion, anyone who doesn't share that opinion is incompetent, or whatever

Re: [PHP-DEV] [RFC Proposal] var keyword deprecation/removal

2016-03-09 Thread Arvids Godjuks
All languages are evolving, and part of that is removing old baggage, even if that baggage is harmful. Because ease of maintenance. When you have multiple ways to do a thing, that means that when you touch some part of it, you have to remember to update everything else. It's easy with

Re: [PHP-DEV] [RFC Proposal] var keyword deprecation/removal

2016-03-09 Thread Tony Marston
"Andrew Brown" wrote in message news:CAH=AbGJAnYK1Vra+7mU=Ldcb+9Tp6+qbT9yaVzX60GJ=yjs...@mail.gmail.com... the main argument against removing var that I continue to hear is that 'my old code won't work anymore because of this unnecessary BC break'. but the thing is, your code *will* continue

Re: [PHP-DEV] [RFC Proposal] var keyword deprecation/removal

2016-03-09 Thread James Titcumb
> > need to have their competence, professionalism, and intelligence > questioned. Tony, making a statement like this is unprofessional in itself. You've already been asked to put emotions aside and discuss this topic on the technical merit, there's no need to question people's competence,

Re: [PHP-DEV] [RFC Proposal] var keyword deprecation/removal

2016-03-09 Thread Tony Marston
"Rowan Collins" wrote in message news:56dea829.5030...@gmail.com... Tony Marston wrote on 08/03/2016 09:51: a "Rowan Collins" wrote in message news:56dd64f5.5010...@gmail.com... Tony Marston wrote on 07/03/2016 09:14: That takes brains and discipline, something which appears to be lacking

[PHP-DEV] [RFC][VOTE] Precise session management

2016-03-09 Thread Yasuo Ohgaki
Hi all, This mail is for RFC vote notice. The RFC is https://wiki.php.net/rfc/precise_session_management The PR is https://github.com/php/php-src/pull/1734 I suppose almost all questions and discussion is finished, but if you have any, please comment/ask. Vote starts 2016-03-09-09:00(UTC) and