[PHP-DEV] Re: Request shutdown optimization

Hey: On Thu, Jun 22, 2017 at 3:29 PM, Dmitry Stogov wrote: > hi, > > > could you, please, review the PR https://github.com/php/php-src/pull/2591 > > > The main idea is not to free request-allocated zvals, because they are > freed by Zend MM anyway. > > Also, shutdown_executor()

Re: [PHP-DEV] [RFC] [Vote] Doxygen

On 22/6/17 1:43 am, Fleshgrinder wrote: On 6/21/2017 5:38 PM, Nikita Popov wrote: Can you please clarify where functions that are declared in a header and defined in a source file should be documented? I believe the usual recommendation is to document in the source file, because it's closer

[PHP-DEV] BAD Benchmark Results for PHP Master 2017-06-21

Results for project PHP master, build date 2017-06-21 19:23:40-07:00 commit: 9fb0e6f previous commit:7802cf8 revision date: 2017-06-22 01:41:59+03:00 environment:Haswell-EP cpu:Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz 2x18 cores, stepping 2, LLC 45 MB

Re: [PHP-DEV] Valgrind failures

On Thu, Jun 22, 2017 at 9:12 PM, Jakub Zelenka wrote: > Ah thanks I see! Just out of interest what changes actually caused it as > it's master only? > It's due to https://github.com/php/php-src/commit/141d1ba9801f742dc5d9ccd06e02b94284c4deb7, which has only been introduced in

Re: [PHP-DEV] [RFC] Unary null coalescing operator

On Thu, Jun 22, 2017 at 10:52 PM, Andrea Faulds wrote: > Hi Stas, > > Stanislav Malyshev wrote: > >> Hi! >> >> I think that `if ($_GET['x']?? === 1)` looks and feels a lot like `if >>> (@$_GET['x'] === 1)`... >>> >>> Yes, the latter has runtime performance issues and will still

Re: [PHP-DEV] [RFC] Unary null coalescing operator

Hi Stas, Stanislav Malyshev wrote: Hi! I think that `if ($_GET['x']?? === 1)` looks and feels a lot like `if (@$_GET['x'] === 1)`... Yes, the latter has runtime performance issues and will still send notices to error handlers and logs. But perhaps if we're going to extend syntax, the

Re: [PHP-DEV] Re: Deprecating DateTime::ISO8601 / DATE_ISO8601

2017-06-22 12:32 GMT+02:00 Derick Rethans : > On Thu, 22 Jun 2017, Niklas Keller wrote: > > > Hey, > > > > can we please deprecate DateTime::ISO8601 / DATE_ISO8601 so we can change > > them to the proper format in a later version? It's really ridiculous. > > No, we can not remove

Re: [PHP-DEV] Valgrind failures

Ah thanks I see! Just out of interest what changes actually caused it as it's master only? On Thu, Jun 22, 2017 at 7:51 PM, Nikita Popov wrote: > On Thu, Jun 22, 2017 at 8:45 PM, Jakub Zelenka wrote: > >> Hi Dmitry, >> >> I noticed that valgind reports a

Re: [PHP-DEV] Valgrind failures

On Thu, Jun 22, 2017 at 8:45 PM, Jakub Zelenka wrote: > Hi Dmitry, > > I noticed that valgind reports a lot of memleaks for the master and it > seems to be related to the freeing of registered classes on shutdown when > running cli. I'm wondering if it can be related to your

[PHP-DEV] Valgrind failures

Hi Dmitry, I noticed that valgind reports a lot of memleaks for the master and it seems to be related to the freeing of registered classes on shutdown when running cli. I'm wondering if it can be related to your recent changes that were touching that parts. I haven't found the commit that caused

Re: [PHP-DEV] [RFC][VOTE] Add support for stream-wrapped URLs in opcode cache

Hi Dmitry, Le 22/06/2017 à 09:42, Dmitry Stogov a écrit : The PR is incomplete, so I can't test and even understand the idea completely. In my opinion, user defined streams can't be cached, because the wrapper code itself may be changed from request to request. Right. I hadn't imagined

[PHP-DEV] Re: Deprecating DateTime::ISO8601 / DATE_ISO8601

On Thu, 22 Jun 2017, Niklas Keller wrote: > Hey, > > can we please deprecate DateTime::ISO8601 / DATE_ISO8601 so we can change > them to the proper format in a later version? It's really ridiculous. No, we can not remove this. cheers, Derick -- PHP Internals - PHP Runtime Development Mailing

[PHP-DEV] PHP 7.0.21RC1 is available for testing

Hi, PHP 7.0.21 RC1 was just released and can be downloaded from: https://downloads.php.net/~ab/ The Windows binaries are available at http://windows.php.net/qa/ This release contains a number of bugfixes. For the list of bugfixes that you can target in your testing, please refer to

[PHP-DEV] PHP 7.2.0 Alpha 2 Released

The second alpha for 7.2.0 was just released and can be downloaded from: https://downloads.php.net/~pollita/ Or using the git tag: php-7.2.0alpha2 The Windows binaries are available at: http://windows.php.net/qa/ Please test it carefully, and report any bugs in the bug system. The next release

Re: [PHP-DEV] Deprecating DateTime::ISO8601 / DATE_ISO8601

Am 22.06.17 um 12:08 schrieb Niklas Keller: > Hey, > > can we please deprecate DateTime::ISO8601 / DATE_ISO8601 so we can change > them to the proper format in a later version? It's really ridiculous. > > Regards, Niklas > IMHO deprecating means we remove something, which we do not want to do

[PHP-DEV] Deprecating DateTime::ISO8601 / DATE_ISO8601

Hey, can we please deprecate DateTime::ISO8601 / DATE_ISO8601 so we can change them to the proper format in a later version? It's really ridiculous. Regards, Niklas

Re: [PHP-DEV] DateInterval and ISO 8601

On Thu, 22 Jun 2017, David Rodrigues wrote: > As mentioned on doc (http://php.net/manual/en/dateinterval.construct.php) > the format is based on ISO 8601 ( > https://en.wikipedia.org/wiki/ISO_8601#Durations), but it doesn't respects, > for instance, decimal values. There are some reason for that?

Re: [PHP-DEV] [RFC][VOTE] Add support for stream-wrapped URLs in opcode cache

hi François, The PR is incomplete, so I can't test and even understand the idea completely. In my opinion, user defined streams can't be cached, because the wrapper code itself may be changed from request to request. -1 Thanks. Dmitry. From: François

[PHP-DEV] Request shutdown optimization

hi, could you, please, review the PR https://github.com/php/php-src/pull/2591 The main idea is not to free request-allocated zvals, because they are freed by Zend MM anyway. Also, shutdown_executor() code was simplified by calling destructors and closing resources, before freeing data.

[PHP-DEV] DateInterval and ISO 8601

As mentioned on doc (http://php.net/manual/en/dateinterval.construct.php) the format is based on ISO 8601 ( https://en.wikipedia.org/wiki/ISO_8601#Durations), but it doesn't respects, for instance, decimal values. There are some reason for that? This bug was related on 2011 and we have not update