Re: [PHP-DEV] [RFC] Interface Default Methods

On Tue, Jun 20, 2023 at 7:30 AM Levi Morrison wrote: > On Sat, Jun 17, 2023 at 6:05 AM Alexandru Pătrănescu > wrote: > > > > 1. Do we want to allow also private methods in the interface so that it > > allows code reuse or better code organization in smaller methods? > > Sorry for the delay in

Re: [PHP-DEV] [RFC] Interface Default Methods

On Sat, Jun 17, 2023 at 6:05 AM Alexandru Pătrănescu wrote: > > Thank you for this! > I like the proposal and I think it fits well. > I'm used to it from Java and I don't know any reason for it to be > considered a bad practice since it was introduce, about 9-10 years ago. > > 1. Do we want to

Re: [PHP-DEV] [RFC] [Discussion] PHP 8.3 deprecations

On 19-6-2023 23:27, Máté Kocsis wrote: Hi Juliette, For the mb_strimwidth() proposal an impact analysis is provided at the end ("over 100 projects were reviewed"). For the other proposals there isn't and we do not believe this to be useful. We consider deprecations to be different from other

Re: [PHP-DEV] [RFC] [Discussion] Deprecate functions with overloaded signatures

On 19-6-2023 23:16, Máté Kocsis wrote: Hi, The impact analysis on userland code seems to be missing for some of the proposals, most notably for the proposals which I expect will have the highest impact. I'd like to ask for an impact analysis to be added to each of these: * array_keys() *

Re: [PHP-DEV] [RFC] Interface Default Methods

> I like the idea of this RFC - in fact it's one which has been near top of > my wishlist for PHP language features for a long time - but I think this is > an issue with the proposed implementation which at the very least warrants > highlighting and discussion. I understand your concern but

Re: [PHP-DEV] [RFC] [Discussion] PHP 8.3 deprecations

Hi Juliette, For the mb_strimwidth() proposal an impact analysis is provided at the end ("over 100 projects were reviewed"). For the other proposals there isn't and we do not believe this to be useful. We consider deprecations to be different from other RFCs that add new features, because

Re: [PHP-DEV] Possible RFC: PDOStatement::addBatch

So if I'm not missing something, you want to add this new method to core to accommodate situations where: 1. the dev is too inexperienced to implement a pre-existing library and 2. the incoming 2d payload is not packaged as a csv file (and therefore cannot be directly imported as such) and 3. the

Re: [PHP-DEV] [RFC] [Discussion] Deprecate functions with overloaded signatures

Hi, The impact analysis on userland code seems to be missing for some of the > proposals, most notably for the proposals which I expect will have the > highest impact. I'd like to ask for an impact analysis to be added to > each of these: > * array_keys() > * ReflectionProperty::setValue() >

Re: [PHP-DEV] [RFC] Interface Default Methods

On Mon, Jun 19, 2023 at 9:53 PM Rowan Tommins wrote: > On 19/06/2023 20:20, David Gebler wrote: > > Okay, thanks. That's really quite significant, since it changes the > feature > > to one which could allow changes made to interfaces to adversely impact > > existing clients of an interface

Re: [PHP-DEV] [RFC] Interface Default Methods

On 19/06/2023 20:20, David Gebler wrote: Okay, thanks. That's really quite significant, since it changes the feature to one which could allow changes made to interfaces to adversely impact existing clients of an interface without those clients changing a thing. As the RFC says, it introduces

Re: Fwd: [PHP-DEV] [RFC] [Discussion] Deprecate functions with overloaded signatures

On 19/06/2023 21:17, Nicolas Grekas wrote: I think we must account for a bit of history/legacy on the topic. I think session_set_save_handler(SessionHandlerInterface) is the best BC/FC path we can provide. Can you elaborate? The SessionHandlerInterface is the *newer* of the two current

Re: Fwd: [PHP-DEV] [RFC] [Discussion] Deprecate functions with overloaded signatures

Le mer. 14 juin 2023 à 23:51, Máté Kocsis a écrit : > > > > Given that you've agreed that neither signature is "primary" or "better", > > doesn't that argument apply equally to both signatures? If it's OK to > force > > anyone using individual callbacks to change their code, why is it not > >

Re: [PHP-DEV] [RFC] [Discussion] Deprecate functions with overloaded signatures

> > > I'm going to nitpick on the newly suggested names and argument order > for > > > the > > > DatePeriod factory methods — althoughI do agree that they need to get > > > created: > > > > > > createFromInterval(DateTimeInterface $start, DateInterval $interval, > > > DateTimeInterface $end, int

Re: [PHP-DEV] [RFC] Interface Default Methods

On Mon, Jun 19, 2023 at 3:53 AM Levi Morrison wrote: > > No, there's no attempt to ensure the method body adheres to calling > the public interface. Due to PHP's possible dynamic behaviors, I don't > think it's reasonable to attempt to enforce it at compile-time. I'm > not sure it's worth the

[PHP-DEV] Re: [RFC] [VOTE] mb_str_pad

On 05/06/2023 19:59, Niels Dossche wrote: > Hello internals > > I'm opening the vote now on my proposal to include mb_str_pad() into PHP 8.3. > RFC link: https://wiki.php.net/rfc/mb_str_pad > > The vote will last until 2023-06-19 20:00 GMT+2. > > Kind regards > Niels Hi internals The voting

Re: [PHP-DEV] Request to create a RFC for const args

2023-06-19 12:59 GMT+02:00, Sam McDonald : > He6 Olle, > Yes more so the former, not the latter in your example. > If there is already an rfc in place then that is fantastic. > Regards > SAM There's no RFC, just me mailing out the idea when I had it. :) Go wild. Olle -- PHP Internals - PHP

Re: [PHP-DEV] Expired pear.php.net certificates

It appears to have been resolved after 13 hours, as of 45min ago. pear.php.net. Let's Encrypt. Valid Not Before: Mon, 19 Jun 2023 10:11:33 GMT -- Timo On Sun, Jun 18, 2023 at 10:46 PM jocelyn fournier < jocelyn.fourn...@gmail.com> wrote: > Hi! > > FYI, it seems pear.php.net

Re: [PHP-DEV] Request to create a RFC for const args

He6 Olle, Yes more so the former, not the latter in your example. If there is already an rfc in place then that is fantastic. Regards SAM Sent from Outlook for Android From: Olle Härstedt Sent: Monday, June 19, 2023 7:47:49 PM To: Sam

Re: [PHP-DEV] Request to create a RFC for const args

2023-06-19 9:56 GMT+02:00, Sam McDonald : > Hello php internals team, > I would like to put forward an RFC for a new feature. I am a long time user, > but have never participated as yet to the RFC. > > This is my first step to gather reaction/feedback from the team. > > I would be happy to

[PHP-DEV] Request to create a RFC for const args

Hello php internals team, I would like to put forward an RFC for a new feature. I am a long time user, but have never participated as yet to the RFC. This is my first step to gather reaction/feedback from the team. I would be happy to implement the feature and post a PR or have someone from