Re: [PHP-DEV] [IDEA] allow extending enum

2023-03-29 Thread Davey Shafik
> On Mar 29, 2023, at 06:56, Rowan Tommins wrote: > > On Wed, 29 Mar 2023 at 14:22, Rokas Šleinius wrote: > >> Ok so I am trying to find the argumentation here: >>> This is by design. >>> The point of enums is to be limiting. >> This is clearly an assumption. That statement is not in the

Re: [PHP-DEV] [RFC] Treat namespaced names as single token, relax reserved keyword restrictions

2020-06-16 Thread Davey Shafik
On Tue, Jun 16, 2020 at 1:34 PM Nikita Popov wrote: > On Tue, Jun 16, 2020 at 10:28 PM Davey Shafik wrote: > >> >> >> On Tue, Jun 16, 2020 at 1:52 AM Nikita Popov >> wrote: >> >>> Hi internals, >>> >>> Inspired by the

Re: [PHP-DEV] [RFC] Treat namespaced names as single token, relax reserved keyword restrictions

2020-06-16 Thread Davey Shafik
On Tue, Jun 16, 2020 at 1:52 AM Nikita Popov wrote: > Hi internals, > > Inspired by the recent discussion on reserved keyword reservation, I'd like > to propose the following RFC: > > https://wiki.php.net/rfc/namespaced_names_as_token > > This RFC makes two related changes: Treat namespaced

Re: [PHP-DEV] [RFC][DISCUSSION] Match expression v2

2020-05-23 Thread Davey Shafik
On Fri, May 22, 2020 at 4:09 AM Ilija Tovilo wrote: > Hi internals > > I'd like to announce the match expression v2 RFC: > https://wiki.php.net/rfc/match_expression_v2 > > The goal of the new draft is to be as simple and uncontroversial as > possible. It differs from v1 in the following ways: >

Re: [PHP-DEV] HTTP/1.1 by default in PHP 8.0

2020-05-23 Thread Davey Shafik
dopOn Fri, May 22, 2020 at 3:58 AM Nikita Popov wrote: > On Thu, May 21, 2020 at 11:54 PM Rowan Tommins > wrote: > > > Hi all, > > > > A few years ago, I posted a message suggesting that PHP improve support > > for HTTP/1.1 in its stream wrapper functions: > > https://externals.io/message/96192

Re: [PHP-DEV] [RFC] <> Attribute

2020-05-07 Thread Davey Shafik
On Thu, May 7, 2020 at 01:18 Benjamin Eberlei wrote: > > > On Thu, May 7, 2020 at 10:10 AM Davey Shafik wrote: > >> >> >> On Thu, May 7, 2020 at 00:22 Benjamin Eberlei >> wrote: >> >>> Hi everyone, >>> >>> The attributes

Re: [PHP-DEV] [RFC] <> Attribute

2020-05-07 Thread Davey Shafik
On Thu, May 7, 2020 at 00:22 Benjamin Eberlei wrote: > Hi everyone, > > The attributes RFC specifically looked into the use of attributes at the > engine/compiler level. > > To have a showcase of this with the 8.0 release I want to propose this RFC > for a <> attribute: > >

Re: [PHP-DEV] Renaming PhpAttribute to Attribute

2020-05-02 Thread Davey Shafik
On Wed, Apr 29, 2020 at 08:24 Benas IML wrote: > Hello, > > > Again, your assumption that just about everyone uses namespaced classes > > doesn't take into account closed source projects. I don't care if it's a > major > > release or not - BC breaks should always be avoided without a major >

Re: [PHP-DEV] RFC proposal: Provide support for XSLT 3.0, XPath 3.1, and XQuery 3.1

2017-10-04 Thread Davey Shafik
On Tue, Oct 3, 2017 at 1:29 PM, Walter Parker wrote: > On Tue, Oct 3, 2017 at 7:51 AM, Dan Ackroyd > wrote: > > > Hi O'Neil, > > > > On 3 October 2017 at 10:04, O'Neil Delpratt wrote: > > > Hi, > > > > > > We are considering

Re: [PHP-DEV] "Reader" as alternative to Iterator

2017-07-06 Thread Davey Shafik
I believe the correct solution to this is an OuterIterator — an OuterIterator contains the logic to constrain the loop, for example, we have the LimitIterator, FilterIterator, RegexIterator, etc. See this example: http://php.net/manual/en/class.limititerator.php#example-4473 You can build your

Re: [PHP-DEV] Re: [RFC] Distrust SHA-1 Certificates

2017-07-04 Thread Davey Shafik
It should be noted that Certificate Authorities (CAs) haven't been issuing SHA-1 certs since December 31st 2015. I think the best solution if possible, would be to treat MD5 and SHA-1 certs as invalid in _all_ supported versions of PHP and requiring that the verify_peer option be set to false to

Re: [PHP-DEV] PHP_OS_FAMILY and macOS

2017-06-13 Thread Davey Shafik
Given that iPad (and iPhone) both run iOS which is based on Darwin, and Apple just relaxed the rules on running interpreted code, and we are already seeing IDEs spring up for the device, we should use "Darwin", rather than "Mac". This also encompasses other distros like PureDarwin. - Davey On

Re: [PHP-DEV] Re: [RFC] [VOTE] Arrays starting with a negative index

2017-06-12 Thread Davey Shafik
Pedro, It would be best to just kill the vote and start over. The proposal should be for deprecation notice in 7.2 and implementation in 8.0 IMO — it should be one vote, as doing both together should be the only option. - Davey On Sun, Jun 11, 2017 at 8:25 AM, Pedro Magalhães

Re: [PHP-DEV] [7.2] Timetable

2017-04-22 Thread Davey Shafik
As I recall the 7.1.0 release process there was never a time when a scheduled release didn't have enough changes to warrant it. I think consistently scheduled releases give us a few things: - Early access to changes as they progress - Predictable timelines - No rush to get a bunch of things in

Re: [PHP-DEV] PHP 7.2 Release Managers

2017-04-07 Thread Davey Shafik
Thanks Remi! As the Release Process RFC requires two RMs[1], are you and Sara willing to collaborate as a team for 7.2? If not, you will each have to find a second team-mate :) - Davey [1] https://wiki.php.net/rfc/releaseprocess#release_managers_selection On Thu, Apr 6, 2017 at 9:44 PM, Remi

Re: [PHP-DEV] PHP 7.2 Release Managers

2017-03-30 Thread Davey Shafik
As a reminder, this thread is just for folks to throw their hat in the ring. There will be a formal vote on the wiki to pick the actual RM (assuming anyone else volunteers!). - Davey P.S. +1 ;) On Thu, Mar 30, 2017 at 10:34 AM, Christoph M. Becker wrote: > On 28.03.2017 at

Re: [PHP-DEV] ; on the end of the line

2017-03-30 Thread Davey Shafik
On Wed, Mar 29, 2017 at 11:10 PM, dmitr y wrote: > Hello, dear coders. > I'm using php for a year and it's being my favourite language. Also I'm > using some bookkeping languages which is based on php syntax but ';' on the > end of the line is not neccesary on it. > So I can't

Re: [PHP-DEV] [RFC][VOTE] Binary String Deprecation

2017-02-16 Thread Davey Shafik
I personally think there is value in marking strings as binary using the 'b' even if PHP currently doesn't differentiate, from a developer friendliness perspective. It shows intent, and informs the reader of what to expect if they inspect the value. If anything, the only change I'd make, if

Re: [PHP-DEV] [RFC][Discussion] ServerRequest and ServerResponse objects

2017-01-10 Thread Davey Shafik
On Mon, Jan 9, 2017 at 10:43 AM, Paul Jones wrote: > > > On Jan 7, 2017, at 15:41, Joe Watkins wrote: > > > > That doesn't sound like a positive consensus that this is a good idea, > it is rather the opposite. > > Not to get into interpretations of

Re: [PHP-DEV] PHP 5.6 end of active support

2016-12-14 Thread Davey Shafik
On Wed, Dec 14, 2016 at 7:15 AM, Dennis Clarke wrote: > On 12/14/2016 06:35 AM, Kalle Sommer Nielsen wrote: > >> Hi >> >> On Dec 14, 2016 12:23, "Christoph M. Becker" wrote: >> >>> >>> Hi! >>> >>> The end of active support for PHP 5.6 is documented to

Re: [PHP-DEV][RFC][DISCUSSION] - Immutable classes and properties

2016-12-11 Thread Davey Shafik
On Sun, Dec 11, 2016 at 7:40 PM, Mathieu Rochette wrote: > > > On 12/12/2016 01:16 AM, Silvio Marijić wrote: > > This have occurred to me also, I wanted to separate that into two RFC's, > > but then how we deal with RFC's that depend on each other? > well that's just my

Re: [PHP-DEV] Re: [RFC] Debugging PDO Prepared Statement Emulation v2

2016-12-05 Thread Davey Shafik
This issue is not difficult to solve in userland, at least well enough for debugging in my experience. Here's an older example I wrote up on my blog that worked (but I'm told is broken right now): https://daveyshafik.com/archives/605-debugging-pdo-prepared-statements.html Thanks, - Davey On

Re: [PHP-DEV] php.net mailing setup owner?

2016-12-01 Thread Davey Shafik
On Thu, Dec 1, 2016 at 2:48 PM, Rasmus Lerdorf wrote: > On Thu, Dec 1, 2016 at 8:00 AM, Derick Rethans wrote: > > > > I think it's time to retire Ecelerity. Nobody knows how it works. if > > It'd be postfix, I would likely have checked one of these ghost mail

Re: [PHP-DEV] PHP 7.1.0 GA

2016-11-23 Thread Davey Shafik
On Wed, Nov 23, 2016 at 9:12 AM, David Zuelke wrote: > On 22.11.2016, at 19:36, Joe Watkins wrote: > > > Evening internals, > > > > I'm excited to announce that PHP 7.1.0 will be GA on December 1st. > > > > It has taken a lot of hard work from a lot of

Re: [PHP-DEV] DateTime microseconds discussion

2016-11-08 Thread Davey Shafik
On Tue, Nov 8, 2016 at 6:28 AM, Alice Wonder wrote: > On 11/08/2016 04:16 AM, Arjen Schol wrote: > >> Hi Dan, >> >> I think you make some bad assumptions here. The examples provided by >> Sjon are scripts submitted to 3v4l.org They may have bad assumptions, >> but are real

Re: [PHP-DEV] [RFC] Convert numeric keys in object/array casts

2016-10-23 Thread Davey Shafik
This has been the case since 4.3 at the least: https://3v4l.org/bjZ4d On Sat, Oct 22, 2016 at 22:48 Yasuo Ohgaki wrote: > On Sun, Oct 23, 2016 at 4:59 AM, Yasuo Ohgaki wrote: > > Numeric key name must be string? > > > > $obj->{'0'} = 1; > > > > or could

Re: [PHP-DEV] PHP-7.1.0RC4

2016-10-19 Thread Davey Shafik
Thanks Joe! - Davey On Wed, Oct 19, 2016 at 3:48 AM, Joe Watkins wrote: > Morning internals, QA folks, > > I would like to announce the availability of PHP-7.1.0RC4. > > Downloads: http://downloads.php.net/~krakjoe/ > > php-7.1.0RC4.tar.bz2 > SHA256 hash: >

Re: [PHP-DEV] Re: Fixing insane session_start() behaviors

2016-10-19 Thread Davey Shafik
On Tue, Oct 18, 2016 at 11:08 PM, Stanislav Malyshev wrote: > Hi! > > > I pushed patch fixes number of nonsense/inconsistent session function > > behaviors. The additional patch is pushed so that it's easy to cherry > > pick minimum fixes. The last push is the additional

Re: [PHP-DEV] [!] Master merged into PHP-7.1

2016-10-13 Thread Davey Shafik
On Thu, Oct 13, 2016 at 12:20 PM, Lauri Kenttä <lauri.ken...@gmail.com> wrote: > On 2016-10-13 20:16, Davey Shafik wrote: > >> Can anyone shed some light on: >> >> 1) when it was merged >> 2) who merged it >> 3) how the dates a

[PHP-DEV] [!] Master merged into PHP-7.1

2016-10-13 Thread Davey Shafik
and I have video proof from Aug ~29th (RC1 build) that it wasn't there then. My local PHP-7.1 branch also does not have this commit, and it's last commit was: commit 50059639c86a10fe11d6ec3eec2e690ee77afccc Author: Davey Shafik <m...@daveyshafik.com> Date: Wed Oct 5 13:07:47 2016 -0700 S

Re: [PHP-DEV] OpenSSL ext status including port to OpenSSL 1.1

2016-10-11 Thread Davey Shafik
Remi, I'm glad this was followed up on, it is likely the source of a reported issue! 7.1 no longer supports LibreSSL due to the usage of some new openssl changes, you can find the errors http://awel.domblogger. net/7/php7/ssl_error.txt and a patch by the reporter here:

Re: [PHP-DEV] Regression between RC1 and RC2?

2016-10-07 Thread Davey Shafik
Yes, we should not mask the exception. The behavior in 7.0/7.1.0RC1 is much better IMO. (As seen here: https://3v4l.org/EJpD4#v700) - Davey On Fri, Oct 7, 2016 at 12:52 PM, Nikita Popov wrote: > On Fri, Oct 7, 2016 at 9:31 PM, Derick Rethans wrote: > > >

Re: [PHP-DEV] Intention to move mcrypt to PECL

2016-10-05 Thread Davey Shafik
On Wed, Oct 5, 2016 at 8:11 PM, Pierre Joye wrote: > hi Leigh, > > On Tue, Oct 4, 2016 at 11:58 PM, Leigh wrote: > > Hello list, > > > > It is my intention to create a new PECL package for ext/mcrypt, so > > that it can be removed from master as per the

Re: [PHP-DEV] [RFC][DISCUSSION] Improve uniqid() uniqueness

2016-10-03 Thread Davey Shafik
On Sunday, October 2, 2016, Yasuo Ohgaki wrote: > Hi all, > > On Mon, Oct 3, 2016 at 3:56 AM, Yasuo Ohgaki wrote: > > Besides improving "more entropy" the default and data, I prepared > > fully compatible patch to simplify discussion. > > > >

[PHP-DEV] PHP 7.1.0RC3 is available for testing

2016-09-29 Thread Davey Shafik
Hi, PHP 7.1.0RC3 was just released and can be downloaded from: https://downloads.php.net/~davey/ The Windows binaries are available at http://windows.php.net/qa/ This release contains a number of bugfixes. For the list of bugfixes that you can target in your testing, please refer to

[PHP-DEV] [RFC] [FAILED] Add PHP Engine Identifier Constant

2016-09-26 Thread Davey Shafik
Hey all, Just a quick note (a couple of days late, sorry) that the vote for the RFC " Add PHP Engine Identifier Constant" failed, 8 to 9. I'll consider this RFC closed at this point. Thanks all! - Davey

Re: [PHP-DEV] Server-Side Request/Response Objects

2016-09-26 Thread Davey Shafik
On Mon, Sep 26, 2016 at 2:32 PM, Rowan Collins wrote: > On 26/09/2016 20:37, Paul Jones wrote: > >> tl;dr: Gauging interest in an extension for server-side PHP request and >> response objects (*not* HTTP messages per se; see below) prior to writing >> an RFC for them on

[PHP-DEV] PHP 7.1.0RC2 is available for testing

2016-09-16 Thread Davey Shafik
Hi, The first release candidate for PHP 7.1.0, RC2 was just released and can be downloaded from: https://downloads.php.net/~davey/ The Windows binaries are available at http://windows.php.net/qa/ For the list of bug fixes and other changes that you can target in your testing, please

Re: [PHP-DEV] [RFC] [VOTE] Add PHP Engine Constant Identifier

2016-09-09 Thread Davey Shafik
On Fri, Sep 9, 2016 at 6:09 PM, Davey Shafik <da...@php.net> wrote: > On Fri, Sep 9, 2016 at 6:05 PM, Stanislav Malyshev <smalys...@gmail.com> > wrote: > >> Hi! >> >> > As noted last week, I'm now opening up the vote for adding a PHP Engine >

Re: [PHP-DEV] [RFC] [VOTE] Add PHP Engine Constant Identifier

2016-09-09 Thread Davey Shafik
On Fri, Sep 9, 2016 at 6:05 PM, Stanislav Malyshev wrote: > Hi! > > > As noted last week, I'm now opening up the vote for adding a PHP Engine > > Identifier constant to PHP 7.2+ (and more importantly, to the language > > spec). Additionally, there is a second vote to add

Re: [PHP-DEV] [RFC] [VOTE] Add PHP Engine Constant Identifier

2016-09-09 Thread Davey Shafik
. There are tons of places this _may_ be useful, and there's zero impact to adding it. - Davey On Fri, Sep 9, 2016 at 5:42 PM, Kalle Sommer Nielsen <ka...@php.net> wrote: > Hi Davey > > 2016-09-10 1:49 GMT+02:00 Davey Shafik <da...@php.net>: > > Hi all, > > > >

[PHP-DEV] [RFC] [VOTE] Add PHP Engine Constant Identifier

2016-09-09 Thread Davey Shafik
Hi all, As noted last week, I'm now opening up the vote for adding a PHP Engine Identifier constant to PHP 7.2+ (and more importantly, to the language spec). Additionally, there is a second vote to add corresponding PHP_ENGINE_(*_)VERSION(_ID) constants.

Re: [PHP-DEV] [RFC] Deprecate PEAR/PECL & Replace withcomposer/pickle

2016-09-08 Thread Davey Shafik
On Thu, Sep 8, 2016 at 3:18 PM, Lester Caine wrote: > On 08/09/16 18:40, Larry Garfield wrote: > > Note: Whether that is a good trend or bad trend I will not claim, and > > that is largely irrelevant. But that is where the river is running, and > > trying to swim upstream

Re: [PHP-DEV] [RFC] Deprecate PEAR/PECL & Replace with composer/pickle

2016-09-08 Thread Davey Shafik
On Thu, Sep 8, 2016 at 1:34 AM, Michael Morris wrote: > On Thu, Sep 8, 2016 at 4:27 AM, Daniel Morris > wrote: > > > On Thu, 8 Sep 2016, at 08:43 AM, Tony Marston wrote: > > > Perhaps users could be prevented from making such basic mistakes if > they

Re: [PHP-DEV] Re: [PREVOTE] PHP Engine Constants

2016-09-06 Thread Davey Shafik
On Tue, Sep 6, 2016 at 2:51 PM, Dan Ackroyd <dan...@basereality.com> wrote: > On 6 September 2016 at 22:39, Davey Shafik <da...@php.net> wrote: > > > > > > The key to this is that it's part of the spec. If you actually want to > > follow the spec, you have

Re: [PHP-DEV] Re: [PREVOTE] PHP Engine Constants

2016-09-06 Thread Davey Shafik
On Tue, Sep 6, 2016 at 1:32 PM, Dan Ackroyd <dan...@basereality.com> wrote: > On 5 September 2016 at 19:43, Davey Shafik <da...@php.net> wrote: > > > > Instead, it would be better to check PHP_ENGINE === > > 'hhvm' && PHP_ENGINE_VERSION_ID <= 3081

Re: [PHP-DEV] Missing reflection info about strict types?

2016-09-05 Thread Davey Shafik
On Mon, Sep 5, 2016 at 1:13 PM, Nicolas Grekas wrote: > > Why do you concatenate these files in the first place? > > > > > > It's not specifically me but Symfony's ClassCollectionLoader::load() > method, which generates a single file with common classes inlined for >

Re: [PHP-DEV] [RFC] Deprecate PEAR/PECL & Replace with composer/pickle

2016-09-05 Thread Davey Shafik
On Mon, Sep 5, 2016 at 8:31 AM, Michael Morris wrote: > Please be cautious - composer isn't a complete replacement for PEAR > because it doesn't behave the same way. For the most part this is a good > thing, but please consider the following. > > On not one but two occasions

Re: [PHP-DEV] [RFC] Deprecate PEAR/PECL & Replace with composer/pickle

2016-09-05 Thread Davey Shafik
On Mon, Sep 5, 2016 at 8:57 AM, Lester Caine wrote: > On 05/09/16 16:31, Michael Morris wrote: > > Also, as Tony Marston pointed out, there are CPanel systems that allow > the > > pear libraries to be managed from a web gui. Given time I'm sure the > folks > > at cpanel will

Re: [PHP-DEV] Re: [PREVOTE] PHP Engine Constants

2016-09-05 Thread Davey Shafik
On Mon, Sep 5, 2016 at 11:19 AM, Andrea Faulds <a...@ajf.me> wrote: > Hi Davey, > > Davey Shafik wrote: > >> A while back I brought a small RFC to internals, that proposed a set of >> constants that were specifically for alternative implementations to >> iden

Re: [PHP-DEV] Missing reflection info about strict types?

2016-09-05 Thread Davey Shafik
> On Sep 5, 2016, at 02:38, Nicolas Grekas wrote: > > Hello, > > It looks like we miss a way to check by reflection if a function/method has > strict types enabled or not. > > We'd need to do this in Symfony to generate a file with concatenated > classes, but split

Re: [PHP-DEV] Non-conflicting PHP 5 and 7 builds

2016-09-04 Thread Davey Shafik
Jordan, This was a choice they made, yet the author of the Debian/Ubuntu packages has side-by-side installable versions from 5.5-7.1 in his own PPA: https://launchpad.net/~ondrej/+archive/ubuntu/php It's not only currently feasible, it has been done, the _project_ chose not to do it. - Davey

Re: [PHP-DEV] [RFC] Deprecate PEAR/PECL & Replace with composer/pickle

2016-09-03 Thread Davey Shafik
On Sat, Sep 3, 2016 at 2:53 PM, Rowan Collins wrote: > On 03/09/2016 19:44, Lester Caine wrote: > >> So this RFC is simply proposing that PHP-FIG becomes the standard for >> writing PHP code? >> > > No, that is not at all what this RFC is proposing. The RFC is simply >

Re: [PHP-DEV] [RFC] Deprecate PEAR/PECL & Replace with composer/pickle

2016-09-02 Thread Davey Shafik
On Fri, Sep 2, 2016 at 12:57 PM, James Gilliland <neclim...@gmail.com> wrote: > On Fri, Sep 2, 2016 at 2:33 PM Davey Shafik <m...@daveyshafik.com> wrote: > > > Hi internals, > > > > I'd like to introduce a new RFC to deprecate pear/pecl (in 7.2, and > remo

[PHP-DEV] Re: [RFC] Deprecate PEAR/PECL & Replace with composer/pickle

2016-09-02 Thread Davey Shafik
adoption of composer on the general communities part. We should probably also have some conversations about actually sunsetting the PEAR and PECL sites and deprovisioning those resources. But that's a whole other conversation ;) - Davey On Fri, Sep 2, 2016 at 12:32 PM, Davey Shafik &l

[PHP-DEV] [RFC] Deprecate PEAR/PECL & Replace with composer/pickle

2016-09-02 Thread Davey Shafik
Hi internals, I'd like to introduce a new RFC to deprecate pear/pecl (in 7.2, and remove in 8.0), as well as add composer/pickle (optional in 7.2, default in 7.3+) in their place. https://wiki.php.net/rfc/deprecate-pear-include-composer I highly recommend reading the twitter poll and

Re: [PHP-DEV] SQLite 3.14

2016-09-02 Thread Davey Shafik
Good find with that other test! I don't see any reason not to fix it for 5.6+ - Davey On Fri, Sep 2, 2016 at 12:08 PM, Christoph M. Becker <cmbecke...@gmx.de> wrote: > On 31.08.2016 at 05:46, Davey Shafik wrote: > > > Sorry, I dropped the ball on this one: > >

Re: [PHP-DEV] [RFC][VOTE] Deprecate then Remove Mcrypt Closed (23-6)

2016-09-02 Thread Davey Shafik
e Enterprises <https://paragonie.com> >> >> On Fri, Sep 2, 2016 at 11:18 AM, Davey Shafik <da...@php.net> wrote: >> >>> I would still be OK adding this in RC2, TBH. I didn't realize it was >>> missed, and it's something we _need_ to do. >>> >&

Re: [PHP-DEV] [RFC][VOTE] Deprecate then Remove Mcrypt Closed (23-6)

2016-09-02 Thread Davey Shafik
I would still be OK adding this in RC2, TBH. I didn't realize it was missed, and it's something we _need_ to do. - Davey On Fri, Sep 2, 2016 at 8:08 AM, Leigh wrote: > On 22 March 2016 at 17:00, Scott Arciszewski wrote: > > Hi all, > > > >

Re: [PHP-DEV] [PREVOTE] PHP Engine Constants

2016-09-01 Thread Davey Shafik
On Thu, Sep 1, 2016 at 12:04 PM, Fleshgrinder <p...@fleshgrinder.com> wrote: > On 9/1/2016 8:02 PM, Davey Shafik wrote: > > Hey all, > > > > A while back I brought a small RFC to internals, that proposed a set of > > constants that were specifically for alternativ

[PHP-DEV] [PREVOTE] PHP Engine Constants

2016-09-01 Thread Davey Shafik
Hey all, A while back I brought a small RFC to internals, that proposed a set of constants that were specifically for alternative implementations to identify themselves as such if they want to conform to the spec. https://wiki.php.net/rfc/php_engine_constant There were some folks who didn't

[PHP-DEV] PHP 7.1.0RC1 is available for testing

2016-09-01 Thread Davey Shafik
Hi, The first release candidate for PHP 7.1.0, RC1 was just released and can be downloaded from: https://downloads.php.net/~davey/ The Windows binaries are available at http://windows.php.net/qa/ For the list of bug fixes and other changes that you can target in your testing, please

Re: [PHP-DEV] SQLite 3.14

2016-08-30 Thread Davey Shafik
Change the path to be "../../../../../bad" to ensure it's outside the top-level of the script. Add a: chdir(__DIR__); at the top. Thoughts? On Fri, Aug 19, 2016 at 5:31 PM, Anatol Belski <anatol@belski.net> wrote: > Hi Davey, > > > -Original Message- > > Fr

Re: [PHP-DEV] Reverting "Too Few Arguments Exception" RFC

2016-08-27 Thread Davey Shafik
FTR, I've created a second PR, without the changes to the array functions: https://github.com/php/php-src/pull/2100 This way we can go either way. - Davey On Sat, Aug 27, 2016 at 1:57 AM, Christoph M. Becker wrote: > On 26.08.2016 at 16:48, Levi Morrison wrote: > > > On

Re: [PHP-DEV] Reverting "Too Few Arguments Exception" RFC

2016-08-25 Thread Davey Shafik
On Thu, Aug 25, 2016 at 8:12 PM, Christoph M. Becker <cmbecke...@gmx.de> wrote: > On 24.08.2016 at 18:45, Nikita Popov wrote: > > > On Aug 24, 2016 9:55 AM, "Davey Shafik" <da...@php.net> wrote: > >> > >> Given this thread: http://externals.

Re: [PHP-DEV] Reverting "Too Few Arguments Exception" RFC

2016-08-24 Thread Davey Shafik
gt; wrote: > On Aug 24, 2016 9:55 AM, "Davey Shafik" <da...@php.net> wrote: > > > > Hi all, > > > > Given this thread: http://externals.io/thread/233 > > > > I'm not happy with the state of this going into RC1 next week, and > without

[PHP-DEV] Reverting "Too Few Arguments Exception" RFC

2016-08-24 Thread Davey Shafik
Hi all, Given this thread: http://externals.io/thread/233 I'm not happy with the state of this going into RC1 next week, and without changes (such as the patch I provided), I would like to revert this change and leave it for 7.2. My patch will _retain_ BC for internal functions with non

Re: [PHP-DEV] Incorrect Argument Count Error

2016-08-22 Thread Davey Shafik
On Mon, Aug 22, 2016 at 5:59 PM, Derick Rethans <der...@php.net> wrote: > On Fri, 19 Aug 2016, Davey Shafik wrote: > > > b) a huge BC break (stuff that currently throws a warning in > > strict_types mode will now throw an exception, similar BC break as > > w

Re: [PHP-DEV] Incorrect Argument Count Error

2016-08-22 Thread Davey Shafik
On Fri, Aug 19, 2016 at 10:27 PM, Kalle Sommer Nielsen <ka...@php.net> wrote: > 2016-08-19 15:05 GMT+02:00 Davey Shafik <da...@php.net>: > > Hey Internals, > > > > I'm working on the patch to change the error exception to > > \ArgumentCountError inst

Re: [PHP-DEV] SQLite 3.14

2016-08-19 Thread Davey Shafik
Argh! Apologies for autocomplete adding that 'e' to your name! - Davey On Sat, Aug 20, 2016 at 03:09 Davey Shafik <da...@php.net> wrote: > Christophe, > > I got the failure multiple times in my Debian Jessie docker container that > I use for builds - you can check it out y

Re: [PHP-DEV] SQLite 3.14

2016-08-19 Thread Davey Shafik
cke...@gmx.de> wrote: > Hi Davey! > > On 19.08.2016 at 15:32, Davey Shafik wrote: > > > I saw this failure while packaging 7.1.0beta3, and assume it might be > > related to your update: > > > > FAIL SQLite3 open_basedir checks > > [ext/sqlite3/test

Re: [PHP-DEV] SQLite 3.14

2016-08-19 Thread Davey Shafik
Hey Christoph, I saw this failure while packaging 7.1.0beta3, and assume it might be related to your update: FAIL SQLite3 open_basedir checks [ext/sqlite3/tests/sqlite3_21_security.phpt] DIFF 006- 007- Warning: SQLite3::__construct(): open_basedir restriction in effect. File(%s)

[PHP-DEV] Incorrect Argument Count Error

2016-08-19 Thread Davey Shafik
Hey Internals, I'm working on the patch to change the error exception to \ArgumentCountError instead of \Error when too few, or too many arguments are passed in as discussed a couple of weeks ago. To be BC with 7.0, this extends \TypeError, which is the exception currently thrown when

Re: [PHP-DEV] Change to Too Few Args Exception RFC

2016-08-16 Thread Davey Shafik
Hey all, Can we please reach a resolution on this? - Davey On Sun, Aug 7, 2016 at 9:04 AM, Davey Shafik <da...@php.net> wrote: > AFAICT, to make this change, I'd have to modify: > > ZEND_API ZEND_COLD void zend_internal_type_error(zend_bool > throw_exception,

Re: [PHP-DEV] BC break with rand() where min > max

2016-08-08 Thread Davey Shafik
Leigh, I would _very_ much prefer to keep this BC. If we do the right thing, and there are no repercussions, I'd actually remove the warning. If you think we might want to disallow this in the future, use an E_DEPRECATED, but a warning seems pointless unless it's doing the wrong thing, or it's

Re: [PHP-DEV] Function auto-loading

2016-08-08 Thread Davey Shafik
On Mon, Aug 8, 2016 at 1:15 PM, Rasmus Schultz wrote: > > Unfortunately, function name resolution has this quirk that class name > resolution doesn't, so something's got to give. > > I suppose. > > Well, then, how about making the feature work consistently for all >

Re: [PHP-DEV] Function auto-loading

2016-08-07 Thread Davey Shafik
On Sun, Aug 7, 2016 at 12:32 PM, David Rodrigues wrote: > What should be the difference between a static method on a autoloaded > class? > > I guess that it could be done currently by use a static method. > In this case, I know exactly what method should be called,

Re: [PHP-DEV] Adding validate_var_array()/validate_input_array() to which version?

2016-08-07 Thread Davey Shafik
On Sun, Aug 7, 2016 at 8:20 AM, Niklas Keller wrote: > 2016-08-07 14:20 GMT+02:00 Pierre Joye : > > > On Aug 5, 2016 2:30 AM, "Yasuo Ohgaki" wrote: > > > > > > Hi Christian, > > > > > > On Thu, Aug 4, 2016 at 8:27 PM, Christian Stadler

Re: [PHP-DEV] Undocumented Nullable Return Behavior

2016-08-07 Thread Davey Shafik
nikita@gmail.com> wrote: > On Sun, Aug 7, 2016 at 9:07 AM, Davey Shafik <m...@daveyshafik.com> wrote: > >> Hi internals, >> >> In the nullable types we do not allow implicit return null/return with no >> value to fulfill a nullable type. >> >

[PHP-DEV] Undocumented Nullable Return Behavior

2016-08-07 Thread Davey Shafik
Hi internals, In the nullable types we do not allow implicit return null/return with no value to fulfill a nullable type. - No return will result in a TypeError when executed - Return with no value will be an actual fatal error, which I believe is due to the fact it's not found at runtime,

Re: [PHP-DEV] Change to Too Few Args Exception RFC

2016-08-06 Thread Davey Shafik
AFAICT, to make this change, I'd have to modify: ZEND_API ZEND_COLD void zend_internal_type_error(zend_bool throw_exception, const char *format, ...) /* {{{ */ To be: ZEND_API ZEND_COLD void zend_internal_type_error(zend_bool throw_exception, zend_class_entry *zend_error, const char *format, …)

Re: [PHP-DEV] Change to Too Few Args Exception RFC

2016-08-06 Thread Davey Shafik
On Sat, Aug 6, 2016 at 2:34 AM, Nikita Popov <nikita@gmail.com> wrote: > On Sat, Aug 6, 2016 at 4:26 AM, Davey Shafik <da...@php.net> wrote: > >> Hey all, >> >> I know this is a little late in the process, but it's something I've >> noti

Re: [PHP-DEV] Re: Change to Too Few Args Exception RFC

2016-08-06 Thread Davey Shafik
On Sat, Aug 6, 2016 at 8:18 AM, Dmitry Stogov <dmi...@zend.com> wrote: > >> I don't see a big problem accepting this. The change is really minor, and >> makes sense. >> >> Dmitry. >> >> On Aug 6, 2016 5:26 AM, Davey Shafik <da...@php.net> wrote: &g

[PHP-DEV] PHP 7.1.0beta2 is available for testing

2016-08-05 Thread Davey Shafik
Hi, PHP 7.1.0beta2 was just released and can be downloaded from: https://downloads.php.net/~davey/ The Windows binaries are available at http://windows.php.net/qa/ This release contains a number of bugfixes. For the list of bugfixes that you can target in your testing, please refer to

[PHP-DEV] Change to Too Few Args Exception RFC

2016-08-05 Thread Davey Shafik
Hey all, I know this is a little late in the process, but it's something I've noticed while prepping some content around 7.1. This RFC: https://wiki.php.net/rfc/too_few_args Passed, and has been implemented, but I feel that throwing an `\Error` exception is a mistake. I think we should another

Re: [PHP-DEV] Re: [RFC][VOTE] Session ID without hashing - Vote reopened and restarted

2016-08-03 Thread Davey Shafik
Hey Yasuo, Unfortunately this missed beta2 (tagged yesterday), I'll confirm with Joe about putting it in for 7.1beta3. Thanks for those last minute changes, I'm much happier with this result! :) - Davey On Tue, Aug 2, 2016 at 10:29 PM, Yasuo Ohgaki wrote: > Hi all, > >

Re: [PHP-DEV] [RFC][VOTE] New operator (short tag) for context-dependent escaping

2016-07-30 Thread Davey Shafik
This should definitely be a 2 week vote. - Davey On Sat, Jul 30, 2016 at 08:09 Michael Vostrikov wrote: > Hello. The RFC 'New operator (short tag) for context-dependent escaping' is > now in voting phase. > > https://wiki.php.net/rfc/escaping_operator > > This RFC

Re: [PHP-DEV] RFC Karma Request

2016-07-26 Thread Davey Shafik
ers. > > True str_begins and str_ends would do check if a string begins or ends > with a string of n characters. > > Regards, > > -Will > > > On 2016-07-26 19:39, Davey Shafik wrote: > >> Will, >> >> Now that we have generalized support for ne

Re: [PHP-DEV] RFC Karma Request

2016-07-26 Thread Davey Shafik
Will, Now that we have generalized support for negative string offsets you can now just do: $string = "/foo/bar/bat/"; if ($string[0] === "/") { // fully-qualified path } if ($string[-1] === "/") { // trailing "/" } This avoids the overhead of a function call, arguably is as expressive, and a

Re: [PHP-DEV] [RFC][VOTE] Session ID without hashing - Reopened

2016-07-25 Thread Davey Shafik
Looks good to me, go for it :) Thanks, - Davey On Mon, Jul 25, 2016 at 2:14 AM, Yasuo Ohgaki <yohg...@ohgaki.net> wrote: > Hi Davey, > > On Mon, Jul 25, 2016 at 5:46 PM, Yasuo Ohgaki <yohg...@ohgaki.net> wrote: > > > > On Mon, Jul 25, 2016 at 4:09 PM, D

Re: [PHP-DEV] Bundled SQLlite3

2016-07-25 Thread Davey Shafik
I'd like to see an updated SQLite in 7.1, this is part of shoring up the stability of the release IMO. - Davey On Sun, Jul 24, 2016 at 11:57 PM, Anatol Belski wrote: > Hi Christoph, > > > -Original Message- > > From: Christoph Becker [mailto:cmbecke...@gmx.de] >

Re: [PHP-DEV] [RFC][VOTE] Session ID without hashing - Reopened

2016-07-25 Thread Davey Shafik
My suggestion: Re-start the vote, three options: Yes, new defaults (BC Break), Yes, old defaults (no BC break), No OR: add a second vote to the page, with: Use new defaults (BC Break), Use Old Defaults (No BC Break) On Sun, Jul 24, 2016 at 6:52 PM, Yasuo Ohgaki wrote: >

Re: [PHP-DEV] [RFC][VOTE] Session ID without hashing - Reopened

2016-07-24 Thread Davey Shafik
Just wanted to let you know I voted no because of the BC breaking change to the INI options that could easily break many custom session handlers — any session handler that stores the sessions in a fixed-width column will be broken. I'm fine changing the defaults in the php.ini-*, but not changing

Re: [PHP-DEV] [RFC][VOTE] Session ID without hashing - Reopened

2016-07-24 Thread Davey Shafik
Done, I guess it just needed a unique name, removing the first one kept the new one only :) - Davey On Sat, Jul 23, 2016 at 10:50 PM, Yasuo Ohgaki <yohg...@ohgaki.net> wrote: > Hi Davey, > > On Sun, Jul 24, 2016 at 2:37 PM, Davey Shafik <da...@php.net> wrote: > > &g

Re: [PHP-DEV] [RFC][VOTE] Session ID without hashing - Reopened

2016-07-23 Thread Davey Shafik
Yasuo, It didn't actually reopen, and just setting closed to false, it kept the original votes. So I added a second vote below. Bonus: the original is also preserved. Hope that's OK. - Davey On Sat, Jul 23, 2016 at 9:50 PM, Yasuo Ohgaki wrote: > Hi all, > > Due to a

Re: [PHP-DEV] Re: [RFC][VOTE] Session ID without hashing

2016-07-23 Thread Davey Shafik
Stas, The issue is that changes were made once the voting started, and some of us were waiting for the vote to restart: > I'd like to see the vote re-run (1 week?) with the changes in place. I didn't vote because I expected it to be restarted. I would have voted -1 on the current proposal.

Re: [PHP-DEV] PHP 5.5.38 is released

2016-07-22 Thread Davey Shafik
Thank you Julien and David for your hard work and a job well done! Congrats! :) - Davey On Fri, Jul 22, 2016 at 8:01 AM, Julien Pauli wrote: > Hi. > > The PHP development team announces the immediate availability of PHP > 5.5.38. > Several security related issues were fixed in

[PHP-DEV] Re: PHP 7.1.0beta1 Released

2016-07-21 Thread Davey Shafik
Downloads are actually at https://downloads.php.net/~ab/ And Thanks to Anatol for his assist with this release and for pushing these up. - Davey On Thu, Jul 21, 2016 at 2:37 AM, Davey Shafik <m...@daveyshafik.com> wrote: > Hi, > > The first beta for 7.1.0 was just released. Wi

[PHP-DEV] PHP 7.1.0beta1 Released

2016-07-21 Thread Davey Shafik
on Thursday August 8th. Thanks, Davey Shafik & Joe Watkins PHP 7.1 Release Managers php-7.1.0beta1.tar.bz2 SHA256 hash: 14b29e5a2cb13c071a7d70784ad3f43230cba09e4bda6d90c3c1dfaa070ac882 MD5 hash: 68fbd1bc98ba7c636dabc85698bc0046 PGP signature: -BEGIN PGP SIGNATURE- Version: GnuP

[PHP-DEV] PHP-7.1 Branched

2016-07-20 Thread Davey Shafik
Hey folks, as mentioned in the last release email, the PHP-7.1 branch has now been created. I will be creating the PHP 7.1.0beta1 release off it in the next few minutes. However, this effectively means that master is open for PHP 7.2 (or 8.0 :P) and any further commits specifically for 7.1 must

  1   2   >