[PHP-DEV] Error/Exception handlers chaining (Was: [PHP-DEV] Include XDebug and Suhosin Patch in Core for 5.5)

2013-03-01 Thread Patrick ALLAERT
2013/2/28 Derick Rethans der...@php.net: On Thu, 28 Feb 2013, Anthony Ferrara wrote: It appears that xdebug is borking generator exception handling. Without xdebug the following two tests pass, but with it they fail: Generator::throw() where the exception is caught in the generator

Re: [PHP-DEV] Include XDebug and Suhosin Patch in Core for 5.5

2013-03-01 Thread David Muir
On 01/03/2013, at 7:00 AM, Anthony Ferrara ircmax...@gmail.com wrote: Hey all, Based off of the recent discussion around pulling in ZO+ into core, I've come to the conclusion that we should also pull in XDebug and Suhosin into core at the same time. 1. It has integration issues with ZO+

Re: [PHP-DEV] Include XDebug and Suhosin Patch in Core for 5.5

2013-03-01 Thread Julien Pauli
On Fri, Mar 1, 2013 at 11:39 AM, David Muir davidkm...@gmail.com wrote: On 01/03/2013, at 7:00 AM, Anthony Ferrara ircmax...@gmail.com wrote: Hey all, Based off of the recent discussion around pulling in ZO+ into core, I've come to the conclusion that we should also pull in XDebug and

Re: [PHP-DEV] Include XDebug and Suhosin Patch in Core for 5.5

2013-03-01 Thread Julien Pauli
On Thu, Feb 28, 2013 at 9:13 PM, Stas Malyshev smalys...@sugarcrm.comwrote: Hi! Based off of the recent discussion around pulling in ZO+ into core, I've come to the conclusion that we should also pull in XDebug and Suhosin into core at the same time. Suhosin has multiple

Re: [PHP-DEV] Include XDebug and Suhosin Patch in Core for 5.5

2013-03-01 Thread Kalle Sommer Nielsen
Hi 2013/3/1 Julien Pauli jpa...@php.net: I guess the ini declaration order and then the order the modules get loaded in the engine. We could also look at implementing a module-load-order internally in the zend_module struct, as in some extensions like EXIF relies on mbstring, while the

Re: [PHP-DEV] Include XDebug and Suhosin Patch in Core for 5.5

2013-03-01 Thread Julien Pauli
On Fri, Mar 1, 2013 at 12:49 PM, Kalle Sommer Nielsen ka...@php.net wrote: Hi 2013/3/1 Julien Pauli jpa...@php.net: I guess the ini declaration order and then the order the modules get loaded in the engine. We could also look at implementing a module-load-order internally in the

Re: [PHP-DEV] Include XDebug and Suhosin Patch in Core for 5.5

2013-03-01 Thread Raymond Irving
I agree with adding XDebug to core distribution but it must be disabled by default. On Fri, Mar 1, 2013 at 8:28 AM, Julien Pauli jpa...@php.net wrote: On Fri, Mar 1, 2013 at 12:49 PM, Kalle Sommer Nielsen ka...@php.net wrote: Hi 2013/3/1 Julien Pauli jpa...@php.net: I guess the

[PHP-DEV] Include XDebug and Suhosin Patch in Core for 5.5

2013-02-28 Thread Anthony Ferrara
Hey all, Based off of the recent discussion around pulling in ZO+ into core, I've come to the conclusion that we should also pull in XDebug and Suhosin into core at the same time. 1. It has integration issues with ZO+ in that it has to be included in a specific order (specifically around ini

Re: [PHP-DEV] Include XDebug and Suhosin Patch in Core for 5.5

2013-02-28 Thread Stas Malyshev
Hi! Based off of the recent discussion around pulling in ZO+ into core, I've come to the conclusion that we should also pull in XDebug and Suhosin into core at the same time. Suhosin has multiple BC-incompatible and performance-problematic changes and limits and the author refused many times

Re: [PHP-DEV] Include XDebug and Suhosin Patch in Core for 5.5

2013-02-28 Thread Michael Wallner
[...] Sorry, but I hope you are in some funny sort of mood... Mike

Re: [PHP-DEV] Include XDebug and Suhosin Patch in Core for 5.5

2013-02-28 Thread Derick Rethans
On Thu, 28 Feb 2013, Anthony Ferrara wrote: Based off of the recent discussion around pulling in ZO+ into core, I've come to the conclusion that we should also pull in XDebug and Suhosin into core at the same time. Suhosin has a large performance impact (even the normal patch, without

Re: [PHP-DEV] Include XDebug and Suhosin Patch in Core for 5.5

2013-02-28 Thread Anthony Ferrara
Derick: On Thu, Feb 28, 2013 at 3:39 PM, Derick Rethans der...@php.net wrote: On Thu, 28 Feb 2013, Anthony Ferrara wrote: Based off of the recent discussion around pulling in ZO+ into core, I've come to the conclusion that we should also pull in XDebug and Suhosin into core at the same

Re: [PHP-DEV] Include XDebug and Suhosin Patch in Core for 5.5

2013-02-28 Thread Derick Rethans
On Thu, 28 Feb 2013, Anthony Ferrara wrote: It appears that xdebug is borking generator exception handling. Without xdebug the following two tests pass, but with it they fail: Generator::throw() where the exception is caught in the generator [Zend/tests/generators/throw_caught.phpt]

Re: [PHP-DEV] Include XDebug and Suhosin Patch in Core for 5.5

2013-02-28 Thread Adam Jon Richardson
On Thu, Feb 28, 2013 at 3:00 PM, Anthony Ferrara ircmax...@gmail.com wrote: 1. It has integration issues with ZO+ in that it has to be included in a specific order (specifically around ini declarations). If it was included into core, this could be accounted for allowing for more robust