Re: [PHP-DEV] Proposal to run all tests with and without strict_types enabled

2018-02-12 Thread Pedro Lacerda
2018-02-12 18:05 GMT-03:00 Rowan Collins : > > I think adding this to the language would be very controversial, because > it opens up the ability to undermine the "caller decides" concept of the > two scalar type modes. People on this list have openly said that they would

Re: [PHP-DEV] Proposal to run all tests with and without strict_types enabled

2018-02-12 Thread Rowan Collins
On 12 February 2018 05:50:56 GMT+00:00, Pedro Lacerda wrote: >Besides testing, may or may not be valuable expose a `__STRICT_TYPES__` >constant. I think adding this to the language would be very controversial, because it opens up the ability to undermine the "caller

Re: [PHP-DEV] Proposal to run all tests with and without strict_types enabled

2018-02-11 Thread Pedro Lacerda
> > 2018-02-11 20:34 GMT-03:00 Christoph M. Becker : >> >>> Umm, I wonder whether a magic constant (say, `__STRICT_TYPES__`) would >>> be more appropriate. >> >> Implement `__STRICT_TYPES__` was a breeze, very hackable codebase. A magic constant indeed sounds more appropriate.

Re: [PHP-DEV] Proposal to run all tests with and without strict_types enabled

2018-02-11 Thread Stanislav Malyshev
Hi! > My proposal is to run all tests with and without strict_types, skipping if > necessary, and increasing the code coverage. Depending of you overral > reception I'll create an RFC for it. I am not sure what would be the advantage of this. Beyond testing strict_types functionality itself