Re: [PATCH V10 08/11] iommu/vt-d: Add svm/sva invalidate function

2020-04-02 Thread Jacob Pan
On Wed, 1 Apr 2020 09:32:37 +0200 Auger Eric wrote: > > I didn’t read through all comments. Here is a concern with this 2-D > > table, the iommu cache type is defined as below. I suppose there is > > a problem here. If I'm using IOMMU_CACHE_INV_TYPE_PASID, it will > > beyond the 2-D table. > >

Re: [PATCH V10 08/11] iommu/vt-d: Add svm/sva invalidate function

2020-04-01 Thread Jacob Pan
On Wed, 1 Apr 2020 09:32:37 +0200 Auger Eric wrote: > >> devtlb > >> descriptor, that is why Eric suggests {0, 0, 1}. > > > > I think it should be {0, 0, 1} :-) addr field and S field are must, > > pasid field depends on G bit. > > On my side, I understood from the spec that addr/S are

Re: [PATCH V10 08/11] iommu/vt-d: Add svm/sva invalidate function

2020-04-01 Thread Jacob Pan
On Wed, 1 Apr 2020 06:57:42 + "Liu, Yi L" wrote: > > From: Tian, Kevin > > Sent: Wednesday, April 1, 2020 2:24 PM > > To: Jacob Pan > > Subject: RE: [PATCH V10 08/11] iommu/vt-d: Add svm/sva invalidate > > function > > > From: Jacob

Re: [PATCH V10 08/11] iommu/vt-d: Add svm/sva invalidate function

2020-04-01 Thread Auger Eric
Hi, On 4/1/20 9:13 AM, Liu, Yi L wrote: >> From: Tian, Kevin >> Sent: Wednesday, April 1, 2020 2:30 PM >> To: Jacob Pan >> Subject: RE: [PATCH V10 08/11] iommu/vt-d: Add svm/sva invalidate function >> >>> From: Jacob Pan >>> Sent: Wednesday, Apri

RE: [PATCH V10 08/11] iommu/vt-d: Add svm/sva invalidate function

2020-04-01 Thread Liu, Yi L
> From: Tian, Kevin > Sent: Wednesday, April 1, 2020 2:30 PM > To: Jacob Pan > Subject: RE: [PATCH V10 08/11] iommu/vt-d: Add svm/sva invalidate function > > > From: Jacob Pan > > Sent: Wednesday, April 1, 2020 4:58 AM > > > > On Tue, 31 Mar 2020

RE: [PATCH V10 08/11] iommu/vt-d: Add svm/sva invalidate function

2020-04-01 Thread Liu, Yi L
> From: Tian, Kevin > Sent: Wednesday, April 1, 2020 2:24 PM > To: Jacob Pan > Subject: RE: [PATCH V10 08/11] iommu/vt-d: Add svm/sva invalidate function > > > From: Jacob Pan > > Sent: Wednesday, April 1, 2020 2:14 AM > > > > On Sat, 28 Mar 2020

RE: [PATCH V10 08/11] iommu/vt-d: Add svm/sva invalidate function

2020-04-01 Thread Tian, Kevin
> From: Jacob Pan > Sent: Wednesday, April 1, 2020 5:08 AM > > On Tue, 31 Mar 2020 03:34:22 + > "Tian, Kevin" wrote: > > > > From: Auger Eric > > > Sent: Monday, March 30, 2020 12:05 AM > > > > > > On 3/28/20 11:01 AM, Tian, Kevin wrote: > > > >> From: Jacob Pan > > > >> Sent: Saturday,

RE: [PATCH V10 08/11] iommu/vt-d: Add svm/sva invalidate function

2020-04-01 Thread Tian, Kevin
> From: Jacob Pan > Sent: Wednesday, April 1, 2020 4:58 AM > > On Tue, 31 Mar 2020 02:49:21 + > "Tian, Kevin" wrote: > > > > From: Auger Eric > > > Sent: Sunday, March 29, 2020 11:34 PM > > > > > > Hi, > > > > > > On 3/28/20 11:01 AM, Tian, Kevin wrote: > > > >> From: Jacob Pan > > > >>

RE: [PATCH V10 08/11] iommu/vt-d: Add svm/sva invalidate function

2020-04-01 Thread Tian, Kevin
> From: Jacob Pan > Sent: Wednesday, April 1, 2020 2:14 AM > > On Sat, 28 Mar 2020 10:01:42 + > "Tian, Kevin" wrote: > > > > From: Jacob Pan > > > Sent: Saturday, March 21, 2020 7:28 AM > > > > > > When Shared Virtual Address (SVA) is enabled for a guest OS via > > > vIOMMU, we need to

Re: [PATCH V10 08/11] iommu/vt-d: Add svm/sva invalidate function

2020-03-31 Thread Jacob Pan
On Sun, 29 Mar 2020 18:05:47 +0200 Auger Eric wrote: > Hi Jacob, > > On 3/21/20 12:27 AM, Jacob Pan wrote: > > When Shared Virtual Address (SVA) is enabled for a guest OS via > > vIOMMU, we need to provide invalidation support at IOMMU API and > > driver level. This patch adds Intel VT-d

Re: [PATCH V10 08/11] iommu/vt-d: Add svm/sva invalidate function

2020-03-31 Thread Jacob Pan
On Tue, 31 Mar 2020 03:34:22 + "Tian, Kevin" wrote: > > From: Auger Eric > > Sent: Monday, March 30, 2020 12:05 AM > > > > On 3/28/20 11:01 AM, Tian, Kevin wrote: > > >> From: Jacob Pan > > >> Sent: Saturday, March 21, 2020 7:28 AM > > >> > > >> When Shared Virtual Address (SVA) is

Re: [PATCH V10 08/11] iommu/vt-d: Add svm/sva invalidate function

2020-03-31 Thread Jacob Pan
On Tue, 31 Mar 2020 02:49:21 + "Tian, Kevin" wrote: > > From: Auger Eric > > Sent: Sunday, March 29, 2020 11:34 PM > > > > Hi, > > > > On 3/28/20 11:01 AM, Tian, Kevin wrote: > > >> From: Jacob Pan > > >> Sent: Saturday, March 21, 2020 7:28 AM > > >> > > >> When Shared Virtual Address

Re: [PATCH V10 08/11] iommu/vt-d: Add svm/sva invalidate function

2020-03-31 Thread Jacob Pan
On Sat, 28 Mar 2020 10:01:42 + "Tian, Kevin" wrote: > > From: Jacob Pan > > Sent: Saturday, March 21, 2020 7:28 AM > > > > When Shared Virtual Address (SVA) is enabled for a guest OS via > > vIOMMU, we need to provide invalidation support at IOMMU API and > > driver level. This patch adds

RE: [PATCH V10 08/11] iommu/vt-d: Add svm/sva invalidate function

2020-03-30 Thread Tian, Kevin
> From: Auger Eric > Sent: Monday, March 30, 2020 12:05 AM > > On 3/28/20 11:01 AM, Tian, Kevin wrote: > >> From: Jacob Pan > >> Sent: Saturday, March 21, 2020 7:28 AM > >> > >> When Shared Virtual Address (SVA) is enabled for a guest OS via > >> vIOMMU, we need to provide invalidation support

RE: [PATCH V10 08/11] iommu/vt-d: Add svm/sva invalidate function

2020-03-30 Thread Tian, Kevin
> From: Auger Eric > Sent: Sunday, March 29, 2020 11:34 PM > > Hi, > > On 3/28/20 11:01 AM, Tian, Kevin wrote: > >> From: Jacob Pan > >> Sent: Saturday, March 21, 2020 7:28 AM > >> > >> When Shared Virtual Address (SVA) is enabled for a guest OS via > >> vIOMMU, we need to provide invalidation

Re: [PATCH V10 08/11] iommu/vt-d: Add svm/sva invalidate function

2020-03-29 Thread Auger Eric
Hi Jacob, On 3/21/20 12:27 AM, Jacob Pan wrote: > When Shared Virtual Address (SVA) is enabled for a guest OS via > vIOMMU, we need to provide invalidation support at IOMMU API and driver > level. This patch adds Intel VT-d specific function to implement > iommu passdown invalidate API for shared

Re: [PATCH V10 08/11] iommu/vt-d: Add svm/sva invalidate function

2020-03-29 Thread Auger Eric
On 3/28/20 11:01 AM, Tian, Kevin wrote: >> From: Jacob Pan >> Sent: Saturday, March 21, 2020 7:28 AM >> >> When Shared Virtual Address (SVA) is enabled for a guest OS via >> vIOMMU, we need to provide invalidation support at IOMMU API and driver >> level. This patch adds Intel VT-d specific

Re: [PATCH V10 08/11] iommu/vt-d: Add svm/sva invalidate function

2020-03-29 Thread Auger Eric
Hi, On 3/28/20 11:01 AM, Tian, Kevin wrote: >> From: Jacob Pan >> Sent: Saturday, March 21, 2020 7:28 AM >> >> When Shared Virtual Address (SVA) is enabled for a guest OS via >> vIOMMU, we need to provide invalidation support at IOMMU API and driver >> level. This patch adds Intel VT-d specific

RE: [PATCH V10 08/11] iommu/vt-d: Add svm/sva invalidate function

2020-03-28 Thread Tian, Kevin
> From: Jacob Pan > Sent: Saturday, March 21, 2020 7:28 AM > > When Shared Virtual Address (SVA) is enabled for a guest OS via > vIOMMU, we need to provide invalidation support at IOMMU API and driver > level. This patch adds Intel VT-d specific function to implement > iommu passdown invalidate

[PATCH V10 08/11] iommu/vt-d: Add svm/sva invalidate function

2020-03-20 Thread Jacob Pan
When Shared Virtual Address (SVA) is enabled for a guest OS via vIOMMU, we need to provide invalidation support at IOMMU API and driver level. This patch adds Intel VT-d specific function to implement iommu passdown invalidate API for shared virtual address. The use case is for supporting caching