Re: [Ipmitool-devel] Code Review - ID: 3595612 - ask for password once only if used

2013-01-15 Thread Ales Ledvinka
- Original Message - From: Zdenek Styblik zdenek.styb...@gmail.com To: Ales Ledvinka aledv...@redhat.com Cc: ipmitool-devel ipmitool-devel@lists.sourceforge.net Sent: Tuesday, January 15, 2013 2:23:51 PM Subject: Re: Code Review - ID: 3595612 - ask for password once only if used

Re: [Ipmitool-devel] Code Review - ID: 3595612 - ask for password once only if used

2013-01-15 Thread Zdenek Styblik
On Tue, Jan 15, 2013 at 3:03 PM, Zdenek Styblik zdenek.styb...@gmail.com wrote: On Tue, Jan 15, 2013 at 2:54 PM, Ales Ledvinka aledv...@redhat.com wrote: [...] Sure. For the specific corner cases that I overlooked. Unlikely to be used by anyone. Rather then dropping the compatibility for

Re: [Ipmitool-devel] Code Review - ID: 3595612 - ask for password once only if used

2013-01-15 Thread Ales Ledvinka
- Original Message - From: Zdenek Styblik zdenek.styb...@gmail.com To: Ales Ledvinka aledv...@redhat.com Cc: ipmitool-devel ipmitool-devel@lists.sourceforge.net Sent: Tuesday, January 15, 2013 3:03:28 PM Subject: Re: Code Review - ID: 3595612 - ask for password once only if used

Re: [Ipmitool-devel] Code Review - ID: 3595612 - ask for password once only if used

2013-01-14 Thread Ales Ledvinka
Hello, Skip the Friday replies. Too hastily to be correct. Now about the option handling inconsistency. The -Y and -a with your last 2nd skip now: 1) -E -P -a result from last (-a) 2) -a -E -P -a result from last-1 (-P) 3) -E -a -P result from last (-P) 1st asks that's ok. 2nd

Re: [Ipmitool-devel] Code Review - ID: 3595612 - ask for password once only if used

2013-01-14 Thread Zdenek Styblik
On Mon, Jan 14, 2013 at 4:07 PM, Ales Ledvinka aledv...@redhat.com wrote: Hello, Skip the Friday replies. Too hastily to be correct. Now about the option handling inconsistency. The -Y and -a with your last 2nd skip now: 1) -E -P -a result from last (-a) 2) -a -E -P -a result from

Re: [Ipmitool-devel] Code Review - ID: 3595612 - ask for password once only if used

2013-01-11 Thread Ales Ledvinka
I vote NACK since it's inconsistent. current: -U user1 *-U user2* except.: -E *-a* current: *-a* -P pass Option groups setting same value: key-option:= [ -k key | -K | -y hex_key | -Y ] password-option := [ -f password_file | -a | -P password | -E ]

Re: [Ipmitool-devel] Code Review - ID: 3595612 - ask for password once only if used

2013-01-11 Thread Zdenek Styblik
On Fri, Jan 11, 2013 at 5:02 PM, Ales Ledvinka aledv...@redhat.com wrote: [...] I vote NACK since it's inconsistent. current: -U user1 *-U user2* except.: -E *-a* current: *-a* -P pass Option groups setting same value: key-option:= [ -k key | -K | -y hex_key | -Y ]

Re: [Ipmitool-devel] Code Review - ID: 3595612 - ask for password once only if used

2013-01-11 Thread Zdenek Styblik
On Fri, Jan 11, 2013 at 5:32 PM, Zdenek Styblik zdenek.styb...@gmail.com wrote: [...] Anyway, I'll try to think of some elegant solution over the weekend. Another solution is attached. Z. - Original Message - From: Zdenek Styblik zdenek.styb...@gmail.com To: ipmitool-devel