Applied.
Thanks,
Brian
--
Brian King
Power Linux I/O
IBM Linux Technology Center
___
Iprdd-devel mailing list
Iprdd-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/iprdd-devel
Applied,
Thanks!
Brian
--
Brian King
Power Linux I/O
IBM Linux Technology Center
___
Iprdd-devel mailing list
Iprdd-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/iprdd-devel
user expects.
Applied.
Thanks!
Brian
--
Brian King
Power Linux I/O
IBM Linux Technology Center
___
Iprdd-devel mailing list
Iprdd-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/iprdd-devel
o convert the sense data
> to the format that user expects.
>
> Signed-off-by: Brahadambal Srinivasan
> Signed-off-by: Brian King
My signed off should be removed from the patch submission and I
will add it when committing the patch.
> Reviewed-by: Rick Lindsley
> Repor
-off-by: Brian King
---
iprlib.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/iprlib.c b/iprlib.c
index 4d3ab5f..516f069 100644
--- a/iprlib.c
+++ b/iprlib.c
@@ -10345,7 +10345,8 @@ int ipr_jbod_sysfs_bind(struct ipr_dev *dev, u8 op)
char *sysfs_device_name
These two patches fix up some hang conditions that have been
seen when formatting drives for RAID function.
Brian King (2):
iprutils: Fix driver unbind on format
iprutils: Fix format for RAID hang
iprconfig.c | 2 +-
iprlib.c| 6 --
2 files changed, 5 insertions(+), 3 deletions
On 05/25/2018 09:00 AM, wenxi...@linux.vnet.ibm.com wrote:
> From: Wen Xiong
>
> This patch adds formatting error overlay 0x41 to improve debug
> capabilities.
>
> Signed-off-by: Wen Xiong
> ---
Acked-by: Brian King
--
Brian King
Power Linux I/O
IBM Li
Applied.
Thanks,
Brian
--
Brian King
Power Linux I/O
IBM Linux Technology Center
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
ked this patch on top of my
> patch (see the last hunk). However I just fetched iprutils repo and my
> patch wasn't merged, so I guess this need to be reworked in order to not
> depend on my patch, that probably is present only in your repo.
Yep. I rediffed and pushed.
Thanks!
Brian
--
to the default
value of write back if there is no saved write cache policy.
Signed-off-by: Brian King <brk...@linux.vnet.ibm.com>
---
iprlib.c | 34 ++
iprlib.h |1 -
2 files changed, 18 insertions(+), 17 deletions(-)
diff -puN ip
This fixes up a couple places where iprutils was not
setting the data direction to SG_DXFER_NONE for SG_IO
ioctls with a zero data length. The sg driver has recently
gotten more strick about this and has started failing
these requests.
Signed-off-by: Brian King <brk...@linux.vnet.ibm.
This fixes up a couple places where iprutils was not
setting the data direction to SG_DXFER_NONE for SG_IO
ioctls with a zero data length. The sg driver has recently
gotten more strick about this and has started failing
these requests.
Signed-off-by: Brian King <brk...@linux.vnet.ibm.
Applied.
Thanks,
Brian
--
Brian King
Power Linux I/O
IBM Linux Technology Center
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
Applied.
Thanks,
Brian
--
Brian King
Power Linux I/O
IBM Linux Technology Center
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, Slashdot.org! http://sdm.link/slashdot
Older kernels on little endian systems had the device_id endian
swapped in sysfs. This has since been fixed up. This patch adds
support to iprinit to check for attributes saved using the old
endian swapped device id.
Signed-off-by: Brian King <brk...@linux.vnet.ibm.com>
---
iprlib.c
Fixes up iprconfig -c dump to show more details about the IOA. Also
fixes an issue where we could end up treating a RAID array as an
adapter resource which resulted in strange looking iprconfig menus
and possible iprinit failures.
Signed-off-by: Brian King <brk...@linux.vnet.ibm.
Allow VSET write cache to be enabled in bare metal mode.
Signed-off-by: Brian King <brk...@linux.vnet.ibm.com>
---
iprlib.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff -puN iprlib.c~iprutils_vset_wcache_baremetal iprlib.c
--- iprutils.patched/ip
This patch ensures that if __tool_init fails, we don't sleep and retry
if the tool is iprconfig. We only want to do this for the ipr daemons.
Signed-off-by: Brian King <brk...@linux.vnet.ibm.com>
---
iprconfig.c |1 +
iprlib.c|3 ++-
iprlib.h|1 +
3 files chan
Remove a debug printf that is not needed.
Signed-off-by: Brian King <brk...@linux.vnet.ibm.com>
---
iprlib.c |1 -
1 file changed, 1 deletion(-)
diff -puN iprlib.c~iprutils_remove_debug_printf iprlib.c
--- iprutils.patched/iprlib.c~iprutils_remove_debug_printf 2016-10-18
This patch filters out JBOD HDDs from showing up as devices for selection in
the device statistics menu. Without this patch, they are selectable, but return
without displaying any data.
Signed-off-by: Brian King <brk...@linux.vnet.ibm.com>
---
iprconfig.c | 15 ++-
1 file c
Series applied.
Thanks!
Brian
--
Brian King
Power Linux I/O
IBM Linux Technology Center
--
Check out the vibrant tech community on one of the world's most
engaging tech sites, SlashDot.org! http://sdm.link/slashdot
Fixes up iprconfig -c dump to show more details about the IOA.
Signed-off-by: Brian King <brk...@linux.vnet.ibm.com>
---
iprconfig.c |3 +++
iprlib.c|3 ++-
2 files changed, 5 insertions(+), 1 deletion(-)
diff -puN iprconfig.c~iprutils_dump_ioa_fixup iprco
Allow VSET write cache to be enabled in bare metal mode.
Signed-off-by: Brian King <brk...@linux.vnet.ibm.com>
---
iprlib.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff -puN iprlib.c~iprutils_vset_wcache_baremetal iprlib.c
--- iprutils.patched/ip
cache parameters before setting the
other attributes to ensure it gets set properly.
Signed-off-by: Brian King <brk...@linux.vnet.ibm.com>
---
iprlib.c | 41 +++--
1 file changed, 19 insertions(+), 22 deletions(-)
diff -puN iprlib.c~iprutils_vset_wcac
Allow the option to disable verify on array rebuild, which greatly speeds up
rebuild
time, to get enabled on single adapter configurations and enable this by
default.
Signed-off-by: Brian King <brk...@linux.vnet.ibm.com>
---
iprlib.c | 13 +++--
1 file changed, 7 insertions
Using the raid-create iprconfig command line option would sometimes
result in commands getting sent to the secondary adapter rather than
the primary adapter. This fixes that up.
Signed-off-by: Brian King <brk...@linux.vnet.ibm.com>
---
iprlib.c |9 -
iprlib.h |1 +
2
Remove a debug printf that is not needed.
Signed-off-by: Brian King <brk...@linux.vnet.ibm.com>
---
iprlib.c |1 -
1 file changed, 1 deletion(-)
diff -puN iprlib.c~iprutils_remove_debug_printf iprlib.c
--- iprutils.patched/iprlib.c~iprutils_remove_debug_printf 2016-10-04
Older kernels on little endian systems had the device_id endian
swapped in sysfs. This has since been fixed up.
Signed-off-by: Brian King <brk...@linux.vnet.ibm.com>
---
iprlib.c |9 +
1 file changed, 9 insertions(+)
diff -puN iprlib.c~iprutils_device_id_endian_swap ip
Using the raid-create iprconfig command line option would sometimes
result in commands getting sent to the secondary adapter rather than
the primary adapter. This fixes that up.
Signed-off-by: Brian King <brk...@linux.vnet.ibm.com>
---
iprlib.c |9 -
iprlib.h |1 +
2
logging
to make it easier to track when this indeed does occur in
case a system never loads the sg driver.
Signed-off-by: Brian King <brk...@linux.vnet.ibm.com>
---
iprconfig.c | 19 ---
iprinit.c | 33 +
iprlib.c
Applied.
Thanks,
Brian
--
Brian King
Power Linux I/O
IBM Linux Technology Center
--
___
Iprdd-devel mailing list
Iprdd-devel@lists.sourceforge.net
https
On 09/08/2016 12:37 PM, Gabriel Krisman Bertazi wrote:
> Brian King <brk...@linux.vnet.ibm.com> writes:
>
>> This converts ipr's queuecommand path to use percpu refcounts
>> rather than atomics.
>>
>> Signed-off-by: Brian King <brk...@linux.vnet.ibm.com&g
gt;> -if (res->needs_sync_complete) {
>> -ioarcb->cmd_pkt.flags_hi |= IPR_FLAGS_HI_SYNC_COMPLETE;
>> -res->needs_sync_complete = 0;
>> -}
>> +
>> ipr_trc_hook(ipr_cmd, IPR_TRACE_START, IPR_GET_RES
On 09/08/2016 10:53 AM, Gabriel Krisman Bertazi wrote:
> Brian King <brk...@linux.vnet.ibm.com> writes:
>
>> From: Wen Xiong <wenxi...@linux.vnet.ibm.com>
>>
>> Add scsi multi-queue support in ipr driver.
>>
>> Signed-off-by: Brian King <brk
spin_lock_irqsave(ioa_cfg->host->host_lock, lock_flags);
>> + sata_port->ioa_cfg = ioa_cfg;
>> +sata_port->ap = ap;
>> +sata_port->res = res;
>> +INIT_WORK(_port->
On 09/08/2016 09:44 AM, Gabriel Krisman Bertazi wrote:
> Brian King <brk...@linux.vnet.ibm.com> writes:
>
>> A 9084 error gets logged by the ipr adapter when adapter raw mode
>> gets enabled. A bunch of unformatted hex data also gets logged
>> for this error, wh
this once.
Signed-off-by: Brian King <brk...@linux.vnet.ibm.com>
---
drivers/scsi/ipr.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff -puN drivers/scsi/ipr.c~ipr_hrrq_message drivers/scsi/ipr.c
--- linux-2.6.git/drivers/scsi/ipr.c~ipr_hrrq_message 2016-08-30
between command
completion and error handling.
Signed-off-by: Brian King <brk...@linux.vnet.ibm.com>
---
drivers/scsi/ipr.c | 176 +
drivers/scsi/ipr.h | 51 ++-
2 files changed, 122 insertions(+), 105 deletions(-)
dif
From: Wen Xiong <wenxi...@linux.vnet.ibm.com>
Add scsi multi-queue support in ipr driver.
Signed-off-by: Brian King <brk...@linux.vnet.ibm.com>
---
drivers/scsi/ipr.c | 14 +-
1 file changed, 13 insertions(+), 1 deletion(-)
diff -puN drivers/scsi/ipr.c~ipr_scsimq
This converts ipr's queuecommand path to use percpu refcounts
rather than atomics.
Signed-off-by: Brian King <brk...@linux.vnet.ibm.com>
---
drivers/scsi/ipr.c | 111 ++---
drivers/scsi/ipr.h | 53 +++--
2 files chang
path appears to be working.
Signed-off-by: Brian King <brk...@linux.vnet.ibm.com>
---
drivers/scsi/ipr.c | 479 +++--
drivers/scsi/ipr.h |3
2 files changed, 288 insertions(+), 194 deletions(-)
diff -puN drivers/scsi
.
This patch also eliminates a hang that can occur when formatting
disks if a second iprconfig instance is started concurently.
Signed-off-by: Brian King <brk...@linux.vnet.ibm.com>
---
iprconfig.c | 72 ++
iprlib.c
.
This patch also eliminates a hang that can occur when formatting
disks if a second iprconfig instance is started concurently.
Signed-off-by: Brian King <brk...@linux.vnet.ibm.com>
---
iprconfig.c | 72 ++
iprlib.c
b, *temp;
> + int len, hcam_count = 0;
> + unsigned long lock_flags = 0;
> +
> + spin_lock_irqsave(ioa_cfg->host->host_lock, lock_flags);
> + list_for_each_entry_safe(hostrcb, temp,
> + _c
around this function to ensure that does not happen.
Signed-off-by: Brian King <brk...@linux.vnet.ibm.com>
---
iprconfig.c | 19 ---
iprlib.c| 47 ++-
iprlib.h|2 ++
3 files changed, 64 insertions(+), 4 deletions(-)
be seen when formatting JBOD disks.
Signed-off-by: Brian King <brk...@linux.vnet.ibm.com>
---
iprlib.c |3 +++
1 file changed, 3 insertions(+)
diff -puN iprlib.c~iprutils_mpath_format_fix iprlib.c
--- iprutils.patched/iprlib.c~iprutils_mpath_format_fix 2016-07-20
10:52:01.754919456
mistakenly reformatting
drives to the wrong block size. This was primarily an issue
for drives that ended up in medium format corrupt and the subsequent
format then did the wrong thing.
Signed-off-by: Brian King <brk...@linux.vnet.ibm.com>
---
iprlib.c
Ensure the known zeroed state gets saved in the adapter following
a format unit command from the command line.
Signed-off-by: Brian King <brk...@linux.vnet.ibm.com>
---
iprconfig.c |1 +
1 file changed, 1 insertion(+)
diff -puN iprconfig.c~iprutils_known_zeroed_cmdline iprco
Fix a possible format timeout issue for large disks on little endian systems.
We need to byte swap the 2 byte timeout field.
Signed-off-by: Brian King <brk...@linux.vnet.ibm.com>
---
iprlib.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff -puN ip
st_reboot;
> +static unsigned int ipr_use_blk_mq = 0;
Why do we disable this by default?
Thanks,
Brian
--
Brian King
Power Linux I/O
IBM Linux Technology Center
--
Attend Shape: An AT Tech Expo July 15-16. Meet
Display the /dev/sr device name for optical devices.
Signed-off-by: Brian King <brk...@linux.vnet.ibm.com>
---
iprlib.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN iprlib.c~iprutils_sr_devname iprlib.c
--- iprutils.patched/iprlib.c~iprutils_sr_devname 2016
nodes prior to deleting the RAID array,
we weren't flushing the unused multipaths, so let's do that.
Signed-off-by: Brian King <brk...@linux.vnet.ibm.com>
---
iprlib.c | 28
1 file changed, 16 insertions(+), 12 deletions(-)
diff -puN ip
Enhance iprsos to collect some missing log files.
Signed-off-by: Brian King <brk...@linux.vnet.ibm.com>
---
iprsos | 20
1 file changed, 20 insertions(+)
diff -puN iprsos~iprutils_sos_logs iprsos
--- iprutils.patched/iprsos~iprutils_sos_logs 2016-06-15
I've created a release candidate build for the next iprutils release.
Its in the OBS testing repository:
https://build.opensuse.org/package/show/home:kingb:iprutils-test/iprutils
Thanks,
Brian
--
Brian King
Power Linux I/O
IBM Linux Technology Center
The iprutils init.d scripts require the redhat-lsb on RHEL 6 in order
to function. Add this as a dependency.
Signed-off-by: Brian King <brk...@linux.vnet.ibm.com>
---
diff -puN spec/iprutils.spec~iprutils_rhel6_lsb_dep spec/iprutils.spec
--- iprutils.patched/spec/iprutil
Clarify the verbiage used for the SSD report for read intensive SSDs.
Signed-off-by: Brian King <brk...@linux.vnet.ibm.com>
---
diff -puN iprconfig.c~iprutils_ssd_report_tweak iprconfig.c
--- iprutils.patched/iprconfig.c~iprutils_ssd_report_tweak 2016-04-05
10:00:16.333971504
r
debugging,
but doesn't seem like something we'd typically want a user to do. I think I'd
prefer to
keep things simple and not expose this in iprconfig, unless you can think of a
good
use case.
Thanks,
Brian
--
Brian King
Power Linux I/O
IBM Linux Technology Center
---
ak;
Indentation issue with this break.
> }
> closedir(host_dirfd);
> if (ipr_ioa->host_num < 0) {
> @@ -6943,6 +6949,8 @@ static void ipr_save_dev_attr(struct ipr_dev *dev, char
> *field,
> char *value, in
d these now. Please let me
know if you still see issues.
Thanks,
Brian
--
Brian King
Power Linux I/O
IBM Linux Technology Center
--
Transform Data into Opportunity.
Accelerate data analysis in your applications with
In
Series applied.
Thanks,
Brian
--
Brian King
Power Linux I/O
IBM Linux Technology Center
--
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library
_attr.queue_depth;
> - sprintf(qdepth_str,"%d",disk_config_attr[0].queue_depth);
> + sprintf(qdepth_str, "%d", disk_config_attr[0].queue_depth);
> i_con = add_i_con(i_con, qdepth_str, _config_attr[0]);
> }
>
--
Brian King
Applied.
Thanks,
Brian
--
Brian King
Power Linux I/O
IBM Linux Technology Center
--
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data Analytics Acceleration Library.
Click
I fixed up the typo and applied this one.
Thanks,
Brian
--
Brian King
Power Linux I/O
IBM Linux Technology Center
--
Transform Data into Opportunity.
Accelerate data analysis in your applications with
Intel Data
gt;host, >dev);
> + rc = scsi_add_host_with_dma(ioa_cfg->host, >dev, >dev);
>
> if (rc) {
> __ipr_remove(pdev);
> @@ -10596,6 +10606,7 @@ static int ipr_probe(struct pci_dev *pdev, const
> struct pci_device_id *dev_id)
>
> scsi_
Applied.
Thanks,
Brian
--
Brian King
Power Linux I/O
IBM Linux Technology Center
--
___
Iprdd-devel mailing list
Iprdd-devel@lists.sourceforge.net
https
Series applied.
Thanks,
Brian
--
Brian King
Power Linux I/O
IBM Linux Technology Center
--
___
Iprdd-devel mailing list
Iprdd-devel@lists.sourceforge.net
https
e we update the SAS reference guide to document this as a
valid state:
http://www-01.ibm.com/support/knowledgecenter/8247-22L/p8ebk/diskarraystates.htm?cp=8247-22L
What happens now if you create a single disk RAID 0 with a device not
On 01/14/2016 06:34 AM, Gabriel Krisman Bertazi wrote:
> Brian King <brk...@linux.vnet.ibm.com> writes:
>
>> I'm hoping to spin a 2.4.10 version of iprutils before the end of this week.
>> There are a few pending patches from Heitor, but I'm planning to defer
Applied.
Thanks,
Brian
--
Brian King
Power Linux I/O
IBM Linux Technology Center
--
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35
Applied.
Thanks,
Brian
--
Brian King
Power Linux I/O
IBM Linux Technology Center
--
Site24x7 APM Insight: Get Deep Visibility into Application Performance
APM + Mobile APM + RUM: Monitor 3 App instances at just $35
On 01/06/2016 04:18 PM, Gabriel Krisman Bertazi wrote:
> Brian King <brk...@linux.vnet.ibm.com> writes:
>
>>> I don't think replacing system with exec* is a much better solution
>>> here. It's OK for your log system fix because we really need to call an
>>&g
index++)
> + free_item(cache_prot_item[index]);
> + if (rc == EXIT_FLAG)
> + goto leave;
> + continue;
> } else
>
> +struct screen_opts device_stats_opt[] = {
> + {device_stats, "\n"}
> +};
> +
> +s_node n_device_stats = {
> + .rc_flags = (CANCEL_FLAG),
> + .f_flags = (EXIT_FLAG | CANCEL_FLAG | REFRESH_FLAG | TOGGLE_FLAG |
> FWD_FLAG),
> + .num_opts = NUM_OPTS(de
multipath-tools, which is bad, because none of the distro packages I
> know considers that dependency. Not even the one we provide in the spec
> directory. This is broken and will fail silently, even if harmlessly ,
> in any machine lacking multipath-tools.
I do think this is still goodness overa
Reviewed-by: Brian King <brk...@linux.vnet.ibm.com>
--
Brian King
Power Linux I/O
IBM Linux Technology Center
--
Go from Idea to Many App Stores Faster with Intel(R) XDK
Give your users amazing mobile app exper
ock ipr_notifier = {
> **/
> static int __init ipr_init(void)
> {
> + int cpu;
> ipr_info("IBM Power RAID SCSI Device Driver version: %s %s\n",
>IPR_DRIVER_VERSION, IPR_DRIV
uot;Enable CPU affinity per adapter. (default: 0)");
> +module_param_named(use_blk_mq, ipr_use_blk_mq, uint, S_IRUGO);
> +MODULE_PARM_DESC(use_blk_mq, "ipr use block mq enable/disable. (default:
> 0)");
Why disable by default?
--
Brian King
Power Linux I/O
IBM Linux Tech
ID_2780 0x0264
> #define IPR_SUBS_DEV_ID_5702 0x0266
> @@ -111,6 +112,8 @@
> #define IPR_SUBS_DEV_ID_2CCA 0x04C7
> #define IPR_SUBS_DEV_ID_2CD2 0x04C8
> #define IPR_SUBS_DEV_ID_2CCD 0x04C9
> +#define IPR_SUBS_DEV_ID_580A 0x04FC
> +#define IPR_SUBS_DEV_ID_580B 0x04FB
&
_config_attr[index++]);
> + body = add_line_to_body(body,_("IOA Caching Mode"),
> "%18");
> + }
> }
> if (dev->ioa->configure_rebuild_verify) {
> body = add_line_to_body(body,
>
--
Applied.
Thanks,
Brian
--
Brian King
Power Linux I/O
IBM Linux Technology Center
--
___
Iprdd-devel mailing list
Iprdd-devel@lists.sourceforge.net
https
Acked-by: Brian King <brk...@linux.vnet.ibm.com>
--
Brian King
Power Linux I/O
IBM Linux Technology Center
--
___
Iprdd-devel mailing list
Iprdd-devel@lists.sourcefor
is the default
> + Vset Cache policy. Users can override this setting
> + by passing option '-c writethrough' to raid create */
> + vcache = IPR_DEV_CACHE_WRITE_BACK;
> + }
> +
> if (dev_init_head) {
> rc = send_dev_init
e config file, and it
doesn't look
like we are looking at IPR_ARRAY_REBUILD_RATE or
IPR_ARRAY_DISABLE_REBUILD_VERIFY. We'll
need to fix this up in a follow on patch.
For this particular patch, what you have is fine, since we aren't yet exposing
a way
to disable this on a per adap
ssign a default value of bare metal and simplify the
function above
slightly.
> +
> #define IPR_IS_DASD_DEVICE(std_inq_data) \
> std_inq_data).peri_dev_type) == TYPE_DISK) &&
> !((std_inq_data).removeable_medium))
>
--
Brian King
Power Linux I/O
IBM Linux Technology C
I like the per distro defaults. Does this also do the right thing for
PowerKVM?
Pulled and pushed. Thanks Gabriel.
-Brian
--
___
Iprdd-devel mailing list
ipr_update_ioa_fw(struct ipr_ioa *, struct ipr_fw_images *, int);
int ipr_update_disk_fw(struct ipr_dev *, struct ipr_fw_images *, int);
int ipr_init_dev(struct ipr_dev *);
--
Brian King
Power Linux I/O
IBM Linux Technology Center
, __(Download Ucode)},
+ {ucode_status,2, __(Show Ucode Levels)},
I'd prefer we don't use the abbreviation ucode and use the word microcode
instead.
Thanks,
Brian
--
Brian King
Power Linux I/O
IBM Linux Technology Center
an alternate fix for this and posted a
2.4.8 version. Please let me know if this addresses your issue.
https://sourceforge.net/p/iprdd/iprutils/ci/3054ea4232b37dc19f8ea33ae93e3a8248e3a34e/
Thanks,
Brian
--
Brian King
Power Linux I/O
IBM Linux Technology Center
88 matches
Mail list logo
