[jira] [Commented] (ARTEMIS-1790) Improve Topology Member Finding

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433341#comment-16433341
 ] 

ASF GitHub Bot commented on ARTEMIS-1790:
-

Github user gaohoward commented on the issue:

https://github.com/apache/activemq-artemis/pull/1999
  
@clebertsuconic @stanlyDoge done.


> Improve Topology Member Finding
> ---
>
> Key: ARTEMIS-1790
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1790
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Broker
>Affects Versions: 2.5.0
>Reporter: Howard Gao
>Assignee: Howard Gao
>Priority: Major
> Fix For: 2.5.1
>
>
> When finding out if a connector belong to a target node it compares the whole 
> parameter map which is not necessary. Also in understanding the connector the 
> best place is to delegate it to the corresponding remoting connection who 
> understands it. (e.g. INVMConnection knows whether the connector belongs to a 
> target node by checking it's serverID only. The netty ones only need to match 
> host and port, and understanding that localhost and 127.0.0.1 are same thing).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Closed] (ARTEMIS-1797) Auto-create-address flag shouldn't block temp destination creation

[Howard Gao (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1797?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Howard Gao closed ARTEMIS-1797.
---
Resolution: Fixed

> Auto-create-address flag shouldn't block temp destination creation
> --
>
> Key: ARTEMIS-1797
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1797
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 2.5.0
>Reporter: Howard Gao
>Assignee: Howard Gao
>Priority: Major
> Fix For: 2.5.1
>
>
> When creating a temp destination and auto-create-address set to false, the 
> broker throws an error and refuse to create it. This doesn't conform to 
> normal use-case (like amqp dynamic flag) where the temp destination should be 
> allowed even if the auto-create-address is false.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1790) Improve Topology Member Finding

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433276#comment-16433276
 ] 

ASF GitHub Bot commented on ARTEMIS-1790:
-

Github user gaohoward commented on the issue:

https://github.com/apache/activemq-artemis/pull/1999
  
ok I'll take care of them.


> Improve Topology Member Finding
> ---
>
> Key: ARTEMIS-1790
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1790
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Broker
>Affects Versions: 2.5.0
>Reporter: Howard Gao
>Assignee: Howard Gao
>Priority: Major
> Fix For: 2.5.1
>
>
> When finding out if a connector belong to a target node it compares the whole 
> parameter map which is not necessary. Also in understanding the connector the 
> best place is to delegate it to the corresponding remoting connection who 
> understands it. (e.g. INVMConnection knows whether the connector belongs to a 
> target node by checking it's serverID only. The netty ones only need to match 
> host and port, and understanding that localhost and 127.0.0.1 are same thing).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1790) Improve Topology Member Finding

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433275#comment-16433275
 ] 

ASF GitHub Bot commented on ARTEMIS-1790:
-

Github user gaohoward commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1999#discussion_r180614044
  
--- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnection.java
 ---
@@ -511,6 +511,45 @@ public final boolean isUsingProtocolHandling() {
   return true;
}
 
+   @Override
+   public boolean isSameTarget(TransportConfiguration... configs) {
+  boolean yes = false;
--- End diff --

alright. :)



> Improve Topology Member Finding
> ---
>
> Key: ARTEMIS-1790
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1790
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Broker
>Affects Versions: 2.5.0
>Reporter: Howard Gao
>Assignee: Howard Gao
>Priority: Major
> Fix For: 2.5.1
>
>
> When finding out if a connector belong to a target node it compares the whole 
> parameter map which is not necessary. Also in understanding the connector the 
> best place is to delegate it to the corresponding remoting connection who 
> understands it. (e.g. INVMConnection knows whether the connector belongs to a 
> target node by checking it's serverID only. The netty ones only need to match 
> host and port, and understanding that localhost and 127.0.0.1 are same thing).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (AMQ-6930) bin/activemq should allow stdout/stderr to some file instead of /dev/null for daemon mode

[Jeff Genender (JIRA)]

[ 
https://issues.apache.org/jira/browse/AMQ-6930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433142#comment-16433142
 ] 

Jeff Genender commented on AMQ-6930:


Thanks Alvin!  Great patch and the test case was much appreciated!

> bin/activemq should allow stdout/stderr to some file instead of /dev/null for 
> daemon mode
> -
>
> Key: AMQ-6930
> URL: https://issues.apache.org/jira/browse/AMQ-6930
> Project: ActiveMQ
>  Issue Type: Wish
>Affects Versions: 5.15.0, 5.15.1, 5.15.2, 5.15.3
>Reporter: Alvin Lin
>Priority: Major
> Fix For: 5.16.0, 5.15.4
>
>
> if I do "bin/activemq start" the ActiveMQ process is started with 
> stdout/stdin redirected to /dev/null. 
> This makes it hard to debug issue like out of memory error because we can't 
> see any log, for example, when the JVM flag "ExitOnOutOfMemoryError" is 
> turned on. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (AMQ-6930) bin/activemq should allow stdout/stderr to some file instead of /dev/null for daemon mode

[Jeff Genender (JIRA)]

 [ 
https://issues.apache.org/jira/browse/AMQ-6930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jeff Genender updated AMQ-6930:
---
Fix Version/s: 5.15.4
   5.16.0

> bin/activemq should allow stdout/stderr to some file instead of /dev/null for 
> daemon mode
> -
>
> Key: AMQ-6930
> URL: https://issues.apache.org/jira/browse/AMQ-6930
> Project: ActiveMQ
>  Issue Type: Wish
>Affects Versions: 5.15.0, 5.15.1, 5.15.2, 5.15.3
>Reporter: Alvin Lin
>Priority: Major
> Fix For: 5.16.0, 5.15.4
>
>
> if I do "bin/activemq start" the ActiveMQ process is started with 
> stdout/stdin redirected to /dev/null. 
> This makes it hard to debug issue like out of memory error because we can't 
> see any log, for example, when the JVM flag "ExitOnOutOfMemoryError" is 
> turned on. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (AMQ-6930) bin/activemq should allow stdout/stderr to some file instead of /dev/null for daemon mode

[Jeff Genender (JIRA)]

[ 
https://issues.apache.org/jira/browse/AMQ-6930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433132#comment-16433132
 ] 

Jeff Genender commented on AMQ-6930:


Added fix versions

> bin/activemq should allow stdout/stderr to some file instead of /dev/null for 
> daemon mode
> -
>
> Key: AMQ-6930
> URL: https://issues.apache.org/jira/browse/AMQ-6930
> Project: ActiveMQ
>  Issue Type: Wish
>Affects Versions: 5.15.0, 5.15.1, 5.15.2, 5.15.3
>Reporter: Alvin Lin
>Priority: Major
> Fix For: 5.16.0, 5.15.4
>
>
> if I do "bin/activemq start" the ActiveMQ process is started with 
> stdout/stdin redirected to /dev/null. 
> This makes it hard to debug issue like out of memory error because we can't 
> see any log, for example, when the JVM flag "ExitOnOutOfMemoryError" is 
> turned on. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (AMQ-6930) bin/activemq should allow stdout/stderr to some file instead of /dev/null for daemon mode

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/AMQ-6930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433116#comment-16433116
 ] 

ASF subversion and git services commented on AMQ-6930:
--

Commit 0036084af6ec930e91927170bdc6cfc1c81b37ff in activemq's branch 
refs/heads/activemq-5.15.x from [~alvinlin123]
[ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=0036084 ]

AMQ-6930 provide options to allow stdout/stderr of activemq process to be 
redirect to a file using append mode

(cherry picked from commit f3a8e882068803a3cdab338d3544b27a7808e0cc)


> bin/activemq should allow stdout/stderr to some file instead of /dev/null for 
> daemon mode
> -
>
> Key: AMQ-6930
> URL: https://issues.apache.org/jira/browse/AMQ-6930
> Project: ActiveMQ
>  Issue Type: Wish
>Affects Versions: 5.15.0, 5.15.1, 5.15.2, 5.15.3
>Reporter: Alvin Lin
>Priority: Major
>
> if I do "bin/activemq start" the ActiveMQ process is started with 
> stdout/stdin redirected to /dev/null. 
> This makes it hard to debug issue like out of memory error because we can't 
> see any log, for example, when the JVM flag "ExitOnOutOfMemoryError" is 
> turned on. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (AMQ-6930) bin/activemq should allow stdout/stderr to some file instead of /dev/null for daemon mode

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/AMQ-6930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16433108#comment-16433108
 ] 

ASF subversion and git services commented on AMQ-6930:
--

Commit 929483906bd4838ede4ab7f8e07758fc52d2cfce in activemq's branch 
refs/heads/activemq-5.15.x from [~alvinlin123]
[ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=9294839 ]

AMQ-6930 add test case

(cherry picked from commit 6bb56decf881328f5595692ca17c1899f7f86a7b)


> bin/activemq should allow stdout/stderr to some file instead of /dev/null for 
> daemon mode
> -
>
> Key: AMQ-6930
> URL: https://issues.apache.org/jira/browse/AMQ-6930
> Project: ActiveMQ
>  Issue Type: Wish
>Affects Versions: 5.15.0, 5.15.1, 5.15.2, 5.15.3
>Reporter: Alvin Lin
>Priority: Major
>
> if I do "bin/activemq start" the ActiveMQ process is started with 
> stdout/stdin redirected to /dev/null. 
> This makes it hard to debug issue like out of memory error because we can't 
> see any log, for example, when the JVM flag "ExitOnOutOfMemoryError" is 
> turned on. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ARTEMIS-1794) Confusion when auto removing a queue

[Justin Bertram (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Bertram updated ARTEMIS-1794:

Description: 
I'm using the following settings to try to mimic ActiveMQ 5 STOMP destination 
handling:
{code}
tcp://0.0.0.0:61613?tcpSendBufferSize=1048576;tcpReceiveBufferSize=1048576;protocols=STOMP;useEpoll=true;anycastPrefix=/queue/;multicastPrefix=/topic/
{code}

This works as expected in most situations.

However, when subscribing to a queue (via {{destination:/queue/foo}}) and 
sending a message to an eponymous topic ({{destination:/topic/foo}}) Artemis 
reports a fatal error:
{code}
AMQ119209 Can't remove routing type ANYCAST, queues exists for address foo. 
Please delete queues before removing this routing type.
{code}

I guess this happens when it tries to auto delete things.

Doing the opposite (subscribing to the queue and sending a message to the 
topic), I get the same kind of error:
{code}
AMQ119209 Can't remove routing type MULTICAST, queues exists for address foo. 
Please delete queues before removing this routing type.
{code}


  was:
I'm using the following settings to try to mimic ActiveMQ 5 STOMP destination 
handling:
{code}
 tcp://0.0.0.0:61613?tcpSendBufferSize=1048576;tcpReceiveBufferSize=1048576;protocols=STOMP;useEpoll=true;anycastPrefix=/queue/;multicastPrefix=/topic/
{code}

This works as expected in most situations.

However, when subscribing to a queue (via {{destination:/queue/foo}}) and 
sending a message to an eponymous topic ({{destination:/topic/foo}}) Artemis 
reports a fatal error:
{code}
AMQ119209 Can't remove routing type ANYCAST, queues exists for address foo. 
Please delete queues before removing this routing type.
{code}

I guess this happens when it tries to auto delete things.

Doing the opposite (subscribing to the queue and sending a message to the 
topic), I get the same kind of error:
{code}
AMQ119209 Can't remove routing type MULTICAST, queues exists for address foo. 
Please delete queues before removing this routing type.
{code}



> Confusion when auto removing a queue
> 
>
> Key: ARTEMIS-1794
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1794
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: STOMP
>Affects Versions: 2.5.0
>Reporter: Lionel Cons
>Priority: Major
>
> I'm using the following settings to try to mimic ActiveMQ 5 STOMP destination 
> handling:
> {code}
>  name="stomp">tcp://0.0.0.0:61613?tcpSendBufferSize=1048576;tcpReceiveBufferSize=1048576;protocols=STOMP;useEpoll=true;anycastPrefix=/queue/;multicastPrefix=/topic/
> {code}
> This works as expected in most situations.
> However, when subscribing to a queue (via {{destination:/queue/foo}}) and 
> sending a message to an eponymous topic ({{destination:/topic/foo}}) Artemis 
> reports a fatal error:
> {code}
> AMQ119209 Can't remove routing type ANYCAST, queues exists for address foo. 
> Please delete queues before removing this routing type.
> {code}
> I guess this happens when it tries to auto delete things.
> Doing the opposite (subscribing to the queue and sending a message to the 
> topic), I get the same kind of error:
> {code}
> AMQ119209 Can't remove routing type MULTICAST, queues exists for address foo. 
> Please delete queues before removing this routing type.
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1800) Incorrect number of messages on queue after remove of scheduled message

[Christopher L. Shannon (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432879#comment-16432879
 ] 

Christopher L. Shannon commented on ARTEMIS-1800:
-

[~jbertram] - Ok should be fixed for real this time

> Incorrect number of messages on queue after remove of scheduled message
> ---
>
> Key: ARTEMIS-1800
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1800
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.5.0
>Reporter: Justin Bertram
>Assignee: Christopher L. Shannon
>Priority: Major
>
> This will reproduce the failure if added to 
> {{org.apache.activemq.artemis.tests.integration.management.QueueControlTest}}:
> {noformat}
>@Test
>public void testGetScheduledCountOnRemove() throws Exception {
>   long delay = Integer.MAX_VALUE;
>   SimpleString address = RandomUtil.randomSimpleString();
>   SimpleString queue = RandomUtil.randomSimpleString();
>   session.createQueue(address, RoutingType.MULTICAST, queue, null, 
> durable);
>   QueueControl queueControl = createManagementControl(address, queue);
>   Assert.assertEquals(0, queueControl.getScheduledCount());
>   ClientProducer producer = session.createProducer(address);
>   ClientMessage message = session.createMessage(durable);
>   message.putLongProperty(Message.HDR_SCHEDULED_DELIVERY_TIME, 
> System.currentTimeMillis() + delay);
>   producer.send(message);
>   queueControl.removeAllMessages();
>   Assert.assertEquals(0, queueControl.getMessageCount());
>   session.deleteQueue(queue);
>}
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (AMQ-6930) bin/activemq should allow stdout/stderr to some file instead of /dev/null for daemon mode

[Arthur Naseef (JIRA)]

 [ 
https://issues.apache.org/jira/browse/AMQ-6930?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Arthur Naseef resolved AMQ-6930.

Resolution: Fixed

> bin/activemq should allow stdout/stderr to some file instead of /dev/null for 
> daemon mode
> -
>
> Key: AMQ-6930
> URL: https://issues.apache.org/jira/browse/AMQ-6930
> Project: ActiveMQ
>  Issue Type: Wish
>Affects Versions: 5.15.0, 5.15.1, 5.15.2, 5.15.3
>Reporter: Alvin Lin
>Priority: Major
>
> if I do "bin/activemq start" the ActiveMQ process is started with 
> stdout/stdin redirected to /dev/null. 
> This makes it hard to debug issue like out of memory error because we can't 
> see any log, for example, when the JVM flag "ExitOnOutOfMemoryError" is 
> turned on. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (AMQ-6930) bin/activemq should allow stdout/stderr to some file instead of /dev/null for daemon mode

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/AMQ-6930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432875#comment-16432875
 ] 

ASF GitHub Bot commented on AMQ-6930:
-

Github user asfgit closed the pull request at:

https://github.com/apache/activemq/pull/281


> bin/activemq should allow stdout/stderr to some file instead of /dev/null for 
> daemon mode
> -
>
> Key: AMQ-6930
> URL: https://issues.apache.org/jira/browse/AMQ-6930
> Project: ActiveMQ
>  Issue Type: Wish
>Affects Versions: 5.15.0, 5.15.1, 5.15.2, 5.15.3
>Reporter: Alvin Lin
>Priority: Major
>
> if I do "bin/activemq start" the ActiveMQ process is started with 
> stdout/stdin redirected to /dev/null. 
> This makes it hard to debug issue like out of memory error because we can't 
> see any log, for example, when the JVM flag "ExitOnOutOfMemoryError" is 
> turned on. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (AMQ-6930) bin/activemq should allow stdout/stderr to some file instead of /dev/null for daemon mode

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/AMQ-6930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432874#comment-16432874
 ] 

ASF subversion and git services commented on AMQ-6930:
--

Commit 0caa7121c62453dea533683c0e6ec7c8b4680c1f in activemq's branch 
refs/heads/master from artnaseef
[ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=0caa712 ]

AMQ-6930 updates closes #281


> bin/activemq should allow stdout/stderr to some file instead of /dev/null for 
> daemon mode
> -
>
> Key: AMQ-6930
> URL: https://issues.apache.org/jira/browse/AMQ-6930
> Project: ActiveMQ
>  Issue Type: Wish
>Affects Versions: 5.15.0, 5.15.1, 5.15.2, 5.15.3
>Reporter: Alvin Lin
>Priority: Major
>
> if I do "bin/activemq start" the ActiveMQ process is started with 
> stdout/stdin redirected to /dev/null. 
> This makes it hard to debug issue like out of memory error because we can't 
> see any log, for example, when the JVM flag "ExitOnOutOfMemoryError" is 
> turned on. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1800) Incorrect number of messages on queue after remove of scheduled message

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432877#comment-16432877
 ] 

ASF GitHub Bot commented on ARTEMIS-1800:
-

GitHub user cshannon opened a pull request:

https://github.com/apache/activemq-artemis/pull/2009

ARTEMIS-1800 - Fix metrics decrement on scheduled message cancel

The queue metrics were being decremented improperly because on iteration
over the cancelled scheduled messages because the flag for 
fromMessageReferences was not
set to false. Setting the flag to false skips over the metrics update
which is what we want as the scheduled messages were never added to the
message references in the first place so the metrics don't need updating

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cshannon/activemq-artemis ARTEMIS-1800

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/2009.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2009


commit 70f0908b4ee64e68059a21009db9dd3236c26732
Author: Christopher L. Shannon (cshannon) 
Date:   2018-04-10T19:54:29Z

ARTEMIS-1800 - Fix metrics decrement on scheduled message cancel

The queue metrics were being decremented improperly because on iteration
over the cancelled scheduled messages because the flag for 
fromMessageReferences was not
set to false. Setting the flag to false skips over the metrics update
which is what we want as the scheduled messages were never added to the
message references in the first place so the metrics don't need updating




> Incorrect number of messages on queue after remove of scheduled message
> ---
>
> Key: ARTEMIS-1800
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1800
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.5.0
>Reporter: Justin Bertram
>Assignee: Christopher L. Shannon
>Priority: Major
>
> This will reproduce the failure if added to 
> {{org.apache.activemq.artemis.tests.integration.management.QueueControlTest}}:
> {noformat}
>@Test
>public void testGetScheduledCountOnRemove() throws Exception {
>   long delay = Integer.MAX_VALUE;
>   SimpleString address = RandomUtil.randomSimpleString();
>   SimpleString queue = RandomUtil.randomSimpleString();
>   session.createQueue(address, RoutingType.MULTICAST, queue, null, 
> durable);
>   QueueControl queueControl = createManagementControl(address, queue);
>   Assert.assertEquals(0, queueControl.getScheduledCount());
>   ClientProducer producer = session.createProducer(address);
>   ClientMessage message = session.createMessage(durable);
>   message.putLongProperty(Message.HDR_SCHEDULED_DELIVERY_TIME, 
> System.currentTimeMillis() + delay);
>   producer.send(message);
>   queueControl.removeAllMessages();
>   Assert.assertEquals(0, queueControl.getMessageCount());
>   session.deleteQueue(queue);
>}
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (AMQ-6930) bin/activemq should allow stdout/stderr to some file instead of /dev/null for daemon mode

[Arthur Naseef (JIRA)]

[ 
https://issues.apache.org/jira/browse/AMQ-6930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432867#comment-16432867
 ] 

Arthur Naseef commented on AMQ-6930:


Since the update is fully backward compatible, and adds new functionality that 
is definitely useful, I agree with the update.

After successfully building locally (which required skipping the faulty, and 
unrelated, PooledConnectionSecurityExceptionTest.java test), I merged the 
commits.

Commits merged with thanks to Alvin Lin.

> bin/activemq should allow stdout/stderr to some file instead of /dev/null for 
> daemon mode
> -
>
> Key: AMQ-6930
> URL: https://issues.apache.org/jira/browse/AMQ-6930
> Project: ActiveMQ
>  Issue Type: Wish
>Affects Versions: 5.15.0, 5.15.1, 5.15.2, 5.15.3
>Reporter: Alvin Lin
>Priority: Major
>
> if I do "bin/activemq start" the ActiveMQ process is started with 
> stdout/stdin redirected to /dev/null. 
> This makes it hard to debug issue like out of memory error because we can't 
> see any log, for example, when the JVM flag "ExitOnOutOfMemoryError" is 
> turned on. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (AMQ-6930) bin/activemq should allow stdout/stderr to some file instead of /dev/null for daemon mode

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/AMQ-6930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432859#comment-16432859
 ] 

ASF subversion and git services commented on AMQ-6930:
--

Commit 246899bb268345bd1b6c7aab484ebb28005bf6b0 in activemq's branch 
refs/heads/master from [~alvinlin123]
[ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=246899b ]

AMQ-6930 add test case

(cherry picked from commit 6bb56decf881328f5595692ca17c1899f7f86a7b)


> bin/activemq should allow stdout/stderr to some file instead of /dev/null for 
> daemon mode
> -
>
> Key: AMQ-6930
> URL: https://issues.apache.org/jira/browse/AMQ-6930
> Project: ActiveMQ
>  Issue Type: Wish
>Affects Versions: 5.15.0, 5.15.1, 5.15.2, 5.15.3
>Reporter: Alvin Lin
>Priority: Major
>
> if I do "bin/activemq start" the ActiveMQ process is started with 
> stdout/stdin redirected to /dev/null. 
> This makes it hard to debug issue like out of memory error because we can't 
> see any log, for example, when the JVM flag "ExitOnOutOfMemoryError" is 
> turned on. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (AMQ-6930) bin/activemq should allow stdout/stderr to some file instead of /dev/null for daemon mode

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/AMQ-6930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432858#comment-16432858
 ] 

ASF subversion and git services commented on AMQ-6930:
--

Commit 73d90b1b4782dfbdf7803dde50cf355c9171137b in activemq's branch 
refs/heads/master from [~alvinlin123]
[ https://git-wip-us.apache.org/repos/asf?p=activemq.git;h=73d90b1 ]

AMQ-6930 provide options to allow stdout/stderr of activemq process to be 
redirect to a file using append mode

(cherry picked from commit f3a8e882068803a3cdab338d3544b27a7808e0cc)


> bin/activemq should allow stdout/stderr to some file instead of /dev/null for 
> daemon mode
> -
>
> Key: AMQ-6930
> URL: https://issues.apache.org/jira/browse/AMQ-6930
> Project: ActiveMQ
>  Issue Type: Wish
>Affects Versions: 5.15.0, 5.15.1, 5.15.2, 5.15.3
>Reporter: Alvin Lin
>Priority: Major
>
> if I do "bin/activemq start" the ActiveMQ process is started with 
> stdout/stdin redirected to /dev/null. 
> This makes it hard to debug issue like out of memory error because we can't 
> see any log, for example, when the JVM flag "ExitOnOutOfMemoryError" is 
> turned on. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1800) Incorrect number of messages on queue after remove of scheduled message

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432808#comment-16432808
 ] 

ASF GitHub Bot commented on ARTEMIS-1800:
-

Github user cshannon closed the pull request at:

https://github.com/apache/activemq-artemis/pull/2008


> Incorrect number of messages on queue after remove of scheduled message
> ---
>
> Key: ARTEMIS-1800
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1800
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.5.0
>Reporter: Justin Bertram
>Assignee: Christopher L. Shannon
>Priority: Major
>
> This will reproduce the failure if added to 
> {{org.apache.activemq.artemis.tests.integration.management.QueueControlTest}}:
> {noformat}
>@Test
>public void testGetScheduledCountOnRemove() throws Exception {
>   long delay = Integer.MAX_VALUE;
>   SimpleString address = RandomUtil.randomSimpleString();
>   SimpleString queue = RandomUtil.randomSimpleString();
>   session.createQueue(address, RoutingType.MULTICAST, queue, null, 
> durable);
>   QueueControl queueControl = createManagementControl(address, queue);
>   Assert.assertEquals(0, queueControl.getScheduledCount());
>   ClientProducer producer = session.createProducer(address);
>   ClientMessage message = session.createMessage(durable);
>   message.putLongProperty(Message.HDR_SCHEDULED_DELIVERY_TIME, 
> System.currentTimeMillis() + delay);
>   producer.send(message);
>   queueControl.removeAllMessages();
>   Assert.assertEquals(0, queueControl.getMessageCount());
>   session.deleteQueue(queue);
>}
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1800) Incorrect number of messages on queue after remove of scheduled message

[Christopher L. Shannon (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432807#comment-16432807
 ] 

Christopher L. Shannon commented on ARTEMIS-1800:
-

[~jbertram] - Oops I realized that this isn't the correct fix, I'm going to 
close out the PR and revisit.

> Incorrect number of messages on queue after remove of scheduled message
> ---
>
> Key: ARTEMIS-1800
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1800
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.5.0
>Reporter: Justin Bertram
>Assignee: Christopher L. Shannon
>Priority: Major
>
> This will reproduce the failure if added to 
> {{org.apache.activemq.artemis.tests.integration.management.QueueControlTest}}:
> {noformat}
>@Test
>public void testGetScheduledCountOnRemove() throws Exception {
>   long delay = Integer.MAX_VALUE;
>   SimpleString address = RandomUtil.randomSimpleString();
>   SimpleString queue = RandomUtil.randomSimpleString();
>   session.createQueue(address, RoutingType.MULTICAST, queue, null, 
> durable);
>   QueueControl queueControl = createManagementControl(address, queue);
>   Assert.assertEquals(0, queueControl.getScheduledCount());
>   ClientProducer producer = session.createProducer(address);
>   ClientMessage message = session.createMessage(durable);
>   message.putLongProperty(Message.HDR_SCHEDULED_DELIVERY_TIME, 
> System.currentTimeMillis() + delay);
>   producer.send(message);
>   queueControl.removeAllMessages();
>   Assert.assertEquals(0, queueControl.getMessageCount());
>   session.deleteQueue(queue);
>}
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (ARTEMIS-1800) Incorrect number of messages on queue after remove of scheduled message

[Christopher L. Shannon (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christopher L. Shannon reassigned ARTEMIS-1800:
---

Assignee: Christopher L. Shannon

> Incorrect number of messages on queue after remove of scheduled message
> ---
>
> Key: ARTEMIS-1800
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1800
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.5.0
>Reporter: Justin Bertram
>Assignee: Christopher L. Shannon
>Priority: Major
>
> This will reproduce the failure if added to 
> {{org.apache.activemq.artemis.tests.integration.management.QueueControlTest}}:
> {noformat}
>@Test
>public void testGetScheduledCountOnRemove() throws Exception {
>   long delay = Integer.MAX_VALUE;
>   SimpleString address = RandomUtil.randomSimpleString();
>   SimpleString queue = RandomUtil.randomSimpleString();
>   session.createQueue(address, RoutingType.MULTICAST, queue, null, 
> durable);
>   QueueControl queueControl = createManagementControl(address, queue);
>   Assert.assertEquals(0, queueControl.getScheduledCount());
>   ClientProducer producer = session.createProducer(address);
>   ClientMessage message = session.createMessage(durable);
>   message.putLongProperty(Message.HDR_SCHEDULED_DELIVERY_TIME, 
> System.currentTimeMillis() + delay);
>   producer.send(message);
>   queueControl.removeAllMessages();
>   Assert.assertEquals(0, queueControl.getMessageCount());
>   session.deleteQueue(queue);
>}
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1800) Incorrect number of messages on queue after remove of scheduled message

[Christopher L. Shannon (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432793#comment-16432793
 ] 

Christopher L. Shannon commented on ARTEMIS-1800:
-

[~jbertram] - I created a PR to fix it, the issue is that the messages are 
iterated over again on the remove all cancel and it was calling off to the 
decrement logic more than once.  However in another case I think we still want 
to decrement during the cancel (currently referenced from ScaleDownHandler) so 
I made it configurable.  There might be another way to fix it as well but this 
seemed like the most straight forward.

> Incorrect number of messages on queue after remove of scheduled message
> ---
>
> Key: ARTEMIS-1800
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1800
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.5.0
>Reporter: Justin Bertram
>Priority: Major
>
> This will reproduce the failure if added to 
> {{org.apache.activemq.artemis.tests.integration.management.QueueControlTest}}:
> {noformat}
>@Test
>public void testGetScheduledCountOnRemove() throws Exception {
>   long delay = Integer.MAX_VALUE;
>   SimpleString address = RandomUtil.randomSimpleString();
>   SimpleString queue = RandomUtil.randomSimpleString();
>   session.createQueue(address, RoutingType.MULTICAST, queue, null, 
> durable);
>   QueueControl queueControl = createManagementControl(address, queue);
>   Assert.assertEquals(0, queueControl.getScheduledCount());
>   ClientProducer producer = session.createProducer(address);
>   ClientMessage message = session.createMessage(durable);
>   message.putLongProperty(Message.HDR_SCHEDULED_DELIVERY_TIME, 
> System.currentTimeMillis() + delay);
>   producer.send(message);
>   queueControl.removeAllMessages();
>   Assert.assertEquals(0, queueControl.getMessageCount());
>   session.deleteQueue(queue);
>}
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1800) Incorrect number of messages on queue after remove of scheduled message

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432788#comment-16432788
 ] 

ASF GitHub Bot commented on ARTEMIS-1800:
-

GitHub user cshannon opened a pull request:

https://github.com/apache/activemq-artemis/pull/2008

ARTEMIS-1800 - fix duplicate metrics update on scheduled message cancel

When removing scheduled messages from a queue the scheduled message
metrics were being decremented twice

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cshannon/activemq-artemis ARTEMIS-1800

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/2008.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2008


commit 122782ae460a789c883beb21bfccb80089d9bb59
Author: Christopher L. Shannon (cshannon) 
Date:   2018-04-10T19:06:28Z

ARTEMIS-1800 - fix duplicate metrics update on scheduled message cancel

When removing scheduled messages from a queue the scheduled message
metrics were being decremented twice




> Incorrect number of messages on queue after remove of scheduled message
> ---
>
> Key: ARTEMIS-1800
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1800
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.5.0
>Reporter: Justin Bertram
>Priority: Major
>
> This will reproduce the failure if added to 
> {{org.apache.activemq.artemis.tests.integration.management.QueueControlTest}}:
> {noformat}
>@Test
>public void testGetScheduledCountOnRemove() throws Exception {
>   long delay = Integer.MAX_VALUE;
>   SimpleString address = RandomUtil.randomSimpleString();
>   SimpleString queue = RandomUtil.randomSimpleString();
>   session.createQueue(address, RoutingType.MULTICAST, queue, null, 
> durable);
>   QueueControl queueControl = createManagementControl(address, queue);
>   Assert.assertEquals(0, queueControl.getScheduledCount());
>   ClientProducer producer = session.createProducer(address);
>   ClientMessage message = session.createMessage(durable);
>   message.putLongProperty(Message.HDR_SCHEDULED_DELIVERY_TIME, 
> System.currentTimeMillis() + delay);
>   producer.send(message);
>   queueControl.removeAllMessages();
>   Assert.assertEquals(0, queueControl.getMessageCount());
>   session.deleteQueue(queue);
>}
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1800) Incorrect number of messages on queue after remove of scheduled message

[Christopher L. Shannon (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432765#comment-16432765
 ] 

Christopher L. Shannon commented on ARTEMIS-1800:
-

I will take a look

> Incorrect number of messages on queue after remove of scheduled message
> ---
>
> Key: ARTEMIS-1800
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1800
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.5.0
>Reporter: Justin Bertram
>Priority: Major
>
> This will reproduce the failure if added to 
> {{org.apache.activemq.artemis.tests.integration.management.QueueControlTest}}:
> {noformat}
>@Test
>public void testGetScheduledCountOnRemove() throws Exception {
>   long delay = Integer.MAX_VALUE;
>   SimpleString address = RandomUtil.randomSimpleString();
>   SimpleString queue = RandomUtil.randomSimpleString();
>   session.createQueue(address, RoutingType.MULTICAST, queue, null, 
> durable);
>   QueueControl queueControl = createManagementControl(address, queue);
>   Assert.assertEquals(0, queueControl.getScheduledCount());
>   ClientProducer producer = session.createProducer(address);
>   ClientMessage message = session.createMessage(durable);
>   message.putLongProperty(Message.HDR_SCHEDULED_DELIVERY_TIME, 
> System.currentTimeMillis() + delay);
>   producer.send(message);
>   queueControl.removeAllMessages();
>   Assert.assertEquals(0, queueControl.getMessageCount());
>   session.deleteQueue(queue);
>}
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1800) Incorrect number of messages on queue after remove of scheduled message

[Justin Bertram (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1800?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432758#comment-16432758
 ] 

Justin Bertram commented on ARTEMIS-1800:
-

[~cshannon], can you take a look at this? I believe your change in ARTEMIS-1663 
caused this regression.

> Incorrect number of messages on queue after remove of scheduled message
> ---
>
> Key: ARTEMIS-1800
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1800
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.5.0
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>
> This will reproduce the failure if added to 
> {{org.apache.activemq.artemis.tests.integration.management.QueueControlTest}}:
> {noformat}
>@Test
>public void testGetScheduledCountOnRemove() throws Exception {
>   long delay = Integer.MAX_VALUE;
>   SimpleString address = RandomUtil.randomSimpleString();
>   SimpleString queue = RandomUtil.randomSimpleString();
>   session.createQueue(address, RoutingType.MULTICAST, queue, null, 
> durable);
>   QueueControl queueControl = createManagementControl(address, queue);
>   Assert.assertEquals(0, queueControl.getScheduledCount());
>   ClientProducer producer = session.createProducer(address);
>   ClientMessage message = session.createMessage(durable);
>   message.putLongProperty(Message.HDR_SCHEDULED_DELIVERY_TIME, 
> System.currentTimeMillis() + delay);
>   producer.send(message);
>   queueControl.removeAllMessages();
>   Assert.assertEquals(0, queueControl.getMessageCount());
>   session.deleteQueue(queue);
>}
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Assigned] (ARTEMIS-1800) Incorrect number of messages on queue after remove of scheduled message

[Justin Bertram (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Bertram reassigned ARTEMIS-1800:
---

Assignee: (was: Justin Bertram)

> Incorrect number of messages on queue after remove of scheduled message
> ---
>
> Key: ARTEMIS-1800
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1800
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.5.0
>Reporter: Justin Bertram
>Priority: Major
>
> This will reproduce the failure if added to 
> {{org.apache.activemq.artemis.tests.integration.management.QueueControlTest}}:
> {noformat}
>@Test
>public void testGetScheduledCountOnRemove() throws Exception {
>   long delay = Integer.MAX_VALUE;
>   SimpleString address = RandomUtil.randomSimpleString();
>   SimpleString queue = RandomUtil.randomSimpleString();
>   session.createQueue(address, RoutingType.MULTICAST, queue, null, 
> durable);
>   QueueControl queueControl = createManagementControl(address, queue);
>   Assert.assertEquals(0, queueControl.getScheduledCount());
>   ClientProducer producer = session.createProducer(address);
>   ClientMessage message = session.createMessage(durable);
>   message.putLongProperty(Message.HDR_SCHEDULED_DELIVERY_TIME, 
> System.currentTimeMillis() + delay);
>   producer.send(message);
>   queueControl.removeAllMessages();
>   Assert.assertEquals(0, queueControl.getMessageCount());
>   session.deleteQueue(queue);
>}
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ARTEMIS-1800) Incorrect number of messages on queue after remove of scheduled message

[Justin Bertram (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Bertram updated ARTEMIS-1800:

Description: 
This will reproduce the failure if added to 
{{org.apache.activemq.artemis.tests.integration.management.QueueControlTest}}:
{noformat}
   @Test
   public void testGetScheduledCountOnRemove() throws Exception {
  long delay = Integer.MAX_VALUE;
  SimpleString address = RandomUtil.randomSimpleString();
  SimpleString queue = RandomUtil.randomSimpleString();

  session.createQueue(address, RoutingType.MULTICAST, queue, null, durable);

  QueueControl queueControl = createManagementControl(address, queue);
  Assert.assertEquals(0, queueControl.getScheduledCount());

  ClientProducer producer = session.createProducer(address);
  ClientMessage message = session.createMessage(durable);
  message.putLongProperty(Message.HDR_SCHEDULED_DELIVERY_TIME, 
System.currentTimeMillis() + delay);
  producer.send(message);

  queueControl.removeAllMessages();

  Assert.assertEquals(0, queueControl.getMessageCount());

  session.deleteQueue(queue);
   }
{noformat}

> Incorrect number of messages on queue after remove of scheduled message
> ---
>
> Key: ARTEMIS-1800
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1800
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.5.0
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>
> This will reproduce the failure if added to 
> {{org.apache.activemq.artemis.tests.integration.management.QueueControlTest}}:
> {noformat}
>@Test
>public void testGetScheduledCountOnRemove() throws Exception {
>   long delay = Integer.MAX_VALUE;
>   SimpleString address = RandomUtil.randomSimpleString();
>   SimpleString queue = RandomUtil.randomSimpleString();
>   session.createQueue(address, RoutingType.MULTICAST, queue, null, 
> durable);
>   QueueControl queueControl = createManagementControl(address, queue);
>   Assert.assertEquals(0, queueControl.getScheduledCount());
>   ClientProducer producer = session.createProducer(address);
>   ClientMessage message = session.createMessage(durable);
>   message.putLongProperty(Message.HDR_SCHEDULED_DELIVERY_TIME, 
> System.currentTimeMillis() + delay);
>   producer.send(message);
>   queueControl.removeAllMessages();
>   Assert.assertEquals(0, queueControl.getMessageCount());
>   session.deleteQueue(queue);
>}
> {noformat}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Comment Edited] (AMQ-6930) bin/activemq should allow stdout/stderr to some file instead of /dev/null for daemon mode

[Jamie goodyear (JIRA)]

[ 
https://issues.apache.org/jira/browse/AMQ-6930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432748#comment-16432748
 ] 

Jamie goodyear edited comment on AMQ-6930 at 4/10/18 6:40 PM:
--

Given the new behavior is controlled via environment variable switch, I think 
this is a fare change to make.

Classic behavior is retained unless you need the optional output location set.


was (Author: jgoodyear):
Given the new behavior is controlled via environment variable switch, I think 
this is a fare change to make.

> bin/activemq should allow stdout/stderr to some file instead of /dev/null for 
> daemon mode
> -
>
> Key: AMQ-6930
> URL: https://issues.apache.org/jira/browse/AMQ-6930
> Project: ActiveMQ
>  Issue Type: Wish
>Affects Versions: 5.15.0, 5.15.1, 5.15.2, 5.15.3
>Reporter: Alvin Lin
>Priority: Major
>
> if I do "bin/activemq start" the ActiveMQ process is started with 
> stdout/stdin redirected to /dev/null. 
> This makes it hard to debug issue like out of memory error because we can't 
> see any log, for example, when the JVM flag "ExitOnOutOfMemoryError" is 
> turned on. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (AMQ-6930) bin/activemq should allow stdout/stderr to some file instead of /dev/null for daemon mode

[Jamie goodyear (JIRA)]

[ 
https://issues.apache.org/jira/browse/AMQ-6930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432748#comment-16432748
 ] 

Jamie goodyear commented on AMQ-6930:
-

Given the new behavior is controlled via environment variable switch, I think 
this is a fare change to make.

> bin/activemq should allow stdout/stderr to some file instead of /dev/null for 
> daemon mode
> -
>
> Key: AMQ-6930
> URL: https://issues.apache.org/jira/browse/AMQ-6930
> Project: ActiveMQ
>  Issue Type: Wish
>Affects Versions: 5.15.0, 5.15.1, 5.15.2, 5.15.3
>Reporter: Alvin Lin
>Priority: Major
>
> if I do "bin/activemq start" the ActiveMQ process is started with 
> stdout/stdin redirected to /dev/null. 
> This makes it hard to debug issue like out of memory error because we can't 
> see any log, for example, when the JVM flag "ExitOnOutOfMemoryError" is 
> turned on. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (AMQ-6930) bin/activemq should allow stdout/stderr to some file instead of /dev/null for daemon mode

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/AMQ-6930?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432697#comment-16432697
 ] 

ASF GitHub Bot commented on AMQ-6930:
-

GitHub user alvinlin123 opened a pull request:

https://github.com/apache/activemq/pull/281

AMQ-6930 Expose an environment variable to allow redirect stdout/stderr to 
a file

This change does not modify the default behavior, the default behavior is 
still to pipe stdout/stderr to /dev/null. User can specify a file using an 
environment variable called `ACTIVEMQ_OUT` to  redirect stdout/stderr to the 
file. 

This change also added and fixed some tests in 
`assembly/src/test/scripts/init-script-testsuite`.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/alvinlin123/activemq amq-6930

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq/pull/281.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #281


commit f3a8e882068803a3cdab338d3544b27a7808e0cc
Author: Alvin Lin 
Date:   2018-04-09T23:53:44Z

AMQ-6930 provide options to allow stdout/stderr of activemq process to be 
redirect to a file using append mode

commit 6bb56decf881328f5595692ca17c1899f7f86a7b
Author: Alvin Lin 
Date:   2018-04-10T02:04:55Z

AMQ-6930 add test case




> bin/activemq should allow stdout/stderr to some file instead of /dev/null for 
> daemon mode
> -
>
> Key: AMQ-6930
> URL: https://issues.apache.org/jira/browse/AMQ-6930
> Project: ActiveMQ
>  Issue Type: Wish
>Affects Versions: 5.15.0, 5.15.1, 5.15.2, 5.15.3
>Reporter: Alvin Lin
>Priority: Major
>
> if I do "bin/activemq start" the ActiveMQ process is started with 
> stdout/stdin redirected to /dev/null. 
> This makes it hard to debug issue like out of memory error because we can't 
> see any log, for example, when the JVM flag "ExitOnOutOfMemoryError" is 
> turned on. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1797) Auto-create-address flag shouldn't block temp destination creation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432645#comment-16432645
 ] 

ASF GitHub Bot commented on ARTEMIS-1797:
-

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/2005


> Auto-create-address flag shouldn't block temp destination creation
> --
>
> Key: ARTEMIS-1797
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1797
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 2.5.0
>Reporter: Howard Gao
>Assignee: Howard Gao
>Priority: Major
> Fix For: 2.5.1
>
>
> When creating a temp destination and auto-create-address set to false, the 
> broker throws an error and refuse to create it. This doesn't conform to 
> normal use-case (like amqp dynamic flag) where the temp destination should be 
> allowed even if the auto-create-address is false.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1797) Auto-create-address flag shouldn't block temp destination creation

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432644#comment-16432644
 ] 

ASF subversion and git services commented on ARTEMIS-1797:
--

Commit 1175d777b3ce20606ac63548a934ad245a9eb666 in activemq-artemis's branch 
refs/heads/master from [~gaohoward]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=1175d77 ]

ARTEMIS-1797 Auto-create-address flag shouldn't avoid temp destination creation

When creating a temp destination and auto-create-address set to false, the
broker throws an error and refuse to create it. This doesn't conform to
normal use-case (like amqp dynamic flag) where the temp destination should
be allowed even if the auto-create-address is false.


> Auto-create-address flag shouldn't block temp destination creation
> --
>
> Key: ARTEMIS-1797
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1797
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 2.5.0
>Reporter: Howard Gao
>Assignee: Howard Gao
>Priority: Major
> Fix For: 2.5.1
>
>
> When creating a temp destination and auto-create-address set to false, the 
> broker throws an error and refuse to create it. This doesn't conform to 
> normal use-case (like amqp dynamic flag) where the temp destination should be 
> allowed even if the auto-create-address is false.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1797) Auto-create-address flag shouldn't block temp destination creation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432641#comment-16432641
 ] 

ASF GitHub Bot commented on ARTEMIS-1797:
-

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/2005
  
I will merge it .. but I will rename the commit message.


> Auto-create-address flag shouldn't block temp destination creation
> --
>
> Key: ARTEMIS-1797
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1797
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 2.5.0
>Reporter: Howard Gao
>Assignee: Howard Gao
>Priority: Major
> Fix For: 2.5.1
>
>
> When creating a temp destination and auto-create-address set to false, the 
> broker throws an error and refuse to create it. This doesn't conform to 
> normal use-case (like amqp dynamic flag) where the temp destination should be 
> allowed even if the auto-create-address is false.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1790) Improve Topology Member Finding

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432636#comment-16432636
 ] 

ASF GitHub Bot commented on ARTEMIS-1790:
-

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/1999
  
only issue I see is.. if this is broken.. then 
Topology::getMember(TransportConfiguration) is probably broken as well? That's 
used on freezeConnections and ScaleDownHandler

any chance you can fix it?


> Improve Topology Member Finding
> ---
>
> Key: ARTEMIS-1790
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1790
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Broker
>Affects Versions: 2.5.0
>Reporter: Howard Gao
>Assignee: Howard Gao
>Priority: Major
> Fix For: 2.5.1
>
>
> When finding out if a connector belong to a target node it compares the whole 
> parameter map which is not necessary. Also in understanding the connector the 
> best place is to delegate it to the corresponding remoting connection who 
> understands it. (e.g. INVMConnection knows whether the connector belongs to a 
> target node by checking it's serverID only. The netty ones only need to match 
> host and port, and understanding that localhost and 127.0.0.1 are same thing).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1790) Improve Topology Member Finding

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432635#comment-16432635
 ] 

ASF GitHub Bot commented on ARTEMIS-1790:
-

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1999#discussion_r180507233
  
--- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnection.java
 ---
@@ -511,6 +511,45 @@ public final boolean isUsingProtocolHandling() {
   return true;
}
 
+   @Override
+   public boolean isSameTarget(TransportConfiguration... configs) {
+  boolean yes = false;
--- End diff --

@gaohoward  can you rename it from yes? :)

call it result if you like :)


> Improve Topology Member Finding
> ---
>
> Key: ARTEMIS-1790
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1790
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Broker
>Affects Versions: 2.5.0
>Reporter: Howard Gao
>Assignee: Howard Gao
>Priority: Major
> Fix For: 2.5.1
>
>
> When finding out if a connector belong to a target node it compares the whole 
> parameter map which is not necessary. Also in understanding the connector the 
> best place is to delegate it to the corresponding remoting connection who 
> understands it. (e.g. INVMConnection knows whether the connector belongs to a 
> target node by checking it's serverID only. The netty ones only need to match 
> host and port, and understanding that localhost and 127.0.0.1 are same thing).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1798) DEBUG message bad write method arg count: public void org.apache.activemq.artemis.core.protocol.openwire.OpenWireProtocolManager.setUpInactivityParams

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432618#comment-16432618
 ] 

ASF GitHub Bot commented on ARTEMIS-1798:
-

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/2006


> DEBUG message bad write method arg count: public void 
> org.apache.activemq.artemis.core.protocol.openwire.OpenWireProtocolManager.setUpInactivityParams
> --
>
> Key: ARTEMIS-1798
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1798
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Stanislav Knot
>Assignee: Stanislav Knot
>Priority: Trivial
>
> {noformat}
> 16:06:31,002 DEBUG 
> [org.apache.activemq.artemis.utils.uri.FluentPropertyBeanIntrospectorWithIgnores]
>  bad write method arg count: public void 
> org.apache.activemq.artemis.core.protocol.openwire.OpenWireProtocolManager.setUpInactivityParams(org.apache.activemq.artemis.core.protocol.openwire.OpenWireConnection,org.apache.activemq.command.WireFormatInfo)
>  throws java.io.IOException: java.beans.IntrospectionException: bad write 
> method arg count: public void 
> org.apache.activemq.artemis.core.protocol.openwire.OpenWireProtocolManager.setUpInactivityParams(org.apache.activemq.artemis.core.protocol.openwire.OpenWireConnection,org.
> {noformat}
> setUpInactivityParams does not set any property, which causes this error 
> message when debug logging is enabled.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1798) DEBUG message bad write method arg count: public void org.apache.activemq.artemis.core.protocol.openwire.OpenWireProtocolManager.setUpInactivityParams

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432617#comment-16432617
 ] 

ASF subversion and git services commented on ARTEMIS-1798:
--

Commit 5063488b2118e854bf91acbf4d888bd5b6a0179d in activemq-artemis's branch 
refs/heads/master from [~sknot]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=5063488 ]

ARTEMIS-1798 DEBUG message bad write method arg count - fix


> DEBUG message bad write method arg count: public void 
> org.apache.activemq.artemis.core.protocol.openwire.OpenWireProtocolManager.setUpInactivityParams
> --
>
> Key: ARTEMIS-1798
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1798
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Stanislav Knot
>Assignee: Stanislav Knot
>Priority: Trivial
>
> {noformat}
> 16:06:31,002 DEBUG 
> [org.apache.activemq.artemis.utils.uri.FluentPropertyBeanIntrospectorWithIgnores]
>  bad write method arg count: public void 
> org.apache.activemq.artemis.core.protocol.openwire.OpenWireProtocolManager.setUpInactivityParams(org.apache.activemq.artemis.core.protocol.openwire.OpenWireConnection,org.apache.activemq.command.WireFormatInfo)
>  throws java.io.IOException: java.beans.IntrospectionException: bad write 
> method arg count: public void 
> org.apache.activemq.artemis.core.protocol.openwire.OpenWireProtocolManager.setUpInactivityParams(org.apache.activemq.artemis.core.protocol.openwire.OpenWireConnection,org.
> {noformat}
> setUpInactivityParams does not set any property, which causes this error 
> message when debug logging is enabled.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1797) Auto-create-address flag shouldn't block temp destination creation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432615#comment-16432615
 ] 

ASF GitHub Bot commented on ARTEMIS-1797:
-

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/2005
  
@gaohoward by block did you mean avoid? When you say block I was expecting 
a client blocking or not completing.


> Auto-create-address flag shouldn't block temp destination creation
> --
>
> Key: ARTEMIS-1797
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1797
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 2.5.0
>Reporter: Howard Gao
>Assignee: Howard Gao
>Priority: Major
> Fix For: 2.5.1
>
>
> When creating a temp destination and auto-create-address set to false, the 
> broker throws an error and refuse to create it. This doesn't conform to 
> normal use-case (like amqp dynamic flag) where the temp destination should be 
> allowed even if the auto-create-address is false.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1798) DEBUG message bad write method arg count: public void org.apache.activemq.artemis.core.protocol.openwire.OpenWireProtocolManager.setUpInactivityParams

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432545#comment-16432545
 ] 

ASF GitHub Bot commented on ARTEMIS-1798:
-

Github user jdanekrh commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/2006#discussion_r180483597
  
--- Diff: 
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireProtocolManager.java
 ---
@@ -84,6 +85,10 @@
 import org.apache.activemq.util.LongSequenceGenerator;
 
 public class OpenWireProtocolManager implements 
ProtocolManager, ClusterTopologyListener {
+   static {
+  // this is not really a property, needs to be ignored
+  
FluentPropertyBeanIntrospectorWithIgnores.addIgnore(OpenWireProtocolManager.class.getName(),
 "setUpInactivityParams");
--- End diff --

@stanlyDoge told you so ))


> DEBUG message bad write method arg count: public void 
> org.apache.activemq.artemis.core.protocol.openwire.OpenWireProtocolManager.setUpInactivityParams
> --
>
> Key: ARTEMIS-1798
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1798
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Stanislav Knot
>Assignee: Stanislav Knot
>Priority: Trivial
>
> {noformat}
> 16:06:31,002 DEBUG 
> [org.apache.activemq.artemis.utils.uri.FluentPropertyBeanIntrospectorWithIgnores]
>  bad write method arg count: public void 
> org.apache.activemq.artemis.core.protocol.openwire.OpenWireProtocolManager.setUpInactivityParams(org.apache.activemq.artemis.core.protocol.openwire.OpenWireConnection,org.apache.activemq.command.WireFormatInfo)
>  throws java.io.IOException: java.beans.IntrospectionException: bad write 
> method arg count: public void 
> org.apache.activemq.artemis.core.protocol.openwire.OpenWireProtocolManager.setUpInactivityParams(org.apache.activemq.artemis.core.protocol.openwire.OpenWireConnection,org.
> {noformat}
> setUpInactivityParams does not set any property, which causes this error 
> message when debug logging is enabled.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1799) Create a NotificationActiveMQServerPlugin to publish new types of notifications

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432535#comment-16432535
 ] 

ASF GitHub Bot commented on ARTEMIS-1799:
-

Github user cshannon commented on the issue:

https://github.com/apache/activemq-artemis/pull/2007
  
@clebertsuconic - thanks for merging 


> Create a NotificationActiveMQServerPlugin to publish new types of 
> notifications
> ---
>
> Key: ARTEMIS-1799
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1799
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>  Components: Broker
>Affects Versions: 2.5.0
>Reporter: Christopher L. Shannon
>Assignee: Christopher L. Shannon
>Priority: Major
> Fix For: 2.6.0
>
>
> For monitoring the broker it would be helpful to support publishing of new 
> notification types that can be listened for.  This is similar to the 
> advisories that ActiveMQ 5.x supports.
> By adding this functionality to a plugin it can be easily enabled/disabled by 
> the user through configuration and fine tuned to a user's requirements.  For 
> this initial Jira I'm proposing adding the following notification types: 
> connection creation/destroyed events, session created/closed events, address 
> added/removed events, delivered messages, and expired messages.
> It will be easy to enhance these new notifications in future Jiras (ie add 
> more properties to the messages if necessary) and also easy to add new 
> notifications to the plugin.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Resolved] (ARTEMIS-1799) Create a NotificationActiveMQServerPlugin to publish new types of notifications

[Christopher L. Shannon (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1799?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Christopher L. Shannon resolved ARTEMIS-1799.
-
Resolution: Fixed

> Create a NotificationActiveMQServerPlugin to publish new types of 
> notifications
> ---
>
> Key: ARTEMIS-1799
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1799
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>  Components: Broker
>Affects Versions: 2.5.0
>Reporter: Christopher L. Shannon
>Assignee: Christopher L. Shannon
>Priority: Major
> Fix For: 2.6.0
>
>
> For monitoring the broker it would be helpful to support publishing of new 
> notification types that can be listened for.  This is similar to the 
> advisories that ActiveMQ 5.x supports.
> By adding this functionality to a plugin it can be easily enabled/disabled by 
> the user through configuration and fine tuned to a user's requirements.  For 
> this initial Jira I'm proposing adding the following notification types: 
> connection creation/destroyed events, session created/closed events, address 
> added/removed events, delivered messages, and expired messages.
> It will be easy to enhance these new notifications in future Jiras (ie add 
> more properties to the messages if necessary) and also easy to add new 
> notifications to the plugin.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1799) Create a NotificationActiveMQServerPlugin to publish new types of notifications

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432525#comment-16432525
 ] 

ASF GitHub Bot commented on ARTEMIS-1799:
-

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/2007
  
@cshannon I see. .thanks for the clarification. merging it.


> Create a NotificationActiveMQServerPlugin to publish new types of 
> notifications
> ---
>
> Key: ARTEMIS-1799
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1799
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>  Components: Broker
>Affects Versions: 2.5.0
>Reporter: Christopher L. Shannon
>Assignee: Christopher L. Shannon
>Priority: Major
> Fix For: 2.6.0
>
>
> For monitoring the broker it would be helpful to support publishing of new 
> notification types that can be listened for.  This is similar to the 
> advisories that ActiveMQ 5.x supports.
> By adding this functionality to a plugin it can be easily enabled/disabled by 
> the user through configuration and fine tuned to a user's requirements.  For 
> this initial Jira I'm proposing adding the following notification types: 
> connection creation/destroyed events, session created/closed events, address 
> added/removed events, delivered messages, and expired messages.
> It will be easy to enhance these new notifications in future Jiras (ie add 
> more properties to the messages if necessary) and also easy to add new 
> notifications to the plugin.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1799) Create a NotificationActiveMQServerPlugin to publish new types of notifications

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432527#comment-16432527
 ] 

ASF GitHub Bot commented on ARTEMIS-1799:
-

Github user asfgit closed the pull request at:

https://github.com/apache/activemq-artemis/pull/2007


> Create a NotificationActiveMQServerPlugin to publish new types of 
> notifications
> ---
>
> Key: ARTEMIS-1799
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1799
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>  Components: Broker
>Affects Versions: 2.5.0
>Reporter: Christopher L. Shannon
>Assignee: Christopher L. Shannon
>Priority: Major
> Fix For: 2.6.0
>
>
> For monitoring the broker it would be helpful to support publishing of new 
> notification types that can be listened for.  This is similar to the 
> advisories that ActiveMQ 5.x supports.
> By adding this functionality to a plugin it can be easily enabled/disabled by 
> the user through configuration and fine tuned to a user's requirements.  For 
> this initial Jira I'm proposing adding the following notification types: 
> connection creation/destroyed events, session created/closed events, address 
> added/removed events, delivered messages, and expired messages.
> It will be easy to enhance these new notifications in future Jiras (ie add 
> more properties to the messages if necessary) and also easy to add new 
> notifications to the plugin.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1798) DEBUG message bad write method arg count: public void org.apache.activemq.artemis.core.protocol.openwire.OpenWireProtocolManager.setUpInactivityParams

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432528#comment-16432528
 ] 

ASF GitHub Bot commented on ARTEMIS-1798:
-

Github user clebertsuconic commented on the issue:

https://github.com/apache/activemq-artemis/pull/2006
  
nice one.. thanks.. will wait the check and merge it


> DEBUG message bad write method arg count: public void 
> org.apache.activemq.artemis.core.protocol.openwire.OpenWireProtocolManager.setUpInactivityParams
> --
>
> Key: ARTEMIS-1798
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1798
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Stanislav Knot
>Assignee: Stanislav Knot
>Priority: Trivial
>
> {noformat}
> 16:06:31,002 DEBUG 
> [org.apache.activemq.artemis.utils.uri.FluentPropertyBeanIntrospectorWithIgnores]
>  bad write method arg count: public void 
> org.apache.activemq.artemis.core.protocol.openwire.OpenWireProtocolManager.setUpInactivityParams(org.apache.activemq.artemis.core.protocol.openwire.OpenWireConnection,org.apache.activemq.command.WireFormatInfo)
>  throws java.io.IOException: java.beans.IntrospectionException: bad write 
> method arg count: public void 
> org.apache.activemq.artemis.core.protocol.openwire.OpenWireProtocolManager.setUpInactivityParams(org.apache.activemq.artemis.core.protocol.openwire.OpenWireConnection,org.
> {noformat}
> setUpInactivityParams does not set any property, which causes this error 
> message when debug logging is enabled.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1799) Create a NotificationActiveMQServerPlugin to publish new types of notifications

[ASF subversion and git services (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432526#comment-16432526
 ] 

ASF subversion and git services commented on ARTEMIS-1799:
--

Commit 4795f7c6d0e9242c2fc1f364b1cc025a1ce037b6 in activemq-artemis's branch 
refs/heads/master from [~cshannon]
[ https://git-wip-us.apache.org/repos/asf?p=activemq-artemis.git;h=4795f7c ]

ARTEMIS-1799 - Add a NotificationActiveMQServerPlugin

Adds a new plugin that will support sending new types of notifications
for broker events which will allow enhanced broker monitoring


> Create a NotificationActiveMQServerPlugin to publish new types of 
> notifications
> ---
>
> Key: ARTEMIS-1799
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1799
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>  Components: Broker
>Affects Versions: 2.5.0
>Reporter: Christopher L. Shannon
>Assignee: Christopher L. Shannon
>Priority: Major
> Fix For: 2.6.0
>
>
> For monitoring the broker it would be helpful to support publishing of new 
> notification types that can be listened for.  This is similar to the 
> advisories that ActiveMQ 5.x supports.
> By adding this functionality to a plugin it can be easily enabled/disabled by 
> the user through configuration and fine tuned to a user's requirements.  For 
> this initial Jira I'm proposing adding the following notification types: 
> connection creation/destroyed events, session created/closed events, address 
> added/removed events, delivered messages, and expired messages.
> It will be easy to enhance these new notifications in future Jiras (ie add 
> more properties to the messages if necessary) and also easy to add new 
> notifications to the plugin.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1798) DEBUG message bad write method arg count: public void org.apache.activemq.artemis.core.protocol.openwire.OpenWireProtocolManager.setUpInactivityParams

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432501#comment-16432501
 ] 

ASF GitHub Bot commented on ARTEMIS-1798:
-

Github user stanlyDoge commented on the issue:

https://github.com/apache/activemq-artemis/pull/2006
  
@clebertsuconic Renamed.


> DEBUG message bad write method arg count: public void 
> org.apache.activemq.artemis.core.protocol.openwire.OpenWireProtocolManager.setUpInactivityParams
> --
>
> Key: ARTEMIS-1798
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1798
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Stanislav Knot
>Assignee: Stanislav Knot
>Priority: Trivial
>
> {noformat}
> 16:06:31,002 DEBUG 
> [org.apache.activemq.artemis.utils.uri.FluentPropertyBeanIntrospectorWithIgnores]
>  bad write method arg count: public void 
> org.apache.activemq.artemis.core.protocol.openwire.OpenWireProtocolManager.setUpInactivityParams(org.apache.activemq.artemis.core.protocol.openwire.OpenWireConnection,org.apache.activemq.command.WireFormatInfo)
>  throws java.io.IOException: java.beans.IntrospectionException: bad write 
> method arg count: public void 
> org.apache.activemq.artemis.core.protocol.openwire.OpenWireProtocolManager.setUpInactivityParams(org.apache.activemq.artemis.core.protocol.openwire.OpenWireConnection,org.
> {noformat}
> setUpInactivityParams does not set any property, which causes this error 
> message when debug logging is enabled.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ARTEMIS-1800) Incorrect number of messages on queue after remove of scheduled message

[Justin Bertram (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1800?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Bertram updated ARTEMIS-1800:

Summary: Incorrect number of messages on queue after remove of scheduled 
message  (was: Removing scheduled message causes negative message count)

> Incorrect number of messages on queue after remove of scheduled message
> ---
>
> Key: ARTEMIS-1800
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1800
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Affects Versions: 2.5.0
>Reporter: Justin Bertram
>Assignee: Justin Bertram
>Priority: Major
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (ARTEMIS-1800) Removing scheduled message causes negative message count

[Justin Bertram (JIRA)]

Justin Bertram created ARTEMIS-1800:
---

 Summary: Removing scheduled message causes negative message count
 Key: ARTEMIS-1800
 URL: https://issues.apache.org/jira/browse/ARTEMIS-1800
 Project: ActiveMQ Artemis
  Issue Type: Bug
Affects Versions: 2.5.0
Reporter: Justin Bertram
Assignee: Justin Bertram






--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1799) Create a NotificationActiveMQServerPlugin to publish new types of notifications

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432447#comment-16432447
 ] 

ASF GitHub Bot commented on ARTEMIS-1799:
-

Github user cshannon commented on the issue:

https://github.com/apache/activemq-artemis/pull/2007
  
I don't understand the confusion.  That call just calls off to any 
registered plugins if they exist.  This commit is a brand new plugin that 
implements the afterDeliver call and fires off a notification. But it only 
fires off that notification if the flag in the plugin is set to true.


> Create a NotificationActiveMQServerPlugin to publish new types of 
> notifications
> ---
>
> Key: ARTEMIS-1799
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1799
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>  Components: Broker
>Affects Versions: 2.5.0
>Reporter: Christopher L. Shannon
>Assignee: Christopher L. Shannon
>Priority: Major
> Fix For: 2.6.0
>
>
> For monitoring the broker it would be helpful to support publishing of new 
> notification types that can be listened for.  This is similar to the 
> advisories that ActiveMQ 5.x supports.
> By adding this functionality to a plugin it can be easily enabled/disabled by 
> the user through configuration and fine tuned to a user's requirements.  For 
> this initial Jira I'm proposing adding the following notification types: 
> connection creation/destroyed events, session created/closed events, address 
> added/removed events, delivered messages, and expired messages.
> It will be easy to enhance these new notifications in future Jiras (ie add 
> more properties to the messages if necessary) and also easy to add new 
> notifications to the plugin.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1798) DEBUG message bad write method arg count: public void org.apache.activemq.artemis.core.protocol.openwire.OpenWireProtocolManager.setUpInactivityParams

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432444#comment-16432444
 ] 

ASF GitHub Bot commented on ARTEMIS-1798:
-

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/2006#discussion_r180460101
  
--- Diff: 
artemis-protocols/artemis-openwire-protocol/src/main/java/org/apache/activemq/artemis/core/protocol/openwire/OpenWireProtocolManager.java
 ---
@@ -84,6 +85,10 @@
 import org.apache.activemq.util.LongSequenceGenerator;
 
 public class OpenWireProtocolManager implements 
ProtocolManager, ClusterTopologyListener {
+   static {
+  // this is not really a property, needs to be ignored
+  
FluentPropertyBeanIntrospectorWithIgnores.addIgnore(OpenWireProtocolManager.class.getName(),
 "setUpInactivityParams");
--- End diff --

Instead of that.. what about renaming the method to 
configureInactivityParams.

You wouldn't need to do anything with Beans.


> DEBUG message bad write method arg count: public void 
> org.apache.activemq.artemis.core.protocol.openwire.OpenWireProtocolManager.setUpInactivityParams
> --
>
> Key: ARTEMIS-1798
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1798
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Stanislav Knot
>Assignee: Stanislav Knot
>Priority: Trivial
>
> {noformat}
> 16:06:31,002 DEBUG 
> [org.apache.activemq.artemis.utils.uri.FluentPropertyBeanIntrospectorWithIgnores]
>  bad write method arg count: public void 
> org.apache.activemq.artemis.core.protocol.openwire.OpenWireProtocolManager.setUpInactivityParams(org.apache.activemq.artemis.core.protocol.openwire.OpenWireConnection,org.apache.activemq.command.WireFormatInfo)
>  throws java.io.IOException: java.beans.IntrospectionException: bad write 
> method arg count: public void 
> org.apache.activemq.artemis.core.protocol.openwire.OpenWireProtocolManager.setUpInactivityParams(org.apache.activemq.artemis.core.protocol.openwire.OpenWireConnection,org.
> {noformat}
> setUpInactivityParams does not set any property, which causes this error 
> message when debug logging is enabled.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1799) Create a NotificationActiveMQServerPlugin to publish new types of notifications

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432434#comment-16432434
 ] 

ASF GitHub Bot commented on ARTEMIS-1799:
-

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/2007#discussion_r180458900
  
--- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/CoreNotificationType.java
 ---
@@ -39,7 +39,15 @@
PROPOSAL(18),
PROPOSAL_RESPONSE(19),
UNPROPOSAL(20),
-   CONSUMER_SLOW(21);
+   CONSUMER_SLOW(21),
+   ADDRESS_ADDED(22),
+   ADDRESS_REMOVED(23),
+   CONNECTION_CREATED(24),
+   CONNECTION_DESTROYED(25),
+   SESSION_CREATED(26),
+   SESSION_CLOSED(27),
+   MESSAGE_DELIVERED(28),
--- End diff --

@cshannon this one: 
https://github.com/apache/activemq-artemis/blob/39fc8cf1413c0f3cbb88913531753e8a7dba3d07/artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/ServerConsumerImpl.java#L437


> Create a NotificationActiveMQServerPlugin to publish new types of 
> notifications
> ---
>
> Key: ARTEMIS-1799
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1799
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>  Components: Broker
>Affects Versions: 2.5.0
>Reporter: Christopher L. Shannon
>Assignee: Christopher L. Shannon
>Priority: Major
> Fix For: 2.6.0
>
>
> For monitoring the broker it would be helpful to support publishing of new 
> notification types that can be listened for.  This is similar to the 
> advisories that ActiveMQ 5.x supports.
> By adding this functionality to a plugin it can be easily enabled/disabled by 
> the user through configuration and fine tuned to a user's requirements.  For 
> this initial Jira I'm proposing adding the following notification types: 
> connection creation/destroyed events, session created/closed events, address 
> added/removed events, delivered messages, and expired messages.
> It will be easy to enhance these new notifications in future Jiras (ie add 
> more properties to the messages if necessary) and also easy to add new 
> notifications to the plugin.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1799) Create a NotificationActiveMQServerPlugin to publish new types of notifications

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432427#comment-16432427
 ] 

ASF GitHub Bot commented on ARTEMIS-1799:
-

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/2007#discussion_r180457921
  
--- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/CoreNotificationType.java
 ---
@@ -39,7 +39,15 @@
PROPOSAL(18),
PROPOSAL_RESPONSE(19),
UNPROPOSAL(20),
-   CONSUMER_SLOW(21);
+   CONSUMER_SLOW(21),
+   ADDRESS_ADDED(22),
+   ADDRESS_REMOVED(23),
+   CONNECTION_CREATED(24),
+   CONNECTION_DESTROYED(25),
+   SESSION_CREATED(26),
+   SESSION_CLOSED(27),
+   MESSAGE_DELIVERED(28),
--- End diff --

@cshannon when  you go to ServerConsumerImpl, there's already a previous 
call you added to afterDeliver, that's apparently gets called every time.


Shouldn't that be changed to call this new component you wrote?


I guess that's where I'm getting confused. I read the code as part of your 
change now and I see that's an older change you added back in Jan this year.


Can you take a look for the relationship between that change and this one 
now?


> Create a NotificationActiveMQServerPlugin to publish new types of 
> notifications
> ---
>
> Key: ARTEMIS-1799
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1799
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>  Components: Broker
>Affects Versions: 2.5.0
>Reporter: Christopher L. Shannon
>Assignee: Christopher L. Shannon
>Priority: Major
> Fix For: 2.6.0
>
>
> For monitoring the broker it would be helpful to support publishing of new 
> notification types that can be listened for.  This is similar to the 
> advisories that ActiveMQ 5.x supports.
> By adding this functionality to a plugin it can be easily enabled/disabled by 
> the user through configuration and fine tuned to a user's requirements.  For 
> this initial Jira I'm proposing adding the following notification types: 
> connection creation/destroyed events, session created/closed events, address 
> added/removed events, delivered messages, and expired messages.
> It will be easy to enhance these new notifications in future Jiras (ie add 
> more properties to the messages if necessary) and also easy to add new 
> notifications to the plugin.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1799) Create a NotificationActiveMQServerPlugin to publish new types of notifications

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432398#comment-16432398
 ] 

ASF GitHub Bot commented on ARTEMIS-1799:
-

Github user cshannon commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/2007#discussion_r180449915
  
--- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/CoreNotificationType.java
 ---
@@ -39,7 +39,15 @@
PROPOSAL(18),
PROPOSAL_RESPONSE(19),
UNPROPOSAL(20),
-   CONSUMER_SLOW(21);
+   CONSUMER_SLOW(21),
+   ADDRESS_ADDED(22),
+   ADDRESS_REMOVED(23),
+   CONNECTION_CREATED(24),
+   CONNECTION_DESTROYED(25),
+   SESSION_CREATED(26),
+   SESSION_CLOSED(27),
+   MESSAGE_DELIVERED(28),
--- End diff --

No because every notification is off by default.  The user can configure 
what they want.  By default if you configure the plugin it doesn't do anything 
unless the user sets a type to true to send.  So if someone doesn't care about 
message delivered notifications then just leave that flag as false.


> Create a NotificationActiveMQServerPlugin to publish new types of 
> notifications
> ---
>
> Key: ARTEMIS-1799
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1799
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>  Components: Broker
>Affects Versions: 2.5.0
>Reporter: Christopher L. Shannon
>Assignee: Christopher L. Shannon
>Priority: Major
> Fix For: 2.6.0
>
>
> For monitoring the broker it would be helpful to support publishing of new 
> notification types that can be listened for.  This is similar to the 
> advisories that ActiveMQ 5.x supports.
> By adding this functionality to a plugin it can be easily enabled/disabled by 
> the user through configuration and fine tuned to a user's requirements.  For 
> this initial Jira I'm proposing adding the following notification types: 
> connection creation/destroyed events, session created/closed events, address 
> added/removed events, delivered messages, and expired messages.
> It will be easy to enhance these new notifications in future Jiras (ie add 
> more properties to the messages if necessary) and also easy to add new 
> notifications to the plugin.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1799) Create a NotificationActiveMQServerPlugin to publish new types of notifications

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432392#comment-16432392
 ] 

ASF GitHub Bot commented on ARTEMIS-1799:
-

Github user clebertsuconic commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/2007#discussion_r180448672
  
--- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/api/core/management/CoreNotificationType.java
 ---
@@ -39,7 +39,15 @@
PROPOSAL(18),
PROPOSAL_RESPONSE(19),
UNPROPOSAL(20),
-   CONSUMER_SLOW(21);
+   CONSUMER_SLOW(21),
+   ADDRESS_ADDED(22),
+   ADDRESS_REMOVED(23),
+   CONNECTION_CREATED(24),
+   CONNECTION_DESTROYED(25),
+   SESSION_CREATED(26),
+   SESSION_CLOSED(27),
+   MESSAGE_DELIVERED(28),
--- End diff --

isn't that too costly to the broker?

that's a lot of notifications here. I don't think we should do on 
MESSAGE_DELIVERED.


> Create a NotificationActiveMQServerPlugin to publish new types of 
> notifications
> ---
>
> Key: ARTEMIS-1799
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1799
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>  Components: Broker
>Affects Versions: 2.5.0
>Reporter: Christopher L. Shannon
>Assignee: Christopher L. Shannon
>Priority: Major
> Fix For: 2.6.0
>
>
> For monitoring the broker it would be helpful to support publishing of new 
> notification types that can be listened for.  This is similar to the 
> advisories that ActiveMQ 5.x supports.
> By adding this functionality to a plugin it can be easily enabled/disabled by 
> the user through configuration and fine tuned to a user's requirements.  For 
> this initial Jira I'm proposing adding the following notification types: 
> connection creation/destroyed events, session created/closed events, address 
> added/removed events, delivered messages, and expired messages.
> It will be easy to enhance these new notifications in future Jiras (ie add 
> more properties to the messages if necessary) and also easy to add new 
> notifications to the plugin.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1799) Create a NotificationActiveMQServerPlugin to publish new types of notifications

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1799?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432277#comment-16432277
 ] 

ASF GitHub Bot commented on ARTEMIS-1799:
-

GitHub user cshannon opened a pull request:

https://github.com/apache/activemq-artemis/pull/2007

ARTEMIS-1799 - Add a NotificationActiveMQServerPlugin

Adds a new plugin that will support sending new types of notifications
for broker events which will allow enhanced broker monitoring

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/cshannon/activemq-artemis ARTEMIS-1799

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/2007.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2007


commit 4795f7c6d0e9242c2fc1f364b1cc025a1ce037b6
Author: Christopher L. Shannon (cshannon) 
Date:   2018-04-10T13:19:11Z

ARTEMIS-1799 - Add a NotificationActiveMQServerPlugin

Adds a new plugin that will support sending new types of notifications
for broker events which will allow enhanced broker monitoring




> Create a NotificationActiveMQServerPlugin to publish new types of 
> notifications
> ---
>
> Key: ARTEMIS-1799
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1799
> Project: ActiveMQ Artemis
>  Issue Type: New Feature
>  Components: Broker
>Affects Versions: 2.5.0
>Reporter: Christopher L. Shannon
>Assignee: Christopher L. Shannon
>Priority: Major
> Fix For: 2.6.0
>
>
> For monitoring the broker it would be helpful to support publishing of new 
> notification types that can be listened for.  This is similar to the 
> advisories that ActiveMQ 5.x supports.
> By adding this functionality to a plugin it can be easily enabled/disabled by 
> the user through configuration and fine tuned to a user's requirements.  For 
> this initial Jira I'm proposing adding the following notification types: 
> connection creation/destroyed events, session created/closed events, address 
> added/removed events, delivered messages, and expired messages.
> It will be easy to enhance these new notifications in future Jiras (ie add 
> more properties to the messages if necessary) and also easy to add new 
> notifications to the plugin.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (ARTEMIS-1799) Create a NotificationActiveMQServerPlugin to publish new types of notifications

[Christopher L. Shannon (JIRA)]

Christopher L. Shannon created ARTEMIS-1799:
---

 Summary: Create a NotificationActiveMQServerPlugin to publish new 
types of notifications
 Key: ARTEMIS-1799
 URL: https://issues.apache.org/jira/browse/ARTEMIS-1799
 Project: ActiveMQ Artemis
  Issue Type: New Feature
  Components: Broker
Affects Versions: 2.5.0
Reporter: Christopher L. Shannon
Assignee: Christopher L. Shannon
 Fix For: 2.6.0


For monitoring the broker it would be helpful to support publishing of new 
notification types that can be listened for.  This is similar to the advisories 
that ActiveMQ 5.x supports.

By adding this functionality to a plugin it can be easily enabled/disabled by 
the user through configuration and fine tuned to a user's requirements.  For 
this initial Jira I'm proposing adding the following notification types: 
connection creation/destroyed events, session created/closed events, address 
added/removed events, delivered messages, and expired messages.

It will be easy to enhance these new notifications in future Jiras (ie add more 
properties to the messages if necessary) and also easy to add new notifications 
to the plugin.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Work started] (ARTEMIS-1798) DEBUG message bad write method arg count: public void org.apache.activemq.artemis.core.protocol.openwire.OpenWireProtocolManager.setUpInactivityParams

[Stanislav Knot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Work on ARTEMIS-1798 started by Stanislav Knot.
---
> DEBUG message bad write method arg count: public void 
> org.apache.activemq.artemis.core.protocol.openwire.OpenWireProtocolManager.setUpInactivityParams
> --
>
> Key: ARTEMIS-1798
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1798
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Stanislav Knot
>Assignee: Stanislav Knot
>Priority: Trivial
>
> {noformat}
> 16:06:31,002 DEBUG 
> [org.apache.activemq.artemis.utils.uri.FluentPropertyBeanIntrospectorWithIgnores]
>  bad write method arg count: public void 
> org.apache.activemq.artemis.core.protocol.openwire.OpenWireProtocolManager.setUpInactivityParams(org.apache.activemq.artemis.core.protocol.openwire.OpenWireConnection,org.apache.activemq.command.WireFormatInfo)
>  throws java.io.IOException: java.beans.IntrospectionException: bad write 
> method arg count: public void 
> org.apache.activemq.artemis.core.protocol.openwire.OpenWireProtocolManager.setUpInactivityParams(org.apache.activemq.artemis.core.protocol.openwire.OpenWireConnection,org.
> {noformat}
> setUpInactivityParams does not set any property, which causes this error 
> message when debug logging is enabled.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Updated] (ARTEMIS-1798) DEBUG message bad write method arg count: public void org.apache.activemq.artemis.core.protocol.openwire.OpenWireProtocolManager.setUpInactivityParams

[Stanislav Knot (JIRA)]

 [ 
https://issues.apache.org/jira/browse/ARTEMIS-1798?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Stanislav Knot updated ARTEMIS-1798:

Description: 
{noformat}
16:06:31,002 DEBUG 
[org.apache.activemq.artemis.utils.uri.FluentPropertyBeanIntrospectorWithIgnores]
 bad write method arg count: public void 
org.apache.activemq.artemis.core.protocol.openwire.OpenWireProtocolManager.setUpInactivityParams(org.apache.activemq.artemis.core.protocol.openwire.OpenWireConnection,org.apache.activemq.command.WireFormatInfo)
 throws java.io.IOException: java.beans.IntrospectionException: bad write 
method arg count: public void 
org.apache.activemq.artemis.core.protocol.openwire.OpenWireProtocolManager.setUpInactivityParams(org.apache.activemq.artemis.core.protocol.openwire.OpenWireConnection,org.

{noformat}
setUpInactivityParams does not set any property, which causes this error 
message when debug logging is enabled.

  was:
{noformat}

16:06:31,002 DEBUG 
[org.apache.activemq.artemis.utils.uri.FluentPropertyBeanIntrospectorWithIgnores]
 bad write method arg count: public void 
org.apache.activemq.artemis.core.protocol.openwire.OpenWireProtocolManager.setUpInactivityParams(org.apache.activemq.artemis.core.protocol.openwire.OpenWireConnection,org.apache.activemq.command.WireFormatInfo)
 throws java.io.IOException: java.beans.IntrospectionException: bad write 
method arg count: public void 
org.apache.activemq.artemis.core.protocol.openwire.OpenWireProtocolManager.setUpInactivityParams(org.apache.activemq.artemis.core.protocol.openwire.OpenWireConnection,org.

{noformat}

setUpInactivityParams does not set property, which causes this message when 
debug logging is enabled.


> DEBUG message bad write method arg count: public void 
> org.apache.activemq.artemis.core.protocol.openwire.OpenWireProtocolManager.setUpInactivityParams
> --
>
> Key: ARTEMIS-1798
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1798
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Stanislav Knot
>Assignee: Stanislav Knot
>Priority: Trivial
>
> {noformat}
> 16:06:31,002 DEBUG 
> [org.apache.activemq.artemis.utils.uri.FluentPropertyBeanIntrospectorWithIgnores]
>  bad write method arg count: public void 
> org.apache.activemq.artemis.core.protocol.openwire.OpenWireProtocolManager.setUpInactivityParams(org.apache.activemq.artemis.core.protocol.openwire.OpenWireConnection,org.apache.activemq.command.WireFormatInfo)
>  throws java.io.IOException: java.beans.IntrospectionException: bad write 
> method arg count: public void 
> org.apache.activemq.artemis.core.protocol.openwire.OpenWireProtocolManager.setUpInactivityParams(org.apache.activemq.artemis.core.protocol.openwire.OpenWireConnection,org.
> {noformat}
> setUpInactivityParams does not set any property, which causes this error 
> message when debug logging is enabled.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1790) Improve Topology Member Finding

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1790?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432223#comment-16432223
 ] 

ASF GitHub Bot commented on ARTEMIS-1790:
-

Github user stanlyDoge commented on a diff in the pull request:

https://github.com/apache/activemq-artemis/pull/1999#discussion_r180413588
  
--- Diff: 
artemis-core-client/src/main/java/org/apache/activemq/artemis/core/remoting/impl/netty/NettyConnection.java
 ---
@@ -511,6 +511,45 @@ public final boolean isUsingProtocolHandling() {
   return true;
}
 
+   @Override
+   public boolean isSameTarget(TransportConfiguration... configs) {
+  boolean yes = false;
--- End diff --

hehehe


> Improve Topology Member Finding
> ---
>
> Key: ARTEMIS-1790
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1790
> Project: ActiveMQ Artemis
>  Issue Type: Improvement
>  Components: Broker
>Affects Versions: 2.5.0
>Reporter: Howard Gao
>Assignee: Howard Gao
>Priority: Major
> Fix For: 2.5.1
>
>
> When finding out if a connector belong to a target node it compares the whole 
> parameter map which is not necessary. Also in understanding the connector the 
> best place is to delegate it to the corresponding remoting connection who 
> understands it. (e.g. INVMConnection knows whether the connector belongs to a 
> target node by checking it's serverID only. The netty ones only need to match 
> host and port, and understanding that localhost and 127.0.0.1 are same thing).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1798) DEBUG message bad write method arg count: public void org.apache.activemq.artemis.core.protocol.openwire.OpenWireProtocolManager.setUpInactivityParams

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16432218#comment-16432218
 ] 

ASF GitHub Bot commented on ARTEMIS-1798:
-

GitHub user stanlyDoge opened a pull request:

https://github.com/apache/activemq-artemis/pull/2006

ARTEMIS-1798 DEBUG message bad write method arg count - fix

When the logging level was set up to DEBUG, 
FluentPropertyBeanIntrospectorWithIgnores threw an exception at 
org.apache.activemq.artemis.core.protocol.openwire.OpenWireProtocolManager#setUpInactivityParams
 because it was not really setting up any property. I have added this method to 
FluentPropertyBeanIntrospectorWithIgnores's ignored method, which means this 
method is not checked anymore. That causes there is not error message in DEBUG 
output any longer.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/stanlyDoge/activemq-artemis E638

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/2006.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2006


commit 7f3962c0776fcfdda9c1dab2cc5260228a2edfc1
Author: Stanislav Knot 
Date:   2018-04-10T13:01:55Z

ARTEMIS-1798 DEBUG message bad write method arg count - fix




> DEBUG message bad write method arg count: public void 
> org.apache.activemq.artemis.core.protocol.openwire.OpenWireProtocolManager.setUpInactivityParams
> --
>
> Key: ARTEMIS-1798
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1798
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>Reporter: Stanislav Knot
>Assignee: Stanislav Knot
>Priority: Trivial
>
> {noformat}
> 16:06:31,002 DEBUG 
> [org.apache.activemq.artemis.utils.uri.FluentPropertyBeanIntrospectorWithIgnores]
>  bad write method arg count: public void 
> org.apache.activemq.artemis.core.protocol.openwire.OpenWireProtocolManager.setUpInactivityParams(org.apache.activemq.artemis.core.protocol.openwire.OpenWireConnection,org.apache.activemq.command.WireFormatInfo)
>  throws java.io.IOException: java.beans.IntrospectionException: bad write 
> method arg count: public void 
> org.apache.activemq.artemis.core.protocol.openwire.OpenWireProtocolManager.setUpInactivityParams(org.apache.activemq.artemis.core.protocol.openwire.OpenWireConnection,org.
> {noformat}
> setUpInactivityParams does not set property, which causes this message when 
> debug logging is enabled.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (ARTEMIS-1798) DEBUG message bad write method arg count: public void org.apache.activemq.artemis.core.protocol.openwire.OpenWireProtocolManager.setUpInactivityParams

[Stanislav Knot (JIRA)]

Stanislav Knot created ARTEMIS-1798:
---

 Summary: DEBUG message bad write method arg count: public void 
org.apache.activemq.artemis.core.protocol.openwire.OpenWireProtocolManager.setUpInactivityParams
 Key: ARTEMIS-1798
 URL: https://issues.apache.org/jira/browse/ARTEMIS-1798
 Project: ActiveMQ Artemis
  Issue Type: Bug
Reporter: Stanislav Knot
Assignee: Stanislav Knot


{noformat}

16:06:31,002 DEBUG 
[org.apache.activemq.artemis.utils.uri.FluentPropertyBeanIntrospectorWithIgnores]
 bad write method arg count: public void 
org.apache.activemq.artemis.core.protocol.openwire.OpenWireProtocolManager.setUpInactivityParams(org.apache.activemq.artemis.core.protocol.openwire.OpenWireConnection,org.apache.activemq.command.WireFormatInfo)
 throws java.io.IOException: java.beans.IntrospectionException: bad write 
method arg count: public void 
org.apache.activemq.artemis.core.protocol.openwire.OpenWireProtocolManager.setUpInactivityParams(org.apache.activemq.artemis.core.protocol.openwire.OpenWireConnection,org.

{noformat}

setUpInactivityParams does not set property, which causes this message when 
debug logging is enabled.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (AMQ-6946) PeerBrokers contains raw URI from transportConnector

[Martin Theiss (JIRA)]

Martin Theiss created AMQ-6946:
--

 Summary: PeerBrokers contains raw URI from transportConnector
 Key: AMQ-6946
 URL: https://issues.apache.org/jira/browse/AMQ-6946
 Project: ActiveMQ
  Issue Type: Bug
  Components: Broker, Connector
Affects Versions: 5.15.3
Reporter: Martin Theiss


When two transportConnectors are configured and one has updateClusterClients or 
rebalanceClusterClients enabled, a client connecting to the transportConnector 
will not work reliable.

In org.apache.activemq.broker.BrokerService.getDefaultSocketURIString(), it 
loops over all transportConnectors and deteremines the defaultSocketURI. This 
is used, when no peer has joined the cluster.

Depending on the order of the transportConnectors, this results in a peer with 
0.0.0.0 being declared. This is due to the second connector not being started 
at the point where defaultSocketURI is needed.

Working:
{code:java}
    
    
{code}

NOT working:
{code}


{code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Commented] (ARTEMIS-1797) Auto-create-address flag shouldn't block temp destination creation

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/ARTEMIS-1797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16431864#comment-16431864
 ] 

ASF GitHub Bot commented on ARTEMIS-1797:
-

GitHub user gaohoward opened a pull request:

https://github.com/apache/activemq-artemis/pull/2005

ARTEMIS-1797 Auto-create-address flag shouldn't block temp destination 
creation



When creating a temp destination and auto-create-address set to false, the
broker throws an error and refuse to create it. This doesn't conform to
normal use-case (like amqp dynamic flag) where the temp destination should
be allowed even if the auto-create-address is false.

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/gaohoward/activemq-artemis g_1158

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/activemq-artemis/pull/2005.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #2005


commit 39a4e04aa11f22e672f4fe6f8ce87c436f9ddc8f
Author: Howard Gao 
Date:   2018-04-10T07:26:27Z

ARTEMIS-1797 Auto-create-address flag shouldn't block temp destination 
creation

When creating a temp destination and auto-create-address set to false, the
broker throws an error and refuse to create it. This doesn't conform to
normal use-case (like amqp dynamic flag) where the temp destination should
be allowed even if the auto-create-address is false.




> Auto-create-address flag shouldn't block temp destination creation
> --
>
> Key: ARTEMIS-1797
> URL: https://issues.apache.org/jira/browse/ARTEMIS-1797
> Project: ActiveMQ Artemis
>  Issue Type: Bug
>  Components: Broker
>Affects Versions: 2.5.0
>Reporter: Howard Gao
>Assignee: Howard Gao
>Priority: Major
> Fix For: 2.5.1
>
>
> When creating a temp destination and auto-create-address set to false, the 
> broker throws an error and refuse to create it. This doesn't conform to 
> normal use-case (like amqp dynamic flag) where the temp destination should be 
> allowed even if the auto-create-address is false.
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

[jira] [Created] (ARTEMIS-1797) Auto-create-address flag shouldn't block temp destination creation

[Howard Gao (JIRA)]

Howard Gao created ARTEMIS-1797:
---

 Summary: Auto-create-address flag shouldn't block temp destination 
creation
 Key: ARTEMIS-1797
 URL: https://issues.apache.org/jira/browse/ARTEMIS-1797
 Project: ActiveMQ Artemis
  Issue Type: Bug
  Components: Broker
Affects Versions: 2.5.0
Reporter: Howard Gao
Assignee: Howard Gao
 Fix For: 2.5.1


When creating a temp destination and auto-create-address set to false, the 
broker throws an error and refuse to create it. This doesn't conform to normal 
use-case (like amqp dynamic flag) where the temp destination should be allowed 
even if the auto-create-address is false.

 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)