[jira] [Work logged] (ARTEMIS-2452) group-name ignored in shared store colocated setup
[ https://issues.apache.org/jira/browse/ARTEMIS-2452?focusedWorklogId=647205&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-647205 ] ASF GitHub Bot logged work on ARTEMIS-2452: --- Author: ASF GitHub Bot Created on: 07/Sep/21 07:22 Start Date: 07/Sep/21 07:22 Worklog Time Spent: 10m Work Description: franz1981 closed pull request #2793: URL: https://github.com/apache/activemq-artemis/pull/2793 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 647205) Time Spent: 4.5h (was: 4h 20m) > group-name ignored in shared store colocated setup > -- > > Key: ARTEMIS-2452 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2452 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.9.0 >Reporter: Francesco Nigro >Priority: Major > Time Spent: 4.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2452) group-name ignored in shared store colocated setup
[ https://issues.apache.org/jira/browse/ARTEMIS-2452?focusedWorklogId=647206&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-647206 ] ASF GitHub Bot logged work on ARTEMIS-2452: --- Author: ASF GitHub Bot Created on: 07/Sep/21 07:22 Start Date: 07/Sep/21 07:22 Worklog Time Spent: 10m Work Description: franz1981 commented on pull request #2793: URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-914056875 Closing this because inactive from long time -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: gitbox-unsubscr...@activemq.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 647206) Time Spent: 4h 40m (was: 4.5h) > group-name ignored in shared store colocated setup > -- > > Key: ARTEMIS-2452 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2452 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.9.0 >Reporter: Francesco Nigro >Priority: Major > Time Spent: 4h 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.4#803005)
[jira] [Work logged] (ARTEMIS-2452) group-name ignored in shared store colocated setup
[ https://issues.apache.org/jira/browse/ARTEMIS-2452?focusedWorklogId=304254&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-304254 ] ASF GitHub Bot logged work on ARTEMIS-2452: --- Author: ASF GitHub Bot Created on: 30/Aug/19 13:28 Start Date: 30/Aug/19 13:28 Worklog Time Spent: 10m Work Description: clebertsuconic commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-526601719 @michaelandrepearce I'm marking as DO-NOT-MERGE-YET... it helps me to not mess up. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 304254) Time Spent: 4h 20m (was: 4h 10m) > group-name ignored in shared store colocated setup > -- > > Key: ARTEMIS-2452 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2452 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.9.0 >Reporter: Francesco Nigro >Priority: Major > Time Spent: 4h 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (ARTEMIS-2452) group-name ignored in shared store colocated setup
[ https://issues.apache.org/jira/browse/ARTEMIS-2452?focusedWorklogId=300342&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-300342 ] ASF GitHub Bot logged work on ARTEMIS-2452: --- Author: ASF GitHub Bot Created on: 23/Aug/19 15:51 Start Date: 23/Aug/19 15:51 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-524365392 @clebertsuconic its not ready for merge anyhow. Waiting on @franz1981 atm This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 300342) Time Spent: 4h 10m (was: 4h) > group-name ignored in shared store colocated setup > -- > > Key: ARTEMIS-2452 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2452 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.9.0 >Reporter: Francesco Nigro >Priority: Major > Time Spent: 4h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (ARTEMIS-2452) group-name ignored in shared store colocated setup
[ https://issues.apache.org/jira/browse/ARTEMIS-2452?focusedWorklogId=300339&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-300339 ] ASF GitHub Bot logged work on ARTEMIS-2452: --- Author: ASF GitHub Bot Created on: 23/Aug/19 15:47 Start Date: 23/Aug/19 15:47 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-524365392 @clebertsuconic its not ready for merge anhow This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 300339) Time Spent: 4h (was: 3h 50m) > group-name ignored in shared store colocated setup > -- > > Key: ARTEMIS-2452 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2452 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.9.0 >Reporter: Francesco Nigro >Priority: Major > Time Spent: 4h > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (ARTEMIS-2452) group-name ignored in shared store colocated setup
[ https://issues.apache.org/jira/browse/ARTEMIS-2452?focusedWorklogId=299113&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-299113 ] ASF GitHub Bot logged work on ARTEMIS-2452: --- Author: ASF GitHub Bot Created on: 22/Aug/19 02:05 Start Date: 22/Aug/19 02:05 Worklog Time Spent: 10m Work Description: clebertsuconic commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-523716552 can you rebase this? it will trigger a new build after fixed. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 299113) Time Spent: 3h 50m (was: 3h 40m) > group-name ignored in shared store colocated setup > -- > > Key: ARTEMIS-2452 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2452 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.9.0 >Reporter: Francesco Nigro >Priority: Major > Time Spent: 3h 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.3.2#803003)
[jira] [Work logged] (ARTEMIS-2452) group-name ignored in shared store colocated setup
[ https://issues.apache.org/jira/browse/ARTEMIS-2452?focusedWorklogId=295306&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-295306 ] ASF GitHub Bot logged work on ARTEMIS-2452: --- Author: ASF GitHub Bot Created on: 15/Aug/19 08:39 Start Date: 15/Aug/19 08:39 Worklog Time Spent: 10m Work Description: franz1981 commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-521563027 Yes, sure and will provide proper yes and coverage too as it deserves :) Thanks for the suggestions Michael!! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 295306) Time Spent: 3.5h (was: 3h 20m) > group-name ignored in shared store colocated setup > -- > > Key: ARTEMIS-2452 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2452 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.9.0 >Reporter: Francesco Nigro >Priority: Major > Time Spent: 3.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (ARTEMIS-2452) group-name ignored in shared store colocated setup
[ https://issues.apache.org/jira/browse/ARTEMIS-2452?focusedWorklogId=295309&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-295309 ] ASF GitHub Bot logged work on ARTEMIS-2452: --- Author: ASF GitHub Bot Created on: 15/Aug/19 08:39 Start Date: 15/Aug/19 08:39 Worklog Time Spent: 10m Work Description: franz1981 commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-521563027 Yes, sure and will provide proper test coverage too as it deserves :) Thanks for the suggestions Michael!! This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 295309) Time Spent: 3h 40m (was: 3.5h) > group-name ignored in shared store colocated setup > -- > > Key: ARTEMIS-2452 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2452 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.9.0 >Reporter: Francesco Nigro >Priority: Major > Time Spent: 3h 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (ARTEMIS-2452) group-name ignored in shared store colocated setup
[ https://issues.apache.org/jira/browse/ARTEMIS-2452?focusedWorklogId=295300&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-295300 ] ASF GitHub Bot logged work on ARTEMIS-2452: --- Author: ASF GitHub Bot Created on: 15/Aug/19 08:30 Start Date: 15/Aug/19 08:30 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-521560596 @franz1981 i assume you're going to have a think on this and re-work bits? e.g. no further comments needed for now right? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 295300) Time Spent: 3h 20m (was: 3h 10m) > group-name ignored in shared store colocated setup > -- > > Key: ARTEMIS-2452 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2452 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.9.0 >Reporter: Francesco Nigro >Priority: Major > Time Spent: 3h 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (ARTEMIS-2452) group-name ignored in shared store colocated setup
[ https://issues.apache.org/jira/browse/ARTEMIS-2452?focusedWorklogId=295297&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-295297 ] ASF GitHub Bot logged work on ARTEMIS-2452: --- Author: ASF GitHub Bot Created on: 15/Aug/19 08:24 Start Date: 15/Aug/19 08:24 Worklog Time Spent: 10m Work Description: franz1981 commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-521559226 I understand your comment now, my comment was related to the code itself,not the feature as a whole: I see that there exists cases where it can work.. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 295297) Time Spent: 3h 10m (was: 3h) > group-name ignored in shared store colocated setup > -- > > Key: ARTEMIS-2452 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2452 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.9.0 >Reporter: Francesco Nigro >Priority: Major > Time Spent: 3h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (ARTEMIS-2452) group-name ignored in shared store colocated setup
[ https://issues.apache.org/jira/browse/ARTEMIS-2452?focusedWorklogId=295293&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-295293 ] ASF GitHub Bot logged work on ARTEMIS-2452: --- Author: ASF GitHub Bot Created on: 15/Aug/19 08:19 Start Date: 15/Aug/19 08:19 Worklog Time Spent: 10m Work Description: franz1981 commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-521557724 The feature of shared store colocated is not totally broken, but the shared store colocation using group names, yes. But is normal, if the were not using at all group names in their logic I believe that's ok.. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 295293) Time Spent: 3h (was: 2h 50m) > group-name ignored in shared store colocated setup > -- > > Key: ARTEMIS-2452 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2452 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.9.0 >Reporter: Francesco Nigro >Priority: Major > Time Spent: 3h > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (ARTEMIS-2452) group-name ignored in shared store colocated setup
[
https://issues.apache.org/jira/browse/ARTEMIS-2452?focusedWorklogId=295291&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-295291
]
ASF GitHub Bot logged work on ARTEMIS-2452:
---
Author: ASF GitHub Bot
Created on: 15/Aug/19 08:17
Start Date: 15/Aug/19 08:17
Worklog Time Spent: 10m
Work Description: franz1981 commented on pull request #2793: ARTEMIS-2452
group-name ignored in shared store colocated setup
URL: https://github.com/apache/activemq-artemis/pull/2793#discussion_r314213953
##
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/ha/ColocatedHAManager.java
##
@@ -163,6 +174,23 @@ private synchronized boolean
activateSharedStoreBackup(String journalDirectory,
return true;
}
+ private TopologyMember validateBackupGroupName(SimpleString nodeID) {
+ // Older versions of artemis don't send the nodeID in
BackupRequestMessage:
+ // in this case we cannot trust the request, making the requesting server
Review comment:
It was working fine because you haven't had any other member of topology
with a group name and been lucky, I believe :P
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 295291)
Time Spent: 2h 50m (was: 2h 40m)
> group-name ignored in shared store colocated setup
> --
>
> Key: ARTEMIS-2452
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2452
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Affects Versions: 2.9.0
>Reporter: Francesco Nigro
>Priority: Major
> Time Spent: 2h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Work logged] (ARTEMIS-2452) group-name ignored in shared store colocated setup
[ https://issues.apache.org/jira/browse/ARTEMIS-2452?focusedWorklogId=295290&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-295290 ] ASF GitHub Bot logged work on ARTEMIS-2452: --- Author: ASF GitHub Bot Created on: 15/Aug/19 08:17 Start Date: 15/Aug/19 08:17 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-521556891 Well it can't be totally broken, theres users out there using it (mostly because they are forming single groups or ensuring clusters are rign fenced, therefor group name isnt really mandatory there, yes theres a bug if you need multiple, and thats not ideal, but its not totally broken as you say, This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 295290) Time Spent: 2h 40m (was: 2.5h) > group-name ignored in shared store colocated setup > -- > > Key: ARTEMIS-2452 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2452 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.9.0 >Reporter: Francesco Nigro >Priority: Major > Time Spent: 2h 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (ARTEMIS-2452) group-name ignored in shared store colocated setup
[ https://issues.apache.org/jira/browse/ARTEMIS-2452?focusedWorklogId=295289&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-295289 ] ASF GitHub Bot logged work on ARTEMIS-2452: --- Author: ASF GitHub Bot Created on: 15/Aug/19 08:16 Start Date: 15/Aug/19 08:16 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-521556891 Well it can't be totally broken, theres users out there using it (mostly because they are forming single groups or ensuring clusters are rign fenced), yes theres a bug thats not ideal. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 295289) Time Spent: 2.5h (was: 2h 20m) > group-name ignored in shared store colocated setup > -- > > Key: ARTEMIS-2452 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2452 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.9.0 >Reporter: Francesco Nigro >Priority: Major > Time Spent: 2.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (ARTEMIS-2452) group-name ignored in shared store colocated setup
[ https://issues.apache.org/jira/browse/ARTEMIS-2452?focusedWorklogId=295287&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-295287 ] ASF GitHub Bot logged work on ARTEMIS-2452: --- Author: ASF GitHub Bot Created on: 15/Aug/19 08:14 Start Date: 15/Aug/19 08:14 Worklog Time Spent: 10m Work Description: franz1981 commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-521556443 The version proposal is probably the best solution indeed: the reason why the old logic breaks the new one is that the old one just ignored the group names and let any requesting server that arrive first to be able to form a pair on any group name regardless both the requesting server group name and the target server. It was just totally broken... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 295287) Time Spent: 2h 10m (was: 2h) > group-name ignored in shared store colocated setup > -- > > Key: ARTEMIS-2452 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2452 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.9.0 >Reporter: Francesco Nigro >Priority: Major > Time Spent: 2h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (ARTEMIS-2452) group-name ignored in shared store colocated setup
[ https://issues.apache.org/jira/browse/ARTEMIS-2452?focusedWorklogId=295288&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-295288 ] ASF GitHub Bot logged work on ARTEMIS-2452: --- Author: ASF GitHub Bot Created on: 15/Aug/19 08:14 Start Date: 15/Aug/19 08:14 Worklog Time Spent: 10m Work Description: franz1981 commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-521556443 The version proposal is probably the best solution indeed: the reason why the old logic breaks the new one is that the old one just ignores the group names and let any requesting server that arrive first to be able to form a pair on any group name regardless both the requesting server group name and the target server. It was just totally broken... This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 295288) Time Spent: 2h 20m (was: 2h 10m) > group-name ignored in shared store colocated setup > -- > > Key: ARTEMIS-2452 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2452 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.9.0 >Reporter: Francesco Nigro >Priority: Major > Time Spent: 2h 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (ARTEMIS-2452) group-name ignored in shared store colocated setup
[
https://issues.apache.org/jira/browse/ARTEMIS-2452?focusedWorklogId=295285&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-295285
]
ASF GitHub Bot logged work on ARTEMIS-2452:
---
Author: ASF GitHub Bot
Created on: 15/Aug/19 08:13
Start Date: 15/Aug/19 08:13
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on pull request #2793:
ARTEMIS-2452 group-name ignored in shared store colocated setup
URL: https://github.com/apache/activemq-artemis/pull/2793#discussion_r314212795
##
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/server/cluster/ha/ColocatedHAManager.java
##
@@ -163,6 +174,23 @@ private synchronized boolean
activateSharedStoreBackup(String journalDirectory,
return true;
}
+ private TopologyMember validateBackupGroupName(SimpleString nodeID) {
+ // Older versions of artemis don't send the nodeID in
BackupRequestMessage:
+ // in this case we cannot trust the request, making the requesting server
Review comment:
Why can't we, we know we had old servers and setups working fine, as such
why be so strict, simply fail back (or even tter have a v1 and v2 version of
the message, that way if all v2 cluster you can be fully strict, else in a
v1/v2 mix you can be less strict
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 295285)
Time Spent: 2h (was: 1h 50m)
> group-name ignored in shared store colocated setup
> --
>
> Key: ARTEMIS-2452
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2452
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Affects Versions: 2.9.0
>Reporter: Francesco Nigro
>Priority: Major
> Time Spent: 2h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Work logged] (ARTEMIS-2452) group-name ignored in shared store colocated setup
[
https://issues.apache.org/jira/browse/ARTEMIS-2452?focusedWorklogId=295284&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-295284
]
ASF GitHub Bot logged work on ARTEMIS-2452:
---
Author: ASF GitHub Bot
Created on: 15/Aug/19 08:10
Start Date: 15/Aug/19 08:10
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on pull request #2793:
ARTEMIS-2452 group-name ignored in shared store colocated setup
URL: https://github.com/apache/activemq-artemis/pull/2793#discussion_r314211592
##
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/BackupRequestMessage.java
##
@@ -34,12 +34,14 @@ public BackupRequestMessage() {
}
public BackupRequestMessage(int backupSize,
+ SimpleString nodeID,
String journalDirectory,
String bindingsDirectory,
String largeMessagesDirectory,
String pagingDirectory) {
super(BACKUP_REQUEST);
this.backupSize = backupSize;
+ this.nodeID = nodeID;
Review comment:
Please make a v2 version, this would be a breaking change, for anyone with
existing clusters
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 295284)
Time Spent: 1h 50m (was: 1h 40m)
> group-name ignored in shared store colocated setup
> --
>
> Key: ARTEMIS-2452
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2452
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Affects Versions: 2.9.0
>Reporter: Francesco Nigro
>Priority: Major
> Time Spent: 1h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Work logged] (ARTEMIS-2452) group-name ignored in shared store colocated setup
[
https://issues.apache.org/jira/browse/ARTEMIS-2452?focusedWorklogId=295283&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-295283
]
ASF GitHub Bot logged work on ARTEMIS-2452:
---
Author: ASF GitHub Bot
Created on: 15/Aug/19 08:09
Start Date: 15/Aug/19 08:09
Worklog Time Spent: 10m
Work Description: michaelandrepearce commented on pull request #2793:
ARTEMIS-2452 group-name ignored in shared store colocated setup
URL: https://github.com/apache/activemq-artemis/pull/2793#discussion_r314211592
##
File path:
artemis-server/src/main/java/org/apache/activemq/artemis/core/protocol/core/impl/wireformat/BackupRequestMessage.java
##
@@ -34,12 +34,14 @@ public BackupRequestMessage() {
}
public BackupRequestMessage(int backupSize,
+ SimpleString nodeID,
String journalDirectory,
String bindingsDirectory,
String largeMessagesDirectory,
String pagingDirectory) {
super(BACKUP_REQUEST);
this.backupSize = backupSize;
+ this.nodeID = nodeID;
Review comment:
Please make a v2 version, this would be a breaking change, for anyone with
existing clusters
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
---
Worklog Id: (was: 295283)
Time Spent: 1h 40m (was: 1.5h)
> group-name ignored in shared store colocated setup
> --
>
> Key: ARTEMIS-2452
> URL: https://issues.apache.org/jira/browse/ARTEMIS-2452
> Project: ActiveMQ Artemis
> Issue Type: Bug
> Components: Broker
>Affects Versions: 2.9.0
>Reporter: Francesco Nigro
>Priority: Major
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
[jira] [Work logged] (ARTEMIS-2452) group-name ignored in shared store colocated setup
[ https://issues.apache.org/jira/browse/ARTEMIS-2452?focusedWorklogId=295282&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-295282 ] ASF GitHub Bot logged work on ARTEMIS-2452: --- Author: ASF GitHub Bot Created on: 15/Aug/19 08:07 Start Date: 15/Aug/19 08:07 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-521554151 Also why would having old logic break new? Another option is to version the message, and if you get v1 do old logic, if you get new v2 message do new. Then no need even for a flag. This way in a brand new setup it will all be good, but ln an old / partially transitioned setup you get same guarentees as old, until all fully upgraded after which you're all good. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 295282) Time Spent: 1.5h (was: 1h 20m) > group-name ignored in shared store colocated setup > -- > > Key: ARTEMIS-2452 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2452 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.9.0 >Reporter: Francesco Nigro >Priority: Major > Time Spent: 1.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (ARTEMIS-2452) group-name ignored in shared store colocated setup
[ https://issues.apache.org/jira/browse/ARTEMIS-2452?focusedWorklogId=295280&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-295280 ] ASF GitHub Bot logged work on ARTEMIS-2452: --- Author: ASF GitHub Bot Created on: 15/Aug/19 08:05 Start Date: 15/Aug/19 08:05 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-521554151 Also why would having old logic break new? Another option is to version the message, and if you get v1 do old logic, if you get new v2 message do new. Then no need even for a flag. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 295280) Time Spent: 1h 20m (was: 1h 10m) > group-name ignored in shared store colocated setup > -- > > Key: ARTEMIS-2452 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2452 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.9.0 >Reporter: Francesco Nigro >Priority: Major > Time Spent: 1h 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (ARTEMIS-2452) group-name ignored in shared store colocated setup
[ https://issues.apache.org/jira/browse/ARTEMIS-2452?focusedWorklogId=295277&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-295277 ] ASF GitHub Bot logged work on ARTEMIS-2452: --- Author: ASF GitHub Bot Created on: 15/Aug/19 07:59 Start Date: 15/Aug/19 07:59 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-521552397 Why not have a setting that makes it behave as old version, then once all servers uograded the setting can change to strict..making the flag dynamic would also mean the last change can be done without need for further bounces This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 295277) Time Spent: 1h 10m (was: 1h) > group-name ignored in shared store colocated setup > -- > > Key: ARTEMIS-2452 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2452 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.9.0 >Reporter: Francesco Nigro >Priority: Major > Time Spent: 1h 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (ARTEMIS-2452) group-name ignored in shared store colocated setup
[ https://issues.apache.org/jira/browse/ARTEMIS-2452?focusedWorklogId=295275&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-295275 ] ASF GitHub Bot logged work on ARTEMIS-2452: --- Author: ASF GitHub Bot Created on: 15/Aug/19 07:58 Start Date: 15/Aug/19 07:58 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-521552397 Why not have a setting that makes it behave as old version, then once all servers uograded the setting can change to strict and then simply another round or rolling bounces. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 295275) Time Spent: 1h (was: 50m) > group-name ignored in shared store colocated setup > -- > > Key: ARTEMIS-2452 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2452 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.9.0 >Reporter: Francesco Nigro >Priority: Major > Time Spent: 1h > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (ARTEMIS-2452) group-name ignored in shared store colocated setup
[ https://issues.apache.org/jira/browse/ARTEMIS-2452?focusedWorklogId=295268&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-295268 ] ASF GitHub Bot logged work on ARTEMIS-2452: --- Author: ASF GitHub Bot Created on: 15/Aug/19 07:50 Start Date: 15/Aug/19 07:50 Worklog Time Spent: 10m Work Description: franz1981 commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-521550401 @michaelandrepearce Agree, but nonetheless my comment on the code hold: ``` // Older versions of artemis don't send the nodeID in BackupRequestMessage: // in this case we cannot trust the request, making the requesting server // to pair with this server in any case. ``` Old servers cannot be trusted, because they don't provide enough information to pair with new ones ie the colocated shared store with group name wasn't a feature correctly implemented. If I let them behave as before it can break a new cluster: atm i can't see solutions to preserve a partial cluster upgrade. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 295268) Time Spent: 50m (was: 40m) > group-name ignored in shared store colocated setup > -- > > Key: ARTEMIS-2452 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2452 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.9.0 >Reporter: Francesco Nigro >Priority: Major > Time Spent: 50m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (ARTEMIS-2452) group-name ignored in shared store colocated setup
[ https://issues.apache.org/jira/browse/ARTEMIS-2452?focusedWorklogId=295249&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-295249 ] ASF GitHub Bot logged work on ARTEMIS-2452: --- Author: ASF GitHub Bot Created on: 15/Aug/19 06:41 Start Date: 15/Aug/19 06:41 Worklog Time Spent: 10m Work Description: michaelandrepearce commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-521533815 Its important broker can be rolling upgraded, e.g. old broker instance can talk with new without issue so zero downtime upgrades can occur. I think the issue you called out must be addressed before this can merge, if it breaks that. This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 295249) Time Spent: 40m (was: 0.5h) > group-name ignored in shared store colocated setup > -- > > Key: ARTEMIS-2452 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2452 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.9.0 >Reporter: Francesco Nigro >Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (ARTEMIS-2452) group-name ignored in shared store colocated setup
[ https://issues.apache.org/jira/browse/ARTEMIS-2452?focusedWorklogId=293972&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-293972 ] ASF GitHub Bot logged work on ARTEMIS-2452: --- Author: ASF GitHub Bot Created on: 13/Aug/19 15:42 Start Date: 13/Aug/19 15:42 Worklog Time Spent: 10m Work Description: franz1981 commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-520889867 @howardgao @jbertram wdyt? This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 293972) Time Spent: 0.5h (was: 20m) > group-name ignored in shared store colocated setup > -- > > Key: ARTEMIS-2452 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2452 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.9.0 >Reporter: Francesco Nigro >Priority: Major > Time Spent: 0.5h > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (ARTEMIS-2452) group-name ignored in shared store colocated setup
[ https://issues.apache.org/jira/browse/ARTEMIS-2452?focusedWorklogId=293969&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-293969 ] ASF GitHub Bot logged work on ARTEMIS-2452: --- Author: ASF GitHub Bot Created on: 13/Aug/19 15:38 Start Date: 13/Aug/19 15:38 Worklog Time Spent: 10m Work Description: franz1981 commented on issue #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup URL: https://github.com/apache/activemq-artemis/pull/2793#issuecomment-520888383 This PR is adding `BackupRequestMessage`'s `nodeID` information for shared store colocated setup, to enable proper validation of backup group names: I don't know yet how to handle the case where old brokers are communicating with new ones, but throwing an exception + logging a warn message. I'm opened to other approaches ;) I will add some tests on my PTO return, but I've left this here to make it available for comment/reviewes :) This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 293969) Time Spent: 20m (was: 10m) > group-name ignored in shared store colocated setup > -- > > Key: ARTEMIS-2452 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2452 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.9.0 >Reporter: Francesco Nigro >Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
[jira] [Work logged] (ARTEMIS-2452) group-name ignored in shared store colocated setup
[ https://issues.apache.org/jira/browse/ARTEMIS-2452?focusedWorklogId=293964&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-293964 ] ASF GitHub Bot logged work on ARTEMIS-2452: --- Author: ASF GitHub Bot Created on: 13/Aug/19 15:34 Start Date: 13/Aug/19 15:34 Worklog Time Spent: 10m Work Description: franz1981 commented on pull request #2793: ARTEMIS-2452 group-name ignored in shared store colocated setup URL: https://github.com/apache/activemq-artemis/pull/2793 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org Issue Time Tracking --- Worklog Id: (was: 293964) Time Spent: 10m Remaining Estimate: 0h > group-name ignored in shared store colocated setup > -- > > Key: ARTEMIS-2452 > URL: https://issues.apache.org/jira/browse/ARTEMIS-2452 > Project: ActiveMQ Artemis > Issue Type: Bug > Components: Broker >Affects Versions: 2.9.0 >Reporter: Francesco Nigro >Priority: Major > Time Spent: 10m > Remaining Estimate: 0h > -- This message was sent by Atlassian JIRA (v7.6.14#76016)
