[jira] [Commented] (BEAM-6770) Correct zstd-jni dependency scope to optional

2019-03-08 Thread Jeff Klukas (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-6770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16788159#comment-16788159 ] Jeff Klukas commented on BEAM-6770: --- I plan to pick up this issue, but note I will be out of office next

[jira] [Commented] (BEAM-6770) Correct zstd-jni dependency scope to optional

2019-03-06 Thread Michael Luckey (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-6770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785823#comment-16785823 ] Michael Luckey commented on BEAM-6770: -- Sure you could also add an explicit configuration. And do an

[jira] [Commented] (BEAM-6770) Correct zstd-jni dependency scope to optional

2019-03-06 Thread Romain Manni-Bucau (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-6770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785805#comment-16785805 ] Romain Manni-Bucau commented on BEAM-6770: -- with gradle you can always create the configuration

[jira] [Commented] (BEAM-6770) Correct zstd-jni dependency scope to optional

2019-03-06 Thread JIRA
[ https://issues.apache.org/jira/browse/BEAM-6770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785798#comment-16785798 ] Ismaël Mejía commented on BEAM-6770: Yes it makes sense, if gradle does not suport optinal

[jira] [Commented] (BEAM-6770) Correct zstd-jni dependency scope to optional

2019-03-06 Thread Jeff Klukas (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-6770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785789#comment-16785789 ] Jeff Klukas commented on BEAM-6770: --- Correct that the dependency is not required to compile. The class

[jira] [Commented] (BEAM-6770) Correct zstd-jni dependency scope to optional

2019-03-06 Thread Michael Luckey (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-6770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785769#comment-16785769 ] Michael Luckey commented on BEAM-6770: -- [~jeff.klu...@gmail.com] To put it into test runtime,

[jira] [Commented] (BEAM-6770) Correct zstd-jni dependency scope to optional

2019-03-06 Thread Jeff Klukas (JIRA)
[ https://issues.apache.org/jira/browse/BEAM-6770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785679#comment-16785679 ] Jeff Klukas commented on BEAM-6770: --- We did have some discussion in the PR about how the dependency

[jira] [Commented] (BEAM-6770) Correct zstd-jni dependency scope to optional

2019-03-06 Thread JIRA
[ https://issues.apache.org/jira/browse/BEAM-6770?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16785631#comment-16785631 ] Ismaël Mejía commented on BEAM-6770: It seems there is a mistake in the scope of the dependency, it