[GitHub] infodog commented on issue #1509: solve #1476 issue.

infodog commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396834367 @sijie Ok thanks very much for the explanation, I already merged to my branch. This is an autom

[GitHub] sijie commented on issue #1514: Clean up javadoc mojos execution

sijie commented on issue #1514: Clean up javadoc mojos execution URL: https://github.com/apache/bookkeeper/issues/1514#issuecomment-396823325 what is your environment and command? I never see this on CI or my local runs. This

[GitHub] sijie commented on issue #1509: solve #1476 issue.

sijie commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396823110 @infodog if the comments make sense to you, it would be great if you can merge infodog/bookkeeper#1 to your branch, so it can be showed up here. then we can merge

[GitHub] sijie commented on issue #1509: solve #1476 issue.

sijie commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396822795 @infodog good questions, comments inline. > Will this case cause problem to the application using dl as a replication service? This will not cause any

[GitHub] eolivelli opened a new issue #1514: Clean up javadoc mojos execution

eolivelli opened a new issue #1514: Clean up javadoc mojos execution URL: https://github.com/apache/bookkeeper/issues/1514 **BUG REPORT** 1. Please describe the issue you observed: - What did you do? run "mvn clean install -DskipTests" on current master - What did

[GitHub] infodog commented on issue #1509: solve #1476 issue.

infodog commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396810024 @sijie I still have questions, 1. Although the fix will solve the object recycle problem, but the response with valid data is ignored. Will this case caus

[GitHub] infodog commented on issue #1509: solve #1476 issue.

infodog commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396810024 @sijie I still have questions, 1. Although the fix will solve the object recycle problem, but the response with valid data is ignored. Will this case caus

[GitHub] sijie commented on issue #1504: Issue #1489: Better Prevent Read Outliers during short-term Bookie Slow-Down

sijie commented on issue #1504: Issue #1489: Better Prevent Read Outliers during short-term Bookie Slow-Down URL: https://github.com/apache/bookkeeper/pull/1504#issuecomment-396794131 run bookkeeper-server bookie tests run bookkeeper-server tls tests run integration tests ---

[GitHub] sijie closed issue #1490: BookieJournalForceTest is flaky

sijie closed issue #1490: BookieJournalForceTest is flaky URL: https://github.com/apache/bookkeeper/issues/1490 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use

[GitHub] sijie closed pull request #1512: Issue 1490: BookieJournalForceTest is flaky

sijie closed pull request #1512: Issue 1490: BookieJournalForceTest is flaky URL: https://github.com/apache/bookkeeper/pull/1512 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign

[GitHub] sijie commented on issue #1425: [dlog] Add smoke tests for dlog library

sijie commented on issue #1425: [dlog] Add smoke tests for dlog library URL: https://github.com/apache/bookkeeper/pull/1425#issuecomment-396789469 will resend the PR to get a clean list of CI jobs. This is an automated message

[GitHub] sijie closed pull request #1425: [dlog] Add smoke tests for dlog library

sijie closed pull request #1425: [dlog] Add smoke tests for dlog library URL: https://github.com/apache/bookkeeper/pull/1425 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pul

[GitHub] sijie opened a new pull request #1425: [dlog] Add smoke tests for dlog library

sijie opened a new pull request #1425: [dlog] Add smoke tests for dlog library URL: https://github.com/apache/bookkeeper/pull/1425 Descriptions of the changes in this PR: This PR adds smoke tests for dlog library to cover basic functionalities like basic write/read, control-w

[GitHub] reddycharan commented on issue #1496: ISSUE #1495: Option to enforce minNumRacksPerWriteQuorum

reddycharan commented on issue #1496: ISSUE #1495: Option to enforce minNumRacksPerWriteQuorum URL: https://github.com/apache/bookkeeper/pull/1496#issuecomment-396783971 @sijie and @jvrao created formal PR. FYI This is an au

[GitHub] sijie commented on issue #1512: Issue 1490: BookieJournalForceTest is flaky

sijie commented on issue #1512: Issue 1490: BookieJournalForceTest is flaky URL: https://github.com/apache/bookkeeper/pull/1512#issuecomment-396747438 run bookkeeper-server bookie tests This is an automated message from the Ap

[GitHub] sijie opened a new issue #1513: bookkeeper should handle ipv6 ip address

sijie opened a new issue #1513: bookkeeper should handle ipv6 ip address URL: https://github.com/apache/bookkeeper/issues/1513 *Problem* Currently bookie doesn't handle ipv6 ip address very well. when a bookie advertises itself, it might put an ipv6 address with bookie port, the ipA

[GitHub] eolivelli closed pull request #1508: ISSUE-1490 BookieJournalForceTest is flaky

eolivelli closed pull request #1508: ISSUE-1490 BookieJournalForceTest is flaky URL: https://github.com/apache/bookkeeper/pull/1508 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a fore

[GitHub] sijie commented on issue #1512: Issue 1490: BookieJournalForceTest is flaky

sijie commented on issue #1512: Issue 1490: BookieJournalForceTest is flaky URL: https://github.com/apache/bookkeeper/pull/1512#issuecomment-396713650 run bookkeeper-server bookie tests This is an automated message from the Ap

[GitHub] sijie commented on issue #1512: Issue 1490: BookieJournalForceTest is flaky

sijie commented on issue #1512: Issue 1490: BookieJournalForceTest is flaky URL: https://github.com/apache/bookkeeper/pull/1512#issuecomment-396713915 run bookkeeper-server bookie tests This is an automated message from the Ap

[GitHub] sijie commented on issue #1512: Issue 1490: BookieJournalForceTest is flaky

sijie commented on issue #1512: Issue 1490: BookieJournalForceTest is flaky URL: https://github.com/apache/bookkeeper/pull/1512#issuecomment-396713399 run bookkeeper-server bookie tests // ` Failed to fetch from https://github.com/apache/bookkeeper.git`

[GitHub] sijie commented on issue #1512: Issue 1490: BookieJournalForceTest is flaky

sijie commented on issue #1512: Issue 1490: BookieJournalForceTest is flaky URL: https://github.com/apache/bookkeeper/pull/1512#issuecomment-396713650 run bookkeeper-server bookie tests This is an automated message from the Ap

[GitHub] sijie commented on issue #1512: Issue 1490: BookieJournalForceTest is flaky

sijie commented on issue #1512: Issue 1490: BookieJournalForceTest is flaky URL: https://github.com/apache/bookkeeper/pull/1512#issuecomment-396713399 run bookkeeper-server bookie tests // ` Failed to fetch from https://github.com/apache/bookkeeper.git`

[GitHub] sijie commented on issue #1512: Issue 1490: BookieJournalForceTest is flaky

sijie commented on issue #1512: Issue 1490: BookieJournalForceTest is flaky URL: https://github.com/apache/bookkeeper/pull/1512#issuecomment-396713399 rerun bookkeeper-server bookie tests // ` Failed to fetch from https://github.com/apache/bookkeeper.git` --

[GitHub] sijie commented on issue #1508: ISSUE-1490 BookieJournalForceTest is flaky

sijie commented on issue #1508: ISSUE-1490 BookieJournalForceTest is flaky URL: https://github.com/apache/bookkeeper/pull/1508#issuecomment-396701575 @eolivelli - I sent a separate PR for resolving this issue - #1512 I think the problem is `adaptiveGroupWrite`, which will insert a mar

[GitHub] sijie opened a new pull request #1512: Issue 1490: BookieJournalForceTest is flaky

sijie opened a new pull request #1512: Issue 1490: BookieJournalForceTest is flaky URL: https://github.com/apache/bookkeeper/pull/1512 Descriptions of the changes in this PR: ### Motivation The test cases in BookieJournalForceTest check if the forceWriteQueue is empty aft

[GitHub] sijie commented on issue #1509: solve #1476 issue.

sijie commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396685295 @infodog I've updated infodog/bookkeeper#1 with your original fix and updated the unit test to add validations to make sure recycled entry will not be mutated by a

[GitHub] sijie commented on issue #1509: solve #1476 issue.

sijie commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396677799 @infodog you are correct! I will revert infodog/bookkeeper#1 to your original fix, I will update the unit test to ensure verify the case your described. -

Build failed in Jenkins: bookkeeper_postcommit_master_java9 #167

See Changes: [sijie] Issue #1500: PendingReadOp.logErrorAndReattemptRead logs errors with [sijie] [TABLE SERVICE] Fix StringUtf8Coder and add VarIntCoder [sijie] [TABLE SERVICE] replaying TxnRe

[GitHub] infodog commented on issue #1509: solve #1476 issue.

infodog commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396580056 @sijie it's possible that compleRequest() come before request.complte(), such as https://github.com/apache/bookkeeper/blob/master/bookkeeper-server/src/main/jav

[GitHub] infodog commented on issue #1509: solve #1476 issue.

infodog commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396580056 @sijie it's possible that compleRequest() come before request.complte(), such as thehttps://github.com/apache/bookkeeper/blob/master/bookkeeper-server/src/main/

[GitHub] infodog commented on issue #1509: solve #1476 issue.

infodog commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396580056 @sijie it's possible that compleRequest() come before request.complte(), such as https://github.com/apache/bookkeeper/blob/master/bookkeeper-server/src/main/jav

[GitHub] infodog commented on issue #1509: solve #1476 issue.

infodog commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396580056 @sijie sometimes compleRequest() come before request.complte(), such as the path on https://github.com/apache/bookkeeper/blob/master/bookkeeper-server/src/main/j

[GitHub] infodog commented on issue #1509: solve #1476 issue.

infodog commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396580056 @sijie but some times compleRequest() come before request.complte(), such as the path on https://github.com/apache/bookkeeper/blob/master/bookkeeper-server/src/m

[GitHub] infodog commented on issue #1509: solve #1476 issue.

infodog commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396580056 @sijie but some times compleRequest() come before request.complte(), such as the path on https://github.com/apache/bookkeeper/blob/master/bookkeeper-server/src/m

[GitHub] infodog commented on issue #1509: solve #1476 issue.

infodog commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396580056 @sijie but some times compleRequest() come before request.complte, such as the path on https://github.com/apache/bookkeeper/blob/master/bookkeeper-server/src/mai

[GitHub] infodog commented on issue #1509: solve #1476 issue.

infodog commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396580056 @sijie but some times compleRequest() come before request.complte(), such as the path on https://github.com/apache/bookkeeper/blob/master/bookkeeper-server/src/m

Jenkins build became unstable: bookkeeper_postcommit_validation_master #14

See

[GitHub] infodog commented on issue #1509: solve #1476 issue.

infodog commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396580056 @sijie but some times requestComplete come before request.complte, such as the path on https://github.com/apache/bookkeeper/blob/master/bookkeeper-server/src/mai

[GitHub] infodog commented on issue #1509: solve #1476 issue.

infodog commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396580056 @sijie but some times requestComplete come before request.complte, such as the path on https://github.com/apache/bookkeeper/blob/master/bookkeeper-server/src/mai

[GitHub] infodog commented on issue #1509: solve #1476 issue.

infodog commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396580056 @sijie but some times requestComplete come before request.complte, such as the path on https://github.com/apache/bookkeeper/blob/master/bookkeeper-server/src/mai

[GitHub] eolivelli commented on issue #1436: BP-14 force() API - client side implementation

eolivelli commented on issue #1436: BP-14 force() API - client side implementation URL: https://github.com/apache/bookkeeper/pull/1436#issuecomment-396571250 I meant @jvrao suggested to error our pending adds. I think we do not need to do so. I will remove that from the patch, but

[GitHub] sijie commented on issue #1509: solve #1476 issue.

sijie commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396503864 @infodog I see your point now. let me try to explain: 1) yes. there are two flags, the `completed` flag in request is to checking if the request itself is co

[GitHub] sijie commented on issue #1509: solve #1476 issue.

sijie commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396503864 @infodog I see what your point. let me try to explain: 1) yes. there are two flags, the `completed` flag in request is to checking if the request itself is c

[GitHub] infodog commented on issue #1509: solve #1476 issue.

infodog commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396500590 @sijie but in https://github.com/apache/bookkeeper/blob/master/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/ReadLastConfirmedAndEntryOp.java#L615

[GitHub] sijie commented on issue #261: Docker image: create a tutorial dice application docker build

sijie commented on issue #261: Docker image: create a tutorial dice application docker build URL: https://github.com/apache/bookkeeper/issues/261#issuecomment-396501426 Closed this issue, since it is lacking activities and there is no need for a docker image for a tutorial. or if we do nee

[GitHub] sijie closed issue #261: Docker image: create a tutorial dice application docker build

sijie closed issue #261: Docker image: create a tutorial dice application docker build URL: https://github.com/apache/bookkeeper/issues/261 This is an automated message from the Apache Git Service. To respond to the message,

[GitHub] infodog commented on issue #1509: solve #1476 issue.

infodog commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396500590 @sijie but in https://github.com/apache/bookkeeper/blob/master/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/ReadLastConfirmedAndEntryOp.java#L615

[GitHub] sijie commented on issue #335: Docker Image: tracking sub issues

sijie commented on issue #335: Docker Image: tracking sub issues URL: https://github.com/apache/bookkeeper/issues/335#issuecomment-396501143 Closed this tracking issue since all sub-tasks are done. This is an automated message

[GitHub] sijie closed issue #335: Docker Image: tracking sub issues

sijie closed issue #335: Docker Image: tracking sub issues URL: https://github.com/apache/bookkeeper/issues/335 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use

[GitHub] sijie closed issue #289: Docker image: make docker image build based on master latest code

sijie closed issue #289: Docker image: make docker image build based on master latest code URL: https://github.com/apache/bookkeeper/issues/289 This is an automated message from the Apache Git Service. To respond to the mes

[GitHub] sijie commented on issue #289: Docker image: make docker image build based on master latest code

sijie commented on issue #289: Docker image: make docker image build based on master latest code URL: https://github.com/apache/bookkeeper/issues/289#issuecomment-396500831 This is done by current-version-image test image. So closed it.

[GitHub] infodog commented on issue #1509: solve #1476 issue.

infodog commented on issue #1509: solve #1476 issue. URL: https://github.com/apache/bookkeeper/pull/1509#issuecomment-396500590 @sijie but in https://github.com/apache/bookkeeper/blob/master/bookkeeper-server/src/main/java/org/apache/bookkeeper/client/ReadLastConfirmedAndEntryOp.java#L617

[GitHub] sijie commented on issue #733: fix getKeyName in ComponentConfiguration.

sijie commented on issue #733: fix getKeyName in ComponentConfiguration. URL: https://github.com/apache/bookkeeper/issues/733#issuecomment-396499960 I think this has been fixed in one of the table requests PRs. Closed it. This

[GitHub] sijie closed issue #733: fix getKeyName in ComponentConfiguration.

sijie closed issue #733: fix getKeyName in ComponentConfiguration. URL: https://github.com/apache/bookkeeper/issues/733 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub

[GitHub] sijie closed issue #848: Issues in Prometheus stats provider

sijie closed issue #848: Issues in Prometheus stats provider URL: https://github.com/apache/bookkeeper/issues/848 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and u

[GitHub] sijie commented on issue #848: Issues in Prometheus stats provider

sijie commented on issue #848: Issues in Prometheus stats provider URL: https://github.com/apache/bookkeeper/issues/848#issuecomment-396499505 This is addressed at #1394 This is an automated message from the Apache Git Service

[GitHub] sijie closed issue #983: Add quorum write commit latency to the new api

sijie closed issue #983: Add quorum write commit latency to the new api URL: https://github.com/apache/bookkeeper/issues/983 This is an automated message from the Apache Git Service. To respond to the message, please log on G

[GitHub] sijie commented on issue #983: Add quorum write commit latency to the new api

sijie commented on issue #983: Add quorum write commit latency to the new api URL: https://github.com/apache/bookkeeper/issues/983#issuecomment-396499085 This is implemented in #966 This is an automated message from the Apach

[GitHub] sijie closed issue #1153: Finalize the new bookkeeper CLI name

sijie closed issue #1153: Finalize the new bookkeeper CLI name URL: https://github.com/apache/bookkeeper/issues/1153 This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub an

[GitHub] sijie commented on issue #1153: Finalize the new bookkeeper CLI name

sijie commented on issue #1153: Finalize the new bookkeeper CLI name URL: https://github.com/apache/bookkeeper/issues/1153#issuecomment-396498519 It is renamed to `bkctl` in #1478 This is an automated message from the Apache G

[GitHub] sijie closed issue #1356: new bookkeeper-cli doesn't work in binary distribution

sijie closed issue #1356: new bookkeeper-cli doesn't work in binary distribution URL: https://github.com/apache/bookkeeper/issues/1356 This is an automated message from the Apache Git Service. To respond to the message, pleas

[GitHub] sijie commented on issue #1356: new bookkeeper-cli doesn't work in binary distribution

sijie commented on issue #1356: new bookkeeper-cli doesn't work in binary distribution URL: https://github.com/apache/bookkeeper/issues/1356#issuecomment-396497339 This is fixed by #1478 This is an automated message from the

[GitHub] sijie commented on issue #1356: new bookkeeper-cli doesn't work in binary distribution

sijie commented on issue #1356: new bookkeeper-cli doesn't work in binary distribution URL: https://github.com/apache/bookkeeper/issues/1356#issuecomment-396497211 this is fixed by b9b46172c4f7ac1aa2a42ff8b0fceb24ef03ed68 Thi

[GitHub] sijie commented on issue #1377: `bin/dlog` should promote user to run `mvn install` if the source is not built

sijie commented on issue #1377: `bin/dlog` should promote user to run `mvn install` if the source is not built URL: https://github.com/apache/bookkeeper/issues/1377#issuecomment-396496935 Fixed by #1407 This is an automated m

[GitHub] sijie commented on issue #1377: `bin/dlog` should promote user to run `mvn install` if the source is not built

sijie commented on issue #1377: `bin/dlog` should promote user to run `mvn install` if the source is not built URL: https://github.com/apache/bookkeeper/issues/1377#issuecomment-396496740 I believe this has been addressed by 7446d5c5d999c88de3cf2b9a36d793295c751a91

[GitHub] sijie closed issue #1377: `bin/dlog` should promote user to run `mvn install` if the source is not built

sijie closed issue #1377: `bin/dlog` should promote user to run `mvn install` if the source is not built URL: https://github.com/apache/bookkeeper/issues/1377 This is an automated message from the Apache Git Service. To resp

[GitHub] sijie opened a new issue #1511: [website] upgrade nokogiri to be newer than 1.8.2

sijie opened a new issue #1511: [website] upgrade nokogiri to be newer than 1.8.2 URL: https://github.com/apache/bookkeeper/issues/1511 asf infra is requesting to upgrade nokogiri to be newer than 1.8.2 This is an automated m