[GitHub] [bookkeeper] lordcheng10 edited a comment on pull request #2970: fix checkAllLedgersDuration compute

2022-02-19 Thread GitBox
lordcheng10 edited a comment on pull request #2970: URL: https://github.com/apache/bookkeeper/pull/2970#issuecomment-1046163301 @zymap @hangc0276 PTAL,thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [bookkeeper] lordcheng10 commented on pull request #2970: fix checkAllLedgersDuration compute

2022-02-19 Thread GitBox
lordcheng10 commented on pull request #2970: URL: https://github.com/apache/bookkeeper/pull/2970#issuecomment-1046163301 @hangc0276 PTAL,thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [bookkeeper] lordcheng10 removed a comment on pull request #2970: fix checkAllLedgersDuration compute

2022-02-19 Thread GitBox
lordcheng10 removed a comment on pull request #2970: URL: https://github.com/apache/bookkeeper/pull/2970#issuecomment-1039770808 @eolivelli PTAL,thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [bookkeeper] lordcheng10 commented on pull request #2961: update doc RecoveryBookieService: bookie_dest has been removed

2022-02-19 Thread GitBox
lordcheng10 commented on pull request #2961: URL: https://github.com/apache/bookkeeper/pull/2961#issuecomment-1046162324 @hangc0276 PTAL,thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [bookkeeper] lordcheng10 removed a comment on pull request #2961: update doc RecoveryBookieService: bookie_dest has been removed

2022-02-19 Thread GitBox
lordcheng10 removed a comment on pull request #2961: URL: https://github.com/apache/bookkeeper/pull/2961#issuecomment-1013641259 @pkumar-singh can we merge this PR as it's been open for long -- This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [bookkeeper] lordcheng10 removed a comment on pull request #2970: fix checkAllLedgersDuration compute

2022-02-19 Thread GitBox
lordcheng10 removed a comment on pull request #2970: URL: https://github.com/apache/bookkeeper/pull/2970#issuecomment-1046162096 @hangc0276 PTAL,thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

[GitHub] [bookkeeper] lordcheng10 removed a comment on pull request #2970: fix checkAllLedgersDuration compute

2022-02-19 Thread GitBox
lordcheng10 removed a comment on pull request #2970: URL: https://github.com/apache/bookkeeper/pull/2970#issuecomment-1011784069 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [bookkeeper] lordcheng10 removed a comment on pull request #2970: fix checkAllLedgersDuration compute

2022-02-19 Thread GitBox
lordcheng10 removed a comment on pull request #2970: URL: https://github.com/apache/bookkeeper/pull/2970#issuecomment-1042930683 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [bookkeeper] lordcheng10 commented on pull request #2970: fix checkAllLedgersDuration compute

2022-02-19 Thread GitBox
lordcheng10 commented on pull request #2970: URL: https://github.com/apache/bookkeeper/pull/2970#issuecomment-1046162096 @hangc0276 PTAL,thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [bookkeeper] lordcheng10 commented on a change in pull request #3061: Optimize memory:Support shrinking in ConcurrentLongLongPairHashMap

2022-02-19 Thread GitBox
lordcheng10 commented on a change in pull request #3061: URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r810568131 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java ## @@ -220,22 +329,36 @@

[GitHub] [bookkeeper] lordcheng10 commented on pull request #3061: Optimize memory:Support shrinking in ConcurrentLongLongPairHashMap

2022-02-19 Thread GitBox
lordcheng10 commented on pull request #3061: URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1046153528 rerun failure checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [bookkeeper] hangc0276 commented on pull request #3068: Add sizeInBytes interface for ConcurrentLong map and set

2022-02-19 Thread GitBox
hangc0276 commented on pull request #3068: URL: https://github.com/apache/bookkeeper/pull/3068#issuecomment-1046133989 rerun failure checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [bookkeeper] hangc0276 commented on pull request #3060: Catch onBookieRackChange exception

2022-02-19 Thread GitBox
hangc0276 commented on pull request #3060: URL: https://github.com/apache/bookkeeper/pull/3060#issuecomment-1046133966 rerun failure checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [bookkeeper] hangc0276 commented on pull request #3069: Fix gradle publishToMavenLocal failed

2022-02-19 Thread GitBox
hangc0276 commented on pull request #3069: URL: https://github.com/apache/bookkeeper/pull/3069#issuecomment-1046133908 rerun failure checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [bookkeeper] lordcheng10 edited a comment on pull request #3061: Optimize memory:Support shrinking in ConcurrentLongLongPairHashMap

2022-02-19 Thread GitBox
lordcheng10 edited a comment on pull request #3061: URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1046082436 > Should we also do some shrinking on "clear()"? We should try to follow what ConcurrentHashMap is doing in this case. I think it is necessary to shrink

[GitHub] [bookkeeper] lordcheng10 removed a comment on pull request #3061: Optimize memory:Support shrinking in ConcurrentLongLongPairHashMap

2022-02-19 Thread GitBox
lordcheng10 removed a comment on pull request #3061: URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1046084758 rerun failure checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [bookkeeper] lordcheng10 commented on pull request #3061: Optimize memory:Support shrinking in ConcurrentLongLongPairHashMap

2022-02-19 Thread GitBox
lordcheng10 commented on pull request #3061: URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1046084758 rerun failure checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [bookkeeper] lordcheng10 commented on a change in pull request #3061: Optimize memory:Support shrinking in ConcurrentLongLongPairHashMap

2022-02-19 Thread GitBox
lordcheng10 commented on a change in pull request #3061: URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r810526127 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java ## @@ -220,22 +329,36 @@

[GitHub] [bookkeeper] lordcheng10 commented on a change in pull request #3061: Optimize memory:Support shrinking in ConcurrentLongLongPairHashMap

2022-02-19 Thread GitBox
lordcheng10 commented on a change in pull request #3061: URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r810526127 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java ## @@ -220,22 +329,36 @@

[GitHub] [bookkeeper] lordcheng10 commented on a change in pull request #3061: Optimize memory:Support shrinking in ConcurrentLongLongPairHashMap

2022-02-19 Thread GitBox
lordcheng10 commented on a change in pull request #3061: URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r810526127 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java ## @@ -220,22 +329,36 @@

[GitHub] [bookkeeper] lordcheng10 commented on pull request #3061: Optimize memory:Support shrinking in ConcurrentLongLongPairHashMap

2022-02-19 Thread GitBox
lordcheng10 commented on pull request #3061: URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1046082436 > Should we also do some shrinking on "clear()"? We should try to follow what ConcurrentHashMap is doing in this case. I think it is necessary to shrink when

[GitHub] [bookkeeper] lordcheng10 commented on a change in pull request #3061: Optimize memory:Support shrinking in ConcurrentLongLongPairHashMap

2022-02-19 Thread GitBox
lordcheng10 commented on a change in pull request #3061: URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r810524933 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java ## @@ -220,22 +329,36 @@

[GitHub] [bookkeeper] lordcheng10 commented on a change in pull request #3061: Optimize memory:Support shrinking in ConcurrentLongLongPairHashMap

2022-02-19 Thread GitBox
lordcheng10 commented on a change in pull request #3061: URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r810524933 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java ## @@ -220,22 +329,36 @@

[GitHub] [bookkeeper] merlimat commented on a change in pull request #3061: Optimize memory:Support shrinking in ConcurrentLongLongPairHashMap

2022-02-19 Thread GitBox
merlimat commented on a change in pull request #3061: URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r810522706 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java ## @@ -220,22 +329,36 @@

[GitHub] [bookkeeper] lordcheng10 edited a comment on pull request #3061: Optimize memory:Support shrinking in ConcurrentLongLongPairHashMap

2022-02-19 Thread GitBox
lordcheng10 edited a comment on pull request #3061: URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1046076041 The new changes are as follows: @eolivelli @merlimat 1.update parameters check; 2.fix newCapacity calculation when shrinking : // shrink the hashmap

[GitHub] [bookkeeper] lordcheng10 removed a comment on pull request #3061: Optimize memory:Support shrinking in ConcurrentLongLongPairHashMap

2022-02-19 Thread GitBox
lordcheng10 removed a comment on pull request #3061: URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1046045655 The new changes are as follows: 1.check if the parameter is legal; 2.fix the shrinkage condition: ①newCapacity > size: in order to prevent the

[GitHub] [bookkeeper] lordcheng10 commented on pull request #3061: Optimize memory:Support shrinking in ConcurrentLongLongPairHashMap

2022-02-19 Thread GitBox
lordcheng10 commented on pull request #3061: URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1046076041 The new changes are as follows: 1.update parameters check; 2.fix newCapacity calculation when shrinking : // shrink the hashmap rehash((int)

[GitHub] [bookkeeper] lordcheng10 commented on pull request #3061: Optimize memory:Support shrinking in ConcurrentLongLongPairHashMap

2022-02-19 Thread GitBox
lordcheng10 commented on pull request #3061: URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1046064041 rerun failure checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [bookkeeper] lordcheng10 commented on a change in pull request #3061: Optimize memory:Support shrinking in ConcurrentLongLongPairHashMap

2022-02-19 Thread GitBox
lordcheng10 commented on a change in pull request #3061: URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r810511346 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java ## @@ -220,22 +329,36 @@

[GitHub] [bookkeeper] lordcheng10 commented on a change in pull request #3061: Optimize memory:Support shrinking in ConcurrentLongLongPairHashMap

2022-02-19 Thread GitBox
lordcheng10 commented on a change in pull request #3061: URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r810511346 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java ## @@ -220,22 +329,36 @@

[GitHub] [bookkeeper] lordcheng10 commented on a change in pull request #3061: Optimize memory:Support shrinking in ConcurrentLongLongPairHashMap

2022-02-19 Thread GitBox
lordcheng10 commented on a change in pull request #3061: URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r810508304 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java ## @@ -220,22 +329,36 @@

[GitHub] [bookkeeper] lordcheng10 commented on a change in pull request #3061: Optimize memory:Support shrinking in ConcurrentLongLongPairHashMap

2022-02-19 Thread GitBox
lordcheng10 commented on a change in pull request #3061: URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r810508304 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java ## @@ -220,22 +329,36 @@

[GitHub] [bookkeeper] lordcheng10 edited a comment on pull request #3061: Optimize memory:Support shrinking in ConcurrentLongLongPairHashMap

2022-02-19 Thread GitBox
lordcheng10 edited a comment on pull request #3061: URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1046045655 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [bookkeeper] lordcheng10 edited a comment on pull request #3061: Optimize memory:Support shrinking in ConcurrentLongLongPairHashMap

2022-02-19 Thread GitBox
lordcheng10 edited a comment on pull request #3061: URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1046045655 The new changes are as follows: 1.check if the parameter is legal; 2.fix the shrinkage condition: ①newCapacity > size: in order to prevent the

[GitHub] [bookkeeper] lordcheng10 commented on a change in pull request #3061: Optimize memory:Support shrinking in ConcurrentLongLongPairHashMap

2022-02-19 Thread GitBox
lordcheng10 commented on a change in pull request #3061: URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r810509537 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java ## @@ -220,22 +329,36 @@

[GitHub] [bookkeeper] lordcheng10 edited a comment on pull request #3061: Optimize memory:Support shrinking in ConcurrentLongLongPairHashMap

2022-02-19 Thread GitBox
lordcheng10 edited a comment on pull request #3061: URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1046045655 The new changes are as follows: 1.check if the parameter is legal; 2.fix the shrinkage condition: ①newCapacity > size: in order to prevent the

[GitHub] [bookkeeper] lordcheng10 edited a comment on pull request #3061: Optimize memory:Support shrinking in ConcurrentLongLongPairHashMap

2022-02-19 Thread GitBox
lordcheng10 edited a comment on pull request #3061: URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1046045655 1.check if the parameter is legal; 2.fix the shrinkage condition: ①newCapacity > size: in order to prevent the infinite loop of rehash, newCapacity

[GitHub] [bookkeeper] lordcheng10 edited a comment on pull request #3061: Optimize memory:Support shrinking in ConcurrentLongLongPairHashMap

2022-02-19 Thread GitBox
lordcheng10 edited a comment on pull request #3061: URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1046045655 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [bookkeeper] lordcheng10 edited a comment on pull request #3061: Optimize memory:Support shrinking in ConcurrentLongLongPairHashMap

2022-02-19 Thread GitBox
lordcheng10 edited a comment on pull request #3061: URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1046045655 1.check if the parameter is legal; 2.fix the shrinkage condition: ①newCapacity > size: in order to prevent the infinite loop of rehash, newCapacity

[GitHub] [bookkeeper] lordcheng10 commented on a change in pull request #3061: Optimize memory:Support shrinking in ConcurrentLongLongPairHashMap

2022-02-19 Thread GitBox
lordcheng10 commented on a change in pull request #3061: URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r810508304 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java ## @@ -220,22 +329,36 @@

[GitHub] [bookkeeper] lordcheng10 edited a comment on pull request #3061: Optimize memory:Support shrinking in ConcurrentLongLongPairHashMap

2022-02-19 Thread GitBox
lordcheng10 edited a comment on pull request #3061: URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1046045655 1.check if the parameter is legal; 2.fix the shrinkage condition: ①newCapacity > size: in order to prevent the infinite loop of rehash, newCapacity

[GitHub] [bookkeeper] lordcheng10 commented on a change in pull request #3061: Optimize memory:Support shrinking in ConcurrentLongLongPairHashMap

2022-02-19 Thread GitBox
lordcheng10 commented on a change in pull request #3061: URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r810506743 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java ## @@ -30,6 +30,8 @@

[GitHub] [bookkeeper] lordcheng10 commented on pull request #3061: Optimize memory:Support shrinking in ConcurrentLongLongPairHashMap

2022-02-19 Thread GitBox
lordcheng10 commented on pull request #3061: URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1046045655 1.check parameters; 2.fix the shrinkage condition: ①newCapacity > size: in order to prevent the infinite loop of rehash, newCapacity should be larger than the

[GitHub] [bookkeeper] eolivelli commented on a change in pull request #3061: Optimize memory:Support shrinking in ConcurrentLongLongPairHashMap

2022-02-19 Thread GitBox
eolivelli commented on a change in pull request #3061: URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r810505974 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java ## @@ -220,22 +329,36 @@

[GitHub] [bookkeeper] hangc0276 commented on pull request #3069: Fix gradle publishToMavenLocal failed

2022-02-19 Thread GitBox
hangc0276 commented on pull request #3069: URL: https://github.com/apache/bookkeeper/pull/3069#issuecomment-1046026362 rerun failure checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [bookkeeper] hangc0276 commented on pull request #3068: Add sizeInBytes interface for ConcurrentLong map and set

2022-02-19 Thread GitBox
hangc0276 commented on pull request #3068: URL: https://github.com/apache/bookkeeper/pull/3068#issuecomment-1046026321 rerun failure checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [bookkeeper] lordcheng10 edited a comment on pull request #3061: Optimize memory:Support shrinking in ConcurrentLongLongPairHashMap

2022-02-19 Thread GitBox
lordcheng10 edited a comment on pull request #3061: URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1046021777 PTAL,thanks! @eolivelli @merlimat 1.Added the following method to facilitate updating parameter values: ①setMapFillFactor ②setMapIdleFactor

[GitHub] [bookkeeper] lordcheng10 commented on pull request #3061: Optimize memory:Support shrinking in ConcurrentLongLongPairHashMap

2022-02-19 Thread GitBox
lordcheng10 commented on pull request #3061: URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1046021777 PTAL,thanks! @eolivelli @merlimat Added the following method to facilitate updating parameter values: ①setMapFillFactor ②setMapIdleFactor

[GitHub] [bookkeeper] lordcheng10 removed a comment on pull request #3061: Optimize memory:Support shrinking in ConcurrentLongLongPairHashMap

2022-02-19 Thread GitBox
lordcheng10 removed a comment on pull request #3061: URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1046015696 PTAL,thanks! @eolivelli @merlimat Added the following method to facilitate updating parameter values: ①setMapFillFactor ②setMapIdleFactor

[GitHub] [bookkeeper] lordcheng10 commented on pull request #3061: Optimize memory:Support shrinking in ConcurrentLongLongPairHashMap

2022-02-19 Thread GitBox
lordcheng10 commented on pull request #3061: URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1046015696 PTAL,thanks! @eolivelli @merlimat Added the following method to facilitate updating parameter values: ①setMapFillFactor ②setMapIdleFactor

[GitHub] [bookkeeper] lordcheng10 removed a comment on pull request #3061: Optimize memory:Support shrinking in ConcurrentLongLongPairHashMap

2022-02-19 Thread GitBox
lordcheng10 removed a comment on pull request #3061: URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1046014089 PTAL,thanks! @eolivelli @merlimat Added the following method to facilitate updating parameter values: ①setMapFillFactor ②setMapIdleFactor

[GitHub] [bookkeeper] lordcheng10 commented on pull request #3061: Optimize memory:Support shrinking in ConcurrentLongLongPairHashMap

2022-02-19 Thread GitBox
lordcheng10 commented on pull request #3061: URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1046014089 PTAL,thanks! @eolivelli @merlimat Added the following method to facilitate updating parameter values: ①setMapFillFactor ②setMapIdleFactor

[GitHub] [bookkeeper] hangc0276 commented on pull request #3068: Add sizeInBytes interface for ConcurrentLong map and set

2022-02-19 Thread GitBox
hangc0276 commented on pull request #3068: URL: https://github.com/apache/bookkeeper/pull/3068#issuecomment-1046008403 rerun failure checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [bookkeeper] hangc0276 commented on pull request #3068: Add sizeInBytes interface for ConcurrentLong map and set

2022-02-19 Thread GitBox
hangc0276 commented on pull request #3068: URL: https://github.com/apache/bookkeeper/pull/3068#issuecomment-1046008265 rerun failure checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [bookkeeper] hangc0276 opened a new pull request #3069: Fix gradle publishToMavenLocal failed

2022-02-19 Thread GitBox
hangc0276 opened a new pull request #3069: URL: https://github.com/apache/bookkeeper/pull/3069 ### Motivation When run command `./gradlew publishToMavenLocal` to publish jars to local maven repository, it failed with the following exception. ``` Maven publication 'maven' pom

[GitHub] [bookkeeper] hangc0276 commented on pull request #2642: fix region/rack aware placement police replace bookie bug

2022-02-19 Thread GitBox
hangc0276 commented on pull request #2642: URL: https://github.com/apache/bookkeeper/pull/2642#issuecomment-1045994252 rerun failure checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [bookkeeper] hangc0276 commented on pull request #2963: Add throttle for rebuild entryMetadataMap

2022-02-19 Thread GitBox
hangc0276 commented on pull request #2963: URL: https://github.com/apache/bookkeeper/pull/2963#issuecomment-1045994176 rerun failure checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [bookkeeper] hangc0276 commented on pull request #3046: Avoiding call fileChannelProvider init multiple times

2022-02-19 Thread GitBox
hangc0276 commented on pull request #3046: URL: https://github.com/apache/bookkeeper/pull/3046#issuecomment-1045994040 rerun failure checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [bookkeeper] hangc0276 commented on pull request #3068: Add sizeInBytes interface for ConcurrentLong map and set

2022-02-19 Thread GitBox
hangc0276 commented on pull request #3068: URL: https://github.com/apache/bookkeeper/pull/3068#issuecomment-1045993770 rerun failure checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [bookkeeper] hangc0276 commented on pull request #3060: Catch onBookieRackChange exception

2022-02-19 Thread GitBox
hangc0276 commented on pull request #3060: URL: https://github.com/apache/bookkeeper/pull/3060#issuecomment-1045993751 rerun failure checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [bookkeeper] lordcheng10 removed a comment on pull request #3061: Optimize memory:Support shrinking in ConcurrentLongLongPairHashMap

2022-02-19 Thread GitBox
lordcheng10 removed a comment on pull request #3061: URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1045968870 rerun failure checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to

[GitHub] [bookkeeper] Shoothzj removed a comment on pull request #2995: [security] Allow to enable tls on bookkeeper httpserver

2022-02-19 Thread GitBox
Shoothzj removed a comment on pull request #2995: URL: https://github.com/apache/bookkeeper/pull/2995#issuecomment-1045780449 rerun failure checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [bookkeeper] Shoothzj commented on pull request #2995: [security] Allow to enable tls on bookkeeper httpserver

2022-02-19 Thread GitBox
Shoothzj commented on pull request #2995: URL: https://github.com/apache/bookkeeper/pull/2995#issuecomment-1045985660 rerun failure checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [bookkeeper] lordcheng10 commented on pull request #3061: Optimize memory:Support shrinking in ConcurrentLongLongPairHashMap

2022-02-19 Thread GitBox
lordcheng10 commented on pull request #3061: URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1045979110 rerun failure checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [bookkeeper] lordcheng10 commented on pull request #3061: Optimize memory:Support shrinking in ConcurrentLongLongPairHashMap

2022-02-19 Thread GitBox
lordcheng10 commented on pull request #3061: URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1045971698 rerun failure checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [bookkeeper] lordcheng10 removed a comment on pull request #3061: Optimize memory:Support shrinking in ConcurrentLongLongPairHashMap

2022-02-19 Thread GitBox
lordcheng10 removed a comment on pull request #3061: URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1045774558 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [bookkeeper] lordcheng10 commented on pull request #3061: Optimize memory:Support shrinking in ConcurrentLongLongPairHashMap

2022-02-19 Thread GitBox
lordcheng10 commented on pull request #3061: URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1045968870 rerun failure checks -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the