lordcheng10 edited a comment on pull request #2970:
URL: https://github.com/apache/bookkeeper/pull/2970#issuecomment-1046163301
@zymap @hangc0276 PTAL,thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL
lordcheng10 commented on pull request #2970:
URL: https://github.com/apache/bookkeeper/pull/2970#issuecomment-1046163301
@hangc0276 PTAL,thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
lordcheng10 removed a comment on pull request #2970:
URL: https://github.com/apache/bookkeeper/pull/2970#issuecomment-1039770808
@eolivelli PTAL,thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
lordcheng10 commented on pull request #2961:
URL: https://github.com/apache/bookkeeper/pull/2961#issuecomment-1046162324
@hangc0276 PTAL,thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
lordcheng10 removed a comment on pull request #2961:
URL: https://github.com/apache/bookkeeper/pull/2961#issuecomment-1013641259
@pkumar-singh can we merge this PR as it's been open for long
--
This is an automated message from the Apache Git Service.
To respond to the message, please
lordcheng10 removed a comment on pull request #2970:
URL: https://github.com/apache/bookkeeper/pull/2970#issuecomment-1046162096
@hangc0276 PTAL,thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
lordcheng10 removed a comment on pull request #2970:
URL: https://github.com/apache/bookkeeper/pull/2970#issuecomment-1011784069
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
lordcheng10 removed a comment on pull request #2970:
URL: https://github.com/apache/bookkeeper/pull/2970#issuecomment-1042930683
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
lordcheng10 commented on pull request #2970:
URL: https://github.com/apache/bookkeeper/pull/2970#issuecomment-1046162096
@hangc0276 PTAL,thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
lordcheng10 commented on a change in pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r810568131
##
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java
##
@@ -220,22 +329,36 @@
lordcheng10 commented on pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1046153528
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
hangc0276 commented on pull request #3068:
URL: https://github.com/apache/bookkeeper/pull/3068#issuecomment-1046133989
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
hangc0276 commented on pull request #3060:
URL: https://github.com/apache/bookkeeper/pull/3060#issuecomment-1046133966
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
hangc0276 commented on pull request #3069:
URL: https://github.com/apache/bookkeeper/pull/3069#issuecomment-1046133908
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
lordcheng10 edited a comment on pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1046082436
> Should we also do some shrinking on "clear()"? We should try to follow
what ConcurrentHashMap is doing in this case.
I think it is necessary to shrink
lordcheng10 removed a comment on pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1046084758
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
lordcheng10 commented on pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1046084758
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
lordcheng10 commented on a change in pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r810526127
##
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java
##
@@ -220,22 +329,36 @@
lordcheng10 commented on a change in pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r810526127
##
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java
##
@@ -220,22 +329,36 @@
lordcheng10 commented on a change in pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r810526127
##
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java
##
@@ -220,22 +329,36 @@
lordcheng10 commented on pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1046082436
> Should we also do some shrinking on "clear()"? We should try to follow
what ConcurrentHashMap is doing in this case.
I think it is necessary to shrink when
lordcheng10 commented on a change in pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r810524933
##
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java
##
@@ -220,22 +329,36 @@
lordcheng10 commented on a change in pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r810524933
##
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java
##
@@ -220,22 +329,36 @@
merlimat commented on a change in pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r810522706
##
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java
##
@@ -220,22 +329,36 @@
lordcheng10 edited a comment on pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1046076041
The new changes are as follows: @eolivelli @merlimat
1.update parameters check;
2.fix newCapacity calculation when shrinking :
// shrink the hashmap
lordcheng10 removed a comment on pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1046045655
The new changes are as follows:
1.check if the parameter is legal;
2.fix the shrinkage condition:
①newCapacity > size: in order to prevent the
lordcheng10 commented on pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1046076041
The new changes are as follows:
1.update parameters check;
2.fix newCapacity calculation when shrinking :
// shrink the hashmap
rehash((int)
lordcheng10 commented on pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1046064041
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
lordcheng10 commented on a change in pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r810511346
##
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java
##
@@ -220,22 +329,36 @@
lordcheng10 commented on a change in pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r810511346
##
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java
##
@@ -220,22 +329,36 @@
lordcheng10 commented on a change in pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r810508304
##
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java
##
@@ -220,22 +329,36 @@
lordcheng10 commented on a change in pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r810508304
##
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java
##
@@ -220,22 +329,36 @@
lordcheng10 edited a comment on pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1046045655
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
lordcheng10 edited a comment on pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1046045655
The new changes are as follows:
1.check if the parameter is legal;
2.fix the shrinkage condition:
①newCapacity > size: in order to prevent the
lordcheng10 commented on a change in pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r810509537
##
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java
##
@@ -220,22 +329,36 @@
lordcheng10 edited a comment on pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1046045655
The new changes are as follows:
1.check if the parameter is legal;
2.fix the shrinkage condition:
①newCapacity > size: in order to prevent the
lordcheng10 edited a comment on pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1046045655
1.check if the parameter is legal;
2.fix the shrinkage condition:
①newCapacity > size: in order to prevent the infinite loop of rehash,
newCapacity
lordcheng10 edited a comment on pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1046045655
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
lordcheng10 edited a comment on pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1046045655
1.check if the parameter is legal;
2.fix the shrinkage condition:
①newCapacity > size: in order to prevent the infinite loop of rehash,
newCapacity
lordcheng10 commented on a change in pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r810508304
##
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java
##
@@ -220,22 +329,36 @@
lordcheng10 edited a comment on pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1046045655
1.check if the parameter is legal;
2.fix the shrinkage condition:
①newCapacity > size: in order to prevent the infinite loop of rehash,
newCapacity
lordcheng10 commented on a change in pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r810506743
##
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java
##
@@ -30,6 +30,8 @@
lordcheng10 commented on pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1046045655
1.check parameters;
2.fix the shrinkage condition:
①newCapacity > size: in order to prevent the infinite loop of rehash,
newCapacity should be larger than the
eolivelli commented on a change in pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#discussion_r810505974
##
File path:
bookkeeper-server/src/main/java/org/apache/bookkeeper/util/collections/ConcurrentLongLongPairHashMap.java
##
@@ -220,22 +329,36 @@
hangc0276 commented on pull request #3069:
URL: https://github.com/apache/bookkeeper/pull/3069#issuecomment-1046026362
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
hangc0276 commented on pull request #3068:
URL: https://github.com/apache/bookkeeper/pull/3068#issuecomment-1046026321
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
lordcheng10 edited a comment on pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1046021777
PTAL,thanks! @eolivelli @merlimat
1.Added the following method to facilitate updating parameter values:
①setMapFillFactor
②setMapIdleFactor
lordcheng10 commented on pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1046021777
PTAL,thanks! @eolivelli @merlimat
Added the following method to facilitate updating parameter values:
①setMapFillFactor
②setMapIdleFactor
lordcheng10 removed a comment on pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1046015696
PTAL,thanks! @eolivelli @merlimat
Added the following method to facilitate updating parameter values:
①setMapFillFactor
②setMapIdleFactor
lordcheng10 commented on pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1046015696
PTAL,thanks! @eolivelli @merlimat
Added the following method to facilitate updating parameter values:
①setMapFillFactor
②setMapIdleFactor
lordcheng10 removed a comment on pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1046014089
PTAL,thanks! @eolivelli @merlimat
Added the following method to facilitate updating parameter values:
①setMapFillFactor
②setMapIdleFactor
lordcheng10 commented on pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1046014089
PTAL,thanks! @eolivelli @merlimat
Added the following method to facilitate updating parameter values:
①setMapFillFactor
②setMapIdleFactor
hangc0276 commented on pull request #3068:
URL: https://github.com/apache/bookkeeper/pull/3068#issuecomment-1046008403
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
hangc0276 commented on pull request #3068:
URL: https://github.com/apache/bookkeeper/pull/3068#issuecomment-1046008265
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
hangc0276 opened a new pull request #3069:
URL: https://github.com/apache/bookkeeper/pull/3069
### Motivation
When run command `./gradlew publishToMavenLocal` to publish jars to local
maven repository, it failed with the following exception.
```
Maven publication 'maven' pom
hangc0276 commented on pull request #2642:
URL: https://github.com/apache/bookkeeper/pull/2642#issuecomment-1045994252
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
hangc0276 commented on pull request #2963:
URL: https://github.com/apache/bookkeeper/pull/2963#issuecomment-1045994176
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
hangc0276 commented on pull request #3046:
URL: https://github.com/apache/bookkeeper/pull/3046#issuecomment-1045994040
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
hangc0276 commented on pull request #3068:
URL: https://github.com/apache/bookkeeper/pull/3068#issuecomment-1045993770
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
hangc0276 commented on pull request #3060:
URL: https://github.com/apache/bookkeeper/pull/3060#issuecomment-1045993751
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
lordcheng10 removed a comment on pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1045968870
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
Shoothzj removed a comment on pull request #2995:
URL: https://github.com/apache/bookkeeper/pull/2995#issuecomment-1045780449
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
Shoothzj commented on pull request #2995:
URL: https://github.com/apache/bookkeeper/pull/2995#issuecomment-1045985660
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
lordcheng10 commented on pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1045979110
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
lordcheng10 commented on pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1045971698
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
lordcheng10 removed a comment on pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1045774558
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific
lordcheng10 commented on pull request #3061:
URL: https://github.com/apache/bookkeeper/pull/3061#issuecomment-1045968870
rerun failure checks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
67 matches
Mail list logo