[GitHub] [bookkeeper] lhotari commented on pull request #3110: Fix ledgerEntryImpl reuse problem

2022-03-15 Thread GitBox
lhotari commented on pull request #3110: URL: https://github.com/apache/bookkeeper/pull/3110#issuecomment-1067642520 > Change the `complete` flag in LedgerEntryRequest. They are different instances. yes, I have noticed that there's 2 separate `complete` fields:

[GitHub] [bookkeeper] lhotari commented on pull request #3110: Fix ledgerEntryImpl reuse problem

2022-03-15 Thread GitBox
lhotari commented on pull request #3110: URL: https://github.com/apache/bookkeeper/pull/3110#issuecomment-1067626623 > > Thanks @congbobo184 for making this PR. > > I'm just wondering that `close` should get called once as a result of the guard by

[GitHub] [bookkeeper] lhotari commented on pull request #3110: Fix ledgerEntryImpl reuse problem

2022-03-15 Thread GitBox
lhotari commented on pull request #3110: URL: https://github.com/apache/bookkeeper/pull/3110#issuecomment-1067608248 Thanks @congbobo184 for making this PR. I'm just wondering that `close` should get called once as a result of the guard by