Build failed in Jenkins: distributedlog-nightly-build #499

See -- [...truncated 253.79 KB...] [INFO] Downloaded:

[GitHub] sijie commented on a change in pull request #677: Issue 659: Fix Checkpoint logic in SortedLedgerStorage

sijie commented on a change in pull request #677: Issue 659: Fix Checkpoint logic in SortedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/677#discussion_r153390983 ## File path:

[GitHub] reddycharan commented on a change in pull request #677: Issue 659: Fix Checkpoint logic in SortedLedgerStorage

reddycharan commented on a change in pull request #677: Issue 659: Fix Checkpoint logic in SortedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/677#discussion_r153388326 ## File path:

[GitHub] jiazhai commented on issue #547: Allow loading extra lifecycle components

jiazhai commented on issue #547: Allow loading extra lifecycle components URL: https://github.com/apache/bookkeeper/issues/547#issuecomment-347401489 #548 is for the fix This is an automated message from the Apache Git

[GitHub] reddycharan commented on a change in pull request #677: Issue 659: Fix Checkpoint logic in SortedLedgerStorage

reddycharan commented on a change in pull request #677: Issue 659: Fix Checkpoint logic in SortedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/677#discussion_r153383988 ## File path:

[GitHub] sijie commented on a change in pull request #677: Issue 659: Fix Checkpoint logic in SortedLedgerStorage

sijie commented on a change in pull request #677: Issue 659: Fix Checkpoint logic in SortedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/677#discussion_r153380301 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/SortedLedgerStorage.java

[GitHub] sijie commented on issue #677: Issue 659: Fix Checkpoint logic in SortedLedgerStorage

sijie commented on issue #677: Issue 659: Fix Checkpoint logic in SortedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/677#issuecomment-347392857 @reddycharan yes. with this change, SyncThread is not driving the checkpoint time. The decision is made by ledger storage, so it

[GitHub] sijie commented on a change in pull request #677: Issue 659: Fix Checkpoint logic in SortedLedgerStorage

sijie commented on a change in pull request #677: Issue 659: Fix Checkpoint logic in SortedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/677#discussion_r153377512 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/SyncThread.java ##

[GitHub] sijie commented on a change in pull request #677: Issue 659: Fix Checkpoint logic in SortedLedgerStorage

sijie commented on a change in pull request #677: Issue 659: Fix Checkpoint logic in SortedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/677#discussion_r153377448 ## File path:

[GitHub] reddycharan commented on a change in pull request #677: Issue 659: Fix Checkpoint logic in SortedLedgerStorage

reddycharan commented on a change in pull request #677: Issue 659: Fix Checkpoint logic in SortedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/677#discussion_r153376624 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/SyncThread.java

[GitHub] jiazhai opened a new pull request #781: Issue 780: change BK_statsProviderClass in to NullStatsProvider in Docker file

jiazhai opened a new pull request #781: Issue 780: change BK_statsProviderClass in to NullStatsProvider in Docker file URL: https://github.com/apache/bookkeeper/pull/781 Descriptions of the changes in this PR: In issue #732, we changed Makefile for Docker:

[GitHub] reddycharan commented on a change in pull request #677: Issue 659: Fix Checkpoint logic in SortedLedgerStorage

reddycharan commented on a change in pull request #677: Issue 659: Fix Checkpoint logic in SortedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/677#discussion_r153373234 ## File path:

[GitHub] jiazhai opened a new issue #780: Update Dockerfile in 4.5.1 to use org.apache.bookkeeper.stats.NullStatsProvider

jiazhai opened a new issue #780: Update Dockerfile in 4.5.1 to use org.apache.bookkeeper.stats.NullStatsProvider URL: https://github.com/apache/bookkeeper/issues/780 In issue #732, we changed Makefile for Docker: ```

[GitHub] reddycharan commented on a change in pull request #677: Issue 659: Fix Checkpoint logic in SortedLedgerStorage

reddycharan commented on a change in pull request #677: Issue 659: Fix Checkpoint logic in SortedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/677#discussion_r153363806 ## File path:

[GitHub] reddycharan commented on a change in pull request #677: Issue 659: Fix Checkpoint logic in SortedLedgerStorage

reddycharan commented on a change in pull request #677: Issue 659: Fix Checkpoint logic in SortedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/677#discussion_r153363852 ## File path:

[GitHub] reddycharan commented on a change in pull request #677: Issue 659: Fix Checkpoint logic in SortedLedgerStorage

reddycharan commented on a change in pull request #677: Issue 659: Fix Checkpoint logic in SortedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/677#discussion_r153363752 ## File path:

[GitHub] reddycharan commented on a change in pull request #677: Issue 659: Fix Checkpoint logic in SortedLedgerStorage

reddycharan commented on a change in pull request #677: Issue 659: Fix Checkpoint logic in SortedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/677#discussion_r153363806 ## File path:

[GitHub] reddycharan commented on a change in pull request #677: Issue 659: Fix Checkpoint logic in SortedLedgerStorage

reddycharan commented on a change in pull request #677: Issue 659: Fix Checkpoint logic in SortedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/677#discussion_r153363752 ## File path:

[GitHub] sijie commented on issue #774: Open should run recovery by default

sijie commented on issue #774: Open should run recovery by default URL: https://github.com/apache/bookkeeper/pull/774#issuecomment-347371758 "Personally, I consider that I know what I'm doing in this area, and I got it wrong when updating the tutorial, and I only spotted the mistake by

[GitHub] sijie commented on issue #774: Open should run recovery by default

sijie commented on issue #774: Open should run recovery by default URL: https://github.com/apache/bookkeeper/pull/774#issuecomment-347368506 @ivankelly I think this problem here is more about an assumption problem. All the points you made here assume one thing - bookkeeper can only used in

[GitHub] sijie commented on issue #775: Tests wait for client to see started bookie

sijie commented on issue #775: Tests wait for client to see started bookie URL: https://github.com/apache/bookkeeper/pull/775#issuecomment-347363435 it seems that the return type is still `CompletableFuture`? This is an

[GitHub] sijie commented on a change in pull request #677: Issue 659: Fix Checkpoint logic in SortedLedgerStorage

sijie commented on a change in pull request #677: Issue 659: Fix Checkpoint logic in SortedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/677#discussion_r153354776 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/SyncThread.java ##

[GitHub] sijie commented on a change in pull request #677: Issue 659: Fix Checkpoint logic in SortedLedgerStorage

sijie commented on a change in pull request #677: Issue 659: Fix Checkpoint logic in SortedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/677#discussion_r153354695 ## File path:

[GitHub] reddycharan commented on a change in pull request #677: Issue 659: Fix Checkpoint logic in SortedLedgerStorage

reddycharan commented on a change in pull request #677: Issue 659: Fix Checkpoint logic in SortedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/677#discussion_r153337234 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/bookie/SyncThread.java

[GitHub] ivankelly commented on issue #774: Open should run recovery by default

ivankelly commented on issue #774: Open should run recovery by default URL: https://github.com/apache/bookkeeper/pull/774#issuecomment-347342147 > when you are migrating your App you will have test cases I hope This kind of error could easily be missed by tests, especially if

[GitHub] ivankelly commented on issue #774: Open should run recovery by default

ivankelly commented on issue #774: Open should run recovery by default URL: https://github.com/apache/bookkeeper/pull/774#issuecomment-347340792 > This is not a default case, this is a special case where the new writer needs to know it is fencing. This is the only case that must

[GitHub] jvrao commented on issue #774: Open should run recovery by default

jvrao commented on issue #774: Open should run recovery by default URL: https://github.com/apache/bookkeeper/pull/774#issuecomment-347337626 > A writer fails so another writer wants to take over. They do a non-recovery open on the last ledger > in the stream, read all the entries, and

[GitHub] jvrao commented on issue #774: Open should run recovery by default

jvrao commented on issue #774: Open should run recovery by default URL: https://github.com/apache/bookkeeper/pull/774#issuecomment-347337626 > A writer fails so another writer wants to take over. They do a non-recovery open on the last ledger > in the stream, read all the entries, and

[GitHub] ivankelly commented on issue #774: Open should run recovery by default

ivankelly commented on issue #774: Open should run recovery by default URL: https://github.com/apache/bookkeeper/pull/774#issuecomment-347140907 @jvrao > non-recovery: default > If the caller doesn't know what they are doing, the ledger may never get sealed. > What is

[GitHub] eolivelli commented on issue #774: Open should run recovery by default

eolivelli commented on issue #774: Open should run recovery by default URL: https://github.com/apache/bookkeeper/pull/774#issuecomment-347334346 @ivankelly when you are migrating your App you will have test cases I hope. I think that 'easy to use' depends on the case. If you are writing

[GitHub] reddycharan commented on a change in pull request #677: Issue 659: Fix Checkpoint logic in SortedLedgerStorage

reddycharan commented on a change in pull request #677: Issue 659: Fix Checkpoint logic in SortedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/677#discussion_r153326423 ## File path:

[GitHub] ivankelly commented on issue #774: Open should run recovery by default

ivankelly commented on issue #774: Open should run recovery by default URL: https://github.com/apache/bookkeeper/pull/774#issuecomment-347140907 @jvrao > non-recovery: default > If the caller doesn't know what they are doing, the ledger may never get sealed. > What is

[GitHub] ivankelly commented on issue #774: Open should run recovery by default

ivankelly commented on issue #774: Open should run recovery by default URL: https://github.com/apache/bookkeeper/pull/774#issuecomment-347329315 @eolivelli "When you are using BK you know what you are doing" & "they will read carefully the docs" are both counter to being easy to use.

[GitHub] acoburn opened a new pull request #779: Issue 230: Enable Checkstyle on the tls package

acoburn opened a new pull request #779: Issue 230: Enable Checkstyle on the tls package URL: https://github.com/apache/bookkeeper/pull/779 This is part of #230 and adds Checkstyle verification to the TLS package in `bookkeeper-server`.

[GitHub] eolivelli commented on a change in pull request #777: Issue-689 improve release guide for minor versions

eolivelli commented on a change in pull request #777: Issue-689 improve release guide for minor versions URL: https://github.com/apache/bookkeeper/pull/777#discussion_r153285124 ## File path: site/community/release_guide.md ## @@ -447,6 +450,18 @@ Once all issues have

[GitHub] eolivelli commented on a change in pull request #777: Issue-689 improve release guide for minor versions

eolivelli commented on a change in pull request #777: Issue-689 improve release guide for minor versions URL: https://github.com/apache/bookkeeper/pull/777#discussion_r153285124 ## File path: site/community/release_guide.md ## @@ -447,6 +450,18 @@ Once all issues have

[GitHub] eolivelli commented on a change in pull request #777: Issue-689 improve release guide for minor versions

eolivelli commented on a change in pull request #777: Issue-689 improve release guide for minor versions URL: https://github.com/apache/bookkeeper/pull/777#discussion_r153284757 ## File path: site/community/release_guide.md ## @@ -447,6 +450,18 @@ Once all issues have

[GitHub] eolivelli commented on a change in pull request #777: Issue-689 improve release guide for minor versions

eolivelli commented on a change in pull request #777: Issue-689 improve release guide for minor versions URL: https://github.com/apache/bookkeeper/pull/777#discussion_r153284382 ## File path: site/community/release_guide.md ## @@ -234,21 +244,14 @@ Use Maven release

[GitHub] sijie commented on a change in pull request #677: Issue 659: Fix Checkpoint logic in SortedLedgerStorage

sijie commented on a change in pull request #677: Issue 659: Fix Checkpoint logic in SortedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/677#discussion_r153283583 ## File path:

[GitHub] reddycharan commented on issue #677: Issue 659: Fix Checkpoint logic in SortedLedgerStorage

reddycharan commented on issue #677: Issue 659: Fix Checkpoint logic in SortedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/677#issuecomment-347277148 reviewing it now. Thanks This is an automated message from

[GitHub] sijie commented on a change in pull request #777: Issue-689 improve release guide for minor versions

sijie commented on a change in pull request #777: Issue-689 improve release guide for minor versions URL: https://github.com/apache/bookkeeper/pull/777#discussion_r153277803 ## File path: site/community/release_guide.md ## @@ -447,6 +450,18 @@ Once all issues have been

[GitHub] sijie commented on a change in pull request #777: Issue-689 improve release guide for minor versions

sijie commented on a change in pull request #777: Issue-689 improve release guide for minor versions URL: https://github.com/apache/bookkeeper/pull/777#discussion_r153277291 ## File path: site/community/release_guide.md ## @@ -234,21 +244,14 @@ Use Maven release plugin to

Build failed in Jenkins: bookkeeper-master #1956

See Changes: [sijie] Make LedgerEntries an Iterable -- [...truncated 47.17 KB...] Tests run: 11, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 2.01 sec - in

[GitHub] eolivelli commented on issue #774: Open should run recovery by default

eolivelli commented on issue #774: Open should run recovery by default URL: https://github.com/apache/bookkeeper/pull/774#issuecomment-347183565 I think that the core of BK is fencing/recovery + LAC, they are pretty unique and amazing features. When you are using BK you know what you

[GitHub] ivankelly commented on issue #776: Issue 709: Add Slow Bookkeeper Servers to Placement Policy for read ordering

ivankelly commented on issue #776: Issue 709: Add Slow Bookkeeper Servers to Placement Policy for read ordering URL: https://github.com/apache/bookkeeper/pull/776#issuecomment-347155716 @philipsu522 @sijie > Maintain a list of slow bookkeeper hosts, which are tried only after

[GitHub] ivankelly closed pull request #773: Shade bookkeeper-common into bookkeeper-server

ivankelly closed pull request #773: Shade bookkeeper-common into bookkeeper-server URL: https://github.com/apache/bookkeeper/pull/773 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] ivankelly commented on issue #773: Shade bookkeeper-common into bookkeeper-server

ivankelly commented on issue #773: Shade bookkeeper-common into bookkeeper-server URL: https://github.com/apache/bookkeeper/pull/773#issuecomment-347155202 #772 also solves this now, so closing. We should revisit shading when we break the bookkeeper client out from the server.

[GitHub] ivankelly commented on issue #775: Tests wait for client to see started bookie

ivankelly commented on issue #775: Tests wait for client to see started bookie URL: https://github.com/apache/bookkeeper/pull/775#issuecomment-347137996 Updated to use ```CompletableFuture``` This is an automated message from

[GitHub] ivankelly commented on issue #775: Tests wait for client to see started bookie

ivankelly commented on issue #775: Tests wait for client to see started bookie URL: https://github.com/apache/bookkeeper/pull/775#issuecomment-347137996 Updated to use CompletableFuture This is an automated message from the

[GitHub] eolivelli commented on a change in pull request #777: Issue-689 improve release guide for minor versions

eolivelli commented on a change in pull request #777: Issue-689 improve release guide for minor versions URL: https://github.com/apache/bookkeeper/pull/777#discussion_r153153890 ## File path: site/community/release_guide.md ## @@ -447,6 +450,18 @@ Once all issues have

[GitHub] eolivelli commented on a change in pull request #777: Issue-689 improve release guide for minor versions

eolivelli commented on a change in pull request #777: Issue-689 improve release guide for minor versions URL: https://github.com/apache/bookkeeper/pull/777#discussion_r153153182 ## File path: site/community/release_guide.md ## @@ -378,10 +381,10 @@ Start the

[GitHub] ivankelly commented on issue #771: Don't require password to create or open ledgers

ivankelly commented on issue #771: Don't require password to create or open ledgers URL: https://github.com/apache/bookkeeper/pull/771#issuecomment-347130080 I don't feel strongly about this one, so closing. This is an

[GitHub] ivankelly closed pull request #771: Don't require password to create or open ledgers

ivankelly closed pull request #771: Don't require password to create or open ledgers URL: https://github.com/apache/bookkeeper/pull/771 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is

[GitHub] ivankelly commented on a change in pull request #760: BP-20: Github workflow for bookkeeper proposals

ivankelly commented on a change in pull request #760: BP-20: Github workflow for bookkeeper proposals URL: https://github.com/apache/bookkeeper/pull/760#discussion_r153146882 ## File path: site/community/bookkeeper_proposals.md ## @@ -0,0 +1,107 @@ +--- +title: BookKeeper

[GitHub] ivankelly commented on a change in pull request #677: Issue 659: Fix Checkpoint logic in SortedLedgerStorage

ivankelly commented on a change in pull request #677: Issue 659: Fix Checkpoint logic in SortedLedgerStorage URL: https://github.com/apache/bookkeeper/pull/677#discussion_r153144509 ## File path: