[GitHub] jvrao commented on a change in pull request #1121: [Merge Yahoo repo]: AsyncReadLastEntry should trigger callback with error when ledger is empty

jvrao commented on a change in pull request #1121: [Merge Yahoo repo]: AsyncReadLastEntry should trigger callback with error when ledger is empty URL: https://github.com/apache/bookkeeper/pull/1121#discussion_r168089437 ## File path:

[GitHub] jiazhai commented on issue #1121: [Merge Yahoo repo]: AsyncReadLastEntry should trigger callback with error when ledger is empty

jiazhai commented on issue #1121: [Merge Yahoo repo]: AsyncReadLastEntry should trigger callback with error when ledger is empty URL: https://github.com/apache/bookkeeper/pull/1121#issuecomment-365487833 @sijie Thanks for the comments. changed the code. CI failure seems caused by other

[GitHub] kishorvpatil commented on issue #1125: Issue #1124: Lower memory usage in GarbageCollectionThread while extracting all ledger meta data

kishorvpatil commented on issue #1125: Issue #1124: Lower memory usage in GarbageCollectionThread while extracting all ledger meta data URL: https://github.com/apache/bookkeeper/pull/1125#issuecomment-365485471 @eolivelli Sorry for delay on this. i have fixed the checkstyle issue and

[GitHub] kishorvpatil commented on issue #1125: Issue #1124: Lower memory usage in GarbageCollectionThread while extracting all ledger meta data

kishorvpatil commented on issue #1125: Issue #1124: Lower memory usage in GarbageCollectionThread while extracting all ledger meta data URL: https://github.com/apache/bookkeeper/pull/1125#issuecomment-365485584 @sijie Removing teardown requires ensure we run this particular test always

[GitHub] sijie commented on a change in pull request #1121: [Merge Yahoo repo]: AsyncReadLastEntry should trigger callback with error when ledger is empty

sijie commented on a change in pull request #1121: [Merge Yahoo repo]: AsyncReadLastEntry should trigger callback with error when ledger is empty URL: https://github.com/apache/bookkeeper/pull/1121#discussion_r167386207 ## File path:

[GitHub] sijie commented on a change in pull request #1121: [Merge Yahoo repo]: AsyncReadLastEntry should trigger callback with error when ledger is empty

sijie commented on a change in pull request #1121: [Merge Yahoo repo]: AsyncReadLastEntry should trigger callback with error when ledger is empty URL: https://github.com/apache/bookkeeper/pull/1121#discussion_r167386849 ## File path:

[GitHub] sijie commented on a change in pull request #1121: [Merge Yahoo repo]: AsyncReadLastEntry should trigger callback with error when ledger is empty

sijie commented on a change in pull request #1121: [Merge Yahoo repo]: AsyncReadLastEntry should trigger callback with error when ledger is empty URL: https://github.com/apache/bookkeeper/pull/1121#discussion_r167386297 ## File path:

[GitHub] sijie commented on a change in pull request #1121: [Merge Yahoo repo]: AsyncReadLastEntry should trigger callback with error when ledger is empty

sijie commented on a change in pull request #1121: [Merge Yahoo repo]: AsyncReadLastEntry should trigger callback with error when ledger is empty URL: https://github.com/apache/bookkeeper/pull/1121#discussion_r167386280 ## File path:

[GitHub] jvrao commented on a change in pull request #1140: Issue 1139: Add debug to replication fencing

jvrao commented on a change in pull request #1140: Issue 1139: Add debug to replication fencing URL: https://github.com/apache/bookkeeper/pull/1140#discussion_r167447579 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/ReplicationWorker.java

[GitHub] jvrao commented on a change in pull request #1140: Issue 1139: Add debug to replication fencing

jvrao commented on a change in pull request #1140: Issue 1139: Add debug to replication fencing URL: https://github.com/apache/bookkeeper/pull/1140#discussion_r167934280 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/replication/ReplicationWorker.java

[GitHub] ivankelly closed pull request #1132: Fix shutdown race which left ZK session open

ivankelly closed pull request #1132: Fix shutdown race which left ZK session open URL: https://github.com/apache/bookkeeper/pull/1132 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a

[GitHub] ivankelly commented on issue #1132: Fix shutdown race which left ZK session open

ivankelly commented on issue #1132: Fix shutdown race which left ZK session open URL: https://github.com/apache/bookkeeper/pull/1132#issuecomment-365328837 Merging This is an automated message from the Apache Git Service.

[GitHub] ivankelly closed pull request #1145: Require green CI before merge

ivankelly closed pull request #1145: Require green CI before merge URL: https://github.com/apache/bookkeeper/pull/1145 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance: As this is a foreign pull

[GitHub] ivankelly commented on issue #1145: Require green CI before merge

ivankelly commented on issue #1145: Require green CI before merge URL: https://github.com/apache/bookkeeper/pull/1145#issuecomment-365328267 Merging This is an automated message from the Apache Git Service. To respond to the

Jenkins build is unstable: bookkeeper_postcommit_master_java9 #41

See

Jenkins build is unstable: bookkeeper_release_nightly_snapshot #58

See

[GitHub] sijie commented on a change in pull request #1137: Fix test regression due to change in default ledger manager

sijie commented on a change in pull request #1137: Fix test regression due to change in default ledger manager URL: https://github.com/apache/bookkeeper/pull/1137#discussion_r167886682 ## File path:

[GitHub] eolivelli commented on issue #1125: Issue #1124: Lower memory usage in GarbageCollectionThread while extracting all ledger meta data

eolivelli commented on issue #1125: Issue #1124: Lower memory usage in GarbageCollectionThread while extracting all ledger meta data URL: https://github.com/apache/bookkeeper/pull/1125#issuecomment-365287901 @kishorvpatil checkstyle is not passing, please check

[GitHub] eolivelli commented on a change in pull request #1125: Issue #1124: Lower memory usage in GarbageCollectionThread while extracting all ledger meta data

eolivelli commented on a change in pull request #1125: Issue #1124: Lower memory usage in GarbageCollectionThread while extracting all ledger meta data URL: https://github.com/apache/bookkeeper/pull/1125#discussion_r167884567 ## File path:

[GitHub] sijie commented on a change in pull request #1125: Issue #1124: Lower memory usage in GarbageCollectionThread while extracting all ledger meta data

sijie commented on a change in pull request #1125: Issue #1124: Lower memory usage in GarbageCollectionThread while extracting all ledger meta data URL: https://github.com/apache/bookkeeper/pull/1125#discussion_r167884231 ## File path:

Jenkins build is unstable: bookkeeper_postcommit_master_java8 #40

See

[GitHub] sijie commented on a change in pull request #1094: BP-27: New BookKeeper CLI

sijie commented on a change in pull request #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#discussion_r167881457 ## File path: bookkeeper-tools/src/main/java/org/apache/bookkeeper/tools/cli/commands/CmdBase.java ## @@ -0,0 +1,91 @@

[GitHub] sijie commented on a change in pull request #1094: BP-27: New BookKeeper CLI

sijie commented on a change in pull request #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#discussion_r167881366 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/tools/cli/helpers/DiscoveryCommand.java ## @@ -0,0

[GitHub] sijie commented on a change in pull request #1094: BP-27: New BookKeeper CLI

sijie commented on a change in pull request #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#discussion_r167880741 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/tools/cli/commands/cluster/ListBookiesCommand.java ##

[GitHub] sijie commented on a change in pull request #1094: BP-27: New BookKeeper CLI

sijie commented on a change in pull request #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#discussion_r167880214 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/tools/cli/commands/client/SimpleTestCommand.java ##

[GitHub] ivankelly commented on issue #1142: Gather disk information before CI build

ivankelly commented on issue #1142: Gather disk information before CI build URL: https://github.com/apache/bookkeeper/pull/1142#issuecomment-365281898 I want to see what the state of the disks is before we start the test. I want to see what the disks are in the case of a failure. Is the

[GitHub] sijie commented on issue #1142: Gather disk information before CI build

sijie commented on issue #1142: Gather disk information before CI build URL: https://github.com/apache/bookkeeper/pull/1142#issuecomment-365280640 do we really need this change? from the description, it sounds like more for debugging purpose. because it is unclear to me what are you going

[GitHub] ivankelly closed pull request #1137: Fix test regression due to change in default ledger manager

ivankelly closed pull request #1137: Fix test regression due to change in default ledger manager URL: https://github.com/apache/bookkeeper/pull/1137 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for the sake of provenance:

[GitHub] ivankelly commented on a change in pull request #1137: Fix test regression due to change in default ledger manager

ivankelly commented on a change in pull request #1137: Fix test regression due to change in default ledger manager URL: https://github.com/apache/bookkeeper/pull/1137#discussion_r167873701 ## File path:

[GitHub] ivankelly commented on issue #1137: Fix test regression due to change in default ledger manager

ivankelly commented on issue #1137: Fix test regression due to change in default ledger manager URL: https://github.com/apache/bookkeeper/pull/1137#issuecomment-365276490 merging this now. This is an automated message from

[GitHub] sijie commented on a change in pull request #1137: Fix test regression due to change in default ledger manager

sijie commented on a change in pull request #1137: Fix test regression due to change in default ledger manager URL: https://github.com/apache/bookkeeper/pull/1137#discussion_r167871390 ## File path:

[GitHub] sijie commented on a change in pull request #1137: Fix test regression due to change in default ledger manager

sijie commented on a change in pull request #1137: Fix test regression due to change in default ledger manager URL: https://github.com/apache/bookkeeper/pull/1137#discussion_r167871390 ## File path:

[GitHub] eolivelli closed issue #1143: Error on Java 9 using BookKeeperAdmin API and bookkeeper-server-shaded artifact

eolivelli closed issue #1143: Error on Java 9 using BookKeeperAdmin API and bookkeeper-server-shaded artifact URL: https://github.com/apache/bookkeeper/issues/1143 This is an automated message from the Apache Git Service.

[GitHub] eolivelli commented on a change in pull request #1137: Fix test regression due to change in default ledger manager

eolivelli commented on a change in pull request #1137: Fix test regression due to change in default ledger manager URL: https://github.com/apache/bookkeeper/pull/1137#discussion_r167842478 ## File path:

[GitHub] eolivelli closed pull request #1144: Issue-1143 Error on Java 9 using BookKeeperAdmin API and bookkeeper-server-shaded

eolivelli closed pull request #1144: Issue-1143 Error on Java 9 using BookKeeperAdmin API and bookkeeper-server-shaded URL: https://github.com/apache/bookkeeper/pull/1144 This is a PR merged from a forked repository. As GitHub hides the original diff on merge, it is displayed below for

[GitHub] ivankelly commented on a change in pull request #1137: Fix test regression due to change in default ledger manager

ivankelly commented on a change in pull request #1137: Fix test regression due to change in default ledger manager URL: https://github.com/apache/bookkeeper/pull/1137#discussion_r167793795 ## File path: