[GitHub] reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI

2018-02-14 Thread GitBox
reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#discussion_r168367675 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/tools/cli/commands/bookie/LastMarkCommand.java

[GitHub] reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI

2018-02-14 Thread GitBox
reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#discussion_r168366800 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/tools/cli/commands/bookie/LastMarkCommand.java

[GitHub] reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI

2018-02-14 Thread GitBox
reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#discussion_r168366800 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/tools/cli/commands/bookie/LastMarkCommand.java

[GitHub] reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI

2018-02-14 Thread GitBox
reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#discussion_r168364631 ## File path: bin/bookkeeper-cli ## @@ -0,0 +1,153 @@ +#!/usr/bin/env bash Review comment: probably not..and

[GitHub] reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI

2018-02-14 Thread GitBox
reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#discussion_r168364008 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/tools/cli/commands/bookie/LastMarkCommand.java

[GitHub] reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI

2018-02-14 Thread GitBox
reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#discussion_r168364008 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/tools/cli/commands/bookie/LastMarkCommand.java

[GitHub] reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI

2018-02-14 Thread GitBox
reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#discussion_r168356754 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/tools/cli/commands/bookie/LastMarkCommand.java

[GitHub] reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI

2018-02-14 Thread GitBox
reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#discussion_r168355576 ## File path: bin/bookkeeper-cli ## @@ -0,0 +1,153 @@ +#!/usr/bin/env bash Review comment: @sijie after

[GitHub] reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI

2018-02-14 Thread GitBox
reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#discussion_r168354161 ## File path: bin/bookkeeper-cli ## @@ -0,0 +1,153 @@ +#!/usr/bin/env bash +# +#/** +# * Copyright 2007 The Apache

[GitHub] reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI

2018-02-14 Thread GitBox
reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#discussion_r168352326 ## File path: bin/bookkeeper-cli ## @@ -0,0 +1,153 @@ +#!/usr/bin/env bash Review comment: to un this shell

[GitHub] reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI

2018-02-14 Thread GitBox
reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#discussion_r168351196 ## File path: bin/bookkeeper-cli ## @@ -0,0 +1,153 @@ +#!/usr/bin/env bash +# +#/** +# * Copyright 2007 The Apache

[GitHub] reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI

2018-02-14 Thread GitBox
reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#discussion_r168351196 ## File path: bin/bookkeeper-cli ## @@ -0,0 +1,153 @@ +#!/usr/bin/env bash +# +#/** +# * Copyright 2007 The Apache

[GitHub] reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI

2018-02-14 Thread GitBox
reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#discussion_r168351196 ## File path: bin/bookkeeper-cli ## @@ -0,0 +1,153 @@ +#!/usr/bin/env bash +# +#/** +# * Copyright 2007 The Apache

[GitHub] reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI

2018-02-12 Thread GitBox
reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#discussion_r167771438 ## File path: bookkeeper-tools/src/main/java/org/apache/bookkeeper/tools/cli/commands/CmdBase.java ## @@ -0,0

[GitHub] reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI

2018-02-12 Thread GitBox
reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#discussion_r167771081 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/tools/cli/helpers/DiscoveryCommand.java ## @@

[GitHub] reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI

2018-02-12 Thread GitBox
reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#discussion_r167770053 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/tools/cli/commands/cluster/ListBookiesCommand.java

[GitHub] reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI

2018-02-12 Thread GitBox
reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#discussion_r167766676 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/tools/cli/commands/client/SimpleTestCommand.java

[GitHub] reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI

2018-02-06 Thread GitBox
reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#discussion_r166539750 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/tools/cli/commands/cluster/ListBookiesCommand.java

[GitHub] reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI

2018-02-06 Thread GitBox
reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#discussion_r166539253 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/tools/cli/commands/client/SimpleTestCommand.java

[GitHub] reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI

2018-02-06 Thread GitBox
reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#discussion_r166536639 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/tools/cli/commands/client/SimpleTestCommand.java

[GitHub] reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI

2018-02-06 Thread GitBox
reddycharan commented on a change in pull request #1094: BP-27: New BookKeeper CLI URL: https://github.com/apache/bookkeeper/pull/1094#discussion_r166536639 ## File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/tools/cli/commands/client/SimpleTestCommand.java