[jira] [Commented] (CALCITE-3851) Replace the node importance map with a set for pruned nodes

2020-03-11 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057623#comment-17057623 ] Haisheng Yuan commented on CALCITE-3851: Yeah, make sense. > Replace the node importance map

[jira] [Commented] (CALCITE-3851) Replace the node importance map with a set for pruned nodes

2020-03-11 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057621#comment-17057621 ] Liya Fan commented on CALCITE-3851: --- [~Chunwei Lei][~hyuan] Thanks for your feedback. [~Chunwei Lei]

[jira] [Commented] (CALCITE-3815) Add missing SQL standard aggregate functions: EVERY, SOME, INTERSECTION

2020-03-11 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057616#comment-17057616 ] Feng Zhu commented on CALCITE-3815: --- {quote}_New classes and new SqlKind to be added for these

[jira] [Commented] (CALCITE-3851) Replace the node importance map with a set for pruned nodes

2020-03-11 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057595#comment-17057595 ] Haisheng Yuan commented on CALCITE-3851: In fact, with new interface SubstitutionRule, users

[jira] [Commented] (CALCITE-3852) RexSimplify doesn't simplify NOT EQUAL predicates

2020-03-11 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057584#comment-17057584 ] Chunwei Lei commented on CALCITE-3852: -- Thanks for your reply, [~kgyrtkirk]. I am wondering it

[jira] [Updated] (CALCITE-3842) RexSimplify doesn't simplify range predicates

2020-03-11 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chunwei Lei updated CALCITE-3842: - Summary: RexSimplify doesn't simplify range predicates (was: RexSimplify doesn't simplify

[jira] [Commented] (CALCITE-3851) Replace the node importance map with a set for pruned nodes

2020-03-11 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057579#comment-17057579 ] Chunwei Lei commented on CALCITE-3851: -- IMHO, the api {{setImportance}} is a little confusing.

[jira] [Updated] (CALCITE-3851) Replace the node importance map with a set for pruned nodes

2020-03-11 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3851?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Liya Fan updated CALCITE-3851: -- Summary: Replace the node importance map with a set for pruned nodes (was: Store nodes with zero

[jira] [Commented] (CALCITE-3851) Store nodes with zero importance with a set

2020-03-11 Thread Liya Fan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057576#comment-17057576 ] Liya Fan commented on CALCITE-3851: --- [~julianhyde] Thanks a lot for your feedback. I think this

[jira] [Commented] (CALCITE-3726) Allow declaring type objects

2020-03-11 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3726?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057568#comment-17057568 ] Chunwei Lei commented on CALCITE-3726: -- [~ritesh.kapoor], thank you for your pr. I think the pr

[jira] [Comment Edited] (CALCITE-3815) Add missing SQL standard aggregate functions: EVERY, SOME, INTERSECTION

2020-03-11 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057517#comment-17057517 ] Feng Zhu edited comment on CALCITE-3815 at 3/12/20, 2:42 AM: -

[jira] [Comment Edited] (CALCITE-3815) Add missing SQL standard aggregate functions: EVERY, SOME, INTERSECTION

2020-03-11 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057517#comment-17057517 ] Feng Zhu edited comment on CALCITE-3815 at 3/12/20, 2:42 AM: -

[jira] [Commented] (CALCITE-3679) Allow lambda expressions in SQL queries

2020-03-11 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3679?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057538#comment-17057538 ] Chunwei Lei commented on CALCITE-3679: -- [~ritesh.kapoor] , thank you for your contribution. I

[jira] [Updated] (CALCITE-3852) RexSimplify doesn't simplify NOT EQUAL predicates

2020-03-11 Thread ASF GitHub Bot (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] ASF GitHub Bot updated CALCITE-3852: Labels: pull-request-available (was: ) > RexSimplify doesn't simplify NOT EQUAL

[jira] [Commented] (CALCITE-3815) Add missing SQL standard aggregate functions: EVERY, SOME, INTERSECTION

2020-03-11 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057517#comment-17057517 ] Feng Zhu commented on CALCITE-3815: --- [~julianhyde], [~hanu.ncr], yes, you are right. I made something

[jira] [Commented] (CALCITE-3716) ResultSetMetaData.getTableName should return empty string, not null, when column does not map to a table

2020-03-11 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057482#comment-17057482 ] Julian Hyde commented on CALCITE-3716: -- How about we do the 'right' thing in ColumnMetaData, which

[jira] [Commented] (CALCITE-3716) ResultSetMetaData.getTableName should return empty string, not null, when column does not map to a table

2020-03-11 Thread Stamatis Zampetakis (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3716?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057444#comment-17057444 ] Stamatis Zampetakis commented on CALCITE-3716: -- I had a quick look in the PR and I was

[jira] [Commented] (CALCITE-3823) Do not use String.replaceAll

2020-03-11 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3823?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057304#comment-17057304 ] Julian Hyde commented on CALCITE-3823: -- Thanks for marking fixed, [~danny0405]. Sorry I forgot to

[jira] [Commented] (CALCITE-3815) Add missing SQL standard aggregate functions: EVERY, SOME, INTERSECTION

2020-03-11 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057288#comment-17057288 ] Julian Hyde commented on CALCITE-3815: -- [~hanu.ncr] I don't think you should even mention null.

[jira] [Commented] (CALCITE-3815) Add missing SQL standard aggregate functions: EVERY, SOME, INTERSECTION

2020-03-11 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057282#comment-17057282 ] Julian Hyde commented on CALCITE-3815: -- [~donnyzone] I think you are mistaken. MIN and EVERY

[jira] [Comment Edited] (CALCITE-3815) Add missing SQL standard aggregate functions: EVERY, SOME, INTERSECTION

2020-03-11 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057282#comment-17057282 ] Julian Hyde edited comment on CALCITE-3815 at 3/11/20, 6:05 PM:

[jira] [Commented] (CALCITE-3815) Add missing SQL standard aggregate functions: EVERY, SOME, INTERSECTION

2020-03-11 Thread Hanumath Rao Maduri (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17057138#comment-17057138 ] Hanumath Rao Maduri commented on CALCITE-3815: -- [~donnyzone] Thanks  for trying out in PG.

[jira] [Created] (CALCITE-3854) Add a rule to copy a Sort below a Correlate operator

2020-03-11 Thread Ruben Q L (Jira)
Ruben Q L created CALCITE-3854: -- Summary: Add a rule to copy a Sort below a Correlate operator Key: CALCITE-3854 URL: https://issues.apache.org/jira/browse/CALCITE-3854 Project: Calcite Issue

[jira] [Updated] (CALCITE-3854) Add a rule to copy a Sort below a Correlate operator

2020-03-11 Thread Ruben Q L (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3854?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ruben Q L updated CALCITE-3854: --- Description: Analogously to SortJoinCopyRule (introduced via CALCITE-2624), we could have a new

[jira] [Created] (CALCITE-3853) Minor improvements in SortJoinCopyRule

2020-03-11 Thread Ruben Q L (Jira)
Ruben Q L created CALCITE-3853: -- Summary: Minor improvements in SortJoinCopyRule Key: CALCITE-3853 URL: https://issues.apache.org/jira/browse/CALCITE-3853 Project: Calcite Issue Type: Task

[jira] [Commented] (CALCITE-3285) EnumerableMergeJoin should support non-equi join conditions

2020-03-11 Thread Ruben Q L (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17056997#comment-17056997 ] Ruben Q L commented on CALCITE-3285: [~zabetak], thanks for your comment. I have no problem in

[jira] [Commented] (CALCITE-3852) RexSimplify doesn't simplify NOT EQUAL predicates

2020-03-11 Thread Zoltan Haindrich (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17056969#comment-17056969 ] Zoltan Haindrich commented on CALCITE-3852: --- I always wanted to address this; but forgot :)

[jira] [Commented] (CALCITE-3852) RexSimplify doesn't simplify NOT EQUAL predicates

2020-03-11 Thread Chunwei Lei (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3852?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17056961#comment-17056961 ] Chunwei Lei commented on CALCITE-3852: -- IMO, Given {{x=9}}, {{x != 9}} can be simplified to

[jira] [Created] (CALCITE-3852) RexSimplify doesn't simplify NOT EQUAL predicates

2020-03-11 Thread Chunwei Lei (Jira)
Chunwei Lei created CALCITE-3852: Summary: RexSimplify doesn't simplify NOT EQUAL predicates Key: CALCITE-3852 URL: https://issues.apache.org/jira/browse/CALCITE-3852 Project: Calcite Issue

[jira] [Commented] (CALCITE-3842) RexSimplify doesn't simplify range predicates, as it looks at the operands in a particular order.

2020-03-11 Thread Zoltan Haindrich (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3842?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17056925#comment-17056925 ] Zoltan Haindrich commented on CALCITE-3842: --- As [~Chunwei Lei]  already explained the reason

[jira] [Closed] (CALCITE-3844) SIGSEGV error when running the example provided in calcite-avatica-go

2020-03-11 Thread Stamatis Zampetakis (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stamatis Zampetakis closed CALCITE-3844. Fix Version/s: avatica-go-5.0.0 Assignee: Francis Chuang (was: Stamatis

[jira] [Updated] (CALCITE-3844) SIGSEGV error when running the example provided in calcite-avatica-go

2020-03-11 Thread Stamatis Zampetakis (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stamatis Zampetakis updated CALCITE-3844: - Description: The example calcite-avatica-go provided always returns the

[jira] [Updated] (CALCITE-3844) when i use the example calcite-avatica-go provided, it always reports “panic: runtime error: invalid memory address or nil pointer dereference[signal SIGSEGV: segmentat

2020-03-11 Thread Stamatis Zampetakis (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stamatis Zampetakis updated CALCITE-3844: - Description: The example calcite-avatica-go provided, it always reports

[jira] [Updated] (CALCITE-3844) SIGSEGV error when running the example provided in calcite-avatica-go

2020-03-11 Thread Stamatis Zampetakis (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stamatis Zampetakis updated CALCITE-3844: - Summary: SIGSEGV error when running the example provided in calcite-avatica-go

[jira] [Reopened] (CALCITE-3844) when i use the example calcite-avatica-go provided, it always reports “panic: runtime error: invalid memory address or nil pointer dereference[signal SIGSEGV: segmenta

2020-03-11 Thread Stamatis Zampetakis (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3844?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Stamatis Zampetakis reopened CALCITE-3844: -- Assignee: Stamatis Zampetakis (was: Francis Chuang) > when i use the

[jira] [Commented] (CALCITE-3285) EnumerableMergeJoin should support non-equi join conditions

2020-03-11 Thread Stamatis Zampetakis (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3285?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17056845#comment-17056845 ] Stamatis Zampetakis commented on CALCITE-3285: -- Everybody in this discussion seem to agree

[jira] [Commented] (CALCITE-3839) After calling RelBuilder.aggregate, cannot lookup field by name

2020-03-11 Thread Anton Haidai (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3839?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17056769#comment-17056769 ] Anton Haidai commented on CALCITE-3839: --- FYI: the fix is verified on the test suite that

[jira] [Commented] (CALCITE-3851) Store nodes with zero importance with a set

2020-03-11 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3851?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17056699#comment-17056699 ] Haisheng Yuan commented on CALCITE-3851: Currently, the sole purpose of {{relImportances}} is

[jira] [Commented] (CALCITE-3815) Add missing SQL standard aggregate functions: EVERY, SOME, INTERSECTION

2020-03-11 Thread Feng Zhu (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-3815?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17056677#comment-17056677 ] Feng Zhu commented on CALCITE-3815: --- It seems that we cannot completely reuse _min/max_'s