[jira] [Commented] (CALCITE-1787) thetaSketch Support for Druid Adapter

[ https://issues.apache.org/jira/browse/CALCITE-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130883#comment-16130883 ] Jesus Camacho Rodriguez commented on CALCITE-1787: -- Thanks for catching this one

[jira] [Commented] (CALCITE-1787) thetaSketch Support for Druid Adapter

[ https://issues.apache.org/jira/browse/CALCITE-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16130816#comment-16130816 ] Zain Humayun commented on CALCITE-1787: --- [~jcamachorodriguez], it appears that {{mvn site}} fails

[jira] [Commented] (CALCITE-1787) thetaSketch Support for Druid Adapter

[ https://issues.apache.org/jira/browse/CALCITE-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16120210#comment-16120210 ] Jesus Camacho Rodriguez commented on CALCITE-1787: -- [~zhumayun], I will take a look at

[jira] [Commented] (CALCITE-1787) thetaSketch Support for Druid Adapter

[ https://issues.apache.org/jira/browse/CALCITE-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16116889#comment-16116889 ] Zain Humayun commented on CALCITE-1787: --- [~julianhyde], [~bslim], or[~jcamachorodriguez] can you

[jira] [Commented] (CALCITE-1787) thetaSketch Support for Druid Adapter

[ https://issues.apache.org/jira/browse/CALCITE-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16099153#comment-16099153 ] Zain Humayun commented on CALCITE-1787: --- Ok, it's been a while but i've submitted my updated PRs:

[jira] [Commented] (CALCITE-1787) thetaSketch Support for Druid Adapter

[ https://issues.apache.org/jira/browse/CALCITE-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16051363#comment-16051363 ] Julian Hyde commented on CALCITE-1787: -- I can't think of a case where "name" and "metricName" would

[jira] [Commented] (CALCITE-1787) thetaSketch Support for Druid Adapter

[ https://issues.apache.org/jira/browse/CALCITE-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16051261#comment-16051261 ] Zain Humayun commented on CALCITE-1787: --- wouldn't the "metricName" field need to be there to tell

[jira] [Commented] (CALCITE-1787) thetaSketch Support for Druid Adapter

[ https://issues.apache.org/jira/browse/CALCITE-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16051239#comment-16051239 ] Julian Hyde commented on CALCITE-1787: -- I would remove the "metricName" field. Consider the case

[jira] [Commented] (CALCITE-1787) thetaSketch Support for Druid Adapter

[ https://issues.apache.org/jira/browse/CALCITE-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16051104#comment-16051104 ] Zain Humayun commented on CALCITE-1787: --- Recap and some implementation questions: Columns of type

[jira] [Commented] (CALCITE-1787) thetaSketch Support for Druid Adapter

[ https://issues.apache.org/jira/browse/CALCITE-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16045079#comment-16045079 ] Julian Hyde commented on CALCITE-1787: -- Sure, you can have "user" as a dimension, in which case you

[jira] [Commented] (CALCITE-1787) thetaSketch Support for Druid Adapter

[ https://issues.apache.org/jira/browse/CALCITE-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16044886#comment-16044886 ] Zain Humayun commented on CALCITE-1787: --- Looks good to me. I've closed my PR for now, and i'll

[jira] [Commented] (CALCITE-1787) thetaSketch Support for Druid Adapter

[ https://issues.apache.org/jira/browse/CALCITE-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16044793#comment-16044793 ] Julian Hyde commented on CALCITE-1787: -- bq. +1 for the idea of abstract metric or what we call in

[jira] [Commented] (CALCITE-1787) thetaSketch Support for Druid Adapter

[ https://issues.apache.org/jira/browse/CALCITE-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16044422#comment-16044422 ] slim bouguerra commented on CALCITE-1787: - +1 for the idea of abstract metric or what we call in

[jira] [Commented] (CALCITE-1787) thetaSketch Support for Druid Adapter

[ https://issues.apache.org/jira/browse/CALCITE-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16043293#comment-16043293 ] Julian Hyde commented on CALCITE-1787: -- I was thinking of adding a new collection alongside

[jira] [Commented] (CALCITE-1787) thetaSketch Support for Druid Adapter

[ https://issues.apache.org/jira/browse/CALCITE-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16039728#comment-16039728 ] Joshua Walters commented on CALCITE-1787: - [~bslim]: Yes, our Hive users use the UDFs for

[jira] [Commented] (CALCITE-1787) thetaSketch Support for Druid Adapter

[ https://issues.apache.org/jira/browse/CALCITE-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16039640#comment-16039640 ] Julian Hyde commented on CALCITE-1787: -- Regarding [~bslim]'s proposal to use user-defined aggregate

[jira] [Commented] (CALCITE-1787) thetaSketch Support for Druid Adapter

[ https://issues.apache.org/jira/browse/CALCITE-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16039593#comment-16039593 ] slim bouguerra commented on CALCITE-1787: - my 2 cents. I think renaming is adding some

[jira] [Commented] (CALCITE-1787) thetaSketch Support for Druid Adapter

[ https://issues.apache.org/jira/browse/CALCITE-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16037871#comment-16037871 ] Zain Humayun commented on CALCITE-1787: --- [~joshwalters] I think the rename/mapping is essentially

[jira] [Commented] (CALCITE-1787) thetaSketch Support for Druid Adapter

[ https://issues.apache.org/jira/browse/CALCITE-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16037684#comment-16037684 ] Joshua Walters commented on CALCITE-1787: - The new {{user_id}} column would still be a sketch

[jira] [Commented] (CALCITE-1787) thetaSketch Support for Druid Adapter

[ https://issues.apache.org/jira/browse/CALCITE-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16037679#comment-16037679 ] slim bouguerra commented on CALCITE-1787: - am wondering what the renaming will buy us ? >

[jira] [Commented] (CALCITE-1787) thetaSketch Support for Druid Adapter

[ https://issues.apache.org/jira/browse/CALCITE-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16037670#comment-16037670 ] Joshua Walters commented on CALCITE-1787: - Another possibility, we could just do a column

[jira] [Commented] (CALCITE-1787) thetaSketch Support for Druid Adapter

[ https://issues.apache.org/jira/browse/CALCITE-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16037636#comment-16037636 ] Joshua Walters commented on CALCITE-1787: - The sketch column (theta, HLL, etc) has to exist in

[jira] [Commented] (CALCITE-1787) thetaSketch Support for Druid Adapter

[ https://issues.apache.org/jira/browse/CALCITE-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16037602#comment-16037602 ] Julian Hyde commented on CALCITE-1787: -- Another thought: would it be possible for the "user_id"

[jira] [Commented] (CALCITE-1787) thetaSketch Support for Druid Adapter

[ https://issues.apache.org/jira/browse/CALCITE-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16037598#comment-16037598 ] Julian Hyde commented on CALCITE-1787: -- Well, maybe in that case we should make the column

[jira] [Commented] (CALCITE-1787) thetaSketch Support for Druid Adapter

[ https://issues.apache.org/jira/browse/CALCITE-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16037588#comment-16037588 ] Joshua Walters commented on CALCITE-1787: - [~julianhyde] There is a problem with this approach

[jira] [Commented] (CALCITE-1787) thetaSketch Support for Druid Adapter

[ https://issues.apache.org/jira/browse/CALCITE-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16037436#comment-16037436 ] Julian Hyde commented on CALCITE-1787: -- [~zhumayun], I reviewed your pull request. I think we would

[jira] [Commented] (CALCITE-1787) thetaSketch Support for Druid Adapter

[ https://issues.apache.org/jira/browse/CALCITE-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16033414#comment-16033414 ] Julian Hyde commented on CALCITE-1787: -- Both of the following queries are valid SQL and we should

[jira] [Commented] (CALCITE-1787) thetaSketch Support for Druid Adapter

[ https://issues.apache.org/jira/browse/CALCITE-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16033138#comment-16033138 ] Julian Hyde commented on CALCITE-1787: -- I don't think that "user_unique" should appear in queries.

[jira] [Commented] (CALCITE-1787) thetaSketch Support for Druid Adapter

[ https://issues.apache.org/jira/browse/CALCITE-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16032992#comment-16032992 ] slim bouguerra commented on CALCITE-1787: - For instance if you want to query for how many

[jira] [Commented] (CALCITE-1787) thetaSketch Support for Druid Adapter

[ https://issues.apache.org/jira/browse/CALCITE-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16032985#comment-16032985 ] slim bouguerra commented on CALCITE-1787: - [~zhumayun] please read the sketch docs. 1 - Don't

[jira] [Commented] (CALCITE-1787) thetaSketch Support for Druid Adapter

[ https://issues.apache.org/jira/browse/CALCITE-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16032263#comment-16032263 ] Zain Humayun commented on CALCITE-1787: --- [~bslim] At the moment, an exception is thrown when the

[jira] [Commented] (CALCITE-1787) thetaSketch Support for Druid Adapter

[ https://issues.apache.org/jira/browse/CALCITE-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16031239#comment-16031239 ] Jesus Camacho Rodriguez commented on CALCITE-1787: -- Thanks [~bslim]. [~zhumayun],

[jira] [Commented] (CALCITE-1787) thetaSketch Support for Druid Adapter

[ https://issues.apache.org/jira/browse/CALCITE-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16031227#comment-16031227 ] slim bouguerra commented on CALCITE-1787: - As per the comments above this will produce incorrect

[jira] [Commented] (CALCITE-1787) thetaSketch Support for Druid Adapter

[ https://issues.apache.org/jira/browse/CALCITE-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16031215#comment-16031215 ] Jesus Camacho Rodriguez commented on CALCITE-1787: -- [~zhumayun], [~bslim], if I

[jira] [Commented] (CALCITE-1787) thetaSketch Support for Druid Adapter

[ https://issues.apache.org/jira/browse/CALCITE-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16031114#comment-16031114 ] slim bouguerra commented on CALCITE-1787: - [~zhumayun] in my opinion it is better to have

[jira] [Commented] (CALCITE-1787) thetaSketch Support for Druid Adapter

[ https://issues.apache.org/jira/browse/CALCITE-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16029709#comment-16029709 ] Zain Humayun commented on CALCITE-1787: --- Apologies [~julianhyde], I did not see your comment

[jira] [Commented] (CALCITE-1787) thetaSketch Support for Druid Adapter

[ https://issues.apache.org/jira/browse/CALCITE-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16025766#comment-16025766 ] slim bouguerra commented on CALCITE-1787: - Filters are applied to prune the rows before getting

[jira] [Commented] (CALCITE-1787) thetaSketch Support for Druid Adapter

[ https://issues.apache.org/jira/browse/CALCITE-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16025269#comment-16025269 ] Zain Humayun commented on CALCITE-1787: --- [~julianhyde] I've pushed a new commit addressing your

[jira] [Commented] (CALCITE-1787) thetaSketch Support for Druid Adapter

[ https://issues.apache.org/jira/browse/CALCITE-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16024992#comment-16024992 ] slim bouguerra commented on CALCITE-1787: - [~zhumayun] druid-calcite adapted does not generate

[jira] [Commented] (CALCITE-1787) thetaSketch Support for Druid Adapter

[ https://issues.apache.org/jira/browse/CALCITE-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16024982#comment-16024982 ] Zain Humayun commented on CALCITE-1787: --- [~bslim] Ahh, I see. I didn't realize store_sales was a

[jira] [Commented] (CALCITE-1787) thetaSketch Support for Druid Adapter

[ https://issues.apache.org/jira/browse/CALCITE-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16024884#comment-16024884 ] slim bouguerra commented on CALCITE-1787: - [~zhumayun] the filter is not pushed because

[jira] [Commented] (CALCITE-1787) thetaSketch Support for Druid Adapter

[ https://issues.apache.org/jira/browse/CALCITE-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023404#comment-16023404 ] Zain Humayun commented on CALCITE-1787: --- [~julianhyde] Those review comments are reasonable, i'll

[jira] [Commented] (CALCITE-1787) thetaSketch Support for Druid Adapter

[ https://issues.apache.org/jira/browse/CALCITE-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023400#comment-16023400 ] Zain Humayun commented on CALCITE-1787: --- [~bslim] that seems reasonable. So i've taken the liberty

[jira] [Commented] (CALCITE-1787) thetaSketch Support for Druid Adapter

[ https://issues.apache.org/jira/browse/CALCITE-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023275#comment-16023275 ] Julian Hyde commented on CALCITE-1787: -- Review comments: * I think you should remove

[jira] [Commented] (CALCITE-1787) thetaSketch Support for Druid Adapter

[ https://issues.apache.org/jira/browse/CALCITE-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023175#comment-16023175 ] Zain Humayun commented on CALCITE-1787: --- While I agree that post aggregations make theta sketch

[jira] [Commented] (CALCITE-1787) thetaSketch Support for Druid Adapter

[ https://issues.apache.org/jira/browse/CALCITE-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16023055#comment-16023055 ] slim bouguerra commented on CALCITE-1787: - In my opinion there is something missing here. The

[jira] [Commented] (CALCITE-1787) thetaSketch Support for Druid Adapter

[ https://issues.apache.org/jira/browse/CALCITE-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16021626#comment-16021626 ] Zain Humayun commented on CALCITE-1787: --- I've created two pull requests: 1) For calcite

[jira] [Commented] (CALCITE-1787) thetaSketch Support for Druid Adapter

[ https://issues.apache.org/jira/browse/CALCITE-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16021425#comment-16021425 ] Zain Humayun commented on CALCITE-1787: --- My aim is to write {{SELECT COUNT(DISTINCT "col") FROM

[jira] [Commented] (CALCITE-1787) thetaSketch Support for Druid Adapter

[ https://issues.apache.org/jira/browse/CALCITE-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16020575#comment-16020575 ] Julian Hyde commented on CALCITE-1787: -- Regarding 1. I'm assuming that you want to be able to write

[jira] [Commented] (CALCITE-1787) thetaSketch Support for Druid Adapter

[ https://issues.apache.org/jira/browse/CALCITE-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16012728#comment-16012728 ] Zain Humayun commented on CALCITE-1787: --- Apologies if I didn't fully understand your comment, but

[jira] [Commented] (CALCITE-1787) thetaSketch Support for Druid Adapter

[ https://issues.apache.org/jira/browse/CALCITE-1787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16008330#comment-16008330 ] Julian Hyde commented on CALCITE-1787: -- Does it need to be a new type? Can it not just be a new