[jira] [Commented] (CALCITE-1913) Include DB version in SqlDialect

2017-09-19 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16172335#comment-16172335 ] Julian Hyde commented on CALCITE-1913: -- I am modifying [~christian.beikov]'s PR so that

[jira] [Commented] (CALCITE-1913) Include DB version in SqlDialect

2017-09-18 Thread Christian Beikov (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169645#comment-16169645 ] Christian Beikov commented on CALCITE-1913: --- Can you review again now please? I updated the PR

[jira] [Commented] (CALCITE-1913) Include DB version in SqlDialect

2017-09-18 Thread Christian Beikov (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169632#comment-16169632 ] Christian Beikov commented on CALCITE-1913: --- Dependencies to {{RelDataType}} and {{SqlNode}}

[jira] [Commented] (CALCITE-1913) Include DB version in SqlDialect

2017-09-17 Thread Chris Baynes (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16169306#comment-16169306 ] Chris Baynes commented on CALCITE-1913: --- Yup, totally fine with removing Handler. The new way of

[jira] [Commented] (CALCITE-1913) Include DB version in SqlDialect

2017-09-14 Thread Abbas Gadhia (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16165966#comment-16165966 ] Abbas Gadhia commented on CALCITE-1913: --- When I wanted to find out how much support Calcite has

[jira] [Commented] (CALCITE-1913) Include DB version in SqlDialect

2017-09-10 Thread Christian Beikov (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16160312#comment-16160312 ] Christian Beikov commented on CALCITE-1913: --- What does it mean to "behave like Postgres"? For

[jira] [Commented] (CALCITE-1913) Include DB version in SqlDialect

2017-09-08 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159240#comment-16159240 ] Julian Hyde commented on CALCITE-1913: -- See my comment about "ends of the spectrum" on 1st August.

[jira] [Commented] (CALCITE-1913) Include DB version in SqlDialect

2017-09-07 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16157924#comment-16157924 ] Julian Hyde commented on CALCITE-1913: -- I like the idea of {{SqlDialectFactory}}. In PR 514 you

[jira] [Commented] (CALCITE-1913) Include DB version in SqlDialect

2017-09-07 Thread Christian Beikov (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16157280#comment-16157280 ] Christian Beikov commented on CALCITE-1913: --- I implemented part of what you describe as part

[jira] [Commented] (CALCITE-1913) Include DB version in SqlDialect

2017-08-30 Thread Jess Balint (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147964#comment-16147964 ] Jess Balint commented on CALCITE-1913: -- Removed version > Include DB version in SqlDialect >

[jira] [Commented] (CALCITE-1913) Include DB version in SqlDialect

2017-08-30 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147601#comment-16147601 ] Julian Hyde commented on CALCITE-1913: -- [~jbalint], Do you plan to work on this for 1.14? If not,

[jira] [Commented] (CALCITE-1913) Include DB version in SqlDialect

2017-08-02 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111432#comment-16111432 ] Julian Hyde commented on CALCITE-1913: -- Use your discretion and come up with a pull request. >

[jira] [Commented] (CALCITE-1913) Include DB version in SqlDialect

2017-08-02 Thread Jess Balint (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16111236#comment-16111236 ] Jess Balint commented on CALCITE-1913: -- What would you suggest at this point? > Include DB version

[jira] [Commented] (CALCITE-1913) Include DB version in SqlDialect

2017-08-01 Thread Jess Balint (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109704#comment-16109704 ] Jess Balint commented on CALCITE-1913: -- People may choose not to use a feature if it's buggy? This

[jira] [Commented] (CALCITE-1913) Include DB version in SqlDialect

2017-08-01 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109586#comment-16109586 ] Julian Hyde commented on CALCITE-1913: -- Yep, exposing the DB product was an intentional leak in the

[jira] [Commented] (CALCITE-1913) Include DB version in SqlDialect

2017-08-01 Thread Jess Balint (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16109555#comment-16109555 ] Jess Balint commented on CALCITE-1913: -- You could argue the same for exposing the DB product from