[
https://issues.apache.org/jira/browse/CALCITE-1913?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16165966#comment-16165966
]
Abbas Gadhia commented on CALCITE-1913:
---------------------------------------
When I wanted to find out how much support Calcite has for translating Hive
queries from a RelNode, all i did was a quick search for the number of places
that DatabaseProduct.HIVE was used. It gave me a rough idea of how much work is
done and how much work is left. What i did, proved to be extremely valuable for
me and therefore I think that keeping the DatabaseProduct is a good idea.
However, using the DatabaseProduct inside an "if" or a "switch" is not how it
should be used and the "capability" methods make a lot of sense instead. So i
vote for keeping the DatabaseProduct and avoid "switch statement" abuse by
"careful review" as Julian suggested.
> Include DB version in SqlDialect
> --------------------------------
>
> Key: CALCITE-1913
> URL: https://issues.apache.org/jira/browse/CALCITE-1913
> Project: Calcite
> Issue Type: Improvement
> Components: core
> Affects Versions: 1.13.0
> Reporter: Jess Balint
> Assignee: Jess Balint
> Priority: Minor
>
> It would be useful to have the DB version # in the SqlDialect for unparsing
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
