[jira] [Commented] (CALCITE-1940) Implement dialect specific support for sequences

2017-11-21 Thread Christian Beikov (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16262041#comment-16262041 ] Christian Beikov commented on CALCITE-1940: --- I haven't yet looked into the JdbcConvention

[jira] [Commented] (CALCITE-1940) Implement dialect specific support for sequences

2017-11-19 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16258809#comment-16258809 ] Julian Hyde commented on CALCITE-1940: -- [~christian.beikov], Is there any chance this change (or

[jira] [Commented] (CALCITE-1940) Implement dialect specific support for sequences

2017-09-20 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16173843#comment-16173843 ] Julian Hyde commented on CALCITE-1940: -- I've just pushed commit

[jira] [Commented] (CALCITE-1940) Implement dialect specific support for sequences

2017-09-20 Thread Christian Beikov (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16172813#comment-16172813 ] Christian Beikov commented on CALCITE-1940: --- I looked through your changes and they look good

[jira] [Commented] (CALCITE-1940) Implement dialect specific support for sequences

2017-09-10 Thread Christian Beikov (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16160314#comment-16160314 ] Christian Beikov commented on CALCITE-1940: --- [~julianhyde] I don't think it makes sense as

[jira] [Commented] (CALCITE-1940) Implement dialect specific support for sequences

2017-09-08 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16159255#comment-16159255 ] Julian Hyde commented on CALCITE-1940: -- It seems that we cannot fix this case (CALCITE-1940)

[jira] [Commented] (CALCITE-1940) Implement dialect specific support for sequences

2017-09-07 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16157306#comment-16157306 ] Julian Hyde commented on CALCITE-1940: -- Yes, I meant 1913. Thanks for the correction. > Implement

[jira] [Commented] (CALCITE-1940) Implement dialect specific support for sequences

2017-09-07 Thread Chris Baynes (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16157225#comment-16157225 ] Chris Baynes commented on CALCITE-1940: --- [~julianhyde] I think you mean

[jira] [Commented] (CALCITE-1940) Implement dialect specific support for sequences

2017-09-06 Thread Christian Beikov (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16156072#comment-16156072 ] Christian Beikov commented on CALCITE-1940: --- The idea is to encapsulate all the dialect

[jira] [Commented] (CALCITE-1940) Implement dialect specific support for sequences

2017-09-04 Thread Christian Beikov (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16152922#comment-16152922 ] Christian Beikov commented on CALCITE-1940: --- No worries. I didn't bet on this getting into

[jira] [Commented] (CALCITE-1940) Implement dialect specific support for sequences

2017-09-02 Thread Christian Beikov (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151573#comment-16151573 ] Christian Beikov commented on CALCITE-1940: --- I introduced a custom RexCall subclass since I

[jira] [Commented] (CALCITE-1940) Implement dialect specific support for sequences

2017-09-02 Thread Christian Beikov (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16151561#comment-16151561 ] Christian Beikov commented on CALCITE-1940: --- Ok I understand how that works now, I was just

[jira] [Commented] (CALCITE-1940) Implement dialect specific support for sequences

2017-08-31 Thread Chris Baynes (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16149174#comment-16149174 ] Chris Baynes commented on CALCITE-1940: --- I tried this out with postgres and noticed a problem -

[jira] [Commented] (CALCITE-1940) Implement dialect specific support for sequences

2017-08-31 Thread Christian Beikov (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16148807#comment-16148807 ] Christian Beikov commented on CALCITE-1940: --- I need the dialect since I have to call the

[jira] [Commented] (CALCITE-1940) Implement dialect specific support for sequences

2017-08-30 Thread Christian Beikov (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16148071#comment-16148071 ] Christian Beikov commented on CALCITE-1940: --- Depends on what you want changed. I was kind of

[jira] [Commented] (CALCITE-1940) Implement dialect specific support for sequences

2017-08-30 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16147982#comment-16147982 ] Julian Hyde commented on CALCITE-1940: -- Do you think we could get this done for 1.14? OK if not. >

[jira] [Commented] (CALCITE-1940) Implement dialect specific support for sequences

2017-08-23 Thread Christian Beikov (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139487#comment-16139487 ] Christian Beikov commented on CALCITE-1940: --- Seems I only use {{JdbcTable.jdbcTableName}} to

[jira] [Commented] (CALCITE-1940) Implement dialect specific support for sequences

2017-08-23 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16139445#comment-16139445 ] Julian Hyde commented on CALCITE-1940: -- Good idea. Reviewing

[jira] [Commented] (CALCITE-1940) Implement dialect specific support for sequences

2017-08-20 Thread Christian Beikov (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-1940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16134428#comment-16134428 ] Christian Beikov commented on CALCITE-1940: --- See the following PR for a fix: