[jira] [Commented] (CALCITE-2470) RelBuilder.project should combine expressions if underlying node is a Project

2018-09-22 Thread Vladimir Sitnikov (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624867#comment-16624867 ] Vladimir Sitnikov commented on CALCITE-2470: 1)Non-merged projects are required for testing

[jira] [Commented] (CALCITE-2470) RelBuilder.project should combine expressions if underlying node is a Project

2018-09-22 Thread Vladimir Sitnikov (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16624802#comment-16624802 ] Vladimir Sitnikov commented on CALCITE-2470: [~julianhyde], {{shouldMergeProject}} is

[jira] [Commented] (CALCITE-2470) RelBuilder.project should combine expressions if underlying node is a Project

2018-08-27 Thread Volodymyr Vysotskyi (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16594236#comment-16594236 ] Volodymyr Vysotskyi commented on CALCITE-2470: -- It would be good to add an ability somehow

[jira] [Commented] (CALCITE-2470) RelBuilder.project should combine expressions if underlying node is a Project

2018-08-27 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16594101#comment-16594101 ] Julian Hyde commented on CALCITE-2470: -- [~vlsi] and [~eolivelli], I do agree that Class.getFields

[jira] [Commented] (CALCITE-2470) RelBuilder.project should combine expressions if underlying node is a Project

2018-08-27 Thread Volodymyr Vysotskyi (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16593732#comment-16593732 ] Volodymyr Vysotskyi commented on CALCITE-2470: -- [~julianhyde], thanks for pointing to

[jira] [Commented] (CALCITE-2470) RelBuilder.project should combine expressions if underlying node is a Project

2018-08-27 Thread Enrico Olivelli (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16593411#comment-16593411 ] Enrico Olivelli commented on CALCITE-2470: -- The order of the result of

[jira] [Commented] (CALCITE-2470) RelBuilder.project should combine expressions if underlying node is a Project

2018-08-27 Thread Vladimir Sitnikov (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16593265#comment-16593265 ] Vladimir Sitnikov commented on CALCITE-2470: {quote}Thanks for noticing this. It looks as

[jira] [Commented] (CALCITE-2470) RelBuilder.project should combine expressions if underlying node is a Project

2018-08-27 Thread Vladimir Sitnikov (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16593242#comment-16593242 ] Vladimir Sitnikov commented on CALCITE-2470: {quote}The fieldNames argument is used here.

[jira] [Commented] (CALCITE-2470) RelBuilder.project should combine expressions if underlying node is a Project

2018-08-26 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16593045#comment-16593045 ] Julian Hyde commented on CALCITE-2470: -- bq. This agg.iq diff suspicious (the diff is GROUPING):

[jira] [Commented] (CALCITE-2470) RelBuilder.project should combine expressions if underlying node is a Project

2018-08-26 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16593042#comment-16593042 ] Julian Hyde commented on CALCITE-2470: -- bq. new RelBuilder#project seems to ignore given Iterable

[jira] [Commented] (CALCITE-2470) RelBuilder.project should combine expressions if underlying node is a Project

2018-08-26 Thread Vladimir Sitnikov (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16593037#comment-16593037 ] Vladimir Sitnikov commented on CALCITE-2470: Plan changes look good to me. This agg.iq

[jira] [Commented] (CALCITE-2470) RelBuilder.project should combine expressions if underlying node is a Project

2018-08-26 Thread Julian Hyde (JIRA)
[ https://issues.apache.org/jira/browse/CALCITE-2470?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16593010#comment-16593010 ] Julian Hyde commented on CALCITE-2470: -- My fix is ready, and all tests pass. Can someone please