[jira] [Commented] (CALCITE-4027) Add -Doverwrite option to SqlToRelTestBase

2020-10-10 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17211770#comment-17211770 ] Haisheng Yuan commented on CALCITE-4027: [~amaliujia] Can you continue on this

[jira] [Commented] (CALCITE-4027) Add -Doverwrite option to SqlToRelTestBase

2020-08-23 Thread xzh_dz (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182962#comment-17182962 ] xzh_dz commented on CALCITE-4027: - [~hyuan] A little busy recently, You can take it.

[jira] [Commented] (CALCITE-4027) Add -Doverwrite option to SqlToRelTestBase

2020-08-23 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17182820#comment-17182820 ] Haisheng Yuan commented on CALCITE-4027: [~xzh_dz] Are you still working on thi

[jira] [Commented] (CALCITE-4027) Add -Doverwrite option to SqlToRelTestBase

2020-07-08 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17153860#comment-17153860 ] Julian Hyde commented on CALCITE-4027: -- Reviewing the PR again: * Don't swallow th

[jira] [Commented] (CALCITE-4027) Add -Doverwrite option to SqlToRelTestBase

2020-06-15 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17136139#comment-17136139 ] Julian Hyde commented on CALCITE-4027: -- Reviewing the PR: * Isn't there logic else

[jira] [Commented] (CALCITE-4027) Add -Doverwrite option to SqlToRelTestBase

2020-06-13 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17135002#comment-17135002 ] Haisheng Yuan commented on CALCITE-4027: You don't need to manually update the

[jira] [Commented] (CALCITE-4027) Add -Doverwrite option to SqlToRelTestBase

2020-06-13 Thread xzh_dz (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17135001#comment-17135001 ] xzh_dz commented on CALCITE-4027: - [~hyuan] You mean that unit test actual test output

[jira] [Commented] (CALCITE-4027) Add -Doverwrite option to SqlToRelTestBase

2020-06-13 Thread Rui Wang (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134998#comment-17134998 ] Rui Wang commented on CALCITE-4027: --- I was about to work on this one but since [~xzh_

[jira] [Commented] (CALCITE-4027) Add -Doverwrite option to SqlToRelTestBase

2020-06-13 Thread Haisheng Yuan (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134997#comment-17134997 ] Haisheng Yuan commented on CALCITE-4027: [~xzh_dz] Thanks for working on this.

[jira] [Commented] (CALCITE-4027) Add -Doverwrite option to SqlToRelTestBase

2020-06-13 Thread xzh_dz (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17134996#comment-17134996 ] xzh_dz commented on CALCITE-4027: - [~hyuan] I would like to work on it. The description

[jira] [Commented] (CALCITE-4027) Add -Doverwrite option to SqlToRelTestBase

2020-05-27 Thread Julian Hyde (Jira)
[ https://issues.apache.org/jira/browse/CALCITE-4027?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17118025#comment-17118025 ] Julian Hyde commented on CALCITE-4027: -- Make sure that it works for all other test